Page MenuHomePhabricator
Feed Advanced Search

Yesterday

jkorous planned changes to D77177: [Analyzer][WebKit] RefCntblBaseVirtualDtorChecker & shared utils.

Sorry - I should have made this clear earlier so nobody waste their time reviewing current version - I'm rewriting this with ASTMatchers.

Wed, Apr 8, 2:08 PM

Mon, Apr 6

jkorous updated the diff for D77612: [ASTMatchers] Fix isDerivedFrom for recursive templates.

comment & test case

Mon, Apr 6, 6:34 PM
jkorous created D77612: [ASTMatchers] Fix isDerivedFrom for recursive templates.
Mon, Apr 6, 6:01 PM

Tue, Mar 31

jkorous updated the diff for D77177: [Analyzer][WebKit] RefCntblBaseVirtualDtorChecker & shared utils.

Fix typo in doc comment

Tue, Mar 31, 3:26 PM
jkorous added child revisions for D77177: [Analyzer][WebKit] RefCntblBaseVirtualDtorChecker & shared utils: D77178: [Analyzer][WebKit] NoUncountedMembersChecker, D77179: [Analyzer][WebKit] UncountedCallArgsChecker.
Tue, Mar 31, 2:53 PM
jkorous added a parent revision for D77178: [Analyzer][WebKit] NoUncountedMembersChecker: D77177: [Analyzer][WebKit] RefCntblBaseVirtualDtorChecker & shared utils.
Tue, Mar 31, 2:52 PM
jkorous added a parent revision for D77179: [Analyzer][WebKit] UncountedCallArgsChecker: D77177: [Analyzer][WebKit] RefCntblBaseVirtualDtorChecker & shared utils.
Tue, Mar 31, 2:52 PM
jkorous created D77179: [Analyzer][WebKit] UncountedCallArgsChecker.
Tue, Mar 31, 2:52 PM
jkorous created D77178: [Analyzer][WebKit] NoUncountedMembersChecker.
Tue, Mar 31, 2:52 PM
jkorous created D77177: [Analyzer][WebKit] RefCntblBaseVirtualDtorChecker & shared utils.
Tue, Mar 31, 2:52 PM

Thu, Mar 19

jkorous committed rG5d67fb3eccc7: [AST][NFCi] Make CXXBasePaths::Origin const (authored by jkorous).
[AST][NFCi] Make CXXBasePaths::Origin const
Thu, Mar 19, 8:05 AM

Fri, Mar 13

jkorous committed rGb7ce8fa91ed2: [LLJIT] Add std::move() as a workaround for older compilers (authored by jkorous).
[LLJIT] Add std::move() as a workaround for older compilers
Fri, Mar 13, 3:40 PM
jkorous committed rG42b782741111: [clangd] Add json::Object->Value conversion workaround for older compilers (authored by jkorous).
[clangd] Add json::Object->Value conversion workaround for older compilers
Fri, Mar 13, 2:34 PM

Mar 2 2020

jkorous abandoned D75490: [clang] Skip implicit declarations when attaching doc comments.

@erik.pilkington My bad - didn't check that.

Mar 2 2020, 6:33 PM
jkorous created D75490: [clang] Skip implicit declarations when attaching doc comments.
Mar 2 2020, 4:14 PM
jkorous accepted D75483: [Sema] Fix a crash when attaching comments to an implicit decl.

Thanks a bunch for fixing this!

Mar 2 2020, 3:39 PM · Restricted Project

Feb 20 2020

jkorous added a comment to D74746: [clang][doxygen] Fix -Wdocumentation warning for tag typedefs.

@vsapsai Sorry! I read your comment only after landing this.

Feb 20 2020, 1:55 PM · Restricted Project
jkorous committed rG2f56789c8fe8: [clang][doxygen] Fix false -Wdocumentation warning for tag typedefs (authored by jkorous).
[clang][doxygen] Fix false -Wdocumentation warning for tag typedefs
Feb 20 2020, 11:34 AM
jkorous closed D74746: [clang][doxygen] Fix -Wdocumentation warning for tag typedefs.
Feb 20 2020, 11:33 AM · Restricted Project

Feb 17 2020

jkorous added reviewers for D74746: [clang][doxygen] Fix -Wdocumentation warning for tag typedefs: sammccall, kadircet.

Apparently it's related to:

Feb 17 2020, 4:42 PM · Restricted Project
jkorous updated the diff for D74746: [clang][doxygen] Fix -Wdocumentation warning for tag typedefs.

fix test

Feb 17 2020, 4:34 PM · Restricted Project
jkorous created D74746: [clang][doxygen] Fix -Wdocumentation warning for tag typedefs.
Feb 17 2020, 4:34 PM · Restricted Project

Feb 10 2020

jkorous accepted D74371: [DirectoryWatcher] Fix misuse of FSEvents API and data race.

LGTM

Feb 10 2020, 5:54 PM · Restricted Project
jkorous committed rGefcf6430009c: Reland "[clangd][test] Disable a particular testcase in… (authored by jkorous).
Reland "[clangd][test] Disable a particular testcase in…
Feb 10 2020, 12:18 PM

Feb 5 2020

jkorous committed rG3524755a1a25: Revert "Activate extension loading test on Darwin now that the underlying fix… (authored by jkorous).
Revert "Activate extension loading test on Darwin now that the underlying fix…
Feb 5 2020, 11:14 AM
jkorous added a reverting change for rG058070893428: Activate extension loading test on Darwin now that the underlying fix has landed: rG3524755a1a25: Revert "Activate extension loading test on Darwin now that the underlying fix….
Feb 5 2020, 11:14 AM
jkorous added a comment to D71959: [PassManagerBuilder] Remove global extension when a plugin is unloaded.

@serge-sans-paille The test was still failing on macOS.

Feb 5 2020, 11:12 AM · Restricted Project

Feb 4 2020

jkorous added a reviewer for D74009: [clang] Improve diagnostic note for implicit conversions that are disallowed because they involve more than one user-defined conversion.: jkorous.

Hi @logan-5!
I suggest you split the patch into two smaller ones so it is easier to review.

Feb 4 2020, 5:17 PM · Restricted Project

Feb 3 2020

jkorous added a comment to D72100: Allow matching "any file" in `VerifyDiagnosticConsumer`..

We should either simplify the implementation to reflect that we don't support e. g. *:42 (seems preferable to me) or have the codepaths that are currently not accessible through -fverify tested by other means.

Feb 3 2020, 11:57 AM · Restricted Project

Jan 21 2020

jkorous added a reviewer for D72100: Allow matching "any file" in `VerifyDiagnosticConsumer`.: jkorous.
Jan 21 2020, 6:20 PM · Restricted Project
jkorous added inline comments to D72100: Allow matching "any file" in `VerifyDiagnosticConsumer`..
Jan 21 2020, 6:20 PM · Restricted Project

Jan 16 2020

jkorous updated the summary of D72883: [clangd][test] Disable a particular testcase in FindExplicitReferencesTest when LLVM_ENABLE_EXPENSIVE_CHECKS.
Jan 16 2020, 5:28 PM · Restricted Project
jkorous committed rG42b3c38903c9: [clangd][test] Disable a particular testcase in FindExplicitReferencesTest when… (authored by jkorous).
[clangd][test] Disable a particular testcase in FindExplicitReferencesTest when…
Jan 16 2020, 3:15 PM
jkorous closed D72883: [clangd][test] Disable a particular testcase in FindExplicitReferencesTest when LLVM_ENABLE_EXPENSIVE_CHECKS.
Jan 16 2020, 3:13 PM · Restricted Project
jkorous created D72883: [clangd][test] Disable a particular testcase in FindExplicitReferencesTest when LLVM_ENABLE_EXPENSIVE_CHECKS.
Jan 16 2020, 3:04 PM · Restricted Project

Jan 15 2020

jkorous added a comment to D72729: [clang][test] Use more widely supported sanitizer for file dependency tests.

This was meant as a post-commit review
https://github.com/llvm/llvm-project/commit/986202fad41529af8288aca54f2ff62d4c501d71

Jan 15 2020, 1:49 PM

Jan 14 2020

jkorous committed rG986202fad415: [clang][test][NFC] Use more widely supported sanitizer for file dependency tests (authored by jkorous).
[clang][test][NFC] Use more widely supported sanitizer for file dependency tests
Jan 14 2020, 12:59 PM
jkorous created D72729: [clang][test] Use more widely supported sanitizer for file dependency tests.
Jan 14 2020, 12:50 PM

Jan 10 2020

jkorous committed rGf28972facc1f: [clang] Fix out-of-bounds memory access in ComputeLineNumbers (authored by jkorous).
[clang] Fix out-of-bounds memory access in ComputeLineNumbers
Jan 10 2020, 11:27 AM
jkorous closed D72409: [clang] Fix out-of-bounds memory access in ComputeLineNumbers.
Jan 10 2020, 11:27 AM · Restricted Project

Jan 9 2020

jkorous updated the diff for D72409: [clang] Fix out-of-bounds memory access in ComputeLineNumbers.

polish test

Jan 9 2020, 3:24 PM · Restricted Project
jkorous updated the diff for D72409: [clang] Fix out-of-bounds memory access in ComputeLineNumbers.

test

Jan 9 2020, 2:28 PM · Restricted Project
jkorous added a comment to D72409: [clang] Fix out-of-bounds memory access in ComputeLineNumbers.

(and a delete[])

Jan 9 2020, 2:28 PM · Restricted Project
jkorous added a comment to D72409: [clang] Fix out-of-bounds memory access in ComputeLineNumbers.

Oh, I will just add some ASSERT to the test and a comment on what it actually tests.

Jan 9 2020, 2:28 PM · Restricted Project
jkorous added a comment to D72409: [clang] Fix out-of-bounds memory access in ComputeLineNumbers.

Ok, seems such test fails reliably (on macOS).

Jan 9 2020, 2:28 PM · Restricted Project

Jan 8 2020

jkorous updated the diff for D72409: [clang] Fix out-of-bounds memory access in ComputeLineNumbers.

calculate the size of the buffer upfront

Jan 8 2020, 4:14 PM · Restricted Project
jkorous added a comment to D72409: [clang] Fix out-of-bounds memory access in ComputeLineNumbers.

I tried but couldn't reproduce a segfault. Do you have any suggestion on how to reasonably reliably (TM) reproduce it?

Jan 8 2020, 4:14 PM · Restricted Project
jkorous created D72409: [clang] Fix out-of-bounds memory access in ComputeLineNumbers.
Jan 8 2020, 12:41 PM · Restricted Project

Dec 12 2019

jkorous committed rGffbca84f6813: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by jkorous).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Dec 12 2019, 2:52 PM
jkorous committed rGf3a25928a172: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by jkorous).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Dec 12 2019, 2:51 PM
jkorous committed rGf85af0d4fdac: Merge remote-tracking branch 'llvm.org-proper/master' into upstream-with-swift (authored by jkorous).
Merge remote-tracking branch 'llvm.org-proper/master' into upstream-with-swift
Dec 12 2019, 2:50 PM
jkorous committed rGa0f879077039: [indexstore] Add INDEXSTORE_SYMBOL_ROLE_NAMEREFERENCE (authored by jkorous).
[indexstore] Add INDEXSTORE_SYMBOL_ROLE_NAMEREFERENCE
Dec 12 2019, 2:46 PM
jkorous committed rGf3e88483aa80: [indexstore] Handle enum value SymbolRole::NameReference (authored by jkorous).
[indexstore] Handle enum value SymbolRole::NameReference
Dec 12 2019, 2:46 PM
jkorous committed rG4b5a39a09051: Merge remote-tracking branch 'llvm.org-proper/master' into upstream-with-swift (authored by jkorous).
Merge remote-tracking branch 'llvm.org-proper/master' into upstream-with-swift
Dec 12 2019, 2:44 PM
jkorous committed rG4ab21f75f7c5: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by jkorous).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Dec 12 2019, 2:42 PM
jkorous committed rG2b2c20fb1757: [clang][Index] Replace CodegenNameGenerator with ASTNameGenerator vol. III (authored by jkorous).
[clang][Index] Replace CodegenNameGenerator with ASTNameGenerator vol. III
Dec 12 2019, 2:42 PM
jkorous committed rG0972e5e1b3e2: Revert "Revert a commit series that leads to a tricky merge until Jan can take… (authored by jkorous).
Revert "Revert a commit series that leads to a tricky merge until Jan can take…
Dec 12 2019, 2:40 PM
jkorous committed rG38811eed731a: [DirectoryWatcher][NFC] Remove dead-code (authored by jkorous).
[DirectoryWatcher][NFC] Remove dead-code
Dec 12 2019, 2:19 PM
jkorous committed rG6107c172e1f3: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by jkorous).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Dec 12 2019, 2:15 PM
jkorous committed rG431d3324ada6: Merge remote-tracking branch 'llvm.org-proper/master' into upstream-with-swift (authored by jkorous).
Merge remote-tracking branch 'llvm.org-proper/master' into upstream-with-swift
Dec 12 2019, 2:13 PM
jkorous committed rGdcdc1f485e06: [IndexStore] Remove modification time (authored by jkorous).
[IndexStore] Remove modification time
Dec 12 2019, 2:13 PM
jkorous committed rG3dab785d525e: [IndexStore] Changed enum values (authored by jkorous).
[IndexStore] Changed enum values
Dec 12 2019, 2:13 PM
jkorous committed rG08d7efb59c9b: Merge remote-tracking branch 'llvm.org-proper/master' into upstream-with-swift (authored by jkorous).
Merge remote-tracking branch 'llvm.org-proper/master' into upstream-with-swift
Dec 12 2019, 2:12 PM
jkorous committed rGf9ba6ea709c4: Merge remote-tracking branch 'llvm.org/master' into HEAD (authored by jkorous).
Merge remote-tracking branch 'llvm.org/master' into HEAD
Dec 12 2019, 12:51 PM
jkorous committed rG1797ada246b3: Merge remote-tracking branch 'github/master' into HEAD (authored by jkorous).
Merge remote-tracking branch 'github/master' into HEAD
Dec 12 2019, 12:48 PM
jkorous committed rG01adc36b7fd4: Merge remote-tracking branch 'github/upstream-with-swift' into HEAD (authored by jkorous).
Merge remote-tracking branch 'github/upstream-with-swift' into HEAD
Dec 12 2019, 12:48 PM
jkorous committed rGd564605c3d80: Revert "Merge remote-tracking branch 'github/upstream-with-swift' into HEAD" (authored by jkorous).
Revert "Merge remote-tracking branch 'github/upstream-with-swift' into HEAD"
Dec 12 2019, 12:48 PM
jkorous committed rG7c104527dea9: Merge remote-tracking branch 'llvm.org/master' into HEAD (authored by jkorous).
Merge remote-tracking branch 'llvm.org/master' into HEAD
Dec 12 2019, 12:21 PM
jkorous committed rGb50764c6ace8: Merge remote-tracking branch 'llvm.org/master' into HEAD (authored by jkorous).
Merge remote-tracking branch 'llvm.org/master' into HEAD
Dec 12 2019, 12:21 PM
jkorous committed rG1e5a69077811: Fix incorrect merge conflict resolution from 68571b25294 (authored by jkorous).
Fix incorrect merge conflict resolution from 68571b25294
Dec 12 2019, 12:18 PM
jkorous committed rG7535d57c3c6b: Merge remote-tracking branch 'llvm.org/master' into 'upstream-with-swift' (authored by jkorous).
Merge remote-tracking branch 'llvm.org/master' into 'upstream-with-swift'
Dec 12 2019, 12:18 PM
jkorous committed rG67dac80a6e69: Merge remote-tracking branch 'llvm.org/master' into 'github/upstream-with-swift' (authored by jkorous).
Merge remote-tracking branch 'llvm.org/master' into 'github/upstream-with-swift'
Dec 12 2019, 12:18 PM
jkorous committed rG2b4e6c67d56a: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by jkorous).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Dec 12 2019, 12:16 PM
jkorous committed rG81a64df93a15: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by jkorous).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Dec 12 2019, 12:15 PM
jkorous committed rG9c637eafad10: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by jkorous).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Dec 12 2019, 12:15 PM
jkorous committed rGcb5481575515: Merge remote-tracking branch 'llvm.org/master' into HEAD (authored by jkorous).
Merge remote-tracking branch 'llvm.org/master' into HEAD
Dec 12 2019, 12:15 PM

Dec 4 2019

jkorous added a comment to D71029: [clangd] (take 2) Try harder to find a plausible `clang` as argv0, particularly on Mac..

The use of xcrun looks sound to me.

Dec 4 2019, 11:47 AM · Restricted Project

Dec 2 2019

jkorous added a comment to D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface.

Hi @arthurp, I can review the libclang part of the patch.

Dec 2 2019, 11:29 AM · Restricted Project

Nov 21 2019

jkorous added inline comments to D70556: clang/Modules: Refactor CompilerInstance::loadModule, NFC.
Nov 21 2019, 2:03 PM

Nov 19 2019

jkorous added inline comments to D70440: [Driver] Use VFS to check if sanitizer blacklists exist.
Nov 19 2019, 11:29 AM · Restricted Project, Restricted Project
jkorous awarded D70288: [ADT][Expensive checks] Create a /dev/random seed only once when shuffling the range before sorting it to avoid bot timeouts a Like token.
Nov 19 2019, 11:27 AM · Restricted Project
jkorous added a comment to D69648: Add VFS support for sanitizers' blacklist' 2.

Ahh, right. I originally wanted to support -ivfsoverlay in Driver as it seemed reasonable to check the existence of blacklist in Driver and open it in cc1 using the same fs. I got talked out of it and I didn't touch the Driver but seems like I should've replaced the calls to native fs with VFS to keep things consistent. Thanks for picking this up!

Nov 19 2019, 11:11 AM · Restricted Project, Restricted Project

Nov 8 2019

jkorous committed rG99e2cba219ae: Reland "[compiler-rt] Fix tests after 03b84e4f6d0" (authored by jkorous).
Reland "[compiler-rt] Fix tests after 03b84e4f6d0"
Nov 8 2019, 2:34 PM
jkorous added a reverting change for rGd6be9273c603: Revert "[compiler-rt] Fix tests after 03b84e4f6d0": rG99e2cba219ae: Reland "[compiler-rt] Fix tests after 03b84e4f6d0".
Nov 8 2019, 2:34 PM
jkorous added a reverting change for rGcae4a28864f4: Reland "[clang] Report sanitizer blacklist as a dependency in cc1": rGd52cff88367d: Revert "Reland "[clang] Report sanitizer blacklist as a dependency in cc1"".
Nov 8 2019, 2:34 PM
jkorous committed rGd52cff88367d: Revert "Reland "[clang] Report sanitizer blacklist as a dependency in cc1"" (authored by jkorous).
Revert "Reland "[clang] Report sanitizer blacklist as a dependency in cc1""
Nov 8 2019, 2:34 PM
jkorous committed rG555c6be041d4: [clang] Fix -fsanitize-system-blacklist processing in cc1 (authored by jkorous).
[clang] Fix -fsanitize-system-blacklist processing in cc1
Nov 8 2019, 2:06 PM
jkorous committed rGcae4a28864f4: Reland "[clang] Report sanitizer blacklist as a dependency in cc1" (authored by jkorous).
Reland "[clang] Report sanitizer blacklist as a dependency in cc1"
Nov 8 2019, 2:06 PM
jkorous committed rG6d28588cc0f2: Reland "[clang] Report sanitizer blacklist as a dependency in cc1" (authored by jkorous).
Reland "[clang] Report sanitizer blacklist as a dependency in cc1"
Nov 8 2019, 2:06 PM
jkorous added a reverting change for rG3182027282c5: Revert "Revert "[clang] Report sanitizer blacklist as a dependency in cc1"": rGcae4a28864f4: Reland "[clang] Report sanitizer blacklist as a dependency in cc1".
Nov 8 2019, 2:06 PM
jkorous added a reverting change for rG9b8413ac6e56: Revert "Revert "Revert "[clang] Report sanitizer blacklist as a dependency in…: rG6d28588cc0f2: Reland "[clang] Report sanitizer blacklist as a dependency in cc1".
Nov 8 2019, 2:06 PM
jkorous committed rG590f279c456b: [clang] Add VFS support for sanitizers' blacklists (authored by jkorous).
[clang] Add VFS support for sanitizers' blacklists
Nov 8 2019, 11:03 AM
jkorous closed D69648: Add VFS support for sanitizers' blacklist' 2.
Nov 8 2019, 11:03 AM · Restricted Project, Restricted Project

Nov 7 2019

jkorous committed rGbdeb2724f0aa: [compiler-rt] Fix tests after 03b84e4f6d0 (authored by jkorous).
[compiler-rt] Fix tests after 03b84e4f6d0
Nov 7 2019, 2:45 PM
jkorous committed rG03b84e4f6d0e: [clang] Report sanitizer blacklist as a dependency in cc1 (authored by jkorous).
[clang] Report sanitizer blacklist as a dependency in cc1
Nov 7 2019, 2:08 PM
jkorous closed D69290: [clang] Report sanitizer blacklist as a dependency in cc1 instead of driver.
Nov 7 2019, 2:08 PM · Restricted Project
jkorous added a comment to D69290: [clang] Report sanitizer blacklist as a dependency in cc1 instead of driver.

@pcc Could you please take a look?

Nov 7 2019, 10:47 AM · Restricted Project
jkorous added a comment to D69648: Add VFS support for sanitizers' blacklist' 2.

I am in no particular rush and happy to help you as much as I can but at some point not too far in the future I just want this to land and not get reverted.

Nov 7 2019, 10:38 AM · Restricted Project, Restricted Project

Nov 6 2019

jkorous added a comment to D69648: Add VFS support for sanitizers' blacklist' 2.

The test seems to be fine (fails on master, passes with the patch). I most probably just forgot to run it.

Nov 6 2019, 11:13 AM · Restricted Project, Restricted Project
jkorous updated the diff for D69648: Add VFS support for sanitizers' blacklist' 2.

Actually use the VFS that got passed.

Nov 6 2019, 11:13 AM · Restricted Project, Restricted Project