Page MenuHomePhabricator
Feed Advanced Search

Fri, Aug 16

jkorous added a comment to D66125: [clang] Generalize WrapperFrontendAction to support multiple actions.

I'll just leave this review here until we finish the discussion but consider it to be effectively abandoned.

Fri, Aug 16, 5:19 PM
jkorous updated the diff for D64384: [WIP] Index-while-building.

Added ASTConsumerInjector and changed `Emit|Generate-IndexAction to -ASTConsumer.

Fri, Aug 16, 1:14 PM · Restricted Project

Thu, Aug 15

jkorous accepted D61466: [Rewrite][NFC] Add FIXMEs and tests for RemoveLineIfEmpty bug.

LGTM. Thanks!

Thu, Aug 15, 11:31 AM · Restricted Project, Restricted Project

Wed, Aug 14

jkorous abandoned D61102: [clang][ASTContext][NFCi] Refactor ASTContext::getRawCommentForDeclNoCache.

Abandoned in favor of
Differential Revision: https://reviews.llvm.org/D65301

Wed, Aug 14, 3:54 PM · Restricted Project
jkorous committed rG14230f99262d: [Support][NFC] Fix error message for posix_spawn_file_actions_addopen failed… (authored by jkorous).
[Support][NFC] Fix error message for posix_spawn_file_actions_addopen failed…
Wed, Aug 14, 11:33 AM
jkorous committed rL368899: [Support][NFC] Fix error message for posix_spawn_file_actions_addopen failed….
[Support][NFC] Fix error message for posix_spawn_file_actions_addopen failed…
Wed, Aug 14, 11:29 AM

Tue, Aug 13

jkorous added inline comments to D66125: [clang] Generalize WrapperFrontendAction to support multiple actions.
Tue, Aug 13, 7:12 PM
jkorous updated the diff for D64384: [WIP] Index-while-building.

Addressed some of the comments.

Tue, Aug 13, 6:59 PM · Restricted Project
jkorous added a comment to D64384: [WIP] Index-while-building.

Thanks for the review! I addressed just some minor details so far.

Tue, Aug 13, 6:56 PM · Restricted Project
jkorous committed rG9a13852eaba3: [clang][DirectoryWatcher] Fix Windows stub after LLVM change (authored by jkorous).
[clang][DirectoryWatcher] Fix Windows stub after LLVM change
Tue, Aug 13, 3:41 PM
jkorous committed rGb724f3d4b33c: [clang] DirectoryWatcher for Windows stubs (to fix build break). (authored by jkorous).
[clang] DirectoryWatcher for Windows stubs (to fix build break).
Tue, Aug 13, 3:39 PM
jkorous committed rL368762: [clang][DirectoryWatcher] Fix Windows stub after LLVM change.
[clang][DirectoryWatcher] Fix Windows stub after LLVM change
Tue, Aug 13, 3:38 PM
jkorous committed rL368761: [clang] DirectoryWatcher for Windows stubs (to fix build break)..
[clang] DirectoryWatcher for Windows stubs (to fix build break).
Tue, Aug 13, 3:38 PM
jkorous added a reviewer for D66156: Removed dead code from clang/tools/libclang/CXIndexDataConsumer.{cpp,h}: akyrtzi.

LGTM but let's wait for @akyrtzi to confirm.

Tue, Aug 13, 2:56 PM · Restricted Project, Restricted Project
jkorous created D66172: [clang][Modules] Serialize decl to comment mapping to speed up code completion..
Tue, Aug 13, 2:34 PM
jkorous committed rGf31d8df1c8c6: [clang] Refactor doc comments to Decls attribution (authored by jkorous).
[clang] Refactor doc comments to Decls attribution
Tue, Aug 13, 11:14 AM
jkorous committed rL368732: [clang] Refactor doc comments to Decls attribution.
[clang] Refactor doc comments to Decls attribution
Tue, Aug 13, 11:10 AM
jkorous closed D65301: [clang] Refactor how are doc comments attached to Decls.
Tue, Aug 13, 11:10 AM · Restricted Project

Mon, Aug 12

jkorous added inline comments to D64384: [WIP] Index-while-building.
Mon, Aug 12, 6:55 PM · Restricted Project
jkorous created D66125: [clang] Generalize WrapperFrontendAction to support multiple actions.
Mon, Aug 12, 6:55 PM

Fri, Aug 9

jkorous accepted D66026: Make circular_raw_ostream delegate is_displayed to contained stream.

LGTM

Fri, Aug 9, 4:34 PM · Restricted Project
jkorous updated the diff for D65301: [clang] Refactor how are doc comments attached to Decls.

Addressed comments

Fri, Aug 9, 1:37 PM · Restricted Project
jkorous added inline comments to D65301: [clang] Refactor how are doc comments attached to Decls.
Fri, Aug 9, 1:34 PM · Restricted Project

Thu, Aug 8

jkorous updated the diff for D65301: [clang] Refactor how are doc comments attached to Decls.

Addressed comments & clang-formatted the patch.

Thu, Aug 8, 1:56 PM · Restricted Project
jkorous added inline comments to D65301: [clang] Refactor how are doc comments attached to Decls.
Thu, Aug 8, 1:53 PM · Restricted Project

Wed, Aug 7

jkorous updated the diff for D65301: [clang] Refactor how are doc comments attached to Decls.

searchForDocComments() -> attachCommentsToJustParsedDecls()

Wed, Aug 7, 4:43 PM · Restricted Project
jkorous added a comment to D65301: [clang] Refactor how are doc comments attached to Decls.

I still have to do the searchForDocComments -> attachCommentsToJustParsedDecls change.

Wed, Aug 7, 4:16 PM · Restricted Project
jkorous updated the diff for D65301: [clang] Refactor how are doc comments attached to Decls.

Rewrite caching of Decl -> RawComment mapping.

Wed, Aug 7, 4:12 PM · Restricted Project

Tue, Aug 6

jkorous added a comment to D65829: [clang][DirectoryWatcher][NFC] Swapping asserts for llvm fatal_error in ::create..

Thanks Puyan!

Tue, Aug 6, 4:39 PM · Restricted Project, Restricted Project
jkorous added a comment to D65829: [clang][DirectoryWatcher][NFC] Swapping asserts for llvm fatal_error in ::create..

I was about to suggest something similar. SGTM!

Tue, Aug 6, 3:00 PM · Restricted Project, Restricted Project
jkorous added inline comments to D65704: DirectoryWatcher::create: Adding better error handling..
Tue, Aug 6, 12:29 PM · Restricted Project, Restricted Project

Mon, Aug 5

jkorous added a comment to D65708: [NFC][DirectoryWatchedTests] Unlocking mutexes before signaling condition variable. .

LGTM. Thanks!

Mon, Aug 5, 5:45 PM · Restricted Project, Restricted Project
jkorous added a comment to D65704: DirectoryWatcher::create: Adding better error handling..

Please just update the comment, otherwise LGTM.

Mon, Aug 5, 5:20 PM · Restricted Project, Restricted Project
jkorous added a comment to D65704: DirectoryWatcher::create: Adding better error handling..

Thanks for the patch!

Mon, Aug 5, 5:15 PM · Restricted Project, Restricted Project
jkorous updated the diff for D65301: [clang] Refactor how are doc comments attached to Decls.

Addressed feedback (comments, naming).

Mon, Aug 5, 3:11 PM · Restricted Project
jkorous added inline comments to D65301: [clang] Refactor how are doc comments attached to Decls.
Mon, Aug 5, 3:08 PM · Restricted Project
jkorous committed rG57f4bacf65ac: [DirectoryWatcher][linux] Fix build for older kernels (authored by jkorous).
[DirectoryWatcher][linux] Fix build for older kernels
Mon, Aug 5, 11:49 AM
jkorous committed rL367906: [DirectoryWatcher][linux] Fix build for older kernels.
[DirectoryWatcher][linux] Fix build for older kernels
Mon, Aug 5, 11:43 AM

Thu, Aug 1

jkorous added a comment to D65301: [clang] Refactor how are doc comments attached to Decls.

Ping.

Thu, Aug 1, 6:36 PM · Restricted Project
jkorous committed rG9debb024d44d: [DirectoryWatcher] Relax assumption to prevent test flakiness (authored by jkorous).
[DirectoryWatcher] Relax assumption to prevent test flakiness
Thu, Aug 1, 4:27 PM
jkorous committed rL367632: [DirectoryWatcher] Relax assumption to prevent test flakiness.
[DirectoryWatcher] Relax assumption to prevent test flakiness
Thu, Aug 1, 4:24 PM
jkorous added inline comments to D65545: Handle some fs::remove failures.
Thu, Aug 1, 3:19 PM · Restricted Project, Restricted Project
jkorous accepted D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure.

Thanks for all the work here!

Thu, Aug 1, 12:47 PM · Restricted Project, Restricted Project, Restricted Project
jkorous added a comment to D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.

Hi Puyan,

Thu, Aug 1, 11:24 AM · Restricted Project, Restricted Project

Wed, Jul 31

jkorous added inline comments to D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure.
Wed, Jul 31, 6:24 PM · Restricted Project, Restricted Project, Restricted Project
jkorous added a comment to D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.

@jkorous DirectoryWatcherTests causes ninja check-clang to hang on my Ubuntu 18.04 computer. check-clang will not finish and I am forced to killall -9 DirectoryWatcherTests. My system has 40 threads and this repros on ext4 and btrfs.

Wed, Jul 31, 2:46 PM · Restricted Project, Restricted Project
jkorous added inline comments to D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure.
Wed, Jul 31, 2:28 PM · Restricted Project, Restricted Project, Restricted Project
jkorous added a reviewer for D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure: jkorous.
Wed, Jul 31, 2:28 PM · Restricted Project, Restricted Project, Restricted Project

Tue, Jul 30

jkorous committed rGc32e10794dc7: [clangd][NFC] Fix typo in comment (authored by jkorous).
[clangd][NFC] Fix typo in comment
Tue, Jul 30, 3:20 PM
jkorous committed rL367361: [clangd][NFC] Fix typo in comment.
[clangd][NFC] Fix typo in comment
Tue, Jul 30, 3:17 PM
jkorous committed rG2ee6497e8f32: [clangd][NFC] Typo in comment (authored by jkorous).
[clangd][NFC] Typo in comment
Tue, Jul 30, 1:40 PM
jkorous committed rL367354: [clangd][NFC] Typo in comment.
[clangd][NFC] Typo in comment
Tue, Jul 30, 1:39 PM
jkorous added a comment to D61466: [Rewrite][NFC] Add FIXMEs and tests for RemoveLineIfEmpty bug.

In an inline comment, you also mentioned the alternative of replacing EXPECT_EQ with EXPECT_NE. Neither solution is the XFAIL I'm used to (from lit for example).

Tue, Jul 30, 12:54 PM · Restricted Project, Restricted Project
jkorous added a comment to D65387: [clangd] Add a callback mechanism for handling responses from client..

Hi @hokein,
Do you have any thoughts on how to handle situation when client registers callback but doesn't send a request with registered ID later?

Tue, Jul 30, 11:22 AM · Restricted Project, Restricted Project

Fri, Jul 26

jkorous abandoned D61103: [clang] Add tryToAttachCommentsToDecls method to ASTContext.

Abandoned in favor of https://reviews.llvm.org/D65301

Fri, Jul 26, 11:09 AM · Restricted Project
jkorous abandoned D61104: [clang][ASTContext] Try to avoid sorting comments for code completion.

Abandoned in favor of
https://reviews.llvm.org/D65301

Fri, Jul 26, 11:09 AM · Restricted Project
jkorous added a comment to D61466: [Rewrite][NFC] Add FIXMEs and tests for RemoveLineIfEmpty bug.

Hi @jdenny, thanks for the warning! I think having the test disabled is fine - the main upside I see is that we won't check it fails over and over on our CI systems.
Could you please mention the test/reproducer in those FIXMEs?
Otherwise LGTM.

Fri, Jul 26, 11:09 AM · Restricted Project, Restricted Project

Thu, Jul 25

jkorous created D65301: [clang] Refactor how are doc comments attached to Decls.
Thu, Jul 25, 3:37 PM · Restricted Project

Wed, Jul 24

jkorous added inline comments to D65237: [Support] move FileCollector from LLDB to llvm/Support.
Wed, Jul 24, 1:00 PM · Restricted Project, Restricted Project

Tue, Jul 23

jkorous created D65187: [clang] Frontend insight remarks PoC.
Tue, Jul 23, 9:19 PM
jkorous committed rGe72321f38e34: [clang][NFCI] Fix random typos (authored by jkorous).
[clang][NFCI] Fix random typos
Tue, Jul 23, 9:56 AM
jkorous committed rL366823: [clang][NFCI] Fix random typos.
[clang][NFCI] Fix random typos
Tue, Jul 23, 9:56 AM
jkorous updated the diff for D64384: [WIP] Index-while-building.

clang-format

Tue, Jul 23, 9:47 AM · Restricted Project

Mon, Jul 22

jkorous updated the diff for D64384: [WIP] Index-while-building.

Uploaded the full diff.

Mon, Jul 22, 3:17 PM · Restricted Project
jkorous added a comment to D64384: [WIP] Index-while-building.

Thanks for taking a look Sam!

Mon, Jul 22, 3:09 PM · Restricted Project

Jul 15 2019

jkorous added a comment to D63961: [clangd][xpc] pass the LSP value using data instead of string.

I'd add a test with non-empty non-LSP dictionary to specifically test that we're ignoring the content. I like const-correctness but that's up to you. Otherwise LGTM.

Jul 15 2019, 4:31 PM · Restricted Project
jkorous committed rG60a0d49e77cf: [DirectoryWatcher][linux] Fix for older kernels (authored by jkorous).
[DirectoryWatcher][linux] Fix for older kernels
Jul 15 2019, 4:15 PM
jkorous committed rL366152: [DirectoryWatcher][linux] Fix for older kernels.
[DirectoryWatcher][linux] Fix for older kernels
Jul 15 2019, 4:13 PM
jkorous closed D64764: [DirectoryWatcher][linux] Fix build for older kernels.
Jul 15 2019, 4:13 PM · Restricted Project
jkorous committed rGc5e7a3d71009: [DirectoryWatcher][test] Relax test assumptions (authored by jkorous).
[DirectoryWatcher][test] Relax test assumptions
Jul 15 2019, 3:14 PM
jkorous committed rG5076038bb00d: [DirectoryWatcher][NFC][test] Add typedef for enum (authored by jkorous).
[DirectoryWatcher][NFC][test] Add typedef for enum
Jul 15 2019, 3:13 PM
jkorous committed rL366138: [DirectoryWatcher][test] Relax test assumptions.
[DirectoryWatcher][test] Relax test assumptions
Jul 15 2019, 3:13 PM
jkorous committed rL366137: [DirectoryWatcher][NFC][test] Add typedef for enum.
[DirectoryWatcher][NFC][test] Add typedef for enum
Jul 15 2019, 3:13 PM
jkorous created D64764: [DirectoryWatcher][linux] Fix build for older kernels.
Jul 15 2019, 11:25 AM · Restricted Project

Jul 12 2019

jkorous committed rG4765aa14ff42: [DirectoryWatcher][test][NFC] Add information to test failure reports (authored by jkorous).
[DirectoryWatcher][test][NFC] Add information to test failure reports
Jul 12 2019, 5:09 PM
jkorous committed rL365976: [DirectoryWatcher][test][NFC] Add information to test failure reports.
[DirectoryWatcher][test][NFC] Add information to test failure reports
Jul 12 2019, 5:09 PM
jkorous committed rG000ba715ddbd: [DirectoryWatcher][NFC] Silence warnings in release build (authored by jkorous).
[DirectoryWatcher][NFC] Silence warnings in release build
Jul 12 2019, 3:27 PM
jkorous committed rL365968: [DirectoryWatcher][NFC] Silence warnings in release build.
[DirectoryWatcher][NFC] Silence warnings in release build
Jul 12 2019, 3:27 PM
jkorous committed rGec2abbafda62: [DirectoryWatcher][linux] Fix use of uninitialized value (authored by jkorous).
[DirectoryWatcher][linux] Fix use of uninitialized value
Jul 12 2019, 3:13 PM
jkorous committed rL365966: [DirectoryWatcher][linux] Fix use of uninitialized value.
[DirectoryWatcher][linux] Fix use of uninitialized value
Jul 12 2019, 3:13 PM
jkorous committed rG77dd8a79286d: Reland [clang] DirectoryWatcher (authored by jkorous).
Reland [clang] DirectoryWatcher
Jul 12 2019, 1:36 PM
jkorous added a reverting change for rGf561227d1332: Revert "Reland [clang] DirectoryWatcher": rG77dd8a79286d: Reland [clang] DirectoryWatcher.
Jul 12 2019, 1:36 PM
jkorous committed rL365954: Reland [clang] DirectoryWatcher.
Reland [clang] DirectoryWatcher
Jul 12 2019, 1:35 PM
jkorous committed rGf561227d1332: Revert "Reland [clang] DirectoryWatcher" (authored by jkorous).
Revert "Reland [clang] DirectoryWatcher"
Jul 12 2019, 12:55 PM
jkorous added a reverting change for rGfdcb7f47e783: Reland [clang] DirectoryWatcher: rGf561227d1332: Revert "Reland [clang] DirectoryWatcher".
Jul 12 2019, 12:55 PM
jkorous committed rL365948: Revert "Reland [clang] DirectoryWatcher".
Revert "Reland [clang] DirectoryWatcher"
Jul 12 2019, 12:55 PM
jkorous committed rGfdcb7f47e783: Reland [clang] DirectoryWatcher (authored by jkorous).
Reland [clang] DirectoryWatcher
Jul 12 2019, 12:49 PM
jkorous added a reverting change for rGabce8c457dd3: Revert [clang] DirectoryWatcher: rGfdcb7f47e783: Reland [clang] DirectoryWatcher.
Jul 12 2019, 12:49 PM
jkorous committed rL365947: Reland [clang] DirectoryWatcher.
Reland [clang] DirectoryWatcher
Jul 12 2019, 12:48 PM

Jul 11 2019

jkorous committed rGa286aae4d818: [clangd][NFC] Decrease template depth limit in RecursiveHierarchyUnbounded test (authored by jkorous).
[clangd][NFC] Decrease template depth limit in RecursiveHierarchyUnbounded test
Jul 11 2019, 11:24 AM
jkorous committed rL365804: [clangd][NFC] Decrease template depth limit in RecursiveHierarchyUnbounded test.
[clangd][NFC] Decrease template depth limit in RecursiveHierarchyUnbounded test
Jul 11 2019, 11:21 AM

Jul 9 2019

jkorous added a comment to D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.

Thanks for the revert.

Jul 9 2019, 5:07 PM · Restricted Project, Restricted Project
jkorous committed rG31babea94a3e: [clang] DirectoryWatcher (authored by jkorous).
[clang] DirectoryWatcher
Jul 9 2019, 3:46 PM
jkorous committed rL365574: [clang] DirectoryWatcher.
[clang] DirectoryWatcher
Jul 9 2019, 3:44 PM
jkorous closed D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.
Jul 9 2019, 3:44 PM · Restricted Project, Restricted Project

Jul 8 2019

jkorous created D64384: [WIP] Index-while-building.
Jul 8 2019, 8:22 PM · Restricted Project

Jun 28 2019

jkorous committed rGcaf4cee6fe8e: [clang][test][NFC] Explicitly specify clang ABI in AST Dumper test (authored by jkorous).
[clang][test][NFC] Explicitly specify clang ABI in AST Dumper test
Jun 28 2019, 3:40 PM
jkorous committed rL364690: [clang][test][NFC] Explicitly specify clang ABI in AST Dumper test.
[clang][test][NFC] Explicitly specify clang ABI in AST Dumper test
Jun 28 2019, 3:39 PM

Jun 20 2019

jkorous accepted D63600: [test][Driver] Fix Clang :: Driver/cl-response-file.c.

LGTM

Jun 20 2019, 2:20 PM · Restricted Project, Restricted Project
jkorous added a comment to D63603: [ASTImporter] Propagate error from ImportDeclContext.

I don't have the insight to LGTM the whole change - just a nit about implementation detail.

Jun 20 2019, 2:04 PM · Restricted Project, Restricted Project