Page MenuHomePhabricator
Feed Advanced Search

Wed, Jun 5

jkorous committed rGa3701caad826: [clang-format][NFC] Fix BS_Allman style example in the header docs are… (authored by jkorous).
[clang-format][NFC] Fix BS_Allman style example in the header docs are…
Wed, Jun 5, 2:01 PM
jkorous committed rL362646: [clang-format][NFC] Fix BS_Allman style example in the header docs are….
[clang-format][NFC] Fix BS_Allman style example in the header docs are…
Wed, Jun 5, 2:01 PM
jkorous closed D61729: [docs] Fix example for Allman brace breaking style.
Wed, Jun 5, 2:01 PM · Restricted Project, Restricted Project

Mon, Jun 3

jkorous updated the diff for D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.

linux implementation

  • factory method for SemaphorePipe
  • *_CLOEXEC flags
Mon, Jun 3, 6:01 PM · Restricted Project
jkorous added a comment to D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.

I fixed the rest.

Mon, Jun 3, 5:56 PM · Restricted Project
jkorous added a comment to D61729: [docs] Fix example for Allman brace breaking style.

Thanks, I didn't know it's generated.

Mon, Jun 3, 5:05 PM · Restricted Project, Restricted Project
jkorous updated the diff for D61729: [docs] Fix example for Allman brace breaking style.

Fix in the header file from which the documentation is actually generated.

Mon, Jun 3, 5:05 PM · Restricted Project, Restricted Project
jkorous commandeered D61729: [docs] Fix example for Allman brace breaking style.
Mon, Jun 3, 5:05 PM · Restricted Project, Restricted Project

Fri, May 31

jkorous edited reviewers for D61729: [docs] Fix example for Allman brace breaking style, added: owenpan; removed: llvm-commits.

You're right, thanks for letting me know.

Fri, May 31, 5:43 PM · Restricted Project, Restricted Project
jkorous updated the diff for D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.

Addressed comments.

Fri, May 31, 12:23 PM · Restricted Project
jkorous added inline comments to D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.
Fri, May 31, 12:20 PM · Restricted Project

Thu, May 30

jkorous committed rG2980f3c18f98: [NFC] Fix SmallVector::append comments (authored by jkorous).
[NFC] Fix SmallVector::append comments
Thu, May 30, 11:14 AM
jkorous committed rL362120: [NFC] Fix SmallVector::append comments.
[NFC] Fix SmallVector::append comments
Thu, May 30, 11:13 AM

Wed, May 29

jkorous committed rG158875ce0c95: [BitstreamWriter][NFC] Remove obsolete comment. (authored by jkorous).
[BitstreamWriter][NFC] Remove obsolete comment.
Wed, May 29, 6:10 PM
jkorous committed rL362046: [BitstreamWriter][NFC] Remove obsolete comment..
[BitstreamWriter][NFC] Remove obsolete comment.
Wed, May 29, 6:09 PM

Tue, May 28

jkorous added a comment to D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.

One more thing.

Tue, May 28, 1:38 PM · Restricted Project
jkorous updated the diff for D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.

Remove DirectoryWatcher::Event::EventKind::Added

Tue, May 28, 12:44 PM · Restricted Project

Fri, May 24

jkorous updated the diff for D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.
  • simplify link libraries in cmake
  • fix Release build (messed-up asserts)
Fri, May 24, 2:40 PM · Restricted Project
jkorous updated the diff for D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.

Specify what "file modified" means and add a test for metadata change

Fri, May 24, 1:25 PM · Restricted Project

Thu, May 23

jkorous added inline comments to D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.
Thu, May 23, 6:49 PM · Restricted Project
jkorous updated the diff for D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.

Reimplemented tests with std::futures which allowed to use more generous timeout while not slowing down the happy paths.

Thu, May 23, 6:45 PM · Restricted Project

Wed, May 22

jkorous updated the diff for D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.
Wed, May 22, 12:52 PM · Restricted Project
jkorous added a comment to D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.

Thanks for taking a look Kadir!
After yesterday's discussion with Dmitri I removed all those busy waits. Seems like the code is not much more complex now. I am going to update the diff and off to fixing the tests.

Wed, May 22, 12:51 PM · Restricted Project
jkorous updated the diff for D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.

Remove busy waits.

Wed, May 22, 12:51 PM · Restricted Project

Mon, May 20

jkorous updated the diff for D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.

Addressed comments.
Changed semantics of one of std::atomic<bool> in linux implementation.

Mon, May 20, 7:52 PM · Restricted Project
jkorous added a comment to D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.

I addressed most of the comments.

Mon, May 20, 7:51 PM · Restricted Project
jkorous added a comment to D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.

Thanks for taking a look @gribozavr!

Mon, May 20, 1:00 PM · Restricted Project

May 17 2019

jkorous updated the diff for D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.

fix link libraries in cmake

May 17 2019, 5:54 PM · Restricted Project

May 15 2019

jkorous updated the diff for D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.

A major clean-up.

May 15 2019, 7:02 PM · Restricted Project

May 13 2019

jkorous committed rG1652d8140191: [clang][ASTContext] Call setAttached for comments attached to a declaration (authored by jkorous).
[clang][ASTContext] Call setAttached for comments attached to a declaration
May 13 2019, 10:53 AM
jkorous committed rC360607: [clang][ASTContext] Call setAttached for comments attached to a declaration.
[clang][ASTContext] Call setAttached for comments attached to a declaration
May 13 2019, 10:52 AM
jkorous committed rL360607: [clang][ASTContext] Call setAttached for comments attached to a declaration.
[clang][ASTContext] Call setAttached for comments attached to a declaration
May 13 2019, 10:52 AM
jkorous closed D61538: [clang][ASTContext] Call setAttached for comments attached to a declaration.
May 13 2019, 10:52 AM · Restricted Project

May 6 2019

jkorous added a comment to D28462: clang-format: Add new style option AlignConsecutiveMacros.

Hi @VelocityRa, just FYI - it's considered fine to ping your reviewers once per week here if you've addressed their comments and there's no activity in the review. Sometimes people just get distracted by other things.

May 6 2019, 3:48 PM · Restricted Project

May 3 2019

jkorous created D61538: [clang][ASTContext] Call setAttached for comments attached to a declaration.
May 3 2019, 2:25 PM · Restricted Project

May 2 2019

jkorous committed rGf90458b3895c: [clangd][xpc] Cannonicalize value of CLANGD_BUILD_XPC before caching (authored by jkorous).
[clangd][xpc] Cannonicalize value of CLANGD_BUILD_XPC before caching
May 2 2019, 1:31 PM
jkorous committed rCTE359824: [clangd][xpc] Cannonicalize value of CLANGD_BUILD_XPC before caching.
[clangd][xpc] Cannonicalize value of CLANGD_BUILD_XPC before caching
May 2 2019, 1:30 PM
jkorous committed rL359824: [clangd][xpc] Cannonicalize value of CLANGD_BUILD_XPC before caching.
[clangd][xpc] Cannonicalize value of CLANGD_BUILD_XPC before caching
May 2 2019, 1:30 PM

May 1 2019

jkorous planned changes to D61104: [clang][ASTContext] Try to avoid sorting comments for code completion.

@gribozavr thanks for the feedback. I'm rewriting the patch now as I figured out my detection of comments preceding declarations is unsound.

May 1 2019, 2:53 PM · Restricted Project

Apr 29 2019

jkorous committed rGfd76383d761c: [clangd][xpc] Fix XPC unittests (authored by jkorous).
[clangd][xpc] Fix XPC unittests
Apr 29 2019, 12:40 PM
jkorous committed rL359489: [clangd][xpc] Fix XPC unittests.
[clangd][xpc] Fix XPC unittests
Apr 29 2019, 12:39 PM
jkorous committed rCTE359489: [clangd][xpc] Fix XPC unittests.
[clangd][xpc] Fix XPC unittests
Apr 29 2019, 12:39 PM
jkorous closed D61271: [clangd][xpc] Fix XPC unittests.
Apr 29 2019, 12:39 PM · Restricted Project
jkorous added a comment to D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools..

Patch with fix for XPC tests https://reviews.llvm.org/D61271

Apr 29 2019, 11:19 AM · Restricted Project, Restricted Project
jkorous created D61271: [clangd][xpc] Fix XPC unittests.
Apr 29 2019, 11:19 AM · Restricted Project
jkorous added a comment to D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools..

@MaskRay @juliehockett I'll take a look.

Apr 29 2019, 10:23 AM · Restricted Project, Restricted Project

Apr 26 2019

jkorous updated the diff for D61102: [clang][ASTContext][NFCi] Refactor ASTContext::getRawCommentForDeclNoCache.
  • moved assert
Apr 26 2019, 10:29 AM · Restricted Project

Apr 25 2019

jkorous added inline comments to D61102: [clang][ASTContext][NFCi] Refactor ASTContext::getRawCommentForDeclNoCache.
Apr 25 2019, 5:30 PM · Restricted Project
jkorous updated the diff for D61102: [clang][ASTContext][NFCi] Refactor ASTContext::getRawCommentForDeclNoCache.
  • renames
  • if => assert
Apr 25 2019, 5:09 PM · Restricted Project
jkorous abandoned D60432: [clang][ASTContext] Simplify caching for declaration-related comments.
Apr 25 2019, 4:05 PM · Restricted Project
jkorous added a comment to D61103: [clang] Add tryToAttachCommentsToDecls method to ASTContext.

Also, IIUC the test case that I deleted wasn't actually supposed to produce any diagnostics and the fact that it did was a bug. We could keep it as a regression test but I think it has a rather low value. WDYT?

Apr 25 2019, 3:52 PM · Restricted Project
jkorous updated the diff for D61103: [clang] Add tryToAttachCommentsToDecls method to ASTContext.
  • clang-format
  • comments
Apr 25 2019, 3:50 PM · Restricted Project
jkorous added inline comments to D61103: [clang] Add tryToAttachCommentsToDecls method to ASTContext.
Apr 25 2019, 3:46 PM · Restricted Project
jkorous abandoned D60494: [clang][ASTContext] Don't load external comments from Sema::ActOnDocumentableDecls.

Abandonned in favor of https://reviews.llvm.org/D61103

Apr 25 2019, 1:24 PM

Apr 24 2019

jkorous added a parent revision for D61104: [clang][ASTContext] Try to avoid sorting comments for code completion: D61102: [clang][ASTContext][NFCi] Refactor ASTContext::getRawCommentForDeclNoCache.
Apr 24 2019, 4:43 PM · Restricted Project
jkorous added a child revision for D61102: [clang][ASTContext][NFCi] Refactor ASTContext::getRawCommentForDeclNoCache: D61104: [clang][ASTContext] Try to avoid sorting comments for code completion.
Apr 24 2019, 4:43 PM · Restricted Project
jkorous added a child revision for D61102: [clang][ASTContext][NFCi] Refactor ASTContext::getRawCommentForDeclNoCache: D61103: [clang] Add tryToAttachCommentsToDecls method to ASTContext.
Apr 24 2019, 4:42 PM · Restricted Project
jkorous added a parent revision for D61103: [clang] Add tryToAttachCommentsToDecls method to ASTContext: D61102: [clang][ASTContext][NFCi] Refactor ASTContext::getRawCommentForDeclNoCache.
Apr 24 2019, 4:42 PM · Restricted Project
jkorous updated the summary of D61102: [clang][ASTContext][NFCi] Refactor ASTContext::getRawCommentForDeclNoCache.
Apr 24 2019, 4:42 PM · Restricted Project
jkorous created D61104: [clang][ASTContext] Try to avoid sorting comments for code completion.
Apr 24 2019, 4:42 PM · Restricted Project
jkorous created D61103: [clang] Add tryToAttachCommentsToDecls method to ASTContext.
Apr 24 2019, 4:33 PM · Restricted Project
jkorous created D61102: [clang][ASTContext][NFCi] Refactor ASTContext::getRawCommentForDeclNoCache.
Apr 24 2019, 4:32 PM · Restricted Project
jkorous accepted D61093: Fix spelling error. NFC.
Apr 24 2019, 3:25 PM · Restricted Project
jkorous accepted D61096: posix_spawn should retry upon EINTR.

Hmm, we have this utility function RetryAfterSignal() but it doesn't have maxRetries.

Apr 24 2019, 3:24 PM · Restricted Project

Apr 23 2019

jkorous added a comment to D60523: [clang] Don't segfault on incorrect using directive (PR41400).

I can't really comment on correctness of your fix but had been willing to do the work I'd suggest making ASTContext::getDependentNameType and DependentNameType::DependentNameType interface more robust.

Apr 23 2019, 6:43 PM · Restricted Project, Restricted Project
jkorous accepted D61038: Add "const" in GetUnderlyingObjects.

Seems like a NFC.
Looks awesome to me - const correctness for the win!

Apr 23 2019, 5:50 PM · Restricted Project
jkorous abandoned D48559: [clangd] refactoring for XPC transport layer [NFCI].
Apr 23 2019, 5:32 PM · Restricted Project, Restricted Project
jkorous abandoned D48560: [clangd] JSON <-> XPC conversions.
Apr 23 2019, 5:32 PM · Restricted Project, Restricted Project

Apr 16 2019

jkorous added inline comments to D60233: [clang-scan-deps] initial outline of the tool that runs preprocessor to find dependencies over a JSON compilation database.
Apr 16 2019, 3:51 PM · Restricted Project, Restricted Project
jkorous added inline comments to D60779: [ADT] llvm::bsearch, binary search for mere mortals.
Apr 16 2019, 2:05 PM · Restricted Project

Apr 12 2019

jkorous abandoned D58749: [index-while-building] IndexRecordHasher.
Apr 12 2019, 2:42 PM · Restricted Project

Apr 11 2019

jkorous added a comment to D58749: [index-while-building] IndexRecordHasher.

We did performance tests of alternative approach - just hashing the serialized bit code representation. There's a performance regression in the sense that while the current implementation costs approx. extra 2.2% in build time the alternative approach costs 3.8%.

Apr 11 2019, 8:08 PM · Restricted Project

Apr 10 2019

jkorous added a comment to D60494: [clang][ASTContext] Don't load external comments from Sema::ActOnDocumentableDecls.

I agree and will try to decrease the impact on interfaces.

Apr 10 2019, 4:17 PM
jkorous updated the diff for D60432: [clang][ASTContext] Simplify caching for declaration-related comments.

rename RawCommentAndCacheFlags -> CommentAndOrigin

Apr 10 2019, 4:12 PM · Restricted Project
jkorous updated the diff for D60432: [clang][ASTContext] Simplify caching for declaration-related comments.

Second attempt on reducing the cache size and number of operations.

Apr 10 2019, 4:03 PM · Restricted Project
jkorous added inline comments to D60432: [clang][ASTContext] Simplify caching for declaration-related comments.
Apr 10 2019, 3:56 PM · Restricted Project
jkorous committed rG6644d014dd98: [clang][ASTContext] Try to exit early before loading serialized comments from… (authored by jkorous).
[clang][ASTContext] Try to exit early before loading serialized comments from…
Apr 10 2019, 1:23 PM
jkorous committed rC358133: [clang][ASTContext] Try to exit early before loading serialized comments from….
[clang][ASTContext] Try to exit early before loading serialized comments from…
Apr 10 2019, 1:23 PM
jkorous committed rL358133: [clang][ASTContext] Try to exit early before loading serialized comments from….
[clang][ASTContext] Try to exit early before loading serialized comments from…
Apr 10 2019, 1:23 PM
jkorous closed D60493: [clang][ASTContext] Try to exit early before loading serialize comments from AST files.
Apr 10 2019, 1:23 PM · Restricted Project
jkorous added a comment to D60493: [clang][ASTContext] Try to exit early before loading serialize comments from AST files.

Thanks @gribozavr!

Apr 10 2019, 1:23 PM · Restricted Project

Apr 9 2019

jkorous created D60494: [clang][ASTContext] Don't load external comments from Sema::ActOnDocumentableDecls.
Apr 9 2019, 6:45 PM
jkorous created D60493: [clang][ASTContext] Try to exit early before loading serialize comments from AST files.
Apr 9 2019, 6:34 PM · Restricted Project
jkorous added inline comments to D60432: [clang][ASTContext] Simplify caching for declaration-related comments.
Apr 9 2019, 6:29 PM · Restricted Project

Apr 8 2019

jkorous created D60432: [clang][ASTContext] Simplify caching for declaration-related comments.
Apr 8 2019, 5:45 PM · Restricted Project

Apr 4 2019

jkorous accepted D60120: check-clang-tools: Actually build and run XPC test.

LGTM. Thanks for fixing this!

Apr 4 2019, 1:03 PM · Restricted Project

Mar 25 2019

jkorous committed rG2d000e395ecc: [clangd][xpc][cmake] Respect explicit value of CLANGD_BUILD_XPC (authored by jkorous).
[clangd][xpc][cmake] Respect explicit value of CLANGD_BUILD_XPC
Mar 25 2019, 8:48 PM
jkorous committed rCTE356974: [clangd][xpc][cmake] Respect explicit value of CLANGD_BUILD_XPC.
[clangd][xpc][cmake] Respect explicit value of CLANGD_BUILD_XPC
Mar 25 2019, 8:48 PM
jkorous committed rL356974: [clangd][xpc][cmake] Respect explicit value of CLANGD_BUILD_XPC.
[clangd][xpc][cmake] Respect explicit value of CLANGD_BUILD_XPC
Mar 25 2019, 8:48 PM
jkorous closed D59808: [clangd][xpc][cmake] Respect explicit value of CLANGD_BUILD_XPC.
Mar 25 2019, 8:48 PM · Restricted Project
jkorous created D59808: [clangd][xpc][cmake] Respect explicit value of CLANGD_BUILD_XPC.
Mar 25 2019, 8:09 PM · Restricted Project

Mar 21 2019

jkorous accepted D59377: Frontend: Remove CompilerInstance::VirtualFileSystem, NFC.

LGTM

Mar 21 2019, 8:23 PM
jkorous added a comment to D40988: Clang-format: add finer-grained options for putting all arguments on one line.

@russellmcc the patch has been approved by @MyDeveloperDay
https://reviews.llvm.org/D40988#1430502

Mar 21 2019, 4:21 PM · Restricted Project
jkorous accepted D57965: Clean up ObjCPropertyDecl printing.

LGTM. Thanks for working on this!

Mar 21 2019, 4:13 PM · Restricted Project, Restricted Project
jkorous added a comment to D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.

Why is this needed for index-while-building? My mental model for index-while-building is that that streams out build index metadata as part of the regular compile. Why does that require watching directories?

You're right that this isn't necessary for the indexing phase. But we also provide API so clients can consume the index. This functionality is used for getting notifications about index data changes.

You can see it for example here:
https://github.com/apple/swift-clang/blob/stable/lib/IndexDataStore/IndexDataStore.cpp#L111

Is that code going to live in clang? This seems more like a tool built on top of the compiler rather than something core to the compiler itself (like the actual index-while-building feature). Maybe this could be in clang-tools-extra?

It actually is part of the feature as the serialized format of the index isn't meant as a stable interface, that's what the API is for. DirectoryWatcher isn't a tool, it's just part of implementation of the IndexStore API.

Maybe I misunderstand what the client of the IndexStore API is. That's not code that will be in the clang binary, right?

Mar 21 2019, 4:09 PM · Restricted Project

Mar 20 2019

jkorous added inline comments to D59605: [clangd] Introduce background-indexer.
Mar 20 2019, 11:05 AM · Restricted Project

Mar 19 2019

jkorous accepted D59388: Basic: Return a reference from FileManager::getVirtualFileSystem, NFC.

Yes, it's safe. The reference count is "intrusive", meaning it's stored in the object itself (via inheritance from RefCountedBase). As a result, all the instances of IntrusiveRefCntPtr that reference at the same object will implicitly share their count.

Mar 19 2019, 11:28 AM

Mar 18 2019

jkorous accepted D59130: [llvm][Support] Provide interface to set thread priorities.

Gotchas and symptoms are IMO dependent on the use-case. Since this is a generic API I'd say that documenting the behavior is the best we can do here.

Mar 18 2019, 11:31 AM · Restricted Project

Mar 15 2019

jkorous added a comment to D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.

Why is this needed for index-while-building? My mental model for index-while-building is that that streams out build index metadata as part of the regular compile. Why does that require watching directories?

You're right that this isn't necessary for the indexing phase. But we also provide API so clients can consume the index. This functionality is used for getting notifications about index data changes.

You can see it for example here:
https://github.com/apple/swift-clang/blob/stable/lib/IndexDataStore/IndexDataStore.cpp#L111

Is that code going to live in clang? This seems more like a tool built on top of the compiler rather than something core to the compiler itself (like the actual index-while-building feature). Maybe this could be in clang-tools-extra?

Mar 15 2019, 1:29 PM · Restricted Project
jkorous added a comment to D59388: Basic: Return a reference from FileManager::getVirtualFileSystem, NFC.

Hi Duncan, thanks for working on better interfaces in clang!

Mar 15 2019, 12:46 PM