Sorry - I should have made this clear earlier so nobody waste their time reviewing current version - I'm rewriting this with ASTMatchers.
Mon, Apr 6
comment & test case
Tue, Mar 31
Fix typo in doc comment
Thu, Mar 19
Fri, Mar 13
Mar 2 2020
@erik.pilkington My bad - didn't check that.
Thanks a bunch for fixing this!
Feb 20 2020
@vsapsai Sorry! I read your comment only after landing this.
Feb 17 2020
Apparently it's related to:
Feb 10 2020
Feb 5 2020
@serge-sans-paille The test was still failing on macOS.
Feb 4 2020
I suggest you split the patch into two smaller ones so it is easier to review.
Feb 3 2020
We should either simplify the implementation to reflect that we don't support e. g. *:42 (seems preferable to me) or have the codepaths that are currently not accessible through -fverify tested by other means.
Jan 21 2020
Jan 16 2020
Jan 15 2020
This was meant as a post-commit review
Jan 14 2020
Jan 10 2020
Jan 9 2020
(and a delete)
Oh, I will just add some ASSERT to the test and a comment on what it actually tests.
Ok, seems such test fails reliably (on macOS).
Jan 8 2020
calculate the size of the buffer upfront
I tried but couldn't reproduce a segfault. Do you have any suggestion on how to reasonably reliably (TM) reproduce it?
Dec 12 2019
Dec 4 2019
The use of xcrun looks sound to me.
Dec 2 2019
Hi @arthurp, I can review the libclang part of the patch.
Nov 21 2019
Nov 19 2019
Ahh, right. I originally wanted to support -ivfsoverlay in Driver as it seemed reasonable to check the existence of blacklist in Driver and open it in cc1 using the same fs. I got talked out of it and I didn't touch the Driver but seems like I should've replaced the calls to native fs with VFS to keep things consistent. Thanks for picking this up!
Nov 8 2019
Nov 7 2019
@pcc Could you please take a look?
I am in no particular rush and happy to help you as much as I can but at some point not too far in the future I just want this to land and not get reverted.
Nov 6 2019
The test seems to be fine (fails on master, passes with the patch). I most probably just forgot to run it.
Actually use the VFS that got passed.