Page MenuHomePhabricator
Feed Advanced Search

Fri, Jul 19

cameron.mcinally added a comment to D63782: [FPEnv] Add fptosi and fptoui constrained intrinsics.

Makes sense to me. As I recall, the mutation was always intended as a temporary solution.

Fri, Jul 19, 1:16 PM · Restricted Project

Wed, Jul 17

cameron.mcinally updated subscribers of D64746: Add constrained intrinsics for lrint and lround.
Wed, Jul 17, 8:44 AM · Restricted Project

Tue, Jul 16

cameron.mcinally added inline comments to D64746: Add constrained intrinsics for lrint and lround.
Tue, Jul 16, 1:24 PM · Restricted Project
cameron.mcinally added inline comments to D64746: Add constrained intrinsics for lrint and lround.
Tue, Jul 16, 1:23 PM · Restricted Project
cameron.mcinally accepted D64412: [Strict FP] Allow more relaxed scheduling.

This patch would add the additional option of also changing the relative order of the two strict_fmul operations.

Tue, Jul 16, 7:32 AM · Restricted Project

Mon, Jul 15

cameron.mcinally added a comment to D64412: [Strict FP] Allow more relaxed scheduling.

I think I'll have to challenge you a little here. ;)

Mon, Jul 15, 2:25 PM · Restricted Project
cameron.mcinally added a comment to D64412: [Strict FP] Allow more relaxed scheduling.

Bah, my last comment was flawed! I read the test cases incorrectly and missed the 'fpexcept.ignore' on some of them.

Mon, Jul 15, 12:20 PM · Restricted Project
cameron.mcinally added a comment to D64412: [Strict FP] Allow more relaxed scheduling.

I'm reviewing the trap-safety issues now and have some open questions (language lawyers needed??). Let's say we have something like this:

Mon, Jul 15, 12:12 PM · Restricted Project

Fri, Jul 12

cameron.mcinally added a comment to D63782: [FPEnv] Add fptosi and fptoui constrained intrinsics.

Is there any chance I can get this patch into 9? What do I need to do to make that happen?

Fri, Jul 12, 10:40 AM · Restricted Project
cameron.mcinally added a comment to D63782: [FPEnv] Add fptosi and fptoui constrained intrinsics.

How aggressive is LLVM's UB handling? Would it remove an entire block/function if UB is found in it?

If LLVM can prove a basic block unconditionally executes UB, it will be erased. But "unconditionally" is an important qualifier. For example, consider the following function: void f(void g()) { g(); *(int*)0 = 0; }. The call to g isn't erased because we can't prove g will return.

Fri, Jul 12, 8:05 AM · Restricted Project

Tue, Jul 9

cameron.mcinally updated subscribers of D63782: [FPEnv] Add fptosi and fptoui constrained intrinsics.
In D63782#1573780, @kpn wrote:

I might be opening a can of worms here and I'm not a language expert, but it isn't clear to me from reading the C99 standard that defining fptosi/fptoui as returning poison values in the unrepresentable case allows correct implementation of the C standard. That is, it doesn't seem to me that the standard actually says this is undefined behavior. It just says the resulting value is unspecified, and the exception behavior is explicitly defined. On the other hand, C++ does say clearly that it is undefined behavior, right?

Tue, Jul 9, 9:47 AM · Restricted Project

Mon, Jul 8

cameron.mcinally committed rG771769be9013: [Float2Int] Add support for unary FNeg to Float2Int (authored by cameron.mcinally).
[Float2Int] Add support for unary FNeg to Float2Int
Mon, Jul 8, 7:49 AM

Fri, Jun 28

cameron.mcinally added inline comments to D63933: [NewGVN] Add unary FNeg support to NewGVN pass.
Fri, Jun 28, 2:40 PM · Restricted Project
cameron.mcinally committed rGb671535983fa: [NFC][NewGVN] Explicitly check fpmath metadata in fpmath.ll (authored by cameron.mcinally).
[NFC][NewGVN] Explicitly check fpmath metadata in fpmath.ll
Fri, Jun 28, 2:40 PM
cameron.mcinally added inline comments to D63933: [NewGVN] Add unary FNeg support to NewGVN pass.
Fri, Jun 28, 1:45 PM · Restricted Project
cameron.mcinally added inline comments to D63933: [NewGVN] Add unary FNeg support to NewGVN pass.
Fri, Jun 28, 1:14 PM · Restricted Project
cameron.mcinally committed rG30e5cf1d8f3a: [NewGVN] Add unary FNeg support to NewGVN pass (authored by cameron.mcinally).
[NewGVN] Add unary FNeg support to NewGVN pass
Fri, Jun 28, 1:11 PM
cameron.mcinally committed rGab4b2364e566: [GVNSink] Add unary FNeg support to GVNSink pass (authored by cameron.mcinally).
[GVNSink] Add unary FNeg support to GVNSink pass
Fri, Jun 28, 12:58 PM
cameron.mcinally created D63941: [Float2Int] Add support for unary FNeg to Float2Int.
Fri, Jun 28, 10:27 AM · Restricted Project
cameron.mcinally committed rG9fab46ca0bd3: [NFC][Float2Int] Pre-commit unary FNeg test to basic.ll (authored by cameron.mcinally).
[NFC][Float2Int] Pre-commit unary FNeg test to basic.ll
Fri, Jun 28, 8:13 AM
cameron.mcinally created D63933: [NewGVN] Add unary FNeg support to NewGVN pass.
Fri, Jun 28, 7:48 AM · Restricted Project
cameron.mcinally committed rG13d9c723c89b: [NFC][NewGVN] Pre-commit unary FNeg test to fpmath.ll (authored by cameron.mcinally).
[NFC][NewGVN] Pre-commit unary FNeg test to fpmath.ll
Fri, Jun 28, 7:41 AM

Thu, Jun 27

cameron.mcinally created D63900: [GVNSink] Add unary FNeg support to GVNSink pass.
Thu, Jun 27, 2:49 PM · Restricted Project
cameron.mcinally committed rG30cab5d6eef7: [NFC][GVNSink] Pre-commit unary FNeg test to fpmath.ll (authored by cameron.mcinally).
[NFC][GVNSink] Pre-commit unary FNeg test to fpmath.ll
Thu, Jun 27, 2:24 PM
cameron.mcinally committed rG6e62a796d502: [GVN] Add support for unary FNeg to GVN pass (authored by cameron.mcinally).
[GVN] Add support for unary FNeg to GVN pass
Thu, Jun 27, 2:06 PM
cameron.mcinally created D63896: [GVN] Add support for unary FNeg to GVN pass.
Thu, Jun 27, 1:48 PM · Restricted Project
cameron.mcinally committed rG22afca2ce022: [NFC][GVN] Pre-commit unary FNeg tests to fpmath.ll (authored by cameron.mcinally).
[NFC][GVN] Pre-commit unary FNeg tests to fpmath.ll
Thu, Jun 27, 1:39 PM
cameron.mcinally added a comment to D54649: [FPEnv] Rough out constrained FCmp intrinsics.

Now that this has landed, are you planning to have another look at this?

Thu, Jun 27, 12:46 PM · Restricted Project
cameron.mcinally updated subscribers of D63214: [InstCombine] canonicalize fmin/fmax to LLVM intrinsics minnum/maxnum.

This LGTM at a high level, but I don't fully understand the AVR concerns from D63294. Maybe @eli.friedman would be a better reviewer?

Thu, Jun 27, 11:19 AM · Restricted Project

Wed, Jun 26

cameron.mcinally added a comment to D63782: [FPEnv] Add fptosi and fptoui constrained intrinsics.

So pragmatically, an invalid exception is an alarm that the code is off track. As long as the exception is handled appropriately (default or an alternative), the result of the invalid operation shouldn't matter. Whatever LLVM wants to do with the value gets no arguments from me, since we've already self-destructed (unless the program handles the exception gracefully, but that wouldn't require a defined result from the invalid operation anyway).

But the exception could be masked couldn't it?

Wed, Jun 26, 7:52 PM · Restricted Project
cameron.mcinally added a comment to D63782: [FPEnv] Add fptosi and fptoui constrained intrinsics.

I think IEEE-754 does define this

Your citation doesn't actually specify what value is returned, only that an exception is raised.

Wed, Jun 26, 5:59 PM · Restricted Project
cameron.mcinally added a comment to D63782: [FPEnv] Add fptosi and fptoui constrained intrinsics.

Unless I'm misunderstanding, we should be leaving the constrained converts alone until a hardware instruction is produced.

We have to define the semantics; I mean, I guess we could say "If the value cannot fit in the destination type, the result is computed in a target-specific way", but we'd have to state it explicitly. And it's sort of awkward.

Wed, Jun 26, 3:11 PM · Restricted Project
cameron.mcinally added a comment to D63782: [FPEnv] Add fptosi and fptoui constrained intrinsics.

What happens if the input float is out of range? fptosi/fptoui instructions produce poison; not sure if you want that here.

Wed, Jun 26, 12:35 PM · Restricted Project

Mon, Jun 24

cameron.mcinally committed rG1e5116cbb3a0: [NFC][Reassociate] Add unary FNeg tests to fast-ReassociateVector.ll (authored by cameron.mcinally).
[NFC][Reassociate] Add unary FNeg tests to fast-ReassociateVector.ll
Mon, Jun 24, 2:38 PM
cameron.mcinally committed rGfe3f15cf9001: [SLP] Support unary FNeg vectorization (authored by cameron.mcinally).
[SLP] Support unary FNeg vectorization
Mon, Jun 24, 12:25 PM
cameron.mcinally added a comment to D63609: [SLP] Support unary FNeg vectorization.

Answering myself - doesn't look like anything has changed since:
D62444 / rL361788

Mon, Jun 24, 11:25 AM · Restricted Project

Jun 21 2019

cameron.mcinally added inline comments to D62158: [InstCombine] canonicalize minnum/maxnum with 'nnan' to fcmp+select.
Jun 21 2019, 11:09 AM · Restricted Project

Jun 20 2019

cameron.mcinally committed rG1c0bd6dd2ca7: [Reassociate] Remove bogus assert reported in PR42349. (authored by cameron.mcinally).
[Reassociate] Remove bogus assert reported in PR42349.
Jun 20 2019, 4:04 PM
cameron.mcinally updated the diff for D63609: [SLP] Support unary FNeg vectorization.

Add two more tests (X86/propagate_ir_flags.ll).

Jun 20 2019, 2:02 PM · Restricted Project
cameron.mcinally committed rG9589db7a98ea: [NFC][SLP] Pre-commit unary FNeg test to X86/propagate_ir_flags.ll (authored by cameron.mcinally).
[NFC][SLP] Pre-commit unary FNeg test to X86/propagate_ir_flags.ll
Jun 20 2019, 1:56 PM
cameron.mcinally created D63609: [SLP] Support unary FNeg vectorization.
Jun 20 2019, 9:34 AM · Restricted Project
cameron.mcinally committed rG4452c3b490e9: [NFC][SLP] Pre-commit unary FNeg test to X86/phi3.ll (authored by cameron.mcinally).
[NFC][SLP] Pre-commit unary FNeg test to X86/phi3.ll
Jun 20 2019, 8:16 AM

Jun 19 2019

cameron.mcinally committed rG11e7357a052d: [NFC][IR] Move CreateFNegFMF(...) next to CreateFNeg(...). (authored by cameron.mcinally).
[NFC][IR] Move CreateFNegFMF(...) next to CreateFNeg(...).
Jun 19 2019, 9:33 AM
cameron.mcinally committed rG7aa898e61e19: [DFSan] Add UnaryOperator visitor to DataFlowSanitizer (authored by cameron.mcinally).
[DFSan] Add UnaryOperator visitor to DataFlowSanitizer
Jun 19 2019, 8:09 AM
cameron.mcinally committed rGa027cf47640c: [Reassociate] Handle unary FNeg in the Reassociate pass (authored by cameron.mcinally).
[Reassociate] Handle unary FNeg in the Reassociate pass
Jun 19 2019, 7:57 AM

Jun 18 2019

cameron.mcinally accepted D63294: [Analysis] enhance FP library function prototype checking to match types with name suffix .

LGTM, assuming the test writer was not intentionally playing games with the fabs(...) calls.

Jun 18 2019, 9:09 AM · Restricted Project
cameron.mcinally added a comment to D62815: Add UnaryOperator visitor to DataFlowSanitizer.

Ping*2.

Jun 18 2019, 8:10 AM · Restricted Project
cameron.mcinally updated the diff for D63445: [Reassociate] Handle unary FNeg in the Reassociate pass.

Remove unintentional changes. Also fix up a poor naming choice.

Jun 18 2019, 7:39 AM · Restricted Project
cameron.mcinally added inline comments to D63445: [Reassociate] Handle unary FNeg in the Reassociate pass.
Jun 18 2019, 7:19 AM · Restricted Project

Jun 17 2019

cameron.mcinally updated the diff for D63445: [Reassociate] Handle unary FNeg in the Reassociate pass.

Correct comment. Should be 'nnan', not 'nnan and nsz'.

Jun 17 2019, 12:45 PM · Restricted Project
cameron.mcinally added a comment to D63405: GlobalISel: Don't lose fneg flags when lowering to fsub.

But there's a separate question that is raised here: why is it legal to convert fneg to fsub -0.0? That loosens the IEEE requirement when dealing with a NAN. I'd think this should be legalized by converting to integer and flipping the sign bit (xor).
ping @cameron.mcinally

Jun 17 2019, 12:45 PM
cameron.mcinally created D63445: [Reassociate] Handle unary FNeg in the Reassociate pass.
Jun 17 2019, 10:33 AM · Restricted Project

Jun 13 2019

cameron.mcinally committed rG79ec1a29572e: Revert "[NFC][CodeGen] Add unary fneg tests to fp-fast.ll fp-fold.ll fp-in… (authored by cameron.mcinally).
Revert "[NFC][CodeGen] Add unary fneg tests to fp-fast.ll fp-fold.ll fp-in…
Jun 13 2019, 12:26 PM
cameron.mcinally added a reverting change for rG1d85a7518c6b: [NFC][CodeGen] Add unary fneg tests to fp-fast.ll fp-fold.ll fp-in-intregs.ll…: rG79ec1a29572e: Revert "[NFC][CodeGen] Add unary fneg tests to fp-fast.ll fp-fold.ll fp-in….
Jun 13 2019, 12:26 PM
cameron.mcinally committed rG07514a1b1625: Revert "[NFC][CodeGen] Add unary fneg tests to fmul-combines.ll fnabs.ll" (authored by cameron.mcinally).
Revert "[NFC][CodeGen] Add unary fneg tests to fmul-combines.ll fnabs.ll"
Jun 13 2019, 12:26 PM
cameron.mcinally added a reverting change for rG5c0114058126: [NFC][CodeGen] Add unary fneg tests to fmul-combines.ll fnabs.ll: rG07514a1b1625: Revert "[NFC][CodeGen] Add unary fneg tests to fmul-combines.ll fnabs.ll".
Jun 13 2019, 12:26 PM
cameron.mcinally committed rG8984dbc27c37: Revert "[NFC][CodeGen] Add unary fneg tests to X86/fma_patterns_wide.ll" (authored by cameron.mcinally).
Revert "[NFC][CodeGen] Add unary fneg tests to X86/fma_patterns_wide.ll"
Jun 13 2019, 12:26 PM
cameron.mcinally committed rG5d9271802ba6: Revert "[NFC][CodeGen] Add unary fneg tests to X86/fma_patterns.ll" (authored by cameron.mcinally).
Revert "[NFC][CodeGen] Add unary fneg tests to X86/fma_patterns.ll"
Jun 13 2019, 12:25 PM
cameron.mcinally added a reverting change for rG06de52674da7: [NFC][CodeGen] Add unary fneg tests to X86/fma_patterns.ll: rG5d9271802ba6: Revert "[NFC][CodeGen] Add unary fneg tests to X86/fma_patterns.ll".
Jun 13 2019, 12:25 PM
cameron.mcinally added a reverting change for rGf1b8c6ac4f9d: [NFC][CodeGen] Add unary fneg tests to X86/fma_patterns_wide.ll: rG8984dbc27c37: Revert "[NFC][CodeGen] Add unary fneg tests to X86/fma_patterns_wide.ll".
Jun 13 2019, 12:25 PM
cameron.mcinally committed rGd331e71bdb67: Revert "[NFC][CodeGen] Add unary fneg tests to X86/fma4-fneg-combine.ll" (authored by cameron.mcinally).
Revert "[NFC][CodeGen] Add unary fneg tests to X86/fma4-fneg-combine.ll"
Jun 13 2019, 12:25 PM
cameron.mcinally added a reverting change for rGf288a0685f87: [NFC][CodeGen] Add unary fneg tests to X86/fma4-fneg-combine.ll: rGd331e71bdb67: Revert "[NFC][CodeGen] Add unary fneg tests to X86/fma4-fneg-combine.ll".
Jun 13 2019, 12:25 PM
cameron.mcinally added a reverting change for rG3d2ee0053aa2: [NFC][CodeGen] Add unary fneg tests to X86/fma-scalar-combine.ll: rG31da4f80d5bb: Revert "[NFC][CodeGen] Add unary fneg tests to X86/fma-scalar-combine.ll".
Jun 13 2019, 12:25 PM
cameron.mcinally committed rG31da4f80d5bb: Revert "[NFC][CodeGen] Add unary fneg tests to X86/fma-scalar-combine.ll" (authored by cameron.mcinally).
Revert "[NFC][CodeGen] Add unary fneg tests to X86/fma-scalar-combine.ll"
Jun 13 2019, 12:25 PM
cameron.mcinally committed rG2aff82bfa675: Revert "[NFC][CodeGen] Add unary fneg tests to X86/fma4-intrinsics-x86.ll" (authored by cameron.mcinally).
Revert "[NFC][CodeGen] Add unary fneg tests to X86/fma4-intrinsics-x86.ll"
Jun 13 2019, 12:25 PM
cameron.mcinally committed rGd3eaa332e4a4: Revert "[NFC][CodeGen] Add unary fneg tests to X86/fma-intrinsics-x86.ll" (authored by cameron.mcinally).
Revert "[NFC][CodeGen] Add unary fneg tests to X86/fma-intrinsics-x86.ll"
Jun 13 2019, 12:25 PM
cameron.mcinally added a reverting change for rG169fc2b0209d: [NFC][CodeGen] Add unary fneg tests to X86/fma-intrinsics-x86.ll: rGd3eaa332e4a4: Revert "[NFC][CodeGen] Add unary fneg tests to X86/fma-intrinsics-x86.ll".
Jun 13 2019, 12:25 PM
cameron.mcinally added a reverting change for rG66f286845cad: [NFC][CodeGen] Add unary fneg tests to X86/fma4-intrinsics-x86.ll: rG2aff82bfa675: Revert "[NFC][CodeGen] Add unary fneg tests to X86/fma4-intrinsics-x86.ll".
Jun 13 2019, 12:25 PM
cameron.mcinally committed rG0a3fe05047e6: Revert "[NFC][CodeGen] Add unary FNeg tests to some X86/ and XCore/ tests." (authored by cameron.mcinally).
Revert "[NFC][CodeGen] Add unary FNeg tests to some X86/ and XCore/ tests."
Jun 13 2019, 12:25 PM
cameron.mcinally added a reverting change for rG4f3cf3853e11: [NFC][CodeGen] Add unary FNeg tests to some X86/ and XCore/ tests.: rG0a3fe05047e6: Revert "[NFC][CodeGen] Add unary FNeg tests to some X86/ and XCore/ tests.".
Jun 13 2019, 12:25 PM
cameron.mcinally committed rGa0d06a626ffa: Revert "[NFC][CodeGen] Add unary FNeg tests to X86/fma-intrinsics-canonical.ll" (authored by cameron.mcinally).
Revert "[NFC][CodeGen] Add unary FNeg tests to X86/fma-intrinsics-canonical.ll"
Jun 13 2019, 12:25 PM
cameron.mcinally added a reverting change for rGee5881a88cbe: [NFC][CodeGen] Add unary FNeg tests to X86/fma-intrinsics-canonical.ll: rGa0d06a626ffa: Revert "[NFC][CodeGen] Add unary FNeg tests to X86/fma-intrinsics-canonical.ll".
Jun 13 2019, 12:25 PM
cameron.mcinally committed rGa37d925d3d89: Revert "[NFC][CodeGen] Forgot 2 unary FNeg tests in X86/fma-intrinsics… (authored by cameron.mcinally).
Revert "[NFC][CodeGen] Forgot 2 unary FNeg tests in X86/fma-intrinsics…
Jun 13 2019, 12:25 PM
cameron.mcinally added a reverting change for rG5f39a3096f8e: [NFC][CodeGen] Forgot 2 unary FNeg tests in X86/fma-intrinsics-canonical.ll: rGa37d925d3d89: Revert "[NFC][CodeGen] Forgot 2 unary FNeg tests in X86/fma-intrinsics….
Jun 13 2019, 12:25 PM
cameron.mcinally committed rGe00198f7a875: Revert "[NFC][CodeGen] Add unary fneg tests to X86/fma-fneg-combine.ll" (authored by cameron.mcinally).
Revert "[NFC][CodeGen] Add unary fneg tests to X86/fma-fneg-combine.ll"
Jun 13 2019, 12:24 PM
cameron.mcinally added a reverting change for rG10c085554215: [NFC][CodeGen] Add unary fneg tests to X86/fma-fneg-combine.ll: rGe00198f7a875: Revert "[NFC][CodeGen] Add unary fneg tests to X86/fma-fneg-combine.ll".
Jun 13 2019, 12:24 PM
cameron.mcinally committed rGea28a063fd8e: Revert "[NFC][CodeGen] Add unary FNeg tests to X86/combine-fcopysign.ll X86/dag… (authored by cameron.mcinally).
Revert "[NFC][CodeGen] Add unary FNeg tests to X86/combine-fcopysign.ll X86/dag…
Jun 13 2019, 12:24 PM
cameron.mcinally added a reverting change for rGe04c4b6af81d: [NFC][CodeGen] Add unary FNeg tests to X86/combine-fcopysign.ll X86/dag-fmf-cse.: rGea28a063fd8e: Revert "[NFC][CodeGen] Add unary FNeg tests to X86/combine-fcopysign.ll X86/dag….
Jun 13 2019, 12:24 PM
cameron.mcinally committed rG489045719614: Revert "[NFC][CodeGen] Add unary FNeg tests to X86/avx512vl-intrinsics-fast… (authored by cameron.mcinally).
Revert "[NFC][CodeGen] Add unary FNeg tests to X86/avx512vl-intrinsics-fast…
Jun 13 2019, 12:24 PM
cameron.mcinally added a reverting change for rG6fe46ec25d84: [NFC][CodeGen] Add unary FNeg tests to X86/avx512vl-intrinsics-fast-isel.ll…: rG489045719614: Revert "[NFC][CodeGen] Add unary FNeg tests to X86/avx512vl-intrinsics-fast….
Jun 13 2019, 12:24 PM
cameron.mcinally committed rG21a29a9e653a: Revert "[NFC][CodeGen] Add unary FNeg tests to X86/avx512vl-intrinsics-fast… (authored by cameron.mcinally).
Revert "[NFC][CodeGen] Add unary FNeg tests to X86/avx512vl-intrinsics-fast…
Jun 13 2019, 12:24 PM
cameron.mcinally added a reverting change for rG2aa5ada267d2: [NFC][CodeGen] Add unary FNeg tests to X86/avx512vl-intrinsics-fast-isel.ll: rG21a29a9e653a: Revert "[NFC][CodeGen] Add unary FNeg tests to X86/avx512vl-intrinsics-fast….
Jun 13 2019, 12:24 PM
cameron.mcinally committed rG7d4e7efd2e16: Revert "[NFC][CodeGen] Add unary FNeg tests to X86/avx512vl-intrinsics-fast… (authored by cameron.mcinally).
Revert "[NFC][CodeGen] Add unary FNeg tests to X86/avx512vl-intrinsics-fast…
Jun 13 2019, 12:24 PM
cameron.mcinally added a reverting change for rG27a5db9de57d: [NFC][CodeGen] Add unary FNeg tests to X86/avx512vl-intrinsics-fast-isel.ll: rG7d4e7efd2e16: Revert "[NFC][CodeGen] Add unary FNeg tests to X86/avx512vl-intrinsics-fast….
Jun 13 2019, 12:24 PM
cameron.mcinally committed rG8608afa964d2: Revert "[NFC][CodeGen] Add unary FNeg tests to X86/avx512-intrinsics-fast-isel. (authored by cameron.mcinally).
Revert "[NFC][CodeGen] Add unary FNeg tests to X86/avx512-intrinsics-fast-isel.
Jun 13 2019, 12:24 PM
cameron.mcinally added a reverting change for rG41e0b9f28030: [NFC][CodeGen] Add unary FNeg tests to X86/avx512-intrinsics-fast-isel.ll: rG8608afa964d2: Revert "[NFC][CodeGen] Add unary FNeg tests to X86/avx512-intrinsics-fast-isel..
Jun 13 2019, 12:24 PM
cameron.mcinally committed rG675be5db469f: Revert "[NFC][CodeGen] Add unary FNeg tests to X86/avx512-intrinsics-fast-isel. (authored by cameron.mcinally).
Revert "[NFC][CodeGen] Add unary FNeg tests to X86/avx512-intrinsics-fast-isel.
Jun 13 2019, 12:24 PM
cameron.mcinally added a reverting change for rGaeb89f8b33d8: [NFC][CodeGen] Add unary FNeg tests to X86/avx512-intrinsics-fast-isel.ll: rG675be5db469f: Revert "[NFC][CodeGen] Add unary FNeg tests to X86/avx512-intrinsics-fast-isel..
Jun 13 2019, 12:24 PM
cameron.mcinally committed rGaeb89f8b33d8: [NFC][CodeGen] Add unary FNeg tests to X86/avx512-intrinsics-fast-isel.ll (authored by cameron.mcinally).
[NFC][CodeGen] Add unary FNeg tests to X86/avx512-intrinsics-fast-isel.ll
Jun 13 2019, 8:53 AM

Jun 12 2019

cameron.mcinally committed rG41e0b9f28030: [NFC][CodeGen] Add unary FNeg tests to X86/avx512-intrinsics-fast-isel.ll (authored by cameron.mcinally).
[NFC][CodeGen] Add unary FNeg tests to X86/avx512-intrinsics-fast-isel.ll
Jun 12 2019, 3:49 PM
cameron.mcinally committed rG27a5db9de57d: [NFC][CodeGen] Add unary FNeg tests to X86/avx512vl-intrinsics-fast-isel.ll (authored by cameron.mcinally).
[NFC][CodeGen] Add unary FNeg tests to X86/avx512vl-intrinsics-fast-isel.ll
Jun 12 2019, 1:55 PM
cameron.mcinally committed rG2aa5ada267d2: [NFC][CodeGen] Add unary FNeg tests to X86/avx512vl-intrinsics-fast-isel.ll (authored by cameron.mcinally).
[NFC][CodeGen] Add unary FNeg tests to X86/avx512vl-intrinsics-fast-isel.ll
Jun 12 2019, 12:37 PM
cameron.mcinally accepted D63214: [InstCombine] canonicalize fmin/fmax to LLVM intrinsics minnum/maxnum.

LGTM

Jun 12 2019, 11:37 AM · Restricted Project

Jun 11 2019

cameron.mcinally committed rG6fe46ec25d84: [NFC][CodeGen] Add unary FNeg tests to X86/avx512vl-intrinsics-fast-isel.ll… (authored by cameron.mcinally).
[NFC][CodeGen] Add unary FNeg tests to X86/avx512vl-intrinsics-fast-isel.ll…
Jun 11 2019, 5:16 PM
cameron.mcinally committed rGe04c4b6af81d: [NFC][CodeGen] Add unary FNeg tests to X86/combine-fcopysign.ll X86/dag-fmf-cse. (authored by cameron.mcinally).
[NFC][CodeGen] Add unary FNeg tests to X86/combine-fcopysign.ll X86/dag-fmf-cse.
Jun 11 2019, 11:55 AM
cameron.mcinally committed rG10c085554215: [NFC][CodeGen] Add unary fneg tests to X86/fma-fneg-combine.ll (authored by cameron.mcinally).
[NFC][CodeGen] Add unary fneg tests to X86/fma-fneg-combine.ll
Jun 11 2019, 10:03 AM
cameron.mcinally committed rG08200d6d26e9: [InstCombine] Handle -(X-Y) --> (Y-X) for unary fneg when NSZ (authored by cameron.mcinally).
[InstCombine] Handle -(X-Y) --> (Y-X) for unary fneg when NSZ
Jun 11 2019, 9:21 AM
cameron.mcinally accepted D62414: [InstCombine] canonicalize fcmp+select to minnum/maxnum intrinsics.

LGTM

Jun 11 2019, 9:17 AM · Restricted Project
cameron.mcinally committed rG796de11331e6: [InstCombine] Update fptrunc (fneg x)) -> (fneg (fptrunc x) for unary FNeg (authored by cameron.mcinally).
[InstCombine] Update fptrunc (fneg x)) -> (fneg (fptrunc x) for unary FNeg
Jun 11 2019, 8:46 AM
cameron.mcinally added inline comments to D62414: [InstCombine] canonicalize fcmp+select to minnum/maxnum intrinsics.
Jun 11 2019, 8:41 AM · Restricted Project