Page MenuHomePhabricator
Feed Advanced Search

Thu, Jun 17

DavidTruby added reviewers for D104471: [llvm][sve] Lowering for VLS truncating stores: paulwalker-arm, peterwaller-arm, bsmith, joechrisellis.
Thu, Jun 17, 9:59 AM · Restricted Project
DavidTruby requested review of D104471: [llvm][sve] Lowering for VLS truncating stores.
Thu, Jun 17, 9:58 AM · Restricted Project

May 20 2021

DavidTruby committed rGbf3b6cf92081: [llvm][sve] Lowering for VLS MLOAD/MSTORE (authored by DavidTruby).
[llvm][sve] Lowering for VLS MLOAD/MSTORE
May 20 2021, 4:06 AM
DavidTruby closed D101834: [llvm][sve] Lowering for VLS MLOAD/MSTORE.
May 20 2021, 4:06 AM · Restricted Project
DavidTruby updated the diff for D101834: [llvm][sve] Lowering for VLS MLOAD/MSTORE.

Ensure v and s registers used are the same in <2 x half> tests

May 20 2021, 3:44 AM · Restricted Project
DavidTruby updated the diff for D101834: [llvm][sve] Lowering for VLS MLOAD/MSTORE.

Added tests for <2 x half>

May 20 2021, 3:30 AM · Restricted Project

May 19 2021

DavidTruby added inline comments to D101834: [llvm][sve] Lowering for VLS MLOAD/MSTORE.
May 19 2021, 6:56 AM · Restricted Project

May 18 2021

DavidTruby added inline comments to D101834: [llvm][sve] Lowering for VLS MLOAD/MSTORE.
May 18 2021, 4:51 AM · Restricted Project
DavidTruby updated the diff for D101834: [llvm][sve] Lowering for VLS MLOAD/MSTORE.

Update tests for review and fix erroneous if statement
Include suggestion of returning automatically rather than introducing a variable

May 18 2021, 4:48 AM · Restricted Project

May 12 2021

DavidTruby updated the diff for D101834: [llvm][sve] Lowering for VLS MLOAD/MSTORE.

Add guard against truncating stores and extending loads

May 12 2021, 6:53 AM · Restricted Project
DavidTruby updated the diff for D101834: [llvm][sve] Lowering for VLS MLOAD/MSTORE.

Spelling and whitespace fixes

May 12 2021, 5:23 AM · Restricted Project
DavidTruby added inline comments to D101834: [llvm][sve] Lowering for VLS MLOAD/MSTORE.
May 12 2021, 5:19 AM · Restricted Project
DavidTruby updated the diff for D101834: [llvm][sve] Lowering for VLS MLOAD/MSTORE.

Improved tests and removed unnecessary if statements

May 12 2021, 5:15 AM · Restricted Project
DavidTruby updated the diff for D99074: [llvm][AArch64][SVE] Fold literals into math instructions.

Fixed accidentally overwriting this with a different patch...

May 12 2021, 5:14 AM · Restricted Project
DavidTruby updated the diff for D99074: [llvm][AArch64][SVE] Fold literals into math instructions.
May 12 2021, 5:13 AM · Restricted Project

May 5 2021

DavidTruby updated the diff for D99074: [llvm][AArch64][SVE] Fold literals into math instructions.

Separated zeroing forms and regenreated check lines

May 5 2021, 6:01 AM · Restricted Project
DavidTruby updated the diff for D101834: [llvm][sve] Lowering for VLS MLOAD/MSTORE.

Fixed erroneous use of ", true" and ran clang-format

May 5 2021, 5:31 AM · Restricted Project

May 4 2021

DavidTruby added reviewers for D101834: [llvm][sve] Lowering for VLS MLOAD/MSTORE: sdesmalen, kmclaughlin, joechrisellis, peterwaller-arm, paulwalker-arm, bsmith.
May 4 2021, 7:33 AM · Restricted Project
DavidTruby updated subscribers of D101834: [llvm][sve] Lowering for VLS MLOAD/MSTORE.
May 4 2021, 7:32 AM · Restricted Project
DavidTruby requested review of D101834: [llvm][sve] Lowering for VLS MLOAD/MSTORE.
May 4 2021, 7:31 AM · Restricted Project

Apr 20 2021

DavidTruby accepted D100655: [flang][nfc] Port 2 tests to use the new driver when enabled.

LGTM

Apr 20 2021, 3:05 AM · Restricted Project, Restricted Project

Apr 19 2021

DavidTruby added a comment to D99074: [llvm][AArch64][SVE] Fold literals into math instructions.

ping

Apr 19 2021, 3:02 AM · Restricted Project

Apr 7 2021

DavidTruby updated the diff for D99074: [llvm][AArch64][SVE] Fold literals into math instructions.

Moved the zeroing predicates behind the UseExperimentalZeroingPseudos feature
Added additional tests for one of the patterns
Addressed misc reivew comments

Apr 7 2021, 5:47 AM · Restricted Project

Mar 29 2021

DavidTruby added a reviewer for D99074: [llvm][AArch64][SVE] Fold literals into math instructions: joechrisellis.
Mar 29 2021, 8:50 AM · Restricted Project
DavidTruby added inline comments to D99074: [llvm][AArch64][SVE] Fold literals into math instructions.
Mar 29 2021, 7:28 AM · Restricted Project
DavidTruby updated the diff for D99074: [llvm][AArch64][SVE] Fold literals into math instructions.

Refactored patterns into helper multiclass

Mar 29 2021, 7:27 AM · Restricted Project
DavidTruby updated the diff for D99074: [llvm][AArch64][SVE] Fold literals into math instructions.

Added extra tests for fmax, fmaxnm, fmin, fminnm

Mar 29 2021, 6:36 AM · Restricted Project

Mar 22 2021

DavidTruby added reviewers for D99074: [llvm][AArch64][SVE] Fold literals into math instructions: paulwalker-arm, peterwaller-arm, bsmith, sdesmalen, c-rhodes.
Mar 22 2021, 6:16 AM · Restricted Project
DavidTruby requested review of D99074: [llvm][AArch64][SVE] Fold literals into math instructions.
Mar 22 2021, 6:15 AM · Restricted Project

Feb 16 2021

DavidTruby added inline comments to D96700: [llvm][Aarch64][SVE] Remove extra fmov instruction with certain literals.
Feb 16 2021, 6:18 AM · Restricted Project
DavidTruby committed rGe86f9ba15c41: [llvm][Aarch64][SVE] Remove extra fmov instruction with certain literals (authored by DavidTruby).
[llvm][Aarch64][SVE] Remove extra fmov instruction with certain literals
Feb 16 2021, 6:17 AM
DavidTruby closed D96700: [llvm][Aarch64][SVE] Remove extra fmov instruction with certain literals.
Feb 16 2021, 6:17 AM · Restricted Project

Feb 15 2021

DavidTruby updated the diff for D96700: [llvm][Aarch64][SVE] Remove extra fmov instruction with certain literals.

Remove faulty f64 patterns

Feb 15 2021, 6:33 AM · Restricted Project
DavidTruby added inline comments to D96700: [llvm][Aarch64][SVE] Remove extra fmov instruction with certain literals.
Feb 15 2021, 6:29 AM · Restricted Project
DavidTruby added inline comments to D96700: [llvm][Aarch64][SVE] Remove extra fmov instruction with certain literals.
Feb 15 2021, 5:38 AM · Restricted Project
DavidTruby updated the diff for D96700: [llvm][Aarch64][SVE] Remove extra fmov instruction with certain literals.

Added equivalent f64 patterns

Feb 15 2021, 5:30 AM · Restricted Project
DavidTruby added reviewers for D96700: [llvm][Aarch64][SVE] Remove extra fmov instruction with certain literals: paulwalker-arm, joechrisellis, peterwaller-arm, bsmith.
Feb 15 2021, 4:10 AM · Restricted Project
DavidTruby requested review of D96700: [llvm][Aarch64][SVE] Remove extra fmov instruction with certain literals.
Feb 15 2021, 4:09 AM · Restricted Project

Feb 10 2021

DavidTruby accepted D96423: [DebugInfo] Only perform TypeSize -> unsigned cast when necessary.

LGTM!

Feb 10 2021, 10:11 AM · Restricted Project

Feb 8 2021

DavidTruby resigned from D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.
Feb 8 2021, 6:00 AM · Restricted Project, Restricted Project, Restricted Project

Jan 20 2021

DavidTruby resigned from D89368: [flang][windows] Run regression tests under Windows. NFCI..
Jan 20 2021, 12:27 PM · Restricted Project, Restricted Project
DavidTruby resigned from D94707: [Flang] Fix compilation on MinGW-w64.
Jan 20 2021, 12:27 PM · Restricted Project, Restricted Project

Jan 15 2021

DavidTruby resigned from D82159: Add a cmake warning when someone tries to configure clang-tools-extra without clang.
Jan 15 2021, 6:14 AM · Restricted Project
DavidTruby resigned from D83397: [flang] Replace uses of _Complex with std::complex.
Jan 15 2021, 6:13 AM · Restricted Project, Restricted Project
DavidTruby resigned from D92732: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs.
Jan 15 2021, 6:13 AM · Restricted Project, Restricted Project, Restricted Project
DavidTruby resigned from D87056: [POC] SVE/SVE2 implementation (LLVM 9).
Jan 15 2021, 6:12 AM · Restricted Project, Restricted Project
DavidTruby added a comment to D87672: [doc] Fix typos.

Did this change ever get committed?

Jan 15 2021, 6:12 AM · Restricted Project

Jan 12 2021

DavidTruby committed rGe5f51fdd650c: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate (authored by DavidTruby).
[clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate
Jan 12 2021, 11:44 AM
DavidTruby closed D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate.
Jan 12 2021, 11:44 AM · Restricted Project, Restricted Project

Jan 11 2021

DavidTruby updated the diff for D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate.

Fix tests to use check-label correctly and add proper precondition on aarch64

Jan 11 2021, 6:18 AM · Restricted Project, Restricted Project

Jan 6 2021

DavidTruby added inline comments to D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate.
Jan 6 2021, 8:53 PM · Restricted Project, Restricted Project
DavidTruby updated the diff for D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate.

Refactor based on review

Jan 6 2021, 8:51 PM · Restricted Project, Restricted Project

Jan 4 2021

DavidTruby updated the diff for D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate.

Switch from CHECK to CHECK-LABEL in tests.

Jan 4 2021, 4:23 AM · Restricted Project, Restricted Project
DavidTruby added inline comments to D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate.
Jan 4 2021, 4:16 AM · Restricted Project, Restricted Project
DavidTruby added inline comments to D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate.
Jan 4 2021, 4:15 AM · Restricted Project, Restricted Project
DavidTruby updated the diff for D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate.

Refactor based on review comments

Jan 4 2021, 4:13 AM · Restricted Project, Restricted Project

Dec 15 2020

DavidTruby updated the diff for D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate.

Add additional callee-side tests

Dec 15 2020, 9:24 AM · Restricted Project, Restricted Project
DavidTruby added reviewers for D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate: rnk, asl.
Dec 15 2020, 7:50 AM · Restricted Project, Restricted Project
DavidTruby retitled D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate from Precondition isHomogeneousAggregate on isCXX14Aggregate to [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate.
Dec 15 2020, 7:49 AM · Restricted Project, Restricted Project
DavidTruby updated the diff for D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate.

Added extra tests for additional conditions and IR -> assembly tests.

Dec 15 2020, 7:45 AM · Restricted Project, Restricted Project

Dec 7 2020

DavidTruby added reviewers for D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate: peterwaller-arm, richard.townsend.arm.
Dec 7 2020, 3:17 AM · Restricted Project, Restricted Project
DavidTruby requested review of D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate.
Dec 7 2020, 3:17 AM · Restricted Project, Restricted Project

Oct 30 2020

DavidTruby closed D90158: [Aarch64] Fix assumption that Windows implies x86.

Committed as rG81b96bb6f1caee90ad64c9c7c80b55c163b1f6a8

Oct 30 2020, 5:13 AM · Restricted Project
DavidTruby committed rG81b96bb6f1ca: [Aarch64] Fix assumption that Windows implies x86 (authored by DavidTruby).
[Aarch64] Fix assumption that Windows implies x86
Oct 30 2020, 5:12 AM

Oct 26 2020

DavidTruby added a reviewer for D90158: [Aarch64] Fix assumption that Windows implies x86: arm-chrjan01.
Oct 26 2020, 12:13 PM · Restricted Project
DavidTruby accepted D90146: [SVE] Fix TypeSize warning in llvm::getGEPInductionOperand.

LGTM!

Oct 26 2020, 8:04 AM · Restricted Project
DavidTruby requested review of D90158: [Aarch64] Fix assumption that Windows implies x86.
Oct 26 2020, 7:59 AM · Restricted Project

Oct 14 2020

DavidTruby accepted D89403: [flang] Fix CMake bug in the definition of flang-new.

LGTM

Oct 14 2020, 10:16 AM · Restricted Project

Sep 30 2020

DavidTruby added a comment to D87073: [flang]Fix for PR47339.

Ah ok, can we close this review then? Thanks!

Sep 30 2020, 6:07 AM · Restricted Project
DavidTruby resigned from D84064: [flang][openacc] OpenACC module signature.
Sep 30 2020, 5:41 AM · Restricted Project, Restricted Project
DavidTruby added a comment to D87073: [flang]Fix for PR47339.

Is something blocking this change being committed?

Sep 30 2020, 5:40 AM · Restricted Project
DavidTruby added a comment to D87672: [doc] Fix typos.

@YangZhihui if you don't have commit access I can commit this for you. Could you let me know the name and email address you'd like it committed under please? Thanks!

Sep 30 2020, 5:37 AM · Restricted Project
DavidTruby resigned from D82176: [flang][OpenMP] Added parser support for Iterators (OpenMP 5.0) and updated depend clause.
Sep 30 2020, 5:36 AM · Restricted Project, Restricted Project
DavidTruby resigned from D87499: [DebugInfo] Flang should not emit DW_AT_main_subprogram for DWARF version lower than 4.
Sep 30 2020, 5:35 AM · Restricted Project, debug-info
DavidTruby resigned from D87906: [Flang][OpenACC] Fix for branching out issue in OpenACC parallel construct..
Sep 30 2020, 5:35 AM · Restricted Project, Restricted Project
DavidTruby accepted D88109: [flang][msvc] Avoid ReferenceVariantBase ctor ambiguity. NFC..

LGTM. Not sure why msvc thinks these are ambiguous

Sep 30 2020, 5:35 AM · Restricted Project, Restricted Project
DavidTruby resigned from D88253: [flang][openacc] Update loop construct lowering.
Sep 30 2020, 5:34 AM · Restricted Project, Restricted Project
DavidTruby resigned from D88313: [flang] Failed call to CHECK() for call to ASSOCIATED(NULL()).
Sep 30 2020, 5:34 AM · Restricted Project, Restricted Project
DavidTruby accepted D88556: [Flang][OpenMP] Fix issue in only a single nowait clause can appear on a sections directive..

LGTM

Sep 30 2020, 5:34 AM · Restricted Project, Restricted Project
DavidTruby retitled D86071: [MLIR][OpenMP] Add omp.wsloop operation from [MLIR][OpenMP] Add omp.do operation to [MLIR][OpenMP] Add omp.wsloop operation.
Sep 30 2020, 5:33 AM · Restricted Project, Restricted Project
DavidTruby updated the diff for D86071: [MLIR][OpenMP] Add omp.wsloop operation.

Add indexes for loop-style implementation, and rename operation to omp.wsloop

Sep 30 2020, 5:33 AM · Restricted Project, Restricted Project
DavidTruby resigned from D88511: [flang][msvc] long double is not different from double..
Sep 30 2020, 4:14 AM · Restricted Project, Restricted Project

Sep 24 2020

DavidTruby added inline comments to D88219: [flang][driver] Remove unnecessary includes in the unittest.
Sep 24 2020, 5:19 AM · Restricted Project
DavidTruby committed rG956a84da0616: [flang] [OpenMP 4.5] Adding lit test cases for OpenMP Constructs. (authored by praveen).
[flang] [OpenMP 4.5] Adding lit test cases for OpenMP Constructs.
Sep 24 2020, 5:09 AM
DavidTruby closed D87908: [flang] [OpenMP 4.5] Adding lit test cases for OpenMP Constructs..
Sep 24 2020, 5:09 AM · Restricted Project, Restricted Project, Restricted Project
DavidTruby accepted D88219: [flang][driver] Remove unnecessary includes in the unittest.

LGTM, perhaps put NFC in the commit message?

Sep 24 2020, 5:00 AM · Restricted Project

Sep 23 2020

DavidTruby added a comment to D87908: [flang] [OpenMP 4.5] Adding lit test cases for OpenMP Constructs..

@kiranktp @DavidTruby Thanks for the review.

I do not have commit access . Can someone commit the changes on my behalf ?

Sep 23 2020, 7:07 AM · Restricted Project, Restricted Project, Restricted Project

Sep 22 2020

DavidTruby abandoned D85508: [flang] Add rudimentary empty function lowering to tco.

As discussed on flang-dev I am closing this to not block anyone else's progress on upstreaming.

Sep 22 2020, 9:53 AM · Restricted Project
DavidTruby abandoned D85509: [flang] Add rudimentary bbc tool infrastructure..

As discussed on flang-dev I am closing this to not block anyone else's progress on upstreaming.

Sep 22 2020, 9:53 AM · Restricted Project
DavidTruby abandoned D85510: [flang] Upstream lowering of empty functions and programs..

As discussed on flang-dev I am closing this to not block anyone else's progress on upstreaming.

Sep 22 2020, 9:53 AM · Restricted Project
DavidTruby added inline comments to D87684: [mlir]Add Allocate Clause to OMP Parallel Operation Definition.
Sep 22 2020, 6:47 AM · Restricted Project
DavidTruby committed rGbf202b8ce77c: [NFC][mlir] Remove llvm:: prefix from SmallVector in parallel pretty printer. (authored by DavidTruby).
[NFC][mlir] Remove llvm:: prefix from SmallVector in parallel pretty printer.
Sep 22 2020, 6:46 AM
DavidTruby closed D88025: [NFC][mlir] Remove llvm:: prefix from SmallVector in parallel pretty printer..
Sep 22 2020, 6:46 AM · Restricted Project
DavidTruby accepted D88001: [flang][msvc] Add explicit function template argument to applyLamda. NFC..

LGTM

Sep 22 2020, 6:11 AM · Restricted Project
DavidTruby accepted D88052: [flang][msvc] Explicitly reference "this" inside closure. NFC..

LGTM

Sep 22 2020, 6:11 AM · Restricted Project, Restricted Project
DavidTruby accepted D87961: [flang][msvc] Add explicit function template argument to applyFunction. NFC..

LGTM. Odd that msvc needs this clarification though.

Sep 22 2020, 6:10 AM · Restricted Project, Restricted Project
DavidTruby accepted D87908: [flang] [OpenMP 4.5] Adding lit test cases for OpenMP Constructs..

LGTM!
@kiranktp I believe most of the semantic checks are still only targeting OpenMP 4.5, at least the ones that I implemented are as that was the target spec last time I checked. If this hasn't significantly changed then upgrading the tests to OpenMP 5 will cause failures.

Sep 22 2020, 6:07 AM · Restricted Project, Restricted Project, Restricted Project

Sep 21 2020

DavidTruby added a comment to D88025: [NFC][mlir] Remove llvm:: prefix from SmallVector in parallel pretty printer..

As requested on https://reviews.llvm.org/D87684

Sep 21 2020, 8:23 AM · Restricted Project
DavidTruby requested review of D88025: [NFC][mlir] Remove llvm:: prefix from SmallVector in parallel pretty printer..
Sep 21 2020, 8:23 AM · Restricted Project

Sep 18 2020

DavidTruby added a comment to D86071: [MLIR][OpenMP] Add omp.wsloop operation.

I have submitted an RFC on the openmp do loop design here: https://llvm.discourse.group/t/openmp-worksharing-loop-rfc/1815

Sep 18 2020, 7:15 AM · Restricted Project, Restricted Project