Page MenuHomePhabricator
Feed Advanced Search

Fri, Jul 31

cchen added a comment to D82245: [libomptarget] Add support for target update non-contiguous.

ping

Fri, Jul 31, 12:43 PM · Restricted Project, Restricted Project

Fri, Jul 24

cchen added a comment to D82245: [libomptarget] Add support for target update non-contiguous.

Ping, compiler support is in this patch: https://reviews.llvm.org/D84192.

Fri, Jul 24, 9:16 AM · Restricted Project, Restricted Project
cchen added a comment to D84192: [OpenMP5.0] map item can be non-contiguous for target update.

@ABataev, do I need to wait for the runtime patch to commit this one? If so, do you have some recommend reviewers for me to add to that patch? I have pinged several times for that patch but haven't got many reviews for it. Thanks!

Fri, Jul 24, 9:06 AM · Restricted Project
cchen updated the diff for D84192: [OpenMP5.0] map item can be non-contiguous for target update.

Fix coding style and argument on getIntTypeForBitwidth

Fri, Jul 24, 8:54 AM · Restricted Project
cchen added a comment to D84192: [OpenMP5.0] map item can be non-contiguous for target update.

@ABataev, is there any other concern for this patch?

Fri, Jul 24, 8:36 AM · Restricted Project

Wed, Jul 22

cchen abandoned D69316: [OpenMP 5.0] target update list items need not be contiguous (Sema).
Wed, Jul 22, 1:50 PM · Restricted Project, Restricted Project
cchen added a comment to D84192: [OpenMP5.0] map item can be non-contiguous for target update.

Also, what about compatibility with declare mapper? Can you add tests for it?

There's a restriction for map clause that non-contiguous is not allowed and I guess it also applies to declare mapper.

I see that to/from clauses allow to use mappers too:

to([mapper(mapper-identifier):]locator-list) from([mapper(mapper-identifier):]locator-list

I'm confused of how to use to([mapper(mapper-identifier):]locator-list) with array section.
For this case:

class C {
public:
  int a;
  double b[3][4][5];
};

#pragma omp declare mapper(id: C s) map(s.a, s.b[0:3][0:4][0:5])

#pragma omp target update from(mapper(id): c)

Clang already has a semantic check in from clause when mapper is used: "mapper type must be of struct, union or class type".
So the only item I can put in from clause in the above example is c and I cannot put c.b[0:2][1:2][0:2] or any even c.b[0:2].

Does clang compile your example? If not, shall it be allowed for to/from clauses or not?

Clang can compile my example but the problem is that Clang do not accept something like #pragma omp target update from(mapper(id): c.b[0:2][1:2][2:2]) (non-contiguous) or even #pragma omp target update from(mapper(id): c.b[2][1][0:2]) (contiguous).
Actually, Clang now only accepts c as struct/union/class type in from(mapper(id): c). And the reason for the restriction is from declare mapper directive - "The type must be of struct, union or class type in C and C++".

And it is fine. How does it work in declare mapper, the main question? Does it support extended array sections format mapoers with maps, to and from? Shall it be supported in declare mapper at all?

After discussing with @dreachem, my understanding is that it is not incorrect to not allowing extended/non-contiguous array section to appear in declare mapper.
For the declare mapper directive, since spec only allows map clause, extended array section (with stride) or non-contiguous array section are both not allowed.
For using the mapper in map/to/from clause, if mapping or updating an array section of type T, where there is a mapper declared for T, then the mapper needs to apply as if to each element of the array or array section. Spec is intentionally not sufficiently clear on this for target update so the semantic check in Clang is not incorrect. Which lead to the fact that I might not need to support extended/non-contiguous array section for declare mapper.

What exactly is incorrect in clang sema?

Wed, Jul 22, 12:20 PM · Restricted Project
cchen added a comment to D84192: [OpenMP5.0] map item can be non-contiguous for target update.

Also, what about compatibility with declare mapper? Can you add tests for it?

There's a restriction for map clause that non-contiguous is not allowed and I guess it also applies to declare mapper.

I see that to/from clauses allow to use mappers too:

to([mapper(mapper-identifier):]locator-list) from([mapper(mapper-identifier):]locator-list

I'm confused of how to use to([mapper(mapper-identifier):]locator-list) with array section.
For this case:

class C {
public:
  int a;
  double b[3][4][5];
};

#pragma omp declare mapper(id: C s) map(s.a, s.b[0:3][0:4][0:5])

#pragma omp target update from(mapper(id): c)

Clang already has a semantic check in from clause when mapper is used: "mapper type must be of struct, union or class type".
So the only item I can put in from clause in the above example is c and I cannot put c.b[0:2][1:2][0:2] or any even c.b[0:2].

Does clang compile your example? If not, shall it be allowed for to/from clauses or not?

Clang can compile my example but the problem is that Clang do not accept something like #pragma omp target update from(mapper(id): c.b[0:2][1:2][2:2]) (non-contiguous) or even #pragma omp target update from(mapper(id): c.b[2][1][0:2]) (contiguous).
Actually, Clang now only accepts c as struct/union/class type in from(mapper(id): c). And the reason for the restriction is from declare mapper directive - "The type must be of struct, union or class type in C and C++".

And it is fine. How does it work in declare mapper, the main question? Does it support extended array sections format mapoers with maps, to and from? Shall it be supported in declare mapper at all?

Wed, Jul 22, 12:15 PM · Restricted Project

Tue, Jul 21

cchen added a comment to D84192: [OpenMP5.0] map item can be non-contiguous for target update.

Also, what about compatibility with declare mapper? Can you add tests for it?

There's a restriction for map clause that non-contiguous is not allowed and I guess it also applies to declare mapper.

I see that to/from clauses allow to use mappers too:

to([mapper(mapper-identifier):]locator-list) from([mapper(mapper-identifier):]locator-list

I'm confused of how to use to([mapper(mapper-identifier):]locator-list) with array section.
For this case:

class C {
public:
  int a;
  double b[3][4][5];
};

#pragma omp declare mapper(id: C s) map(s.a, s.b[0:3][0:4][0:5])

#pragma omp target update from(mapper(id): c)

Clang already has a semantic check in from clause when mapper is used: "mapper type must be of struct, union or class type".
So the only item I can put in from clause in the above example is c and I cannot put c.b[0:2][1:2][0:2] or any even c.b[0:2].

Does clang compile your example? If not, shall it be allowed for to/from clauses or not?

Tue, Jul 21, 3:52 PM · Restricted Project
cchen added a comment to D84192: [OpenMP5.0] map item can be non-contiguous for target update.

Also, what about compatibility with declare mapper? Can you add tests for it?

There's a restriction for map clause that non-contiguous is not allowed and I guess it also applies to declare mapper.

I see that to/from clauses allow to use mappers too:

to([mapper(mapper-identifier):]locator-list) from([mapper(mapper-identifier):]locator-list
Tue, Jul 21, 2:59 PM · Restricted Project
cchen added a comment to D84192: [OpenMP5.0] map item can be non-contiguous for target update.

Also, what about compatibility with declare mapper? Can you add tests for it?

There's a restriction for map clause that non-contiguous is not allowed and I guess it also applies to declare mapper.

I see that to/from clauses allow to use mappers too:

to([mapper(mapper-identifier):]locator-list) from([mapper(mapper-identifier):]locator-list
Tue, Jul 21, 2:20 PM · Restricted Project
cchen updated the diff for D84192: [OpenMP5.0] map item can be non-contiguous for target update.

Fix based on feedback

Tue, Jul 21, 2:04 PM · Restricted Project
cchen added a comment to D84192: [OpenMP5.0] map item can be non-contiguous for target update.

Also, what about compatibility with declare mapper? Can you add tests for it?

Tue, Jul 21, 2:03 PM · Restricted Project

Mon, Jul 20

cchen abandoned D79972: [OpenMP5.0] map item can be non-contiguous for target update.

Created a new patch with the support for stride: https://reviews.llvm.org/D84192.

Mon, Jul 20, 9:16 PM · Restricted Project
cchen updated the diff for D82245: [libomptarget] Add support for target update non-contiguous.

Modify test for supporting stride in target update non-contiguous

Mon, Jul 20, 9:16 PM · Restricted Project, Restricted Project
Herald added a project to D84192: [OpenMP5.0] map item can be non-contiguous for target update: Restricted Project.
Mon, Jul 20, 9:16 PM · Restricted Project

Thu, Jul 9

cchen added a reviewer for D82245: [libomptarget] Add support for target update non-contiguous: AndreyChurbanov.
Thu, Jul 9, 12:13 PM · Restricted Project, Restricted Project
cchen committed rG2da9572a9b10: [OPENMP50] extend array section for stride (Parsing/Sema/AST) (authored by cchen).
[OPENMP50] extend array section for stride (Parsing/Sema/AST)
Thu, Jul 9, 11:35 AM
cchen closed D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST).
Thu, Jul 9, 11:34 AM · Restricted Project
cchen added a comment to D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST).

@ABataev , can you commit this patch for me when you have time? Thanks.

I think you can request commit access from Chris Lattner and commit it yourself.

Thu, Jul 9, 8:52 AM · Restricted Project
cchen added a comment to D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST).

@ABataev , can you commit this patch for me when you have time? Thanks.

Thu, Jul 9, 8:34 AM · Restricted Project

Wed, Jul 8

cchen updated the diff for D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST).

Fix message and rebase

Wed, Jul 8, 3:59 PM · Restricted Project
cchen added a comment to rG90b54fa045e3: [OPENMP50]Codegen for use_device_addr clauses..

Not sure whether I should put it here or Bugzilla. I found there is an internal compiler error for both use_device_ptr and use_device_addr both when running on host (clang -fopenmp -fopenmp-version=50 test.c).

Wed, Jul 8, 2:51 PM

Tue, Jul 7

cchen added inline comments to D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST).
Tue, Jul 7, 1:07 PM · Restricted Project
cchen added inline comments to D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST).
Tue, Jul 7, 12:54 PM · Restricted Project

Mon, Jul 6

cchen updated the diff for D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST).

Fix based on comment

Mon, Jul 6, 4:00 PM · Restricted Project
cchen updated the diff for D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST).

Move analysis of stride from Sema to Parse

Mon, Jul 6, 2:35 PM · Restricted Project
cchen added inline comments to D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST).
Mon, Jul 6, 11:28 AM · Restricted Project
cchen added inline comments to D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST).
Mon, Jul 6, 10:14 AM · Restricted Project
cchen added a comment to D82245: [libomptarget] Add support for target update non-contiguous.

ping

Mon, Jul 6, 10:03 AM · Restricted Project, Restricted Project

Jul 2 2020

cchen updated the diff for D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST).

Fix based on feedback

Jul 2 2020, 2:36 PM · Restricted Project
cchen updated the diff for D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST).

Rebase

Jul 2 2020, 12:57 PM · Restricted Project

Jul 1 2020

cchen added reviewers for D82245: [libomptarget] Add support for target update non-contiguous: hfinkel, Meinersbur, kkwli0, Hahnfeld.
Jul 1 2020, 2:36 PM · Restricted Project, Restricted Project

Jun 30 2020

cchen added a comment to D79972: [OpenMP5.0] map item can be non-contiguous for target update.

@ABataev , I'm considering emitting an extra dimension for a non-contiguous descriptor to support stride in this patch (stride = 1 in array section is just a special case for computing stride, however, the formula computing stride do not change). Do you think I should do it in this patch?

Jun 30 2020, 3:46 PM · Restricted Project
cchen added inline comments to D79972: [OpenMP5.0] map item can be non-contiguous for target update.
Jun 30 2020, 10:18 AM · Restricted Project

Jun 29 2020

cchen updated the diff for D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST).
  1. Remove a commit that is not on master branch
  2. Add a rule in Sema to avoid non-contiguous array section for map clause
  3. Add tests
Jun 29 2020, 4:06 PM · Restricted Project
cchen added inline comments to D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST).
Jun 29 2020, 1:36 PM · Restricted Project
cchen updated the diff for D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST).

Revert unnecessary changes made by bot

Jun 29 2020, 1:01 PM · Restricted Project
cchen created D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST).
Jun 29 2020, 12:28 PM · Restricted Project
cchen added a comment to D82245: [libomptarget] Add support for target update non-contiguous.

ping

Jun 29 2020, 12:28 PM · Restricted Project, Restricted Project

Jun 26 2020

cchen updated the diff for D79972: [OpenMP5.0] map item can be non-contiguous for target update.

Rebase and resolve conflictions

Jun 26 2020, 10:55 AM · Restricted Project
cchen updated the diff for D79972: [OpenMP5.0] map item can be non-contiguous for target update.

Fix based on feedback

Jun 26 2020, 8:44 AM · Restricted Project

Jun 25 2020

cchen updated the diff for D79972: [OpenMP5.0] map item can be non-contiguous for target update.

Pass Info directly

Jun 25 2020, 3:18 PM · Restricted Project
cchen updated the diff for D79972: [OpenMP5.0] map item can be non-contiguous for target update.

Fix based on feedback

Jun 25 2020, 2:44 PM · Restricted Project
cchen added inline comments to D79972: [OpenMP5.0] map item can be non-contiguous for target update.
Jun 25 2020, 1:39 PM · Restricted Project
cchen added inline comments to D79972: [OpenMP5.0] map item can be non-contiguous for target update.
Jun 25 2020, 1:39 PM · Restricted Project
cchen updated the diff for D82245: [libomptarget] Add support for target update non-contiguous.

Fix non_contig type

Jun 25 2020, 1:39 PM · Restricted Project, Restricted Project
cchen updated the diff for D79972: [OpenMP5.0] map item can be non-contiguous for target update.

Fix coding style

Jun 25 2020, 1:05 PM · Restricted Project
cchen added a comment to D79972: [OpenMP5.0] map item can be non-contiguous for target update.

ping

Jun 25 2020, 9:40 AM · Restricted Project

Jun 24 2020

cchen updated the diff for D82245: [libomptarget] Add support for target update non-contiguous.

Update test so that it don't depends on compiler generated code

Jun 24 2020, 2:40 PM · Restricted Project, Restricted Project
cchen updated the diff for D82245: [libomptarget] Add support for target update non-contiguous.

Revert llvm pre-merge lint for existing code

Jun 24 2020, 1:34 PM · Restricted Project, Restricted Project
cchen updated the diff for D82245: [libomptarget] Add support for target update non-contiguous.

Update test

Jun 24 2020, 1:01 PM · Restricted Project, Restricted Project

Jun 22 2020

cchen added a comment to D79972: [OpenMP5.0] map item can be non-contiguous for target update.

How do you plan to support
#pragma omp target update to (arr[1:2][1:2][0:2], x, b[1:5][0:2])
Are you going to split this into 3 updates since your are using the arg fields.

Jun 22 2020, 4:10 PM · Restricted Project
cchen updated the diff for D79972: [OpenMP5.0] map item can be non-contiguous for target update.

Updated test for clarification

Jun 22 2020, 4:07 PM · Restricted Project
cchen added a comment to D79972: [OpenMP5.0] map item can be non-contiguous for target update.

How do you plan to support
#pragma omp target update to (arr[1:2][1:2][0:2], x, b[1:5][0:2])
Are you going to split this into 3 updates since your are using the arg fields.

Jun 22 2020, 3:35 PM · Restricted Project
cchen added inline comments to D82245: [libomptarget] Add support for target update non-contiguous.
Jun 22 2020, 1:26 PM · Restricted Project, Restricted Project
cchen updated the diff for D82245: [libomptarget] Add support for target update non-contiguous.

Add test

Jun 22 2020, 1:26 PM · Restricted Project, Restricted Project

Jun 19 2020

cchen created D82245: [libomptarget] Add support for target update non-contiguous.
Jun 19 2020, 3:14 PM · Restricted Project, Restricted Project

Jun 16 2020

cchen updated the diff for D79972: [OpenMP5.0] map item can be non-contiguous for target update.

Fix based on feedback

Jun 16 2020, 3:23 PM · Restricted Project
cchen updated the diff for D79972: [OpenMP5.0] map item can be non-contiguous for target update.

Fix Int64Ty issue (The bitNum of APInt I used before is 32)

Jun 16 2020, 1:44 PM · Restricted Project
cchen added inline comments to D79972: [OpenMP5.0] map item can be non-contiguous for target update.
Jun 16 2020, 9:54 AM · Restricted Project

Jun 15 2020

cchen added inline comments to D79972: [OpenMP5.0] map item can be non-contiguous for target update.
Jun 15 2020, 3:29 PM · Restricted Project
cchen updated the diff for D79972: [OpenMP5.0] map item can be non-contiguous for target update.

Resolve issues

Jun 15 2020, 3:29 PM · Restricted Project

Jun 12 2020

cchen updated the diff for D79972: [OpenMP5.0] map item can be non-contiguous for target update.

Fix based on feedback

Jun 12 2020, 3:58 PM · Restricted Project
cchen added inline comments to D79972: [OpenMP5.0] map item can be non-contiguous for target update.
Jun 12 2020, 3:58 PM · Restricted Project

Jun 10 2020

cchen updated the diff for D79972: [OpenMP5.0] map item can be non-contiguous for target update.

Fix based on feedback

Jun 10 2020, 1:55 PM · Restricted Project

Jun 9 2020

cchen added a comment to D79972: [OpenMP5.0] map item can be non-contiguous for target update.

Do you have a test for mapping of something like arr[0][:n], where the base is an array subscript and the remaining part is an array section?

Jun 9 2020, 2:21 PM · Restricted Project
cchen updated the diff for D79972: [OpenMP5.0] map item can be non-contiguous for target update.

Fix based on feedback

Jun 9 2020, 2:21 PM · Restricted Project

Jun 8 2020

cchen added a comment to D79972: [OpenMP5.0] map item can be non-contiguous for target update.

ping

Jun 8 2020, 10:37 PM · Restricted Project

Jun 2 2020

cchen added a comment to D79972: [OpenMP5.0] map item can be non-contiguous for target update.

Still: Did you think about implementing it in the compiler instead of the runtime?

I'm not sure I understand your question, which part of code are you asking?
The main work compiler needs to do is to send the {offset, count, stride} struct to runtime.

I mean did you think about calling __tgt_target_data_update function in a loop in the compiler-generated code instead of putting it into the runtime?

Oh, I would prefer to call tgt_target_data_update once in the compiler and I'm also doing it now.

I was not quite correct. What I mean, is to generate the array with the array section as VLA in the compiler, and fill it in the loop generated by the compiler for non-contiguous sections but not in the runtime?
Say, we have the code:

int arr[3][3]
...
 #pragma omp update to(arr[1:2][1:2]

In this case, we're going to transfer the next elements:

000
0xx
0xx

In the compiler-generated code we emit something like this:

void *bptr[<n>];
void *ptr[<n>];
int64 sizes[<n>];
int64 maptypes[<n>];
for (int i = 0; i < <n>; ++i) {
  bptr[i] = &arr[1+i][1];
  ptr[i] = &arr[1+i][1];
  sizes[i] = ...;'
  maptypes[i] = ...;
}
call void @__tgt_target_data_update(i64 -1, i32 <n>, bptr, ptr, sizes, maptypes);

With this solution, you won't need to modify the runtime and add a new mapping flag.

Jun 2 2020, 4:29 PM · Restricted Project
cchen updated the diff for D79972: [OpenMP5.0] map item can be non-contiguous for target update.

Fix based on feedback

Jun 2 2020, 3:56 PM · Restricted Project
cchen abandoned D80590: [WIP][OPENMP] Fix assertion error for using alignas with OpenMP directive.
Jun 2 2020, 2:16 PM · Restricted Project
cchen added a comment to D79972: [OpenMP5.0] map item can be non-contiguous for target update.

Still: Did you think about implementing it in the compiler instead of the runtime?

I'm not sure I understand your question, which part of code are you asking?
The main work compiler needs to do is to send the {offset, count, stride} struct to runtime.

I mean did you think about calling __tgt_target_data_update function in a loop in the compiler-generated code instead of putting it into the runtime?

Jun 2 2020, 12:37 PM · Restricted Project
cchen added a comment to D79972: [OpenMP5.0] map item can be non-contiguous for target update.

Still: Did you think about implementing it in the compiler instead of the runtime?

Jun 2 2020, 12:05 PM · Restricted Project

Jun 1 2020

cchen updated the diff for D79972: [OpenMP5.0] map item can be non-contiguous for target update.
  • Use PointerIntPair to pass non-contiguous information in AST
  • Error out in Sema if we don't have enough size information for cases involving pointers
  • Allows *arr[N][M] since we don't need size information for the last dimension
  • Add more test cases
Jun 1 2020, 2:05 PM · Restricted Project

May 28 2020

cchen added inline comments to D79972: [OpenMP5.0] map item can be non-contiguous for target update.
May 28 2020, 9:54 AM · Restricted Project
cchen updated the diff for D79972: [OpenMP5.0] map item can be non-contiguous for target update.

Fix based on feedback

May 28 2020, 9:50 AM · Restricted Project

May 27 2020

cchen added inline comments to D79972: [OpenMP5.0] map item can be non-contiguous for target update.
May 27 2020, 3:50 PM · Restricted Project
cchen added a comment to D79972: [OpenMP5.0] map item can be non-contiguous for target update.

Is my guess correct that for OpenMP >= 50 for target update directive we always emit possibly non-continuous runtime calls?

My intent is to emit possibly non-contiguous runtime calls only if the analysis in Sema set the IsNonContiguous flag to true.

But this analysis only checks for the directive and the version,nothing else.

May 27 2020, 3:49 PM · Restricted Project
cchen updated the summary of D79972: [OpenMP5.0] map item can be non-contiguous for target update.
May 27 2020, 3:16 PM · Restricted Project
cchen added a comment to D79972: [OpenMP5.0] map item can be non-contiguous for target update.

Is my guess correct that for OpenMP >= 50 for target update directive we always emit possibly non-continuous runtime calls?

May 27 2020, 3:16 PM · Restricted Project
cchen updated the summary of D79972: [OpenMP5.0] map item can be non-contiguous for target update.
May 27 2020, 2:46 PM · Restricted Project
cchen added inline comments to D79972: [OpenMP5.0] map item can be non-contiguous for target update.
May 27 2020, 2:43 PM · Restricted Project
cchen added a comment to D79972: [OpenMP5.0] map item can be non-contiguous for target update.

How are you going to pass this non-contiguous data in the runtime? Are you going to map it in a loop or convert this non-contiguous data into the contiguous and map it as a contiguous chunk of data? Your presentation provides interface only interface changes but has nothing about implementation in the runtime.

May 27 2020, 2:10 PM · Restricted Project

May 26 2020

cchen updated the diff for D80590: [WIP][OPENMP] Fix assertion error for using alignas with OpenMP directive.

Add test

May 26 2020, 4:23 PM · Restricted Project
cchen added a comment to D80590: [WIP][OPENMP] Fix assertion error for using alignas with OpenMP directive.

Haven't added test yet since I'm not sure in which file should I add the test.

Where is the directive?

May 26 2020, 4:23 PM · Restricted Project
cchen updated the summary of D80590: [WIP][OPENMP] Fix assertion error for using alignas with OpenMP directive.
May 26 2020, 4:23 PM · Restricted Project
cchen added a reviewer for D80590: [WIP][OPENMP] Fix assertion error for using alignas with OpenMP directive: ABataev.
May 26 2020, 3:17 PM · Restricted Project
cchen created D80590: [WIP][OPENMP] Fix assertion error for using alignas with OpenMP directive.
May 26 2020, 3:17 PM · Restricted Project
cchen added a comment to D80590: [WIP][OPENMP] Fix assertion error for using alignas with OpenMP directive.

Haven't added test yet since I'm not sure in which file should I add the test.

May 26 2020, 3:17 PM · Restricted Project

May 21 2020

cchen updated the diff for D79972: [OpenMP5.0] map item can be non-contiguous for target update.

Remove redundant code

May 21 2020, 11:53 AM · Restricted Project
cchen added a comment to D79972: [OpenMP5.0] map item can be non-contiguous for target update.

ping

May 21 2020, 11:53 AM · Restricted Project

May 15 2020

cchen updated the diff for D79972: [OpenMP5.0] map item can be non-contiguous for target update.

Rebase

May 15 2020, 9:45 AM · Restricted Project

May 14 2020

cchen created D79972: [OpenMP5.0] map item can be non-contiguous for target update.
May 14 2020, 3:47 PM · Restricted Project

Apr 6 2020

cchen added a comment to D77581: Add map-type check for target and target data directive.

@ABataev , can you land it for me when you have time? thanks

Apr 6 2020, 3:16 PM · Restricted Project
cchen updated the diff for D77581: Add map-type check for target and target data directive.

Reuse existing function for target/target data check

Apr 6 2020, 2:43 PM · Restricted Project
cchen added inline comments to D77581: Add map-type check for target and target data directive.
Apr 6 2020, 2:43 PM · Restricted Project
cchen updated the diff for D77581: Add map-type check for target and target data directive.

Do not use lint on test

Apr 6 2020, 2:10 PM · Restricted Project
cchen created D77581: Add map-type check for target and target data directive.
Apr 6 2020, 1:04 PM · Restricted Project

Feb 28 2020

cchen added a comment to D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause.

@ABataev, can you land it for me when you have time?

Feb 28 2020, 11:30 AM · Restricted Project