It depends on whether it's intended behavior for ConversionPatternRewriter::replaceAllUsesWith and ConversionPatternRewriter::eraseOp to be unusable in conversion passes
I'm confused, aren't these widely used? At least eraseOp is pretty standard here and I see quite a large number of hit in the conversion passes in-tree (replaceAllUsesWith maybe less common because replaceOpWithNewOp).
Sat, Sep 9
Thu, Sep 7
Aug 17 2023
Aug 16 2023
Make changes to zero9178's comments
Jul 28 2023
one takes a StringRef * that parses any keyword.
Jul 27 2023
Ah yes, now I see why parseKeyword isn't sufficient. I would like to have the bare_identifier be arbitrary, similar to how AffineMap allows for an arbitrary variable name.
I'm not really sure we need to expose this, why does parseKeyword not work for you?
Jul 26 2023
Add optional variant
Remove caret token def
Still getting the hang of the arc CLI tool, sorry for the noise
Revert ParserTest.cpp formatting change
Removed the parseCaret after determining I can't make it work
Apr 17 2023
What exactly is the followup here? I see the extra test added that ensures ctlz is not lowered when the flag is disabled. Is another test helpful?
Apr 16 2023
I can fix it Monday morning. A rollback is fine if it's urgent.
Apr 15 2023
I'm not able to get to my computer til Monday, but perhaps your issue is
that this feature is disabled by default (see comments above), and you need
to explicitly enable it. The test files in this patch show the invocation.
Apr 10 2023
@vzakhari ping :) thanks for your review and advice!
Apr 6 2023
(btw, I don't have commit access, so someone else will need to commit it for me)
This time only Bazel failed, so ok to merge :)
Try syncing with head
Apr 4 2023
break -> continue, plus move mlir-cpu-runner
Mar 30 2023
Fixed a typo/bad variable name choice from the last update
Sorry for the delay, I was in Korea at a conference.
Address reviewer comments
Mar 20 2023
Added default-disabled convert-ctlz option
Mar 17 2023
The backend we're ultimately planning to support does not have a ctlz builtin, so we have no choice but to emulate it in software. This is why lowering to llvm's builtin doesn't help us (and IIUC CIRCT also doesn't support llvm's ctlz)
Added mlir-cpu-runner tests for ctlz