Page MenuHomePhabricator
Feed Advanced Search

Oct 7 2019

rnk accepted D68589: [lit] Leverage argparse features to remove some code.

lgtm

Oct 7 2019, 3:20 PM · Restricted Project
rnk accepted D67855: [X86] Add new calling convention that guarantees tail call optimization.

(back from vacation) Thanks, I think this looks good. Would you like somebody to commit this?

Oct 7 2019, 1:43 PM · Restricted Project
rnk accepted D68584: Fix Calling Convention through aliases.

lgtm

Oct 7 2019, 11:29 AM · Restricted Project

Oct 4 2019

rnk committed rG67cfa79c0100: Revert [CodeGen] Do the Simple Early Return in block-placement pass to optimize… (authored by rnk).
Revert [CodeGen] Do the Simple Early Return in block-placement pass to optimize…
Oct 4 2019, 3:26 PM
rnk committed rL373805: Revert [CodeGen] Do the Simple Early Return in block-placement pass to optimize….
Revert [CodeGen] Do the Simple Early Return in block-placement pass to optimize…
Oct 4 2019, 3:26 PM
rnk added a comment to D63972: [CodeGen] Do the Simple Early Return in block-placement pass to optimize the blocks.

I reverted this in rL373805, it caused https://bugs.llvm.org/show_bug.cgi?id=43566, which has to do with Windows EH. This code in general doesn't seem to consider address-taken blocks, so the problem is probably wider than just Windows EH. See the bug for a test case.

Oct 4 2019, 3:25 PM · Restricted Project
rnk committed rGcfe3bf89c296: Add missing null pointer check in -ftime-trace code (authored by rnk).
Add missing null pointer check in -ftime-trace code
Oct 4 2019, 11:58 AM
rnk committed rL373771: Add missing null pointer check in -ftime-trace code.
Add missing null pointer check in -ftime-trace code
Oct 4 2019, 11:55 AM
rnk accepted D68475: [lit] Use better name for "test in parallel" concept.

lgtm

Oct 4 2019, 11:46 AM · Restricted Project
rnk accepted D68099: [MS ABI]: Fix mangling function arguments for template types to be compatible with MSVC.

I confirmed the test case matches the name that MSVC produces. I guess this regressed in rC362293 / D62746, so the bug is in clang 9.0, but not 8.0. Maybe we should merge this to 9.0.1.

Oct 4 2019, 11:45 AM · Restricted Project
rnk accepted D68449: [test] Remove another two unnecessary uses of REQUIRES: target-windows. NFC..

lgtm

Oct 4 2019, 11:37 AM · Restricted Project
rnk updated subscribers of D68114: Fix for expanding __pragmas in macro arguments.

+ @Bigcheese, for amusement. We discussed some interesting behavior of _Pragma and C++ raw string literals last night.

Oct 4 2019, 11:37 AM · Restricted Project, Restricted Project
rnk accepted D68017: [LLD] [COFF] Always demangle the __imp_ prefix to __declspec(dllimport).

lgtm

Oct 4 2019, 11:20 AM · Restricted Project
rnk added a comment to D68135: [lit] Set the target-windows feature for any windows environment.

Updated, with a slightly different form of the regex, that also allows the triple to just end at -windows.

Alternatively, we could just remove this part of the lit config altogether. There's no other OSes that have target-<os> as a feature (only system-<os> for the host where the test is running), and after D68133 and D68136, no tests actually use this feature any longer.

In most cases, target restrictions rely on using a component of the triple. If all Windows-target triples are guaranteed to spell the component 'windows' then REQUIRES: windows works, and we don't need target-windows at all. But I was under the impression that win32 was used in the triple sometimes?

At least at this point, it seems to use normalized triple names. For input to tools, win32 is a synonym to windows, and "mingw32" as OS name gets normalized to "windows-gnu".

Oct 4 2019, 10:48 AM · Restricted Project

Oct 3 2019

rnk added a comment to D65543: [Windows] Autolink with basenames and add libdir to libpath.

One last idea is that we could teach LLD to automatically add this directory to library search path, but then users who link with Visual C++ (not many anymore) will run into this as a corner case issue.

Oct 3 2019, 6:31 PM · Restricted Project, Restricted Project
rnk added a comment to D65543: [Windows] Autolink with basenames and add libdir to libpath.

Another slightly related thread, regarding libs from the clang resource dir and how they are specified to the linker (regarding the builtins library): https://reviews.llvm.org/D51440

Oct 3 2019, 6:26 PM · Restricted Project, Restricted Project
rnk updated the diff for D65543: [Windows] Autolink with basenames and add libdir to libpath.
  • Fix PGO build
Oct 3 2019, 6:03 PM · Restricted Project, Restricted Project
rnk accepted D67696: [tools] Mark output of tools as text if it is really text.

lgtm

Oct 3 2019, 5:11 PM · Restricted Project
rnk accepted D68133: [Symbolize] Use the local MSVC C++ demangler instead of relying on dbghelp. NFC..

lgtm

Oct 3 2019, 5:11 PM · Restricted Project
rnk added inline comments to D68135: [lit] Set the target-windows feature for any windows environment.
Oct 3 2019, 4:50 PM · Restricted Project
rnk accepted D68136: [test] Remove a needless declaration of REQUIES: target-windows.

lgtm

Oct 3 2019, 4:50 PM · Restricted Project
rnk accepted D68114: Fix for expanding __pragmas in macro arguments.

Nice, the solution was right in front of us the whole time. :)

Oct 3 2019, 4:17 PM · Restricted Project, Restricted Project
rnk accepted D68321: Fix clang Visual Studio build instructions.

lgtm

Oct 3 2019, 3:18 PM · Restricted Project
rnk added inline comments to D67723: [DebugInfo] Add option to disable inline line tables..
Oct 3 2019, 3:18 PM · debug-info, Restricted Project, Restricted Project
rnk accepted D67847: [Support] make report_fatal_error `abort` instead of `exit`.

The abort() function raises SIGABRT, for which the default behavior is to trigger a coredump. Do we actually want that behavior?

Either _exit() (long available extension, which lld already uses) or quick_exit() (the new C standard way) seem possibly preferable?

Oct 3 2019, 2:52 PM · Restricted Project, Restricted Project
rnk updated subscribers of D68255: [X86] Remove AVX/AVX512 check from validateOperandSize, just always accept 512.

I notice that x86 is the only target for which validateInput/OutputSize are implemented. If you are going to disable these checks, perhaps we should get rid of these methods and leave all these errors to the backend? You could add -S to the x86_32-inline-asm.c test and turn it into an integration test that shows that we no longer crash. It would need REQUIRES: x86-registered-target if you do that.

Oct 3 2019, 1:32 PM

Sep 26 2019

rnk added a comment to D65543: [Windows] Autolink with basenames and add libdir to libpath.

I happened to notice that I felt the same way about this in 2014 that I do today:
https://reviews.llvm.org/D4428#56536
That makes me feel like I should keep pushing for this change, even though so far people don't seem enthusiastic about it. :)

Sep 26 2019, 3:04 PM · Restricted Project, Restricted Project
rnk retitled D65543: [Windows] Autolink with basenames and add libdir to libpath from Use library basenames when autolinking on Windows to [Windows] Autolink with basenames and add libdir to libpath.
Sep 26 2019, 2:59 PM · Restricted Project, Restricted Project
rnk committed rGe440d23195f7: Only pass -coverage-notes-file when emitting coverage (authored by rnk).
Only pass -coverage-notes-file when emitting coverage
Sep 26 2019, 11:17 AM
rnk committed rL373004: Only pass -coverage-notes-file when emitting coverage.
Only pass -coverage-notes-file when emitting coverage
Sep 26 2019, 11:17 AM
rnk accepted D67301: [LLD] [COFF] Use the unified llvm demangle frontend function. NFC..

OK, so this is NFC for ELF, but has the relaxed __Z handling for COFF. lgtm

Sep 26 2019, 11:17 AM · Restricted Project
rnk committed rGadc183018715: Move normalization of `\` in #includes from -fms-compatibility to -fms… (authored by rnk).
Move normalization of `\` in #includes from -fms-compatibility to -fms…
Sep 26 2019, 10:24 AM
rnk committed rL372999: Move normalization of `\` in #includes from -fms-compatibility to -fms….
Move normalization of `\` in #includes from -fms-compatibility to -fms…
Sep 26 2019, 10:24 AM
rnk committed rG01ba7d5efe18: Un-XFAIL coverage_no_integrated_as.c test on Windows (authored by rnk).
Un-XFAIL coverage_no_integrated_as.c test on Windows
Sep 26 2019, 9:57 AM
rnk committed rL372994: Un-XFAIL coverage_no_integrated_as.c test on Windows.
Un-XFAIL coverage_no_integrated_as.c test on Windows
Sep 26 2019, 9:57 AM

Sep 25 2019

rnk committed rG9aeae9fe0d75: Simplify -fms-compatibility include lookup logic, NFC (authored by rnk).
Simplify -fms-compatibility include lookup logic, NFC
Sep 25 2019, 3:51 PM
rnk committed rL372926: Simplify -fms-compatibility include lookup logic, NFC.
Simplify -fms-compatibility include lookup logic, NFC
Sep 25 2019, 3:51 PM
rnk accepted D68041: [PGO] Don't group COMDAT variables for compiler generated profile variables in ELF.

lgtm, glad it saves object size.

Sep 25 2019, 3:21 PM · Restricted Project
rnk created D68055: Add -fgnuc-version= to control __GNUC__ and other GCC macros.
Sep 25 2019, 3:01 PM · Restricted Project
rnk updated subscribers of D67301: [LLD] [COFF] Use the unified llvm demangle frontend function. NFC..

Is there a scenario where both Itanium and Microsoft mangling schemes should be tried? (mingw?)

Sep 25 2019, 6:35 AM · Restricted Project

Sep 24 2019

rnk added a comment to D67855: [X86] Add new calling convention that guarantees tail call optimization.

I think of "disable-tail-calls" as a debugging tool, so I think what you've implemented here makes sense.

Sep 24 2019, 11:42 AM · Restricted Project
rnk added a comment to D28596: [compiler-rt] General definition for weak functions..

I see. I audited the other instances of SANITIZER_INTERFACE_WEAK_DEF, and they all seem to be properly namespaced into __asan_, __sanitizer_, etc.

Sep 24 2019, 9:05 AM · Restricted Project
rnk updated subscribers of D67847: [Support] make report_fatal_error `abort` instead of `exit`.

The main alternative worth mentioning is _exit, which LLD already uses for the same reason you mention here.

Sep 24 2019, 8:51 AM · Restricted Project, Restricted Project
rnk added a comment to D67301: [LLD] [COFF] Use the unified llvm demangle frontend function. NFC..

We haven't even heard people complaining about lack of demangling of __Z, ___Z or ___Z prefixed names. I still lean towards keeping the "_Z" check for ELF to avoid false positive.

Sep 24 2019, 8:42 AM · Restricted Project

Sep 20 2019

rnk added a comment to D67855: [X86] Add new calling convention that guarantees tail call optimization.

I'd just like to note that this code is not well tested. A number of features and platforms have been added to the x86 prologue codepath that have not been tested in combination with guaranteed TCO, such as Win64 support. I've always assumed that users of this feature just like to live life dangerously.

Sep 20 2019, 3:31 PM · Restricted Project
rnk updated subscribers of D67847: [Support] make report_fatal_error `abort` instead of `exit`.

This has been proposed before by @MatzeB:
https://reviews.llvm.org/D33960

Sep 20 2019, 11:51 AM · Restricted Project, Restricted Project

Sep 18 2019

rnk added a comment to D67175: [llvm] [cmake] Add possibility to use ChooseMSVCCRT.cmake when include LLVM library.

I don't think so. Is there a committer interested in doing this? I'm busy.

Sep 18 2019, 3:00 PM · Restricted Project
rnk accepted D67631: Add AutoUpgrade function to add new address space datalayout string to existing datalayouts..

lgtm

Sep 18 2019, 3:00 PM · Restricted Project
rnk added a comment to D67723: [DebugInfo] Add option to disable inline line tables..

+ other debug info people

Sep 18 2019, 11:19 AM · debug-info, Restricted Project, Restricted Project
rnk added reviewers for D67723: [DebugInfo] Add option to disable inline line tables.: jmorse, probinson.
Sep 18 2019, 11:19 AM · debug-info, Restricted Project, Restricted Project
rnk added a reviewer for D67723: [DebugInfo] Add option to disable inline line tables.: dblaikie.
Sep 18 2019, 11:18 AM · debug-info, Restricted Project, Restricted Project
rnk added inline comments to D67631: Add AutoUpgrade function to add new address space datalayout string to existing datalayouts..
Sep 18 2019, 11:06 AM · Restricted Project
rnk added a comment to D67696: [tools] Mark output of tools as text if it is really text.

The main effect that I'm aware of here is that this will do CRLF conversion on Windows. Are we sure we really want that? I just did the opposite to TableGen output in rL371683. In general, I think the majority of tools that write text use OF_Text, so your change makes this minority of tools consistent with the other ones.

Sep 18 2019, 10:49 AM · Restricted Project

Sep 17 2019

rnk added a comment to D67579: [PGO] Use linkonce_odr linkage for __profd_ variables in comdat groups.

From what I understand, the comdat group isn't necessary, so I disabled it on COFF in r372182. Can we simplify ELF to match?

Sep 17 2019, 3:20 PM · Restricted Project
rnk added inline comments to D67631: Add AutoUpgrade function to add new address space datalayout string to existing datalayouts..
Sep 17 2019, 2:34 PM · Restricted Project
rnk committed rG23e872a3d054: [PGO] Don't use comdat groups for counters & data on COFF (authored by rnk).
[PGO] Don't use comdat groups for counters & data on COFF
Sep 17 2019, 2:12 PM
rnk committed rL372182: [PGO] Don't use comdat groups for counters & data on COFF.
[PGO] Don't use comdat groups for counters & data on COFF
Sep 17 2019, 2:11 PM
rnk committed rG6f1f3cfc5ac2: Ignore exception specifier mismatch when merging redeclarations (authored by rnk).
Ignore exception specifier mismatch when merging redeclarations
Sep 17 2019, 1:29 PM
rnk committed rL372178: Ignore exception specifier mismatch when merging redeclarations.
Ignore exception specifier mismatch when merging redeclarations
Sep 17 2019, 1:28 PM
rnk closed D67590: Properly ignore mismatched exception specifiers in MSVC Compat mode..
Sep 17 2019, 1:27 PM · Restricted Project, Restricted Project
rnk updated the diff for D67590: Properly ignore mismatched exception specifiers in MSVC Compat mode..
  • simplify merging check
Sep 17 2019, 1:25 PM · Restricted Project, Restricted Project
rnk added inline comments to D67643: [lit] Extend internal diff to support `-` argument.
Sep 17 2019, 11:36 AM · Restricted Project
rnk added a comment to D62063: CMake changes to get Windows self-host with PGO working.

@hans has been trying to build clang with PGO on Windows, so I'll defer this to him.

Sep 17 2019, 11:12 AM · Restricted Project
rnk edited reviewers for D62063: CMake changes to get Windows self-host with PGO working, added: hans; removed: rnk.
Sep 17 2019, 11:11 AM · Restricted Project
rnk added a comment to D67579: [PGO] Use linkonce_odr linkage for __profd_ variables in comdat groups.

Hm, this broke check-asan on Windows, which exercises some code coverage features:
http://lab.llvm.org:8011/builders/sanitizer-windows/builds/51563

Sep 17 2019, 11:03 AM · Restricted Project

Sep 16 2019

rnk updated the diff for D67590: Properly ignore mismatched exception specifiers in MSVC Compat mode..
  • move test
Sep 16 2019, 12:54 PM · Restricted Project, Restricted Project
rnk commandeered D67590: Properly ignore mismatched exception specifiers in MSVC Compat mode..

Taking this to move the test around and try the other version...

Sep 16 2019, 12:53 PM · Restricted Project, Restricted Project
rnk committed rG32837a0c93ec: [PGO] Use linkonce_odr linkage for __profd_ variables in comdat groups (authored by rnk).
[PGO] Use linkonce_odr linkage for __profd_ variables in comdat groups
Sep 16 2019, 11:49 AM
rnk committed rL372020: [PGO] Use linkonce_odr linkage for __profd_ variables in comdat groups.
[PGO] Use linkonce_odr linkage for __profd_ variables in comdat groups
Sep 16 2019, 11:49 AM
rnk closed D67579: [PGO] Use linkonce_odr linkage for __profd_ variables in comdat groups.
Sep 16 2019, 11:49 AM · Restricted Project
rnk added inline comments to D67590: Properly ignore mismatched exception specifiers in MSVC Compat mode..
Sep 16 2019, 11:43 AM · Restricted Project, Restricted Project

Sep 13 2019

rnk added a comment to D67579: [PGO] Use linkonce_odr linkage for __profd_ variables in comdat groups.
In D67579#1670170, @xur wrote:

LGTM. Thanks for the fix!

I wasn't sure why profd was set to internal when looking at PR41380 (as for ELF, all are linkonce_oda). But your description explained that.

BTW, the intrinsic lowering happens before inline (I suppose you are talking the main IPA inline).

Sep 13 2019, 4:18 PM · Restricted Project
rnk created D67579: [PGO] Use linkonce_odr linkage for __profd_ variables in comdat groups.
Sep 13 2019, 3:42 PM · Restricted Project
rnk added a comment to D66843: Change datalayout compatibility check for X86 to allow datalayouts without the new address spaces..

If this is only being used for clang-cl (or -fms-compatibility) mode only, is it possible to limit it to just that rather than it affecting pretty much everything?

Sep 13 2019, 10:51 AM · Restricted Project

Sep 12 2019

rnk committed rG0e88ebe11d93: Use host's executable suffix for clang when cross-compiling compiler-rt (authored by rnk).
Use host's executable suffix for clang when cross-compiling compiler-rt
Sep 12 2019, 11:44 AM
rnk committed rL371754: Use host's executable suffix for clang when cross-compiling compiler-rt.
Use host's executable suffix for clang when cross-compiling compiler-rt
Sep 12 2019, 11:44 AM
rnk closed D67401: Use host's executable suffix for clang when cross-compiling compiler-rt.
Sep 12 2019, 11:44 AM · Restricted Project, Restricted Project
rnk added a comment to D67401: Use host's executable suffix for clang when cross-compiling compiler-rt.
In D67401#1665548, @rnk wrote:

lgtm

I don't have commit access, can I ask you to commit this for me? Or is there anything else that needs to be done?

Sep 12 2019, 11:44 AM · Restricted Project, Restricted Project
rnk committed rGb6a8152b8bf7: [MS] Warn when shadowing template parameters under -fms-compatibility (authored by rnk).
[MS] Warn when shadowing template parameters under -fms-compatibility
Sep 12 2019, 11:26 AM
rnk committed rL371753: [MS] Warn when shadowing template parameters under -fms-compatibility.
[MS] Warn when shadowing template parameters under -fms-compatibility
Sep 12 2019, 11:26 AM
rnk closed D67463: [MS] Warn when shadowing template parameters under -fms-compatibility.
Sep 12 2019, 11:26 AM · Restricted Project, Restricted Project
rnk committed rGb00a49d1b3a1: Don't warn about selectany on implicitly inline variables (authored by rnk).
Don't warn about selectany on implicitly inline variables
Sep 12 2019, 10:58 AM
rnk committed rL371749: Don't warn about selectany on implicitly inline variables.
Don't warn about selectany on implicitly inline variables
Sep 12 2019, 10:58 AM
rnk closed D67426: Don't warn about selectany on implicitly inline variables.
Sep 12 2019, 10:58 AM · Restricted Project

Sep 11 2019

rnk committed rL371686: Run svn cleanup before svn up on Windows annotated build bots.
Run svn cleanup before svn up on Windows annotated build bots
Sep 11 2019, 4:18 PM
rnk committed rGe78a7a0ecddc: [TableGen] Skip CRLF conversion when writing output (authored by rnk).
[TableGen] Skip CRLF conversion when writing output
Sep 11 2019, 3:34 PM
rnk committed rL371683: [TableGen] Skip CRLF conversion when writing output.
[TableGen] Skip CRLF conversion when writing output
Sep 11 2019, 3:34 PM
rnk committed rGff45955fc868: [X86] Fix latent bugs in 32-bit CMPXCHG8B inserter (authored by rnk).
[X86] Fix latent bugs in 32-bit CMPXCHG8B inserter
Sep 11 2019, 2:59 PM
rnk committed rL371678: [X86] Fix latent bugs in 32-bit CMPXCHG8B inserter.
[X86] Fix latent bugs in 32-bit CMPXCHG8B inserter
Sep 11 2019, 2:54 PM
rnk committed rGa685f5161db9: Start porting ivfsoverlay tests to Windows (authored by rnk).
Start porting ivfsoverlay tests to Windows
Sep 11 2019, 1:57 PM
rnk committed rL371663: Start porting ivfsoverlay tests to Windows.
Start porting ivfsoverlay tests to Windows
Sep 11 2019, 1:55 PM
rnk closed D67454: Start porting ivfsoverlay tests to Windows.
Sep 11 2019, 1:55 PM · Restricted Project, Restricted Project
rnk committed rG6d5f0029fc06: [llvm-reduce] Fix a bug, improve error handling when running test (authored by rnk).
[llvm-reduce] Fix a bug, improve error handling when running test
Sep 11 2019, 1:31 PM
rnk committed rL371653: [llvm-reduce] Fix a bug, improve error handling when running test.
[llvm-reduce] Fix a bug, improve error handling when running test
Sep 11 2019, 1:27 PM
rnk created D67463: [MS] Warn when shadowing template parameters under -fms-compatibility.
Sep 11 2019, 1:09 PM · Restricted Project, Restricted Project
rnk created D67454: Start porting ivfsoverlay tests to Windows.
Sep 11 2019, 11:39 AM · Restricted Project, Restricted Project
rnk committed rGabcc2a879c95: [MS] Consder constexpr globals to be inline, as in C++17 (authored by rnk).
[MS] Consder constexpr globals to be inline, as in C++17
Sep 11 2019, 11:09 AM
rnk committed rL371642: [MS] Consder constexpr globals to be inline, as in C++17.
[MS] Consder constexpr globals to be inline, as in C++17
Sep 11 2019, 11:07 AM
rnk closed D47956: [MS] Consder constexpr globals to be inline, as in C++17.
Sep 11 2019, 11:07 AM · Restricted Project, Restricted Project
rnk added a comment to D66843: Change datalayout compatibility check for X86 to allow datalayouts without the new address spaces..

Still really not a fan of this way. I think you can change the incoming DL in compatibility cases to add an address space when none exists on x86.

-eric

Sep 11 2019, 9:23 AM · Restricted Project