Page MenuHomePhabricator
Feed Advanced Search

Jul 19 2019

rnk added a comment to rL366501: Revert [X86] EltsFromConsecutiveLoads - support common source loads.

extern "C" void *memcpy(void *, const void *, unsigned long);
template <typename a> using b = a attribute((ext_vector_type(4)));
using c = b<char>;
template <typename b, typename a> b d(a e, unsigned) {

b f;
f[2] = 2;
memcpy(&f, e, 2);
return f;

}
void g(c);
char h;
long i;
void j() { g(d<c>(&h, i)); }

Jul 19 2019, 12:55 PM
rnk added a comment to D64971: [SafeStack] Insert the deref after the offset.

(I though Reid was going to invent dbg.addr and solve all this nonsense for us...)

Jul 19 2019, 11:24 AM · Restricted Project
rnk accepted D64780: Disallow most calling convention attributes on PS4..

lgtm

Jul 19 2019, 11:14 AM · Restricted Project, Restricted Project

Jul 18 2019

rnk committed rGba9c9e62cbf4: Revert [X86] EltsFromConsecutiveLoads - support common source loads (authored by rnk).
Revert [X86] EltsFromConsecutiveLoads - support common source loads
Jul 18 2019, 2:31 PM
rnk committed rL366501: Revert [X86] EltsFromConsecutiveLoads - support common source loads.
Revert [X86] EltsFromConsecutiveLoads - support common source loads
Jul 18 2019, 2:31 PM
rnk added inline comments to D58484: [DO NOT SUBMIT] Add -vs-diagnostics..
Jul 18 2019, 2:05 PM · Restricted Project
rnk accepted D64948: IR: Teach Constant::needsRelocation() that relative pointers don't need to be relocated..

lgtm

Jul 18 2019, 1:49 PM · Restricted Project
rnk added a comment to D64799: [Sema] Emit diagnostics for uncorrected delayed typos at the end of TU.

@rsmith, I'll look into emitting the typos when we pop expression evaluation context, but do we expect this to cover all cases where TypoExprs are produced?
(conservatively assuming that the answer is "no") should we land this patch and also emit at the end of TU in addition to expression evaluation context?

Jul 18 2019, 1:28 PM · Restricted Project
rnk added a comment to D64931: Change X86 datalayout for three address spaces that specify pointer sizes..

I suggested to @akhuang offline that we should discuss this on llvm-dev. I'll add some other X86 reviewers.

Jul 18 2019, 1:21 PM · Restricted Project, Restricted Project
rnk added reviewers for D64931: Change X86 datalayout for three address spaces that specify pointer sizes.: craig.topper, RKSimon.
Jul 18 2019, 1:19 PM · Restricted Project, Restricted Project
rnk added a comment to D64067: [X86][PPC] Support -mlong-double-64.

Hi, we just inherited this commit at Cray when we did our latest upstream merge and there are a few problems with it that I'd like to point out. Sorry that I was not part of the initial discussion here, but I didn't know that this work was being done and I had already done it for x86 in our downstream compiler a while ago.

  1. This patch adds the -m options to f_Group, which is weird. They should be in m_Group since they are target-specific. I actually implemented them as part of a subgroup of m_Group so that I can take the last option from that group that appears on the command line.
Jul 18 2019, 1:18 PM · Restricted Project, Restricted Project

Jul 17 2019

rnk accepted D64879: llvm-pdbdump: Fix several smaller issues with injected source compression handling.

lgtm with a suggestion

Jul 17 2019, 1:56 PM · Restricted Project
rnk added a comment to D64483: [CMake] Define _FILE_OFFSET_BITS=64 on Solaris.

I would place this macro setting with the other code that sets this macro, in cmake/modules/HandleLLVMOptions.cmake.

Jul 17 2019, 1:13 PM · Restricted Project
rnk accepted D64536: Adding inline comments to code view type records.

lgtm, sorry this fell out of my inbox.

Jul 17 2019, 10:21 AM · Restricted Project, Restricted Project

Jul 16 2019

rnk committed rG9304e59c0131: Fix OpenCLCXX test on 32-bit Windows where thiscall is present (authored by rnk).
Fix OpenCLCXX test on 32-bit Windows where thiscall is present
Jul 16 2019, 4:45 PM
rnk committed rL366284: Fix OpenCLCXX test on 32-bit Windows where thiscall is present.
Fix OpenCLCXX test on 32-bit Windows where thiscall is present
Jul 16 2019, 4:45 PM
rnk committed rG2ecca781a159: Fix darwin-ld.c if dsymutil.exe exists on PATH (authored by rnk).
Fix darwin-ld.c if dsymutil.exe exists on PATH
Jul 16 2019, 4:39 PM
rnk committed rL366282: Fix darwin-ld.c if dsymutil.exe exists on PATH.
Fix darwin-ld.c if dsymutil.exe exists on PATH
Jul 16 2019, 4:37 PM
rnk added a comment to D64799: [Sema] Emit diagnostics for uncorrected delayed typos at the end of TU.

I'm in favor of this as is. We should loop in and get confirmation from @rsmith though.

Jul 16 2019, 3:40 PM · Restricted Project
rnk edited reviewers for D64799: [Sema] Emit diagnostics for uncorrected delayed typos at the end of TU, added: rsmith; removed: rnk.
Jul 16 2019, 3:40 PM · Restricted Project
rnk accepted D64491: [Driver] Enable __cxa_atexit on Solaris.

lgtm

Jul 16 2019, 3:26 PM · Restricted Project, Restricted Project
rnk committed rGfa575839225a: Add REQUIRES: x86 to safeseh-no.s test for x86 (authored by rnk).
Add REQUIRES: x86 to safeseh-no.s test for x86
Jul 16 2019, 3:04 PM
rnk committed rL366273: Add REQUIRES: x86 to safeseh-no.s test for x86.
Add REQUIRES: x86 to safeseh-no.s test for x86
Jul 16 2019, 3:01 PM
rnk added a comment to D64780: Disallow most calling convention attributes on PS4..

Some suggestions, you don't have to take all of them.

Jul 16 2019, 1:24 PM · Restricted Project, Restricted Project
rnk accepted D64482: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris.

To avoid a similar inconsistence with host compilers that don't predefine _FILE_OFFSET_BITS=64
(e.g. clang < 9, gcc < 9), this needs a compantion patch to be submitted shortly.

Jul 16 2019, 1:11 PM · Restricted Project, Restricted Project
rnk committed rG1d58c1d9d6b8: Fix LLDB Windows build Python version logic after r366243 (authored by rnk).
Fix LLDB Windows build Python version logic after r366243
Jul 16 2019, 11:48 AM
rnk added a comment to D64812: [CMake] Fail when Python interpreter doesn't match Python libraries version .
In D64812#1588055, @rnk wrote:

You broke my build. =/ I got this output:

CMake Error at C:/src/llvm-project/lldb/cmake/modules/LLDBConfig.cmake:201 (message):
  Found incompatible Python interpreter (3.7.3) and Python libraries ()

I'll mess with it a bit I guess.

Jul 16 2019, 11:48 AM · Restricted Project, Restricted Project
rnk committed rL366247: Fix LLDB Windows build Python version logic after r366243.
Fix LLDB Windows build Python version logic after r366243
Jul 16 2019, 11:46 AM
rnk added a comment to D64812: [CMake] Fail when Python interpreter doesn't match Python libraries version .

You broke my build. =/ I got this output:

CMake Error at C:/src/llvm-project/lldb/cmake/modules/LLDBConfig.cmake:201 (message):
  Found incompatible Python interpreter (3.7.3) and Python libraries ()

I'll mess with it a bit I guess.

Jul 16 2019, 11:41 AM · Restricted Project, Restricted Project
rnk committed rG11dc3d371124: Mark new test as requiring an x86 backend for LTO native object generation (authored by rnk).
Mark new test as requiring an x86 backend for LTO native object generation
Jul 16 2019, 11:36 AM
rnk committed rL366245: Mark new test as requiring an x86 backend for LTO native object generation.
Mark new test as requiring an x86 backend for LTO native object generation
Jul 16 2019, 11:36 AM
rnk committed rG4b6f69fe906e: Fix linkrepro.test after safeseh:no change (authored by rnk).
Fix linkrepro.test after safeseh:no change
Jul 16 2019, 11:35 AM
rnk committed rL366244: Fix linkrepro.test after safeseh:no change.
Fix linkrepro.test after safeseh:no change
Jul 16 2019, 11:33 AM
rnk committed rGfe44a531e0e2: [COFF] Implement /safeseh:no and check @feat.00 flags by default (authored by rnk).
[COFF] Implement /safeseh:no and check @feat.00 flags by default
Jul 16 2019, 11:18 AM
rnk committed rL366238: [COFF] Implement /safeseh:no and check @feat.00 flags by default.
[COFF] Implement /safeseh:no and check @feat.00 flags by default
Jul 16 2019, 11:17 AM
rnk closed D63570: [COFF] Implement /safeseh:no and check @feat.00 flags by default.
Jul 16 2019, 11:17 AM · Restricted Project
rnk updated the diff for D63570: [COFF] Implement /safeseh:no and check @feat.00 flags by default.
  • rebase
Jul 16 2019, 11:17 AM · Restricted Project
rnk added a comment to D64461: [lld-link] implement -thinlto-index-only.
In D64461#1586582, @rnk wrote:

Personally I believe we should prioritize fixing that. It's trivial to fix for thin archives, since those are practically equivalent to the command line object groups.

Someone asked about this on the llvm-dev mailing list recently, pasting my response below:

Somehow, the module identifier for each constituent object would need to be both unique (we currently generate this from the name of the archive plus the offset in the archive plus the name of the source file IIRC), but also correctly identify the extracted bitcode object used in the post-thinlink backend invocation. This is so it can write out the distributed index file with a filename that gets consumed by the associated backend invocation (passed to -fthinlto-index=), and so that the module paths emitted in those index files correctly identify where we can import functions from. Since the bitcode objects need to be extracted for the corresponding backend clang invocations, a couple possibilities come to mind:

  1. Do it outside the compiler/linker: wrap the whole thing in a script that does the extraction, invokes the link with extracted constituents surrounded by --start-lib/-end-lib pairs, invokes each backend through some parallel or distributed mechanism, and then invokes the final link; or
  2. Add support to pass some kind of mapping file into LTO that maps from each archive constituent to the extracted filename including path that the corresponding ThinLTO backend clang invocation will use, and have LTO set the module identifiers accordingly so that everything "just works" (in theory). We already support some munging of these names (see the thinlto_object_suffix_replace plugin option in either gold-plugin.cpp or in lld), but what you need here is a bit more complicated than a simple suffix change. But since there is already support for adjusting the name, it might not be too bad to add this support.
Jul 16 2019, 11:12 AM · Restricted Project
rnk accepted D64428: Teach `llvm-pdbutil pretty -native` about `-injected-sources`.

lgtm, up to you if you want to wait for @zturner. I like the new error handling approach. :)

Jul 16 2019, 10:38 AM · Restricted Project

Jul 15 2019

rnk updated the diff for D63570: [COFF] Implement /safeseh:no and check @feat.00 flags by default.
  • change default
  • simplify
Jul 15 2019, 4:14 PM · Restricted Project
rnk added inline comments to D63570: [COFF] Implement /safeseh:no and check @feat.00 flags by default.
Jul 15 2019, 4:06 PM · Restricted Project
rnk accepted D64679: Display codeview type record values in hex representation instead of decimal.

lgtm with the explicit marker removed. Thanks!

Jul 15 2019, 3:50 PM · Restricted Project
rnk added a comment to D64428: Teach `llvm-pdbutil pretty -native` about `-injected-sources`.

I'd like to get feedback on the high-level design here, since I'm not familiar with how things are supposed to be done in this code. In particular, does the split between NativeEnumInjectedSources and InjectedSourceStream make sense? Are these names consistent with the rest of the code?

Jul 15 2019, 3:45 PM · Restricted Project
rnk added a comment to D64461: [lld-link] implement -thinlto-index-only.

Distributed ThinLTO doesn't support archives: http://lists.llvm.org/pipermail/llvm-dev/2019-June/133145.html. @tejohnson suggested -start-lib -end-lib as a workaround, but that's not a thing for COFF. Do you have plans for archive support, or is that not something you need to deal with for your use cases?

Jul 15 2019, 3:27 PM · Restricted Project
rnk accepted D64458: add -fthinlto-index= option to clang-cl.

lgtm too, since now this is just whitelisting a clang flag for clang-cl.

Jul 15 2019, 3:10 PM · Restricted Project, Restricted Project
rnk accepted D64694: Fix heapapi.h dependency in asan_malloc_win.cc.

Looks good to me too. :)

Jul 15 2019, 10:53 AM · Restricted Project, Restricted Project
rnk committed rG3e7c314b039d: Reland "[COFF] Add null check in case of symbols defined in LTO blobs" (authored by rnk).
Reland "[COFF] Add null check in case of symbols defined in LTO blobs"
Jul 15 2019, 10:52 AM
rnk committed rL366095: Reland "[COFF] Add null check in case of symbols defined in LTO blobs".
Reland "[COFF] Add null check in case of symbols defined in LTO blobs"
Jul 15 2019, 10:51 AM
rnk added a comment to D64062: Remove __VERSION__.

This revision breaks python 2.7.16 builds, which are still supported by upstream python for a few more months. I'm preparing a revert.

The file is getcompiler.c:

Jul 15 2019, 10:39 AM · Restricted Project, Restricted Project
rnk accepted D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version.

lgtm

Jul 15 2019, 10:36 AM · Restricted Project, Restricted Project
rnk accepted D64738: Expand comment about how StringsToBuckets was computed, and add more entries.

lgtm

Jul 15 2019, 10:22 AM · Restricted Project

Jul 12 2019

rnk committed rG0291d309291f: [COFF] Add null check in case of symbols defined in LTO blobs (authored by rnk).
[COFF] Add null check in case of symbols defined in LTO blobs
Jul 12 2019, 5:23 PM
rnk committed rL365979: [COFF] Add null check in case of symbols defined in LTO blobs.
[COFF] Add null check in case of symbols defined in LTO blobs
Jul 12 2019, 5:20 PM
rnk added inline comments to D64679: Display codeview type record values in hex representation instead of decimal.
Jul 12 2019, 5:18 PM · Restricted Project
rnk added a reviewer for D64679: Display codeview type record values in hex representation instead of decimal: pcc.
Jul 12 2019, 5:11 PM · Restricted Project
rnk accepted D64610: [clang] allow -fthinlto-index= without -x ir.

lgtm

Jul 12 2019, 4:56 PM · Restricted Project, Restricted Project
rnk accepted D64640: PDB HashTable: Move TraitsT from class parameter to the methods that need it.
In D64640#1583265, @rnk wrote:

The traits object is only used by a few methods. Deserializing a hash
table and walking it is possible without the traits object, so it
shouldn't be required to build a dummy object for that use case.

The traits are needed to do any actual hashing.

I believe that's not really true: The has key is always an uint32_t, and assuming that lookupKeyToStorageKey() and storageKeyToLookupKey() are inverses of each other (which currently is true for StringTableHashTraits; for NamedStreamMapTraits I'm not yet sure what the semantics for two streams with the same name are. I believe it's not allowed – passing two identical /natvis: params to lld seems to confuse everyone at least -- and then it'd be true there too). So I currently think (but could be wrong, I'm not sure yet) that the hashtable hash function is overly complicated and should always work just on the uint32_t key and there should be a convenience function to convert a string key to an uint32_t. But that's for another change.

Jul 12 2019, 4:03 PM · Restricted Project
rnk added a comment to D64655: [Clang][Driver] don't error for unsupported as options for -no-integrated-as.

I reverted @thakis's change in rC365956, but I think in retrospect I should've just stamped your change. I was glazing over the "Integrated" part of "CollectArgsForIntegratedAssembler". Anyway, I think we should leave it alone and let him decide how to handle integrated and non-integrated assembly in a uniform way.

Jul 12 2019, 1:52 PM · Restricted Project
rnk committed rGa3aa67b7f915: Revert driver: Don't warn about assembler flags being unused when not assembling (authored by rnk).
Revert driver: Don't warn about assembler flags being unused when not assembling
Jul 12 2019, 1:49 PM
rnk committed rL365956: Revert driver: Don't warn about assembler flags being unused when not assembling.
Revert driver: Don't warn about assembler flags being unused when not assembling
Jul 12 2019, 1:45 PM
rnk added a comment to D64655: [Clang][Driver] don't error for unsupported as options for -no-integrated-as.

I don't think this is the right fix, because now I think we get this behavior that we don't want:

$ clang -E t.c -o t.i -Wa,-mbig-obj
# no warning
$ clang -E t.c -o t.i -Wa,-mbig-obj -fno-integrated-as
clang: warning: argument unused during compilation: '-Wa,-mbig-obj' [-Wunused-command-line-argument]
Jul 12 2019, 1:36 PM · Restricted Project
rnk accepted D64062: Remove __VERSION__.

lgtm, minor changes

Jul 12 2019, 11:50 AM · Restricted Project, Restricted Project
rnk added a comment to D64640: PDB HashTable: Move TraitsT from class parameter to the methods that need it.

The traits object is only used by a few methods. Deserializing a hash
table and walking it is possible without the traits object, so it
shouldn't be required to build a dummy object for that use case.

Jul 12 2019, 11:45 AM · Restricted Project
rnk added a comment to D64630: [DebugInfo] Address performance regression with r364515.

With ASAN, packs of up to 800 DBG_VALUEs in a row appear (for that file)

That seems excessive; in the past when I've seen this explosion of DBG instructions, the vast majority were redundant. Have you looked at them to see if this is the case? We might rather eliminate duplicates than write code to make it cheaper to have lots of unnecessary instructions.

Jul 12 2019, 11:27 AM · Restricted Project
rnk accepted D64633: Slightly simplify MappedBlockStream::createIndexedStream() calls.

lgtm

Jul 12 2019, 11:20 AM · Restricted Project

Jul 11 2019

rnk added a comment to D64527: driver: Don't warn about assembler flags being unused when not assembling.

I think the intention of this change was to ignore assembler flags in pre-processing actions without warning about them. It implements that behavior by running the code that gathers and validates assembler flags. The validation is whats emitting the problematic errors. I don't think that's desirable, so I'd recommend reverting for now.

Jul 11 2019, 6:09 PM · Restricted Project
rnk accepted D64277: [X86][PowerPC] Support -mlong-double-128.

lgtm with suggestion

Jul 11 2019, 4:25 PM · Restricted Project, Restricted Project
rnk committed rG1a285c27fdf6: Use clang driver for libfuzzer tests on Windows (authored by rnk).
Use clang driver for libfuzzer tests on Windows
Jul 11 2019, 4:21 PM
rnk committed rL365841: Use clang driver for libfuzzer tests on Windows.
Use clang driver for libfuzzer tests on Windows
Jul 11 2019, 4:21 PM
rnk closed D64587: Use clang driver for libfuzzer tests on Windows.
Jul 11 2019, 4:21 PM · Restricted Project, Restricted Project
rnk added a comment to D64062: Remove __VERSION__.
In D64062#1581290, @rnk wrote:

Perhaps we should just remove __VERSION__ and keep -dumpversion.

As you wish. clang --version seems an alternative and dumpversion never worked for clang. so, I don't expect software to use it for clang.

Jul 11 2019, 4:21 PM · Restricted Project, Restricted Project
rnk committed rGf002fcb2ad64: Open native file handles to avoid converting from FDs, NFC (authored by rnk).
Open native file handles to avoid converting from FDs, NFC
Jul 11 2019, 1:30 PM
rnk created D64587: Use clang driver for libfuzzer tests on Windows.
Jul 11 2019, 1:30 PM · Restricted Project, Restricted Project
rnk committed rL365820: Open native file handles to avoid converting from FDs, NFC.
Open native file handles to avoid converting from FDs, NFC
Jul 11 2019, 1:29 PM
rnk added a comment to D64062: Remove __VERSION__.

I still have this open concern:

Jul 11 2019, 12:58 PM · Restricted Project, Restricted Project
rnk added a comment to D64505: [Support] Move the static initializer install_out_memory_new_handler to InitLLVM.
In D64505#1580928, @jfb wrote:

Let me rephrase: does it ever make sense to call InitLLVM if there's already a new handler installed? Or is it always a sign of trouble if that's done?

Jul 11 2019, 11:39 AM · Restricted Project

Jul 10 2019

rnk added a comment to D64538: [Driver] Don't escape backslashes on Windows.

I'm not fully understanding this. If the .sh file was generated on Windows, it'll contain backslashes in any arguments that are paths, right? Before this change, those backslashes would have been doubled up, but the backslash still wouldn't work as a path separator on Linux, so those arguments would need manual adjustment. I guess the other case that matters is if you have a backslash in an argument which isn't a path, in which case the old behavior was definitely correct and the new one definitely isn't.

Jul 10 2019, 7:30 PM · Restricted Project
rnk added inline comments to D64536: Adding inline comments to code view type records.
Jul 10 2019, 5:44 PM · Restricted Project, Restricted Project
rnk accepted D64506: clang-cl: Remove -O0 option.

lgtm

Jul 10 2019, 5:19 PM · Restricted Project
rnk accepted D64504: Various minor tweaks to CLCompatOptions.td.

lgtm

Jul 10 2019, 5:17 PM
rnk added a comment to D64538: [Driver] Don't escape backslashes on Windows.
In D64538#1579561, @rnk wrote:

An extremely convenient feature of the current escaping pattern is that it magically works for both the cmd shell and various bash implementations. You can simply copy paste the commands and run them. This matters, for example, for the .sh crash reproducer script. On Windows today, you can just run it with bash, and it works. So, I'd prefer it if we didn't do this.

If you want -### output to be more FileCheck friendly, then I would recommend adding a new driver flag for testing that dumps the commands without doing any escaping. This came up before:
https://reviews.llvm.org/D62493

As long as the backslashes aren't followed by a few special characters (as detailed in my comment), the backslash should still continue to work. I've been testing this with git bash and I'm still able to copy-paste the ouptut command.

Jul 10 2019, 3:58 PM · Restricted Project
rnk added a comment to D64505: [Support] Move the static initializer install_out_memory_new_handler to InitLLVM.
In D64505#1579577, @jfb wrote:

So you're saying: maybe it's a bug if we install one but there was already one installed?

Jul 10 2019, 3:50 PM · Restricted Project
rnk added a comment to D64538: [Driver] Don't escape backslashes on Windows.

An extremely convenient feature of the current escaping pattern is that it magically works for both the cmd shell and various bash implementations. You can simply copy paste the commands and run them. This matters, for example, for the .sh crash reproducer script. On Windows today, you can just run it with bash, and it works. So, I'd prefer it if we didn't do this.

Jul 10 2019, 3:35 PM · Restricted Project
rnk added a comment to D64461: [lld-link] implement -thinlto-index-only.

Hit send without saying things...

Jul 10 2019, 3:10 PM · Restricted Project
rnk added inline comments to D64461: [lld-link] implement -thinlto-index-only.
Jul 10 2019, 3:08 PM · Restricted Project
rnk added a comment to D64505: [Support] Move the static initializer install_out_memory_new_handler to InitLLVM.
In D64505#1578699, @jfb wrote:

Does it make sense to reset any previous handler in llvm_shutdown?

Jul 10 2019, 2:22 PM · Restricted Project
rnk added inline comments to D64504: Various minor tweaks to CLCompatOptions.td.
Jul 10 2019, 1:56 PM
rnk added a comment to D64506: clang-cl: Remove -O0 option.

Does clang-cl -O0 without a / still work, though? It's used:

Jul 10 2019, 1:49 PM · Restricted Project
rnk accepted D64527: driver: Don't warn about assembler flags being unused when not assembling.

lgtm

Jul 10 2019, 1:23 PM · Restricted Project
rnk accepted D64288: [LLD] [COFF] Share the tail in delayimport symbol thunks.

lgtm, and I think Rui approves as well.

Jul 10 2019, 1:14 PM · Restricted Project

Jul 9 2019

rnk added a comment to D64458: add -fthinlto-index= option to clang-cl.
In D64458#1577435, @pcc wrote:

Do we really need to support clang-cl syntax here? Can't the user of -fthinlto-index= use the regular clang driver?

Jul 9 2019, 6:13 PM · Restricted Project, Restricted Project
rnk committed rGcc418a3af45a: [Support] Move llvm::MemoryBuffer to sys::fs::file_t (authored by rnk).
[Support] Move llvm::MemoryBuffer to sys::fs::file_t
Jul 9 2019, 5:35 PM
rnk committed rL365588: [Support] Move llvm::MemoryBuffer to sys::fs::file_t.
[Support] Move llvm::MemoryBuffer to sys::fs::file_t
Jul 9 2019, 5:34 PM
rnk closed D63453: [Support] Move llvm::MemoryBuffer to sys::fs::file_t.
Jul 9 2019, 5:34 PM · Restricted Project
rnk added inline comments to D63453: [Support] Move llvm::MemoryBuffer to sys::fs::file_t.
Jul 9 2019, 5:31 PM · Restricted Project
rnk added a comment to D63453: [Support] Move llvm::MemoryBuffer to sys::fs::file_t.

I got back to work and found some time, so now I have easy access to Linux and Windows, and should be able to finish this.

Jul 9 2019, 5:19 PM · Restricted Project
rnk committed rGabce8c457dd3: Revert [clang] DirectoryWatcher (authored by rnk).
Revert [clang] DirectoryWatcher
Jul 9 2019, 4:23 PM
rnk committed rL365581: Revert [clang] DirectoryWatcher.
Revert [clang] DirectoryWatcher
Jul 9 2019, 4:22 PM
rnk added a comment to D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.

Reverted in rC365581.

Jul 9 2019, 4:21 PM · Restricted Project, Restricted Project
rnk added inline comments to D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.
Jul 9 2019, 4:21 PM · Restricted Project, Restricted Project