Page MenuHomePhabricator
Feed Advanced Search

Tue, Jun 30

rnk committed rG926fab7c4fcd: [gn build] Update build for new OpenMP tablegen logic (authored by rnk).
[gn build] Update build for new OpenMP tablegen logic
Tue, Jun 30, 4:19 PM
rnk committed rGb7402edce315: [PDB] Defer public serialization until PDB writing (authored by rnk).
[PDB] Defer public serialization until PDB writing
Tue, Jun 30, 11:57 AM
rnk closed D81296: [PDB] Defer public serialization until PDB writing.
Tue, Jun 30, 11:57 AM · Restricted Project
rnk updated the diff for D81296: [PDB] Defer public serialization until PDB writing.
  • update
Tue, Jun 30, 11:24 AM · Restricted Project
rnk added inline comments to D81296: [PDB] Defer public serialization until PDB writing.
Tue, Jun 30, 11:24 AM · Restricted Project

Mon, Jun 29

rnk committed rG1c15229ba3a1: [gn build] Add missing llvm-lipo dep to check-lld (authored by rnk).
[gn build] Add missing llvm-lipo dep to check-lld
Mon, Jun 29, 12:29 PM
rnk committed rG6d01a9419351: Silence unused var warning in NDEBUG build (authored by rnk).
Silence unused var warning in NDEBUG build
Mon, Jun 29, 11:55 AM

Thu, Jun 11

rnk committed rG1c03389c29f3: Re-land "Migrate the rest of COFFObjectFile to Error" (authored by rnk).
Re-land "Migrate the rest of COFFObjectFile to Error"
Thu, Jun 11, 2:55 PM
rnk added a reverting change for rG101fbc01382e: Revert "Migrate the rest of COFFObjectFile to Error": rG1c03389c29f3: Re-land "Migrate the rest of COFFObjectFile to Error".
Thu, Jun 11, 2:55 PM

Jun 5 2020

rnk committed rGb5289656b865: Migrate the rest of COFFObjectFile to Error (authored by rnk).
Migrate the rest of COFFObjectFile to Error
Jun 5 2020, 4:50 PM
rnk committed rGe03a135be8cf: Re-land "Migrate Binary::checkOffset from error_code to Error, NFC" (authored by rnk).
Re-land "Migrate Binary::checkOffset from error_code to Error, NFC"
Jun 5 2020, 4:49 PM
rnk added a reverting change for rG38f3ba591e3a: Revert "Migrate Binary::checkOffset from error_code to Error, NFC": rGe03a135be8cf: Re-land "Migrate Binary::checkOffset from error_code to Error, NFC".
Jun 5 2020, 4:49 PM
rnk committed rG74bd98829d82: Migrate Binary::checkOffset from error_code to Error, NFC (authored by rnk).
Migrate Binary::checkOffset from error_code to Error, NFC
Jun 5 2020, 2:04 PM
rnk committed rG672ed5386024: [codeview] Put !heapallocsite on calls to operator new (authored by rnk).
[codeview] Put !heapallocsite on calls to operator new
Jun 5 2020, 12:58 PM
rnk closed D80966: [codeview] Put !heapallocsite on calls to operator new.
Jun 5 2020, 12:58 PM · Restricted Project
rnk created D81296: [PDB] Defer public serialization until PDB writing.
Jun 5 2020, 12:54 PM · Restricted Project

Jun 2 2020

rnk committed rG3eb16fe4e945: [LLD] Have only one SpecificAllocator per type (authored by rnk).
[LLD] Have only one SpecificAllocator per type
Jun 2 2020, 2:17 PM

Jun 1 2020

rnk committed rG11d1aa0bcc11: [COFF] Free some memory used for chunks (authored by rnk).
[COFF] Free some memory used for chunks
Jun 1 2020, 6:58 PM
rnk created D80966: [codeview] Put !heapallocsite on calls to operator new.
Jun 1 2020, 5:53 PM · Restricted Project
rnk updated the diff for D80966: [codeview] Put !heapallocsite on calls to operator new.
  • revert lld change
Jun 1 2020, 5:53 PM · Restricted Project
rnk added a comment to D80876: [clang] Default to windows response files when running on windows.

This seems wrong for mingw, so check with @mstorsjo.

Jun 1 2020, 3:43 PM · Restricted Project
rnk added a reviewer for D80876: [clang] Default to windows response files when running on windows: mstorsjo.
Jun 1 2020, 3:12 PM · Restricted Project
rnk committed rG45fd3e4688a7: [PDB] Share code to relocate .debug$[SF] sections, NFC (authored by rnk).
[PDB] Share code to relocate .debug$[SF] sections, NFC
Jun 1 2020, 1:34 PM
rnk committed rG8f0a66003064: [PDB] Use inlinee file checksum offsets directly (authored by rnk).
[PDB] Use inlinee file checksum offsets directly
Jun 1 2020, 1:00 PM

May 23 2020

rnk added a comment to D80433: [clang-tblgen][CommandLine][ManagedStatic] Fix build errors with clang-tblgen in Debug mode using MSVC 2019 v16.6.

To restate what I know, here is what I think is going on:

May 23 2020, 10:03 AM · Restricted Project, Restricted Project
rnk added inline comments to D69585: Add option to instantiate templates already in the PCH.
May 23 2020, 9:31 AM · Restricted Project
rnk accepted D80400: [DwarfEHPrepare] Don't prune unreachable resumes at optnone.

lgtm, thanks

May 23 2020, 8:59 AM · Restricted Project

May 21 2020

rnk updated subscribers of D80400: [DwarfEHPrepare] Don't prune unreachable resumes at optnone.

Neat

May 21 2020, 2:05 PM · Restricted Project
rnk added a comment to D79934: [RFC] [LLD] [COFF] Support options for enabling/disabling autoimport and pseudo relocs in .drectve sections.

I guess I would prefer not to add .drectve support for this unless there is a use case for it. It is a somewhat fragile interface.

May 21 2020, 12:59 PM · Restricted Project

May 20 2020

rnk accepted D69585: Add option to instantiate templates already in the PCH.

IMO there is a pretty clear performance use case for this mode of operation, and it seems to me that you have addressed @rsmith's feedback. Please wait a few days to see if he has more to add, but otherwise, feel free to land this after Friday.

May 20 2020, 4:35 PM · Restricted Project
rnk committed rG3508c1d8fbe9: [LLD] Make scoped timers thread safe (authored by rnk).
[LLD] Make scoped timers thread safe
May 20 2020, 4:35 PM
rnk closed D80298: [LLD] Make scoped timers thread safe.
May 20 2020, 4:34 PM · Restricted Project
rnk added a comment to D80153: [AST] Mangle LambdaContextDecl for top level decl.

After looking at the code more, I'm more convinced that your fix is in the right place.

May 20 2020, 4:33 PM · Restricted Project
rnk added inline comments to D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM.
May 20 2020, 3:27 PM · Restricted Project, Restricted Project
rnk accepted D79847: [Support] On Windows, handle interrupt signals without crash message.

I don't have Cygwin anymore. IMO your code change seems low risk for cygwin, although the test could always fail with Cygwin Python, but IMO it's not worth worrying about.

May 20 2020, 2:53 PM · Restricted Project
rnk added a comment to D80225: [Driver] Recognize -fuse-ld={bfd,gold,lld} but don't prepend "ld." or "ld64." for other values.

Personally, I support this. I never liked the magic ld. prefixing. If we want a way to select a proprietary linker, it seems reasonable to ask the user to name the complete binary basename (ld.lld, lld, ld64, myld, etc). The driver shouldn't force the linker to use some special executable naming scheme.

May 20 2020, 2:53 PM · Restricted Project
rnk added a comment to D79269: [NativeSession] Implement NativeSession::findSymbolByAddress..

I would like to register a small complaint that this script even exists in the first place. LLVM uses CMake. It's not OK for contributors to add their own ad-hoc shell script build systems and then impose the costs of maintaining them on other contributors. However, on the other hand, I understand what this script is trying to do, and do not have concrete suggestions on how to replace it. My only request is that the team that maintains it remains proactive about finding and fixing these problems.

May 20 2020, 12:02 PM · Restricted Project
rnk created D80298: [LLD] Make scoped timers thread safe.
May 20 2020, 8:10 AM · Restricted Project

May 19 2020

rnk removed a reviewer for D78346: Fix Windows command line bug when last token in response file is "": rnk.
May 19 2020, 12:02 PM · Restricted Project
rnk added a comment to D78346: Fix Windows command line bug when last token in response file is "".

Thanks for the fix, I agree with Adrian's feedback. @amccarth, can you take over the review? I will remove myself, thanks.

May 19 2020, 12:02 PM · Restricted Project
rnk accepted D77920: [Windows EH] Fix the order of Nested try-catches in $tryMap$ table.

The code change looks correct, but the test still needs to be updated. I'll go ahead and mark it accepted, but please remember to do that when landing this.

May 19 2020, 12:02 PM · Restricted Project
rnk updated subscribers of D79591: Fix for Bug45811 - Failed assertion.

@hans is the resident dllexport expert at this moment.

May 19 2020, 11:30 AM

May 18 2020

rnk added a comment to D75323: Support relative dest paths in headermap files.

@vsapsai @bruno The use case is distributed compilation. I am unfamiliar with the changes in question, but essentially, if every input to clang is rooted in /Users/foo and the build works there, we should be able to move it all to /Users/bar, change directories, and the build should still work. It seems that this doesn't work for header maps, but I haven't reviewed the code change or test and know nothing else about this feature.

May 18 2020, 6:58 PM · Restricted Project
rnk added a comment to D75323: Support relative dest paths in headermap files.

For more context: https://crbug.com/1056174

May 18 2020, 6:58 PM · Restricted Project
rnk added inline comments to D80153: [AST] Mangle LambdaContextDecl for top level decl.
May 18 2020, 6:26 PM · Restricted Project
rnk committed rG47cc6db928d0: Re-land [Debug][CodeView] Emit fully qualified names for globals (authored by rnk).
Re-land [Debug][CodeView] Emit fully qualified names for globals
May 18 2020, 5:54 PM
rnk added a reverting change for rG525a591f0f48: Revert 76c5f277f2 "Re-land [Debug][CodeView] Emit fully qualified names for…: rG47cc6db928d0: Re-land [Debug][CodeView] Emit fully qualified names for globals.
May 18 2020, 5:54 PM
rnk added a comment to D80172: Revert "Re-fix _lrotl/_lrotr to always take Long, no matter the platform.".

I'd be fine going back to the behavior from before.

May 18 2020, 5:54 PM · Restricted Project
rnk added inline comments to D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function.
May 18 2020, 4:17 PM · Restricted Project
rnk added a comment to D79537: Add NoMerge MIFlag to avoid MIR branch folding.

I think this looks good, but I want to find another reviewer for CodeGen. @craig.topper or @arsenm, are you OK reviewing this, or can you recommend another reviewer?

May 18 2020, 4:17 PM · Restricted Project
rnk accepted D79121: Add nomerge statement attribute to clang.

I think this looks good and @zequanwu has addressed the concerns of other reviewers. Please wait until Wednesday before pushing in case they raise other concerns.

May 18 2020, 3:12 PM · Restricted Project
rnk added a comment to D79447: [Debug][CodeView] Emit fully qualified names for globals.

I will take a look and try to reland this, since I requested the assert.

May 18 2020, 12:26 PM · Restricted Project, Restricted Project

May 15 2020

rnk added inline comments to D80006: [Clang][DebugInfo] Make DIFile filename and directory native to target architecture.
May 15 2020, 2:42 PM · debug-info, Restricted Project
rnk edited reviewers for D78508: [Clang] Allow long as size_t printf argument on 32-bit Windows platforms., added: hans; removed: rnk.
May 15 2020, 7:00 AM · Restricted Project

May 14 2020

rnk accepted D79447: [Debug][CodeView] Emit fully qualified names for globals.

lgtm, modulo ifdef adjustment

May 14 2020, 12:30 PM · Restricted Project, Restricted Project
rnk added inline comments to D68820: win: Move Parallel.h off concrt to cross-platform code.
May 14 2020, 12:30 PM · Restricted Project
rnk committed rG3774bcf9f845: [COFF] Fix var names cVStrTab->cvStrTab sXDataChunks->sxDataChunks (authored by rnk).
[COFF] Fix var names cVStrTab->cvStrTab sXDataChunks->sxDataChunks
May 14 2020, 11:25 AM
rnk committed rGf5a79713b612: [LLD] Fix precomp-link.test (authored by rnk).
[LLD] Fix precomp-link.test
May 14 2020, 10:50 AM
rnk committed rG54a335a2f60b: [COFF] Move type merging to TpiSource::mergeDebugT virtual method (authored by rnk).
[COFF] Move type merging to TpiSource::mergeDebugT virtual method
May 14 2020, 10:17 AM
rnk closed D79672: [COFF] Move type merging to TpiSource::mergeDebugT virtual method.
May 14 2020, 10:17 AM · Restricted Project
rnk added a comment to D79672: [COFF] Move type merging to TpiSource::mergeDebugT virtual method.

Thanks! I measured time and memory usage on a particular binary, and this change had no measurable effect, which is good.

May 14 2020, 9:44 AM · Restricted Project
rnk added inline comments to D79672: [COFF] Move type merging to TpiSource::mergeDebugT virtual method.
May 14 2020, 9:43 AM · Restricted Project

May 13 2020

rnk added inline comments to D79396: [BrachProbablityInfo] Set edge probabilities at once..
May 13 2020, 4:56 PM · Restricted Project
rnk committed rG40927427406d: [PDB] Switch from LLVM_PACKED to LLVM_PACKED_START/END (authored by rnk).
[PDB] Switch from LLVM_PACKED to LLVM_PACKED_START/END
May 13 2020, 2:44 PM
rnk accepted D78923: [LLD] [COFF] Add options for disabling auto import and runtime pseudo relocs.

Looks good.

May 13 2020, 2:42 PM · Restricted Project
rnk added a comment to D79467: [PDB] Optimize public symbol processing.

Hopefully rG409274274 addresses the GCC warnings. I didn't get a chance to locally repro and confirm that the fix works.

May 13 2020, 2:42 PM · Restricted Project
rnk updated the diff for D79672: [COFF] Move type merging to TpiSource::mergeDebugT virtual method.
  • Add logic to clear global tpi source lists
  • Remove check for type server PDB age
May 13 2020, 2:42 PM · Restricted Project
rnk removed a reviewer for D79786: [Dexter] Add DexLimitSteps command and ConditionalController implementation: rnk.
May 13 2020, 2:09 PM · debug-info
rnk removed a reviewer for D79820: [test] Improve FileCheck's numeric-expression.txt: rnk.
May 13 2020, 2:09 PM · Restricted Project
rnk added inline comments to D79537: Add NoMerge MIFlag to avoid MIR branch folding.
May 13 2020, 2:09 PM · Restricted Project
rnk accepted D77689: [X86] Codegen for preallocated.

I have some surface level code style comments, please address those and land this if you agree.

May 13 2020, 2:09 PM · Restricted Project
rnk updated subscribers of D79537: Add NoMerge MIFlag to avoid MIR branch folding.

After this lands, can you follow this up by migrating the sanitizer passes to using the attribute instead of using empty inline asm blobs? Send the patch to @vitalybuka. This is the code I'm thinking of:
https://github.com/llvm/llvm-project/blob/028bfdd8913616f7a3e57e8ef5c2a9990e528ff0/llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp#L1626
https://github.com/llvm/llvm-project/blob/d6695e18763a05b30cb336c18157175277da8f4b/llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp#L864
... and any similar uses.

May 13 2020, 1:36 PM · Restricted Project
rnk added inline comments to D78659: Add nomerge function attribute to supress tail merge optimization in simplifyCFG.
May 13 2020, 1:36 PM · Restricted Project, Restricted Project
rnk updated subscribers of D79672: [COFF] Move type merging to TpiSource::mergeDebugT virtual method.
May 13 2020, 1:36 PM · Restricted Project
rnk added a comment to D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function.

Arthur recently went through the process of refining a diagnostic, so he should be able to help guide you in this if you have more questions.

May 13 2020, 1:03 PM · Restricted Project
rnk edited reviewers for D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function, added: aeubanks; removed: rnk.
May 13 2020, 1:03 PM · Restricted Project
rnk accepted D79274: Fix template class debug info for Visual Studio visualizers.

lgtm, thanks!

May 13 2020, 1:03 PM · Restricted Project
rnk added a comment to D79537: Add NoMerge MIFlag to avoid MIR branch folding.

Overall, this looks good to me, but I'd like to ask @craig.topper for an opinion. His area of expertise is the x86 backend.

May 13 2020, 1:03 PM · Restricted Project
rnk edited reviewers for D79537: Add NoMerge MIFlag to avoid MIR branch folding, added: craig.topper; removed: rnk.
May 13 2020, 1:03 PM · Restricted Project
rnk committed rG1370757dd019: Revert "[BrachProbablityInfo] Set edge probabilities at once. NFC." (authored by rnk).
Revert "[BrachProbablityInfo] Set edge probabilities at once. NFC."
May 13 2020, 8:38 AM
rnk added a reverting change for rGeef95f2746c3: [BrachProbablityInfo] Set edge probabilities at once. NFC.: rG1370757dd019: Revert "[BrachProbablityInfo] Set edge probabilities at once. NFC.".
May 13 2020, 8:38 AM
rnk updated subscribers of D79594: Fix MSan test use-after-dtor.cpp under new pass manager.

rnk@ mentioned to me something about inlining and symbolization under the new pass manager, any links to that so I can put it in the description?

May 13 2020, 8:38 AM · Restricted Project
rnk added inline comments to D79396: [BrachProbablityInfo] Set edge probabilities at once..
May 13 2020, 8:38 AM · Restricted Project
rnk added inline comments to D79396: [BrachProbablityInfo] Set edge probabilities at once..
May 13 2020, 8:37 AM · Restricted Project

May 12 2020

rnk committed rGcb22ab740355: Add nomerge function attribute to supress tail merge optimization in simplifyCFG (authored by zequanwu).
Add nomerge function attribute to supress tail merge optimization in simplifyCFG
May 12 2020, 5:16 PM
rnk closed D78659: Add nomerge function attribute to supress tail merge optimization in simplifyCFG.
May 12 2020, 5:16 PM · Restricted Project, Restricted Project
rnk accepted D79269: [NativeSession] Implement NativeSession::findSymbolByAddress..
May 12 2020, 3:37 PM · Restricted Project
rnk accepted D79795: Ensure that CMake tries to find Python3 before processing.

Grepping for this shows that it turns up in all the other top-level CMakeLists.txt. Sigh, duplication. lgtm.

May 12 2020, 2:32 PM · Restricted Project
rnk updated the summary of D79672: [COFF] Move type merging to TpiSource::mergeDebugT virtual method.
May 12 2020, 12:24 PM · Restricted Project
rnk updated the diff for D79672: [COFF] Move type merging to TpiSource::mergeDebugT virtual method.
  • Fix tests, add tests, fix naming
May 12 2020, 12:23 PM · Restricted Project
rnk added a comment to D79672: [COFF] Move type merging to TpiSource::mergeDebugT virtual method.

This next update fixes the variable naming issues, test failures, and adds a PCH test. It should be ready for review.

May 12 2020, 12:22 PM · Restricted Project
rnk committed rG6da5672962c2: [LLD] Rename iDTable -> idTable, NFC (authored by rnk).
[LLD] Rename iDTable -> idTable, NFC
May 12 2020, 6:57 AM

May 11 2020

rnk added inline comments to D79274: Fix template class debug info for Visual Studio visualizers.
May 11 2020, 2:01 PM · Restricted Project

May 9 2020

rnk added inline comments to D78884: [CMake] -gen-dag-isel: add -omit-comments if neither Debug nor RelWithDebInfo.
May 9 2020, 9:01 AM · Restricted Project
rnk added a comment to D79636: [LangRef] Clarify the semantics of the `byval` attribute.

Some copy editing comments, but I agree with the semantics: From the IR perspective, it is better to think of argument stack memory as belonging to the callee. A byval argument has more in common with a local static alloca than a passed in pointer.

May 9 2020, 8:29 AM · Restricted Project
rnk accepted D79619: [LLD] [COFF] Fix def file exporting of symbols containing periods.

lgtm

May 9 2020, 8:29 AM · Restricted Project
rnk added a comment to D79673: Allow 32-bit pointer extensions to be used without -fms-extensions.

Needs a test.

May 9 2020, 8:29 AM · Restricted Project
rnk created D79672: [COFF] Move type merging to TpiSource::mergeDebugT virtual method.
May 9 2020, 7:25 AM · Restricted Project

May 8 2020

rnk added a comment to D79467: [PDB] Optimize public symbol processing.
In D79467#2027736, @rnk wrote:

Speaking of which, @aganea, since you are using clang to compile now, you should try adding -Xclang -debug-info-kind=constructor if you haven't already. It greatly reduces the amount of duplicate type info that clang emits.

We were discussing about that today. Is there any drawback for doing so?

May 8 2020, 4:08 PM · Restricted Project
rnk added a comment to D79467: [PDB] Optimize public symbol processing.

Right, I remember actually reviewing D59226, and then thinking that it had landed. I will look into rebasing it, thanks for the reminder.

May 8 2020, 3:03 PM · Restricted Project