Page MenuHomePhabricator
Feed Advanced Search

Fri, Oct 18

rnk committed rG7bbe711fb1b9: Avoid including CodeView/SymbolRecord.h from MCStreamer.h (authored by rnk).
Avoid including CodeView/SymbolRecord.h from MCStreamer.h
Fri, Oct 18, 6:43 PM
rnk committed rL375325: Avoid including CodeView/SymbolRecord.h from MCStreamer.h.
Avoid including CodeView/SymbolRecord.h from MCStreamer.h
Fri, Oct 18, 6:43 PM
rnk committed rL375320: Prune a LegacyDivergenceAnalysis and MachineLoopInfo include each.
Prune a LegacyDivergenceAnalysis and MachineLoopInfo include each
Fri, Oct 18, 6:33 PM
rnk committed rG904cd3e06b98: Prune a LegacyDivergenceAnalysis and MachineLoopInfo include each (authored by rnk).
Prune a LegacyDivergenceAnalysis and MachineLoopInfo include each
Fri, Oct 18, 6:33 PM
rnk committed rG0ad6c191deef: Prune Analysis includes from SelectionDAG.h (authored by rnk).
Prune Analysis includes from SelectionDAG.h
Fri, Oct 18, 6:15 PM
rnk committed rL375319: Prune Analysis includes from SelectionDAG.h.
Prune Analysis includes from SelectionDAG.h
Fri, Oct 18, 6:06 PM
rnk committed rG90c64a3456b9: Move endian constant from Host.h to SwapByteOrder.h, prune include (authored by rnk).
Move endian constant from Host.h to SwapByteOrder.h, prune include
Fri, Oct 18, 5:47 PM
rnk committed rL375316: Move endian constant from Host.h to SwapByteOrder.h, prune include.
Move endian constant from Host.h to SwapByteOrder.h, prune include
Fri, Oct 18, 5:47 PM
rnk committed rG1d7b41361ffa: Prune two MachineInstr.h includes, fix up deps (authored by rnk).
Prune two MachineInstr.h includes, fix up deps
Fri, Oct 18, 5:29 PM
rnk committed rL375311: Prune two MachineInstr.h includes, fix up deps.
Prune two MachineInstr.h includes, fix up deps
Fri, Oct 18, 5:19 PM
rnk committed rG52d765544b50: [X86] Fix register parsing in .seh_* in Intel syntax (authored by rnk).
[X86] Fix register parsing in .seh_* in Intel syntax
Fri, Oct 18, 2:05 PM
rnk committed rL375287: [X86] Fix register parsing in .seh_* in Intel syntax.
[X86] Fix register parsing in .seh_* in Intel syntax
Fri, Oct 18, 2:04 PM

Thu, Oct 17

rnk added a comment to D65761: Add Windows Control Flow Guard checks (/guard:cf)..

I think this looks pretty good, thanks! I really only noticed style nits. I think with some small fixes, we should go ahead and merge it. If you want, I can commit it on your behalf, but I know there are other folks at Microsoft with commit access to LLVM, if you'd prefer. When you upload the next diff, make sure to use the merge point with origin/master as the base, so that the patch will apply cleanly.

Thu, Oct 17, 4:40 PM · Restricted Project, Restricted Project
rnk added a comment to D69136: Add an instruction marker field to the ExtraInfo in MachineInstrs..

Thanks for putting up with these micro-optimized data structures, sorry they're opaque.

Thu, Oct 17, 3:43 PM · Restricted Project
rnk added inline comments to D69136: Add an instruction marker field to the ExtraInfo in MachineInstrs..
Thu, Oct 17, 3:34 PM · Restricted Project
rnk committed rG0aaa193127f3: [asan] Update Windows test expectations for LLVM's MS demangler (authored by rnk).
[asan] Update Windows test expectations for LLVM's MS demangler
Thu, Oct 17, 11:02 AM
rnk committed rL375147: [asan] Update Windows test expectations for LLVM's MS demangler.
[asan] Update Windows test expectations for LLVM's MS demangler
Thu, Oct 17, 11:02 AM
rnk added a comment to D68133: [Symbolize] Use the local MSVC C++ demangler instead of relying on dbghelp. NFC..

It seems like this still broke a buildbot. @rnk, as it's your bot, can you look into it before we revert this? The logs don't really show enough detail... http://lab.llvm.org:8011/builders/sanitizer-windows/builds/53114/steps/stage%201%20check/logs/stdio

Thu, Oct 17, 11:02 AM · Restricted Project
rnk committed rG4ff1e34b606d: Revert [lit] Synthesize artificial deadline (authored by rnk).
Revert [lit] Synthesize artificial deadline
Thu, Oct 17, 10:52 AM
rnk committed rL375143: Revert [lit] Synthesize artificial deadline.
Revert [lit] Synthesize artificial deadline
Thu, Oct 17, 10:42 AM
rnk committed rGfc69ad09882c: [codeview] Workaround for PR43479, don't re-emit instr labels (authored by rnk).
[codeview] Workaround for PR43479, don't re-emit instr labels
Thu, Oct 17, 10:34 AM
rnk closed D69068: [codeview] Workaround for PR43479, don't re-emit instr labels.
Thu, Oct 17, 10:33 AM · Restricted Project
rnk committed rL375137: [codeview] Workaround for PR43479, don't re-emit instr labels.
[codeview] Workaround for PR43479, don't re-emit instr labels
Thu, Oct 17, 10:33 AM
rnk accepted D69098: Remove -DLLVM_USE_LINKER from Windows self host bots.

lgtm

Thu, Oct 17, 10:14 AM · Restricted Project
rnk added a comment to D68772: [COFF] Wrap things in namespace lld { namespace coff {.

I guess the productive thing to do would be for me to put together a patch to CodingStandards and then send it to llvm-dev to get some feedback, and then follow up myself here.

Thu, Oct 17, 10:14 AM · Restricted Project

Wed, Oct 16

rnk accepted D68847: [lit] Small refactoring and cleanups in main.py.

lgtm

Wed, Oct 16, 2:13 PM · Restricted Project
rnk added a comment to D69013: [AArch64][X86] Don't assume __powidf2 is available on Windows..

I tried to get clang to make llvm.powi from C, but it was challenging. Setting -fno-math-errno was what ended up mattering, and even then, I couldn't go from llvm.pow.f64 to powi.

Wed, Oct 16, 1:47 PM · Restricted Project
rnk accepted D68133: [Symbolize] Use the local MSVC C++ demangler instead of relying on dbghelp. NFC..

lgtm

Wed, Oct 16, 1:27 PM · Restricted Project
rnk created D69068: [codeview] Workaround for PR43479, don't re-emit instr labels.
Wed, Oct 16, 1:18 PM · Restricted Project

Tue, Oct 15

rnk committed rG215a8d948d66: Fix as-w-option.c on Windows where no assembler exists (authored by rnk).
Fix as-w-option.c on Windows where no assembler exists
Tue, Oct 15, 11:45 AM
rnk committed rL374936: Fix as-w-option.c on Windows where no assembler exists.
Fix as-w-option.c on Windows where no assembler exists
Tue, Oct 15, 11:45 AM

Mon, Oct 14

rnk added a comment to D67723: [DebugInfo] Add option to disable inline line tables..

Who is "we" in this context? The CodeView backend?

Mon, Oct 14, 5:10 PM · debug-info, Restricted Project, Restricted Project
rnk added a comment to D68708: [RFC] Adopt Dexter and use it to run debuginfo-tests.

I looked at some of the converted cdb tests, and it looks pretty nice. Thanks for working on this! :)

Mon, Oct 14, 3:50 PM · Restricted Project
rnk added inline comments to D67723: [DebugInfo] Add option to disable inline line tables..
Mon, Oct 14, 3:41 PM · debug-info, Restricted Project, Restricted Project
rnk added a comment to D68720: Support -fstack-clash-protection for x86.

For maintenance reasons, I'd really prefer it if we could find a way to reuse the existing code that calls an external stack probe function. What do you think about taking a look at X86RetpolineThunks.cpp and doing something similar to that? Basically, when the user sets -fstack-clash-protection, LLVM will emit a small comdat+weak function into every object file that has the same ABI as the existing stack probe mechanism. For other prior art, you can also look at how __clang_call_terminate works.

Mon, Oct 14, 3:28 PM · Restricted Project, Restricted Project
rnk added inline comments to D68935: [LLD] [COFF] Wrap file location pair<StringRef,int> in Optional<>. NFC..
Mon, Oct 14, 2:21 PM · Restricted Project
rnk added a comment to D64962: appendToGlobalCtors: allow for llvm.global_ctors functions of varying type.

Q: Why should appendToGlobalCtors take a Function * in the first place?

Mon, Oct 14, 2:21 PM · Restricted Project
rnk accepted D68843: [lit] Create Run object later and only when it is needed.

Looks good, amusing. :)

Mon, Oct 14, 2:13 PM · Restricted Project
rnk updated subscribers of D68953: Enable most VFS tests on Windows.

+VFS people, mostly just to let them know
@arphaman @Bigcheese @vsapsai

Mon, Oct 14, 2:12 PM · Restricted Project
rnk accepted D68917: [Demangle] Add a few more options to the microsoft demangler.

lgtm

Mon, Oct 14, 2:12 PM · Restricted Project
rnk added inline comments to D68917: [Demangle] Add a few more options to the microsoft demangler.
Mon, Oct 14, 1:26 PM · Restricted Project
rnk added a comment to D67723: [DebugInfo] Add option to disable inline line tables..

Based on what we learned in https://llvm.org/PR43530, I think we still want to use the location of the call site and not line zero. :(

Mon, Oct 14, 1:15 PM · debug-info, Restricted Project, Restricted Project
rnk added a comment to D68945: [DebugInfo] Don't translate dbg.addr and similar intrinsics into indirect DBG_VALUEs.

This makes sense to me, we should be able to replace isIndirect with DW_OP_deref.

Mon, Oct 14, 11:49 AM · Restricted Project

Fri, Oct 11

rnk added a comment to D67723: [DebugInfo] Add option to disable inline line tables..

I guess the commit message shouldn't say "[CodeView] Add option to disable inline line tables." It's really an option for all debug info. You could put "[DebugInfo]" on there, or just drop the tag.

Fri, Oct 11, 3:19 PM · debug-info, Restricted Project, Restricted Project
rnk added inline comments to D67723: [DebugInfo] Add option to disable inline line tables..
Fri, Oct 11, 2:50 PM · debug-info, Restricted Project, Restricted Project
rnk added inline comments to D68772: [COFF] Wrap things in namespace lld { namespace coff {.
Fri, Oct 11, 1:55 PM · Restricted Project
rnk accepted D68836: [lit] Small cleanups in main.py.

lgtm

Fri, Oct 11, 1:37 PM · Restricted Project
rnk accepted D68450: [lit] Remove setting of the target-windows feature.

lgtm

Fri, Oct 11, 1:35 PM · Restricted Project
rnk accepted D68839: [lit] Fix internal diff's --strip-trailing-cr and use it.

I looked into these tests, and it seems that they would've failed if it were not for Python's universal newline translator thing. When I diff the files in question with gnu diff from git bash, they appear to be different without -w or --strip-trailing-cr. So, your fix makes lit's diff more like gnu diff, and fixes the tests to work in that mode.

Fri, Oct 11, 1:35 PM · Restricted Project

Thu, Oct 10

rnk committed rG9280d6c178a4: Fix check-interception link error in compiler-rt debug mode (authored by rnk).
Fix check-interception link error in compiler-rt debug mode
Thu, Oct 10, 4:35 PM
rnk committed rL374472: Fix check-interception link error in compiler-rt debug mode.
Fix check-interception link error in compiler-rt debug mode
Thu, Oct 10, 4:35 PM
rnk committed rG5e866e411caa: Add -fgnuc-version= to control __GNUC__ and other GCC macros (authored by rnk).
Add -fgnuc-version= to control __GNUC__ and other GCC macros
Thu, Oct 10, 2:06 PM
rnk closed D68055: Add -fgnuc-version= to control __GNUC__ and other GCC macros.
Thu, Oct 10, 2:06 PM · Restricted Project
rnk committed rL374449: Add -fgnuc-version= to control __GNUC__ and other GCC macros.
Add -fgnuc-version= to control __GNUC__ and other GCC macros
Thu, Oct 10, 2:06 PM
rnk accepted D68830: [lit] Break main into smaller functions.

lgtm

Thu, Oct 10, 1:56 PM · Restricted Project
rnk added inline comments to D68772: [COFF] Wrap things in namespace lld { namespace coff {.
Thu, Oct 10, 1:25 PM · Restricted Project
rnk accepted D66431: [PDB] Fix bug when using multiple PCH header objects with the same name..

Go for it.

Thu, Oct 10, 1:16 PM · Restricted Project
rnk committed rG377fcf61b652: Fix one more clang test which didn't have \5C in it (authored by rnk).
Fix one more clang test which didn't have \5C in it
Thu, Oct 10, 11:41 AM
rnk committed rL374418: Fix one more clang test which didn't have \5C in it.
Fix one more clang test which didn't have \5C in it
Thu, Oct 10, 11:41 AM
rnk committed rG63bb6737cee9: Update clang tests for new LLVM IR backslash printing in r374415 (authored by rnk).
Update clang tests for new LLVM IR backslash printing in r374415
Thu, Oct 10, 11:41 AM
rnk committed rL374416: Update clang tests for new LLVM IR backslash printing in r374415.
Update clang tests for new LLVM IR backslash printing in r374415
Thu, Oct 10, 11:41 AM
rnk accepted D68820: win: Move Parallel.h off concrt to cross-platform code.

Looks very good. :)

Thu, Oct 10, 11:41 AM · Restricted Project
rnk committed rG67d440b949d6: Print quoted backslashes in LLVM IR as \\ instead of \5C (authored by rnk).
Print quoted backslashes in LLVM IR as \\ instead of \5C
Thu, Oct 10, 11:32 AM
rnk committed rL374415: Print quoted backslashes in LLVM IR as \\ instead of \5C.
Print quoted backslashes in LLVM IR as \\ instead of \5C
Thu, Oct 10, 11:31 AM
rnk committed rGf05ed6601f22: Remove strings.h include to fix GSYM Windows build (authored by rnk).
Remove strings.h include to fix GSYM Windows build
Thu, Oct 10, 11:22 AM
rnk committed rL374411: Remove strings.h include to fix GSYM Windows build.
Remove strings.h include to fix GSYM Windows build
Thu, Oct 10, 11:22 AM
rnk committed rGe80a2616c8dd: Fix test to avoid check-not matching the temp file absolute path (authored by rnk).
Fix test to avoid check-not matching the temp file absolute path
Thu, Oct 10, 11:03 AM
rnk committed rG9d4806a38789: Re-land "Use -fdebug-compilation-dir to form absolute paths in coverage… (authored by rnk).
Re-land "Use -fdebug-compilation-dir to form absolute paths in coverage…
Thu, Oct 10, 11:03 AM
rnk committed rL374404: Fix test to avoid check-not matching the temp file absolute path.
Fix test to avoid check-not matching the temp file absolute path
Thu, Oct 10, 11:03 AM
rnk committed rL374403: Re-land "Use -fdebug-compilation-dir to form absolute paths in coverage….
Re-land "Use -fdebug-compilation-dir to form absolute paths in coverage…
Thu, Oct 10, 11:03 AM

Wed, Oct 9

rnk committed rGda2bde9e34df: Re-land [mangle] Fix mangling where an extra mangle context is required. (authored by rnk).
Re-land [mangle] Fix mangling where an extra mangle context is required.
Wed, Oct 9, 6:13 PM
rnk committed rGc34385d07c7d: Revert [mangle] Fix mangling where an extra mangle context is required. (authored by rnk).
Revert [mangle] Fix mangling where an extra mangle context is required.
Wed, Oct 9, 6:13 PM
rnk committed rL374269: Re-land [mangle] Fix mangling where an extra mangle context is required..
Re-land [mangle] Fix mangling where an extra mangle context is required.
Wed, Oct 9, 6:13 PM
rnk committed rG9d8f0b3519c4: [codeview] Try to avoid emitting .cv_loc with line zero (authored by rnk).
[codeview] Try to avoid emitting .cv_loc with line zero
Wed, Oct 9, 6:13 PM
rnk committed rL374268: Revert [mangle] Fix mangling where an extra mangle context is required..
Revert [mangle] Fix mangling where an extra mangle context is required.
Wed, Oct 9, 6:13 PM
rnk closed D68747: [codeview] Try to avoid emitting .cv_loc with line zero.
Wed, Oct 9, 6:13 PM · Restricted Project
rnk committed rL374267: [codeview] Try to avoid emitting .cv_loc with line zero.
[codeview] Try to avoid emitting .cv_loc with line zero
Wed, Oct 9, 6:04 PM
rnk committed rGf6777964bde2: Use -fdebug-compilation-dir to form absolute paths in coverage mappings (authored by rnk).
Use -fdebug-compilation-dir to form absolute paths in coverage mappings
Wed, Oct 9, 5:55 PM
rnk closed D68733: Use -fdebug-compilation-dir to form absolute paths in coverage mappings.
Wed, Oct 9, 5:54 PM · Restricted Project
rnk committed rL374266: Use -fdebug-compilation-dir to form absolute paths in coverage mappings.
Use -fdebug-compilation-dir to form absolute paths in coverage mappings
Wed, Oct 9, 5:54 PM
rnk created D68747: [codeview] Try to avoid emitting .cv_loc with line zero.
Wed, Oct 9, 5:17 PM · Restricted Project
rnk added inline comments to D68733: Use -fdebug-compilation-dir to form absolute paths in coverage mappings.
Wed, Oct 9, 5:00 PM · Restricted Project
rnk accepted D68736: [MSVC] Automatically add atlmfc include and lib directories as system paths..

I think the old VS Express editions used to exclude atlmfc, so there's the possibility that we'll be searching non-existent directories, but I think that's OK. Whoever wrote this code was probably basing it on what VS express did. That edition is long gone, and we're better off with this new logic.

Wed, Oct 9, 3:54 PM · Restricted Project
rnk created D68733: Use -fdebug-compilation-dir to form absolute paths in coverage mappings.
Wed, Oct 9, 2:43 PM · Restricted Project
rnk updated the diff for D68055: Add -fgnuc-version= to control __GNUC__ and other GCC macros.
  • Fix GNUG, tighten tests for it
Wed, Oct 9, 2:06 PM · Restricted Project
rnk accepted D68689: [LLD] [MinGW] Look for other library patterns with -l.

lgtm

Wed, Oct 9, 1:56 PM · Restricted Project
rnk updated the diff for D68055: Add -fgnuc-version= to control __GNUC__ and other GCC macros.
  • add docs, release note
  • keep __EXCEPTIONS if !ms
  • keep private_extern if !ms
  • set GNUG value with flag
Wed, Oct 9, 1:28 PM · Restricted Project
rnk accepted D68716: [clang] prevent crash for nonnull attribut in constant context (Bug 43601).

lgtm, thanks.

Wed, Oct 9, 1:10 PM · Restricted Project

Tue, Oct 8

rnk added a comment to D68055: Add -fgnuc-version= to control __GNUC__ and other GCC macros.

From a big-picture perspective, I would like us to move to treating MS and GNU extensions in the same way (at the cc1 level) to the extent that we can. I think this moves us in that direction.

Tue, Oct 8, 4:58 PM · Restricted Project
rnk accepted D68668: [lit] Extend internal diff to support -U.

lgtm

Tue, Oct 8, 3:45 PM · Restricted Project
rnk accepted D67643: [lit] Extend internal diff to support `-` argument.

lgtm

Tue, Oct 8, 2:33 PM · Restricted Project
rnk accepted D68664: [lit] Clean up internal diff's encoding handling.

I'm guessing you've tested with Python 2.7 and 3.5, and that's probably what matters.

Tue, Oct 8, 2:24 PM · Restricted Project
rnk accepted D68610: [clang] enable_trivial_var_init_zero should not be Joined<>.

lgtm

Tue, Oct 8, 1:26 PM · Restricted Project
rnk added a comment to D68570: Unify the two CRC implementations.

Maybe a dumb idea: can we compute the table with constexpr evaluation? You could set up a constexpr function that returns a struct that wraps the array, and then the body of the function would construct the array imperatively as the old initialization code did. Set up a constexpr global with an initializer that calls the function.

Tue, Oct 8, 10:57 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Oct 7

rnk committed rL373976: [X86] Add new calling convention that guarantees tail call optimization.
[X86] Add new calling convention that guarantees tail call optimization
Mon, Oct 7, 10:22 PM
rnk committed rGf9b67b810e2d: [X86] Add new calling convention that guarantees tail call optimization (authored by rnk).
[X86] Add new calling convention that guarantees tail call optimization
Mon, Oct 7, 10:22 PM
rnk closed D67855: [X86] Add new calling convention that guarantees tail call optimization.
Mon, Oct 7, 10:22 PM · Restricted Project
rnk accepted D68608: [clang] Accept -ftrivial-auto-var-init in clang-cl.

lgtm

Mon, Oct 7, 4:42 PM · Restricted Project, Restricted Project
rnk added a comment to D67742: Add VFS support for sanitizers' blacklist.

Broke Windows:
http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/11306

Mon, Oct 7, 4:40 PM · Restricted Project
rnk added a comment to D67855: [X86] Add new calling convention that guarantees tail call optimization.

It's ready on my end. I don't have commit access, so...

Mon, Oct 7, 3:49 PM · Restricted Project