Page MenuHomePhabricator
Feed Advanced Search

Today

mcgrathr added inline comments to D72959: Relative VTables ABI on Fuchsia.
Thu, Apr 2, 11:55 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Mar 30

mcgrathr accepted D76963: [profile] Avoid duplicating or leaking VMO.

lgtm

Mon, Mar 30, 2:11 PM · Restricted Project

Tue, Mar 24

mcgrathr accepted D76750: [profile] Move RuntimeCounterRelocation and ProfileDumped into a separate file.

lgtm

Tue, Mar 24, 8:24 PM · Restricted Project
mcgrathr accepted D76556: [profile] Make atexit hook a no-op on Fuchsia.

lgtm with comment and nits

Tue, Mar 24, 6:36 PM · Restricted Project
mcgrathr added a comment to D76668: [lld][ELF] Ignore __start/__stop symbols in section groups during GC.

The discussion and the tests should distinguish the COMDAT semantics from the --gc-sections semantics. They are related but distinct.

Tue, Mar 24, 3:39 PM · Restricted Project

Mon, Mar 23

mcgrathr added inline comments to D76556: [profile] Make atexit hook a no-op on Fuchsia.
Mon, Mar 23, 1:38 PM · Restricted Project

Sat, Mar 21

mcgrathr added inline comments to D76556: [profile] Make atexit hook a no-op on Fuchsia.
Sat, Mar 21, 5:06 PM · Restricted Project

Fri, Mar 20

mcgrathr added a comment to D76482: [lld][ELF] Provide optional hidden symbol for build ID.

I think if you provide symbols for the section bounds, they should be __start_note_gnu_build_id and __stop_note_gnu_build_id. But that doesn't seem enough of an improvement over parsing phdrs from __ehdr_start to merit the feature IMHO. Consumers still have to parse (or worse yet, assume) the note headers. What would make things trivial for consumers is a pair of symbols giving exactly the bounds of the *payload*, i.e. just the build ID itself (and presenting its variable size in a simple manner).

Fri, Mar 20, 11:23 AM · Restricted Project

Thu, Mar 19

mcgrathr accepted D76462: [XRay] Record the XRay data size as a property of the VMO.

lgtm

Thu, Mar 19, 6:39 PM · Restricted Project
mcgrathr created D76437: [sanitizer_coverage][Fuchsia] Set ZX_PROP_VMO_CONTENT_SIZE.
Thu, Mar 19, 10:52 AM · Restricted Project
mcgrathr accepted D76402: [profile] Record the profile size as a property of the VMO.

A comment wouldn't hurt.

Thu, Mar 19, 10:52 AM · Restricted Project

Tue, Mar 10

mcgrathr added a comment to D75724: [ELF] Simplify sh_addr computation and warn if sh_addr is not a multiple of sh_addralign.

I wholeheartedly endorse documenting the policy on linker script semantics. I think the described deviation from GNU semantics for cases where explicit output section alignment doesn't jibe with input section alignment is generally fine. That is, I think this corner case is best avoided and I'm not too concerned with exactly how it goes when it happens. The warning for the case of an explicit address that is misaligned wrt input section sh_addralign is the most important thing for avoiding accidents. For the explicit alignment being less than than input requirements, the lld behavior of using the maximum of the two seems sensible to me (essentially the explicit alignment in the linker script is just another of the requirements like all the inputs' sh_addralign values and you align to the maximum of the whole set, which is perfectly intuitive). If anything, I think the GNU linkers should warn about violating input sh_addralign requirements if they're going to have that behavior.

Tue, Mar 10, 11:25 AM · Restricted Project

Feb 21 2020

mcgrathr added a comment to D75002: [AArch64] Predefine __AARCH64_CMODEL_*__ as GCC does.

Thanks! Can you land it for me?

Feb 21 2020, 8:06 PM · Restricted Project
mcgrathr added a comment to D75003: [X86] Fix __code_model_*__ predefine names.

Thanks! Can you land it for me?

Feb 21 2020, 8:05 PM · Restricted Project
mcgrathr created D75003: [X86] Fix __code_model_*__ predefine names.
Feb 21 2020, 4:57 PM · Restricted Project
mcgrathr added a reviewer for D75002: [AArch64] Predefine __AARCH64_CMODEL_*__ as GCC does: tamur.
Feb 21 2020, 4:57 PM · Restricted Project
mcgrathr updated the diff for D75002: [AArch64] Predefine __AARCH64_CMODEL_*__ as GCC does.

update log

Feb 21 2020, 4:39 PM · Restricted Project
mcgrathr created D75002: [AArch64] Predefine __AARCH64_CMODEL_*__ as GCC does.
Feb 21 2020, 4:39 PM · Restricted Project
mcgrathr updated the summary of D75002: [AArch64] Predefine __AARCH64_CMODEL_*__ as GCC does.
Feb 21 2020, 4:39 PM · Restricted Project

Jan 30 2020

mcgrathr updated the diff for D73734: [Fuchsia] Never link in implicit "system dependencies" of sanitizer runtimes.

style nit

Jan 30 2020, 1:15 PM · Restricted Project
mcgrathr updated the diff for D73734: [Fuchsia] Never link in implicit "system dependencies" of sanitizer runtimes.

builds now.

Jan 30 2020, 1:06 PM · Restricted Project
mcgrathr created D73734: [Fuchsia] Never link in implicit "system dependencies" of sanitizer runtimes.
Jan 30 2020, 12:01 PM · Restricted Project

Jan 28 2020

mcgrathr updated the diff for D72887: [lsan] Support LeakSanitizer runtime on Fuchsia.

Fixed patch rebasing snafu that dropped LsanOnDeadlySignal code from lsan_posix.cpp.

Jan 28 2020, 12:43 AM · Restricted Project, Restricted Project
mcgrathr reopened D72887: [lsan] Support LeakSanitizer runtime on Fuchsia.

Reverted after landing due to patch rebasing snafu that dropped the LsanOnDeadlySignal function.

Jan 28 2020, 12:43 AM · Restricted Project, Restricted Project

Jan 27 2020

mcgrathr accepted D73529: [Instrumentation] Set hidden visibility for the bias variable.

There should be test coverage that verifies the visibility gets set, but lgtm with that.

Jan 27 2020, 11:47 PM · Restricted Project
mcgrathr updated the diff for D72887: [lsan] Support LeakSanitizer runtime on Fuchsia.

Moved ReportIfNotSuspended out of #if.

Jan 27 2020, 1:38 PM · Restricted Project, Restricted Project
mcgrathr added inline comments to D72887: [lsan] Support LeakSanitizer runtime on Fuchsia.
Jan 27 2020, 1:38 PM · Restricted Project, Restricted Project

Jan 25 2020

mcgrathr created D73409: [Fuchsia] Remove aarch64-fuchsia target-specific -mcmodel=kernel.
Jan 25 2020, 1:50 AM · Restricted Project

Jan 24 2020

mcgrathr added a child revision for D72887: [lsan] Support LeakSanitizer runtime on Fuchsia: D73397: [Clang] Enable -fsanitize=leak on Fuchsia targets.
Jan 24 2020, 10:43 PM · Restricted Project, Restricted Project
mcgrathr added a parent revision for D73397: [Clang] Enable -fsanitize=leak on Fuchsia targets: D72887: [lsan] Support LeakSanitizer runtime on Fuchsia.
Jan 24 2020, 10:43 PM · Restricted Project
mcgrathr updated the diff for D73397: [Clang] Enable -fsanitize=leak on Fuchsia targets.

Fixed Android SafeStack case, now passing check-clang.

Jan 24 2020, 6:15 PM · Restricted Project
mcgrathr created D73397: [Clang] Enable -fsanitize=leak on Fuchsia targets.
Jan 24 2020, 5:57 PM · Restricted Project
mcgrathr added a comment to D73309: [lsan] Factor pthread-specific assumptions out of thread tracking code.

I've made the style changes you asked for and clang-format'd the files I touched. But note that all of these changes are to existing code that I just moved and left exactly as it had been and not anything I'd added. I erred on the side of leaving things alone rather than cleaning them up. I've now done the opposite as you asked, though it's not entirely consistent with the style and formatting of the existing code in the same directory. I'm happy to use whatever style choices you prefer, but it's easiest to do that when the codebase is consistent with those choices already.

Jan 24 2020, 4:27 PM · Restricted Project, Restricted Project
mcgrathr updated the diff for D73309: [lsan] Factor pthread-specific assumptions out of thread tracking code.

Style changes to copied code, clang-format.

Jan 24 2020, 4:18 PM · Restricted Project, Restricted Project
mcgrathr updated the diff for D72988: [lsan] Expose Frontier object to OS-specific LockStuffAndStopTheWorld callback.

Rebased

Jan 24 2020, 4:18 PM · Restricted Project, Restricted Project
mcgrathr updated the diff for D72886: [sanitizer_common] Implement MemoryMappingLayout for Fuchsia.

Rebased

Jan 24 2020, 4:09 PM · Restricted Project, Restricted Project

Jan 23 2020

mcgrathr added a comment to D72887: [lsan] Support LeakSanitizer runtime on Fuchsia.

I think I've done everything Vitaly's last review asked for. Thanks.

Jan 23 2020, 5:00 PM · Restricted Project, Restricted Project
mcgrathr added a parent revision for D72887: [lsan] Support LeakSanitizer runtime on Fuchsia: D73309: [lsan] Factor pthread-specific assumptions out of thread tracking code.
Jan 23 2020, 5:00 PM · Restricted Project, Restricted Project
mcgrathr added a child revision for D73309: [lsan] Factor pthread-specific assumptions out of thread tracking code: D72887: [lsan] Support LeakSanitizer runtime on Fuchsia.
Jan 23 2020, 5:00 PM · Restricted Project, Restricted Project
mcgrathr updated the diff for D72887: [lsan] Support LeakSanitizer runtime on Fuchsia.

Split out ThreadContext refactoring into a separate patch.
Updated related changes following review comments.

Jan 23 2020, 4:52 PM · Restricted Project, Restricted Project
mcgrathr created D73309: [lsan] Factor pthread-specific assumptions out of thread tracking code.
Jan 23 2020, 4:49 PM · Restricted Project, Restricted Project
mcgrathr updated the diff for D72988: [lsan] Expose Frontier object to OS-specific LockStuffAndStopTheWorld callback.

Rebased.

Jan 23 2020, 4:49 PM · Restricted Project, Restricted Project
mcgrathr updated the diff for D72886: [sanitizer_common] Implement MemoryMappingLayout for Fuchsia.

Rebased

Jan 23 2020, 4:40 PM · Restricted Project, Restricted Project

Jan 18 2020

mcgrathr added a parent revision for D72887: [lsan] Support LeakSanitizer runtime on Fuchsia: D72988: [lsan] Expose Frontier object to OS-specific LockStuffAndStopTheWorld callback.
Jan 18 2020, 3:23 PM · Restricted Project, Restricted Project
mcgrathr added a child revision for D72988: [lsan] Expose Frontier object to OS-specific LockStuffAndStopTheWorld callback: D72887: [lsan] Support LeakSanitizer runtime on Fuchsia.
Jan 18 2020, 3:23 PM · Restricted Project, Restricted Project
mcgrathr added a comment to D72887: [lsan] Support LeakSanitizer runtime on Fuchsia.

I've split part of the patch out and done a substantial refactoring of the standalone lsan thread stuff following Vitaly's review.

Jan 18 2020, 3:23 PM · Restricted Project, Restricted Project
mcgrathr updated the diff for D72887: [lsan] Support LeakSanitizer runtime on Fuchsia.

Generic refactoring patch split out.
Standalone LSan port refactored following review comments.

Jan 18 2020, 3:21 PM · Restricted Project, Restricted Project
mcgrathr created D72988: [lsan] Expose Frontier object to OS-specific LockStuffAndStopTheWorld callback.
Jan 18 2020, 3:21 PM · Restricted Project, Restricted Project
mcgrathr updated the diff for D72886: [sanitizer_common] Implement MemoryMappingLayout for Fuchsia.

Rebased.

Jan 18 2020, 2:16 PM · Restricted Project, Restricted Project
mcgrathr added a child revision for D72886: [sanitizer_common] Implement MemoryMappingLayout for Fuchsia: D72887: [lsan] Support LeakSanitizer runtime on Fuchsia.
Jan 18 2020, 10:07 AM · Restricted Project, Restricted Project
mcgrathr added a parent revision for D72887: [lsan] Support LeakSanitizer runtime on Fuchsia: D72886: [sanitizer_common] Implement MemoryMappingLayout for Fuchsia.
Jan 18 2020, 10:07 AM · Restricted Project, Restricted Project
mcgrathr added a reviewer for D72886: [sanitizer_common] Implement MemoryMappingLayout for Fuchsia: vitalybuka.
Jan 18 2020, 10:04 AM · Restricted Project, Restricted Project
mcgrathr updated the diff for D72886: [sanitizer_common] Implement MemoryMappingLayout for Fuchsia.

Rebased, added a comment.

Jan 18 2020, 10:04 AM · Restricted Project, Restricted Project

Jan 16 2020

mcgrathr created D72887: [lsan] Support LeakSanitizer runtime on Fuchsia.
Jan 16 2020, 3:34 PM · Restricted Project, Restricted Project
mcgrathr created D72886: [sanitizer_common] Implement MemoryMappingLayout for Fuchsia.
Jan 16 2020, 3:24 PM · Restricted Project, Restricted Project

Dec 17 2019

mcgrathr accepted D71641: [unwind] Don't link libpthread and libdl on Fuchsia.

lgtm

Dec 17 2019, 5:29 PM · Restricted Project

Oct 16 2019

mcgrathr updated the diff for D66712: [Driver] Enable ShadowCallStack, not SafeStack, by default on AArch64 Fuchsia.

rebased

Oct 16 2019, 11:15 AM · Restricted Project
mcgrathr added a comment to D66712: [Driver] Enable ShadowCallStack, not SafeStack, by default on AArch64 Fuchsia.

It's time to land this now. Can one of you commit it for me?

Oct 16 2019, 11:15 AM · Restricted Project

Aug 24 2019

mcgrathr added reviewers for D66712: [Driver] Enable ShadowCallStack, not SafeStack, by default on AArch64 Fuchsia: phosek, leonardchan, jakehehrlich.

This should land only after we've done our first stages of downstream roll-out and burn-in testing. But setting it up now.

Aug 24 2019, 11:14 PM · Restricted Project
mcgrathr created D66712: [Driver] Enable ShadowCallStack, not SafeStack, by default on AArch64 Fuchsia.
Aug 24 2019, 11:12 PM · Restricted Project

Aug 15 2019

mcgrathr accepted D66323: [Fuchsia] Create the VMO during initialization, not during exit.

lgtm

Aug 15 2019, 4:54 PM · Restricted Project, Restricted Project

Aug 14 2019

mcgrathr accepted D66233: Always print DSO map on Fuchsia libFuzzer launch.

lgtm

Aug 14 2019, 8:46 PM · Restricted Project, Restricted Project

Aug 4 2019

mcgrathr created D65715: [Driver] Don't disable -fsanitizer-coverage for safe-stack or shadow-call-stack.
Aug 4 2019, 1:57 AM · Restricted Project, Restricted Project

Jul 17 2019

mcgrathr added inline comments to D64603: [Target] Use IEEE quad format for long double on Fuchsia x86_64.
Jul 17 2019, 12:50 PM · Restricted Project

Jul 11 2019

mcgrathr accepted D64605: [CMake][Fuchsia] Use RelWithDebInfo to build runtimes.

Lgtm

Jul 11 2019, 4:31 PM · Restricted Project, Restricted Project

Jul 3 2019

mcgrathr accepted D64166: [ASan] Use __sanitizer_fill_shadow for FastPoisonShadow on Fuchsia.

AFAICT the inlining is the whole point of FastPoisonShadow so this LGTM as is.

Jul 3 2019, 5:34 PM · Restricted Project, Restricted Project
mcgrathr accepted D64140: [CMake][Fuchsia] Define asan+noexcept multilib.

lgtm

Jul 3 2019, 10:20 AM · Restricted Project, Restricted Project

Jun 29 2019

mcgrathr added a reviewer for D63695: [sancov] Ignore PC samples with value 0: kcc.
Jun 29 2019, 11:36 AM · Restricted Project
mcgrathr added a comment to D63695: [sancov] Ignore PC samples with value 0.

PTAL

Jun 29 2019, 11:36 AM · Restricted Project

Jun 24 2019

mcgrathr updated the diff for D63695: [sancov] Ignore PC samples with value 0.

Move logic out of RawCoverage constructor.

Jun 24 2019, 12:24 PM · Restricted Project

Jun 23 2019

mcgrathr added a comment to D63695: [sancov] Ignore PC samples with value 0.

https://fuchsia-review.googlesource.com/c/fuchsia/+/295508 has the runtime implementation that motivated this.

Jun 23 2019, 4:03 PM · Restricted Project
mcgrathr created D63695: [sancov] Ignore PC samples with value 0.
Jun 23 2019, 3:58 PM · Restricted Project

May 31 2019

mcgrathr accepted D62770: [libcxx] Use libtool when merging archives on Apple platforms.

lgtm

May 31 2019, 11:35 PM · Restricted Project
mcgrathr accepted D62769: [CMake] Use libtool for runtimes when building for Apple platform.

lgtm

May 31 2019, 11:34 PM · Restricted Project

May 30 2019

mcgrathr accepted D62712: [CMake][Fuchsia] Use libc++ ABI v2 on Darwin as well.

lgtm

May 30 2019, 6:12 PM · Restricted Project, Restricted Project

May 28 2019

mcgrathr accepted D62558: [Driver] Search the toolchain dir with -print-file-name.

lgtm

May 28 2019, 4:51 PM · Restricted Project

May 27 2019

mcgrathr accepted D62469: [Driver] Change layout of per-target runtimes to resemble multiarch.

lgtm

May 27 2019, 12:30 PM · Restricted Project, Restricted Project, Restricted Project

May 24 2019

mcgrathr accepted D62442: [Driver] Update handling of c++ and runtime directories.

lgtm contingent on verifying intended behavior changes and adding comments. The factoring suggestion for the triple,triple searching is preferred but at your discretion, though I'd really like to see at least comments.

May 24 2019, 11:03 PM · Restricted Project

May 21 2019

mcgrathr accepted D62226: [libFuzzer] Ignore synthetic exceptions on Fuchsia.

lgtm with one nit: either change to an assert or improve the comment to clarify what other cases are expected

May 21 2019, 6:36 PM · Restricted Project, Restricted Project

May 14 2019

mcgrathr accepted D61919: [builtins] Deduplicate __eqsf2 and __gtsf2.

Lgtm

May 14 2019, 2:50 PM · Restricted Project, Restricted Project

May 6 2019

mcgrathr added a comment to D61510: [SanitizerCoverage] Use different module ctor names for trace-pc-guard and inline-8bit-counters.

Previously the same local symbol name was being used for both things in an uncoordinated fashion. The logic in places like ValueSymbolTable::createValueName leads to the second one getting renamed with some ".digits" suffix to make them unique.
Then the code that emits the references between the init_array and the actual function and sets the COMDAT group name assumed it could use the original name throughout, but in some places this was replaced with the suffixed name and in some places it was not, leading to the incorrect references.

May 6 2019, 11:58 AM · Restricted Project
mcgrathr added a comment to D61477: [ELF] -z combreloc: sort dynamic relocations by (symbol_index,r_offset).

Sorting R_*_RELATIVE relocs first and setting REL(A)COUNT is a format requirement, period. It's not a debatable question of optimization.

May 6 2019, 11:51 AM · Restricted Project

May 5 2019

mcgrathr created D61572: [libcxxabi] Don't use -fvisibility-global-new-delete-hidden when not defining them.
May 5 2019, 11:56 AM · Restricted Project, Restricted Project
mcgrathr created D61571: [libcxx] Don't use -fvisibility-global-new-delete-hidden when not defining them.
May 5 2019, 11:55 AM · Restricted Project, Restricted Project

May 4 2019

mcgrathr added reviewers for D61510: [SanitizerCoverage] Use different module ctor names for trace-pc-guard and inline-8bit-counters: jakehehrlich, phosek.

This works for my case that led to me to file https://bugs.llvm.org/show_bug.cgi?id=41693 as a linker issue.

May 4 2019, 9:27 PM · Restricted Project

May 3 2019

mcgrathr added a comment to D61477: [ELF] -z combreloc: sort dynamic relocations by (symbol_index,r_offset).

The sorting behavior is entirely an optimization for locality at dynamic reloc time. Both locality of symtab indices and locality of reloc offsets are useful to that goal.

May 3 2019, 10:59 AM · Restricted Project

Apr 30 2019

mcgrathr accepted D61363: [compiler-rt] Pass sysroot and disable pedantic for crtbegin.o/crtend.o.

Lgtm

Apr 30 2019, 8:27 PM · Restricted Project, Restricted Project

Apr 24 2019

mcgrathr added inline comments to D61040: [Fuchsia] Support multilib for -fsanitize=address and -fno-exceptions.
Apr 24 2019, 4:44 PM · Restricted Project
mcgrathr accepted D60990: [Driver] Support priority for multilibs.

lgtm

Apr 24 2019, 4:43 PM · Restricted Project
mcgrathr accepted D61040: [Fuchsia] Support multilib for -fsanitize=address and -fno-exceptions.

lgtm

Apr 24 2019, 4:42 PM · Restricted Project

Apr 3 2019

mcgrathr accepted D60245: [libunwind] Export the weak alias in Mach-O.

Lgtm

Apr 3 2019, 8:26 PM · Restricted Project
mcgrathr accepted D60235: [CMake] Disable libc++ and libc++abi new/delete definitions when built with ASan.

IMHO the library code should use #if !__has_feature(...) to avoid the definitions entirely when built with a sanitizer whose runtime provides them.
But this is a fine way to achieve that while we wait for those libraries to be fixed for sanitized builds.

Apr 3 2019, 3:47 PM · Restricted Project

Apr 2 2019

mcgrathr accepted D60176: [libc++][libc++abi] Don't provide new/delete when built with ASan, HWASan or TSan.

lgtm

Apr 2 2019, 8:44 PM · Restricted Project

Mar 28 2019

mcgrathr added inline comments to D59921: [libunwind] Export the unw_* symbols as weak symbols.
Mar 28 2019, 10:25 AM · Restricted Project

Feb 16 2019

mcgrathr accepted D58325: [Driver][Fuchsia] Support -nolibc flag.

This is only on GCC trunk (i.e. 9), not in 8.2 or even the current gcc-8 branch. So clarify the log entry. We don't know if 8.x,x>2 will add it or only gcc 9.

Feb 16 2019, 4:52 PM · Restricted Project, Restricted Project
mcgrathr added inline comments to D58184: [scudo][standalone] Introduce platform specific code & mutexes.
Feb 16 2019, 1:16 AM · Restricted Project, Restricted Project

Feb 14 2019

mcgrathr added inline comments to D58184: [scudo][standalone] Introduce platform specific code & mutexes.
Feb 14 2019, 10:12 AM · Restricted Project, Restricted Project

Feb 13 2019

mcgrathr added inline comments to D58184: [scudo][standalone] Introduce platform specific code & mutexes.
Feb 13 2019, 1:25 PM · Restricted Project, Restricted Project
mcgrathr added a comment to D58184: [scudo][standalone] Introduce platform specific code & mutexes.

I only really looked at the Fuchsia code.

Feb 13 2019, 11:57 AM · Restricted Project, Restricted Project

Feb 9 2019

mcgrathr accepted D58010: [CodeGen] Set construction vtable visibility after creating initializer.

lgtm with a comment (and perhaps an assertion).

Feb 9 2019, 7:55 PM · Restricted Project, Restricted Project