Page MenuHomePhabricator
Feed Advanced Search

Yesterday

arsenm added a comment to D61607: Introduce an option to stripPointerCasts to force the same bit pattern.

Yes I know it can change the bit pattern. And if it is only about the bit pattern, the name is fine. However, it seems to me that the only difference between stripPointerCastsSameBitPattern and stripPointerCasts is the AS, which may or may not be relevant to the bit pattern. This is confusing: it isn't clear to me from the name stripPointerCastsSameBitPattern whether it may strip any addrspacecast that has the same bit pattern.

Sat, May 18, 9:37 PM · Restricted Project
arsenm added inline comments to D62100: [DAGCombine][X86][AMDGPU][AArch64] (srl (shl x, c1), c2) with c1 != c2 handling.
Sat, May 18, 3:29 PM · Restricted Project
arsenm added inline comments to D62100: [DAGCombine][X86][AMDGPU][AArch64] (srl (shl x, c1), c2) with c1 != c2 handling.
Sat, May 18, 3:29 PM · Restricted Project
arsenm added a comment to D61607: Introduce an option to stripPointerCasts to force the same bit pattern.

To me (someone from outside LLVM), the "keep bit pattern" argument looks confusing. Pointer casts do not necessarily change the bit pattern? In fact, it seems to me that most pointer casts preserve the bit pattern but change the meaning of the pointer (example: address space 1 on AVR which points into flash instead of RAM - no bits are changed with an addrspacecast).

Sat, May 18, 8:42 AM · Restricted Project
arsenm created D62101: NewGVN: Handle addrspacecast.
Sat, May 18, 8:24 AM
arsenm committed rGb04f3258dd6a: GVN: Handle addrspacecast (authored by arsenm).
GVN: Handle addrspacecast
Sat, May 18, 7:34 AM
arsenm committed rL361103: GVN: Handle addrspacecast.
GVN: Handle addrspacecast
Sat, May 18, 7:33 AM
arsenm accepted D62099: UpdateTestChecks: fix AMDGPU handling.
Sat, May 18, 5:16 AM · Restricted Project

Fri, May 17

arsenm committed rG2f29220d6d61: AMDGPU/GlobalISel: Implement s64->s64 [SU]ITOFP (authored by arsenm).
AMDGPU/GlobalISel: Implement s64->s64 [SU]ITOFP
Fri, May 17, 4:09 PM
arsenm committed rG02b5ca8cd112: GlobalISel: Implement lower for S64->S32 [SU]ITOFP (authored by arsenm).
GlobalISel: Implement lower for S64->S32 [SU]ITOFP
Fri, May 17, 4:09 PM
arsenm committed rL361081: GlobalISel: Implement lower for S64->S32 [SU]ITOFP.
GlobalISel: Implement lower for S64->S32 [SU]ITOFP
Fri, May 17, 4:08 PM
arsenm committed rL361082: AMDGPU/GlobalISel: Implement s64->s64 [SU]ITOFP.
AMDGPU/GlobalISel: Implement s64->s64 [SU]ITOFP
Fri, May 17, 4:08 PM
arsenm closed D62031: AMDGPU/GlobalISel: Implement s64->s64 [SU]ITOFP.

r361082

Fri, May 17, 4:08 PM
arsenm closed D62023: GlobalISel: Implement lower for S64->S32 [SU]ITOFP.

r361081

Fri, May 17, 4:08 PM
arsenm created D62080: bugpoint: Add option to disable attribute removal.
Fri, May 17, 2:05 PM
arsenm created D62076: AMDGPU/GlobalISel: Legality for integer min/max.
Fri, May 17, 12:58 PM
arsenm committed rGf3cedf4823ce: GlobalISel: Define integer min/max instructions (authored by arsenm).
GlobalISel: Define integer min/max instructions
Fri, May 17, 11:34 AM
arsenm committed rL361061: GlobalISel: Define integer min/max instructions.
GlobalISel: Define integer min/max instructions
Fri, May 17, 11:34 AM
arsenm closed D62042: GlobalISel: Define integer min/max instructions.

r361061

Fri, May 17, 11:34 AM
arsenm committed rG1a02d30c8730: AMDGPU: Fix unused variable warnings in release builds (authored by arsenm).
AMDGPU: Fix unused variable warnings in release builds
Fri, May 17, 5:57 AM
arsenm committed rL361030: AMDGPU: Fix unused variable warnings in release builds.
AMDGPU: Fix unused variable warnings in release builds
Fri, May 17, 5:57 AM
arsenm updated the diff for D62023: GlobalISel: Implement lower for S64->S32 [SU]ITOFP.

Move bulk of implementation to separate function

Fri, May 17, 5:48 AM
arsenm committed rGa510b570c281: AMDGPU/GlobalISel: Legalize G_FCEIL (authored by arsenm).
AMDGPU/GlobalISel: Legalize G_FCEIL
Fri, May 17, 5:19 AM
arsenm committed rG6aebcd549988: AMDGPU/GlobalISel: Legalize G_INTRINSIC_TRUNC (authored by arsenm).
AMDGPU/GlobalISel: Legalize G_INTRINSIC_TRUNC
Fri, May 17, 5:19 AM
arsenm committed rG6aafc5e19d30: AMDGPU/GlobalISel: Legalize G_FRINT (authored by arsenm).
AMDGPU/GlobalISel: Legalize G_FRINT
Fri, May 17, 5:19 AM
arsenm committed rG1448f5689e29: AMDGPU/GlobalISel: Legalize G_FCOPYSIGN (authored by arsenm).
AMDGPU/GlobalISel: Legalize G_FCOPYSIGN
Fri, May 17, 5:19 AM
arsenm committed rL361028: AMDGPU/GlobalISel: Legalize G_FCEIL.
AMDGPU/GlobalISel: Legalize G_FCEIL
Fri, May 17, 5:18 AM
arsenm committed rL361027: AMDGPU/GlobalISel: Legalize G_INTRINSIC_TRUNC.
AMDGPU/GlobalISel: Legalize G_INTRINSIC_TRUNC
Fri, May 17, 5:18 AM
arsenm committed rL361026: AMDGPU/GlobalISel: Legalize G_FRINT.
AMDGPU/GlobalISel: Legalize G_FRINT
Fri, May 17, 5:18 AM
arsenm closed D61984: AMDGPU/GlobalISel: Legalize G_FCEIL.

r361028

Fri, May 17, 5:18 AM
arsenm committed rL361025: AMDGPU/GlobalISel: Legalize G_FCOPYSIGN.
AMDGPU/GlobalISel: Legalize G_FCOPYSIGN
Fri, May 17, 5:18 AM
arsenm closed D61982: AMDGPU/GlobalISel: Legalize G_FRINT.

r361026

Fri, May 17, 5:18 AM
arsenm closed D61983: AMDGPU/GlobalISel: Legalize G_INTRINSIC_TRUNC.

r361027

Fri, May 17, 5:18 AM
arsenm committed rG568f193847c9: AMDGPU/GlobalISel: RegBankSelect for llvm.amdgcn.s.buffer.load (authored by arsenm).
AMDGPU/GlobalISel: RegBankSelect for llvm.amdgcn.s.buffer.load
Fri, May 17, 5:03 AM
arsenm committed rGa3b5a386fa7b: AMDGPU/GlobalISel: Use subreg index instead of extra unmerge (authored by arsenm).
AMDGPU/GlobalISel: Use subreg index instead of extra unmerge
Fri, May 17, 5:03 AM
arsenm committed rGb3dc73634c49: AMDGPU/GlobalISel: Use waterfall loop for buffer_load (authored by arsenm).
AMDGPU/GlobalISel: Use waterfall loop for buffer_load
Fri, May 17, 5:03 AM
arsenm committed rL361023: AMDGPU/GlobalISel: RegBankSelect for llvm.amdgcn.s.buffer.load.
AMDGPU/GlobalISel: RegBankSelect for llvm.amdgcn.s.buffer.load
Fri, May 17, 5:02 AM
arsenm committed rL361022: AMDGPU/GlobalISel: Use subreg index instead of extra unmerge.
AMDGPU/GlobalISel: Use subreg index instead of extra unmerge
Fri, May 17, 5:02 AM
arsenm committed rL361021: AMDGPU/GlobalISel: Use waterfall loop for buffer_load.
AMDGPU/GlobalISel: Use waterfall loop for buffer_load
Fri, May 17, 5:02 AM
arsenm closed D61987: AMDGPU/GlobalISel: RegBankSelect for llvm.amdgcn.s.buffer.load.

r361023

Fri, May 17, 5:02 AM
arsenm closed D61986: AMDGPU/GlobalISel: Use subreg index instead of extra unmerge.

r361022

Fri, May 17, 5:02 AM
arsenm closed D61985: AMDGPU/GlobalISel: Use waterfall loop for buffer_load.

r361021

Fri, May 17, 5:02 AM
arsenm committed rG1400a35f7167: GlobalISel: Fix missing version of customFor (authored by arsenm).
GlobalISel: Fix missing version of customFor
Fri, May 17, 4:52 AM
arsenm committed rGe1a2a28d6bcd: GlobalISel: Add fp<->int casts to MachineIRBuilder (authored by arsenm).
GlobalISel: Add fp<->int casts to MachineIRBuilder
Fri, May 17, 4:51 AM
arsenm committed rG7f8ea15ffa19: GlobalISel: Add MIRBuilder wrappers for bitcount instructions (authored by arsenm).
GlobalISel: Add MIRBuilder wrappers for bitcount instructions
Fri, May 17, 4:51 AM
arsenm committed rL361020: GlobalISel: Fix missing version of customFor.
GlobalISel: Fix missing version of customFor
Fri, May 17, 4:51 AM
arsenm committed rL361019: GlobalISel: Add fp<->int casts to MachineIRBuilder.
GlobalISel: Add fp<->int casts to MachineIRBuilder
Fri, May 17, 4:51 AM
arsenm committed rL361018: GlobalISel: Add MIRBuilder wrappers for bitcount instructions.
GlobalISel: Add MIRBuilder wrappers for bitcount instructions
Fri, May 17, 4:51 AM
arsenm closed D62038: GlobalISel: Add fp<->int casts to MachineIRBuilder.

r361019

Fri, May 17, 4:51 AM
arsenm closed D62037: GlobalISel: Add MIRBUilder wrappers for bitcount instructions.

r361018

Fri, May 17, 4:51 AM
arsenm added inline comments to D62058: [AMDGPU] gfx1010 Avoid SMEM WAR hazard for some s_waitcnt values.
Fri, May 17, 4:28 AM · Restricted Project

Thu, May 16

arsenm created D62042: GlobalISel: Define integer min/max instructions.
Thu, May 16, 3:49 PM
arsenm created D62038: GlobalISel: Add fp<->int casts to MachineIRBuilder.
Thu, May 16, 3:25 PM
arsenm created D62037: GlobalISel: Add MIRBUilder wrappers for bitcount instructions.
Thu, May 16, 3:06 PM
arsenm created D62031: AMDGPU/GlobalISel: Implement s64->s64 [SU]ITOFP.
Thu, May 16, 2:07 PM
arsenm created D62023: GlobalISel: Implement lower for S64->S32 [SU]ITOFP.
Thu, May 16, 11:49 AM
arsenm accepted D61009: [AMDGPU][MC] Corrected parsing of NAME:VALUE modifiers.

LGTM

Thu, May 16, 10:38 AM · Restricted Project
arsenm added inline comments to D59666: AMDGPU: HIP compiler option -finstrument-functions flag.
Thu, May 16, 10:16 AM
arsenm added a comment to D59666: AMDGPU: HIP compiler option -finstrument-functions flag.

Added a test outside entry block; doesn't make any difference in the output.
By a test with no ret, do you mean something that returns void?

Thu, May 16, 10:14 AM
arsenm added inline comments to D62013: [InstSimplify] Add unary fneg to `fsub 0.0, (fneg X) ==> X` transform.
Thu, May 16, 10:14 AM · Restricted Project
arsenm committed rG99e6f4d11af3: AMDGPU: Introduce TokenFactor for ABI register copies in call sequence (authored by arsenm).
AMDGPU: Introduce TokenFactor for ABI register copies in call sequence
Thu, May 16, 8:09 AM
arsenm committed rL360906: AMDGPU: Introduce TokenFactor for ABI register copies in call sequence.
AMDGPU: Introduce TokenFactor for ABI register copies in call sequence
Thu, May 16, 8:08 AM
arsenm closed D61988: AMDGPU: Introduce TokenFactor for ABI register copies in call sequence.

r360906

Thu, May 16, 8:08 AM
arsenm committed rGdf24c92c0f03: AMDGPU: Assume xnack is enabled by default (authored by arsenm).
AMDGPU: Assume xnack is enabled by default
Thu, May 16, 7:49 AM
arsenm committed rL360903: AMDGPU: Assume xnack is enabled by default.
AMDGPU: Assume xnack is enabled by default
Thu, May 16, 7:48 AM
arsenm closed D61901: AMDGPU: Assume xnack is enabled by default.

r360903

Thu, May 16, 7:48 AM
arsenm committed rG2120748f770d: GlobalISel: Add buildFMA to MachineIRBuilder (authored by arsenm).
GlobalISel: Add buildFMA to MachineIRBuilder
Thu, May 16, 6:03 AM
arsenm committed rL360888: GlobalISel: Add buildFMA to MachineIRBuilder.
GlobalISel: Add buildFMA to MachineIRBuilder
Thu, May 16, 6:02 AM
arsenm committed rG828b685ebe3f: RegAllocFast: Improve hinting heuristic (authored by arsenm).
RegAllocFast: Improve hinting heuristic
Thu, May 16, 5:49 AM
arsenm closed D54367: RegAllocFast: Improve hinting heuristic.

r360887

Thu, May 16, 5:48 AM · Restricted Project
arsenm committed rL360887: RegAllocFast: Improve hinting heuristic.
RegAllocFast: Improve hinting heuristic
Thu, May 16, 5:48 AM
arsenm committed rGd72f25e5b005: GlobalISel: Add buildXor/buildNot (authored by arsenm).
GlobalISel: Add buildXor/buildNot
Thu, May 16, 5:22 AM
arsenm committed rG27ac8408f6d1: GlobalISel: Add DstOp version of buildIntrinsic (authored by arsenm).
GlobalISel: Add DstOp version of buildIntrinsic
Thu, May 16, 5:22 AM
arsenm committed rL360880: GlobalISel: Add buildXor/buildNot.
GlobalISel: Add buildXor/buildNot
Thu, May 16, 5:22 AM
arsenm closed D61980: GlobalISel: Add DstOp version of buildIntrinsic.

r360879

Thu, May 16, 5:21 AM
arsenm closed D61981: GlobalISel: Add buildXor/buildNot.

r360880

Thu, May 16, 5:21 AM
arsenm committed rL360879: GlobalISel: Add DstOp version of buildIntrinsic.
GlobalISel: Add DstOp version of buildIntrinsic
Thu, May 16, 5:20 AM
arsenm committed rGa8f88c388f75: AMDGPU/GlobalISel: Correct regbank for 1-bit and/or/xor (authored by arsenm).
AMDGPU/GlobalISel: Correct regbank for 1-bit and/or/xor
Thu, May 16, 5:06 AM
arsenm committed rL360877: AMDGPU/GlobalISel: Correct regbank for 1-bit and/or/xor.
AMDGPU/GlobalISel: Correct regbank for 1-bit and/or/xor
Thu, May 16, 5:06 AM
arsenm added a comment to D61980: GlobalISel: Add DstOp version of buildIntrinsic.

The patch looks good. One comment - does it make sense to have two functions or unify the implementation - make the non DstOp version forward to DstOp version?

It would require creating another vector constructing DstOps, which seems worse

Fair enough. I'm not strongly opinionated here - either way is good for me.

Thu, May 16, 5:06 AM

Wed, May 15

arsenm committed rG11be78bc7abf: GlobalISel: Add buildFConstant for APFloat (authored by arsenm).
GlobalISel: Add buildFConstant for APFloat
Wed, May 15, 9:09 PM
arsenm committed rG940a9ff0f3bf: GlobalISel: Add some FP instructions to MachineIRBuilder (authored by arsenm).
GlobalISel: Add some FP instructions to MachineIRBuilder
Wed, May 15, 9:09 PM
arsenm committed rG012ecbbbbadf: GlobalISel: Fix indentation (authored by arsenm).
GlobalISel: Fix indentation
Wed, May 15, 9:09 PM
arsenm committed rG55146d31392e: GlobalISel: Add G_FCOPYSIGN (authored by arsenm).
GlobalISel: Add G_FCOPYSIGN
Wed, May 15, 9:08 PM
arsenm committed rG2006f936efd6: Fix missing const (authored by arsenm).
Fix missing const
Wed, May 15, 9:08 PM
arsenm committed rL360853: GlobalISel: Add buildFConstant for APFloat.
GlobalISel: Add buildFConstant for APFloat
Wed, May 15, 9:08 PM
arsenm committed rL360852: GlobalISel: Add some FP instructions to MachineIRBuilder.
GlobalISel: Add some FP instructions to MachineIRBuilder
Wed, May 15, 9:08 PM
arsenm committed rL360851: GlobalISel: Fix indentation.
GlobalISel: Fix indentation
Wed, May 15, 9:08 PM
arsenm committed rL360850: GlobalISel: Add G_FCOPYSIGN.
GlobalISel: Add G_FCOPYSIGN
Wed, May 15, 9:08 PM
arsenm committed rL360849: Fix missing const.
Fix missing const
Wed, May 15, 9:08 PM
arsenm closed D61979: GlobalISel: Add buildFConstant for APFloat.

r360853

Wed, May 15, 9:07 PM
arsenm closed D61977: GlobalISel: Add G_FCOPYSIGN.

r360850

Wed, May 15, 9:07 PM
arsenm closed D61978: GlobalISel: Add some FP instructions to MachineIRBuilder.

r360852

Wed, May 15, 9:07 PM
arsenm added a comment to D61980: GlobalISel: Add DstOp version of buildIntrinsic.

The patch looks good. One comment - does it make sense to have two functions or unify the implementation - make the non DstOp version forward to DstOp version?

Wed, May 15, 8:33 PM
arsenm created D61988: AMDGPU: Introduce TokenFactor for ABI register copies in call sequence.
Wed, May 15, 8:33 PM
arsenm created D61987: AMDGPU/GlobalISel: RegBankSelect for llvm.amdgcn.s.buffer.load.
Wed, May 15, 8:22 PM
arsenm added a parent revision for D61986: AMDGPU/GlobalISel: Use subreg index instead of extra unmerge: D61985: AMDGPU/GlobalISel: Use waterfall loop for buffer_load.
Wed, May 15, 8:22 PM
arsenm added a child revision for D61985: AMDGPU/GlobalISel: Use waterfall loop for buffer_load: D61986: AMDGPU/GlobalISel: Use subreg index instead of extra unmerge.
Wed, May 15, 8:22 PM
arsenm created D61986: AMDGPU/GlobalISel: Use subreg index instead of extra unmerge.
Wed, May 15, 8:22 PM
arsenm created D61985: AMDGPU/GlobalISel: Use waterfall loop for buffer_load.
Wed, May 15, 8:20 PM