Page MenuHomePhabricator
Feed Advanced Search

Yesterday

arsenm committed rG255d15767226: AMDGPU/GlobalISel: Remove illegal select tests (authored by arsenm).
AMDGPU/GlobalISel: Remove illegal select tests
Sun, Sep 15, 9:25 PM
arsenm committed rL371955: AMDGPU/GlobalISel: Remove illegal select tests.
AMDGPU/GlobalISel: Remove illegal select tests
Sun, Sep 15, 9:19 PM
arsenm added a child revision for D67601: TLI: Remove DAG argument from getRegisterByName: D67602: GlobalISel: Handle llvm.read_register.
Sun, Sep 15, 7:30 PM
arsenm added a parent revision for D67602: GlobalISel: Handle llvm.read_register: D67601: TLI: Remove DAG argument from getRegisterByName.
Sun, Sep 15, 7:30 PM
arsenm created D67602: GlobalISel: Handle llvm.read_register.
Sun, Sep 15, 7:30 PM
arsenm created D67601: TLI: Remove DAG argument from getRegisterByName.
Sun, Sep 15, 7:30 PM
arsenm committed rGbc8de8a8da70: AMDGPU/GlobalISel: Select SMRD loads for more types (authored by arsenm).
AMDGPU/GlobalISel: Select SMRD loads for more types
Sun, Sep 15, 5:54 PM
arsenm committed rL371954: AMDGPU/GlobalISel: Select SMRD loads for more types.
AMDGPU/GlobalISel: Select SMRD loads for more types
Sun, Sep 15, 5:52 PM
arsenm committed rG48b158acae65: AMDGPU/GlobalISel: RegBankSelect for kill (authored by arsenm).
AMDGPU/GlobalISel: RegBankSelect for kill
Sun, Sep 15, 5:48 PM
arsenm committed rL371953: AMDGPU/GlobalISel: RegBankSelect for kill.
AMDGPU/GlobalISel: RegBankSelect for kill
Sun, Sep 15, 5:48 PM
arsenm committed rG01c7f40de3e4: AMDGPU/GlobalISel: Legalize s1 source G_[SU]ITOFP (authored by arsenm).
AMDGPU/GlobalISel: Legalize s1 source G_[SU]ITOFP
Sun, Sep 15, 5:37 PM
arsenm committed rG60169ed61305: AMDGPU/GlobalISel: Set type on vgpr live in special arguments (authored by arsenm).
AMDGPU/GlobalISel: Set type on vgpr live in special arguments
Sun, Sep 15, 5:36 PM
arsenm committed rL371952: AMDGPU/GlobalISel: Legalize s1 source G_[SU]ITOFP.
AMDGPU/GlobalISel: Legalize s1 source G_[SU]ITOFP
Sun, Sep 15, 5:36 PM
arsenm committed rG9f52c1ea583f: AMDGPU/GlobalISel: Select S16->S32 fptoint (authored by arsenm).
AMDGPU/GlobalISel: Select S16->S32 fptoint
Sun, Sep 15, 5:36 PM
arsenm committed rL371951: AMDGPU/GlobalISel: Set type on vgpr live in special arguments.
AMDGPU/GlobalISel: Set type on vgpr live in special arguments
Sun, Sep 15, 5:31 PM
arsenm committed rL371950: AMDGPU/GlobalISel: Select S16->S32 fptoint.
AMDGPU/GlobalISel: Select S16->S32 fptoint
Sun, Sep 15, 5:31 PM
arsenm committed rG0a6123595f97: AMDGPU/GlobalISel: Select s32->s16 G_[US]ITOFP (authored by arsenm).
AMDGPU/GlobalISel: Select s32->s16 G_[US]ITOFP
Sun, Sep 15, 5:31 PM
arsenm committed rL371949: AMDGPU/GlobalISel: Select s32->s16 G_[US]ITOFP.
AMDGPU/GlobalISel: Select s32->s16 G_[US]ITOFP
Sun, Sep 15, 5:27 PM
arsenm committed rGf5d5cd205e7b: AMDGPU/GlobalISel: Fix VALU s16 fneg (authored by arsenm).
AMDGPU/GlobalISel: Fix VALU s16 fneg
Sun, Sep 15, 5:23 PM
arsenm committed rL371948: AMDGPU/GlobalISel: Fix VALU s16 fneg.
AMDGPU/GlobalISel: Fix VALU s16 fneg
Sun, Sep 15, 5:19 PM
arsenm created D67600: AMDGPU/GlobalISel: Allow scc/vcc alternative mappings for s1 constants.
Sun, Sep 15, 4:40 PM
arsenm created D67599: AMDGPU/GlobalISel: Select s1 src G_SITOFP/G_UITOFP.
Sun, Sep 15, 4:39 PM
arsenm created D67598: AMDGPU/GlobalISel: Select G_UADDO/G_USUBO.
Sun, Sep 15, 4:33 PM
arsenm created D67597: AMDGPU/GlobalISel: Avoid creating shift of 0 in arg lowering.
Sun, Sep 15, 4:30 PM
arsenm created D67596: AMDGPU/GlobalISel: Allow selection of scalar min/max.
Sun, Sep 15, 4:30 PM

Thu, Sep 12

arsenm committed rG3b7ffc6ae75a: AMDGPU/GlobalISel: Fix assert on multi-return side effect intrinsics (authored by arsenm).
AMDGPU/GlobalISel: Fix assert on multi-return side effect intrinsics
Thu, Sep 12, 9:14 PM
arsenm committed rL371812: AMDGPU/GlobalISel: Fix assert on multi-return side effect intrinsics.
AMDGPU/GlobalISel: Fix assert on multi-return side effect intrinsics
Thu, Sep 12, 9:14 PM
arsenm committed rGa4be3eff5c95: AMDGPU/GlobalISel: Legalize s32->s16 G_SITOFP/G_UITOFP (authored by arsenm).
AMDGPU/GlobalISel: Legalize s32->s16 G_SITOFP/G_UITOFP
Thu, Sep 12, 9:04 PM
arsenm committed rL371811: AMDGPU/GlobalISel: Legalize s32->s16 G_SITOFP/G_UITOFP.
AMDGPU/GlobalISel: Legalize s32->s16 G_SITOFP/G_UITOFP
Thu, Sep 12, 9:04 PM
arsenm committed rG67d9349dad3f: AMDGPU/GlobalISel: Fix RegBankSelect for amdgcn.else (authored by arsenm).
AMDGPU/GlobalISel: Fix RegBankSelect for amdgcn.else
Thu, Sep 12, 8:56 PM
arsenm committed rG638f80238117: AMDGPU/GlobalISel: Select 16-bit VALU bit ops (authored by arsenm).
AMDGPU/GlobalISel: Select 16-bit VALU bit ops
Thu, Sep 12, 8:55 PM
arsenm committed rL371808: AMDGPU/GlobalISel: Fix RegBankSelect for amdgcn.else.
AMDGPU/GlobalISel: Fix RegBankSelect for amdgcn.else
Thu, Sep 12, 8:55 PM
arsenm committed rL371807: AMDGPU/GlobalISel: Select 16-bit VALU bit ops.
AMDGPU/GlobalISel: Select 16-bit VALU bit ops
Thu, Sep 12, 8:55 PM
arsenm committed rGf457dd2bd437: AMDGPU/GlobalISel: Legalize G_FFLOOR (authored by arsenm).
AMDGPU/GlobalISel: Legalize G_FFLOOR
Thu, Sep 12, 6:51 PM
arsenm committed rL371803: AMDGPU/GlobalISel: Legalize G_FFLOOR.
AMDGPU/GlobalISel: Legalize G_FFLOOR
Thu, Sep 12, 6:46 PM
arsenm committed rG4d3391803462: AMDGPU/GlobalISel: Legalize G_FMAD (authored by arsenm).
AMDGPU/GlobalISel: Legalize G_FMAD
Thu, Sep 12, 5:47 PM
arsenm closed D67279: GlobalISel/AMDGPU: Legalize G_FMAD.

r371800

Thu, Sep 12, 5:43 PM
arsenm committed rL371800: AMDGPU/GlobalISel: Legalize G_FMAD.
AMDGPU/GlobalISel: Legalize G_FMAD
Thu, Sep 12, 5:43 PM
arsenm added a comment to rL371640: LiveIntervals: Split live intervals on multiple dead defs.

Hi @arsenm ,

We've seen internal Hexagon test failures revealed by this patch, and here is the PR: https://bugs.llvm.org/show_bug.cgi?id=43302. Are you ok with temporarily rolling back this patch while we are investigating the issue?

Thanks!

Thu, Sep 12, 5:42 PM
arsenm closed D67355: AMDGPU/GlobalISel: Select G_CTPOP.

r371798

Thu, Sep 12, 5:13 PM
arsenm closed D67333: DAG/GlobalISel: Correct type profile of bitcount ops.

r371797

Thu, Sep 12, 5:13 PM
arsenm committed rG4a73c6eadae0: AMDGPU/GlobalISel: Select G_CTPOP (authored by arsenm).
AMDGPU/GlobalISel: Select G_CTPOP
Thu, Sep 12, 5:11 PM
arsenm committed rGb366329a34a1: DAG/GlobalISel: Correct type profile of bitcount ops (authored by arsenm).
DAG/GlobalISel: Correct type profile of bitcount ops
Thu, Sep 12, 5:11 PM
arsenm committed rL371798: AMDGPU/GlobalISel: Select G_CTPOP.
AMDGPU/GlobalISel: Select G_CTPOP
Thu, Sep 12, 5:10 PM
arsenm committed rL371797: DAG/GlobalISel: Correct type profile of bitcount ops.
DAG/GlobalISel: Correct type profile of bitcount ops
Thu, Sep 12, 5:10 PM
arsenm closed D67338: AMDGPU: Add immarg tto llvm.amdgcn.init.exec.from.input.

r371793

Thu, Sep 12, 4:55 PM
arsenm closed D67505: LiveIntervals: Remove assertion.

r371792

Thu, Sep 12, 4:55 PM
arsenm closed D67519: AMDGPU: Inline constant when materalizing FI with add on gfx9.

r371791

Thu, Sep 12, 4:55 PM
arsenm committed rG91b758f35809: AMDGPU: Add immarg to llvm.amdgcn.init.exec.from.input (authored by arsenm).
AMDGPU: Add immarg to llvm.amdgcn.init.exec.from.input
Thu, Sep 12, 4:47 PM
arsenm committed rGb85c8c4bbded: LiveIntervals: Remove assertion (authored by arsenm).
LiveIntervals: Remove assertion
Thu, Sep 12, 4:47 PM
arsenm committed rG8382ce5f1b09: AMDGPU: Inline constant when materalizing FI with add on gfx9 (authored by arsenm).
AMDGPU: Inline constant when materalizing FI with add on gfx9
Thu, Sep 12, 4:47 PM
arsenm committed rL371793: AMDGPU: Add immarg to llvm.amdgcn.init.exec.from.input.
AMDGPU: Add immarg to llvm.amdgcn.init.exec.from.input
Thu, Sep 12, 4:45 PM
arsenm committed rL371791: AMDGPU: Inline constant when materalizing FI with add on gfx9.
AMDGPU: Inline constant when materalizing FI with add on gfx9
Thu, Sep 12, 4:45 PM
arsenm committed rL371792: LiveIntervals: Remove assertion.
LiveIntervals: Remove assertion
Thu, Sep 12, 4:45 PM
arsenm accepted D66318: [SDAG] Update generic code to conservatively check for isAtomic in addition to isVolatile.

LGTM with nits

Thu, Sep 12, 3:13 PM · Restricted Project
arsenm created D67519: AMDGPU: Inline constant when materalizing FI with add on gfx9.
Thu, Sep 12, 1:57 PM
arsenm created D67505: LiveIntervals: Remove assertion.
Thu, Sep 12, 9:06 AM

Wed, Sep 11

arsenm created D67464: MachineScheduler: Fix assert from not checking subregs.
Wed, Sep 11, 1:17 PM
arsenm added inline comments to D67279: GlobalISel/AMDGPU: Legalize G_FMAD.
Wed, Sep 11, 12:58 PM
arsenm committed rGf5c3bb60b39f: Fix test failures after r371640 (authored by arsenm).
Fix test failures after r371640
Wed, Sep 11, 11:55 AM
arsenm committed rL371645: Fix test failures after r371640.
Fix test failures after r371640
Wed, Sep 11, 11:53 AM
arsenm committed rG81196a595c68: LiveIntervals: Split live intervals on multiple dead defs (authored by arsenm).
LiveIntervals: Split live intervals on multiple dead defs
Wed, Sep 11, 10:59 AM
arsenm committed rL371640: LiveIntervals: Split live intervals on multiple dead defs.
LiveIntervals: Split live intervals on multiple dead defs
Wed, Sep 11, 10:57 AM
arsenm closed D67448: LiveIntervals: Split live intervals on multiple dead defs.

r371640

Wed, Sep 11, 10:57 AM
arsenm accepted D67446: [ConstProp] allow folding for fma that produces NaN.

LGTM

Wed, Sep 11, 7:49 AM · Restricted Project
arsenm created D67448: LiveIntervals: Split live intervals on multiple dead defs.
Wed, Sep 11, 7:40 AM

Tue, Sep 10

arsenm accepted D67406: [TLI][AMDGPU] AMDPAL does not have tan function.

LGTM

Tue, Sep 10, 12:18 PM · Restricted Project
arsenm added a comment to D67132: [PATCH] Improve support for atomicrmw and cmpxchg in C API..

Tests?

Tue, Sep 10, 12:11 PM · Restricted Project
arsenm added a comment to D58233: Allow replacing intrinsic operands with variables.

I don't really have any concerns about this from the perspective of correctness; any breakage will be obvious and easy to fix.

In terms of performance, I'm a little concerned we might not have an appropriate heuristic for profitability for all the callers of canReplaceOperandWithVariable. Even if it's technically legal, for example, pulling the length out of a memcpy forces it to be lowered to a library call, which could be a lot slower. (Even for non-intrinsic functions, we've had issues with this in the past; there was a bug reported at one point that we were pulling the shift amount out of an i256 shift, or something like that.)

Tue, Sep 10, 11:49 AM
arsenm added a parent revision for D67355: AMDGPU/GlobalISel: Select G_CTPOP: D67333: DAG/GlobalISel: Correct type profile of bitcount ops.
Tue, Sep 10, 11:21 AM
arsenm added a child revision for D67333: DAG/GlobalISel: Correct type profile of bitcount ops: D67355: AMDGPU/GlobalISel: Select G_CTPOP.
Tue, Sep 10, 11:21 AM
arsenm committed rG4a23ae5e7879: GlobalISel/TableGen: Handle REG_SEQUENCE patterns (authored by arsenm).
GlobalISel/TableGen: Handle REG_SEQUENCE patterns
Tue, Sep 10, 11:01 AM
arsenm committed rL371542: GlobalISel/TableGen: Handle REG_SEQUENCE patterns.
GlobalISel/TableGen: Handle REG_SEQUENCE patterns
Tue, Sep 10, 10:56 AM
arsenm closed D67136: GlobalISel/TableGen: Handle REG_SEQUENCE patterns.

r371542

Tue, Sep 10, 10:56 AM
arsenm committed rGe1895aba3da0: AMDGPU/GlobalISel: Select G_FABS/G_FNEG (authored by arsenm).
AMDGPU/GlobalISel: Select G_FABS/G_FNEG
Tue, Sep 10, 10:25 AM
arsenm committed rL371540: AMDGPU/GlobalISel: Select G_FABS/G_FNEG.
AMDGPU/GlobalISel: Select G_FABS/G_FNEG
Tue, Sep 10, 10:25 AM
arsenm closed D67055: AMDGPU/GlobalISel: Select G_FABS/G_FNEG.

r371540

Tue, Sep 10, 10:25 AM
arsenm committed rG7df5b3fd2624: AMDGPU/GlobalISel: Select cvt pk intrinsics (authored by arsenm).
AMDGPU/GlobalISel: Select cvt pk intrinsics
Tue, Sep 10, 10:17 AM
arsenm committed rG37d1bda4f6b5: AMDGPU/GlobalISel: Select llvm.amdgcn.sffbh (authored by arsenm).
AMDGPU/GlobalISel: Select llvm.amdgcn.sffbh
Tue, Sep 10, 10:17 AM
arsenm committed rL371539: AMDGPU/GlobalISel: Select cvt pk intrinsics.
AMDGPU/GlobalISel: Select cvt pk intrinsics
Tue, Sep 10, 10:16 AM
arsenm committed rL371538: AMDGPU/GlobalISel: Select llvm.amdgcn.sffbh.
AMDGPU/GlobalISel: Select llvm.amdgcn.sffbh
Tue, Sep 10, 10:16 AM
arsenm added a comment to D66666: [AMDGPU] Remove unnecessary movs for v_fmac operands.

Can you also add a MIR test for this? Also testing the 16-bit case would be nice

Tue, Sep 10, 9:59 AM · Restricted Project
arsenm committed rGda027275c666: AMDGPU/GlobalISel: RegBankSelect for G_ZEXTLOAD/G_SEXTLOAD (authored by arsenm).
AMDGPU/GlobalISel: RegBankSelect for G_ZEXTLOAD/G_SEXTLOAD
Tue, Sep 10, 9:43 AM
arsenm committed rGad6a8b83cdc3: AMDGPU/GlobalISel: Legalize constant 32-bit loads (authored by arsenm).
AMDGPU/GlobalISel: Legalize constant 32-bit loads
Tue, Sep 10, 9:43 AM
arsenm committed rL371536: AMDGPU/GlobalISel: RegBankSelect for G_ZEXTLOAD/G_SEXTLOAD.
AMDGPU/GlobalISel: RegBankSelect for G_ZEXTLOAD/G_SEXTLOAD
Tue, Sep 10, 9:43 AM
arsenm committed rL371535: AMDGPU/GlobalISel: Legalize constant 32-bit loads.
AMDGPU/GlobalISel: Legalize constant 32-bit loads
Tue, Sep 10, 9:43 AM
arsenm added a comment to D67396: [ConstantHoisting] Do not attempt to hoist ImmArgs.

See D58233

Tue, Sep 10, 9:43 AM · Restricted Project
arsenm added a comment to D58233: Allow replacing intrinsic operands with variables.

ping

Tue, Sep 10, 9:43 AM
arsenm closed D67042: AMDGPU/GlobalISel: RegBankSelect for G_ZEXTLOAD/G_SEXTLOAD.

r371536

Tue, Sep 10, 9:43 AM
arsenm added a comment to D66971: TableGen: Remove assert that pattern results match input number.

ping

Tue, Sep 10, 9:38 AM
arsenm added inline comments to D67406: [TLI][AMDGPU] AMDPAL does not have tan function.
Tue, Sep 10, 9:37 AM · Restricted Project
arsenm added inline comments to D67406: [TLI][AMDGPU] AMDPAL does not have tan function.
Tue, Sep 10, 9:28 AM · Restricted Project
arsenm committed rGc0ceca588306: AMDGPU/GlobalISel: First pass at attempting to legalize load/stores (authored by arsenm).
AMDGPU/GlobalISel: First pass at attempting to legalize load/stores
Tue, Sep 10, 9:21 AM
arsenm closed D64899: AMDGPU/GlobalISel: First pass at attempting to legalize load/stores.

r371533. Had to split some of the tests to avoid differences in release builds

Tue, Sep 10, 9:20 AM
arsenm committed rL371533: AMDGPU/GlobalISel: First pass at attempting to legalize load/stores.
AMDGPU/GlobalISel: First pass at attempting to legalize load/stores
Tue, Sep 10, 9:19 AM

Mon, Sep 9

arsenm added reviewers for D66389: AMDGPU/GlobalISel: Legalize constant 32-bit loads: kerbowa, rampitec, ronlieb.
Mon, Sep 9, 5:48 PM
arsenm added a comment to D66389: AMDGPU/GlobalISel: Legalize constant 32-bit loads.

ping

Mon, Sep 9, 5:48 PM
arsenm updated the diff for D64899: AMDGPU/GlobalISel: First pass at attempting to legalize load/stores.

Address comments and rebase testss

Mon, Sep 9, 5:13 PM
arsenm accepted D67380: [globalisel][knownbits] Allow targets to call GISelKnownBits::computeKnownBitsImpl().

LGTM

Mon, Sep 9, 4:54 PM · Restricted Project
arsenm committed rGa91f017ae315: AMDGPU/GlobalISel: Fix insert point when lowering fminnum/fmaxnum (authored by arsenm).
AMDGPU/GlobalISel: Fix insert point when lowering fminnum/fmaxnum
Mon, Sep 9, 4:30 PM