Page MenuHomePhabricator
Feed Advanced Search

Feb 18 2021

awpr updated the diff for D96380: Perform memory accesses in the same addrspace as the corresponding memref..

Rebased onto more recent github/main.

Feb 18 2021, 11:57 AM · Restricted Project
awpr removed 1 blocking reviewer(s) for D96380: Perform memory accesses in the same addrspace as the corresponding memref.: whchung.
Feb 18 2021, 11:14 AM · Restricted Project

Feb 10 2021

awpr added a reviewer for D96380: Perform memory accesses in the same addrspace as the corresponding memref.: whchung.
Feb 10 2021, 9:15 AM · Restricted Project

Feb 9 2021

awpr updated the diff for D96369: Fix side-effect detection in LLVMIRIntrinsicGen..

Change from loops with early retuns to llvm::any_of and llvm::none_of.

Feb 9 2021, 4:24 PM · Restricted Project
awpr requested review of D96380: Perform memory accesses in the same addrspace as the corresponding memref..
Feb 9 2021, 3:59 PM · Restricted Project
awpr added a comment to D79023: [mlir][vector] let transfer_read and transfer_write take non-zero addrspace..

Is it important for the memory accesses here to be done via addrspace 0, or is that just an artifact of making the pointer type match up? It seems that for many architectures with multiple memory spaces, it won't be possible to address all memory via addrspace 0, and memory accesses should be done in the addrspace their memref lives in (as in https://reviews.llvm.org/D96380); but I'm not sure whether making that change would affect the use case this was meant for.

Feb 9 2021, 3:12 PM · Restricted Project, Restricted Project
awpr requested review of D96373: Add LLVMIR Dialect counterparts of @llvm.maximum and @llvm.minimum..
Feb 9 2021, 2:28 PM · Restricted Project
awpr requested review of D96369: Fix side-effect detection in LLVMIRIntrinsicGen..
Feb 9 2021, 2:03 PM · Restricted Project

Aug 21 2020

awpr added a reviewer for D86385: Use the named accessor methods in predicate substitutions.: jpienaar.
Aug 21 2020, 4:18 PM · Restricted Project
awpr requested review of D86385: Use the named accessor methods in predicate substitutions..
Aug 21 2020, 4:10 PM · Restricted Project