Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Feed Advanced Search

Aug 16 2023

scchan committed rGd40fd9e1d99c: Fix typo in module inliner priority flag (authored by scchan).
Fix typo in module inliner priority flag
Aug 16 2023, 9:27 AM · Restricted Project, Restricted Project
scchan closed D158013: Fix typo in module inliner priority flag.
Aug 16 2023, 9:26 AM · Restricted Project, Restricted Project

Aug 15 2023

scchan added a reviewer for D158013: Fix typo in module inliner priority flag: kazu.
Aug 15 2023, 12:37 PM · Restricted Project, Restricted Project
scchan requested review of D158013: Fix typo in module inliner priority flag.
Aug 15 2023, 12:35 PM · Restricted Project, Restricted Project

Jul 27 2023

scchan accepted D156426: [HIP] link HIP runtime library without --hip-link.

LGTM thanks

Jul 27 2023, 12:49 PM · Restricted Project, Restricted Project
scchan accepted D155213: [Driver] Add `-f[no-]offload-uniform-block`.

LGTM thanks

Jul 27 2023, 12:30 PM · Restricted Project, Restricted Project
scchan added inline comments to D156426: [HIP] link HIP runtime library without --hip-link.
Jul 27 2023, 8:27 AM · Restricted Project, Restricted Project
scchan added inline comments to D155213: [Driver] Add `-f[no-]offload-uniform-block`.
Jul 27 2023, 8:17 AM · Restricted Project, Restricted Project

Jul 24 2023

scchan accepted D154123: [HIP] Start document HIP support by clang.

LGTM thanks

Jul 24 2023, 11:58 AM · Restricted Project, Restricted Project
scchan added inline comments to D154123: [HIP] Start document HIP support by clang.
Jul 24 2023, 10:45 AM · Restricted Project, Restricted Project

Jul 18 2023

scchan accepted D155539: [CUDA][HIP] Use the same default language std as C++.

LGTM thanks

Jul 18 2023, 8:23 AM · Restricted Project, Restricted Project

Jul 17 2023

scchan committed rGcbc4bbb85c72: [HIP] Ignore host linker flags for device-only (authored by scchan).
[HIP] Ignore host linker flags for device-only
Jul 17 2023, 1:30 PM · Restricted Project, Restricted Project
scchan closed D154881: [HIP] Ignore host linker flags for device-only.
Jul 17 2023, 1:29 PM · Restricted Project, Restricted Project
scchan updated the diff for D154881: [HIP] Ignore host linker flags for device-only.

minor formatting fixes, rebased

Jul 17 2023, 8:38 AM · Restricted Project, Restricted Project

Jul 14 2023

scchan added inline comments to D155213: [Driver] Add `-f[no-]offload-uniform-block`.
Jul 14 2023, 10:41 AM · Restricted Project, Restricted Project
scchan updated the diff for D154881: [HIP] Ignore host linker flags for device-only.

added extra checks for not host, rebased

Jul 14 2023, 10:22 AM · Restricted Project, Restricted Project

Jul 12 2023

scchan added a comment to D152414: AMDGPU: Do not not force alwaysinline with calls and module LDS enabled.

LG here. Can we get rid of EnableFunctionCalls?

If we can get rid of hipcc which is still using it

hipcc only needs a way to force EarlyInlineAll but that pass is predicated by !EnableFunctionCalls. If we don't think it's warranted then we can deprecate EnableFunctionCalls by first removing it in hipcc.

Jul 12 2023, 11:14 AM · Restricted Project, Restricted Project

Jul 11 2023

scchan added a comment to rGac3e720dc1af: Make clang HIP headers compatible with C++98.

Can you either

  1. Add test coverage
  2. Delete this entirely

Is it really worth holding a static_assert for the size of the FP types? The implementation for nan should be moved out of the header anyway (and go through builtin_nan/builtin_nanf)

+ @scchan I think we might still need these changes. We could add a lit test to clang/test/Headers about this.

Yea, I think we can make nan/nanf to go through the builtins and then get rid of this implementation.

Jul 11 2023, 11:24 AM
scchan updated the diff for D154881: [HIP] Ignore host linker flags for device-only.

addressed comments from yaxunl, rebased

Jul 11 2023, 10:03 AM · Restricted Project, Restricted Project

Jul 10 2023

scchan requested review of D154881: [HIP] Ignore host linker flags for device-only.
Jul 10 2023, 1:06 PM · Restricted Project, Restricted Project

Jul 7 2023

scchan added inline comments to D154133: [amdgpu] start documenting amdgpu support by clang.
Jul 7 2023, 11:35 AM · Restricted Project, Restricted Project
scchan added inline comments to D154210: AMDGPU: Add some notes about amdgpu-flat-work-group-size.
Jul 7 2023, 10:15 AM · Restricted Project, Restricted Project
scchan added inline comments to D154123: [HIP] Start document HIP support by clang.
Jul 7 2023, 9:50 AM · Restricted Project, Restricted Project
scchan added inline comments to D154133: [amdgpu] start documenting amdgpu support by clang.
Jul 7 2023, 9:37 AM · Restricted Project, Restricted Project

Jun 29 2023

scchan added inline comments to D154123: [HIP] Start document HIP support by clang.
Jun 29 2023, 12:44 PM · Restricted Project, Restricted Project

Jun 9 2023

scchan committed rGf1aee32f1c85: [HIP] Instruct lld to go through all archives (authored by scchan).
[HIP] Instruct lld to go through all archives
Jun 9 2023, 5:51 AM · Restricted Project, Restricted Project
scchan closed D152207: [HIP] Instruct lld to go through all archives.
Jun 9 2023, 5:51 AM · Restricted Project, Restricted Project

Jun 8 2023

scchan accepted D149741: [InlineCost][TargetTransformInfo][AMDGPU] Consider cost of alloca instructions in the caller (2/2).

LGTM

Jun 8 2023, 12:23 PM · Restricted Project, Restricted Project
scchan added a comment to D152414: AMDGPU: Do not not force alwaysinline with calls and module LDS enabled.

We should probably drop the amdgpu-function-calls too but I think
hipcc is still using it.

The amdgpu-function-calls switch is needed to disable function calls as a prereq to enable alwaysinline, which I don't understand why.

I'm failing to parse this sentence

Jun 8 2023, 11:11 AM · Restricted Project, Restricted Project
scchan updated the diff for D152207: [HIP] Instruct lld to go through all archives.

rebased

Jun 8 2023, 10:23 AM · Restricted Project, Restricted Project
scchan added a comment to D152414: AMDGPU: Do not not force alwaysinline with calls and module LDS enabled.

We should probably drop the amdgpu-function-calls too but I think
hipcc is still using it.

Jun 8 2023, 9:20 AM · Restricted Project, Restricted Project

Jun 7 2023

scchan updated the diff for D152207: [HIP] Instruct lld to go through all archives.

Removed redundant comment.

Jun 7 2023, 12:26 PM · Restricted Project, Restricted Project
scchan updated the diff for D152207: [HIP] Instruct lld to go through all archives.

added a matching --no-whole-archive

Jun 7 2023, 10:54 AM · Restricted Project, Restricted Project
scchan updated the diff for D152207: [HIP] Instruct lld to go through all archives.

fix some formatting issue

Jun 7 2023, 8:13 AM · Restricted Project, Restricted Project

Jun 6 2023

scchan added inline comments to D151996: [AMDGPU] Start documenting calling conventions. NFC.
Jun 6 2023, 3:50 PM · Restricted Project, Restricted Project
scchan updated the diff for D152207: [HIP] Instruct lld to go through all archives.

remove ws

Jun 6 2023, 3:35 PM · Restricted Project, Restricted Project
scchan updated the diff for D152207: [HIP] Instruct lld to go through all archives.

Updated patch to address review feedback

Jun 6 2023, 3:32 PM · Restricted Project, Restricted Project

Jun 5 2023

scchan added reviewers for D152207: [HIP] Instruct lld to go through all archives: yaxunl, kerbowa, bcahoon.
Jun 5 2023, 4:02 PM · Restricted Project, Restricted Project
scchan requested review of D152207: [HIP] Instruct lld to go through all archives.
Jun 5 2023, 4:00 PM · Restricted Project, Restricted Project

May 18 2023

scchan added inline comments to D149741: [InlineCost][TargetTransformInfo][AMDGPU] Consider cost of alloca instructions in the caller (2/2).
May 18 2023, 8:47 AM · Restricted Project, Restricted Project
scchan added inline comments to D149741: [InlineCost][TargetTransformInfo][AMDGPU] Consider cost of alloca instructions in the caller (2/2).
May 18 2023, 7:05 AM · Restricted Project, Restricted Project

Apr 26 2023

scchan accepted D149110: [HIP] Detect HIP for Ubuntu, Mint, Gentoo, etc..
Apr 26 2023, 9:17 AM · Restricted Project, Restricted Project

Mar 8 2023

scchan added a comment to D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading.

LGTM

Mar 8 2023, 11:00 AM · Restricted Project, Restricted Project
scchan added a reviewer for D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading: yaxunl.
Mar 8 2023, 10:59 AM · Restricted Project, Restricted Project

Feb 7 2023

scchan added inline comments to D143498: Reapply "[AMDGPU] Modify adjustInliningThreshold to also consider the cost of passing function arguments through the stack".
Feb 7 2023, 12:13 PM · Restricted Project, Restricted Project

Jan 25 2023

scchan committed rG56184bb3ad3f: [AMDGCN] Fix device lib test to work with lib64 (authored by scchan).
[AMDGCN] Fix device lib test to work with lib64
Jan 25 2023, 6:56 AM · Restricted Project, Restricted Project
scchan closed D142506: [AMDGCN] Fix device lib test to work with lib64.
Jan 25 2023, 6:56 AM · Restricted Project, Restricted Project

Jan 24 2023

scchan added a comment to D142506: [AMDGCN] Fix device lib test to work with lib64.

The resource directory should be strictly controlled. why would lib64 ever be used here?

Jan 24 2023, 3:01 PM · Restricted Project, Restricted Project
scchan requested review of D142506: [AMDGCN] Fix device lib test to work with lib64.
Jan 24 2023, 2:17 PM · Restricted Project, Restricted Project
scchan added a comment to D140315: [AMDGCN] Update search path for device libraries.

I'm sorry for reporting it this late (clang's been broken for over two weeks, so we couldn't periodically test it) but this change is causing test regressions on Gentoo/amd64:

Thanks for reporting the issue. I'm working on a patch to fix the test.

Jan 24 2023, 9:11 AM · Restricted Project, Restricted Project

Jan 12 2023

scchan added inline comments to D140242: [AMDGPU] Modify adjustInliningThreshold to also consider the cost of passing function arguments through the stack.
Jan 12 2023, 11:54 AM · Restricted Project, Restricted Project

Jan 11 2023

scchan committed rGa18fe67b9fcf: [AMDGCN] Update search path for device libraries (authored by scchan).
[AMDGCN] Update search path for device libraries
Jan 11 2023, 8:53 AM · Restricted Project, Restricted Project
scchan closed D140315: [AMDGCN] Update search path for device libraries.
Jan 11 2023, 8:53 AM · Restricted Project, Restricted Project

Dec 22 2022

scchan added a comment to D140315: [AMDGCN] Update search path for device libraries.

files under clang/test/Driver/Inputs/rocm_resource_dir/lib/amdgcn/bitcode-no-abi-ver seem not used.

Dec 22 2022, 1:14 PM · Restricted Project, Restricted Project
scchan updated the diff for D140315: [AMDGCN] Update search path for device libraries.

Remove unused bitcode files

Dec 22 2022, 1:12 PM · Restricted Project, Restricted Project

Dec 19 2022

scchan requested review of D140315: [AMDGCN] Update search path for device libraries.
Dec 19 2022, 9:27 AM · Restricted Project, Restricted Project

Dec 16 2022

scchan added inline comments to D140242: [AMDGPU] Modify adjustInliningThreshold to also consider the cost of passing function arguments through the stack.
Dec 16 2022, 1:38 PM · Restricted Project, Restricted Project
scchan requested changes to D140242: [AMDGPU] Modify adjustInliningThreshold to also consider the cost of passing function arguments through the stack.
Dec 16 2022, 1:23 PM · Restricted Project, Restricted Project

Nov 16 2022

scchan updated subscribers of D138141: [amdgpu] Reimplement LDS lowering.
Nov 16 2022, 9:46 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sep 29 2022

scchan committed rGcecb0e98d4b1: [HIP] stop forcing the lang std in the driver (authored by scchan).
[HIP] stop forcing the lang std in the driver
Sep 29 2022, 1:22 PM · Restricted Project, Restricted Project
scchan closed D134314: [HIP] stop forcing the lang std in the driver.
Sep 29 2022, 1:22 PM · Restricted Project, Restricted Project

Sep 20 2022

scchan requested review of D134314: [HIP] stop forcing the lang std in the driver.
Sep 20 2022, 2:20 PM · Restricted Project, Restricted Project

Sep 12 2022

scchan accepted D133705: [HIP] Fix unbundling archive.

LGTM

Sep 12 2022, 10:57 AM · Restricted Project
scchan requested changes to D133705: [HIP] Fix unbundling archive.
Sep 12 2022, 9:39 AM · Restricted Project

Aug 5 2022

scchan added a comment to D130784: [AMDGPU] Support LDS spilling.

Just briefly glanced through the code and it seems that it doesn't look at whether a kernel has dynamic LDS or not because LDS spilling has to be disabled in that case, can you confirm?

Aug 5 2022, 9:03 AM · Restricted Project, Restricted Project

Jun 7 2022

scchan added a comment to D127052: [amdgpu][nfc] Allocate kernel-specific LDS struct deterministically.

Hoping this is uncontroversial - got more patches to follow up with if we can land this,

Jun 7 2022, 8:08 AM · Restricted Project, Restricted Project

Apr 8 2022

scchan requested review of D123387: [clang-offload-bundler] fix "no output file" issue with -outputs.
Apr 8 2022, 6:41 AM · Restricted Project, Restricted Project

Apr 4 2022

scchan updated the diff for D120662: [clang-offload-bundler] add -input/-output options.
  • fixed the hip-link-bundle-archive.hip test issue on Windows
  • fixed a couple of formatting issues
Apr 4 2022, 9:50 AM · Restricted Project, Restricted Project

Apr 1 2022

scchan updated the diff for D120662: [clang-offload-bundler] add -input/-output options.

update the failing lit tests to recognize the new switches

Apr 1 2022, 1:29 PM · Restricted Project, Restricted Project

Mar 28 2022

scchan updated the diff for D120662: [clang-offload-bundler] add -input/-output options.

update the clang-offload-bundler-asserts-on test

Mar 28 2022, 2:41 PM · Restricted Project, Restricted Project
scchan updated the diff for D120662: [clang-offload-bundler] add -input/-output options.

fix lit test failures on Windows, rebased

Mar 28 2022, 2:36 PM · Restricted Project, Restricted Project

Feb 28 2022

scchan added a reviewer for D120662: [clang-offload-bundler] add -input/-output options: tra.
Feb 28 2022, 7:45 AM · Restricted Project, Restricted Project
scchan requested review of D120662: [clang-offload-bundler] add -input/-output options.
Feb 28 2022, 7:44 AM · Restricted Project, Restricted Project

Jan 19 2022

scchan added a comment to D117494: AMDGPU: Account for usage HIP-style dynamic LDS.

I am OK for now. We may need keep an eye for the perf regression and be prepared to figure a way to alleviate that.

Jan 19 2022, 7:57 AM · Restricted Project

Jan 18 2022

scchan updated the diff for D117494: AMDGPU: Account for usage HIP-style dynamic LDS.

Check for zero-sized and move the check into the existing loop.

Jan 18 2022, 3:17 PM · Restricted Project

Jan 17 2022

scchan added reviewers for D117494: AMDGPU: Account for usage HIP-style dynamic LDS: arsenm, yaxunl.
Jan 17 2022, 8:17 AM · Restricted Project
scchan requested review of D117494: AMDGPU: Account for usage HIP-style dynamic LDS.
Jan 17 2022, 8:15 AM · Restricted Project

Jul 22 2021

scchan accepted D106571: [HIP] Fix visibility of __hip_fatbin.

LGTM

Jul 22 2021, 10:36 AM · Restricted Project

Jun 30 2021

scchan accepted D104904: [OpenMP][AMDGCN] Initial math headers support.
Jun 30 2021, 7:59 AM · Restricted Project

Jun 25 2021

scchan added inline comments to D104904: [OpenMP][AMDGCN] Initial math headers support.
Jun 25 2021, 6:50 AM · Restricted Project
scchan added a reviewer for D104904: [OpenMP][AMDGCN] Initial math headers support: b-sumner.
Jun 25 2021, 5:41 AM · Restricted Project

Jun 18 2021

scchan updated the diff for D104392: [HIP] Add support functions for C++ polymorphic types.

Minor clean up in the hip-header.hip test

Jun 18 2021, 10:30 AM · Restricted Project
scchan updated the diff for D104392: [HIP] Add support functions for C++ polymorphic types.

Adding test

Jun 18 2021, 9:46 AM · Restricted Project

Jun 16 2021

scchan requested review of D104392: [HIP] Add support functions for C++ polymorphic types.
Jun 16 2021, 8:42 AM · Restricted Project

Aug 6 2020

scchan added a reviewer for D85471: Make clang HIP headers compatible with C++98: yaxunl.
Aug 6 2020, 12:57 PM · Restricted Project, Restricted Project
scchan requested review of D85471: Make clang HIP headers compatible with C++98.
Aug 6 2020, 12:56 PM · Restricted Project, Restricted Project

Jun 24 2020

scchan added inline comments to D82496: [amdgpu] Add codegen support for HIP dynamic shared memory..
Jun 24 2020, 1:34 PM · Restricted Project

Feb 27 2020

Gerrit Code Review <gerritcr@atlswgit02.amd.com> committed rGfd9b4174403a: Merge "Speed up SAC when erasing unwanted functions by deleting the function… (authored by scchan).
Merge "Speed up SAC when erasing unwanted functions by deleting the function…
Feb 27 2020, 7:05 AM
Gerrit Code Review <gerritcr@atlswgit02.amd.com> committed rG0823d86dceb7: Merge "SelectAcceleratorCode: strip pointer casts when examining a call" into… (authored by scchan).
Merge "SelectAcceleratorCode: strip pointer casts when examining a call" into…
Feb 27 2020, 7:05 AM
scchan committed rG0334a838d6d4: SelectAcceleratorCode: strip pointer casts when examining a call (authored by sameerds).
SelectAcceleratorCode: strip pointer casts when examining a call
Feb 27 2020, 7:04 AM
Gerrit Code Review <gerritcr@atlswgit02.amd.com> committed rG5429b86d8620: Merge "do not traverse callgraph during pass initialization" into amd-common (authored by scchan).
Merge "do not traverse callgraph during pass initialization" into amd-common
Feb 27 2020, 7:04 AM
scchan committed rGb50ff5b4f946: do not traverse callgraph during pass initialization (authored by sameerds).
do not traverse callgraph during pass initialization
Feb 27 2020, 7:04 AM

Aug 13 2018

scchan accepted D50626: AMDGPU: Implement llvm.amdgcn.icmp/fcmp for i16/f16.

LGTM

Aug 13 2018, 7:44 AM
scchan accepted D50624: AMDGPU: Stop producing icmp/fcmp intrinsics with invalid types.

LGTM

Aug 13 2018, 7:32 AM

Jun 22 2018

scchan added a comment to D48493: [HIP] Support flush denorms bitcode.

LGTM

Jun 22 2018, 10:52 AM · Restricted Project, Restricted Project

May 16 2018

scchan accepted D46769: [AMDGPU] Change llvm.debugtrap to be a debug breakpoint that can resume execution..
May 16 2018, 9:16 AM

Mar 21 2017

scchan added a comment to D31210: [AMDGPU] Switch address space mapping by triple environment.

I'm concerned about the default address space to be 64 bit. It would move alloca into generic address space effectively making private address to be 64 bit.
This may have very undesirable performance implications, like address arithmetic can become expensive 64 bit and only be truncated at load or store.
I realize you will use addrspacecast on an alloca's value, though I'm not sure that is sufficient to mitigate performance hit.
I believe such change shall not be made without a good performance comparison with the feature enabled, provided the very likely performance issues.

Did not we want to use this: http://lists.llvm.org/pipermail/llvm-dev/2017-March/111199.html and use non-0 for our allocas?

Our final goal is to let alloca return private pointer. The Clang changes are mostly common whether alloca returns generic pointer or private pointer. Actually to be able to test the above patch we need to get the changes in Clang done first.

Mar 21 2017, 3:43 PM

Mar 1 2017

scchan accepted D29670: [DebugInfo] Emit address space with DW_AT_address_class attribute for pointer and reference types.

LGTM

Mar 1 2017, 7:12 AM