Page MenuHomePhabricator
Feed Advanced Search

Dec 5 2019

MadCoder added a comment to D71091: Make sure that the implicit arguments for direct methods have been setup.

turns out that I had no codegen check for the call site and that one of the last iteration broke it trivially :'(

Dec 5 2019, 2:26 PM · Restricted Project
MadCoder created D71091: Make sure that the implicit arguments for direct methods have been setup.
Dec 5 2019, 2:26 PM · Restricted Project

Nov 21 2019

MadCoder accepted D70544: Debug info: Emit objc_direct methods as members of their containing class.
Nov 21 2019, 10:14 AM · Restricted Project, debug-info

Nov 17 2019

MadCoder updated the diff for D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members)).

Diff against previous is:

Nov 17 2019, 8:49 PM · Restricted Project
MadCoder added a comment to D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members)).

when running the full test-suite before sending the patch, and it broke tests because some loads are now ordered differently :(
yay.

Nov 17 2019, 8:32 PM · Restricted Project

Nov 14 2019

MadCoder added inline comments to D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members)).
Nov 14 2019, 2:36 PM · Restricted Project
MadCoder updated the diff for D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members)).

reverted the hunk about "direct methods" note.

Nov 14 2019, 2:36 PM · Restricted Project
MadCoder updated the diff for D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members)).

Updated for the new round of comments, with added tests and Sema checks errors for:

  • messaging super
  • messaging a nullable Class expression
Nov 14 2019, 11:20 AM · Restricted Project
MadCoder added inline comments to D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members)).
Nov 14 2019, 11:20 AM · Restricted Project

Nov 13 2019

MadCoder updated the diff for D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members)).

Implemented all the tests @rjmccall wanted (and then some)

Nov 13 2019, 11:29 PM · Restricted Project
MadCoder added inline comments to D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members)).
Nov 13 2019, 11:29 PM · Restricted Project
MadCoder added a comment to D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members)).

Is it intentional that the direct method names use the exact same symbol namespace (\01-[class message]) as "real" Objective-C methods? Could that be a problem? Should we use a slightly different naming scheme?

Nov 13 2019, 10:00 PM · Restricted Project
MadCoder updated the diff for D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members)).

Beefed up the tests, addressed the selfValue related issue.

Nov 13 2019, 2:05 PM · Restricted Project
MadCoder added inline comments to D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members)).
Nov 13 2019, 2:05 PM · Restricted Project
MadCoder added inline comments to D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members)).
Nov 13 2019, 1:28 AM · Restricted Project
MadCoder updated the diff for D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members)).

Updated clang/test/Misc/pragma-attribute-supported-attributes-list.test that I had forgotten.

Nov 13 2019, 1:28 AM · Restricted Project
MadCoder updated the diff for D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members)).

Updated the patch to restrict objc_direct to methods and use objc_direct_members for containers, and several diagnostics improvements (especially in the vicinity of properties and the GNU runtime + tests).

Nov 13 2019, 1:18 AM · Restricted Project

Nov 12 2019

MadCoder added inline comments to D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members)).
Nov 12 2019, 11:20 PM · Restricted Project
MadCoder updated the diff for D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members)).

Handled a bunch of comments (marked done).

Nov 12 2019, 11:20 PM · Restricted Project
MadCoder added inline comments to D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members)).
Nov 12 2019, 11:20 PM · Restricted Project

Nov 8 2019

MadCoder added a comment to D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members)).

Why doesn't this need an update in lib/Serialization, is there generic code that handles all attributes?

Nov 8 2019, 3:01 PM · Restricted Project

Nov 7 2019

MadCoder added inline comments to D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members)).
Nov 7 2019, 11:37 PM · Restricted Project
MadCoder updated the summary of D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members)).
Nov 7 2019, 11:37 PM · Restricted Project
MadCoder created D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members)).
Nov 7 2019, 11:26 PM · Restricted Project