turns out that I had no codegen check for the call site and that one of the last iteration broke it trivially :'(
Dec 5 2019
Nov 21 2019
Nov 17 2019
Diff against previous is:
when running the full test-suite before sending the patch, and it broke tests because some loads are now ordered differently :(
Nov 14 2019
reverted the hunk about "direct methods" note.
Updated for the new round of comments, with added tests and Sema checks errors for:
- messaging super
- messaging a nullable Class expression
Nov 13 2019
Implemented all the tests @rjmccall wanted (and then some)
Is it intentional that the direct method names use the exact same symbol namespace (\01-[class message]) as "real" Objective-C methods? Could that be a problem? Should we use a slightly different naming scheme?
Beefed up the tests, addressed the selfValue related issue.
Updated clang/test/Misc/pragma-attribute-supported-attributes-list.test that I had forgotten.
Updated the patch to restrict objc_direct to methods and use objc_direct_members for containers, and several diagnostics improvements (especially in the vicinity of properties and the GNU runtime + tests).
Nov 12 2019
Handled a bunch of comments (marked done).
Nov 8 2019
Why doesn't this need an update in lib/Serialization, is there generic code that handles all attributes?