Page MenuHomePhabricator
Feed Advanced Search

Mon, Jul 22

miyuki committed rGb64b9009628d: [libunwind][ARM] Fix types in _Unwind_VRS_Get. (authored by miyuki).
[libunwind][ARM] Fix types in _Unwind_VRS_Get.
Mon, Jul 22, 9:45 AM
miyuki committed rL366701: [libunwind][ARM] Fix types in _Unwind_VRS_Get..
[libunwind][ARM] Fix types in _Unwind_VRS_Get.
Mon, Jul 22, 9:44 AM

Fri, Jul 19

miyuki committed rGf41e62715729: [libunwind][ARM] Fix loading FP registers on big-endian targets (authored by miyuki).
[libunwind][ARM] Fix loading FP registers on big-endian targets
Fri, Jul 19, 8:24 AM
miyuki committed rL366587: [libunwind][ARM] Fix loading FP registers on big-endian targets.
[libunwind][ARM] Fix loading FP registers on big-endian targets
Fri, Jul 19, 8:20 AM
miyuki closed D64996: [libunwind][ARM] Fix loading FP registers on big-endian targets.
Fri, Jul 19, 8:20 AM · Restricted Project, Restricted Project
miyuki created D64996: [libunwind][ARM] Fix loading FP registers on big-endian targets.
Fri, Jul 19, 7:40 AM · Restricted Project, Restricted Project
miyuki committed rG0b001f94a54a: [ARM] Add <saturate> operand to SQRSHRL and UQRSHLL (authored by miyuki).
[ARM] Add <saturate> operand to SQRSHRL and UQRSHLL
Fri, Jul 19, 2:49 AM
miyuki committed rL366555: [ARM] Add <saturate> operand to SQRSHRL and UQRSHLL.
[ARM] Add <saturate> operand to SQRSHRL and UQRSHLL
Fri, Jul 19, 2:48 AM
miyuki closed D64810: [ARM] Add <saturate> operand to SQRSHRL and UQRSHLL.
Fri, Jul 19, 2:48 AM · Restricted Project
miyuki updated the diff for D64810: [ARM] Add <saturate> operand to SQRSHRL and UQRSHLL.

Removed some redundancy.

Fri, Jul 19, 2:31 AM · Restricted Project

Tue, Jul 16

miyuki created D64810: [ARM] Add <saturate> operand to SQRSHRL and UQRSHLL.
Tue, Jul 16, 10:53 AM · Restricted Project

Wed, Jul 10

miyuki accepted D64502: [ARM] Remove nonexistent unsigned forms of MVE VQDMLAH..
Wed, Jul 10, 8:24 AM · Restricted Project
miyuki committed rGed143c5d59bd: [ARM] Enable VPUSH/VPOP aliases when either MVE or VFP is present (authored by miyuki).
[ARM] Enable VPUSH/VPOP aliases when either MVE or VFP is present
Wed, Jul 10, 2:01 AM
miyuki committed rL365604: [ARM] Enable VPUSH/VPOP aliases when either MVE or VFP is present.
[ARM] Enable VPUSH/VPOP aliases when either MVE or VFP is present
Wed, Jul 10, 1:59 AM
miyuki closed D64413: [ARM] Enable VPUSH/VPOP aliases when either MVE or VFP is present.
Wed, Jul 10, 1:59 AM · Restricted Project

Tue, Jul 9

miyuki updated the diff for D64413: [ARM] Enable VPUSH/VPOP aliases when either MVE or VFP is present.

Uploaded the correct patch

Tue, Jul 9, 11:17 AM · Restricted Project
miyuki updated the diff for D64413: [ARM] Enable VPUSH/VPOP aliases when either MVE or VFP is present.

Changed predicate for variants with suffixes

Tue, Jul 9, 11:17 AM · Restricted Project
miyuki committed rGa448ed99dfdb: [libunwind] Fix Unwind-EHABI.cpp:getByte on big-endian targets (authored by miyuki).
[libunwind] Fix Unwind-EHABI.cpp:getByte on big-endian targets
Tue, Jul 9, 8:33 AM
miyuki committed rL365505: [libunwind] Fix Unwind-EHABI.cpp:getByte on big-endian targets.
[libunwind] Fix Unwind-EHABI.cpp:getByte on big-endian targets
Tue, Jul 9, 8:29 AM
miyuki closed D64402: [libunwind] Fix Unwind-EHABI.cpp:getByte on big-endian targets.
Tue, Jul 9, 8:29 AM · Restricted Project, Restricted Project
miyuki created D64413: [ARM] Enable VPUSH/VPOP aliases when either MVE or VFP is present.
Tue, Jul 9, 6:24 AM · Restricted Project
miyuki added reviewers for D64402: [libunwind] Fix Unwind-EHABI.cpp:getByte on big-endian targets: dmgreen, christof.
Tue, Jul 9, 4:51 AM · Restricted Project, Restricted Project
miyuki created D64402: [libunwind] Fix Unwind-EHABI.cpp:getByte on big-endian targets.
Tue, Jul 9, 4:49 AM · Restricted Project, Restricted Project

Mon, Jul 8

miyuki committed rGee81051fc96a: [ARM] Relax constraints on operands of VQxDMLxDH instructions (authored by miyuki).
[ARM] Relax constraints on operands of VQxDMLxDH instructions
Mon, Jul 8, 2:46 AM
miyuki committed rL365306: [ARM] Relax constraints on operands of VQxDMLxDH instructions.
[ARM] Relax constraints on operands of VQxDMLxDH instructions
Mon, Jul 8, 2:46 AM
miyuki closed D64250: [ARM] Relax constraints on operands of VQxDMLxDH instructions.
Mon, Jul 8, 2:46 AM · Restricted Project
miyuki abandoned D64260: [libc++] Erase-Like Algorithms in C++17 and below.

Abandoned in favor of:
https://reviews.llvm.org/rG1ab3fe8a7a6537f882bbb2dac72c479d05eb8c49 and
https://reviews.llvm.org/rGf814dcbafbabd46a1babaeabec6acc3b70951bf4

Mon, Jul 8, 2:37 AM · Restricted Project

Fri, Jul 5

miyuki created D64260: [libc++] Erase-Like Algorithms in C++17 and below.
Fri, Jul 5, 11:51 AM · Restricted Project
miyuki added reviewers for D64250: [ARM] Relax constraints on operands of VQxDMLxDH instructions: SjoerdMeijer, samparker.
Fri, Jul 5, 8:11 AM · Restricted Project
miyuki added a comment to D58332: Erase-Like Algorithms Should Return size_type (P0646R1).

Shouldn't the type change be guarded with a conditional compilation construct? I could write

std::list<int> l
assert(typeid(void) == typeid(l.unique()));

and expect this assertion to pass when compiling with, say, -std=c++98.

Fri, Jul 5, 8:04 AM
miyuki created D64250: [ARM] Relax constraints on operands of VQxDMLxDH instructions.
Fri, Jul 5, 7:44 AM · Restricted Project

Thu, Jul 4

miyuki added a comment to D64105: libc++: add _LIBCPP_HAS_NO_LONG_DOUBLE.

We have a similar problem with our port of libc++ and we also had to conditionalize all uses of long double downstream. Here is a list of files that we had to change: https://pastebin.com/5tTcSYxW
As you see, most of them are tests.
Another problem with long double is that it is used in a couple of places not strictly requiring it (include/locale, include/__mutex_base and include/thread), in those cases we introduced a _LIBCPP_LONGEST_DOUBLE macro which is defined to either double or long double depending on the availability of the latter.

Thu, Jul 4, 3:38 AM

Mon, Jul 1

miyuki committed rG8b2e304bc57c: [ARM] Fix MVE_VQxDMLxDH instruction class (authored by miyuki).
[ARM] Fix MVE_VQxDMLxDH instruction class
Mon, Jul 1, 9:09 AM
miyuki committed rL364796: [ARM] Fix MVE_VQxDMLxDH instruction class.
[ARM] Fix MVE_VQxDMLxDH instruction class
Mon, Jul 1, 9:08 AM
miyuki closed D64007: [ARM] Fix MVE_VQxDMLxDH instruction class.
Mon, Jul 1, 9:07 AM · Restricted Project
miyuki committed rG4a9e3f15bbb2: [ARM] MVE: support QQPRRegClass and QQQQPRRegClass (authored by miyuki).
[ARM] MVE: support QQPRRegClass and QQQQPRRegClass
Mon, Jul 1, 9:07 AM
miyuki committed rL364794: [ARM] MVE: support QQPRRegClass and QQQQPRRegClass.
[ARM] MVE: support QQPRRegClass and QQQQPRRegClass
Mon, Jul 1, 9:07 AM
miyuki closed D64009: [ARM] MVE: support QQPRRegClass and QQQQPRRegClass.
Mon, Jul 1, 9:07 AM · Restricted Project
miyuki updated the diff for D64009: [ARM] MVE: support QQPRRegClass and QQQQPRRegClass.

Fix a comment

Mon, Jul 1, 9:02 AM · Restricted Project
miyuki created D64009: [ARM] MVE: support QQPRRegClass and QQQQPRRegClass.
Mon, Jul 1, 7:08 AM · Restricted Project
miyuki created D64007: [ARM] Fix MVE_VQxDMLxDH instruction class.
Mon, Jul 1, 6:37 AM · Restricted Project

Thu, Jun 27

miyuki abandoned D63827: [ARM] Allow MVE loads and stores of v2f64.

Subsumed by: https://reviews.llvm.org/D63838

Thu, Jun 27, 8:17 AM · Restricted Project
miyuki accepted D63865: [ARM] Fix bogus assertions in copyPhysReg v8.1-M cases..

LGTM

Thu, Jun 27, 3:01 AM · Restricted Project

Wed, Jun 26

miyuki updated the diff for D63827: [ARM] Allow MVE loads and stores of v2f64.

Added a test which uses <2 x double>. Alignment issue should be fixed separately, IMHO.

Wed, Jun 26, 9:59 AM · Restricted Project
miyuki added inline comments to D63827: [ARM] Allow MVE loads and stores of v2f64.
Wed, Jun 26, 9:45 AM · Restricted Project
miyuki created D63827: [ARM] Allow MVE loads and stores of v2f64.
Wed, Jun 26, 8:43 AM · Restricted Project
miyuki committed rG6dcbb3161e35: [ARM] Handle fixup_arm_pcrel_9 correctly on big-endian targets (authored by miyuki).
[ARM] Handle fixup_arm_pcrel_9 correctly on big-endian targets
Wed, Jun 26, 3:51 AM
miyuki committed rL364404: [ARM] Handle fixup_arm_pcrel_9 correctly on big-endian targets.
[ARM] Handle fixup_arm_pcrel_9 correctly on big-endian targets
Wed, Jun 26, 3:50 AM
miyuki closed D63778: [ARM] Handle fixup_arm_pcrel_9 correctly on big-endian targets.
Wed, Jun 26, 3:50 AM · Restricted Project

Tue, Jun 25

miyuki created D63778: [ARM] Handle fixup_arm_pcrel_9 correctly on big-endian targets.
Tue, Jun 25, 10:23 AM · Restricted Project

Jun 21 2019

miyuki committed rGcfdc7f0d7e25: [libc++] Avoid using timespec when it might not be available (authored by miyuki).
[libc++] Avoid using timespec when it might not be available
Jun 21 2019, 1:31 AM
miyuki committed rL364012: [libc++] Avoid using timespec when it might not be available.
[libc++] Avoid using timespec when it might not be available
Jun 21 2019, 1:30 AM
miyuki closed D63328: [libc++] Avoid using timespec when it might not be available.
Jun 21 2019, 1:30 AM · Restricted Project, Restricted Project

Jun 19 2019

miyuki added a comment to D63328: [libc++] Avoid using timespec when it might not be available.

We maintain such library for an embedded toolchain. Besides, only C++17 and later versions are based on C11.

Jun 19 2019, 2:08 AM · Restricted Project, Restricted Project

Jun 18 2019

miyuki committed rGa45292cbfd24: [CodeGen][ARM] Fix FP16 vector coercion (authored by miyuki).
[CodeGen][ARM] Fix FP16 vector coercion
Jun 18 2019, 7:35 AM
miyuki committed rL363687: [CodeGen][ARM] Fix FP16 vector coercion.
[CodeGen][ARM] Fix FP16 vector coercion
Jun 18 2019, 7:35 AM
miyuki closed D63437: [CodeGen][ARM] Fix FP16 vector coercion.
Jun 18 2019, 7:35 AM · Restricted Project, Restricted Project
miyuki added a comment to D63328: [libc++] Avoid using timespec when it might not be available.

__libcpp_condvar_timedwait needs to be implemented in a different TU, so it can't be a template and at the same time it needs some sort of time point. I think timespec was chosen because it is what pthread_cond_timedwait expects. Do you think a specialization of chrono::time_point (like chrono::time_point<chrono::system_clock, chrono::nanoseconds> used by condition_variable::__do_timed_wait) would make more sense here?

Jun 18 2019, 2:43 AM · Restricted Project, Restricted Project

Jun 17 2019

miyuki added a comment to D63437: [CodeGen][ARM] Fix FP16 vector coercion.

This doesn't look like the right pace to fix this - the backend can handle vectors of i8 and i16, which are also not legal types, so why can't it correctly handle vectors of f16?

Jun 17 2019, 9:12 AM · Restricted Project, Restricted Project
miyuki updated subscribers of D63437: [CodeGen][ARM] Fix FP16 vector coercion.
Jun 17 2019, 8:49 AM · Restricted Project, Restricted Project
miyuki created D63437: [CodeGen][ARM] Fix FP16 vector coercion.
Jun 17 2019, 8:46 AM · Restricted Project, Restricted Project
miyuki committed rGd5323f6a707e: [libunwind][AArch64] Fix libunwind::Registers_arm64::jumpto (authored by miyuki).
[libunwind][AArch64] Fix libunwind::Registers_arm64::jumpto
Jun 17 2019, 3:58 AM
miyuki committed rL363545: [libunwind][AArch64] Fix libunwind::Registers_arm64::jumpto.
[libunwind][AArch64] Fix libunwind::Registers_arm64::jumpto
Jun 17 2019, 3:57 AM
miyuki closed D63006: [libunwind][AArch64] Fix libunwind::Registers_arm64::jumpto.
Jun 17 2019, 3:57 AM · Restricted Project, Restricted Project

Jun 14 2019

miyuki committed rGd1cc2e1543e7: [ARM] Add MVE horizontal accumulation instructions (authored by miyuki).
[ARM] Add MVE horizontal accumulation instructions
Jun 14 2019, 7:29 AM
miyuki committed rL363403: [ARM] Add MVE horizontal accumulation instructions.
[ARM] Add MVE horizontal accumulation instructions
Jun 14 2019, 7:29 AM
miyuki closed D62670: [ARM] Add MVE horizontal accumulation instructions..
Jun 14 2019, 7:29 AM · Restricted Project
miyuki created D63328: [libc++] Avoid using timespec when it might not be available.
Jun 14 2019, 4:58 AM · Restricted Project, Restricted Project
miyuki committed rG411c630bae0e: [libc++] Keep __regex_word in sync with ctype_base (authored by miyuki).
[libc++] Keep __regex_word in sync with ctype_base
Jun 14 2019, 2:02 AM
miyuki committed rL363363: [libc++] Keep __regex_word in sync with ctype_base.
[libc++] Keep __regex_word in sync with ctype_base
Jun 14 2019, 2:01 AM
miyuki closed D63284: [libc++] Keep __regex_word in sync with ctype_base.
Jun 14 2019, 2:01 AM · Restricted Project, Restricted Project

Jun 13 2019

miyuki created D63289: [libc++] Add missing #include in tests.
Jun 13 2019, 10:45 AM · Restricted Project, Restricted Project
miyuki created D63284: [libc++] Keep __regex_word in sync with ctype_base.
Jun 13 2019, 10:16 AM · Restricted Project, Restricted Project
miyuki updated the diff for D62670: [ARM] Add MVE horizontal accumulation instructions..
  • Rebase
  • Avoid TableGen logic in instruction operands and constraints
Jun 13 2019, 8:15 AM · Restricted Project
miyuki added inline comments to D62670: [ARM] Add MVE horizontal accumulation instructions..
Jun 13 2019, 5:52 AM · Restricted Project

Jun 12 2019

miyuki added inline comments to D62671: [ARM] Add MVE integer vector min/max instructions..
Jun 12 2019, 8:57 AM · Restricted Project
miyuki updated the diff for D62670: [ARM] Add MVE horizontal accumulation instructions..
  • Fixed naming inconsistencies
  • Removed comments about undefined instructions
  • Factored out common parts of:
    • VMINV and VMAXV
    • VMINNMV and VMAXNMV
    • VMLADAV and VMLSDAV
    • VMLALDAV, VMLSLDAV (includes VRMLSLDAVH) and VRMLALDAVH
  • Fixed inputs and constraints of non-accumulating instructions
  • Split the assembler test into integer and floating point parts
Jun 12 2019, 6:17 AM · Restricted Project
miyuki commandeered D62670: [ARM] Add MVE horizontal accumulation instructions..
Jun 12 2019, 6:04 AM · Restricted Project

Jun 11 2019

miyuki added inline comments to D62670: [ARM] Add MVE horizontal accumulation instructions..
Jun 11 2019, 10:32 AM · Restricted Project
miyuki added inline comments to D62669: [ARM] Set up infrastructure for MVE vector instructions..
Jun 11 2019, 6:06 AM · Restricted Project
miyuki committed rG7bd5c55cadc9: [ARM] First MVE instructions: scalar shifts. (authored by miyuki).
[ARM] First MVE instructions: scalar shifts.
Jun 11 2019, 5:04 AM
miyuki committed rL363051: [ARM] First MVE instructions: scalar shifts..
[ARM] First MVE instructions: scalar shifts.
Jun 11 2019, 5:01 AM
miyuki closed D62668: [ARM] First MVE instructions: scalar shifts..
Jun 11 2019, 5:01 AM · Restricted Project
miyuki set the repository for D62668: [ARM] First MVE instructions: scalar shifts. to rG LLVM Github Monorepo.
Jun 11 2019, 4:53 AM · Restricted Project
miyuki updated the diff for D62668: [ARM] First MVE instructions: scalar shifts..
Jun 11 2019, 3:39 AM · Restricted Project
miyuki updated the diff for D62668: [ARM] First MVE instructions: scalar shifts..

Fixed the tablegen file and tests according to reviewer's comments. Added missing cases to ARMRegisterBankInfo.cpp

Jun 11 2019, 2:51 AM · Restricted Project
miyuki commandeered D62668: [ARM] First MVE instructions: scalar shifts..
Jun 11 2019, 2:48 AM · Restricted Project

Jun 7 2019

miyuki added inline comments to D62667: [ARM] Add the non-MVE instructions in Arm v8.1-M..
Jun 7 2019, 10:58 AM · Restricted Project
miyuki created D63006: [libunwind][AArch64] Fix libunwind::Registers_arm64::jumpto.
Jun 7 2019, 7:18 AM · Restricted Project, Restricted Project

Jun 4 2019

miyuki added a comment to D62651: [ARM] Add FP16 vector insert/extract patterns.

LGTM

We could possibly use a custom inserter to generate the vins sequence, but it would probably involve some benchmarking to make sure there aren't any unexpected performance penalties due to the weird register usage. So I'm happy to put that off for now.

(On a side-note, I think you can insert a float into element zero of a vector with two vext instructions, which is the same number of instructions, but maybe lower latency.)

Jun 4 2019, 2:56 AM · Restricted Project
miyuki committed rG08da01b49648: [ARM] Add FP16 vector insert/extract patterns (authored by miyuki).
[ARM] Add FP16 vector insert/extract patterns
Jun 4 2019, 2:38 AM
miyuki committed rL362482: [ARM] Add FP16 vector insert/extract patterns.
[ARM] Add FP16 vector insert/extract patterns
Jun 4 2019, 2:37 AM
miyuki closed D62651: [ARM] Add FP16 vector insert/extract patterns.
Jun 4 2019, 2:37 AM · Restricted Project

May 31 2019

miyuki updated the diff for D62651: [ARM] Add FP16 vector insert/extract patterns.

Changed extraction patterns to avoid using GPRs as intermediate registers.

May 31 2019, 3:55 AM · Restricted Project

May 30 2019

miyuki created D62651: [ARM] Add FP16 vector insert/extract patterns.
May 30 2019, 4:42 AM · Restricted Project

May 10 2019

miyuki added a comment to D51329: [Attribute/Diagnostics] Print macro if definition is an attribute declaration.

This caused https://bugs.llvm.org/show_bug.cgi?id=41835

May 10 2019, 9:47 AM · Restricted Project

Feb 26 2019

miyuki added inline comments to D57335: [IR] Don't assume all functions are 4 byte aligned.
Feb 26 2019, 2:04 AM · Restricted Project, Restricted Project

Feb 19 2019

miyuki added inline comments to D57896: Variable names rule.
Feb 19 2019, 3:43 AM · Restricted Project, Restricted Project

Oct 24 2018

miyuki committed rL345148: Adjust unsupported C++ versions in some tests.
Adjust unsupported C++ versions in some tests
Oct 24 2018, 8:12 AM
miyuki committed rCXX345148: Adjust unsupported C++ versions in some tests.
Adjust unsupported C++ versions in some tests
Oct 24 2018, 8:12 AM