Page MenuHomePhabricator
Feed Advanced Search

Yesterday

miyuki updated the diff for D69844: [clang][Basic] Integrate SourceLocation with FoldingSet, NFCI.

Fixed linter errors.

Fri, Oct 23, 3:44 AM · Restricted Project

Thu, Oct 22

miyuki updated the diff for D69844: [clang][Basic] Integrate SourceLocation with FoldingSet, NFCI.

Reverted accidentally removed chunk.

Thu, Oct 22, 11:10 AM · Restricted Project
miyuki updated the diff for D69844: [clang][Basic] Integrate SourceLocation with FoldingSet, NFCI.

Addressed review comments

Thu, Oct 22, 11:02 AM · Restricted Project

Tue, Oct 20

miyuki added a comment to D69903: [Basic] Introduce PODSourceLocation, NFCI.

An alternative would be to update the unions to an AlignedCharArrayUnion and use SourceLocation directly. WDYT?

Tue, Oct 20, 9:13 AM · Restricted Project
miyuki committed rG781941183700: [clang] Use SourceLocation as key in hash maps, NFCI (authored by miyuki).
[clang] Use SourceLocation as key in hash maps, NFCI
Tue, Oct 20, 8:25 AM
miyuki closed D69840: [clang] Use SourceLocation as key in hash maps, NFCI.
Tue, Oct 20, 8:24 AM · Restricted Project
miyuki committed rG234c47ae2a8e: [clang][Basic] Make SourceLocation usable as key in hash maps, NFCI (authored by miyuki).
[clang][Basic] Make SourceLocation usable as key in hash maps, NFCI
Tue, Oct 20, 7:53 AM
miyuki closed D89719: [clang][Basic] Make SourceLocation usable as key in hash maps, NFCI.
Tue, Oct 20, 7:53 AM · Restricted Project
miyuki added a comment to D89719: [clang][Basic] Make SourceLocation usable as key in hash maps, NFCI.

The build failure is unrelated (see D89463)

Tue, Oct 20, 7:52 AM · Restricted Project
miyuki updated the diff for D89719: [clang][Basic] Make SourceLocation usable as key in hash maps, NFCI.

Added an example of usage.

Tue, Oct 20, 5:11 AM · Restricted Project

Mon, Oct 19

miyuki updated the diff for D69840: [clang] Use SourceLocation as key in hash maps, NFCI.

Split out the refactoring part.

Mon, Oct 19, 12:19 PM · Restricted Project
miyuki retitled D69840: [clang] Use SourceLocation as key in hash maps, NFCI from [Basic] Make SourceLocation usable as key in hash maps, NFCI to [clang] Use SourceLocation as key in hash maps, NFCI.
Mon, Oct 19, 11:42 AM · Restricted Project
miyuki requested review of D89719: [clang][Basic] Make SourceLocation usable as key in hash maps, NFCI.
Mon, Oct 19, 11:31 AM · Restricted Project
miyuki committed rGa3c16039b3f1: [clang] Use SourceLocation as key in std::map, NFCI (authored by miyuki).
[clang] Use SourceLocation as key in std::map, NFCI
Mon, Oct 19, 10:31 AM
miyuki closed D89705: [clang] Use SourceLocation as key in std::map, NFCI.
Mon, Oct 19, 10:31 AM · Restricted Project
miyuki added a comment to D69840: [clang] Use SourceLocation as key in hash maps, NFCI.

Yes, I am still interested in working on this. For now, I've split out some changes that don't require any modifications in SourceLocation into https://reviews.llvm.org/D89705.

A general comment is that there are a couple of functional changes in this patch, where hash values are changing and data structures are being changed, but they're buried in the noise of the refactoring that's going on at the same time. I suggest splitting this up at least into two

Will do.

Mon, Oct 19, 8:40 AM · Restricted Project
miyuki requested review of D89705: [clang] Use SourceLocation as key in std::map, NFCI.
Mon, Oct 19, 8:36 AM · Restricted Project

Thu, Oct 1

miyuki added a comment to D86704: [libcxx] Add testing infrastructure for EXTERNAL_THREAD_API mode.

Customization allows storing data of OS structures such as mutexes and threads in-place, thus avoiding the need for additional dynamic memory allocations, this is important in embedded environments.

Thu, Oct 1, 5:50 AM · Restricted Project

Wed, Sep 30

miyuki added a comment to D86704: [libcxx] Add testing infrastructure for EXTERNAL_THREAD_API mode.

Given this new setup where build bots are checked into the repo, I think adding a bot that test this configuration would be a good way of making sure this doesn't regress. What do you think?

Yes, setting up a build bot is part of my original plan. I will be on holiday for the next two weeks, but I do plan to continue working on this after returning.

Is there a reason why your platform can't simply provide the pthread or the C11 threading APIs, and libc++ has to provide this bridge instead?

The original intent of the external threading API was to make it usable with bare-metal real-time OS-es which tend not to have POSIX or POSIX-like APIs. For example, __libcpp_mutex_t can include the OS structure representing a mutex, instead of allocating it elsewhere.

Wed, Sep 30, 9:10 AM · Restricted Project

Tue, Sep 29

miyuki added a comment to D86704: [libcxx] Add testing infrastructure for EXTERNAL_THREAD_API mode.

@ldionne, do you have any thoughts on how we might progress this forward?

Tue, Sep 29, 10:58 AM · Restricted Project
miyuki commandeered D86704: [libcxx] Add testing infrastructure for EXTERNAL_THREAD_API mode.
Tue, Sep 29, 10:57 AM · Restricted Project

Mon, Sep 28

miyuki committed rG07b7a24e3fe8: [unittests] Preserve LD_LIBRARY_PATH in crash recovery test (authored by miyuki).
[unittests] Preserve LD_LIBRARY_PATH in crash recovery test
Mon, Sep 28, 9:46 AM
miyuki closed D88308: [unittests] Preserve LD_LIBRARY_PATH in crash recovery test.
Mon, Sep 28, 9:46 AM · Restricted Project
miyuki added inline comments to D88308: [unittests] Preserve LD_LIBRARY_PATH in crash recovery test.
Mon, Sep 28, 9:37 AM · Restricted Project
miyuki updated the diff for D88308: [unittests] Preserve LD_LIBRARY_PATH in crash recovery test.

Use setenv in the parent process

Mon, Sep 28, 9:37 AM · Restricted Project

Fri, Sep 25

miyuki added a comment to D88308: [unittests] Preserve LD_LIBRARY_PATH in crash recovery test.

In our case, the child process fails to find the correct version of libstdc++ and exits with return code 1, ASSERT_EQ(-2, RetCode) fails.

Fri, Sep 25, 8:28 AM · Restricted Project
miyuki requested review of D88308: [unittests] Preserve LD_LIBRARY_PATH in crash recovery test.
Fri, Sep 25, 8:07 AM · Restricted Project

Sep 24 2020

miyuki committed rG8cc842a95072: [clang][Sema] Use enumerator instead of hard-coded constant (authored by miyuki).
[clang][Sema] Use enumerator instead of hard-coded constant
Sep 24 2020, 2:24 AM
miyuki closed D88164: [clang][Sema] Use enumerator instead of hard-coded constant.
Sep 24 2020, 2:24 AM · Restricted Project

Sep 23 2020

miyuki requested review of D88164: [clang][Sema] Use enumerator instead of hard-coded constant.
Sep 23 2020, 9:51 AM · Restricted Project

Sep 11 2020

miyuki added a comment to rGfc4bff0cd37f: Update atomic feature macros, synopsis, signatures to match C++20. Improve test….

Thanks!

Sep 11 2020, 10:17 AM
miyuki closed D87508: [libcxx] Handle target triples with dashes in platform name.
Sep 11 2020, 7:41 AM · Restricted Project
miyuki added a comment to rGfc4bff0cd37f: Update atomic feature macros, synopsis, signatures to match C++20. Improve test….

Hi Olivier,
Prior versions of the C++ standard (11, 14, 17) required more specialized templates for atomic_fetch_{add,sub}[_explicit] for pointers. E.g.:

template <class T>
T atomic_fetch_add(atomic<T>*, T) noexcept;
template <class T>
T* atomic_fetch_add(atomic<T*>*, ptrdiff_t) noexcept;

Implementing them as a single template breaks the following code (when compiled as C++17):

#include <atomic>
Sep 11 2020, 7:24 AM
miyuki requested review of D87508: [libcxx] Handle target triples with dashes in platform name.
Sep 11 2020, 4:47 AM · Restricted Project

Sep 1 2020

miyuki added a comment to D86598: [libcxx] Fix compile for BUILD_EXTERNAL_THREAD_LIBRARY.

I've just committed D86773

Sep 1 2020, 4:48 AM · Restricted Project
miyuki committed rG722db5c0b4e8: [libcxx] Link target `cxx_external_threads` to `cxx-headers` for… (authored by Nicu).
[libcxx] Link target `cxx_external_threads` to `cxx-headers` for…
Sep 1 2020, 4:44 AM
miyuki closed D86773: [libcxx] Link target `cxx_external_threads` to `cxx-headers` for BUILD_EXTERNAL_THREAD_LIBRARY.
Sep 1 2020, 4:44 AM · Restricted Project

Aug 28 2020

miyuki added a comment to D86598: [libcxx] Fix compile for BUILD_EXTERNAL_THREAD_LIBRARY.

Thanks!

Aug 28 2020, 3:20 AM · Restricted Project

Aug 27 2020

miyuki committed rG433f2680c979: [ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics (authored by miyuki).
[ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics
Aug 27 2020, 10:55 AM
miyuki committed rGae1396c7d4d8: [ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics (authored by miyuki).
[ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics
Aug 27 2020, 10:44 AM
miyuki closed D86146: [ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics.
Aug 27 2020, 10:44 AM · Restricted Project, Restricted Project
miyuki updated the diff for D86146: [ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics.

Small refactoring of bitcode updater tests (use some-name.ll.bc names for bitcode files in order to be able to refer to them as %s.bc from some-name.ll)

Aug 27 2020, 9:50 AM · Restricted Project, Restricted Project
miyuki added inline comments to D86146: [ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics.
Aug 27 2020, 9:09 AM · Restricted Project, Restricted Project
miyuki added a comment to D86598: [libcxx] Fix compile for BUILD_EXTERNAL_THREAD_LIBRARY.

Sorry about that. I've reverted the change and will investigate.

Aug 27 2020, 8:49 AM · Restricted Project
miyuki added a reverting change for rG3b71f91558ff: [libcxx] Fix compile for BUILD_EXTERNAL_THREAD_LIBRARY: rGa19fd1aab519: Revert "[libcxx] Fix compile for BUILD_EXTERNAL_THREAD_LIBRARY".
Aug 27 2020, 8:49 AM
miyuki committed rGa19fd1aab519: Revert "[libcxx] Fix compile for BUILD_EXTERNAL_THREAD_LIBRARY" (authored by miyuki).
Revert "[libcxx] Fix compile for BUILD_EXTERNAL_THREAD_LIBRARY"
Aug 27 2020, 8:48 AM
miyuki added a reverting change for D86598: [libcxx] Fix compile for BUILD_EXTERNAL_THREAD_LIBRARY: rGa19fd1aab519: Revert "[libcxx] Fix compile for BUILD_EXTERNAL_THREAD_LIBRARY".
Aug 27 2020, 8:48 AM · Restricted Project
miyuki committed rG3b71f91558ff: [libcxx] Fix compile for BUILD_EXTERNAL_THREAD_LIBRARY (authored by Nicu).
[libcxx] Fix compile for BUILD_EXTERNAL_THREAD_LIBRARY
Aug 27 2020, 8:25 AM
miyuki closed D86598: [libcxx] Fix compile for BUILD_EXTERNAL_THREAD_LIBRARY.
Aug 27 2020, 8:25 AM · Restricted Project
miyuki added inline comments to D86704: [libcxx] Add testing infrastructure for EXTERNAL_THREAD_API mode.
Aug 27 2020, 8:20 AM · Restricted Project
miyuki committed rG23d5e93f342e: [AArch64] Optimize instruction selection for certain vector shuffles (authored by miyuki).
[AArch64] Optimize instruction selection for certain vector shuffles
Aug 27 2020, 3:07 AM
miyuki closed D86225: [AArch64] Optimize instruction selection for certain vector shuffles.
Aug 27 2020, 3:07 AM · Restricted Project

Aug 26 2020

miyuki updated the diff for D86146: [ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics.
  1. Also update bfdot
  2. Add auto-upgrade for old intrinsics
Aug 26 2020, 12:11 PM · Restricted Project, Restricted Project
miyuki updated the diff for D86225: [AArch64] Optimize instruction selection for certain vector shuffles.

Cast to the correct type

Aug 26 2020, 11:13 AM · Restricted Project
miyuki added a reviewer for D86599: [libcxx] Add cmake cache file for BUILD_EXTERNAL_THREAD_LIBRARY: miyuki.
Aug 26 2020, 5:56 AM · Restricted Project
miyuki added a reviewer for D86599: [libcxx] Add cmake cache file for BUILD_EXTERNAL_THREAD_LIBRARY: ldionne.
Aug 26 2020, 5:55 AM · Restricted Project
miyuki added inline comments to D86598: [libcxx] Fix compile for BUILD_EXTERNAL_THREAD_LIBRARY.
Aug 26 2020, 5:54 AM · Restricted Project
miyuki added reviewers for D86598: [libcxx] Fix compile for BUILD_EXTERNAL_THREAD_LIBRARY: ldionne, miyuki.
Aug 26 2020, 5:51 AM · Restricted Project

Aug 21 2020

miyuki abandoned D41179: [Sema] Diagnose template specializations with C linkage.

Abandoning in favour of:

Aug 21 2020, 2:13 AM

Aug 20 2020

miyuki updated the diff for D86225: [AArch64] Optimize instruction selection for certain vector shuffles.
  1. Addressed review comments
  2. Added a cast back to the original type
Aug 20 2020, 10:05 AM · Restricted Project
miyuki updated the diff for D86146: [ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics.

Keep the second vbfmlaltq_laneq_f32 test

Aug 20 2020, 3:12 AM · Restricted Project, Restricted Project
miyuki added a comment to D86146: [ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics.

Do we need to upgrade the old bfmmla to the new signatures?

Aug 20 2020, 3:08 AM · Restricted Project, Restricted Project

Aug 19 2020

miyuki added reviewers for D86146: [ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics: momchil.velikov, MarkMurrayARM.
Aug 19 2020, 10:00 AM · Restricted Project, Restricted Project
miyuki requested review of D86225: [AArch64] Optimize instruction selection for certain vector shuffles.
Aug 19 2020, 9:41 AM · Restricted Project

Aug 18 2020

miyuki requested review of D86146: [ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics.
Aug 18 2020, 9:17 AM · Restricted Project, Restricted Project

Aug 12 2020

miyuki added a comment to D85118: [clang][AArch64] Correct return type of Neon vqmovun intrinsics.

For intrinsics that are plain functions (not macros) you could just check the signatures using assignments to function pointers, e.g.:

Aug 12 2020, 10:01 AM · Restricted Project

Jul 31 2020

miyuki accepted D85010: [clang][ARM] Add name-mangling test for direct __fp16 arguments..

The mangling agrees with https://itanium-cxx-abi.github.io/cxx-abi/abi.html#mangling-builtin
LGTM

Jul 31 2020, 9:02 AM · Restricted Project

Jul 23 2020

miyuki closed D84394: [libcxx] Adjust trivial_abi tests for C++03 and C++11 testing.
Jul 23 2020, 6:21 AM · Restricted Project
miyuki committed rG2b89c34784fa: [libcxx] Adjust trivial_abi tests for C++03 and C++11 testing (authored by miyuki).
[libcxx] Adjust trivial_abi tests for C++03 and C++11 testing
Jul 23 2020, 6:21 AM
miyuki updated the summary of D84394: [libcxx] Adjust trivial_abi tests for C++03 and C++11 testing.
Jul 23 2020, 4:59 AM · Restricted Project
Herald added a reviewer for D84394: [libcxx] Adjust trivial_abi tests for C++03 and C++11 testing: Restricted Project.
Jul 23 2020, 4:58 AM · Restricted Project

Jul 14 2020

miyuki added a comment to D83055: [clang][Driver] Fix tool path priority test failures.

I have reproduced the type 1 failure and I confirm that this patch fixes the issue.

Jul 14 2020, 9:50 AM · Restricted Project

Jul 7 2020

miyuki accepted D83231: [CodeGen] Don't combine extract + concat vectors with non-legal types.

LGTM. Please wait until Friday before committing, so that others have a chance to share their objections.

Jul 7 2020, 4:23 AM · Restricted Project

Jul 6 2020

miyuki added inline comments to D83206: [PATCH] [ARM] Add Cortex-A78 and Cortex-X1 Support for Clang and LLVM.
Jul 6 2020, 3:50 AM · Restricted Project, Restricted Project

Jun 23 2020

miyuki committed rG3f353a2e5a98: [BFloat] Add convert/copy instrinsic support (authored by miyuki).
[BFloat] Add convert/copy instrinsic support
Jun 23 2020, 7:59 AM
miyuki closed D80928: [BFloat] Add convert/copy instrinsic support.
Jun 23 2020, 7:59 AM · Restricted Project, Restricted Project
miyuki committed rG9c579540ff69: [ARM] BFloat MatMul Intrinsics&CodeGen (authored by miyuki).
[ARM] BFloat MatMul Intrinsics&CodeGen
Jun 23 2020, 5:18 AM
miyuki closed D81740: [ARM] BFloat MatMul Intrinsics&CodeGen.
Jun 23 2020, 5:17 AM · Restricted Project, Restricted Project
miyuki added reviewers for D81740: [ARM] BFloat MatMul Intrinsics&CodeGen: simon_tatham, dmgreen.
Jun 23 2020, 4:12 AM · Restricted Project, Restricted Project
miyuki updated the diff for D81740: [ARM] BFloat MatMul Intrinsics&CodeGen.

Addressed the review comments

Jun 23 2020, 4:12 AM · Restricted Project, Restricted Project
miyuki set the repository for D81740: [ARM] BFloat MatMul Intrinsics&CodeGen to rG LLVM Github Monorepo.
Jun 23 2020, 4:12 AM · Restricted Project, Restricted Project

Jun 22 2020

miyuki committed rG3a4feb1d53df: [ARM][BFloat] Implement bf16 get/set_lane without casts to i16 vectors (authored by miyuki).
[ARM][BFloat] Implement bf16 get/set_lane without casts to i16 vectors
Jun 22 2020, 10:46 AM
miyuki closed D82206: [ARM][BFloat] Implement bf16 get/set_lane without casts to i16 vectors.
Jun 22 2020, 10:46 AM · Restricted Project
miyuki commandeered D81740: [ARM] BFloat MatMul Intrinsics&CodeGen.
Jun 22 2020, 7:30 AM · Restricted Project, Restricted Project
miyuki added inline comments to D80928: [BFloat] Add convert/copy instrinsic support.
Jun 22 2020, 6:57 AM · Restricted Project, Restricted Project
miyuki updated the diff for D80928: [BFloat] Add convert/copy instrinsic support.
  1. Rebased and fixed failures
  2. Added a test for AArch64 codegen of lane copying intrinsics
  3. Addressed reviewers' comments
Jun 22 2020, 6:57 AM · Restricted Project, Restricted Project

Jun 19 2020

miyuki created D82206: [ARM][BFloat] Implement bf16 get/set_lane without casts to i16 vectors.
Jun 19 2020, 10:19 AM · Restricted Project
miyuki committed rG490f78c03884: [ARM][BFloat] Implement lowering of bf16 load/store intrinsics (authored by miyuki).
[ARM][BFloat] Implement lowering of bf16 load/store intrinsics
Jun 19 2020, 7:33 AM
miyuki closed D81486: [ARM][BFloat] Implement lowering of bf16 load/store intrinsics.
Jun 19 2020, 7:33 AM · Restricted Project
miyuki updated the diff for D81486: [ARM][BFloat] Implement lowering of bf16 load/store intrinsics.

Workaround the dependency of bf16 on fullfp16

Jun 19 2020, 7:00 AM · Restricted Project
miyuki committed rG75268812464f: [ARM][BFloat] Lowering of create/get/set/dup intrinsics (authored by miyuki).
[ARM][BFloat] Lowering of create/get/set/dup intrinsics
Jun 19 2020, 5:55 AM
miyuki closed D81411: [ARM][BFloat] Lowering of create/get/set/dup intrinsics.
Jun 19 2020, 5:54 AM · Restricted Project
miyuki updated the diff for D81411: [ARM][BFloat] Lowering of create/get/set/dup intrinsics.

Rebased. Added a workaround for bf16 arguments and returns (lowering currently works only with +fullfp16).

Jun 19 2020, 5:53 AM · Restricted Project

Jun 17 2020

miyuki commandeered D80928: [BFloat] Add convert/copy instrinsic support.
Jun 17 2020, 8:03 AM · Restricted Project, Restricted Project

Jun 15 2020

miyuki added inline comments to D81740: [ARM] BFloat MatMul Intrinsics&CodeGen.
Jun 15 2020, 5:56 AM · Restricted Project, Restricted Project

Jun 10 2020

miyuki added a comment to D81559: [libcxx] Fix std::vector construct_iter_iter.pass.cpp test (C++98/03).

Do we need to reenable the test somewhere?

My understanding is that it was never disabled, it just started failing with a recent compiler. @miyuki is that correct?

Jun 10 2020, 7:37 AM · Restricted Project
miyuki committed rG4e94bdceb0f9: [libcxx] Fix std::vector construct_iter_iter.pass.cpp test (C++98/03) (authored by miyuki).
[libcxx] Fix std::vector construct_iter_iter.pass.cpp test (C++98/03)
Jun 10 2020, 6:35 AM
miyuki closed D81559: [libcxx] Fix std::vector construct_iter_iter.pass.cpp test (C++98/03).
Jun 10 2020, 6:35 AM · Restricted Project
miyuki created D81559: [libcxx] Fix std::vector construct_iter_iter.pass.cpp test (C++98/03).
Jun 10 2020, 5:58 AM · Restricted Project

Jun 9 2020

miyuki created D81486: [ARM][BFloat] Implement lowering of bf16 load/store intrinsics.
Jun 9 2020, 10:58 AM · Restricted Project