Page MenuHomePhabricator
Feed Advanced Search

Today

steakhal added inline comments to D113753: [Analyzer][Core] Better simplification in SimpleSValBuilder::evalBinOpNN.
Thu, Dec 2, 2:24 PM · Restricted Project
steakhal added a comment to D114454: [CSA]Skip unstable CSA tests failing on several platforms.

Ah, please retitle this to have the [analyzer] tag. I think we dont use the CSA tag or any other.

Thu, Dec 2, 12:37 PM · Restricted Project
steakhal accepted D114454: [CSA]Skip unstable CSA tests failing on several platforms.

I think it looks good. Sorry for the delay.
I'll fix the test later, to pass on all targets :)
Thanks again for making it support multiple triples.

Thu, Dec 2, 12:36 PM · Restricted Project
steakhal added a comment to D114887: [Analyzer][solver] Simplification: Do a fixpoint iteration before the eq class merge.

Also, please provide the coverage of the new test case (only excercising the new test case not the whole test file) I really want to make sure that it will cover the loop as it supposed to.

Oh, I just now see that there is no test. Now I'm really courious.

There is a test case in D103317 (with the so many bs) which covers the loop. That patch is the dependent patch of the reverted patch.

Thu, Dec 2, 6:30 AM · Restricted Project
steakhal added a comment to D114938: [Analyzer] SValBuilder: Simlify a SymExpr to the absolute simplest form.

I don't think there is any time concern with this patch. It's NFC. You should retitle accordingly.

Thu, Dec 2, 6:25 AM · Restricted Project

Yesterday

steakhal added a comment to D114887: [Analyzer][solver] Simplification: Do a fixpoint iteration before the eq class merge.

Also, please provide the coverage of the new test case (only excercising the new test case not the whole test file) I really want to make sure that it will cover the loop as it supposed to.

Wed, Dec 1, 1:51 PM · Restricted Project
steakhal added a comment to D114887: [Analyzer][solver] Simplification: Do a fixpoint iteration before the eq class merge.

I think I'm in favor of this change. However, Im also slightly in favor of reverting stuff instead of rushing things. Let's hope it will resolve the issue of the previous offending commit.

Wed, Dec 1, 1:48 PM · Restricted Project
steakhal added a comment to D114454: [CSA]Skip unstable CSA tests failing on several platforms.

setting a bunch of target triples and letting gtest to run each one to see if it still passes on all triples.

Did you mean adding all the triples that we're interested in to allTestClangConfigs()? If so, do you have a list in mind? Sorry if this is a dumb question, I'm not very familiar with CSA and parameterized gtest.

Yes. I don't know any specific, but we could pick a couple of esoteric targets where integrals differ significantly from what we have on x86_64.
That said, I would test for i686-pc-windows-msvc, i686-apple-darwin9, x86_64-apple-darwin9, x86_64-scei-ps4, x86_64-windows-msvc, x86_64-unknown-linux, x86_64-apple-macosx, x86_64-apple-ios14.0, wasm32-unknown-unknown, wasm64-unknown-unknown, thumb-pc-win32, sparc64-none-openbsd, sparc-none-none, riscv64-unknown-linux, ppc64-windows-msvc, powerpc-ibm-aix, powerpc64-ibm-aix, s390x-ibm-zos, armv7-pc-windows-msvc, aarch64-pc-windows-msvc, xcore-xmos-elf.
Please note that I've just grepped for the triples and picked some interesting-sounding ones. I did nothing scientific. We could change this in the future.

Wed, Dec 1, 2:49 AM · Restricted Project

Tue, Nov 30

steakhal added a comment to D114510: [analyzer] Ignore flex generated files.

Since we already had some precedent, it looks good to me. But I still think it would be nicer to have these features outside of the analyzer in the future.

Tue, Nov 30, 6:40 AM
steakhal requested changes to D112621: [analyzer][solver] Introduce reasoning for not equal to operator.

I have made few changes:

  1. The failed assertions due to comparison between different types have been fixed by converting all the Ranges to a given type. This will allow comparisons without throwing errors.
  2. There was also a build error due to explicit specialization in non-namespace scope. This was fixed by @martong previously, but that patch led to the above mentioned bug. So I used @martong 's patch here to make GCC happy.
  3. I have added a small check for comparison between different types.

https://reviews.llvm.org/D106102 differential contains the background story.

Tue, Nov 30, 6:37 AM · Restricted Project
steakhal added a comment to D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file.

Looks good.
Please get rid of the macro stuff, consider something along the lines I proposed for the parsing stuff.
Also clang-format the code you touch.
I haven't checked the docs and the comments of the codebase, but I'll assume you grepped and fixed all occurrences.
I look forward to this, thank you for working on this @OikawaKirie.

Tue, Nov 30, 5:46 AM · Restricted Project

Mon, Nov 29

steakhal requested changes to D114706: [analyzer] Fix sensitive argument logic in GenericTaintChecker.

E.g. execl() and execlp functions are actually variadic. You should also account for them.
I would rather map directly to a full-fledged Propagation rule instead of to a sensitive arg index list. That way you could express this property.
Demonstrate this in a test.

Mon, Nov 29, 10:50 AM · Restricted Project
steakhal accepted D114619: [Analyzer][solver] Do not remove the simplified symbol from the eq class.

I think it looks great.

Mon, Nov 29, 9:04 AM · Restricted Project
steakhal accepted D103317: [Analyzer][Core] Make SValBuilder to better simplify svals with 3 symbols in the tree.

Still looks great.

Mon, Nov 29, 8:55 AM · Restricted Project
steakhal added inline comments to D114441: [analyzer][NFC] Refactor AnalysisConsumer::getModeForDecl().
Mon, Nov 29, 5:48 AM · Restricted Project
steakhal resigned from D91000: [clang-tidy] Add cert-msc24-c checker..

I've already reviewed this change offline, thus I resign. For me this looks great, I'm eager to hear your opinions!

Mon, Nov 29, 2:24 AM · Restricted Project, Restricted Project
steakhal committed rGaf37d4b6fee8: [analyzer][NFC] Refactor AnalysisConsumer::getModeForDecl() (authored by steakhal).
[analyzer][NFC] Refactor AnalysisConsumer::getModeForDecl()
Mon, Nov 29, 1:40 AM
steakhal closed D114441: [analyzer][NFC] Refactor AnalysisConsumer::getModeForDecl().
Mon, Nov 29, 1:39 AM · Restricted Project
steakhal committed rGa8120a771143: [clang-tidy] Ignore narrowing conversions in case of bitfields (authored by steakhal).
[clang-tidy] Ignore narrowing conversions in case of bitfields
Mon, Nov 29, 12:57 AM
steakhal committed rGe1d0673aeeec: [clang-tidy] Fix crashing altera-struct-pack-align on invalid RecordDecls (authored by steakhal).
[clang-tidy] Fix crashing altera-struct-pack-align on invalid RecordDecls
Mon, Nov 29, 12:57 AM
steakhal committed rG0540485436c4: [libtooling][clang-tidy] Fix crashing on rendering invalid SourceRanges (authored by steakhal).
[libtooling][clang-tidy] Fix crashing on rendering invalid SourceRanges
Mon, Nov 29, 12:57 AM
steakhal committed rG0685e83534ef: Fix cppcoreguidelines-virtual-base-class-destructor in macros (authored by steakhal).
Fix cppcoreguidelines-virtual-base-class-destructor in macros
Mon, Nov 29, 12:57 AM
steakhal closed D114105: [clang-tidy] Ignore narrowing conversions in case of bitfields.
Mon, Nov 29, 12:57 AM · Restricted Project
steakhal closed D114256: [clang-tidy] Fix crashing altera-struct-pack-align on invalid RecordDecls.
Mon, Nov 29, 12:57 AM · Restricted Project
steakhal closed D114254: [libtooling][clang-tidy] Fix crashing on rendering invalid SourceRanges.
Mon, Nov 29, 12:57 AM · Restricted Project
steakhal closed D113558: [clang-tidy] Fix cppcoreguidelines-virtual-base-class-destructor in macros.
Mon, Nov 29, 12:57 AM · Restricted Project

Fri, Nov 26

steakhal added a comment to D113753: [Analyzer][Core] Better simplification in SimpleSValBuilder::evalBinOpNN.

This seem to cause some weird results.

Given this input:

bar(short k) {
  k++;
  for (short f = 0; f < k; f++)
    ;
  (long)k << 16;
}

we get

> clang  --analyze --target=x86_64 'bbi-63538.c'
bbi-63538.c:5:11: warning: The result of the left shift is undefined due to shifting '1' by '16', which is unrepresentable in the unsigned version of the return type 'long' [core.UndefinedBinaryOperatorResult]
  (long)k << 16;
  ~~~~~~~ ^
bbi-63538.c:5:11: warning: The result of the left shift is undefined due to shifting '2' by '16', which is unrepresentable in the unsigned version of the return type 'long' [core.UndefinedBinaryOperatorResult]
  (long)k << 16;
  ~~~~~~~ ^
bbi-63538.c:5:11: warning: The result of the left shift is undefined due to shifting '3' by '16', which is unrepresentable in the unsigned version of the return type 'long' [core.UndefinedBinaryOperatorResult]
  (long)k << 16;
  ~~~~~~~ ^
3 warnings generated.
Fri, Nov 26, 11:30 AM · Restricted Project
steakhal added a comment to D114256: [clang-tidy] Fix crashing altera-struct-pack-align on invalid RecordDecls.

I plan to commit this stack on Monday.

Fri, Nov 26, 7:05 AM · Restricted Project
steakhal added a comment to D113558: [clang-tidy] Fix cppcoreguidelines-virtual-base-class-destructor in macros.

I'm not sure if it is a good idea to merge things on a Friday, but I am comfortable with this, let's get the check crash less.

Fri, Nov 26, 6:43 AM · Restricted Project
steakhal added inline comments to D114622: [clang-tidy][analyzer] Fix false-positive in IdenticalExprChecker and misc-redundant-expression.
Fri, Nov 26, 5:31 AM · Restricted Project
steakhal updated the diff for D114622: [clang-tidy][analyzer] Fix false-positive in IdenticalExprChecker and misc-redundant-expression.

Fixing nits: renaming variables, etc.

Fri, Nov 26, 5:31 AM · Restricted Project
steakhal updated the diff for D114622: [clang-tidy][analyzer] Fix false-positive in IdenticalExprChecker and misc-redundant-expression.
Fri, Nov 26, 5:08 AM · Restricted Project
steakhal added a comment to D114622: [clang-tidy][analyzer] Fix false-positive in IdenticalExprChecker and misc-redundant-expression.

I haven't looked at the patch in detail yet, but I know I've run into the issue this aims to fix when developing a Tidy check!

There is a // NOLINTNEXTLINE(misc-redundant-expression) directive in the source file clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp right before a static_assert that checks some type_traits-y stuff. Should be at line 510 -- according to my local checkout. Could you please remove that line and have that change be part of this patch too? I did a grep on the project and that's the only "user-side" mention to the misc-redundant-... check. Running Tidy on Tidy itself afterwards would turn out to be a nice real-world test that the fix indeed works. 🙂

Yup, it works. I removed your NOLINT comment.

Fri, Nov 26, 5:08 AM · Restricted Project
steakhal updated the diff for D114510: [analyzer] Ignore flex generated files.

Added analyzer options disabling the skipping of bison and flex files.

Fri, Nov 26, 4:36 AM
steakhal added a comment to D114619: [Analyzer][solver] Do not remove the simplified symbol from the eq class.

I see. Simplification is always good. Let's measure and compare the runtime characteristics before moving forward.

Fri, Nov 26, 3:25 AM · Restricted Project
steakhal added a comment to D103317: [Analyzer][Core] Make SValBuilder to better simplify svals with 3 symbols in the tree.

Please repeat the measurement for openssl. There must have been some interference in the memory consumption. Aside from that the results look great.

I did. Average memory usage is unaffected.

Fri, Nov 26, 3:11 AM · Restricted Project
steakhal requested review of D114622: [clang-tidy][analyzer] Fix false-positive in IdenticalExprChecker and misc-redundant-expression.
Fri, Nov 26, 2:51 AM · Restricted Project

Thu, Nov 25

steakhal added inline comments to D114105: [clang-tidy] Ignore narrowing conversions in case of bitfields.
Thu, Nov 25, 3:10 AM · Restricted Project
steakhal updated the diff for D114105: [clang-tidy] Ignore narrowing conversions in case of bitfields.

Added the test_parameter_passing() tests, demonstrating the implicit conversion triggered by parameter passing.
It turns out my previous revision suppressed a useful report.
Now, I fixed that and we get a warning for take<int>(x.id) // warn when x is CompleteBitfield with 32 bitwidth.
Aside from this, no behavioral change happened compared to the previous revision.

Thu, Nov 25, 3:09 AM · Restricted Project

Wed, Nov 24

steakhal added a comment to D114105: [clang-tidy] Ignore narrowing conversions in case of bitfields.

I think it's in pretty good shape, please have a look to help me move this forward.

Wed, Nov 24, 7:44 AM · Restricted Project
steakhal updated the diff for D114105: [clang-tidy] Ignore narrowing conversions in case of bitfields.

Bitshifts have nothing to do with this issue, thus I'm simply matching for bitfield -> int implicit casts due to promotions.

Wed, Nov 24, 7:43 AM · Restricted Project
steakhal added reviewers for D114454: [CSA]Skip unstable CSA tests failing on several platforms: jlebar, chandlerc.

I think D21810 (commit) was related to a triple issue in the past.
Let me summon them. @chandlerc @jlebar

Wed, Nov 24, 2:18 AM · Restricted Project
steakhal added a comment to D114454: [CSA]Skip unstable CSA tests failing on several platforms.

Thanks for fixing this @stevewan!

Wed, Nov 24, 2:12 AM · Restricted Project
steakhal updated the summary of D114510: [analyzer] Ignore flex generated files.
Wed, Nov 24, 12:19 AM
steakhal requested review of D114510: [analyzer] Ignore flex generated files.
Wed, Nov 24, 12:14 AM

Tue, Nov 23

steakhal added a comment to D114256: [clang-tidy] Fix crashing altera-struct-pack-align on invalid RecordDecls.

What happens if this checker runs on a forward declared class?

The matcher recordDecl(isStruct(), **isDefinition()**, unless(isExpansionInSystemHeader())) filters that case.

Tue, Nov 23, 9:03 AM · Restricted Project
steakhal updated the diff for D114256: [clang-tidy] Fix crashing altera-struct-pack-align on invalid RecordDecls.
  • update comments
  • move no-crash comment inline to the class member declaration
Tue, Nov 23, 9:02 AM · Restricted Project
steakhal added inline comments to D103317: [Analyzer][Core] Make SValBuilder to better simplify svals with 3 symbols in the tree.
Tue, Nov 23, 8:40 AM · Restricted Project
steakhal added a comment to D103317: [Analyzer][Core] Make SValBuilder to better simplify svals with 3 symbols in the tree.

To me at least, the patch looks good.
Please post some comparative measurements to demonstrate it won't introduce runtime regression.

Sure!

Teaser:

Please repeat the measurement for openssl. There must have been some interference in the memory consumption. Aside from that the results look great.

Tue, Nov 23, 7:55 AM · Restricted Project
steakhal added a comment to D114441: [analyzer][NFC] Refactor AnalysisConsumer::getModeForDecl().

I should note that I compared this on multiple projects to the baseline version and no runtime nor reports changed.
So, this is purely a cosmetic change.

Tue, Nov 23, 7:32 AM · Restricted Project
steakhal requested review of D114441: [analyzer][NFC] Refactor AnalysisConsumer::getModeForDecl().
Tue, Nov 23, 7:26 AM · Restricted Project
steakhal accepted D113753: [Analyzer][Core] Better simplification in SimpleSValBuilder::evalBinOpNN.

Awesome!

Tue, Nov 23, 7:17 AM · Restricted Project
steakhal added a comment to D114256: [clang-tidy] Fix crashing altera-struct-pack-align on invalid RecordDecls.

ping

Tue, Nov 23, 12:56 AM · Restricted Project

Mon, Nov 22

steakhal updated the diff for D114254: [libtooling][clang-tidy] Fix crashing on rendering invalid SourceRanges.
  • prefer empty() over size() == 0
Mon, Nov 22, 3:13 AM · Restricted Project

Fri, Nov 19

steakhal committed rGd5de568cc737: [analyzer][NFC] MaybeUInt -> MaybeCount (authored by steakhal).
[analyzer][NFC] MaybeUInt -> MaybeCount
Fri, Nov 19, 9:39 AM
steakhal committed rGe6ef134f3c77: [analyzer][NFC] Use enum for CallDescription flags (authored by steakhal).
[analyzer][NFC] Use enum for CallDescription flags
Fri, Nov 19, 9:33 AM
steakhal committed rG97f1bf15b154: [analyzer][NFC] Consolidate the inner representation of CallDescriptions (authored by steakhal).
[analyzer][NFC] Consolidate the inner representation of CallDescriptions
Fri, Nov 19, 9:33 AM
steakhal committed rGde9d7e42aca2: [analyzer][NFC] CallDescription should own the qualified name parts (authored by steakhal).
[analyzer][NFC] CallDescription should own the qualified name parts
Fri, Nov 19, 9:33 AM
steakhal committed rG9ad0a90baa8c: [analyzer][NFC] Demonstrate the use of CallDescriptionSet (authored by steakhal).
[analyzer][NFC] Demonstrate the use of CallDescriptionSet
Fri, Nov 19, 9:33 AM
steakhal closed D113595: [analyzer][NFC] Use enum for CallDescription flags.
Fri, Nov 19, 9:33 AM · Restricted Project
steakhal committed rGf18da190b0db: [analyzer][NFC] Switch to using CallDescription::matches() instead of isCalled() (authored by steakhal).
[analyzer][NFC] Switch to using CallDescription::matches() instead of isCalled()
Fri, Nov 19, 9:33 AM
steakhal committed rG6c512703a9e6: [analyzer][NFC] Introduce CallDescription::matches() in addition to isCalled() (authored by steakhal).
[analyzer][NFC] Introduce CallDescription::matches() in addition to isCalled()
Fri, Nov 19, 9:33 AM
steakhal closed D113594: [analyzer][NFC] Consolidate the inner representation of CallDescriptions.
Fri, Nov 19, 9:33 AM · Restricted Project
steakhal committed rGd448fcd9b223: [analyzer][NFC] Introduce CallDescriptionSets (authored by steakhal).
[analyzer][NFC] Introduce CallDescriptionSets
Fri, Nov 19, 9:33 AM
steakhal closed D113593: [analyzer][NFC] CallDescription should own the qualified name parts.
Fri, Nov 19, 9:33 AM · Restricted Project
steakhal closed D113592: [analyzer][NFC] Demonstrate the use of CallDescriptionSet.
Fri, Nov 19, 9:33 AM · Restricted Project
steakhal closed D113591: [analyzer][NFC] Switch to using CallDescription::matches() instead of isCalled().
Fri, Nov 19, 9:33 AM · Restricted Project
steakhal closed D113590: [analyzer][NFC] Introduce CallDescription::matches() in addition to isCalled().
Fri, Nov 19, 9:33 AM · Restricted Project
steakhal closed D113589: [analyzer][NFC] Introduce CallDescriptionSets.
Fri, Nov 19, 9:33 AM · Restricted Project
steakhal requested review of D114256: [clang-tidy] Fix crashing altera-struct-pack-align on invalid RecordDecls.
Fri, Nov 19, 9:13 AM · Restricted Project
steakhal requested review of D114254: [libtooling][clang-tidy] Fix crashing on rendering invalid SourceRanges.
Fri, Nov 19, 8:59 AM · Restricted Project
steakhal added a comment to D113754: [Analyzer][Core] Simplify IntSym in SValBuilder.

Great news, thanks.

Fri, Nov 19, 8:01 AM · Restricted Project
steakhal committed rGbf55b9f0d0e9: [analyzer][docs] Ellaborate the docs of cplusplus.StringChecker (authored by steakhal).
[analyzer][docs] Ellaborate the docs of cplusplus.StringChecker
Fri, Nov 19, 3:00 AM
steakhal closed D113401: [analyzer][docs] Ellaborate the docs of cplusplus.StringChecker.
Fri, Nov 19, 3:00 AM · Restricted Project
steakhal committed rGf3753ad77450: [ASTImporter][NFC] Dump decl name at assertion violation (authored by steakhal).
[ASTImporter][NFC] Dump decl name at assertion violation
Fri, Nov 19, 2:31 AM
steakhal closed D113668: [ASTImporter][NFC] Dump decl name at assertion violation.
Fri, Nov 19, 2:31 AM · Restricted Project
steakhal added a comment to D113558: [clang-tidy] Fix cppcoreguidelines-virtual-base-class-destructor in macros.

ping

Fri, Nov 19, 2:26 AM · Restricted Project
steakhal added inline comments to D113594: [analyzer][NFC] Consolidate the inner representation of CallDescriptions.
Fri, Nov 19, 2:21 AM · Restricted Project
steakhal added inline comments to D113595: [analyzer][NFC] Use enum for CallDescription flags.
Fri, Nov 19, 2:14 AM · Restricted Project
steakhal added inline comments to D113591: [analyzer][NFC] Switch to using CallDescription::matches() instead of isCalled().
Fri, Nov 19, 2:13 AM · Restricted Project
steakhal added inline comments to D113590: [analyzer][NFC] Introduce CallDescription::matches() in addition to isCalled().
Fri, Nov 19, 2:13 AM · Restricted Project
steakhal added a comment to D113589: [analyzer][NFC] Introduce CallDescriptionSets.

I recognize the problem, but don't agree with the solution: this is a CallDescriptionSet at this point, not a CallDescriptionMap. Also, I just don't think this is the place to use template specialization, nor do I think we should keep the function name lookup, if we only care about whether the call is in the set or not.

You are right! Fixed by now.

Fri, Nov 19, 2:12 AM · Restricted Project
steakhal updated the diff for D113595: [analyzer][NFC] Use enum for CallDescription flags.
  • move the CDF_None above the comment block
Fri, Nov 19, 2:12 AM · Restricted Project
steakhal updated the diff for D113594: [analyzer][NFC] Consolidate the inner representation of CallDescriptions.
  • introduce the MaybeUInt type alias
Fri, Nov 19, 2:12 AM · Restricted Project
steakhal updated the diff for D113593: [analyzer][NFC] CallDescription should own the qualified name parts.

rebase

Fri, Nov 19, 2:12 AM · Restricted Project
steakhal updated the diff for D113592: [analyzer][NFC] Demonstrate the use of CallDescriptionSet.

rebase: use CallDescriptionSet and .contains()

Fri, Nov 19, 2:12 AM · Restricted Project
steakhal updated the diff for D113591: [analyzer][NFC] Switch to using CallDescription::matches() instead of isCalled().

rebase

Fri, Nov 19, 2:12 AM · Restricted Project
steakhal updated the diff for D113590: [analyzer][NFC] Introduce CallDescription::matches() in addition to isCalled().
  • matches_any() -> matchesAny()
  • fixed some typos
  • removed the discouraging comment reminding users not using CallDescriptions directly
Fri, Nov 19, 2:12 AM · Restricted Project
steakhal updated the diff for D113589: [analyzer][NFC] Introduce CallDescriptionSets.
  • define the CallDescriptionSet class, by wrapping a CallDescriptionMap
  • add doc comments about the class
Fri, Nov 19, 2:12 AM · Restricted Project

Thu, Nov 18

steakhal added a comment to D113594: [analyzer][NFC] Consolidate the inner representation of CallDescriptions.

In the patch, I also avoid the use of the smart less-than operator.

It's not obvious for me how you avoid it. Could you please elaborate?

You can see in the diff that in some cases I'm using the dereference operator of the Optional in the new code, whereas previously we did not.
It was because the operator== and operator<= did the nullness check of the Optional within their operator implementation.
As you can see, one does not regularly see such a thing, so we are better off with that IMO.

Thu, Nov 18, 11:49 AM · Restricted Project
steakhal added inline comments to D114105: [clang-tidy] Ignore narrowing conversions in case of bitfields.
Thu, Nov 18, 9:53 AM · Restricted Project
steakhal added inline comments to D114105: [clang-tidy] Ignore narrowing conversions in case of bitfields.
Thu, Nov 18, 9:30 AM · Restricted Project
steakhal updated the diff for D114105: [clang-tidy] Ignore narrowing conversions in case of bitfields.
  • added more tests
  • add a detailed comment about the situation we suppress
  • see through parenExprs
Thu, Nov 18, 9:30 AM · Restricted Project
steakhal added a comment to D114105: [clang-tidy] Ignore narrowing conversions in case of bitfields.

Thanks for the valuable feedback.

Thu, Nov 18, 6:42 AM · Restricted Project

Wed, Nov 17

steakhal requested review of D114105: [clang-tidy] Ignore narrowing conversions in case of bitfields.
Wed, Nov 17, 10:17 AM · Restricted Project
steakhal closed D113588: [analyzer][NFC] Make the API of CallDescription safer slightly.

I've accidentally committed this without mentioning the Differential Revision stuff in the commit message. :(
This landed with 35ff3a0095d5b2dafa2fc8dd762377342aef9c50

Wed, Nov 17, 6:58 AM
steakhal committed rG35ff3a0095d5: [analyzer][NFC] Make the API of CallDescription safer slightly (authored by steakhal).
[analyzer][NFC] Make the API of CallDescription safer slightly
Wed, Nov 17, 6:56 AM
steakhal added a comment to D113593: [analyzer][NFC] CallDescription should own the qualified name parts.

Why though? Are you actually putting anything in there that isn't a static string literal?

If we plan in the future to dynamically populate CallDescriptionMaps then we will need owning semantics for CallDescriptions actually owning the qualified name parts.
Consider the GenericTaintChecker, which currently implements an ad-hoc function call matching just because of this.
Ideally, what we want is just parsing the config and populating the corresponding maps.
On the other hand, it could come in handy in the StdLibraryChecker as well, if we decide to hoist the DSL and let users specify their API in config files in a similar manner.

Wed, Nov 17, 1:07 AM · Restricted Project

Tue, Nov 16

steakhal accepted D114006: [analyzer][NFC] Enable access to CodeGenOptions from analyzer's instances.

Sweet!
I think commit titles are not punctuated, even though they start with an uppercase letter.

Tue, Nov 16, 11:03 AM · Restricted Project

Mon, Nov 15

steakhal added a comment to D111795: [analyzer] Reject incomplete matches in CallEvent::isCalled(), also introduce wildcards.

Let's reach a wider consensus about this. I'm really worried.

Mon, Nov 15, 11:46 AM