Page MenuHomePhabricator
Feed Advanced Search

Aug 10 2015

paulmaybee added a comment to D11574: Add size field to library load event.

Can you please check in in for me. Thanks.

Aug 10 2015, 9:43 AM

Aug 7 2015

paulmaybee added a comment to D11574: Add size field to library load event.

I'm not sure what the misunderstanding is, so I'll rephrase our desire. The VS debugger decorates code addresses with the name of the shared library from which the code originated (example above). We wish to use the load address and size of the shared library text for the purpose of determining the library name. Is there is some other way for us to get the lib name?

Aug 7 2015, 8:38 AM

Aug 5 2015

paulmaybee added a comment to D11574: Add size field to library load event.

ping

Aug 5 2015, 3:57 PM

Jul 30 2015

paulmaybee updated the diff for D11574: Add size field to library load event.

Add add_slashes to test case. Replace Escape with AddSlashes. Update extension doc.

Jul 30 2015, 9:29 AM
paulmaybee added a comment to D11570: Escape variable creation error messages..

Can you please check it in? Thanks.

Jul 30 2015, 9:17 AM

Jul 29 2015

paulmaybee updated the diff for D11570: Escape variable creation error messages..

Escape quotes too.

Jul 29 2015, 11:17 AM
paulmaybee updated the diff for D11574: Add size field to library load event.

Escape paths in library-loaded event and fix test case.

Jul 29 2015, 11:03 AM

Jul 28 2015

paulmaybee retitled D11574: Add size field to library load event from to Add size field to library load event.
Jul 28 2015, 1:31 PM
paulmaybee retitled D11570: Escape variable creation error messages. from to Escape variable creation error messages..
Jul 28 2015, 12:19 PM
paulmaybee updated the diff for D11488: Fix bug in expression display when determining if a pointer should be treated as a string.

Added the section title.
If you are ok with this now then can you please check it in?

Jul 28 2015, 9:44 AM

Jul 27 2015

paulmaybee updated the diff for D11488: Fix bug in expression display when determining if a pointer should be treated as a string.

Add IsPointeeCharType

Jul 27 2015, 10:34 AM

Jul 24 2015

paulmaybee updated the diff for D11488: Fix bug in expression display when determining if a pointer should be treated as a string.

Add test case

Jul 24 2015, 12:06 PM
paulmaybee retitled D11488: Fix bug in expression display when determining if a pointer should be treated as a string from to Fix bug in expression display when determining if a pointer should be treated as a string.
Jul 24 2015, 10:11 AM

Jul 23 2015

paulmaybee added a comment to D11371: Support escapes and quotes in string and character values..

Can someone please check this in for me. Thanks.

Jul 23 2015, 9:22 AM
paulmaybee updated the diff for D11371: Support escapes and quotes in string and character values..

remove '###'

Jul 23 2015, 9:20 AM

Jul 22 2015

paulmaybee updated the diff for D11371: Support escapes and quotes in string and character values..

Replace "hello" with "\t\"hello\"\n" in string value tests.

Jul 22 2015, 9:26 AM

Jul 21 2015

paulmaybee added inline comments to D11371: Support escapes and quotes in string and character values..
Jul 21 2015, 9:51 AM

Jul 20 2015

paulmaybee retitled D11371: Support escapes and quotes in string and character values. from to Support escapes and quotes in string and character values..
Jul 20 2015, 2:45 PM

May 29 2015

paulmaybee added a comment to D10106: Add type result to lldb-mi variables lists when simple-values is specified..

I am new and can't commit directly. Can you commit this for me?

May 29 2015, 9:31 AM
paulmaybee added inline comments to D10106: Add type result to lldb-mi variables lists when simple-values is specified..
May 29 2015, 8:58 AM
paulmaybee added a comment to D10106: Add type result to lldb-mi variables lists when simple-values is specified..

Sorry, I mistyped the comment in the review. My fix "does not" have the issue the Ilia raised. That is, it does return names in simple lists when no values are asked for.

May 29 2015, 8:30 AM
paulmaybee added a comment to D10106: Add type result to lldb-mi variables lists when simple-values is specified..

Hi Abid,
Yeah looks like you are solving the same problem. I didn't see your review in progress. I do, however, believe my patch also fixes both the issues you address with yours, and does have the issue that Ilia raises.
-Paul

May 29 2015, 8:00 AM

May 28 2015

paulmaybee retitled D10106: Add type result to lldb-mi variables lists when simple-values is specified. from to Add type result to lldb-mi variables lists when simple-values is specified..
May 28 2015, 2:50 PM