Page MenuHomePhabricator
Feed Advanced Search

Feb 5 2021

hctim added a comment to D95884: [Scudo] Use GWP-ASan's aligned allocations and fixup postalloc hooks..

I think the skip in the tests will not work on Fuchsia. I'll check.

Feb 5 2021, 9:13 AM · Restricted Project

Feb 4 2021

hctim added a comment to D94830: [GWP-ASan] Add aligned allocations..

(friendly ping)

Feb 4 2021, 9:15 AM · Restricted Project

Feb 2 2021

hctim accepted D95921: [scudo/standalone] Use zx_system_get_page_size() on Fuchsia.
Feb 2 2021, 9:18 PM · Restricted Project
hctim accepted D95920: [gwp_asan] Use zx_system_get_page_size() on Fuchsia.
Feb 2 2021, 9:18 PM · Restricted Project
hctim updated the diff for D95884: [Scudo] Use GWP-ASan's aligned allocations and fixup postalloc hooks..

Rebase on top of D95542.

Feb 2 2021, 4:35 PM · Restricted Project
hctim updated the diff for D94830: [GWP-ASan] Add aligned allocations..

Rebased on top of D95542, which changed the GWP-ASan flag parsing dependencies. This patch does require a small change on the Scudo side, but the actual integration on top of this API (with some new fixes) is at D95884.

Feb 2 2021, 3:34 PM · Restricted Project
hctim updated the diff for D94830: [GWP-ASan] Add aligned allocations..

Rebase after kerfuffle.

Feb 2 2021, 2:51 PM · Restricted Project
hctim reopened D94830: [GWP-ASan] Add aligned allocations..

Accidentally committed this in 9dc06762470cb5a6cde8de5833cb75262e1bacb0, and reverted it in 0dcf3324cfb4429e85b54e857f9bb86f423ffc5e. This is still needing review.

Feb 2 2021, 2:48 PM · Restricted Project
hctim added a reverting change for rG9dc06762470c: [GWP-ASan] Add aligned allocations.: rG0dcf3324cfb4: Revert "[GWP-ASan] Add aligned allocations.".
Feb 2 2021, 2:47 PM
hctim committed rG0dcf3324cfb4: Revert "[GWP-ASan] Add aligned allocations." (authored by hctim).
Revert "[GWP-ASan] Add aligned allocations."
Feb 2 2021, 2:47 PM
hctim added a reverting change for D94830: [GWP-ASan] Add aligned allocations.: rG0dcf3324cfb4: Revert "[GWP-ASan] Add aligned allocations.".
Feb 2 2021, 2:47 PM · Restricted Project
hctim committed rG30973f6fe01c: [GWP-ASan] Add locking around unwinder for atfork protection. (authored by hctim).
[GWP-ASan] Add locking around unwinder for atfork protection.
Feb 2 2021, 2:45 PM
hctim committed rG9dc06762470c: [GWP-ASan] Add aligned allocations. (authored by hctim).
[GWP-ASan] Add aligned allocations.
Feb 2 2021, 2:45 PM
hctim closed D95889: [GWP-ASan] Add locking around unwinder for atfork protection..
Feb 2 2021, 2:45 PM · Restricted Project
hctim closed D94830: [GWP-ASan] Add aligned allocations..
Feb 2 2021, 2:45 PM · Restricted Project
hctim updated the diff for D94830: [GWP-ASan] Add aligned allocations..

Addressed Kostya's comments.

Feb 2 2021, 2:31 PM · Restricted Project
hctim updated the summary of D95884: [Scudo] Use GWP-ASan's aligned allocations and fixup postalloc hooks..
Feb 2 2021, 2:26 PM · Restricted Project
hctim updated the diff for D95884: [Scudo] Use GWP-ASan's aligned allocations and fixup postalloc hooks..

Changed a comment and reformatted slightly.

Feb 2 2021, 2:26 PM · Restricted Project
hctim updated the diff for D95884: [Scudo] Use GWP-ASan's aligned allocations and fixup postalloc hooks..

Rebased on top of unwinder locking in D95889.

Feb 2 2021, 2:22 PM · Restricted Project
hctim requested review of D95889: [GWP-ASan] Add locking around unwinder for atfork protection..
Feb 2 2021, 11:48 AM · Restricted Project
hctim requested review of D95884: [Scudo] Use GWP-ASan's aligned allocations and fixup postalloc hooks..
Feb 2 2021, 10:30 AM · Restricted Project

Feb 1 2021

hctim added inline comments to D94830: [GWP-ASan] Add aligned allocations..
Feb 1 2021, 11:12 AM · Restricted Project
hctim updated the diff for D94830: [GWP-ASan] Add aligned allocations..

Removed Scudo bits for now, made this GWP-ASan specific. Changes to scudo will come in a follow-up patch.

Feb 1 2021, 11:10 AM · Restricted Project
hctim retitled D94830: [GWP-ASan] Add aligned allocations. from [GWP-ASan] Add 'user requested' size and fix Scudo. to [GWP-ASan] Add aligned allocations..
Feb 1 2021, 11:09 AM · Restricted Project

Jan 27 2021

hctim accepted D95542: [scudo][standalone] Restore GWP-ASan flag parsing.
Jan 27 2021, 11:42 AM · Restricted Project

Jan 26 2021

hctim planned changes to D94830: [GWP-ASan] Add aligned allocations..
Jan 26 2021, 4:46 PM · Restricted Project
hctim updated the diff for D94830: [GWP-ASan] Add aligned allocations..

Address reviewer comments.

Jan 26 2021, 4:46 PM · Restricted Project
hctim added a comment to D94830: [GWP-ASan] Add aligned allocations..

Is there some test that can be added that would find a regression?

Jan 26 2021, 4:37 PM · Restricted Project
hctim updated the summary of D94830: [GWP-ASan] Add aligned allocations..
Jan 26 2021, 4:26 PM · Restricted Project
hctim added inline comments to D92696: [GWP-ASan] Add inbuilt options parser..
Jan 26 2021, 2:23 PM · Restricted Project
hctim added inline comments to D92696: [GWP-ASan] Add inbuilt options parser..
Jan 26 2021, 11:41 AM · Restricted Project

Jan 22 2021

hctim added a reverting change for rG3dedad475da4: [AArch64][GlobalISel] Make G_USUBO legal and select it.: rG19ec559c665e: Revert "[AArch64][GlobalISel] Make G_USUBO legal and select it.".
Jan 22 2021, 2:33 PM
hctim committed rG19ec559c665e: Revert "[AArch64][GlobalISel] Make G_USUBO legal and select it." (authored by hctim).
Revert "[AArch64][GlobalISel] Make G_USUBO legal and select it."
Jan 22 2021, 2:33 PM
hctim added a reverting change for rG541d98efa222: [AArch64][GlobalISel] Implement widenScalar for signed overflow: rGe3a7532cc95e: Revert "[AArch64][GlobalISel] Implement widenScalar for signed overflow".
Jan 22 2021, 2:33 PM
hctim committed rGe3a7532cc95e: Revert "[AArch64][GlobalISel] Implement widenScalar for signed overflow" (authored by hctim).
Revert "[AArch64][GlobalISel] Implement widenScalar for signed overflow"
Jan 22 2021, 2:33 PM
hctim added a reverting change for D95032: [AArch64][GlobalISel] Make G_USUBO legal and select it: rG19ec559c665e: Revert "[AArch64][GlobalISel] Make G_USUBO legal and select it.".
Jan 22 2021, 2:33 PM · Restricted Project
hctim added a reverting change for rG2bb92bf451d7: [GlobalISel] LegalizerHelper - Extract widenScalarAddoSubo method: rG554b3211fefd: Revert "[GlobalISel] LegalizerHelper - Extract widenScalarAddoSubo method".
Jan 22 2021, 2:33 PM
hctim committed rG554b3211fefd: Revert "[GlobalISel] LegalizerHelper - Extract widenScalarAddoSubo method" (authored by hctim).
Revert "[GlobalISel] LegalizerHelper - Extract widenScalarAddoSubo method"
Jan 22 2021, 2:33 PM
hctim added a reverting change for D95034: [AArch64][GlobalISel] Implement widenScalar for signed overflow: rGe3a7532cc95e: Revert "[AArch64][GlobalISel] Implement widenScalar for signed overflow".
Jan 22 2021, 2:33 PM · Restricted Project
hctim added a reverting change for D95035: [GlobalISel] LegalizerHelper - Extract widenScalarAddoSubo method: rG554b3211fefd: Revert "[GlobalISel] LegalizerHelper - Extract widenScalarAddoSubo method".
Jan 22 2021, 2:33 PM · Restricted Project
hctim added a comment to D95032: [AArch64][GlobalISel] Make G_USUBO legal and select it.

Hi, looks like this patch broke UBSan on aarch64:

Jan 22 2021, 2:16 PM · Restricted Project

Jan 19 2021

hctim added a comment to D94267: [PDB] Defer relocating .debug$S until commit time and parallelize it.

Reverted in 5b7aef6eb4b2930971029b984cb2360f7682e5a5 to bring the ASan bots online. Repro instructions at https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild:

Jan 19 2021, 11:48 AM · Restricted Project
hctim added a reverting change for rG6529d7c5a45b: [PDB] Defer relocating .debug$S until commit time and parallelize it: rG5b7aef6eb4b2: Revert "[PDB] Defer relocating .debug$S until commit time and parallelize it".
Jan 19 2021, 11:46 AM
hctim committed rG5b7aef6eb4b2: Revert "[PDB] Defer relocating .debug$S until commit time and parallelize it" (authored by hctim).
Revert "[PDB] Defer relocating .debug$S until commit time and parallelize it"
Jan 19 2021, 11:46 AM
hctim added a reverting change for D94267: [PDB] Defer relocating .debug$S until commit time and parallelize it: rG5b7aef6eb4b2: Revert "[PDB] Defer relocating .debug$S until commit time and parallelize it".
Jan 19 2021, 11:46 AM · Restricted Project

Jan 15 2021

hctim requested review of D94830: [GWP-ASan] Add aligned allocations..
Jan 15 2021, 2:39 PM · Restricted Project
hctim committed rG6a42cbf6d211: [GWP-ASan] Add inbuilt options parser. (authored by hctim).
[GWP-ASan] Add inbuilt options parser.
Jan 15 2021, 1:18 PM
hctim closed D92696: [GWP-ASan] Add inbuilt options parser..
Jan 15 2021, 1:17 PM · Restricted Project

Jan 14 2021

hctim updated the diff for D92696: [GWP-ASan] Add inbuilt options parser..
  • Addressed eugenis@'s comments, delete unknown registry and remove some unnecessary code.
Jan 14 2021, 1:32 PM · Restricted Project
hctim committed rGa8520f6970fd: [GWP-ASan] Minor refactor of optional components. (authored by hctim).
[GWP-ASan] Minor refactor of optional components.
Jan 14 2021, 11:14 AM
hctim closed D94117: [GWP-ASan] Minor refactor of optional components..
Jan 14 2021, 11:14 AM · Restricted Project

Jan 12 2021

hctim abandoned D64457: [GWP-ASan] Attempt to fix Android/ARM platforms..

(no longer relevant - much fresher patch should be coming soon to do the same thing)

Jan 12 2021, 1:39 PM · Restricted Project, Restricted Project
hctim abandoned D94105: [scudo] [android] Use ELF TLS on Android API >= 30..

We're actually going to kill support for compiler-rt based scudo on Android, so this patch should become obsolete soon. Preferably, we'd like to delete the entire thing but it seems like it might be used for Windows builds experimentally...

Jan 12 2021, 12:30 PM · Restricted Project
hctim added a comment to D94117: [GWP-ASan] Minor refactor of optional components..

@eugenis - friendly ping

Jan 12 2021, 10:59 AM · Restricted Project

Jan 8 2021

hctim updated the diff for D94117: [GWP-ASan] Minor refactor of optional components..
  • Update namespace in fuchsia file.
Jan 8 2021, 11:07 AM · Restricted Project
hctim added a comment to D94117: [GWP-ASan] Minor refactor of optional components..

(friendly ping)

Jan 8 2021, 10:14 AM · Restricted Project

Jan 7 2021

hctim abandoned D93499: [sanitizers] Force pickup of new symbolizer (round #2)..

Scratch this patch - polluted environment probably doesn't necessitate a workaround that increases the complexity of the runner.

Jan 7 2021, 8:59 AM · Restricted Project

Jan 6 2021

hctim added inline comments to D93499: [sanitizers] Force pickup of new symbolizer (round #2)..
Jan 6 2021, 4:04 PM · Restricted Project
hctim updated the diff for D93499: [sanitizers] Force pickup of new symbolizer (round #2)..
  • Remove timeout command from 'test'.
Jan 6 2021, 3:14 PM · Restricted Project
hctim added inline comments to D93499: [sanitizers] Force pickup of new symbolizer (round #2)..
Jan 6 2021, 3:14 PM · Restricted Project

Jan 5 2021

hctim accepted D90969: Renovate CMake file for the `llvm-cfi-verify` tool.

Looks reasonable to me.

Jan 5 2021, 4:53 PM · Restricted Project
hctim updated the diff for D93499: [sanitizers] Force pickup of new symbolizer (round #2)..
  • Changed to 'test -x' instead of 'ls' in test, and removed timeout blob.
Jan 5 2021, 4:47 PM · Restricted Project
hctim added inline comments to D93499: [sanitizers] Force pickup of new symbolizer (round #2)..
Jan 5 2021, 4:47 PM · Restricted Project
hctim updated the summary of D92696: [GWP-ASan] Add inbuilt options parser..
Jan 5 2021, 4:41 PM · Restricted Project
hctim updated the diff for D92696: [GWP-ASan] Add inbuilt options parser..
  • Add very large warning about flags.
Jan 5 2021, 4:38 PM · Restricted Project
hctim updated the diff for D92696: [GWP-ASan] Add inbuilt options parser..
  • Add options parser fuzzer. Run pretty extensively under ASan without problems.
Jan 5 2021, 3:29 PM · Restricted Project
hctim updated the summary of D92696: [GWP-ASan] Add inbuilt options parser..
Jan 5 2021, 3:00 PM · Restricted Project
hctim updated the diff for D92696: [GWP-ASan] Add inbuilt options parser..

(rebased, depends on D94117)

Jan 5 2021, 2:59 PM · Restricted Project
hctim added reviewers for D94117: [GWP-ASan] Minor refactor of optional components.: cryptoad, eugenis.
Jan 5 2021, 2:50 PM · Restricted Project
hctim updated the diff for D94117: [GWP-ASan] Minor refactor of optional components..
  • Restore one header file to a smaller diff.
Jan 5 2021, 2:49 PM · Restricted Project
hctim updated the diff for D94117: [GWP-ASan] Minor refactor of optional components..
  • Updated some bits on fuchsia that weren't caught in my checkbuild.
Jan 5 2021, 1:40 PM · Restricted Project
hctim requested review of D94117: [GWP-ASan] Minor refactor of optional components..
Jan 5 2021, 1:37 PM · Restricted Project
hctim committed rG1f8031cd7488: [android] Fix some tests for AOSP-master devices. (authored by hctim).
[android] Fix some tests for AOSP-master devices.
Jan 5 2021, 12:55 PM
hctim closed D94100: [android] Fix some tests for AOSP-master devices..
Jan 5 2021, 12:54 PM · Restricted Project
hctim updated the diff for D92696: [GWP-ASan] Add inbuilt options parser..
  • add the options parser.
Jan 5 2021, 12:10 PM · Restricted Project
hctim updated the diff for D92696: [GWP-ASan] Add inbuilt options parser..

(full cmake patches, basis for working backwards).

Jan 5 2021, 12:09 PM · Restricted Project
hctim removed a project from D92696: [GWP-ASan] Add inbuilt options parser.: Restricted Project.
Jan 5 2021, 12:06 PM · Restricted Project
hctim accepted D94104: [scudo][standalone] Fix build for Fuchsia.
Jan 5 2021, 11:30 AM · Restricted Project
hctim added a reviewer for D94105: [scudo] [android] Use ELF TLS on Android API >= 30.: cryptoad.
Jan 5 2021, 11:24 AM · Restricted Project
hctim updated the diff for D94100: [android] Fix some tests for AOSP-master devices..
  • Remove some dead comments.
Jan 5 2021, 11:23 AM · Restricted Project
hctim added inline comments to D94100: [android] Fix some tests for AOSP-master devices..
Jan 5 2021, 11:22 AM · Restricted Project
hctim added inline comments to D94105: [scudo] [android] Use ELF TLS on Android API >= 30..
Jan 5 2021, 11:22 AM · Restricted Project
hctim requested review of D94105: [scudo] [android] Use ELF TLS on Android API >= 30..
Jan 5 2021, 11:21 AM · Restricted Project
hctim updated the diff for D94100: [android] Fix some tests for AOSP-master devices..

Lost some of the patch in a comment fix, here's the rest of it.

Jan 5 2021, 10:44 AM · Restricted Project
hctim added inline comments to D94100: [android] Fix some tests for AOSP-master devices..
Jan 5 2021, 10:37 AM · Restricted Project
hctim updated the diff for D94100: [android] Fix some tests for AOSP-master devices..

(changed some comment text).

Jan 5 2021, 10:15 AM · Restricted Project
hctim requested review of D94100: [android] Fix some tests for AOSP-master devices..
Jan 5 2021, 10:14 AM · Restricted Project

Dec 17 2020

hctim requested review of D93499: [sanitizers] Force pickup of new symbolizer (round #2)..
Dec 17 2020, 4:24 PM · Restricted Project
hctim added a reverting change for rG66ee0d3d84a6: [sanitizer-common] Force pickup of llvm-symbolizer from new binaries.: rG13261f4c0349: Revert "[sanitizer-common] Force pickup of llvm-symbolizer from new binaries.".
Dec 17 2020, 4:18 PM
hctim committed rG13261f4c0349: Revert "[sanitizer-common] Force pickup of llvm-symbolizer from new binaries." (authored by hctim).
Revert "[sanitizer-common] Force pickup of llvm-symbolizer from new binaries."
Dec 17 2020, 4:18 PM
hctim added a reverting change for rG30d292ddbb7e: [sanitizer-common] Pickup llvm-symbolizer from $OUT/bin IFF exists.: rGab1a05d57f6f: Revert "[sanitizer-common] Pickup llvm-symbolizer from $OUT/bin IFF exists.".
Dec 17 2020, 4:18 PM
hctim committed rGab1a05d57f6f: Revert "[sanitizer-common] Pickup llvm-symbolizer from $OUT/bin IFF exists." (authored by hctim).
Revert "[sanitizer-common] Pickup llvm-symbolizer from $OUT/bin IFF exists."
Dec 17 2020, 4:18 PM
hctim added a reverting change for D93352: [sanitizer-common] Force pickup of llvm-symbolizer from new binaries.: rG13261f4c0349: Revert "[sanitizer-common] Force pickup of llvm-symbolizer from new binaries.".
Dec 17 2020, 4:18 PM · Restricted Project
hctim added a comment to D93352: [sanitizer-common] Force pickup of llvm-symbolizer from new binaries..

Also seems to have broken the Android bot even after your fix:

(there is currently a build issue obscuring the breakage in latest builds)

Function symbolization seems to be broken on Android.

Dec 17 2020, 11:23 AM · Restricted Project

Dec 16 2020

hctim added a comment to D93352: [sanitizer-common] Force pickup of llvm-symbolizer from new binaries..

(buildbreak fixed in 30d292ddbb7e)

Dec 16 2020, 2:42 PM · Restricted Project
hctim committed rG30d292ddbb7e: [sanitizer-common] Pickup llvm-symbolizer from $OUT/bin IFF exists. (authored by hctim).
[sanitizer-common] Pickup llvm-symbolizer from $OUT/bin IFF exists.
Dec 16 2020, 11:59 AM
hctim added a comment to D93352: [sanitizer-common] Force pickup of llvm-symbolizer from new binaries..

(looks like a broke a bot - LMTAL for an in-flight fix: http://lab.llvm.org:8011/#/builders/37/builds/1311/steps/33/logs/stdio)

Dec 16 2020, 9:27 AM · Restricted Project
hctim committed rG66ee0d3d84a6: [sanitizer-common] Force pickup of llvm-symbolizer from new binaries. (authored by hctim).
[sanitizer-common] Force pickup of llvm-symbolizer from new binaries.
Dec 16 2020, 6:43 AM
hctim closed D93352: [sanitizer-common] Force pickup of llvm-symbolizer from new binaries..
Dec 16 2020, 6:43 AM · Restricted Project

Dec 15 2020

hctim requested review of D93352: [sanitizer-common] Force pickup of llvm-symbolizer from new binaries..
Dec 15 2020, 3:28 PM · Restricted Project