Page MenuHomePhabricator
Feed Advanced Search

Yesterday

hctim added a comment to rL372376: [MachinePipeliner] Improve the TargetInstrInfo API analyzeLoop/reduceLoopCount.

No problem! The Sanitizer bots are notoriously hard to reproduce - if you'd like to repro the best instructions I can give are at https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild :)

Fri, Sep 20, 1:56 PM
hctim committed rG72a3d8597da5: Revert "[MachinePipeliner] Improve the TargetInstrInfo API… (authored by hctim).
Revert "[MachinePipeliner] Improve the TargetInstrInfo API…
Fri, Sep 20, 1:26 PM
hctim added a reverting change for rG15e27b0b6d9d: [MachinePipeliner] Improve the TargetInstrInfo API analyzeLoop/reduceLoopCount: rG72a3d8597da5: Revert "[MachinePipeliner] Improve the TargetInstrInfo API….
Fri, Sep 20, 1:26 PM
hctim committed rL372425: Revert "[MachinePipeliner] Improve the TargetInstrInfo API….
Revert "[MachinePipeliner] Improve the TargetInstrInfo API…
Fri, Sep 20, 1:26 PM
hctim added a comment to rL372376: [MachinePipeliner] Improve the TargetInstrInfo API analyzeLoop/reduceLoopCount.

Reverted in rL372425

Fri, Sep 20, 1:25 PM
hctim added a comment to rL372376: [MachinePipeliner] Improve the TargetInstrInfo API analyzeLoop/reduceLoopCount.

FYI - This broke the ASan buildbots:

Fri, Sep 20, 1:25 PM

Thu, Sep 19

hctim committed rG08f938bd1ae3: Revert "[CUDA][HIP] Fix typo in `BestViableFunction`" (authored by hctim).
Revert "[CUDA][HIP] Fix typo in `BestViableFunction`"
Thu, Sep 19, 2:14 PM
hctim added a reverting change for rGeb231d15825a: [CUDA][HIP] Fix typo in `BestViableFunction`: rG08f938bd1ae3: Revert "[CUDA][HIP] Fix typo in `BestViableFunction`".
Thu, Sep 19, 2:14 PM
hctim committed rL372353: Revert "[CUDA][HIP] Fix typo in `BestViableFunction`".
Revert "[CUDA][HIP] Fix typo in `BestViableFunction`"
Thu, Sep 19, 2:09 PM
hctim committed rGf5fcf6156656: Don't false-positive match against binary path. (authored by hctim).
Don't false-positive match against binary path.
Thu, Sep 19, 1:48 PM
hctim committed rL372351: Don't false-positive match against binary path..
Don't false-positive match against binary path.
Thu, Sep 19, 1:46 PM
hctim added a comment to rL372318: [CUDA][HIP] Fix typo in `BestViableFunction`.

Looks like this change broke the msan buildbot:

Thu, Sep 19, 1:28 PM
hctim added a comment to D66320: [Bugpoint redesign] Added pass to reduce Basic Blocks.

Looks like this broke the sanitizer buildbots - I'll confirm that a revert fixes and will follow up with it:

FAIL: LLVM :: Reduce/remove-bbs.ll (25951 of 33613)
******************** TEST 'LLVM :: Reduce/remove-bbs.ll' FAILED ********************
Script:
--
: 'RUN: at line 4';   llvm-reduce --test "/usr/bin/python" --test-arg /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/test/Reduce/Inputs/remove-bbs.py /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/test/Reduce/remove-bbs.ll -o /b/sanitizer-x86_64-linux-fast/build/llvm_build_msan/test/Reduce/Output/remove-bbs.ll.tmp
: 'RUN: at line 5';   cat /b/sanitizer-x86_64-linux-fast/build/llvm_build_msan/test/Reduce/Output/remove-bbs.ll.tmp | /b/sanitizer-x86_64-linux-fast/build/llvm_build_msan/bin/FileCheck -implicit-check-not=uninteresting /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/test/Reduce/remove-bbs.ll
--
Exit Code: 77
Thu, Sep 19, 1:02 PM · Restricted Project

Wed, Sep 18

hctim accepted D67738: [lsan] Fix deadlock in dl_iterate_phdr..
Wed, Sep 18, 6:41 PM · Restricted Project, Restricted Project

Mon, Sep 9

hctim accepted D67193: [UBSan] Do not overwrite the default print_summary sanitizer option..

SGTM. LGTM.

Mon, Sep 9, 9:45 AM · Restricted Project, Restricted Project

Wed, Sep 4

hctim added a reviewer for D67193: [UBSan] Do not overwrite the default print_summary sanitizer option.: kcc.
Wed, Sep 4, 3:29 PM · Restricted Project, Restricted Project
hctim added a comment to D67193: [UBSan] Do not overwrite the default print_summary sanitizer option..

I'm personally okay with this change, but will wait for @kcc to see what he thinks.

Wed, Sep 4, 3:29 PM · Restricted Project, Restricted Project

Tue, Aug 27

hctim committed rL370094: Add GWP-ASan fuzz target to compiler-rt/tools..
Add GWP-ASan fuzz target to compiler-rt/tools.
Tue, Aug 27, 11:49 AM
hctim committed rGae56e593b90c: Add GWP-ASan fuzz target to compiler-rt/tools. (authored by hctim).
Add GWP-ASan fuzz target to compiler-rt/tools.
Tue, Aug 27, 11:41 AM
hctim closed D66776: Add GWP-ASan fuzz target to compiler-rt/tools..
Tue, Aug 27, 11:40 AM · Restricted Project, Restricted Project
hctim added a comment to D66776: Add GWP-ASan fuzz target to compiler-rt/tools..

Submission is broken currently due to the upstream SVN issues. Will submit when it's available. Thanks for your patience.

Tue, Aug 27, 11:26 AM · Restricted Project, Restricted Project

Mon, Aug 26

hctim created D66776: Add GWP-ASan fuzz target to compiler-rt/tools..
Mon, Aug 26, 5:10 PM · Restricted Project, Restricted Project
hctim added a comment to D66494: [GWP-ASan] Build stack_trace_compressor_fuzzer..

Update: there's a slight problem with the dependency chain that I encountered when whipping up a quick fix:

Mon, Aug 26, 3:16 PM · Restricted Project, Restricted Project
hctim added a comment to D66494: [GWP-ASan] Build stack_trace_compressor_fuzzer..

@pree-jackie i'll take a look, thanks for letting me know

Mon, Aug 26, 12:52 PM · Restricted Project, Restricted Project

Fri, Aug 23

hctim added a comment to D66494: [GWP-ASan] Build stack_trace_compressor_fuzzer..

@vitalybuka: Maybe rL369823?

Fri, Aug 23, 6:37 PM · Restricted Project, Restricted Project
hctim committed rG27d69b2f4f6b: [GWP-ASan] Split options_parser and backtrace_sanitizer_common. (authored by hctim).
[GWP-ASan] Split options_parser and backtrace_sanitizer_common.
Fri, Aug 23, 4:25 PM
hctim committed rL369825: [GWP-ASan] Split options_parser and backtrace_sanitizer_common..
[GWP-ASan] Split options_parser and backtrace_sanitizer_common.
Fri, Aug 23, 4:23 PM
hctim closed D66684: [GWP-ASan] Split options_parser and backtrace_sanitizer_common..
Fri, Aug 23, 4:22 PM · Restricted Project, Restricted Project
hctim updated the diff for D66684: [GWP-ASan] Split options_parser and backtrace_sanitizer_common..

Merge branch 'master' into gwp_asan/glibc_printf in prep for submission.

Fri, Aug 23, 4:22 PM · Restricted Project, Restricted Project
hctim committed rG05bc1468c2f4: Fix stack_trace_compressor builds for Clang < 6.0 (authored by hctim).
Fix stack_trace_compressor builds for Clang < 6.0
Fri, Aug 23, 4:14 PM
hctim committed rL369823: Fix stack_trace_compressor builds for Clang < 6.0.
Fix stack_trace_compressor builds for Clang < 6.0
Fri, Aug 23, 4:14 PM
hctim closed D66682: Fix stack_trace_compressor builds for Clang < 6.0.
Fri, Aug 23, 4:14 PM · Restricted Project, Restricted Project
hctim created D66684: [GWP-ASan] Split options_parser and backtrace_sanitizer_common..
Fri, Aug 23, 2:13 PM · Restricted Project, Restricted Project
hctim created D66682: Fix stack_trace_compressor builds for Clang < 6.0.
Fri, Aug 23, 1:40 PM · Restricted Project, Restricted Project

Aug 21 2019

hctim created D66568: [GWP-ASan] Remove c++ standard lib dependency..
Aug 21 2019, 5:05 PM · Restricted Project, Restricted Project
hctim added a comment to D62875: [GWP-ASan] Add public-facing documentation [6]..

The docs don't build and rL369554 doesn't fully fix it

$ ninja docs-llvm-html
[1/1] Generating html Sphinx documentation
FAILED: docs/CMakeFiles/docs-llvm-html

Warning, treated as error:
llvm/docs/GwpAsan.rst:document isn't included in any toctree
ninja: build stopped: subcommand failed.

Submitted rL369556 to temporarily make docs build again. However that basically suppresses the warning; you likely want to put it in a toctree instead of making it an orphan doc, e.g. https://reviews.llvm.org/D66183#change-D4KqPHFormwF

Aug 21 2019, 11:38 AM · Restricted Project, Restricted Project
hctim committed rG84b762af3b54: [docs] Add GwpAsan to toctree. (authored by hctim).
[docs] Add GwpAsan to toctree.
Aug 21 2019, 11:32 AM
hctim added a reverting change for rL369556: [docs] Fix GwpAsan.rst: rL369560: [docs] Add GwpAsan to toctree..
Aug 21 2019, 11:31 AM
hctim committed rL369560: [docs] Add GwpAsan to toctree..
[docs] Add GwpAsan to toctree.
Aug 21 2019, 11:31 AM
hctim committed rG2213bbb57aa7: Add newline to GWP-ASan sphinx document. Should fix the document builder. (authored by hctim).
Add newline to GWP-ASan sphinx document. Should fix the document builder.
Aug 21 2019, 11:05 AM
hctim committed rL369554: Add newline to GWP-ASan sphinx document..
Add newline to GWP-ASan sphinx document.
Aug 21 2019, 11:05 AM
hctim committed rGc776f3f3c26f: [GWP-ASan] Add public-facing documentation [6]. (authored by hctim).
[GWP-ASan] Add public-facing documentation [6].
Aug 21 2019, 10:55 AM
hctim committed rGf9269b5396c1: [GWP-ASan] Build stack_trace_compressor_fuzzer. (authored by hctim).
[GWP-ASan] Build stack_trace_compressor_fuzzer.
Aug 21 2019, 10:55 AM
hctim committed rL369552: [GWP-ASan] Add public-facing documentation [6]..
[GWP-ASan] Add public-facing documentation [6].
Aug 21 2019, 10:54 AM
hctim closed D62875: [GWP-ASan] Add public-facing documentation [6]..
Aug 21 2019, 10:54 AM · Restricted Project, Restricted Project
hctim committed rL369551: [GWP-ASan] Build stack_trace_compressor_fuzzer..
[GWP-ASan] Build stack_trace_compressor_fuzzer.
Aug 21 2019, 10:54 AM
hctim closed D66494: [GWP-ASan] Build stack_trace_compressor_fuzzer..
Aug 21 2019, 10:54 AM · Restricted Project, Restricted Project

Aug 20 2019

hctim updated the diff for D66494: [GWP-ASan] Build stack_trace_compressor_fuzzer..
  • Reverse order of fuzzer dependencies.
Aug 20 2019, 6:01 PM · Restricted Project, Restricted Project
hctim added inline comments to D66494: [GWP-ASan] Build stack_trace_compressor_fuzzer..
Aug 20 2019, 6:01 PM · Restricted Project, Restricted Project
hctim added inline comments to D62875: [GWP-ASan] Add public-facing documentation [6]..
Aug 20 2019, 4:48 PM · Restricted Project, Restricted Project
hctim created D66494: [GWP-ASan] Build stack_trace_compressor_fuzzer..
Aug 20 2019, 1:37 PM · Restricted Project, Restricted Project
hctim committed rG8f5e1755ca38: [GWP-ASan] Fix typos. (authored by hctim).
[GWP-ASan] Fix typos.
Aug 20 2019, 1:18 PM
hctim committed rL369433: [GWP-ASan] Fix typos..
[GWP-ASan] Fix typos.
Aug 20 2019, 1:17 PM
hctim closed D66311: [GWP-ASan] Fix typos..
Aug 20 2019, 1:17 PM · Restricted Project, Restricted Project
hctim added inline comments to D62875: [GWP-ASan] Add public-facing documentation [6]..
Aug 20 2019, 1:09 PM · Restricted Project, Restricted Project

Aug 19 2019

hctim updated the diff for D62875: [GWP-ASan] Add public-facing documentation [6]..
  • Update from Matt's comments.
Aug 19 2019, 4:14 PM · Restricted Project, Restricted Project
hctim added inline comments to D62875: [GWP-ASan] Add public-facing documentation [6]..
Aug 19 2019, 4:14 PM · Restricted Project, Restricted Project
hctim accepted D66231: [scudo][standalone] Fix malloc_iterate.

LGTM. Thanks :)

Aug 19 2019, 3:10 PM · Restricted Project, Restricted Project
hctim added inline comments to D66231: [scudo][standalone] Fix malloc_iterate.
Aug 19 2019, 2:18 PM · Restricted Project, Restricted Project

Aug 15 2019

hctim committed rGeffc28c1398d: Disable stack_trace_compressor_fuzzer. (authored by hctim).
Disable stack_trace_compressor_fuzzer.
Aug 15 2019, 7:04 PM
hctim committed rL369079: Disable stack_trace_compressor_fuzzer..
Disable stack_trace_compressor_fuzzer.
Aug 15 2019, 7:04 PM
hctim added a comment to D66189: [GWP-ASan] Implement stack frame compression..

Commit is still causing some build issues. I'll take a look shortly and rollback if necessary.

Aug 15 2019, 6:35 PM · Restricted Project, Restricted Project
hctim added inline comments to D62875: [GWP-ASan] Add public-facing documentation [6]..
Aug 15 2019, 5:08 PM · Restricted Project, Restricted Project
hctim updated the diff for D62875: [GWP-ASan] Add public-facing documentation [6]..
  • Addressed Matt's and Vlad's comments.
  • Updated memory overhead description in the docs.
Aug 15 2019, 5:08 PM · Restricted Project, Restricted Project
hctim committed rG4660ea953e55: Moved binary off add_llvm_executable. Used add_executable instead, as this… (authored by hctim).
Moved binary off add_llvm_executable. Used add_executable instead, as this…
Aug 15 2019, 4:50 PM
hctim committed rL369071: Moved binary off add_llvm_executable..
Moved binary off add_llvm_executable.
Aug 15 2019, 4:50 PM
hctim committed rG4be5d53a3322: Re-instate 369051. (authored by hctim).
Re-instate 369051.
Aug 15 2019, 4:31 PM
hctim added a comment to D66189: [GWP-ASan] Implement stack frame compression..

Looks like rL369051 was accidentally reverted by rL369055. Have fixed it in rL369067.

Aug 15 2019, 4:31 PM · Restricted Project, Restricted Project
hctim committed rL369067: Re-instate 369051..
Re-instate 369051.
Aug 15 2019, 4:27 PM
hctim added a comment to D66189: [GWP-ASan] Implement stack frame compression..

Hi. We believe this patch is causing a CMake error for out toolchian build:

-- Compiler-RT supported architectures: i386
CMake Error at /b/s/w/ir/k/llvm-project/compiler-rt/lib/gwp_asan/CMakeLists.txt:111 (target_link_options):
  Unknown CMake command "target_link_options".

Could you look into this? Thanks.

Aug 15 2019, 4:03 PM · Restricted Project, Restricted Project
hctim committed rG2fb4e754c64a: Guard fuzzer build behind Clang-only flags. (authored by hctim).
Guard fuzzer build behind Clang-only flags.
Aug 15 2019, 3:16 PM
hctim committed rL369055: Guard fuzzer build behind Clang-only flags..
Guard fuzzer build behind Clang-only flags.
Aug 15 2019, 3:15 PM
hctim created D66311: [GWP-ASan] Fix typos..
Aug 15 2019, 2:46 PM · Restricted Project, Restricted Project
hctim committed rGfdee340beabd: Remove CMake >= v3.13 target_link_options. Instead, use set_target_properties. (authored by hctim).
Remove CMake >= v3.13 target_link_options. Instead, use set_target_properties.
Aug 15 2019, 2:37 PM
hctim committed rL369051: Remove CMake >= v3.13 target_link_options..
Remove CMake >= v3.13 target_link_options.
Aug 15 2019, 2:33 PM
hctim committed rGbe8a2f75657b: [GWP-ASan] Implement stack frame compression. (authored by hctim).
[GWP-ASan] Implement stack frame compression.
Aug 15 2019, 2:09 PM
hctim committed rL369048: [GWP-ASan] Implement stack frame compression..
[GWP-ASan] Implement stack frame compression.
Aug 15 2019, 2:09 PM
hctim closed D66189: [GWP-ASan] Implement stack frame compression..
Aug 15 2019, 2:09 PM · Restricted Project, Restricted Project
hctim added inline comments to D66189: [GWP-ASan] Implement stack frame compression..
Aug 15 2019, 1:20 PM · Restricted Project, Restricted Project
hctim updated the diff for D66189: [GWP-ASan] Implement stack frame compression..
  • Removed ability to set trace length.
Aug 15 2019, 1:20 PM · Restricted Project, Restricted Project
hctim added inline comments to D66189: [GWP-ASan] Implement stack frame compression..
Aug 15 2019, 12:41 PM · Restricted Project, Restricted Project
hctim added inline comments to D66189: [GWP-ASan] Implement stack frame compression..
Aug 15 2019, 11:05 AM · Restricted Project, Restricted Project
hctim updated the diff for D66189: [GWP-ASan] Implement stack frame compression..
  • Updated with Vlad's comments.
Aug 15 2019, 11:05 AM · Restricted Project, Restricted Project

Aug 14 2019

hctim added inline comments to D66231: [scudo][standalone] Fix malloc_iterate.
Aug 14 2019, 11:19 AM · Restricted Project, Restricted Project

Aug 13 2019

hctim created D66189: [GWP-ASan] Implement stack frame compression..
Aug 13 2019, 5:15 PM · Restricted Project, Restricted Project

Aug 12 2019

hctim committed rG352d1b59c0c8: [GWP-ASan] Update backtrace function signature. (authored by hctim).
[GWP-ASan] Update backtrace function signature.
Aug 12 2019, 2:40 PM
hctim committed rL368619: [GWP-ASan] Update backtrace function signature..
[GWP-ASan] Update backtrace function signature.
Aug 12 2019, 2:36 PM
hctim closed D66099: [GWP-ASan] Update backtrace function signature..
Aug 12 2019, 2:35 PM · Restricted Project, Restricted Project
hctim added inline comments to D66099: [GWP-ASan] Update backtrace function signature..
Aug 12 2019, 2:07 PM · Restricted Project, Restricted Project
hctim updated the diff for D66099: [GWP-ASan] Update backtrace function signature..
  • Update comment format.
Aug 12 2019, 2:07 PM · Restricted Project, Restricted Project
hctim created D66099: [GWP-ASan] Update backtrace function signature..
Aug 12 2019, 11:20 AM · Restricted Project, Restricted Project

Aug 9 2019

hctim committed rGcace571c91ce: Revert "[asan_symbolize] Fix bug where the frame counter was not incremented." (authored by hctim).
Revert "[asan_symbolize] Fix bug where the frame counter was not incremented."
Aug 9 2019, 12:38 PM
hctim added a reverting change for rG52a36fae2a3f: [asan_symbolize] Fix bug where the frame counter was not incremented.: rGcace571c91ce: Revert "[asan_symbolize] Fix bug where the frame counter was not incremented.".
Aug 9 2019, 12:37 PM
hctim committed rL368472: Revert "[asan_symbolize] Fix bug where the frame counter was not incremented.".
Revert "[asan_symbolize] Fix bug where the frame counter was not incremented."
Aug 9 2019, 12:36 PM
hctim added a comment to rL368373: [asan_symbolize] Fix bug where the frame counter was not incremented..

Looks like this may have broken the sanitizer-android buildbot: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-android/builds/23393

Aug 9 2019, 11:47 AM
hctim accepted D66020: [libFuzzer] Merge: print stats after reading the output corpus dir..
Aug 9 2019, 11:18 AM · Restricted Project, Restricted Project

Aug 7 2019

hctim committed rGc96387fce36b: [HWASan] Use LLD for check-hwasan. (authored by hctim).
[HWASan] Use LLD for check-hwasan.
Aug 7 2019, 3:00 PM
hctim committed rL368218: [HWASan] Use LLD for check-hwasan..
[HWASan] Use LLD for check-hwasan.
Aug 7 2019, 3:00 PM

Aug 6 2019

hctim added a comment to rL368112: Added Delta IR Reduction Tool.

Broken on sanitizer-x86_64-linux-bootstrap-msan:

Aug 6 2019, 5:51 PM
hctim added a comment to D63672: Added Delta IR Reduction Tool.

rL368112 Still broken on sanitizer-x86_64-linux-bootstrap-msan:

Aug 6 2019, 5:51 PM · Restricted Project