Page MenuHomePhabricator
Feed Advanced Search

Oct 1 2015

yaron.keren added a comment to D13203: [Clang] - Massaging code to fix MSVS 2015 win32-release configuration.

clang can't generate Visual C++ debug info except line numbers yet, so building with VC is essential to development on Windows. While most people and our bots are still using VC 2013 going forward supporting VC 2015 (even with bugs) is worth a small patch.

Oct 1 2015, 7:58 AM

Sep 30 2015

yaron.keren updated subscribers of D13305: [InstCombine] Remove trivially empty lifetime start/end ranges..
Sep 30 2015, 1:48 PM

Sep 28 2015

yaron.keren updated subscribers of D13220: Optimize DeadCodeEliminationPass.
Sep 28 2015, 12:13 PM

Sep 27 2015

yaron.keren added a comment to D12950: [SCEV] Teach isLoopBackedgeGuardedByCond to exploit trip counts..

Please see http://llvm.org/pr24952

Sep 27 2015, 2:55 AM

Sep 26 2015

yaron.keren added a comment to D13128: Fix backend crash on multiple close of stdout..

Hi Dan, it makes sense that output streams should not usually be mixed together, especially if one is binary as you write.
This may or may not be a problem depending on what the user really wants. He may want to mix the outputs for whatever purposes or it may usually be a user error.
In any case, that's not how clang deal with usage or even internal unexpected errors. It asserts, print error messages but does not crash on purpose. Having clang crash here does not seem like a good solution and will result in this issue continue to surface again.

Sep 26 2015, 1:22 AM

Sep 24 2015

yaron.keren updated subscribers of D13128: Fix backend crash on multiple close of stdout..

The original commit http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20100816/106268.html by Dan Ghoman says:

Sep 24 2015, 7:26 AM
yaron.keren added a comment to D13128: Fix backend crash on multiple close of stdout..

When stdout goes elsewhere the console, the shell creates the the output file (pipe) and will close it when clang terminates so so why clang should close it at all ? it did not open it.

Sep 24 2015, 5:36 AM

Sep 18 2015

yaron.keren updated subscribers of D12970: SmallVector fix for use-after-dtor bug..
Sep 18 2015, 10:12 AM

Sep 17 2015

yaron.keren closed D11890: Fixed Visual Studio warnings..

r247972.

Sep 17 2015, 11:59 PM
yaron.keren accepted D11890: Fixed Visual Studio warnings..
Sep 17 2015, 11:36 PM

Sep 16 2015

yaron.keren updated subscribers of D12895: Let cxa_demangle.cpp compile with gcc/libstdc++ 4.8 and clang-cl/MSVC2013's STL..
Sep 16 2015, 12:35 AM

Sep 9 2015

yaron.keren updated subscribers of D12128: Generating available_externally vtables bugfix.
Sep 9 2015, 1:13 PM

Sep 8 2015

yaron.keren updated subscribers of D11890: Fixed Visual Studio warnings..

The asserts on unit tests, BitVectorTest/1.PortableBitMask that calls

Sep 8 2015, 7:20 AM

Sep 4 2015

yaron.keren added inline comments to D11890: Fixed Visual Studio warnings..
Sep 4 2015, 4:56 AM

Sep 3 2015

yaron.keren added a comment to D12087: always_inline codegen rewrite.

In CGCXX.cpp, may be fixable after this commit:

Sep 3 2015, 6:18 AM

Sep 1 2015

yaron.keren updated subscribers of D12509: [MC] Allow MCObjectWriter's output stream to be swapped out.
Sep 1 2015, 4:52 AM

Aug 29 2015

yaron.keren added a comment to D12466: Fix empty -L Path on OSX hosts.

I have never used OSX, Try to add one of the Apple clang developers as reviewers, they know more than me about OSX.

Aug 29 2015, 12:30 PM

Aug 27 2015

yaron.keren updated subscribers of D12087: always_inline codegen rewrite.
Aug 27 2015, 3:00 PM

Aug 20 2015

yaron.keren updated subscribers of D12199: Add framework for iterative compilation to llvm.
Aug 20 2015, 10:52 AM

Aug 15 2015

yaron.keren added inline comments to D11890: Fixed Visual Studio warnings..
Aug 15 2015, 12:40 PM
yaron.keren added a comment to D11890: Fixed Visual Studio warnings..

Fixed several ThreadSanitizer.cpp issues in r245167. I don't have VS2015 config to test the warning and the online compiler is out but

Aug 15 2015, 12:29 PM
yaron.keren added a comment to D11890: Fixed Visual Studio warnings..

Committed the X86ISelLowering.cpp patch in r245161.

Aug 15 2015, 10:10 AM

Aug 13 2015

yaron.keren added a comment to D11944: Nativize filename in FileManager::getFile()..

I think she wishes your second option.

Aug 13 2015, 5:37 AM
yaron.keren added inline comments to D11944: Nativize filename in FileManager::getFile()..
Aug 13 2015, 1:51 AM

Aug 12 2015

yaron.keren added a comment to D11808: Driver: Fix include and lib dirs when not using gcc under mingw.

Yes, go ahead.

Aug 12 2015, 9:45 PM

Aug 11 2015

yaron.keren added a comment to D11960: [windows] Always use the lit shell on Windows, even if bash is present.

Which tests? Can this be solved with a script for %run? A substitution in lit? It seems like a bug somewhere else. Why is TZ not being passed while other env vars are?

Aug 11 2015, 10:21 PM
yaron.keren added a comment to D11960: [windows] Always use the lit shell on Windows, even if bash is present.

The bash shell on Windows from MSYS expands anyhting that looks like a relative path, such as /m. It has workaround for switches but not for environment vas so tests using 'env' were failing without any way to fix. In addition, it did not pass environment variable TZ since it does not know how ot map between Unix and Windows TZ. This also broke tests.

Aug 11 2015, 2:59 PM
yaron.keren added a comment to D11944: Nativize filename in FileManager::getFile()..

There is also the case insensitivity issue, see

Aug 11 2015, 7:46 AM

Aug 10 2015

yaron.keren added inline comments to D11890: Fixed Visual Studio warnings..
Aug 10 2015, 9:48 AM
yaron.keren updated subscribers of D11651: [LVI] Improve LazyValueInfo compile time performance.
Aug 10 2015, 2:25 AM
yaron.keren added a comment to D11890: Fixed Visual Studio warnings..

In what configuration: VC, target do you see the warnings?

Aug 10 2015, 12:01 AM

Aug 6 2015

yaron.keren accepted D11808: Driver: Fix include and lib dirs when not using gcc under mingw.

This LGTM after modifying test/Driver/mingw.cpp to test for this, i.e. create a Inputs/no_gcc_tree/usr directory tree without the gcc dirs, point sysroot and check the output directories. It's mostly copy & paste from one of the existing cases.

Aug 6 2015, 11:14 AM

Jul 29 2015

yaron.keren closed D11594: Fix NAME.1 comdat name for replaced GlobalVariable.

r243525 with expanded testcase.

Jul 29 2015, 9:04 AM
yaron.keren retitled D11594: Fix NAME.1 comdat name for replaced GlobalVariable from to Fix NAME.1 comdat name for replaced GlobalVariable.
Jul 29 2015, 8:17 AM

Jul 27 2015

yaron.keren accepted D11527: docs: update arcanist links.

LGTM
Aside from the test commit, in the future you can fix broken links without review, that's trivial.

Jul 27 2015, 8:41 AM

Jul 23 2015

yaron.keren added a comment to D11446: For loop style fix.

BB very frequently is BasicBlock and I is Instruction, typically in loops

Jul 23 2015, 12:34 PM
yaron.keren closed D11347: Fix building with cmake 2.8.4 or greater under cygwin hosts.

r242993

Jul 23 2015, 1:33 AM
yaron.keren accepted D11347: Fix building with cmake 2.8.4 or greater under cygwin hosts.
Jul 23 2015, 1:32 AM

Jul 22 2015

yaron.keren added inline comments to D11347: Fix building with cmake 2.8.4 or greater under cygwin hosts.
Jul 22 2015, 1:38 PM
yaron.keren closed D11349: Add Support for the cygwin64 target.
Jul 22 2015, 11:09 AM
yaron.keren accepted D11349: Add Support for the cygwin64 target.

r242914

Jul 22 2015, 11:09 AM

Jul 21 2015

yaron.keren added a comment to D11349: Add Support for the cygwin64 target.

LGTM after fixing the comment.

Jul 21 2015, 3:05 AM

Jul 20 2015

yaron.keren added a comment to D11349: Add Support for the cygwin64 target.

What target cygwin x64 uses on current SVN? or we have 32 bits only?

Jul 20 2015, 3:12 AM
yaron.keren updated subscribers of D11349: Add Support for the cygwin64 target.
Jul 20 2015, 3:10 AM
yaron.keren added a comment to D11349: Add Support for the cygwin64 target.

All these classes are already inside a bug anonymous namespace and so is the new one you add, this is OK.

Jul 20 2015, 3:10 AM
yaron.keren added a reviewer for D11347: Fix building with cmake 2.8.4 or greater under cygwin hosts: chapuni.

Hi Chapuni, does this Cygwin change makes sense to you?

Jul 20 2015, 12:28 AM
yaron.keren added a comment to D11237: Add support for -rtlib option and -stdlib option to the mingw driver.

I just added support for Arch Linux to MinGWToolChain.cpp. It appears that all permutations of {"usr" "lib" "lib64" "gcc" gcc-ver Arch } for the mingw include and lib directories actually exist on the various platforms.

Jul 20 2015, 12:26 AM

Jul 15 2015

yaron.keren added a reviewer for D11237: Add support for -rtlib option and -stdlib option to the mingw driver: rnk.
Jul 15 2015, 1:38 PM
yaron.keren updated subscribers of D11237: Add support for -rtlib option and -stdlib option to the mingw driver.
Jul 15 2015, 1:37 PM
yaron.keren updated subscribers of D11232: Always run GlobalDCE before the inliner.
Jul 15 2015, 12:03 PM
yaron.keren closed D11071: Add Windows ARM targets for mingw and cygwin to clang.
Jul 15 2015, 6:48 AM
yaron.keren accepted D11071: Add Windows ARM targets for mingw and cygwin to clang.

I merged the anonymous namespaces to the existing one, r242292.

Jul 15 2015, 6:48 AM

Jul 14 2015

yaron.keren added a comment to D10524: Clang/driver: emulated TLS mode..

mingw on Windows uses emutls, so an option to do the same makes sense, maybe even the default to keep compatibility.

Jul 14 2015, 12:24 PM

Jul 13 2015

yaron.keren added a comment to D11071: Add Windows ARM targets for mingw and cygwin to clang.

Also, please base the diff from top-level llvm directory not from clang subdir, so that the diff starts with:

Jul 13 2015, 11:16 PM
yaron.keren requested changes to D11071: Add Windows ARM targets for mingw and cygwin to clang.

This does not compile against SVN. Please update and run tests.

Jul 13 2015, 11:15 PM
yaron.keren closed D11075: LLVM gen correct asm info for mingw and cygwin arm targets.
Jul 13 2015, 11:13 PM
yaron.keren accepted D11075: LLVM gen correct asm info for mingw and cygwin arm targets.

r242123

Jul 13 2015, 11:13 PM
yaron.keren closed D11088: Clang: Add support for -fuse-ld= in the mingw driver.

r242121

Jul 13 2015, 10:47 PM

Jul 10 2015

yaron.keren accepted D11087: -no-pthread option for mingw-w64.

Committed revision 241929.

Jul 10 2015, 11:42 AM
yaron.keren updated subscribers of D11088: Clang: Add support for -fuse-ld= in the mingw driver.
Jul 10 2015, 9:52 AM
yaron.keren resigned from D11088: Clang: Add support for -fuse-ld= in the mingw driver.
Jul 10 2015, 9:52 AM
yaron.keren added a comment to D11087: -no-pthread option for mingw-w64.

I see, mingw-w64-v4.0.2\mingw-w64-libraries\winpthreads\Makefile.am indeed passes -no-pthread when building winpthreads since pthreads is not available at that time and it is linked by default. clang does not link by default but errors on -no-pthread. I'll commit this switch to avoid the error but we may ignore it otherwise.

Jul 10 2015, 8:34 AM

Jul 9 2015

yaron.keren added a comment to D11087: -no-pthread option for mingw-w64.

The issue is that gcc accepts -no-pthread while clang errors on it. We may wish to accept -no-pthread even if it has no tunction just for gcc compatibility.

Jul 9 2015, 10:07 PM
yaron.keren added a comment to D11077: Clang: add support to mingw driver for compiler-rt, libc++ and lld.

Could you break this into five independent patches so they may be discussed (and approved) one by one?

Jul 9 2015, 1:02 PM
yaron.keren updated subscribers of D11077: Clang: add support to mingw driver for compiler-rt, libc++ and lld.
Jul 9 2015, 12:49 PM
yaron.keren updated subscribers of D601: Clang cmake fix for lib naming http://llvm.org/bugs/show_bug.cgi?id=13909.
Jul 9 2015, 12:04 PM
yaron.keren updated subscribers of D11071: Add Windows ARM targets for mingw and cygwin to clang.
Jul 9 2015, 12:04 PM
yaron.keren updated subscribers of D11075: LLVM gen correct asm info for mingw and cygwin arm targets.
Jul 9 2015, 12:04 PM
yaron.keren added a comment to D601: Clang cmake fix for lib naming http://llvm.org/bugs/show_bug.cgi?id=13909.

On my mingw 4.9.1 builds (without this patch) I get "libclang.dll" and not "liblibclang.dll".
Do you still get "liblibclang.dll" with current SVN (without this patch) ?

Jul 9 2015, 12:01 PM
yaron.keren added a comment to D11075: LLVM gen correct asm info for mingw and cygwin arm targets.

Hi, could you update both patches with more context as detailed in

Jul 9 2015, 11:30 AM
yaron.keren abandoned D10949: A step towards getting libclang tests working on Windows.

Committed revision 241789.

Jul 9 2015, 1:37 AM

Jul 6 2015

yaron.keren updated subscribers of D10984: Redirect DataLayout from TargetMachine to Module in MachineFunction.
Jul 6 2015, 10:59 PM
yaron.keren updated the diff for D10949: A step towards getting libclang tests working on Windows.

Changed type, name of input argument of clang_free and its description.

Jul 6 2015, 11:24 AM

Jul 5 2015

yaron.keren retitled D10949: A step towards getting libclang tests working on Windows from to A step towards getting libclang tests working on Windows.
Jul 5 2015, 1:21 PM

Jul 1 2015

yaron.keren closed D5268: Mingw-w64 driver for clang.

Thanks!, committed revision 241241.

Jul 1 2015, 9:54 PM

Jun 30 2015

yaron.keren abandoned D4177: [Clang] Implement basic MinGW32 version-independent installation detection.
Jun 30 2015, 10:19 PM
yaron.keren commandeered D4177: [Clang] Implement basic MinGW32 version-independent installation detection.

Superceded by http://reviews.llvm.org/D5268

Jun 30 2015, 10:19 PM
yaron.keren updated the diff for D5268: Mingw-w64 driver for clang.

Reduce nesting level in Base selection logic.

Jun 30 2015, 8:21 AM
yaron.keren updated the diff for D5268: Mingw-w64 driver for clang.

For interactive work I prefer to change path since typing gcc at the command line finds the same one clang would find.

Jun 30 2015, 7:55 AM
yaron.keren updated the diff for D5268: Mingw-w64 driver for clang.

Fix for Cygnus C include path.

Jun 30 2015, 5:54 AM
yaron.keren updated the diff for D5268: Mingw-w64 driver for clang.

OK, here is an updated patch for ToT.

Jun 30 2015, 5:43 AM
yaron.keren commandeered D5268: Mingw-w64 driver for clang.
Jun 30 2015, 5:35 AM

Jun 29 2015

yaron.keren updated subscribers of D10823: Remove DataLayout access from the TargetMachine, redirect to the Module .
Jun 29 2015, 11:04 PM

Jun 24 2015

yaron.keren updated subscribers of D10524: Clang/driver: emulated TLS mode..
Jun 24 2015, 6:34 PM
yaron.keren updated subscribers of D10522: Implement target independent TLS compatible with glibc's emutls.c..
Jun 24 2015, 6:33 PM

May 28 2015

yaron.keren accepted D10102: [CMake] Bug 23468 - LLVM_OPTIMIZED_TABLEGEN does not work with Visual Studio.

This works well with Visual C++ 2013, LGTM.
Thanks for fixing this!

May 28 2015, 2:24 PM

May 26 2015

yaron.keren updated subscribers of D10036: [LLD] Add a new PE/COFF port.
May 26 2015, 12:37 PM

May 13 2015

yaron.keren added inline comments to D5268: Mingw-w64 driver for clang.
May 13 2015, 11:03 PM

May 8 2015

yaron.keren added a comment to D5268: Mingw-w64 driver for clang.

I totally agree with Reid, clang should work outside the mingw directory not only for us developers but as the default result of someone installing mingw-w64 at one location and then using the official LLVM installer to install clang at c:\Program Files (X86). This combination will not work with the clang in gcc bin assumption.

May 8 2015, 11:04 AM

May 5 2015

yaron.keren updated subscribers of D9509: [cuda] Driver changes to build and stitch together host and device-side CUDA code..
May 5 2015, 10:32 PM

Apr 24 2015

yaron.keren accepted D9196: Fix APInt long division algorithm.

Ok, this LGTM. Commit the patch?

Apr 24 2015, 12:11 AM

Apr 22 2015

yaron.keren added inline comments to D9196: Fix APInt long division algorithm.
Apr 22 2015, 10:10 AM
yaron.keren added a comment to D9196: Fix APInt long division algorithm.

I'll have a look.

Apr 22 2015, 9:41 AM
yaron.keren added a comment to D9133: Driver tests: don't assume the clang binary is called 'clang'.

Great idea!

Apr 22 2015, 9:13 AM

Apr 9 2015

yaron.keren updated subscribers of D8935: Simplify use of formatted_raw_ostream.
Apr 9 2015, 1:36 PM
yaron.keren updated subscribers of D8717: Add a callback to FunctionPass to enable skipping execution on a per-function basis.
Apr 9 2015, 9:07 AM

Mar 26 2015

yaron.keren closed D8448: Fix APInt division algorithm.

Sure, committed revision 233312.

Mar 26 2015, 12:51 PM
yaron.keren accepted D8448: Fix APInt division algorithm.

Minor nitpicks, LGTM.

Mar 26 2015, 1:07 AM

Mar 25 2015

yaron.keren updated subscribers of D8619: Keep track of canonical decls in Redeclarable..
Mar 25 2015, 3:28 PM

Mar 24 2015

yaron.keren updated subscribers of D8448: Fix APInt division algorithm.
Mar 24 2015, 9:02 AM