Page MenuHomePhabricator
Feed Advanced Search

Aug 6 2015

yaron.keren accepted D11808: Driver: Fix include and lib dirs when not using gcc under mingw.

This LGTM after modifying test/Driver/mingw.cpp to test for this, i.e. create a Inputs/no_gcc_tree/usr directory tree without the gcc dirs, point sysroot and check the output directories. It's mostly copy & paste from one of the existing cases.

Aug 6 2015, 11:14 AM

Jul 29 2015

yaron.keren closed D11594: Fix NAME.1 comdat name for replaced GlobalVariable.

r243525 with expanded testcase.

Jul 29 2015, 9:04 AM
yaron.keren retitled D11594: Fix NAME.1 comdat name for replaced GlobalVariable from to Fix NAME.1 comdat name for replaced GlobalVariable.
Jul 29 2015, 8:17 AM

Jul 27 2015

yaron.keren accepted D11527: docs: update arcanist links.

LGTM
Aside from the test commit, in the future you can fix broken links without review, that's trivial.

Jul 27 2015, 8:41 AM

Jul 23 2015

yaron.keren added a comment to D11446: For loop style fix.

BB very frequently is BasicBlock and I is Instruction, typically in loops

Jul 23 2015, 12:34 PM
yaron.keren closed D11347: Fix building with cmake 2.8.4 or greater under cygwin hosts.

r242993

Jul 23 2015, 1:33 AM
yaron.keren accepted D11347: Fix building with cmake 2.8.4 or greater under cygwin hosts.
Jul 23 2015, 1:32 AM

Jul 22 2015

yaron.keren added inline comments to D11347: Fix building with cmake 2.8.4 or greater under cygwin hosts.
Jul 22 2015, 1:38 PM
yaron.keren closed D11349: Add Support for the cygwin64 target.
Jul 22 2015, 11:09 AM
yaron.keren accepted D11349: Add Support for the cygwin64 target.

r242914

Jul 22 2015, 11:09 AM

Jul 21 2015

yaron.keren added a comment to D11349: Add Support for the cygwin64 target.

LGTM after fixing the comment.

Jul 21 2015, 3:05 AM

Jul 20 2015

yaron.keren added a comment to D11349: Add Support for the cygwin64 target.

What target cygwin x64 uses on current SVN? or we have 32 bits only?

Jul 20 2015, 3:12 AM
yaron.keren updated subscribers of D11349: Add Support for the cygwin64 target.
Jul 20 2015, 3:10 AM
yaron.keren added a comment to D11349: Add Support for the cygwin64 target.

All these classes are already inside a bug anonymous namespace and so is the new one you add, this is OK.

Jul 20 2015, 3:10 AM
yaron.keren added a reviewer for D11347: Fix building with cmake 2.8.4 or greater under cygwin hosts: chapuni.

Hi Chapuni, does this Cygwin change makes sense to you?

Jul 20 2015, 12:28 AM
yaron.keren added a comment to D11237: Add support for -rtlib option and -stdlib option to the mingw driver.

I just added support for Arch Linux to MinGWToolChain.cpp. It appears that all permutations of {"usr" "lib" "lib64" "gcc" gcc-ver Arch } for the mingw include and lib directories actually exist on the various platforms.

Jul 20 2015, 12:26 AM

Jul 15 2015

yaron.keren added a reviewer for D11237: Add support for -rtlib option and -stdlib option to the mingw driver: rnk.
Jul 15 2015, 1:38 PM
yaron.keren updated subscribers of D11237: Add support for -rtlib option and -stdlib option to the mingw driver.
Jul 15 2015, 1:37 PM
yaron.keren closed D11071: Add Windows ARM targets for mingw and cygwin to clang.
Jul 15 2015, 6:48 AM
yaron.keren accepted D11071: Add Windows ARM targets for mingw and cygwin to clang.

I merged the anonymous namespaces to the existing one, r242292.

Jul 15 2015, 6:48 AM

Jul 14 2015

yaron.keren added a comment to D10524: Clang/driver: emulated TLS mode..

mingw on Windows uses emutls, so an option to do the same makes sense, maybe even the default to keep compatibility.

Jul 14 2015, 12:24 PM

Jul 13 2015

yaron.keren added a comment to D11071: Add Windows ARM targets for mingw and cygwin to clang.

Also, please base the diff from top-level llvm directory not from clang subdir, so that the diff starts with:

Jul 13 2015, 11:16 PM
yaron.keren requested changes to D11071: Add Windows ARM targets for mingw and cygwin to clang.

This does not compile against SVN. Please update and run tests.

Jul 13 2015, 11:15 PM
yaron.keren closed D11075: LLVM gen correct asm info for mingw and cygwin arm targets.
Jul 13 2015, 11:13 PM
yaron.keren accepted D11075: LLVM gen correct asm info for mingw and cygwin arm targets.

r242123

Jul 13 2015, 11:13 PM
yaron.keren closed D11088: Clang: Add support for -fuse-ld= in the mingw driver.

r242121

Jul 13 2015, 10:47 PM

Jul 10 2015

yaron.keren accepted D11087: -no-pthread option for mingw-w64.

Committed revision 241929.

Jul 10 2015, 11:42 AM
yaron.keren resigned from D11088: Clang: Add support for -fuse-ld= in the mingw driver.
Jul 10 2015, 9:52 AM
yaron.keren added a comment to D11087: -no-pthread option for mingw-w64.

I see, mingw-w64-v4.0.2\mingw-w64-libraries\winpthreads\Makefile.am indeed passes -no-pthread when building winpthreads since pthreads is not available at that time and it is linked by default. clang does not link by default but errors on -no-pthread. I'll commit this switch to avoid the error but we may ignore it otherwise.

Jul 10 2015, 8:34 AM

Jul 9 2015

yaron.keren added a comment to D11087: -no-pthread option for mingw-w64.

The issue is that gcc accepts -no-pthread while clang errors on it. We may wish to accept -no-pthread even if it has no tunction just for gcc compatibility.

Jul 9 2015, 10:07 PM
yaron.keren added a comment to D11077: Clang: add support to mingw driver for compiler-rt, libc++ and lld.

Could you break this into five independent patches so they may be discussed (and approved) one by one?

Jul 9 2015, 1:02 PM
yaron.keren updated subscribers of D11077: Clang: add support to mingw driver for compiler-rt, libc++ and lld.
Jul 9 2015, 12:49 PM
yaron.keren updated subscribers of D601: Clang cmake fix for lib naming http://llvm.org/bugs/show_bug.cgi?id=13909.
Jul 9 2015, 12:04 PM
yaron.keren updated subscribers of D11071: Add Windows ARM targets for mingw and cygwin to clang.
Jul 9 2015, 12:04 PM
yaron.keren updated subscribers of D11075: LLVM gen correct asm info for mingw and cygwin arm targets.
Jul 9 2015, 12:04 PM
yaron.keren added a comment to D601: Clang cmake fix for lib naming http://llvm.org/bugs/show_bug.cgi?id=13909.

On my mingw 4.9.1 builds (without this patch) I get "libclang.dll" and not "liblibclang.dll".
Do you still get "liblibclang.dll" with current SVN (without this patch) ?

Jul 9 2015, 12:01 PM
yaron.keren added a comment to D11075: LLVM gen correct asm info for mingw and cygwin arm targets.

Hi, could you update both patches with more context as detailed in

Jul 9 2015, 11:30 AM
yaron.keren abandoned D10949: A step towards getting libclang tests working on Windows.

Committed revision 241789.

Jul 9 2015, 1:37 AM

Jul 6 2015

yaron.keren updated the diff for D10949: A step towards getting libclang tests working on Windows.

Changed type, name of input argument of clang_free and its description.

Jul 6 2015, 11:24 AM

Jul 5 2015

yaron.keren retitled D10949: A step towards getting libclang tests working on Windows from to A step towards getting libclang tests working on Windows.
Jul 5 2015, 1:21 PM

Jul 1 2015

yaron.keren closed D5268: Mingw-w64 driver for clang.

Thanks!, committed revision 241241.

Jul 1 2015, 9:54 PM

Jun 30 2015

yaron.keren abandoned D4177: [Clang] Implement basic MinGW32 version-independent installation detection.
Jun 30 2015, 10:19 PM
yaron.keren commandeered D4177: [Clang] Implement basic MinGW32 version-independent installation detection.

Superceded by http://reviews.llvm.org/D5268

Jun 30 2015, 10:19 PM
yaron.keren updated the diff for D5268: Mingw-w64 driver for clang.

Reduce nesting level in Base selection logic.

Jun 30 2015, 8:21 AM
yaron.keren updated the diff for D5268: Mingw-w64 driver for clang.

For interactive work I prefer to change path since typing gcc at the command line finds the same one clang would find.

Jun 30 2015, 7:55 AM
yaron.keren updated the diff for D5268: Mingw-w64 driver for clang.

Fix for Cygnus C include path.

Jun 30 2015, 5:54 AM
yaron.keren updated the diff for D5268: Mingw-w64 driver for clang.

OK, here is an updated patch for ToT.

Jun 30 2015, 5:43 AM
yaron.keren commandeered D5268: Mingw-w64 driver for clang.
Jun 30 2015, 5:35 AM

May 28 2015

yaron.keren accepted D10102: [CMake] Bug 23468 - LLVM_OPTIMIZED_TABLEGEN does not work with Visual Studio.

This works well with Visual C++ 2013, LGTM.
Thanks for fixing this!

May 28 2015, 2:24 PM

May 13 2015

yaron.keren added inline comments to D5268: Mingw-w64 driver for clang.
May 13 2015, 11:03 PM

May 8 2015

yaron.keren added a comment to D5268: Mingw-w64 driver for clang.

I totally agree with Reid, clang should work outside the mingw directory not only for us developers but as the default result of someone installing mingw-w64 at one location and then using the official LLVM installer to install clang at c:\Program Files (X86). This combination will not work with the clang in gcc bin assumption.

May 8 2015, 11:04 AM

Apr 24 2015

yaron.keren accepted D9196: Fix APInt long division algorithm.

Ok, this LGTM. Commit the patch?

Apr 24 2015, 12:11 AM

Apr 22 2015

yaron.keren added inline comments to D9196: Fix APInt long division algorithm.
Apr 22 2015, 10:10 AM
yaron.keren added a comment to D9196: Fix APInt long division algorithm.

I'll have a look.

Apr 22 2015, 9:41 AM
yaron.keren added a comment to D9133: Driver tests: don't assume the clang binary is called 'clang'.

Great idea!

Apr 22 2015, 9:13 AM

Mar 26 2015

yaron.keren closed D8448: Fix APInt division algorithm.

Sure, committed revision 233312.

Mar 26 2015, 12:51 PM
yaron.keren accepted D8448: Fix APInt division algorithm.

Minor nitpicks, LGTM.

Mar 26 2015, 1:07 AM

Mar 18 2015

yaron.keren added a comment to rL232622: Remove many superfluous SmallString::str() calls..

Sorry about this! fixed in 232623/4.

Mar 18 2015, 4:01 AM

Mar 17 2015

yaron.keren closed D6372: Adding SmallString support to Twine.

Committed revision 232465.

Mar 17 2015, 2:54 AM

Mar 16 2015

yaron.keren updated the diff for D6372: Adding SmallString support to Twine.

Updated CopyString argument name to 'String'.

Mar 16 2015, 1:01 PM

Mar 15 2015

yaron.keren updated the diff for D6372: Adding SmallString support to Twine.

Implemented Paweł suggestion to use isSingleStringRef() to reduce the number of overloads. GetOrCreateSymbol, CopyString and MakeArgString accept only Twine now, virtual MakeArgString(StringRef) is still required and was renamed to MakeArgStringRef to avoid ambiguity with the Twine version.

Mar 15 2015, 10:54 PM
yaron.keren added a comment to D8182: LLD: Use std::vector to store SimpleReferences instead of linked list..

This may mean we need teach SmallVector to accept allocator like other ADT.

Mar 15 2015, 10:49 PM · lld

Mar 14 2015

yaron.keren updated the diff for D6372: Adding SmallString support to Twine.

Make MakeArgString and CopyString accept argument by reference.

Mar 14 2015, 9:54 AM
yaron.keren added inline comments to D6372: Adding SmallString support to Twine.
Mar 14 2015, 9:31 AM

Mar 10 2015

yaron.keren updated the diff for D6372: Adding SmallString support to Twine.

Rebased, added unit tests and some overloads to avoid ambiguity.

Mar 10 2015, 2:36 AM
yaron.keren retitled D6372: Adding SmallString support to Twine from Adding SmallString support to raw_ostream and Twine to Adding SmallString support to Twine.
Mar 10 2015, 2:35 AM

Jan 8 2015

yaron.keren abandoned D3686: Fix path concatenation in HeaderSearch.

Continued in http://reviews.llvm.org/D6871

Jan 8 2015, 1:47 AM
yaron.keren added a comment to D6871: Fix for include file resolution on Windows.

I've previously encountered a problem fixing this:

Jan 8 2015, 1:46 AM

Dec 29 2014

yaron.keren added a comment to D6790: Add a public accessor for GlobalCtors in CodeGenModule.

That's for Julia, right?

Dec 29 2014, 11:00 PM

Dec 24 2014

yaron.keren updated subscribers of D6775: CodeGen: correct debug info generation.
Dec 24 2014, 1:27 AM

Nov 22 2014

yaron.keren updated the diff for D6372: Adding SmallString support to Twine.

Correct missing empty line.

Nov 22 2014, 10:36 AM
yaron.keren retitled D6372: Adding SmallString support to Twine from to Adding SmallString support to raw_ostream and Twine.
Nov 22 2014, 10:34 AM

Nov 21 2014

yaron.keren added a comment to D6336: make SmallString::str() return std::string.

Hi David,

Nov 21 2014, 2:04 PM
yaron.keren added a comment to D6336: make SmallString::str() return std::string.

Thanks, I meant to call the StringRef conversion but ended up with empty StringRef.
I will first split the twine and raw_stream changes into their own patch so they will be easier to review.

Nov 21 2014, 12:41 PM

Nov 20 2014

yaron.keren retitled D6336: make SmallString::str() return std::string from to make SmallString::str() return std::string.
Nov 20 2014, 12:53 AM
yaron.keren abandoned D4245: Make ExecutionEngine::getPointerToGlobal understand GlobalAlias.

No JIT.

Nov 20 2014, 12:48 AM

Sep 15 2014

yaron.keren added a comment to D5349: MC: Add support for BigObj.

Visual C++ 2013 Update 2 does not like this change:

Sep 15 2014, 1:31 PM

Sep 10 2014

yaron.keren added a comment to D5268: Mingw-w64 driver for clang.

You can remove the // FIXME: comment in Driver.cpp.

Sep 10 2014, 1:15 AM

Sep 9 2014

yaron.keren retitled D3419: MinGW-w64 SEH on Win64 support (clang part) from SEH exceptions on Win64 (clang part) to MinGW-w64 SEH on Win64 support (clang part).
Sep 9 2014, 10:34 PM
yaron.keren added a comment to D3419: MinGW-w64 SEH on Win64 support (clang part).

Hi Alex,

Sep 9 2014, 10:31 PM
yaron.keren added a comment to D5268: Mingw-w64 driver for clang.

The llvm SEH patch

Sep 9 2014, 3:27 PM
yaron.keren added a comment to D5268: Mingw-w64 driver for clang.

Where can I see this SEH patch?

Sep 9 2014, 1:27 PM
yaron.keren updated subscribers of D5268: Mingw-w64 driver for clang.

(added cfe-commits)

Sep 9 2014, 1:18 PM
yaron.keren added a comment to D5268: Mingw-w64 driver for clang.

"This is really nice because it means that all you have to do is to set up your environment for building things for MinGW (put your gcc compiler or cross-compiler on PATH), and then invoke clang from anywhere."

Sep 9 2014, 12:12 PM
yaron.keren abandoned D4244: Avoid JIT recursive compilation.

JIT gone.

Sep 9 2014, 11:12 AM
yaron.keren added a comment to D4244: Avoid JIT recursive compilation.

JIT gone.

Sep 9 2014, 11:12 AM
yaron.keren abandoned D3818: Factor common code in JIT.

JIT gone.

Sep 9 2014, 11:12 AM
yaron.keren abandoned D3420: MinGW toolchain.
Sep 9 2014, 11:11 AM
yaron.keren added a comment to D3420: MinGW toolchain.

Sure, feel free to comandeer the revision or create a new one.

Sep 9 2014, 6:59 AM

Jul 23 2014

yaron.keren added a comment to D4245: Make ExecutionEngine::getPointerToGlobal understand GlobalAlias.

David, sorry for the late response, I had not seen an e-mail update from Phab, probably due to the e-mail problems it had.

Jul 23 2014, 1:15 AM
yaron.keren added a reviewer for D4245: Make ExecutionEngine::getPointerToGlobal understand GlobalAlias: lhames.
Jul 23 2014, 12:54 AM

Jun 22 2014

yaron.keren updated the test plan for D4245: Make ExecutionEngine::getPointerToGlobal understand GlobalAlias.
Jun 22 2014, 3:07 AM
yaron.keren retitled D4245: Make ExecutionEngine::getPointerToGlobal understand GlobalAlias from to Make ExecutionEngine::getPointerToGlobal understand GlobalAlias.
Jun 22 2014, 3:06 AM
yaron.keren updated the diff for D4244: Avoid JIT recursive compilation.

Calling getSimpleAliasee twice is not needed either.

Jun 22 2014, 2:54 AM
yaron.keren updated the diff for D4244: Avoid JIT recursive compilation.

Recursion not needed, just get the aliasee and continue.

Jun 22 2014, 2:50 AM
yaron.keren retitled D4244: Avoid JIT recursive compilation from to Avoid JIT recursive compilation.
Jun 22 2014, 2:41 AM

Jun 20 2014

yaron.keren added a comment to D4018: unsigned count() for ADT.

Richard, I reverted size_type to unsigned since size are counts are usually assumed in LLVM code to be unsigned.
We don't really need to 64 bit-sized containers (yet?) so better be safe rather than introduce possibly subtle bugs.

Jun 20 2014, 5:44 AM
yaron.keren added a comment to D4018: unsigned count() for ADT.

I modified size_type for BitVector back from size_t to unsigned.
The code caused a compile building failure on LP64 systems where sizeof(size_t)==sizeof(long) with template deduction in line 560. The failure could be fixed otherwise but anyhow I don't think that we have the need to store that many bits.

Jun 20 2014, 4:24 AM
yaron.keren closed D4018: unsigned count() for ADT.

r211350

Jun 20 2014, 3:38 AM

Jun 18 2014

yaron.keren added a comment to D4081: Generate SEH unwinding info on Win64.

You can run clang-format from the VC IDE on selected (marked) text only.However, it may be a good idea to reformat all the file if it does not conform to clang format.

Jun 18 2014, 1:45 PM