Page MenuHomePhabricator
Feed Advanced Search

Mon, Oct 7

yaron.keren closed D31540: Prefer non-friend to friend in in redeclaration chain.
Mon, Oct 7, 6:15 AM · Restricted Project

Feb 28 2018

yaron.keren resigned from D30170: Function definition may have uninstantiated body.
Feb 28 2018, 10:55 AM

Jun 12 2017

yaron.keren added a comment to D34086: Fix -print-after-all banner.

Added test in r305213.

Jun 12 2017, 11:07 AM

Jun 11 2017

yaron.keren created D34086: Fix -print-after-all banner.
Jun 11 2017, 1:30 AM

Apr 27 2017

yaron.keren added a comment to D32486: Cleanup pragma handlers after DoPrintPreprocessedInput.

OK

Apr 27 2017, 4:40 AM
yaron.keren added a comment to D32486: Cleanup pragma handlers after DoPrintPreprocessedInput.

Raphael , do you have commit access? should I commit this?

Apr 27 2017, 3:36 AM

Apr 25 2017

yaron.keren accepted D32486: Cleanup pragma handlers after DoPrintPreprocessedInput.

LGTM

Apr 25 2017, 7:59 AM
yaron.keren added a comment to D32486: Cleanup pragma handlers after DoPrintPreprocessedInput.

Please move the =new out of the PP.AddPragmaHandler calls.
While at it, this code still (as the original) leaks the PragmaHandlers. These should be deleted after RemovePragmaHandler or instead, simply use std::unique_ptr.

Apr 25 2017, 7:19 AM

Apr 17 2017

yaron.keren added a reviewer for D31540: Prefer non-friend to friend in in redeclaration chain: bkramer.
Apr 17 2017, 11:43 PM · Restricted Project
yaron.keren reopened D31540: Prefer non-friend to friend in in redeclaration chain.

reverted in r300497

Apr 17 2017, 11:42 PM · Restricted Project

Apr 14 2017

yaron.keren added reviewers for D15006: Driver: Better detection of mingw-gcc: mati865, rnk.

Adding Mateusz and Reid.

Apr 14 2017, 8:06 AM

Apr 12 2017

yaron.keren updated the diff for D31540: Prefer non-friend to friend in in redeclaration chain.

Added attribute test.

Apr 12 2017, 6:21 AM · Restricted Project

Apr 5 2017

yaron.keren added a comment to D31540: Prefer non-friend to friend in in redeclaration chain.

Thanks, I'll make a test.

Apr 5 2017, 12:23 PM · Restricted Project
yaron.keren added inline comments to D31702: Append -w when LLVM_ENABLE_WARNINGS is Off..
Apr 5 2017, 2:45 AM

Mar 31 2017

yaron.keren created D31540: Prefer non-friend to friend in in redeclaration chain.
Mar 31 2017, 9:12 AM · Restricted Project
yaron.keren added a comment to D31505: Do not close STD* descriptors.

r299207

Mar 31 2017, 5:22 AM

Mar 30 2017

yaron.keren created D31505: Do not close STD* descriptors.
Mar 30 2017, 12:27 PM
yaron.keren resigned from D14446: Fallback to getpwuid() in path::home_directory() on Unix..
Mar 30 2017, 12:09 PM
yaron.keren resigned from D9880: Fix Bug 23189 in C++14 type inference for lambdas with undeclared identifiers.
Mar 30 2017, 12:08 PM
yaron.keren abandoned D6336: make SmallString::str() return std::string.
Mar 30 2017, 12:07 PM
yaron.keren resigned from D15006: Driver: Better detection of mingw-gcc.
Mar 30 2017, 12:07 PM

Mar 29 2017

yaron.keren added a comment to D27051: [X86] Add NumRegisterParameters Module Flag.

No intention of any major work intended... just moved the code (locally) to Release and regression tests were still passing.

Mar 29 2017, 12:54 PM
yaron.keren added a comment to D27051: [X86] Add NumRegisterParameters Module Flag.

Most other module flags are added at CodeGenModule::Release(). For consistency, could this code be in CodeGenModule::Release() as well?

Mar 29 2017, 12:13 PM

Mar 21 2017

yaron.keren added a comment to D31187: Fix removal of out-of-line definitions..

Could use dumpDeclContext() to test?

Mar 21 2017, 8:11 AM

Feb 14 2017

yaron.keren added a comment to D29464: [MinGWToolChain] Don't use GCC headers on Win32.

OK.

Feb 14 2017, 11:14 AM · Restricted Project
yaron.keren added a comment to D29464: [MinGWToolChain] Don't use GCC headers on Win32.

If something is broken now we don't break it even more.
__float128 remain be fixed to be compatible, not only some poor developer would have to fix the missing headers bug one day, he will have to re-fix limits.h the right way and undo this "fix".
There is a problems with limits.h, fix limits.h. Don't make all headers that happens to be in the same directory as limits.h disappear.

Feb 14 2017, 5:37 AM · Restricted Project

Feb 13 2017

yaron.keren added a comment to D29464: [MinGWToolChain] Don't use GCC headers on Win32.

These directories are "mostly" equivalent, with some headers existing is mings gcc dir but missing in clang resource dir and thus will break compilation.
For example, the most popular (37089 download this week) https://sourceforge.net/projects/mingw-w64 distribuion for Windows had elected to place the includes

omp.h, quadmath.h, openacc.h

at

c:\mingw32\lib\gcc\i686-w64-mingw32\5.4.0\include\

with the corresponding libraries at

c:\mingw32\lib\gcc\i686-w64-mingw32\5.4.0\

I had verified this still holds true for the latest i686-6.3.0-release-posix-dwarf-rt_v5-rev1.7z package.
Removing the include dir will make clang less useful for mingw users using these includes, since they will not be found anymore.
Furthermore, It makes no sense to make such intrusive wide-ranging change where the original problem was with limits.h is actually due to:

/* The system's limits.h may, in turn, try to #include_next GCC's limits.h.
 Avert this #include_next madness. */
#if defined __GNUC__ && !defined _GCC_LIMITS_H_
#define _GCC_LIMITS_H_
#endif

so the solution may be as simple as

#if defined __GNUC__ && !defined _GCC_LIMITS_H_ && !defined __MINGW32__
#define _GCC_LIMITS_H_
#endif
Feb 13 2017, 10:03 PM · Restricted Project

Feb 9 2017

yaron.keren added a comment to D29464: [MinGWToolChain] Don't use GCC headers on Win32.

What about omp.h and openacc.h ? many programs are using OpenMP.

Feb 9 2017, 11:57 AM · Restricted Project
yaron.keren added a comment to D29464: [MinGWToolChain] Don't use GCC headers on Win32.

The gcc include dirs in mingw contains headers not available esewhere and thus can't be removed.
Notable examples,

Feb 9 2017, 11:24 AM · Restricted Project

Feb 3 2017

yaron.keren added a comment to D29464: [MinGWToolChain] Don't use GCC headers on Win32.

Hiding these two include dirs removes many headers. Most has clang equivalents but not all of them.
For example quadmath.h is only there, and without the include path programs using it will fail to compile.

Feb 3 2017, 8:10 AM · Restricted Project
yaron.keren added a comment to D29464: [MinGWToolChain] Don't use GCC headers on Win32.

This code is actually used with Windows as well as Linux (with the exception of line 218), see the comment blocks above for detailed include dirs from all platforms from which it was derived.

Feb 3 2017, 4:34 AM · Restricted Project

Jan 21 2017

yaron.keren accepted D28620: Guard __gnuc_va_list typedef.

LGTM, matches the code in libstdc++ stdarg,h.
You can remove the 'hack' comment in line 46, __GNUC_VA_LIST is just a standard include guard for the typedef.

Jan 21 2017, 7:22 PM

Jan 12 2017

yaron.keren added a comment to D28399: PR31469: Don't add friend template class decls to redecl chain in dependent contexts..

@yaron.keren, it seems that http://llvm.org/pr30994 concerns friend function declarations. My current patch focuses on friend class templates. Perhaps we should open another review item for a fix of http://llvm.org/pr30994.

Jan 12 2017, 12:57 AM

Jan 6 2017

yaron.keren added a comment to D28399: PR31469: Don't add friend template class decls to redecl chain in dependent contexts..

While at it, http://llvm.org/pr30994

Jan 6 2017, 9:49 AM

Dec 29 2016

yaron.keren added inline comments to D27810: FileManager: mark virtual file entries as valid entries.
Dec 29 2016, 6:55 AM

Dec 12 2016

yaron.keren added inline comments to D27686: Add llvm::StringLiteral.
Dec 12 2016, 3:39 PM

Nov 29 2016

yaron.keren accepted D27049: [OpenCL] Refactor out ReadPipe/WritePipe.

LGTM after fixing the inline comment

Nov 29 2016, 12:35 PM

Nov 26 2016

yaron.keren added inline comments to D27049: [OpenCL] Refactor out ReadPipe/WritePipe.
Nov 26 2016, 12:31 PM

Sep 28 2016

yaron.keren updated subscribers of D24682: [PR30341] Alias must point to a definition.
Sep 28 2016, 9:42 AM

Jul 28 2016

yaron.keren added a comment to D22858: Fix DbgValue handling in SelectionDAG..

PR28749 was created with trunk clang on Ubuntu x64.
It reproduced reliably but is very fragile, changing just about anything in the code makes the problem disappear.

Jul 28 2016, 1:36 PM

Jul 27 2016

yaron.keren added a comment to D22858: Fix DbgValue handling in SelectionDAG..

I added a small reproducer for what is probably the same problem in

Jul 27 2016, 10:46 PM

Jun 8 2016

yaron.keren accepted D21117: Specify target in lifetime-asan test..

You mean
Some target platforms do not support -fsanitize=address.

Jun 8 2016, 3:14 AM

May 13 2016

yaron.keren accepted D20240: [clang-rename] Fix broken dependency on shared build..

result of r269402, LGTM

May 13 2016, 8:32 AM

Apr 21 2016

yaron.keren updated subscribers of D17392: Embed bitcode in object file (clang cc1 part).
Apr 21 2016, 5:16 PM

Apr 20 2016

yaron.keren accepted D19285: Tweaks to get_started.html, especially for Windows developers.

Ah, OK, I am using regular svn and thus did not counter this problem.
Could you detail this exactly, the problem happens when using git-svn with core.autocrlf config=true but not with svn?
LGTM with this addition.

Apr 20 2016, 9:41 AM
yaron.keren added a comment to D19285: Tweaks to get_started.html, especially for Windows developers.

AFAIK the eol type is decided by svn based the svn:eol-style property, so as long the files were checked in correctly and you do not override it specifically while svn checkout, it just works.
Did you encounter problems with eol ?

Apr 20 2016, 9:01 AM

Mar 5 2016

yaron.keren updated subscribers of D17908: Add Visual Studio Visualizers for more Clang types.
Mar 5 2016, 11:09 AM

Feb 28 2016

yaron.keren updated subscribers of D17695: clang-cl: Implement initial limited support for precompiled headers..
Feb 28 2016, 11:08 AM

Feb 22 2016

yaron.keren updated subscribers of D16821: Add whole-program vtable optimization feature to Clang..
Feb 22 2016, 2:31 PM

Feb 17 2016

yaron.keren accepted D15450: Avoid double deletion in Clang driver..

Would be nice to have CodeGenAction::TheModule redirect to CodeGeneratorImpl::M if possible, but that's for another patch. LGTM.

Feb 17 2016, 8:23 AM
yaron.keren added a comment to D15450: Avoid double deletion in Clang driver..

It certainly makes sense to redirect the module request to its owner instead of duplicating it in a local copy.

Feb 17 2016, 6:16 AM

Feb 11 2016

yaron.keren added a comment to D17183: Make TargetInfo store an actual DataLayout instead of a string..

We have tried to keep one copy of DataLayout around
http://reviews.llvm.org/D11103
Can it share the Module->getDataLayout() ?

Feb 11 2016, 7:41 PM

Jan 29 2016

yaron.keren updated subscribers of D15450: Avoid double deletion in Clang driver..
Jan 29 2016, 11:56 AM

Jan 28 2016

yaron.keren added a comment to D16478: Always build a new TypeSourceInfo for function templates with parameters.

The instantiated does get a new collection of ParmVarDecls while getting
the pattern Type which points to the pattern ParmVarDecls. So the
ParmVarDecls pointed in the instantiated are not the same as those pointed
by its Type.

Jan 28 2016, 2:07 PM
yaron.keren updated subscribers of D16478: Always build a new TypeSourceInfo for function templates with parameters.
Jan 28 2016, 12:39 PM

Jan 2 2016

yaron.keren updated subscribers of D15843: [ADT] Add a sum type abstraction for pointer-like types..
Jan 2 2016, 3:20 AM

Dec 27 2015

yaron.keren updated subscribers of D15784: Enable 2 warnings on MSVC, turn on StringPooling & intrinsic functions.
Dec 27 2015, 12:40 AM

Dec 21 2015

yaron.keren updated subscribers of D15686: PR25910: clang allows two var definitions with the same mangled name.
Dec 21 2015, 5:17 AM

Dec 18 2015

yaron.keren added a comment to D15553: PR25717: fatal IO error writing large outputs to console on Windows.

#define NOGDI
is also useful.

Dec 18 2015, 2:41 PM
yaron.keren added a comment to D15553: PR25717: fatal IO error writing large outputs to console on Windows.

+1 all general-purpose Windows stuff should move to WindowsSupport.h. I'm surprised we got away without so far.
We have NOMINMAX at lib/Driver/MSVCToolChain.cpp before Windows.h which should probably switched to use WindowsSupport.h.

Dec 18 2015, 2:40 PM
yaron.keren added a comment to D15553: PR25717: fatal IO error writing large outputs to console on Windows.

We don't support building with mingw.org.
mingw-w64 has its own versionhelpers.h with IsWindows8OrGreater(), at least from gcc 4.93, probably earlier.

Dec 18 2015, 12:15 AM

Dec 17 2015

yaron.keren updated subscribers of D15619: [Support] Make llvm::Timer reusable.
Dec 17 2015, 11:20 AM

Dec 16 2015

yaron.keren accepted D15006: Driver: Better detection of mingw-gcc.

LGTM with some tests cases.

Dec 16 2015, 12:54 PM
yaron.keren added a comment to D15579: Fix the failing windows clang unit tests. NFC.

http://bb.pgr.jp/grid

Dec 16 2015, 10:38 AM

Dec 14 2015

yaron.keren added inline comments to D15506: [ASTMatchers] Allow hasName() to look through inline namespaces.
Dec 14 2015, 2:02 PM
yaron.keren added a comment to D15506: [ASTMatchers] Allow hasName() to look through inline namespaces.

MSVC 2013 Update 5 accepts for (bool SkipUnwritten : {false, true}).
Possibly changed in one of the Updates?

Dec 14 2015, 1:40 PM
yaron.keren updated subscribers of D5744: Partial specialization after class template instantiation..
Dec 14 2015, 7:05 AM

Dec 11 2015

yaron.keren updated subscribers of D15384: Don't ask for the size of dependent integral types in template diffing.
Dec 11 2015, 10:16 AM

Dec 6 2015

yaron.keren updated subscribers of D15120: Add support for __float128 type to be used by targets that support it.
Dec 6 2015, 10:20 PM

Dec 3 2015

yaron.keren accepted D14965: [llc/opt] Add an option to run all passes twice.

Only abstracting the whole llc/opt drivers which is more trouble than this is worth.
Maybe a commment in llc that opt does something similar and vice versa.
LGTM.

Dec 3 2015, 1:35 PM

Dec 2 2015

yaron.keren added a comment to D14965: [llc/opt] Add an option to run all passes twice.

Do you see any reasonable way to share the duplicated code between llc.cpp and opt.cpp?

Dec 2 2015, 7:24 AM

Dec 1 2015

yaron.keren added a comment to D7718: Itanium ABI: Properly mangle extern "C" template arguments.

There is another copy of getEffectiveDeclContext in MicrosoftMangle.cpp which pre-commit was identical to this one.
Should it get this commit as well to keep both identical?
If so, could both copies of getEffectiveDeclContext be merged?

Dec 1 2015, 12:54 AM

Nov 26 2015

yaron.keren added a comment to D15006: Driver: Better detection of mingw-gcc.

findGccDir() can return llvm::ErrorOr<std::string> and then all Base assignments happen at the same if-elseif-else:

Nov 26 2015, 9:15 AM

Nov 25 2015

yaron.keren added a comment to D15006: Driver: Better detection of mingw-gcc.

This always searches for something-gcc and then discards the result if sysroot was provided, which is a waste.
Move the searching to a helper function and then it can be done only if sysroot was not provided, as it is now.

Nov 25 2015, 10:18 PM
yaron.keren updated subscribers of D15006: Driver: Better detection of mingw-gcc.
Nov 25 2015, 10:12 PM
yaron.keren added a comment to D14965: [llc/opt] Add an option to run all passes twice.

You are right, running passes over again for all but trivial code will not result in the same module.
The CloneModule approach should work.

Nov 25 2015, 6:27 AM
yaron.keren added a comment to D14965: [llc/opt] Add an option to run all passes twice.

Won't the second run output will overwrite the first run output?
If so, what do you think about renaming the second output so it may be binary compared to the first one?

Nov 25 2015, 6:16 AM

Nov 24 2015

yaron.keren added a comment to D14965: [llc/opt] Add an option to run all passes twice.

This makes sense.

Nov 24 2015, 1:42 PM
yaron.keren accepted D14963: [MCMachOStreamer] Properly reset CreatedADWARFSection.

We have been fixed such bugs before, usually when a data member is added to one of the Streamers, so LGTM.

Nov 24 2015, 1:35 PM
yaron.keren added a comment to D14965: [llc/opt] Add an option to run all passes twice.

That's a great idea. Maybe add a LIT test that uses this flag so breakages will be caught at the buildbots?

Nov 24 2015, 1:32 PM
yaron.keren updated subscribers of D14963: [MCMachOStreamer] Properly reset CreatedADWARFSection.
Nov 24 2015, 11:28 AM

Nov 20 2015

yaron.keren closed D14236: Unbreak build on OpenBSD.
Nov 20 2015, 10:47 PM
yaron.keren accepted D14236: Unbreak build on OpenBSD.

r253769

Nov 20 2015, 10:47 PM

Nov 19 2015

yaron.keren added a comment to D14054: Use hexadecimal floating point literals instead of decimal.

Visual C++ does not support hexadecimal floating point literals.
Since all of these are actually integers they should work without the ".0" and ".0f".

Nov 19 2015, 9:40 PM

Nov 16 2015

yaron.keren updated subscribers of D14687: Macro support in LLVM IR.
Nov 16 2015, 12:01 AM

Nov 15 2015

yaron.keren updated subscribers of D14690: Don't force std::set for SmallSet.
Nov 15 2015, 11:59 PM

Nov 11 2015

yaron.keren added a comment to D14454: [WinEH] Fix mutli-parent cloning.

Hi Andy,

Nov 11 2015, 9:03 AM

Nov 9 2015

yaron.keren updated subscribers of D14502: [PATCH] Do not create a clang-install target for MSVC solutions.
Nov 9 2015, 11:01 AM

Nov 4 2015

yaron.keren accepted D14164: Driver: fallback to parent directory of clang if no sysroot for mingw-w64 target.

The formatting is wrong, aligned to the left, clang-format the new code.

Nov 4 2015, 11:15 AM
yaron.keren accepted D14278: Fix unit tests on Windows: handle env vars with non-ASCII chars..

Neat and efficient, LGTM

Nov 4 2015, 12:20 AM

Nov 3 2015

yaron.keren updated subscribers of D14265: DI: Reverse direction of subprogram -> function edge..
Nov 3 2015, 11:17 AM
yaron.keren updated subscribers of D14164: Driver: fallback to parent directory of clang if no sysroot for mingw-w64 target.

We did not have cfe-commits as subscriber so I'm adding it now (this is a clang commit), see if someone would like to further comment.

Nov 3 2015, 8:30 AM
yaron.keren added a comment to D14278: Fix unit tests on Windows: handle env vars with non-ASCII chars..

I see the usage pattern is CopyEnvironment, push_back something, use std::vector<const char *> with ExecuteAndWait. For this you must have a consecutive vector of char * in memory, so someone will have to manage their lifetime. It's better not to leave this to the caller or split responsibility so you could objectize CopyEnvironment to do everything required:

Nov 3 2015, 6:09 AM
yaron.keren added inline comments to D14278: Fix unit tests on Windows: handle env vars with non-ASCII chars..
Nov 3 2015, 3:27 AM

Oct 29 2015

yaron.keren updated subscribers of D14179: Remove some legacy mingw-w64 gcc struct info.
Oct 29 2015, 11:52 AM
yaron.keren added a comment to D14164: Driver: fallback to parent directory of clang if no sysroot for mingw-w64 target.

This code was my first thought too, but I had been commented on the structure of very similar code in this file:

Oct 29 2015, 11:49 AM
yaron.keren added a comment to D14164: Driver: fallback to parent directory of clang if no sysroot for mingw-w64 target.

Yes, I think this is a better default than /usr.

Oct 29 2015, 8:52 AM
yaron.keren added a comment to D14164: Driver: fallback to parent directory of clang if no sysroot for mingw-w64 target.

The code could now be merged (untested). I disconnected the third part on purpose based on comment from Joerg Sonnenberger on the previous code that having else after #endif is confusing.

Oct 29 2015, 1:38 AM

Oct 12 2015

yaron.keren updated subscribers of D13647: Fix an occasional failure in fs::rename() if another process uses fs::openFileForRead() on the same file.
Oct 12 2015, 3:42 AM

Oct 5 2015

yaron.keren updated subscribers of D13443: Rework the LTO Pipeline, aligning closer to the O2/O3 pipeline..
Oct 5 2015, 12:40 PM