Page MenuHomePhabricator
Feed Advanced Search

Wed, Jul 21

tianqing added inline comments to D105462: [X86] Add CRC32 feature..
Wed, Jul 21, 12:31 AM · Restricted Project, Restricted Project

Tue, Jul 20

tianqing committed rGbec4a8157d67: [X86] Update MachineLoopInfo in CMOV conversion. (authored by tianqing).
[X86] Update MachineLoopInfo in CMOV conversion.
Tue, Jul 20, 7:54 PM
tianqing closed D104623: [X86] Update MachineLoopInfo in CMOV conversion..
Tue, Jul 20, 7:54 PM · Restricted Project
tianqing updated the diff for D105462: [X86] Add CRC32 feature..

Instead of using ImpliedFeatures, manually enable CRC32 in presence of SSE4.2.

Tue, Jul 20, 6:39 PM · Restricted Project, Restricted Project

Tue, Jul 6

tianqing added inline comments to D105462: [X86] Add CRC32 feature..
Tue, Jul 6, 12:40 AM · Restricted Project, Restricted Project
tianqing added reviewers for D105462: [X86] Add CRC32 feature.: RKSimon, craig.topper, pengfei, LuoYuanke.
Tue, Jul 6, 12:15 AM · Restricted Project, Restricted Project
tianqing requested review of D105462: [X86] Add CRC32 feature..
Tue, Jul 6, 12:02 AM · Restricted Project, Restricted Project

Jun 30 2021

tianqing updated the diff for D104623: [X86] Update MachineLoopInfo in CMOV conversion..

Update test.

Jun 30 2021, 8:23 PM · Restricted Project

Jun 29 2021

tianqing committed rG6178ddcd2b70: [X86] Add a test to reveal a bug in CMOV conversion. (authored by tianqing).
[X86] Add a test to reveal a bug in CMOV conversion.
Jun 29 2021, 1:38 AM
tianqing closed D104692: [X86] Add a test to reveal a bug in CMOV conversion..
Jun 29 2021, 1:37 AM · Restricted Project
tianqing committed rGd8faf03807ac: [X86] Add -mgeneral-regs-only support. (authored by tianqing).
[X86] Add -mgeneral-regs-only support.
Jun 29 2021, 1:05 AM
tianqing closed D103943: [X86] Add -mgeneral-regs-only support..
Jun 29 2021, 1:05 AM · Restricted Project

Jun 21 2021

tianqing added a comment to D103944: Set local_unnamed_addr for new library function declarations in InjectTLIMappings..

Ping.

Jun 21 2021, 11:47 PM · Restricted Project
tianqing added inline comments to D104623: [X86] Update MachineLoopInfo in CMOV conversion..
Jun 21 2021, 11:47 PM · Restricted Project
tianqing added reviewers for D104692: [X86] Add a test to reveal a bug in CMOV conversion.: pengfei, xbolva00.
Jun 21 2021, 11:28 PM · Restricted Project
tianqing requested review of D104692: [X86] Add a test to reveal a bug in CMOV conversion..
Jun 21 2021, 11:27 PM · Restricted Project
tianqing added inline comments to D103943: [X86] Add -mgeneral-regs-only support..
Jun 21 2021, 8:06 PM · Restricted Project
tianqing updated the diff for D103943: [X86] Add -mgeneral-regs-only support..

Fix lint comment.

Jun 21 2021, 7:50 PM · Restricted Project
tianqing updated subscribers of D104623: [X86] Update MachineLoopInfo in CMOV conversion..
Jun 21 2021, 1:51 AM · Restricted Project
tianqing added reviewers for D104623: [X86] Update MachineLoopInfo in CMOV conversion.: chandlerc, RKSimon, pengfei.
Jun 21 2021, 1:50 AM · Restricted Project
tianqing requested review of D104623: [X86] Update MachineLoopInfo in CMOV conversion..
Jun 21 2021, 1:46 AM · Restricted Project

Jun 18 2021

tianqing updated subscribers of D103944: Set local_unnamed_addr for new library function declarations in InjectTLIMappings..
Jun 18 2021, 2:07 AM · Restricted Project
tianqing updated subscribers of D103943: [X86] Add -mgeneral-regs-only support..
Jun 18 2021, 2:07 AM · Restricted Project

Jun 16 2021

tianqing added a comment to D103943: [X86] Add -mgeneral-regs-only support..

I don't know much about target feature inheritance - does this guarantee that the entire sse/avx/avx512 level chain is correctly disabled?

Jun 16 2021, 8:32 PM · Restricted Project
tianqing updated the diff for D103943: [X86] Add -mgeneral-regs-only support..

Respect order of options.

Jun 16 2021, 8:31 PM · Restricted Project

Jun 10 2021

tianqing updated the diff for D103944: Set local_unnamed_addr for new library function declarations in InjectTLIMappings..

Fix typos.

Jun 10 2021, 1:25 AM · Restricted Project
tianqing updated the summary of D103944: Set local_unnamed_addr for new library function declarations in InjectTLIMappings..
Jun 10 2021, 1:22 AM · Restricted Project

Jun 9 2021

tianqing added reviewers for D103944: Set local_unnamed_addr for new library function declarations in InjectTLIMappings.: fhahn, fpetrogalli.
Jun 9 2021, 1:15 AM · Restricted Project
tianqing updated the diff for D103944: Set local_unnamed_addr for new library function declarations in InjectTLIMappings..
Jun 9 2021, 1:12 AM · Restricted Project
tianqing requested review of D103944: Set local_unnamed_addr for new library function declarations in InjectTLIMappings..
Jun 9 2021, 12:55 AM · Restricted Project

Jun 8 2021

tianqing added reviewers for D103943: [X86] Add -mgeneral-regs-only support.: erichkeane, RKSimon, pengfei.
Jun 8 2021, 11:54 PM · Restricted Project
tianqing requested review of D103943: [X86] Add -mgeneral-regs-only support..
Jun 8 2021, 11:32 PM · Restricted Project

Apr 11 2021

tianqing added a comment to D99708: [X86] Enable compilation of user interrupt handlers..

Does anyone has further comments?

Apr 11 2021, 7:45 PM · Restricted Project, Restricted Project

Apr 7 2021

tianqing updated the diff for D99708: [X86] Enable compilation of user interrupt handlers..
Apr 7 2021, 7:42 PM · Restricted Project, Restricted Project

Apr 6 2021

tianqing updated the diff for D99708: [X86] Enable compilation of user interrupt handlers..

Update handling of -mcmodel=kernel.

Apr 6 2021, 1:20 AM · Restricted Project, Restricted Project

Apr 1 2021

tianqing requested review of D99708: [X86] Enable compilation of user interrupt handlers..
Apr 1 2021, 1:23 AM · Restricted Project, Restricted Project

Oct 20 2020

tianqing updated the diff for D89301: [X86] Add User Interrupts(UINTR) instructions.

Address review comments.

Oct 20 2020, 3:02 AM · Restricted Project, Restricted Project

Oct 18 2020

tianqing added a reviewer for D89301: [X86] Add User Interrupts(UINTR) instructions: pengfei.
Oct 18 2020, 6:39 PM · Restricted Project, Restricted Project

Oct 13 2020

tianqing added reviewers for D89301: [X86] Add User Interrupts(UINTR) instructions: craig.topper, RKSimon, LuoYuanke.
Oct 13 2020, 1:31 AM · Restricted Project, Restricted Project
tianqing requested review of D89301: [X86] Add User Interrupts(UINTR) instructions.
Oct 13 2020, 1:27 AM · Restricted Project, Restricted Project

Apr 8 2020

tianqing updated the diff for D77205: [X86] Add TSXLDTRK instructions..

Rebase

Apr 8 2020, 8:36 PM · Restricted Project
tianqing added a comment to D77205: [X86] Add TSXLDTRK instructions..

Can I just check it in after the rebase?

Apr 8 2020, 7:01 PM · Restricted Project

Apr 2 2020

tianqing updated the diff for D77205: [X86] Add TSXLDTRK instructions..

Removed extra "//".

Apr 2 2020, 9:08 PM · Restricted Project
tianqing updated the diff for D77205: [X86] Add TSXLDTRK instructions..

Updated to resolve conflicts with https://reviews.llvm.org/D77193.

Apr 2 2020, 9:08 PM · Restricted Project

Apr 1 2020

tianqing created D77205: [X86] Add TSXLDTRK instructions..
Apr 1 2020, 2:43 AM · Restricted Project
tianqing updated the diff for D77193: [X86] Add SERIALIZE instruction..
Apr 1 2020, 1:40 AM · Restricted Project

Mar 31 2020

tianqing created D77193: [X86] Add SERIALIZE instruction..
Mar 31 2020, 10:32 PM · Restricted Project

Jan 1 2020

tianqing added a comment to D71884: [OpenMP] Fix formatting of OpenMP error message..

Could someone help commit this patch? Thanks.

Jan 1 2020, 5:15 PM · Restricted Project

Dec 25 2019

tianqing added a reviewer for D71884: [OpenMP] Fix formatting of OpenMP error message.: ABataev.
Dec 25 2019, 6:41 PM · Restricted Project
tianqing created D71884: [OpenMP] Fix formatting of OpenMP error message..
Dec 25 2019, 6:41 PM · Restricted Project

Nov 7 2019

tianqing added inline comments to D68577: [LV] Apply sink-after & interleave-groups as VPlan transformations (NFC).
Nov 7 2019, 6:36 PM · Restricted Project
tianqing added a comment to D68577: [LV] Apply sink-after & interleave-groups as VPlan transformations (NFC).

The recommited patch is hitting an assert. See message and reduced test case below:

assertion failed at llvm/lib/Transforms/Vectorize/VPRecipeBuilder.h:91 in llvm::VPRecipeBase *llvm::VPRecipeBuilder::getRecipe(llvm::Instruction *): Ingredient2Recipe[I] != nullptr && "Ingredient doesn't have a recipe"

Nov 7 2019, 6:09 PM · Restricted Project

Nov 4 2019

tianqing created D69792: [NFC] Supress GCC "Bitfield too small to hold all values of enum" warning. .
Nov 4 2019, 2:04 AM · Restricted Project

Jun 3 2019

tianqing updated the diff for D62282: [X86] Add ENQCMD intrinsics..

Added doxygen comments of intrinsics in enqcmdintrin.h.

Jun 3 2019, 10:33 PM · Restricted Project, Restricted Project

May 22 2019

tianqing created D62282: [X86] Add ENQCMD intrinsics..
May 22 2019, 7:46 PM · Restricted Project, Restricted Project
tianqing created D62281: [X86] Add ENQCMD instructions..
May 22 2019, 7:41 PM · Restricted Project

Jan 31 2019

tianqing updated the diff for D40387: [X86][SSE]: Adding full coverage of MC encoding tests for the SSE isa sets.<NFC>.

Removed psubq from MMX-64.s.

Jan 31 2019, 12:55 AM · Restricted Project

Jan 28 2019

tianqing updated the diff for D40387: [X86][SSE]: Adding full coverage of MC encoding tests for the SSE isa sets.<NFC>.

Added crc32 tests.

Jan 28 2019, 6:56 PM · Restricted Project
tianqing updated the diff for D40387: [X86][SSE]: Adding full coverage of MC encoding tests for the SSE isa sets.<NFC>.

Moved psubq tests from MMX to SSE2

Jan 28 2019, 5:11 PM · Restricted Project

Jan 27 2019

tianqing updated the diff for D40387: [X86][SSE]: Adding full coverage of MC encoding tests for the SSE isa sets.<NFC>.

Fixed whitespace.

Jan 27 2019, 6:31 PM · Restricted Project
tianqing updated the diff for D40387: [X86][SSE]: Adding full coverage of MC encoding tests for the SSE isa sets.<NFC>.

Fix tests for pinsrw/pextrw/paddq.

Jan 27 2019, 6:24 PM · Restricted Project

Jan 24 2019

tianqing added a comment to D40387: [X86][SSE]: Adding full coverage of MC encoding tests for the SSE isa sets.<NFC>.

Also, please can you PCLMUL full coverage tests as well - AFAICT we have AVX variants tests but not non-VEX

Jan 24 2019, 12:09 AM · Restricted Project
tianqing updated the diff for D40387: [X86][SSE]: Adding full coverage of MC encoding tests for the SSE isa sets.<NFC>.

Added SSE4a tests.

Jan 24 2019, 12:04 AM · Restricted Project

Jan 22 2019

tianqing added a comment to D40387: [X86][SSE]: Adding full coverage of MC encoding tests for the SSE isa sets.<NFC>.

Why were the SSE4a tests removed? They should be split out, but I don't see any reason to remove them unless we already have equivalent coverage for them.

Jan 22 2019, 11:53 PM · Restricted Project
tianqing updated the diff for D40387: [X86][SSE]: Adding full coverage of MC encoding tests for the SSE isa sets.<NFC>.

Removed SSE4a tests. Split SSE4.1 and SSE4.2 tests.

Jan 22 2019, 7:15 PM · Restricted Project
tianqing added a comment to D41175: [X86][AVX512F_128]: Adding full coverage of MC encoding for the AVX512F_128 isa sets.<NFC>.

@RKSimon Yes, there are some non-EVEX encodings inside, so I'm trying to regenerate it.

Jan 22 2019, 6:06 PM · Restricted Project
tianqing added a comment to D40776: [X86][AVX512]: Adding full coverage of MC encoding for the AVX512 isa sets (w/o AVX512F).<NFC>.

@RKSimon Yes, there is some non-EVEX encoding inside, so I'm trying to regenerate it.

Jan 22 2019, 6:05 PM · Restricted Project
tianqing added a comment to D41173: [X86][AVX512F_256]: Adding full coverage of MC encoding for the AVX512F 256 bits isa sets.<NFC>.

@RKSimon Yes, there are some non-EVEX encodings inside, so I'm trying to regenerate it.

Jan 22 2019, 6:05 PM · Restricted Project

Jan 9 2019

tianqing added a reviewer for D40387: [X86][SSE]: Adding full coverage of MC encoding tests for the SSE isa sets.<NFC>: LuoYuanke.
Jan 9 2019, 6:24 PM · Restricted Project
tianqing added a reviewer for D40776: [X86][AVX512]: Adding full coverage of MC encoding for the AVX512 isa sets (w/o AVX512F).<NFC>: LuoYuanke.
Jan 9 2019, 6:24 PM · Restricted Project
tianqing commandeered D41175: [X86][AVX512F_128]: Adding full coverage of MC encoding for the AVX512F_128 isa sets.<NFC>.
Jan 9 2019, 6:08 PM · Restricted Project
tianqing commandeered D41173: [X86][AVX512F_256]: Adding full coverage of MC encoding for the AVX512F 256 bits isa sets.<NFC>.
Jan 9 2019, 6:07 PM · Restricted Project
tianqing commandeered D40776: [X86][AVX512]: Adding full coverage of MC encoding for the AVX512 isa sets (w/o AVX512F).<NFC>.
Jan 9 2019, 6:06 PM · Restricted Project
tianqing commandeered D40387: [X86][SSE]: Adding full coverage of MC encoding tests for the SSE isa sets.<NFC>.
Jan 9 2019, 6:05 PM · Restricted Project