Page MenuHomePhabricator
Feed Advanced Search

Jun 17 2020

mehdi_amini closed D82027: Remove "unused" member ModuleSlice from `struct OpenMPOpt`.
Jun 17 2020, 8:31 PM · Restricted Project
mehdi_amini added inline comments to D80358: [MLIR] Add RegionKindInterface.
Jun 17 2020, 8:31 PM · Restricted Project, Restricted Project
mehdi_amini created D82027: Remove "unused" member ModuleSlice from `struct OpenMPOpt`.
Jun 17 2020, 10:45 AM · Restricted Project

Jun 16 2020

mehdi_amini added a comment to D81422: Change filecheck default to dump input on failure.

I would also expect a simple command line flag to llvm-lit to be able to control this, rather than having to set an environment variable

Jun 16 2020, 2:50 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mehdi_amini added a comment to rG1d33c09f220e: [IR] Add nocapture & nosync to matrix intrinsics..

I'd expect this bot to send emails: http://lab.llvm.org:8011/builders/mlir-windows (?)
Otherwise we haven't migrated our build kite bots to buildbots so they don't send emails at the moment: https://buildkite.com/mlir/mlir-core

Jun 16 2020, 11:32 AM
mehdi_amini added a comment to D81109: llvm-link: Add support for archive files as inputs..

LGTM (after remaining minor inline comments)

Jun 16 2020, 11:32 AM · Restricted Project, Restricted Project
mehdi_amini added a comment to D81109: llvm-link: Add support for archive files as inputs..

LGTM, only one new auto in an existing code with 11 previous autos. Looks like consistent usage.

Jun 16 2020, 11:32 AM · Restricted Project, Restricted Project
mehdi_amini added a comment to rG9b72b47ed633: Revert "[mlir][Linalg] Retire C++ MatmulOp in favor of a linalg-ods-gen'd op.".

The stated reason for the revert seems a bit light to me here: there is no indication in the commit message of what is the problem from an upstream point of view.

Jun 16 2020, 2:43 AM
mehdi_amini added a comment to D80358: [MLIR] Add RegionKindInterface.

(Just did another pass)

Jun 16 2020, 12:30 AM · Restricted Project, Restricted Project

Jun 15 2020

mehdi_amini committed rGe81bf67e8cf9: [MLIR] Modify HasParent trait to allow one of several op's as a parent (authored by jurahul).
[MLIR] Modify HasParent trait to allow one of several op's as a parent
Jun 15 2020, 10:00 PM
mehdi_amini closed D81880: [MLIR] Modify HasParent trait to allow one of several op's as a parent.
Jun 15 2020, 10:00 PM · Restricted Project
mehdi_amini added a comment to D79507: [flang] Change DIE("unreachable") cases to use llvm_unreachable.

FYI the Release+Assert config is well supported: this my default local config and this the one used by many bots already.

Jun 15 2020, 9:28 PM · Restricted Project, Restricted Project
mehdi_amini added a comment to D81695: [flang] Turn off FLANG_ENABLE_WERROR by default.

@isuruf Are there some warning that cannot be removed with reasonable effort?

Jun 15 2020, 9:28 PM · Restricted Project, Restricted Project
mehdi_amini accepted D81874: [mlir] Remove EDSC LoopBuilder, derived classes and related functionality.

Nice to see the progress here :)

Jun 15 2020, 9:28 PM · Restricted Project
mehdi_amini added a comment to D81737: docker images for mlir-nvidia.

I don't know where is the best place for the Docker config to live, but there are some in the monorepo already FYI:

Yes, I'm aware of this. @asl recommended putting it in llvm-zorg, as this is there buildbot related things should go.
He also proposed moving the other buildbot Dockerfiles here.

Jun 15 2020, 8:55 PM · Restricted Project
mehdi_amini accepted D81903: [MLIR] Rework generate-test-checks.py to attach CHECK lines to the source (test) file..

Nice improvement, thanks!

Jun 15 2020, 8:55 PM · Restricted Project
mehdi_amini committed rGbd970ef7c6b2: Fix MLIR test after 1d33c09f220e: matrix intrinsics have "nocapture" on some… (authored by mehdi_amini).
Fix MLIR test after 1d33c09f220e: matrix intrinsics have "nocapture" on some…
Jun 15 2020, 4:04 PM
mehdi_amini added a comment to rG1d33c09f220e: [IR] Add nocapture & nosync to matrix intrinsics..

@fhahn can you please enable MLIR in your local build?
(This commit broke our bots, I fixed it)

Jun 15 2020, 4:02 PM
mehdi_amini added a comment to D81422: Change filecheck default to dump input on failure.

The amount of context printed previously was good enough for development use. If I ever can't figure it out from the diff, I want to look at the output completely separate from the terminal.

Jun 15 2020, 3:29 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mehdi_amini added inline comments to D80978: Add a git hook script that can be manually setup to run some checks on every push.
Jun 15 2020, 3:29 PM · Restricted Project
mehdi_amini added a comment to D80978: Add a git hook script that can be manually setup to run some checks on every push.

(mark some comments as done)

Jun 15 2020, 3:29 PM · Restricted Project
mehdi_amini updated the diff for D80978: Add a git hook script that can be manually setup to run some checks on every push.

Address some comments on the python script

Jun 15 2020, 3:29 PM · Restricted Project
mehdi_amini committed rG13331477c0d1: Make OpOperand constructor private (NFC) (authored by mehdi_amini).
Make OpOperand constructor private (NFC)
Jun 15 2020, 1:48 PM
mehdi_amini closed D81815: Make OpOperand constructor private (NFC).
Jun 15 2020, 1:47 PM · Restricted Project
mehdi_amini requested changes to D81870: [mlir] [integration_test] Add XFAIL for "flang-aarch64-ubuntu" reduction failures.

This seems like something which should be in a lit.local.cfg instead of individual tests.

Jun 15 2020, 1:46 PM · Restricted Project
mehdi_amini added a comment to D81447: [llvm][NFC] Move content of ML subdirectory into Analysis.

Broke our Linux build as well FYI: https://buildkite.com/mlir/mlir-core/builds/5673#854a799f-b1c2-46b4-bbca-0b1d0a5b487f

Jun 15 2020, 12:37 PM · Restricted Project
mehdi_amini added a comment to D81618: [mlir] Add support for lowering tanh to LLVMIR..

Reverted in a9a21bb4b682474248dc85f9e7db4b260d249ab9 ; the standalone test was broken

Jun 15 2020, 12:36 PM · Restricted Project
mehdi_amini committed rGa9a21bb4b682: Revert "[mlir] Add support for lowering tanh to LLVMIR." (authored by mehdi_amini).
Revert "[mlir] Add support for lowering tanh to LLVMIR."
Jun 15 2020, 12:08 PM
mehdi_amini added a reverting change for rG32c757e4f808: [mlir] Add support for lowering tanh to LLVMIR.: rGa9a21bb4b682: Revert "[mlir] Add support for lowering tanh to LLVMIR.".
Jun 15 2020, 12:08 PM
mehdi_amini committed rG72d20b9604f6: [LLVM] Change isa<> to a variadic function template (authored by jurahul).
[LLVM] Change isa<> to a variadic function template
Jun 15 2020, 12:07 PM
mehdi_amini closed D81045: [LLVM] Change isa<> to a variadic function template.
Jun 15 2020, 12:07 PM · Restricted Project, Restricted Project, Restricted Project

Jun 14 2020

mehdi_amini created D81815: Make OpOperand constructor private (NFC).
Jun 14 2020, 6:07 PM · Restricted Project
mehdi_amini added inline comments to D79296: [mlir][DenseElementsAttr] Add support for opaque APFloat/APInt complex values..
Jun 14 2020, 6:07 PM · Restricted Project, Restricted Project

Jun 12 2020

mehdi_amini committed rG339e49e2ca4b: Fix GCC5 build by renaming variable used in 'auto' deduction (NFC) (authored by mehdi_amini).
Fix GCC5 build by renaming variable used in 'auto' deduction (NFC)
Jun 12 2020, 8:28 PM
mehdi_amini added a comment to D81753: [mlir] Affine symbols: do not expect AffineScope to always exist.

There was an assumption that valid IR would always live inside a ModuleOp, which has the AffineScope trait. This isn't true any more? Are you referring to unlinked blocks as valid IR?

Jun 12 2020, 4:34 PM · Restricted Project
mehdi_amini added a comment to D81426: [mlir][spirv] modify structure type member decoration and layout information handling.

I am not sure I am following up, can someone explain to me why we needed to revert this change and then add "bits/stdint-uintn.h" in the first place? The link (http://lab.llvm.org:8011/builders/mlir-windows/builds/3068) to the initial change that caused the original issue wasn't related to this particular patch. Or maybe I misunderstood the messages.

Jun 12 2020, 4:34 PM · Restricted Project
mehdi_amini added inline comments to D81287: [flang] Add ComplexExpr code for lowering.
Jun 12 2020, 2:49 PM · Restricted Project, Restricted Project
mehdi_amini added a comment to D81422: Change filecheck default to dump input on failure.

I'm thinking about a possible improvement here: we could have FileCheck dump the input for the current CHECK-LABEL section only: it seems like it could reduce the output drastically while still preserving how useful the information is?

One FileCheck invocation can report multiple errors, one per CHECK-LABEL section, and I prefer to see all errors every time.

Jun 12 2020, 1:42 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mehdi_amini added a comment to D81422: Change filecheck default to dump input on failure.

I'm thinking about a possible improvement here: we could have FileCheck dump the input for the current CHECK-LABEL section only: it seems like it could reduce the output drastically while still preserving how useful the information is?

Jun 12 2020, 12:02 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mehdi_amini added a comment to D81737: docker images for mlir-nvidia.

I don't know where is the best place for the Docker config to live, but there are some in the monorepo already FYI:

Jun 12 2020, 9:12 AM · Restricted Project

Jun 11 2020

mehdi_amini committed rG6f0ce46873b6: Revert "[mlir][spirv] Enhance structure type member decoration handling" (authored by mehdi_amini).
Revert "[mlir][spirv] Enhance structure type member decoration handling"
Jun 11 2020, 10:30 PM
mehdi_amini added a reverting change for rG5d74df5b03e4: [mlir][spirv] Enhance structure type member decoration handling: rG6f0ce46873b6: Revert "[mlir][spirv] Enhance structure type member decoration handling".
Jun 11 2020, 10:30 PM
mehdi_amini added a comment to D81426: [mlir][spirv] modify structure type member decoration and layout information handling.

The Windows failure and GCC failure look the same.

Unfortunately it looks like this is causing a new failure since <bits/stdint-uintn.h> isn't available on Windows. I'm not sure I understand what types it provides that wouldn't otherwise be available, but is there any alternative source? Thanks again for looking into this!
http://lab.llvm.org:8011/builders/mlir-windows/builds/3125

Jun 11 2020, 10:29 PM · Restricted Project
mehdi_amini added inline comments to D80358: [MLIR] Add RegionKindInterface.
Jun 11 2020, 9:57 PM · Restricted Project, Restricted Project
mehdi_amini added inline comments to D80860: Exact integer emptiness checks for FlatAffineConstraints.
Jun 11 2020, 9:24 PM · Restricted Project, Restricted Project
mehdi_amini added inline comments to D80860: Exact integer emptiness checks for FlatAffineConstraints.
Jun 11 2020, 8:52 PM · Restricted Project, Restricted Project
mehdi_amini added a comment to D81652: [mlir][spirv] Introduce OwningSPIRVModuleRef for ownership.

I was somewhat strongly against this in the past because it sets the wrong usage pattern expectations.

Can you clarify what you mean with "pattern expectations" here?

The "usage pattern expectations" I mean are that we shouldn't be using this type of API within passes, patterns, or a majority of the infra that people usually work in. IMO this is more for the top-level layer, i.e., things like parsing an IR blob. In most normal use cases, passing a builder should be preferred over manually constructing and managing the lifetime of the IR.

Jun 11 2020, 8:52 PM · Restricted Project
mehdi_amini added inline comments to D81109: llvm-link: Add support for archive files as inputs..
Jun 11 2020, 8:52 PM · Restricted Project, Restricted Project
mehdi_amini added a comment to D81045: [LLVM] Change isa<> to a variadic function template.

Do you need someone to land this for you?

Jun 11 2020, 8:52 PM · Restricted Project, Restricted Project, Restricted Project
mehdi_amini committed rG95371ce9c2cb: Enable FileCheck -enable-var-scope by default in MLIR test (authored by mehdi_amini).
Enable FileCheck -enable-var-scope by default in MLIR test
Jun 11 2020, 6:11 PM
mehdi_amini closed D81531: Enable FileCheck -enable-var-scope by default in MLIR test.
Jun 11 2020, 6:11 PM · Restricted Project
mehdi_amini added a comment to D81701: Use python3 in generate-test-checks.py..

@whchung can you remove the extra Phabricator tags from commits messages when pushing? (see here: https://mlir.llvm.org/getting_started/Contributing/ )

Jun 11 2020, 6:10 PM · Restricted Project
mehdi_amini added inline comments to D81551: [MLIR][Standard] Make the `dim` operation index an operand..
Jun 11 2020, 6:10 PM · Restricted Project
mehdi_amini updated the diff for D81531: Enable FileCheck -enable-var-scope by default in MLIR test.

Remove dump-input=fail

Jun 11 2020, 5:39 PM · Restricted Project
mehdi_amini added a comment to D81525: [Support] Ensure errs() is constructed after outs() and don't rerun tie when errs() is called.

Unless there is an immediate resolution (and the discussion seems to indicate that it is worth taking our time here), can we revert the patch that introduces a TSAN failure?

@mehdi_amini Pushing this patch will fix the issue.

Jun 11 2020, 2:20 PM · Restricted Project
mehdi_amini added a comment to D78306: [flang] Use LLVM's flags.

@mehdi_amini, after this is merged, I will make a new differential to change the default and people can argue there.
I'd really like to get this merged and this doesn't change the status quo.

Jun 11 2020, 1:47 PM · Restricted Project, Restricted Project
mehdi_amini added a comment to D81652: [mlir][spirv] Introduce OwningSPIRVModuleRef for ownership.

I was somewhat strongly against this in the past because it sets the wrong usage pattern expectations.

Jun 11 2020, 1:47 PM · Restricted Project
mehdi_amini added a comment to D81525: [Support] Ensure errs() is constructed after outs() and don't rerun tie when errs() is called.

Unless there is an immediate resolution (and the discussion seems to indicate that it is worth taking our time here), can we revert the patch that introduces a TSAN failure?

Jun 11 2020, 1:47 PM · Restricted Project
mehdi_amini added a comment to D81223: Size LTO (1/3): Standardizing the use of OptimizationLevel .

The way I see it, with size level for LTO, we could have a different LTO optimization pipeline for size or runtime performance.

Jun 11 2020, 9:23 AM · Restricted Project, Restricted Project, lld, Restricted Project

Jun 10 2020

mehdi_amini added inline comments to D81626: [mlir] [integration-test] [VectorOps] Start an integration test directory for MLIR.
Jun 10 2020, 8:30 PM · Restricted Project
mehdi_amini added a comment to D81426: [mlir][spirv] modify structure type member decoration and layout information handling.

I believe this change may have broken the Windows buildbot, here: http://lab.llvm.org:8011/builders/mlir-windows/builds/3068

Jun 10 2020, 7:25 PM · Restricted Project
mehdi_amini added a reviewer for D81626: [mlir] [integration-test] [VectorOps] Start an integration test directory for MLIR: stephenneuendorffer.
Jun 10 2020, 7:25 PM · Restricted Project
mehdi_amini added a comment to D81626: [mlir] [integration-test] [VectorOps] Start an integration test directory for MLIR.

LGTM overall (adding @stephenneuendorffer who spent time staring at CMake recently)

Jun 10 2020, 7:25 PM · Restricted Project
mehdi_amini added a comment to D81626: [mlir] [integration-test] [VectorOps] Start an integration test directory for MLIR.

Testing Time: 0.24s

Jun 10 2020, 7:25 PM · Restricted Project
mehdi_amini committed rG1cf14860db88: Revert "[mlir][spirv] Enhance structure type member decoration handling" (authored by mehdi_amini).
Revert "[mlir][spirv] Enhance structure type member decoration handling"
Jun 10 2020, 6:21 PM
mehdi_amini added a reverting change for rG4b7aa6c8c1b0: [mlir][spirv] Enhance structure type member decoration handling: rG1cf14860db88: Revert "[mlir][spirv] Enhance structure type member decoration handling".
Jun 10 2020, 6:20 PM
mehdi_amini added inline comments to D81426: [mlir][spirv] modify structure type member decoration and layout information handling.
Jun 10 2020, 5:47 PM · Restricted Project
mehdi_amini committed rG51a822724dae: Register printer and context CL options with the toyc example (authored by mehdi_amini).
Register printer and context CL options with the toyc example
Jun 10 2020, 1:23 PM
mehdi_amini closed D81604: Register printer and context CL options with the toyc example.
Jun 10 2020, 1:23 PM · Restricted Project
mehdi_amini added inline comments to D81604: Register printer and context CL options with the toyc example.
Jun 10 2020, 1:21 PM · Restricted Project
mehdi_amini created D81604: Register printer and context CL options with the toyc example.
Jun 10 2020, 11:41 AM · Restricted Project
mehdi_amini added a comment to D81531: Enable FileCheck -enable-var-scope by default in MLIR test.

We might want to consider doing the same for -dump-input=fail?

Jun 10 2020, 10:00 AM · Restricted Project
mehdi_amini accepted D81579: [MLIR] Add ArrayAttr::empty().
Jun 10 2020, 9:59 AM · Restricted Project
mehdi_amini added inline comments to D81264: [mlir][OpenMP] Add custom parser and pretty printer for parallel construct.
Jun 10 2020, 9:56 AM · Restricted Project
mehdi_amini committed rG83d920c72a96: Fix MLIR test: -dump-input-on-failure is no longer a valid option (authored by mehdi_amini).
Fix MLIR test: -dump-input-on-failure is no longer a valid option
Jun 10 2020, 9:19 AM
mehdi_amini added a comment to D81551: [MLIR][Standard] Make the `dim` operation index an operand..

@frgossen : the pre-merge build is failing on this revision, please check that it is passing or that you understand the failure before pushing.

Jun 10 2020, 9:17 AM · Restricted Project

Jun 9 2020

Herald added a reviewer for D81531: Enable FileCheck -enable-var-scope by default in MLIR test: herhut.
Jun 9 2020, 10:01 PM · Restricted Project
Herald added a project to D77528: [MLIR] Add support to use aligned_alloc to lower AllocOp from std to llvm: Restricted Project.
Jun 9 2020, 9:29 PM · Restricted Project, Restricted Project
mehdi_amini added a comment to D81422: Change filecheck default to dump input on failure.

I think this is a worse default for development for large tests.

Maybe the issue is with large tests that needs to be broken up?

This isn't really manageable, especially with the trend of using update_* test checks scripts. Stuff like legalization tests just have to stress every combination of inputs.

Jun 9 2020, 8:57 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mehdi_amini added a comment to D81422: Change filecheck default to dump input on failure.

I think this is a worse default for development for large tests.

Jun 9 2020, 6:15 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mehdi_amini added inline comments to D80978: Add a git hook script that can be manually setup to run some checks on every push.
Jun 9 2020, 1:14 PM · Restricted Project
mehdi_amini committed rGd31c9e5a46ee: Change filecheck default to dump input on failure (authored by mehdi_amini).
Change filecheck default to dump input on failure
Jun 9 2020, 12:08 PM
mehdi_amini closed D81422: Change filecheck default to dump input on failure.
Jun 9 2020, 12:08 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mehdi_amini added inline comments to D81422: Change filecheck default to dump input on failure.
Jun 9 2020, 10:25 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mehdi_amini updated the diff for D81422: Change filecheck default to dump input on failure.

Address @jdenny's comments:

  • fix the example in lit.local.cfg
  • Test the default value for dump-input
Jun 9 2020, 10:25 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mehdi_amini updated the summary of D81422: Change filecheck default to dump input on failure.
Jun 9 2020, 9:52 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jun 8 2020

mehdi_amini added inline comments to D81276: [mlir][rocdl] Adding vector to ROCDL dialect lowering.
Jun 8 2020, 8:28 PM · Restricted Project
mehdi_amini added inline comments to D81320: [MLIR] Emit debug message if inlining fails.
Jun 8 2020, 8:28 PM · Restricted Project
mehdi_amini added a comment to D81435: [MLIR] Add an Op util which returns its name with the dialect stripped..

Are there use cases in-tree that could be updated?

Jun 8 2020, 7:23 PM · Restricted Project
mehdi_amini accepted D81435: [MLIR] Add an Op util which returns its name with the dialect stripped..
Jun 8 2020, 7:23 PM · Restricted Project
mehdi_amini added inline comments to D81422: Change filecheck default to dump input on failure.
Jun 8 2020, 6:50 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mehdi_amini added a comment to D81431: Added number of operands verification for shape.assuming_all operation..

Nit: slight preference for using the present in your commit title (Added -> Add) in general

Jun 8 2020, 5:45 PM · Restricted Project
mehdi_amini updated the diff for D81422: Change filecheck default to dump input on failure.

Fix more tests

Jun 8 2020, 5:44 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mehdi_amini added a comment to D81422: Change filecheck default to dump input on failure.

I don't remember the exact reasoning but I believe it had something to do with bot logs? @jdenny or @thopre might remember.

Jun 8 2020, 1:52 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mehdi_amini updated the diff for D81422: Change filecheck default to dump input on failure.

Update tests

Jun 8 2020, 1:51 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mehdi_amini created D81422: Change filecheck default to dump input on failure.
Jun 8 2020, 12:44 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
Herald added a reviewer for D80978: Add a git hook script that can be manually setup to run some checks on every push: aaron.ballman.
Jun 8 2020, 12:42 PM · Restricted Project
mehdi_amini added a comment to D68994: [RFC] Redefine `convergent` in terms of dynamic instances.

However, the model described here has some issues, and I hope to introduce a slight variation that addresses those issue.

Jun 8 2020, 10:29 AM · Restricted Project

Jun 7 2020

mehdi_amini added a reverting change for rGe80617df894b: [MLIR] Lower shape.num_elements -> shape.reduce.: rGa25f5cd70cef: Revert "[MLIR] Lower shape.num_elements -> shape.reduce.".
Jun 7 2020, 12:47 PM
mehdi_amini committed rGa25f5cd70cef: Revert "[MLIR] Lower shape.num_elements -> shape.reduce." (authored by mehdi_amini).
Revert "[MLIR] Lower shape.num_elements -> shape.reduce."
Jun 7 2020, 12:47 PM