Page MenuHomePhabricator
Feed Advanced Search

Today

mehdi_amini added inline comments to D82647: [mlir] support returning unranked memrefs.
Sat, Jul 4, 3:02 PM · Restricted Project
mehdi_amini committed rGfbc06b228012: Revert "[MLIR] Parallelize affine.for op to 1-D affine.parallel op" (authored by mehdi_amini).
Revert "[MLIR] Parallelize affine.for op to 1-D affine.parallel op"
Sat, Jul 4, 1:58 PM
mehdi_amini added a reverting change for rG5f2843857fee: [MLIR] Parallelize affine.for op to 1-D affine.parallel op: rGfbc06b228012: Revert "[MLIR] Parallelize affine.for op to 1-D affine.parallel op".
Sat, Jul 4, 1:58 PM
mehdi_amini added a comment to D82672: [MLIR] Parallelize affine.for op to 1-D affine.parallel op.

Reverted in fbc06b228012 ; this broke the build with the -DDBUILD_SHARED_LIBS=ON configuration.

Sat, Jul 4, 1:58 PM · Restricted Project

Yesterday

mehdi_amini added inline comments to D82803: Create the MLIR Reduce framework.
Fri, Jul 3, 9:37 PM · Restricted Project
mehdi_amini added inline comments to D80358: [MLIR] Add RegionKindInterface.
Fri, Jul 3, 9:37 PM · Restricted Project, Restricted Project
mehdi_amini added inline comments to D82803: Create the MLIR Reduce framework.
Fri, Jul 3, 9:06 AM · Restricted Project

Thu, Jul 2

mehdi_amini updated the diff for D82594: Clarify a bit the guideline on omitting braces, including more examples (NFC).

s/the is/that is/

Thu, Jul 2, 10:39 PM · Restricted Project
mehdi_amini added inline comments to D82594: Clarify a bit the guideline on omitting braces, including more examples (NFC).
Thu, Jul 2, 10:39 PM · Restricted Project
mehdi_amini added inline comments to D82803: Create the MLIR Reduce framework.
Thu, Jul 2, 9:35 PM · Restricted Project
mehdi_amini added a comment to D83068: [mlir] Add `ReshapeMemrefCastOp` to Standard..

Can you make sure there is a thread on discourse before adding ops to the standard dialect?

Thu, Jul 2, 9:35 PM · Restricted Project
mehdi_amini added inline comments to D82594: Clarify a bit the guideline on omitting braces, including more examples (NFC).
Thu, Jul 2, 9:42 AM · Restricted Project
mehdi_amini added a comment to D82757: [mlir] Add redundant copy removal transform.

@mehdi_amini Is there any generic copy interface available?

Thu, Jul 2, 9:42 AM · Restricted Project

Wed, Jul 1

mehdi_amini added inline comments to D82803: Create the MLIR Reduce framework.
Wed, Jul 1, 11:25 PM · Restricted Project
mehdi_amini updated the diff for D82594: Clarify a bit the guideline on omitting braces, including more examples (NFC).

slight tweak on the for loop

Wed, Jul 1, 9:39 PM · Restricted Project
mehdi_amini updated the diff for D82594: Clarify a bit the guideline on omitting braces, including more examples (NFC).

Address formatting and other minor comments (no major change)

Wed, Jul 1, 8:35 PM · Restricted Project
mehdi_amini added inline comments to D82594: Clarify a bit the guideline on omitting braces, including more examples (NFC).
Wed, Jul 1, 8:35 PM · Restricted Project
mehdi_amini accepted D83016: [MLIR] Add a NoRegionArguments trait.
Wed, Jul 1, 7:26 PM · Restricted Project
mehdi_amini added inline comments to D82803: Create the MLIR Reduce framework.
Wed, Jul 1, 5:18 PM · Restricted Project
mehdi_amini added a comment to D82803: Create the MLIR Reduce framework.

The implementation mlir/tools/mlir-reduce/Tester.cpp does not seems in the right place: it should be somewhere under lib/

Wed, Jul 1, 5:18 PM · Restricted Project

Tue, Jun 30

mehdi_amini added inline comments to D78434: [mlir] resolve types from attributes in assemblyFormat.
Tue, Jun 30, 3:46 PM · Restricted Project, Restricted Project
mehdi_amini added inline comments to D82647: [mlir] support returning unranked memrefs.
Tue, Jun 30, 2:09 PM · Restricted Project
mehdi_amini added a comment to D82803: Create the MLIR Reduce framework.

I think the proposal is to have a include/mlir/Reducer to mirror TableGen side - at least for me include/mlir/Support is a bit broad. But wait for others comments before moving, I'm not sure if this is what Mehdi ment.

Tue, Jun 30, 10:50 AM · Restricted Project
mehdi_amini added a comment to D82803: Create the MLIR Reduce framework.

If the tools is intended to be extended, I suspect that classes like class Tester should be in a library (and so the header be under the include folder).
The tools folder is only for the generated binary, I'd follow what we do with mlir-opt as a pattern here.

Tue, Jun 30, 9:11 AM · Restricted Project

Mon, Jun 29

mehdi_amini added a reviewer for D80358: [MLIR] Add RegionKindInterface: ftynse.
Mon, Jun 29, 10:32 PM · Restricted Project, Restricted Project
mehdi_amini added a comment to D82757: [mlir] Add redundant copy removal transform.

Can this pass be made to not be Linalg-specific?
Can you clarify the restriction on it and when is it safe or not to use?

Mon, Jun 29, 10:00 PM · Restricted Project
mehdi_amini requested changes to D82751: [mlir][Standard] Add minf/maxf operations..

So far we've consider these as easy to pattern match, anything changed here?

Mon, Jun 29, 10:00 PM · Restricted Project
mehdi_amini added inline comments to D80358: [MLIR] Add RegionKindInterface.
Mon, Jun 29, 9:28 PM · Restricted Project, Restricted Project
mehdi_amini added inline comments to D82647: [mlir] support returning unranked memrefs.
Mon, Jun 29, 8:56 PM · Restricted Project
mehdi_amini added a comment to D82803: Create the MLIR Reduce framework.

If the tools is intended to be extended, I suspect that classes like class Tester should be in a library (and so the header be under the include folder).
The tools folder is only for the generated binary, I'd follow what we do with mlir-opt as a pattern here.

Mon, Jun 29, 4:22 PM · Restricted Project

Sun, Jun 28

mehdi_amini accepted D82595: [mlir] Remove locking for dialect/operation registration..

Nice!

Sun, Jun 28, 12:23 PM · Restricted Project

Fri, Jun 26

mehdi_amini added a comment to D75284: [Sphinx] Adjust for source_parsers deprecation in Sphinx 3.0 .

This patch works on my machine right now!

Fri, Jun 26, 5:05 PM · Restricted Project
mehdi_amini added inline comments to D81236: Improve LegacyPassManager API to correctly report modified status.
Fri, Jun 26, 5:05 PM · Restricted Project
mehdi_amini accepted D82624: [mlir] [VectorOps] Add the ability to mark FP reductions with "reassociate" attribute.

Nice! I agree the attribute is appropriate here.

Fri, Jun 26, 11:29 AM · Restricted Project

Thu, Jun 25

mehdi_amini accepted D81883: [mlir] Add support for defining Traits and Interfaces on Attributes/Types..

What about trait in the test dialect that could test this?

Thu, Jun 25, 9:17 PM · Restricted Project
mehdi_amini added a comment to D75284: [Sphinx] Adjust for source_parsers deprecation in Sphinx 3.0 .

Ping here?

Thu, Jun 25, 8:12 PM · Restricted Project
mehdi_amini committed rG4abf0243367d: Remove references to the 4.0 release as a major breaking (NFC) (authored by mehdi_amini).
Remove references to the 4.0 release as a major breaking (NFC)
Thu, Jun 25, 4:57 PM
mehdi_amini closed D82514: Remove references to the 4.0 release as a major breaking (NFC).
Thu, Jun 25, 4:57 PM · Restricted Project
mehdi_amini added inline comments to D81236: Improve LegacyPassManager API to correctly report modified status.
Thu, Jun 25, 4:23 PM · Restricted Project
mehdi_amini added inline comments to D81236: Improve LegacyPassManager API to correctly report modified status.
Thu, Jun 25, 3:51 PM · Restricted Project
mehdi_amini updated the diff for D82594: Clarify a bit the guideline on omitting braces, including more examples (NFC).

Address minor comments

Thu, Jun 25, 3:18 PM · Restricted Project
mehdi_amini added inline comments to D82594: Clarify a bit the guideline on omitting braces, including more examples (NFC).
Thu, Jun 25, 3:18 PM · Restricted Project
mehdi_amini added inline comments to D82514: Remove references to the 4.0 release as a major breaking (NFC).
Thu, Jun 25, 3:18 PM · Restricted Project
mehdi_amini created D82599: [private] Testing mandatory braces.
Thu, Jun 25, 2:11 PM
mehdi_amini created D82594: Clarify a bit the guideline on omitting braces, including more examples (NFC).
Thu, Jun 25, 1:39 PM · Restricted Project

Wed, Jun 24

mehdi_amini accepted D82480: [FileCheck][NFC] Remove redundant DumpInputDefault.
Wed, Jun 24, 8:37 PM · Restricted Project
mehdi_amini added a comment to D82514: Remove references to the 4.0 release as a major breaking (NFC).

Do we want to actually do the breaking release?

Wed, Jun 24, 8:05 PM · Restricted Project
mehdi_amini committed rG5ac47c3f5231: Move explicit template class specialization out of the class to fix gcc builds… (authored by mehdi_amini).
Move explicit template class specialization out of the class to fix gcc builds…
Wed, Jun 24, 7:02 PM
mehdi_amini added a comment to D73422: [IR] Delete MODULE_CODE_DEPLIB.

Sent https://reviews.llvm.org/D82514 to cleanup

Wed, Jun 24, 5:56 PM · Restricted Project
mehdi_amini created D82514: Remove references to the 4.0 release as a major breaking (NFC).
Wed, Jun 24, 5:56 PM · Restricted Project
mehdi_amini committed rGa61c73dbe320: Add a git hook script that can be manually setup to run some checks on every… (authored by mehdi_amini).
Add a git hook script that can be manually setup to run some checks on every…
Wed, Jun 24, 2:41 PM
mehdi_amini closed D80978: Add a git hook script that can be manually setup to run some checks on every push.
Wed, Jun 24, 2:41 PM · Restricted Project
mehdi_amini added a comment to D80978: Add a git hook script that can be manually setup to run some checks on every push.

Thanks for the reviews @MaskRay !

Wed, Jun 24, 2:40 PM · Restricted Project

Tue, Jun 23

mehdi_amini added inline comments to D80285: [mlir] make the bitwidth of device side index computations configurable.
Tue, Jun 23, 4:43 PM · Restricted Project, Restricted Project
mehdi_amini added inline comments to D80285: [mlir] make the bitwidth of device side index computations configurable.
Tue, Jun 23, 1:26 PM · Restricted Project, Restricted Project
mehdi_amini added a comment to D81695: [flang] Turn off FLANG_ENABLE_WERROR by default.

@isuruf Are there some warning that cannot be removed with reasonable effort?

Tue, Jun 23, 12:54 PM · Restricted Project, Restricted Project
mehdi_amini added inline comments to D82191: [mlir] parallel loop canonicalization.
Tue, Jun 23, 12:54 PM · Restricted Project
mehdi_amini added a comment to rG2ff6fad70049: Revert "[mlir] make the bitwidth of device side index computations configurable".

Thanks for the revert!
For future cases, please indicate the revert reason in the commit message.

Tue, Jun 23, 12:21 PM
mehdi_amini committed rG8b64adb0a285: Fix incorrect "REQUIRE" (default_target->default_triple) introduced in… (authored by mehdi_amini).
Fix incorrect "REQUIRE" (default_target->default_triple) introduced in…
Tue, Jun 23, 11:48 AM
mehdi_amini added inline comments to D80285: [mlir] make the bitwidth of device side index computations configurable.
Tue, Jun 23, 9:37 AM · Restricted Project, Restricted Project

Mon, Jun 22

mehdi_amini added a comment to D82276: Make ninja smart console builds more pretty.

Couldn't we "cache" the result of the check in the function get_source_info?

Mon, Jun 22, 10:32 PM · Restricted Project
mehdi_amini added a comment to D80285: [mlir] make the bitwidth of device side index computations configurable.

nn

Mon, Jun 22, 9:29 PM · Restricted Project, Restricted Project
mehdi_amini added inline comments to D82191: [mlir] parallel loop canonicalization.
Mon, Jun 22, 9:29 PM · Restricted Project
mehdi_amini accepted D82232: Add hasNItemsOrLess and container variants of hasNItems and friends.

Thanks for adding the tests! Did you find the bug while adding these by the way?

Mon, Jun 22, 3:03 PM · Restricted Project, Restricted Project

Sun, Jun 21

mehdi_amini accepted D82276: Make ninja smart console builds more pretty.

OK I see now, the description wasn't clear to me earlier. So it is about the fact that find_package failure is multiple-lines long, and it is called separately from LLVM, clang, lld, and lldb. Instead we will still display 4 times the warning but it'll be one line instead, right?

Sun, Jun 21, 9:09 PM · Restricted Project
mehdi_amini added a comment to D82276: Make ninja smart console builds more pretty.

OK!
So I renamed the find_package(Git) into find_package(Git2) to force an error:

Sun, Jun 21, 2:49 PM · Restricted Project
mehdi_amini added a comment to D82276: Make ninja smart console builds more pretty.

Just curious: what is the practical effect of the change? (I don't know what is "ninja smart console")

Sun, Jun 21, 12:11 PM · Restricted Project
mehdi_amini added inline comments to D81236: Improve LegacyPassManager API to correctly report modified status.
Sun, Jun 21, 12:11 PM · Restricted Project

Sat, Jun 20

mehdi_amini added a comment to D82203: [FileCheck] Implement -dump-input-context.

Are you still playing with this or are you looking for reviews? Or do you need more general feedback? (just making sure you're not blocked waiting on anything)

Sat, Jun 20, 4:25 PM · Restricted Project
mehdi_amini added a comment to D80978: Add a git hook script that can be manually setup to run some checks on every push.

Without git pull --rebase origin master, my local master branch was stale. This script said:

% git push origin HEAD:master                                                                                                                   
`git rev-list 4171f80d5416eccbeebe8864410d576d7dc61eaa..bb67f1a4400a19318713375655999f733418a33b` returned 128    
fatal: Invalid revision range 4171f80d5416eccbeebe8864410d576d7dc61eaa..bb67f1a4400a19318713375655999f733418a33b
Sat, Jun 20, 12:29 AM · Restricted Project
mehdi_amini updated the diff for D80978: Add a git hook script that can be manually setup to run some checks on every push.

Detect when the remote revision isn't available locally

Sat, Jun 20, 12:29 AM · Restricted Project

Fri, Jun 19

mehdi_amini committed rG20d0ab6157c1: Fix warning caused by TableGen verifier predicate (NFC) (authored by mehdi_amini).
Fix warning caused by TableGen verifier predicate (NFC)
Fri, Jun 19, 11:57 PM
mehdi_amini added inline comments to D82232: Add hasNItemsOrLess and container variants of hasNItems and friends.
Fri, Jun 19, 8:35 PM · Restricted Project, Restricted Project
mehdi_amini accepted D81882: [mlir] Refactor OpInterface internals to be faster and factor out common bits..
Fri, Jun 19, 8:35 PM · Restricted Project
mehdi_amini added inline comments to D78867: [docs] avoid 'arc land' command.
Fri, Jun 19, 5:24 PM · Restricted Project
mehdi_amini added inline comments to D82232: Add hasNItemsOrLess and container variants of hasNItems and friends.
Fri, Jun 19, 5:24 PM · Restricted Project, Restricted Project
mehdi_amini accepted D82236: blacklist -> exclusions: heap.py.
Fri, Jun 19, 3:14 PM · Restricted Project
mehdi_amini added inline comments to D78867: [docs] avoid 'arc land' command.
Fri, Jun 19, 3:14 PM · Restricted Project
mehdi_amini added a comment to D82235: Blacklisted -> Excluded : GVNSink.

I think such minor renaming should be perfectly fine to commit as-is (post-commit reviewed).

Fri, Jun 19, 2:41 PM · Restricted Project
mehdi_amini accepted D82235: Blacklisted -> Excluded : GVNSink.

Thanks!

Fri, Jun 19, 2:41 PM · Restricted Project
mehdi_amini added a comment to D82203: [FileCheck] Implement -dump-input-context.

fantastic :)

Fri, Jun 19, 1:05 PM · Restricted Project
mehdi_amini added inline comments to D81236: Improve LegacyPassManager API to correctly report modified status.
Fri, Jun 19, 2:07 AM · Restricted Project
mehdi_amini added inline comments to D80358: [MLIR] Add RegionKindInterface.
Fri, Jun 19, 1:34 AM · Restricted Project, Restricted Project
mehdi_amini added inline comments to D81882: [mlir] Refactor OpInterface internals to be faster and factor out common bits..
Fri, Jun 19, 1:02 AM · Restricted Project
mehdi_amini added a comment to D82117: [mlir] [integration-test] [LLVMIR] Add reduction intrinsic tests.

Add a function to your bashrc to do it for you?

Fri, Jun 19, 12:29 AM · Restricted Project

Thu, Jun 18

mehdi_amini committed rGbc14c77a1e88: Fix `check-mlir` target when the host target isn't configured (authored by mehdi_amini).
Fix `check-mlir` target when the host target isn't configured
Thu, Jun 18, 11:58 PM
mehdi_amini committed rG59f45a1cdb36: Mark some LLVM tests which require a default_triple (NFC) (authored by mehdi_amini).
Mark some LLVM tests which require a default_triple (NFC)
Thu, Jun 18, 11:57 PM
mehdi_amini closed D82142: A the `default_triple` feature to MLIR test suite.
Thu, Jun 18, 11:57 PM · Restricted Project
mehdi_amini added inline comments to D81236: Improve LegacyPassManager API to correctly report modified status.
Thu, Jun 18, 11:23 PM · Restricted Project
mehdi_amini updated the diff for D80978: Add a git hook script that can be manually setup to run some checks on every push.

Mostly cosmetic

Thu, Jun 18, 11:23 PM · Restricted Project
mehdi_amini added inline comments to D80978: Add a git hook script that can be manually setup to run some checks on every push.
Thu, Jun 18, 10:20 PM · Restricted Project
mehdi_amini added a comment to D80978: Add a git hook script that can be manually setup to run some checks on every push.

@MaskRay anything more than cosmetic left?

Thu, Jun 18, 10:20 PM · Restricted Project
mehdi_amini added a comment to D78867: [docs] avoid 'arc land' command.

I'll pick this one up then!

Thu, Jun 18, 9:48 PM · Restricted Project
mehdi_amini added a comment to D65761: Add Windows Control Flow Guard checks (/guard:cf)..

It seems like this pass was added in lib/Transforms but does not have any unit-tests (lit tests) provided. It isn't even linked into opt. As it is an LLVM IR pass it should be tested as such I believe. Can you provide tests for this?

Thu, Jun 18, 9:47 PM · Restricted Project, Restricted Project
mehdi_amini accepted D82138: Diagnostic message (error) related to ThinLTO caching needs to be downgraded to a remark.
Thu, Jun 18, 9:16 PM · Restricted Project
mehdi_amini created D82142: A the `default_triple` feature to MLIR test suite.
Thu, Jun 18, 8:43 PM · Restricted Project
mehdi_amini added a comment to D82117: [mlir] [integration-test] [LLVMIR] Add reduction intrinsic tests.

If you want to write some Php, we can patch Phabricator though!

Thu, Jun 18, 8:11 PM · Restricted Project
mehdi_amini added a comment to D82117: [mlir] [integration-test] [LLVMIR] Add reduction intrinsic tests.

We call out "do not use arc land" in our doc for this reason: https://mlir.llvm.org/getting_started/Contributing/#using-arcanist

Thu, Jun 18, 8:11 PM · Restricted Project
mehdi_amini added a comment to D80978: Add a git hook script that can be manually setup to run some checks on every push.

@MaskRay any major left or can we go one with this?

Thu, Jun 18, 6:35 PM · Restricted Project

Wed, Jun 17

mehdi_amini committed rG77b79d79c05f: Remove "unused" member ModuleSlice from `struct OpenMPOpt` (authored by mehdi_amini).
Remove "unused" member ModuleSlice from `struct OpenMPOpt`
Wed, Jun 17, 8:31 PM