Page MenuHomePhabricator
Feed Advanced Search

Mon, Jul 12

sjarus accepted D105665: [mlir][tosa] Added shape propagation for TOSA pool operations..
Mon, Jul 12, 12:04 PM · Restricted Project

Thu, Jul 8

sjarus accepted D105383: [mlir][tosa] Added more shape inference for tosa ops.

Looks good to me! Sorry for the delay, as I was on vacation yesterday.

Thu, Jul 8, 5:40 PM · Restricted Project

Wed, Jun 30

sjarus added a comment to D105213: [mlir][tosa] Use 3D tensors in tosa.matmul.

Undoes the temporary change in https://reviews.llvm.org/rG05cadc6f71555319882ccabf631d2e6410e3fea4 and moves to 3D tensors now that consuming legalizations have been updated.

Wed, Jun 30, 11:01 AM · Restricted Project
sjarus requested review of D105213: [mlir][tosa] Use 3D tensors in tosa.matmul.
Wed, Jun 30, 10:59 AM · Restricted Project

Fri, Jun 25

sjarus accepted D104949: [mlir][tosa] Update Tosa conv verifier to handle IntegerType input.
Fri, Jun 25, 4:18 PM · Restricted Project

Jun 21 2021

sjarus accepted D104157: [mlir][tosa] Enable tosa.div for TosaMakeBroadcastable.
Jun 21 2021, 1:27 PM · Restricted Project

Jun 9 2021

sjarus accepted D103937: [mlir][tosa] Update tosa.matmul lowering to linalg.batch_matmul.

Thanks for the explanation!

Jun 9 2021, 10:07 AM · Restricted Project

Jun 8 2021

sjarus added inline comments to D103937: [mlir][tosa] Update tosa.matmul lowering to linalg.batch_matmul.
Jun 8 2021, 11:40 PM · Restricted Project
sjarus added a comment to D103854: [mlir][tosa] Temporarily support 2D and 3D tensor types in matmul.

Looks good, I am just checking why the windows build failed (and whether its unrelated).

Jun 8 2021, 3:43 PM · Restricted Project
sjarus updated the diff for D103854: [mlir][tosa] Temporarily support 2D and 3D tensor types in matmul.

Temporarily support 2D and 3D tensor types as valid.
Legalizations and tests across multiple repositories must be updated to emit 3D type.
Change to supporting just Tosa_Tensor3D once everything is updated.

Jun 8 2021, 1:29 PM · Restricted Project
sjarus added a comment to D103854: [mlir][tosa] Temporarily support 2D and 3D tensor types in matmul.

Something appears to be wrong with your patch as its based on a revision not in the LLVM tree. Could you verify your diff history or resubmit based on head?

Jun 8 2021, 12:55 PM · Restricted Project

Jun 7 2021

sjarus requested review of D103854: [mlir][tosa] Temporarily support 2D and 3D tensor types in matmul.
Jun 7 2021, 4:41 PM · Restricted Project

May 24 2021

sjarus accepted D103035: Enable MLIR Python bindings for TOSA..

I have this same thing locally and was planning to push this out, so I'm not going to stop you here :-)

May 24 2021, 10:36 AM · Restricted Project

May 23 2021

sjarus added a comment to D102958: [mlir][tosa] Align tensor rank specifications with current spec.

Ah, you were using the web interface. The docs have extra flags that must be included for full context: https://llvm.org/docs/Phabricator.html#id5

I always use arc diff.

May 23 2021, 9:32 PM · Restricted Project
sjarus added a comment to D102958: [mlir][tosa] Align tensor rank specifications with current spec.

Ok now it seems to look a lot better ? If this is alright, please land it on my behalf - it doesn't seem I can do so myself.

May 23 2021, 9:26 PM · Restricted Project
sjarus updated the diff for D102958: [mlir][tosa] Align tensor rank specifications with current spec.

Trying using arc diff --update from commandline.

May 23 2021, 9:25 PM · Restricted Project
sjarus added a comment to D102958: [mlir][tosa] Align tensor rank specifications with current spec.

Can you upload patches with full context please? Right now I can't see which ops are modified here.

I had a similar question but was able to infer based on eliminating the entire classes of restrictions that had been lifted from the spec.

I don't know phab well enough to know why it can't show context (or how to recommend uploading differently) -- Mehdi, do you know?

May 23 2021, 9:06 PM · Restricted Project

May 21 2021

sjarus requested review of D102958: [mlir][tosa] Align tensor rank specifications with current spec.
May 21 2021, 4:55 PM · Restricted Project

May 19 2021

sjarus accepted D102802: [mlir] Harmonize TOSA include guards.

Thank you once again for these changes!

May 19 2021, 1:40 PM · Restricted Project
sjarus accepted D102800: [mlir] Add include guard to TOSA tblgen passes.

Thank you for adding this!

May 19 2021, 12:57 PM · Restricted Project

May 12 2021

sjarus accepted D102375: [mlir][tosa] Fix tosa.cast semantics to perform rounding/clipping.
May 12 2021, 7:15 PM · Restricted Project
sjarus added inline comments to D102375: [mlir][tosa] Fix tosa.cast semantics to perform rounding/clipping.
May 12 2021, 5:38 PM · Restricted Project
sjarus requested review of D102329: [mlir][tosa] Remove tosa.identityn operator.
May 12 2021, 8:04 AM · Restricted Project

May 6 2021

sjarus added a comment to D101958: [mlir][tosa] Added div op, variadic concat. Removed placeholder. Spec v0.22 alignment..

The implementation looks good however the description needs work. Be more specific than a TOSA version and preface with [mlir][tosa]. It helps contributors to note if this is a CL they should be interested with. Description should be along the lines of "Added tosa.div op and remove tosa.placeholder". For the LLVM repo the summary should focus on what is specifically changing.

May 6 2021, 8:52 AM · Restricted Project
sjarus retitled D101958: [mlir][tosa] Added div op, variadic concat. Removed placeholder. Spec v0.22 alignment. from TOSA v0.22 updates part 2 to [mlir][tosa] Added div op, variadic concat. Removed placeholder. Spec v0.22 alignment..
May 6 2021, 8:51 AM · Restricted Project

May 5 2021

sjarus requested review of D101958: [mlir][tosa] Added div op, variadic concat. Removed placeholder. Spec v0.22 alignment..
May 5 2021, 4:20 PM · Restricted Project

Apr 22 2021

sjarus added a comment to D101009: [mlir][tosa] Add tosa.resize lowering to linalg generic.

This seems to look fine functionally, modulo the inline aesthetic comments.

Apr 22 2021, 3:55 PM · Restricted Project

Mar 31 2021

sjarus accepted D99676: [mlir][tosa] Add tosa.reciprocal and tosa.sigmoid lowerings.
Mar 31 2021, 2:17 PM · Restricted Project

Mar 30 2021

sjarus added a comment to D99628: Move non-spec TOSA operators into TosaUtilOps.td.

Do you need these changes landed for you?

Mar 30 2021, 9:15 PM · Restricted Project
sjarus requested review of D99628: Move non-spec TOSA operators into TosaUtilOps.td.
Mar 30 2021, 4:50 PM · Restricted Project

Mar 25 2021

sjarus added a comment to D99390: TOSA MLIR dialect update to v0.22, part 1.

Thanks for the review! I'm not sure how to land this myself, or if I can at all.

Mar 25 2021, 9:35 PM · Restricted Project
sjarus updated the summary of D99390: TOSA MLIR dialect update to v0.22, part 1.
Mar 25 2021, 4:19 PM · Restricted Project
sjarus requested review of D99390: TOSA MLIR dialect update to v0.22, part 1.
Mar 25 2021, 4:18 PM · Restricted Project

Jan 11 2021

sjarus added inline comments to D94247: [MLIR][TOSA] First lowerings from Tosa to Linalg.
Jan 11 2021, 10:43 AM · Restricted Project

Dec 14 2020

sjarus added a comment to D92581: Add RegionBranchOpInterface to TOSA control flow ops.

At this point the best option appear to be to defer this change. Let's revisit this when the SCF dialect has corresponding tests for this interface. Right now, we aren't able to effectively exercise it, and lack access to precedent material on this interface that we can effectively utilize to construct tests, and don't have familiarity with this domain of MLIR. Thank you for your feedback!

Dec 14 2020, 1:22 PM · Restricted Project
sjarus added inline comments to D92581: Add RegionBranchOpInterface to TOSA control flow ops.
Dec 14 2020, 9:38 AM · Restricted Project
sjarus added a comment to D92581: Add RegionBranchOpInterface to TOSA control flow ops.

Bringing this up again. May I proceed with this ?

Dec 14 2020, 8:04 AM · Restricted Project

Dec 9 2020

sjarus updated the diff for D92581: Add RegionBranchOpInterface to TOSA control flow ops.
Dec 9 2020, 4:54 PM · Restricted Project
sjarus added a comment to D92581: Add RegionBranchOpInterface to TOSA control flow ops.

I've attempted to reconstruct the tests with insights from the sccp tests. While doing so, I restricted this interface to cond_if() alone to simplify this effort. I've also changed the conditional of the op to just a boolean I1 rather than an unnecessary I1Tensor, allowing the check in getSuccessorRegions() to work without modification.

Dec 9 2020, 4:53 PM · Restricted Project

Dec 7 2020

sjarus added inline comments to D92581: Add RegionBranchOpInterface to TOSA control flow ops.
Dec 7 2020, 4:30 PM · Restricted Project
sjarus added inline comments to D92581: Add RegionBranchOpInterface to TOSA control flow ops.
Dec 7 2020, 12:18 PM · Restricted Project

Dec 3 2020

sjarus updated the diff for D92581: Add RegionBranchOpInterface to TOSA control flow ops.

Updated tests.

Dec 3 2020, 6:20 PM · Restricted Project
sjarus added inline comments to D92581: Add RegionBranchOpInterface to TOSA control flow ops.
Dec 3 2020, 6:19 PM · Restricted Project
sjarus updated the diff for D92581: Add RegionBranchOpInterface to TOSA control flow ops.

Incorporated feedback.

Dec 3 2020, 2:36 PM · Restricted Project
sjarus added a comment to D92581: Add RegionBranchOpInterface to TOSA control flow ops.

Incorporated rriddle's feedback and added tests .

Dec 3 2020, 2:35 PM · Restricted Project
sjarus requested review of D92581: Add RegionBranchOpInterface to TOSA control flow ops.
Dec 3 2020, 9:17 AM · Restricted Project

Nov 24 2020

sjarus accepted D92040: [mlir] Add Tosa dialect const folder for tosa.const..
Nov 24 2020, 9:08 AM · Restricted Project

Nov 7 2020

sjarus accepted D91006: NFC: (re-apply) Fix some post-review nits for the Tosa dialect..

Thank you for these cleanup additions!

Nov 7 2020, 9:42 AM · Restricted Project
sjarus added a comment to D90411: TOSA MLIR Dialect.

To suit the flavor of the season, we need a recount here - there was more than 204 since some appear to have disappeared along with deleted files :-)

Nov 7 2020, 9:10 AM · Restricted Project
sjarus updated the diff for D90411: TOSA MLIR Dialect.

Removed TosaTraits and TosaTypes headers. Will add when implemented.

Nov 7 2020, 7:40 AM · Restricted Project

Nov 6 2020

sjarus updated the diff for D90411: TOSA MLIR Dialect.

Removed extra path in test/Dialect/Tosa .

Nov 6 2020, 11:39 PM · Restricted Project
sjarus updated the diff for D90411: TOSA MLIR Dialect.

Updates to feedback from rriddle

Nov 6 2020, 11:24 PM · Restricted Project
sjarus added inline comments to D90411: TOSA MLIR Dialect.
Nov 6 2020, 11:22 PM · Restricted Project
sjarus updated the diff for D90411: TOSA MLIR Dialect.

Fixed typo in inlining test. Reran check-mlir to confirm.

Nov 6 2020, 5:12 PM · Restricted Project
sjarus added a comment to D90411: TOSA MLIR Dialect.

I assume you will need me/someone to land this change?

Nov 6 2020, 1:34 PM · Restricted Project
sjarus updated the diff for D90411: TOSA MLIR Dialect.

stellaraccident: Removed extraneous tests as suggested
mehdi_amini: added test decorators.

Nov 6 2020, 1:33 PM · Restricted Project
sjarus added inline comments to D90411: TOSA MLIR Dialect.
Nov 6 2020, 1:32 PM · Restricted Project
sjarus updated the diff for D90411: TOSA MLIR Dialect.

Incorporates feedback from stellaraccident, rriddle, mehdi_amini

  • Cleanup nits and mechanicals
  • Removed extraneous tests
  • Quantization Builders in C++ now
  • Aligned pass invocation with current approach
  • 80-col alignment
Nov 6 2020, 11:06 AM · Restricted Project
sjarus added inline comments to D90411: TOSA MLIR Dialect.
Nov 6 2020, 11:04 AM · Restricted Project

Nov 5 2020

sjarus added a comment to D90411: TOSA MLIR Dialect.

We'll work on these nits and upload a new patch soon. Since we're new to this, if the next patch looks ok, then please do land it on our behalf as an act of approval.

Nov 5 2020, 12:03 PM · Restricted Project
sjarus updated the diff for D90411: TOSA MLIR Dialect.

Updates contain:

  • Aesthetic cleanups, usage of better MLIR constructs
  • Unit tests
  • WIP rationale document
Nov 5 2020, 7:52 AM · Restricted Project
sjarus added inline comments to D90411: TOSA MLIR Dialect.
Nov 5 2020, 7:50 AM · Restricted Project

Oct 30 2020

sjarus updated the diff for D90411: TOSA MLIR Dialect.

Missed one file update in prior commit

Oct 30 2020, 4:26 PM · Restricted Project
sjarus updated the diff for D90411: TOSA MLIR Dialect.

Updated to incorporate comments from mehdi_amini and stellaraccident.

Oct 30 2020, 4:02 PM · Restricted Project
sjarus added inline comments to D90411: TOSA MLIR Dialect.
Oct 30 2020, 4:01 PM · Restricted Project

Oct 29 2020

sjarus added a comment to D90411: TOSA MLIR Dialect.

Sure, but can you point out exactly where is it tested in this patch? My basic mental model is: if I change the behavior of any line of code, will it fails when running ninja check-mlir?
Again: the benefit of splitting this is that we can land patches more incrementally, and individual important pieces, like moveOutOfLoop and the LoopLikeOpInterface can be tested in isolation with the patch that land them.

These are both good questions. It seems they could both be resolved if we add tests to exercise these in mlir/test/Dialect/Tosa . If so, could we please do that as a follow on effort ?

I'm happy to review the code right now, but I'd also like the tests to get in with the code and not as a follow-up. In general we don't land patches without tests as far as I know.

Oct 29 2020, 6:23 PM · Restricted Project
sjarus added a comment to D90411: TOSA MLIR Dialect.

In the context of this patch, I just randomly sampled some functions involved here and couldn't find an obvious caller? For example buildQTypeAttrFromMinMax or all the computeMultiplierAndShift*

Oct 29 2020, 5:34 PM · Restricted Project
sjarus updated the diff for D90411: TOSA MLIR Dialect.

Updates to incorporate feedback from bondhugula and mehdi_amini .

  • Comment formatting
  • camelCase vars
  • Removed extraneous computeMultiplierAndShift* functions
Oct 29 2020, 5:26 PM · Restricted Project
sjarus added a comment to D90411: TOSA MLIR Dialect.

Thanks, really nice!
Can you split out some pieces so we can focus on the dialect itself mostly?
I'm thinking about the QuantUtils parts (which aren't used/tested in this patch anyway) and a few things like the TosaMakeBroadcastable pass, or the TosaOpInterface or the moveOutOfLoop() method and similarly things which aren't clearly needed right now.

Oct 29 2020, 2:37 PM · Restricted Project
sjarus updated the summary of D90411: TOSA MLIR Dialect.
Oct 29 2020, 11:28 AM · Restricted Project
sjarus requested review of D90411: TOSA MLIR Dialect.
Oct 29 2020, 11:27 AM · Restricted Project