Page MenuHomePhabricator
Feed Advanced Search

Mon, Feb 22

jurahul added a comment to D97217: [mlir] Extend Operation visitor with pre-order traversal.

Please also see: https://github.com/tensorflow/tensorflow/blob/master/tensorflow/compiler/mlir/tensorflow/utils/visitor_util.h

Mon, Feb 22, 2:03 PM · Restricted Project

Jan 12 2021

jurahul committed rG67a339e96839: [MLIR] Disallow `sym_visibility`, `sym_name` and `type` attributes in the… (authored by jurahul).
[MLIR] Disallow `sym_visibility`, `sym_name` and `type` attributes in the…
Jan 12 2021, 9:12 AM
jurahul closed D94200: [MLIR] Disallow `sym_visibility`, `sym_name` and `type` attributes in the parsed attribute dictionary..
Jan 12 2021, 9:12 AM · Restricted Project

Jan 6 2021

jurahul updated the diff for D94200: [MLIR] Disallow `sym_visibility`, `sym_name` and `type` attributes in the parsed attribute dictionary..

Make error message concise.

Jan 6 2021, 4:33 PM · Restricted Project
jurahul updated the diff for D94200: [MLIR] Disallow `sym_visibility`, `sym_name` and `type` attributes in the parsed attribute dictionary..

Better error messages

Jan 6 2021, 4:26 PM · Restricted Project
jurahul added inline comments to D94200: [MLIR] Disallow `sym_visibility`, `sym_name` and `type` attributes in the parsed attribute dictionary..
Jan 6 2021, 3:56 PM · Restricted Project
jurahul added inline comments to D94200: [MLIR] Disallow `sym_visibility`, `sym_name` and `type` attributes in the parsed attribute dictionary..
Jan 6 2021, 3:54 PM · Restricted Project
jurahul updated the diff for D94200: [MLIR] Disallow `sym_visibility`, `sym_name` and `type` attributes in the parsed attribute dictionary..

Simplify by moving check in parseFunctionLikeOp

Jan 6 2021, 3:43 PM · Restricted Project
jurahul added a comment to D94200: [MLIR] Disallow `sym_visibility`, `sym_name` and `type` attributes in the parsed attribute dictionary..

This is in preparation of the visibility related changes discussed in https://llvm.discourse.group/t/external-function-declaration-has-changed-help-needed/2357. This change disallows attributes that sym_visibility/sym_name/type etc which are parsed/inferred from other places to be present in the attribute dictionary. This way, for the follow on changes, the function parser has just one parsed visibility value (parsed as keyword private/public/nested) to consider instead of trying to also look into the parsed attribute dictionary.

Jan 6 2021, 3:20 PM · Restricted Project
jurahul requested review of D94200: [MLIR] Disallow `sym_visibility`, `sym_name` and `type` attributes in the parsed attribute dictionary..
Jan 6 2021, 3:17 PM · Restricted Project

Dec 29 2020

jurahul added inline comments to D93908: [AsmPrinter] Make OpAsmPrinter::printFunctionalType be resilient to null values..
Dec 29 2020, 11:23 AM · Restricted Project

Dec 28 2020

jurahul committed rG25007b4d7e09: [MLIR][NFC] Change FunctionLike::setAllArgAttrs/setAllResultAttrs to do a one… (authored by jurahul).
[MLIR][NFC] Change FunctionLike::setAllArgAttrs/setAllResultAttrs to do a one…
Dec 28 2020, 2:16 PM
jurahul closed D93870: [MLIR][NFC] Change FunctionLike::setAllArgAttrs/setAllResultAttrs to do a one-shot attribute update..
Dec 28 2020, 2:16 PM · Restricted Project
jurahul retitled D93870: [MLIR][NFC] Change FunctionLike::setAllArgAttrs/setAllResultAttrs to do a one-shot attribute update. from [MLIR] Change FunctionLike::setAllArgAttrs/setAllResultAttrs to do a one-shot attribute update. to [MLIR][NFC] Change FunctionLike::setAllArgAttrs/setAllResultAttrs to do a one-shot attribute update..
Dec 28 2020, 1:35 PM · Restricted Project
jurahul updated the diff for D93870: [MLIR][NFC] Change FunctionLike::setAllArgAttrs/setAllResultAttrs to do a one-shot attribute update..

Use if-else

Dec 28 2020, 1:34 PM · Restricted Project
jurahul added a reviewer for D93870: [MLIR][NFC] Change FunctionLike::setAllArgAttrs/setAllResultAttrs to do a one-shot attribute update.: jpienaar.
Dec 28 2020, 12:21 PM · Restricted Project
jurahul requested review of D93870: [MLIR][NFC] Change FunctionLike::setAllArgAttrs/setAllResultAttrs to do a one-shot attribute update..
Dec 28 2020, 12:06 PM · Restricted Project

Dec 10 2020

jurahul committed rG563879b6f946: [NFC] Use ConvertOpToLLVMPattern instead of ConvertToLLVMPattern. (authored by jurahul).
[NFC] Use ConvertOpToLLVMPattern instead of ConvertToLLVMPattern.
Dec 10 2020, 9:34 AM
jurahul closed D92989: [NFC] Use ConvertOpToLLVMPattern instead of ConvertToLLVMPattern..
Dec 10 2020, 9:34 AM · Restricted Project

Dec 9 2020

jurahul requested review of D92989: [NFC] Use ConvertOpToLLVMPattern instead of ConvertToLLVMPattern..
Dec 9 2020, 6:18 PM · Restricted Project
jurahul committed rGb0d02b698b94: [MLIR] Minor cleanup for Shape dialect. (authored by jurahul).
[MLIR] Minor cleanup for Shape dialect.
Dec 9 2020, 2:22 PM
jurahul closed D92901: [MLIR] Minor cleanup for Shape dialect..
Dec 9 2020, 2:22 PM · Restricted Project
jurahul added inline comments to D92927: [mlir][Shape] Make sure tensor_cast(constant_shape) folding uses the correct type.
Dec 9 2020, 11:22 AM · Restricted Project
jurahul added inline comments to D92901: [MLIR] Minor cleanup for Shape dialect..
Dec 9 2020, 9:24 AM · Restricted Project
jurahul updated the diff for D92901: [MLIR] Minor cleanup for Shape dialect..

Address feedback

Dec 9 2020, 9:23 AM · Restricted Project

Dec 8 2020

jurahul updated the diff for D92901: [MLIR] Minor cleanup for Shape dialect..

Remove test case

Dec 8 2020, 8:33 PM · Restricted Project
jurahul added inline comments to D92901: [MLIR] Minor cleanup for Shape dialect..
Dec 8 2020, 8:31 PM · Restricted Project
jurahul retitled D92901: [MLIR] Minor cleanup for Shape dialect. from [MLIR] Minor cleanup for Shape dialect. - Remove some unused types from the Shape dialect - Fix from_extent_tensor to only allow 1D index tensors - Fix assuming_yield to only allow shape.assuming as the parent op. - Fix some documentation typos... to [MLIR] Minor cleanup for Shape dialect. .
Dec 8 2020, 5:51 PM · Restricted Project
jurahul requested review of D92901: [MLIR] Minor cleanup for Shape dialect..
Dec 8 2020, 5:50 PM · Restricted Project

Dec 4 2020

jurahul committed rGfe7fdcac87be: [MLIR] Fix parseFunctionLikeOp() to fail parsing empty regions (authored by jurahul).
[MLIR] Fix parseFunctionLikeOp() to fail parsing empty regions
Dec 4 2020, 9:10 AM
jurahul closed D91886: [MLIR] Fix parseFunctionLikeOp() to fail parsing empty regions.
Dec 4 2020, 9:10 AM · Restricted Project
jurahul committed rG245233423e46: [MLIR] Generate inferReturnTypes declaration using InferTypeOpInterface trait. (authored by jurahul).
[MLIR] Generate inferReturnTypes declaration using InferTypeOpInterface trait.
Dec 4 2020, 9:09 AM
jurahul closed D92585: [MLIR] Generate inferReturnTypes declaration using InferTypeOpInterface trait..
Dec 4 2020, 9:09 AM · Restricted Project

Dec 3 2020

jurahul added inline comments to D92585: [MLIR] Generate inferReturnTypes declaration using InferTypeOpInterface trait..
Dec 3 2020, 4:19 PM · Restricted Project
jurahul updated the diff for D92585: [MLIR] Generate inferReturnTypes declaration using InferTypeOpInterface trait..

Address feedback

Dec 3 2020, 4:18 PM · Restricted Project
jurahul updated the diff for D92585: [MLIR] Generate inferReturnTypes declaration using InferTypeOpInterface trait..

Fix clang-tidy warning

Dec 3 2020, 3:38 PM · Restricted Project
jurahul requested review of D92585: [MLIR] Generate inferReturnTypes declaration using InferTypeOpInterface trait..
Dec 3 2020, 10:16 AM · Restricted Project

Dec 2 2020

jurahul updated the diff for D91886: [MLIR] Fix parseFunctionLikeOp() to fail parsing empty regions.

River's feedback

Dec 2 2020, 4:50 PM · Restricted Project
jurahul added a comment to D91886: [MLIR] Fix parseFunctionLikeOp() to fail parsing empty regions.

Not really. Note that both

Dec 2 2020, 10:48 AM · Restricted Project

Dec 1 2020

jurahul committed rG6b043ecdb71b: [MLIR] Fix genTypeInterfaceMethods() to work correctly with InferTypeOpInterface (authored by jurahul).
[MLIR] Fix genTypeInterfaceMethods() to work correctly with InferTypeOpInterface
Dec 1 2020, 1:37 PM
jurahul closed D92414: [MLIR] Fix genTypeInterfaceMethods() to work correctly with InferTypeOpInterface.
Dec 1 2020, 1:37 PM · Restricted Project
jurahul added a comment to D92414: [MLIR] Fix genTypeInterfaceMethods() to work correctly with InferTypeOpInterface.

Could we also remove the hard coding in genTypeInterfaceMethods ? (not for this one)

Dec 1 2020, 1:34 PM · Restricted Project
jurahul added a comment to D92414: [MLIR] Fix genTypeInterfaceMethods() to work correctly with InferTypeOpInterface.

The fix here is such that TableGen generated inferReturnTypes takes precedence over the one generated by the InferTypeOpInterface. Just tagging the Op with the trait is not sufficient since I assume we also want the generated inferReturnTypes. The other possible fix is to avoid generating the TableGen generated inferReturnTypes method when the Op is tagged with DeclareOpInterfaceMethods<InferTypeOpInterface> and delegate the definition of the method to the user. I've erred on the side of using the TableGen one.

Dec 1 2020, 11:27 AM · Restricted Project
jurahul requested review of D92414: [MLIR] Fix genTypeInterfaceMethods() to work correctly with InferTypeOpInterface.
Dec 1 2020, 11:21 AM · Restricted Project

Nov 24 2020

jurahul added a comment to D91886: [MLIR] Fix parseFunctionLikeOp() to fail parsing empty regions.

Ping.

Nov 24 2020, 10:11 AM · Restricted Project

Nov 20 2020

jurahul requested review of D91886: [MLIR] Fix parseFunctionLikeOp() to fail parsing empty regions.
Nov 20 2020, 11:51 AM · Restricted Project

Nov 17 2020

jurahul committed rG8a4fe75d70e1: [NFC] Add unit tests for printing/parsing of variadic operands and results. (authored by jurahul).
[NFC] Add unit tests for printing/parsing of variadic operands and results.
Nov 17 2020, 9:23 AM
jurahul closed D91557: [NFC] Add unit tests for printing/parsing of variadic operands and results..
Nov 17 2020, 9:22 AM · Restricted Project

Nov 16 2020

jurahul updated the diff for D91557: [NFC] Add unit tests for printing/parsing of variadic operands and results..

Fix nit

Nov 16 2020, 5:37 PM · Restricted Project
jurahul committed rGba3317d0baac: Fix flang MLIR unit test verification failures (authored by jurahul).
Fix flang MLIR unit test verification failures
Nov 16 2020, 5:33 PM
jurahul committed rGb7382ed3fea0: [MLIR] Extend Symbol verification to reject public symbol declarations. (authored by jurahul).
[MLIR] Extend Symbol verification to reject public symbol declarations.
Nov 16 2020, 4:06 PM
jurahul closed D91456: [MLIR] Extend Symbol verification to reject public symbol declarations..
Nov 16 2020, 4:06 PM · Restricted Project
jurahul requested review of D91557: [NFC] Add unit tests for printing/parsing of variadic operands and results..
Nov 16 2020, 11:51 AM · Restricted Project

Nov 13 2020

jurahul added inline comments to D91456: [MLIR] Extend Symbol verification to reject public symbol declarations..
Nov 13 2020, 2:36 PM · Restricted Project
jurahul added inline comments to D91456: [MLIR] Extend Symbol verification to reject public symbol declarations..
Nov 13 2020, 2:28 PM · Restricted Project
jurahul updated the diff for D91456: [MLIR] Extend Symbol verification to reject public symbol declarations..

Attempt to resolve merge conflicts

Nov 13 2020, 1:43 PM · Restricted Project
jurahul updated the diff for D91456: [MLIR] Extend Symbol verification to reject public symbol declarations..

Update comment.

Nov 13 2020, 1:05 PM · Restricted Project
jurahul requested review of D91456: [MLIR] Extend Symbol verification to reject public symbol declarations..
Nov 13 2020, 1:02 PM · Restricted Project
jurahul committed rGd8437552205d: [NFC] Refactor function declaration addition in AsyncToLLVM (authored by jurahul).
[NFC] Refactor function declaration addition in AsyncToLLVM
Nov 13 2020, 1:00 PM
jurahul closed D91453: [NFC] Refactor function declaration addition in AsyncToLLVM.
Nov 13 2020, 1:00 PM · Restricted Project
jurahul added reviewers for D91453: [NFC] Refactor function declaration addition in AsyncToLLVM: ezhulenev, rriddle.
Nov 13 2020, 12:01 PM · Restricted Project
jurahul requested review of D91453: [NFC] Refactor function declaration addition in AsyncToLLVM.
Nov 13 2020, 11:58 AM · Restricted Project

Nov 12 2020

jurahul committed rG5883c4b4705e: [MLIR] Fix standard -> LLVM conversion to fail for unsupported memref element… (authored by jurahul).
[MLIR] Fix standard -> LLVM conversion to fail for unsupported memref element…
Nov 12 2020, 5:07 PM
jurahul closed D91374: [MLIR] Fix standard -> LLVM conversion to fail for unsupported memref element type..
Nov 12 2020, 5:06 PM · Restricted Project
jurahul added a comment to D91374: [MLIR] Fix standard -> LLVM conversion to fail for unsupported memref element type..

AFAICT it's not possible today to hit this, so this turns out to be just defensive programming. MemRef element type is either int/float/index/complex or a vector (which itself can only have int or float elements) and all these types seems to be convertible to LLVM types without any failures. As such, I don't think we will run into this issue today, but will guard against future extensions to MemRef types.

Nov 12 2020, 1:30 PM · Restricted Project
jurahul updated the diff for D91374: [MLIR] Fix standard -> LLVM conversion to fail for unsupported memref element type..

Remove leftover check.

Nov 12 2020, 12:05 PM · Restricted Project
jurahul added inline comments to D91374: [MLIR] Fix standard -> LLVM conversion to fail for unsupported memref element type..
Nov 12 2020, 12:05 PM · Restricted Project
jurahul added a comment to D91374: [MLIR] Fix standard -> LLVM conversion to fail for unsupported memref element type..

This addresses the nit in https://reviews.llvm.org/D90803 more generically.

Nov 12 2020, 11:51 AM · Restricted Project
jurahul requested review of D91374: [MLIR] Fix standard -> LLVM conversion to fail for unsupported memref element type..
Nov 12 2020, 11:50 AM · Restricted Project
jurahul committed rGdea24b422cc2: [NFC] Switch printFunctionLikeOp and parseFunctionLikeOp to only support… (authored by jurahul).
[NFC] Switch printFunctionLikeOp and parseFunctionLikeOp to only support…
Nov 12 2020, 11:29 AM
jurahul closed D91369: [NFC] Switch printFunctionLikeOp and parseFunctionLikeOp to only support "inline" visibility..
Nov 12 2020, 11:29 AM · Restricted Project
jurahul requested review of D91369: [NFC] Switch printFunctionLikeOp and parseFunctionLikeOp to only support "inline" visibility..
Nov 12 2020, 10:48 AM · Restricted Project

Nov 9 2020

jurahul committed rG64be856f6da0: [MLIR] Add setPublic(), setPrivate(), and setNested() to Symbol interface (authored by jurahul).
[MLIR] Add setPublic(), setPrivate(), and setNested() to Symbol interface
Nov 9 2020, 1:57 PM
jurahul closed D91096: [MLIR] Add setPublic(), setPrivate(), and setNested() to Symbol interface.
Nov 9 2020, 1:56 PM · Restricted Project
jurahul added inline comments to D90803: [MLIR] Support `global_memref` and `get_global_memref` in standard -> LLVM conversion..
Nov 9 2020, 1:05 PM · Restricted Project
jurahul committed rGe29cb0908bbc: [MLIR] Fix GCC build failure (authored by jurahul).
[MLIR] Fix GCC build failure
Nov 9 2020, 11:58 AM
jurahul added a comment to D91096: [MLIR] Add setPublic(), setPrivate(), and setNested() to Symbol interface.

This is in prep for the verification check I'll be adding to disallow public declarations. Several place (in and out-of-tree) now need to mark declarations private and its much short to use of these functions.

Nov 9 2020, 11:45 AM · Restricted Project
jurahul requested review of D91096: [MLIR] Add setPublic(), setPrivate(), and setNested() to Symbol interface.
Nov 9 2020, 11:44 AM · Restricted Project
jurahul committed rG8b5a3e46326f: [MLIR] Change FuncOp assembly syntax to print visibility inline instead of in… (authored by jurahul).
[MLIR] Change FuncOp assembly syntax to print visibility inline instead of in…
Nov 9 2020, 11:11 AM
jurahul closed D90859: [MLIR] Change FuncOp assembly syntax to print visibility inline instead of in attrib dict..
Nov 9 2020, 11:10 AM · Restricted Project
jurahul committed rGa97e357e8ed4: [MLIR] Support `global_memref` and `get_global_memref` in standard -> LLVM… (authored by jurahul).
[MLIR] Support `global_memref` and `get_global_memref` in standard -> LLVM…
Nov 9 2020, 10:55 AM
jurahul closed D90803: [MLIR] Support `global_memref` and `get_global_memref` in standard -> LLVM conversion..
Nov 9 2020, 10:55 AM · Restricted Project
jurahul added a comment to D90988: [MLIR] Flag no-terminator error on the last operation of non-empty blocks.

I already push this in, but we can revisit this if there is a better way. Could you give an example where the confusion arises? To me, the last instruction seems more relevant because that's where something is missing. Are you suggesting doing:

Nov 9 2020, 9:59 AM · Restricted Project
jurahul committed rGc96168975b25: [MLIR] Flag no-terminator error on the last operation of non-empty blocks (authored by jurahul).
[MLIR] Flag no-terminator error on the last operation of non-empty blocks
Nov 9 2020, 9:42 AM
jurahul closed D90988: [MLIR] Flag no-terminator error on the last operation of non-empty blocks.
Nov 9 2020, 9:42 AM · Restricted Project
jurahul updated the diff for D90803: [MLIR] Support `global_memref` and `get_global_memref` in standard -> LLVM conversion..

Use 0xdeadbeef for allocated pointer

Nov 9 2020, 9:02 AM · Restricted Project
jurahul added inline comments to D90803: [MLIR] Support `global_memref` and `get_global_memref` in standard -> LLVM conversion..
Nov 9 2020, 8:53 AM · Restricted Project
jurahul updated the diff for D90859: [MLIR] Change FuncOp assembly syntax to print visibility inline instead of in attrib dict..

Address feedback

Nov 9 2020, 8:24 AM · Restricted Project

Nov 8 2020

jurahul updated the diff for D90859: [MLIR] Change FuncOp assembly syntax to print visibility inline instead of in attrib dict..

Use llvm::is_contained() in parseOptionalKeyword

Nov 8 2020, 4:56 PM · Restricted Project

Nov 6 2020

jurahul added inline comments to D90859: [MLIR] Change FuncOp assembly syntax to print visibility inline instead of in attrib dict..
Nov 6 2020, 5:51 PM · Restricted Project
jurahul updated the diff for D90859: [MLIR] Change FuncOp assembly syntax to print visibility inline instead of in attrib dict..

Review feedback

Nov 6 2020, 5:47 PM · Restricted Project
jurahul added inline comments to D90859: [MLIR] Change FuncOp assembly syntax to print visibility inline instead of in attrib dict..
Nov 6 2020, 5:13 PM · Restricted Project
jurahul added inline comments to D90803: [MLIR] Support `global_memref` and `get_global_memref` in standard -> LLVM conversion..
Nov 6 2020, 5:02 PM · Restricted Project
jurahul added a comment to D90859: [MLIR] Change FuncOp assembly syntax to print visibility inline instead of in attrib dict..

I did think of moving the visibility enums to ODS, but I wasn't sure how operations like ModuleOp and FuncOp that are defined outside ODS will use it. Also StrEnumAttr still prints a quoted string I think, so beyond that, we would also need some kind of qualifier in the declarative assembly syntax to indicate that the custom parser needs to print it without quotes (something like noquotes($sym_visibility)). So did not go down that path.

Nov 6 2020, 4:55 PM · Restricted Project
jurahul added inline comments to D90859: [MLIR] Change FuncOp assembly syntax to print visibility inline instead of in attrib dict..
Nov 6 2020, 4:53 PM · Restricted Project
jurahul added inline comments to D90988: [MLIR] Flag no-terminator error on the last operation of non-empty blocks.
Nov 6 2020, 4:45 PM · Restricted Project
jurahul updated the diff for D90859: [MLIR] Change FuncOp assembly syntax to print visibility inline instead of in attrib dict..

Update syntax to not have quotes around visibility

Nov 6 2020, 4:34 PM · Restricted Project
jurahul requested review of D90988: [MLIR] Flag no-terminator error on the last operation of non-empty blocks.
Nov 6 2020, 4:25 PM · Restricted Project
jurahul added a comment to D90859: [MLIR] Change FuncOp assembly syntax to print visibility inline instead of in attrib dict..

I don't think there's a way to do that with the declarative parses though, and we use that std.global_memref so I avoided diverging the syntax between the two. But I do agree that quotes are not that readable. I can change this to be unquoted, but then we would need to change global_memref to use the similar syntax, likely by using the custom directive. @rriddle/@mehdi_amin, what do you think? It almost seems that the SymbolTable can provide helper functions to print/parse visibility that can be reused here across ops.

Nov 6 2020, 2:43 PM · Restricted Project

Nov 5 2020

jurahul added a comment to D90803: [MLIR] Support `global_memref` and `get_global_memref` in standard -> LLVM conversion..

@mehdi_amini or @ftynse, can one you take a look as well?

Nov 5 2020, 2:45 PM · Restricted Project