Page MenuHomePhabricator
Feed Advanced Search

Aug 18 2017

mnbvmar created D36898: [llvm-rc] Add MENU parsing ability. [4/8].
Aug 18 2017, 2:18 PM
mnbvmar updated the summary of D36894: [llvm-rc] Add ACCELERATORS parsing ability. [3/8].
Aug 18 2017, 1:50 PM
mnbvmar added reviewers for D36891: [llvm-rc] Add ICON and HTML parsing ability [2/8]: zturner, rnk, ecbeckmann.
Aug 18 2017, 1:46 PM
mnbvmar created D36894: [llvm-rc] Add ACCELERATORS parsing ability. [3/8].
Aug 18 2017, 1:41 PM
mnbvmar created D36891: [llvm-rc] Add ICON and HTML parsing ability [2/8].
Aug 18 2017, 1:18 PM
mnbvmar committed rL311184: Reapply: [llvm-rc] Add basic RC scripts parsing ability..
Reapply: [llvm-rc] Add basic RC scripts parsing ability.
Aug 18 2017, 11:26 AM
mnbvmar committed rL311177: Revert "[llvm-rc] Add basic RC scripts parsing ability.".
Revert "[llvm-rc] Add basic RC scripts parsing ability."
Aug 18 2017, 10:27 AM
mnbvmar committed rL311175: [llvm-rc] Add basic RC scripts parsing ability..
[llvm-rc] Add basic RC scripts parsing ability.
Aug 18 2017, 10:07 AM
mnbvmar closed D36340: [llvm-rc] Add .rc scripts parser. by committing rL311175: [llvm-rc] Add basic RC scripts parsing ability..
Aug 18 2017, 10:06 AM

Aug 17 2017

mnbvmar updated the diff for D36340: [llvm-rc] Add .rc scripts parser..

Tests failed locally on Windows; fixed their invocation.

Aug 17 2017, 5:55 PM
mnbvmar updated the diff for D36340: [llvm-rc] Add .rc scripts parser..

Style fixes, added macro-based error handling.

Aug 17 2017, 2:23 PM
mnbvmar added inline comments to D36340: [llvm-rc] Add .rc scripts parser..
Aug 17 2017, 1:42 PM
mnbvmar added inline comments to D36340: [llvm-rc] Add .rc scripts parser..
Aug 17 2017, 1:20 PM

Aug 16 2017

mnbvmar updated the diff for D36340: [llvm-rc] Add .rc scripts parser..

Small style fixes according to the suggestions.

Aug 16 2017, 2:10 PM

Aug 15 2017

mnbvmar added a comment to D36340: [llvm-rc] Add .rc scripts parser..

Some comments stopped being relevant to the current patch.

Aug 15 2017, 10:36 AM
mnbvmar updated the diff for D36340: [llvm-rc] Add .rc scripts parser..

Parser rewritten to a single non-templated class. The new patch supports the same set of resources as before.

Aug 15 2017, 10:34 AM

Aug 10 2017

mnbvmar updated the diff for D36340: [llvm-rc] Add .rc scripts parser..

Code rewritten a little bit.

Aug 10 2017, 6:32 PM
mnbvmar added inline comments to D36340: [llvm-rc] Add .rc scripts parser..
Aug 10 2017, 6:13 PM
mnbvmar committed rL310623: Fixup for r310621: Hint the compilers about unreachable code..
Fixup for r310621: Hint the compilers about unreachable code.
Aug 10 2017, 9:47 AM
mnbvmar added inline comments to D36340: [llvm-rc] Add .rc scripts parser..
Aug 10 2017, 9:37 AM
mnbvmar committed rL310621: Add .rc scripts tokenizer..
Add .rc scripts tokenizer.
Aug 10 2017, 9:22 AM
mnbvmar closed D35957: [llvm-rc] Add .rc scripts tokenizer. by committing rL310621: Add .rc scripts tokenizer..
Aug 10 2017, 9:22 AM

Aug 4 2017

mnbvmar updated the diff for D35957: [llvm-rc] Add .rc scripts tokenizer..

Remove unnecessary namespace annotation; fix the non-evaluated assert() bug.

Aug 4 2017, 4:07 PM
mnbvmar added reviewers for D36340: [llvm-rc] Add .rc scripts parser.: amharc, rnk, ecbeckmann, zturner, kuhar.
Aug 4 2017, 3:18 PM
mnbvmar updated the diff for D36340: [llvm-rc] Add .rc scripts parser..

Style fixes.

Aug 4 2017, 3:07 PM
mnbvmar updated the summary of D36340: [llvm-rc] Add .rc scripts parser..
Aug 4 2017, 2:39 PM
mnbvmar created D36340: [llvm-rc] Add .rc scripts parser..
Aug 4 2017, 2:35 PM

Jul 31 2017

mnbvmar added inline comments to D35957: [llvm-rc] Add .rc scripts tokenizer..
Jul 31 2017, 5:05 PM
mnbvmar added inline comments to D35957: [llvm-rc] Add .rc scripts tokenizer..
Jul 31 2017, 3:13 PM
mnbvmar updated the diff for D35957: [llvm-rc] Add .rc scripts tokenizer..

Forgot to remove llvm::'s.

Jul 31 2017, 3:10 PM
mnbvmar updated the diff for D35957: [llvm-rc] Add .rc scripts tokenizer..

Fixed style/nits; tokenizer starts using Error/Expected.

Jul 31 2017, 3:05 PM
mnbvmar added a reviewer for D35957: [llvm-rc] Add .rc scripts tokenizer.: zturner.
Jul 31 2017, 1:03 PM

Jul 27 2017

mnbvmar created D35957: [llvm-rc] Add .rc scripts tokenizer..
Jul 27 2017, 2:57 PM

Jul 25 2017

mnbvmar added a comment to D35852: Quote '?' in llvm-rc test.

It seems that single-quotes fail on Windows ('/h' is considered a whole argument, including the quotes). Double-quotes should work, though.

Jul 25 2017, 2:35 PM

Jul 24 2017

mnbvmar committed rL308940: Add an empty shell of llvm-rc..
Add an empty shell of llvm-rc.
Jul 24 2017, 5:26 PM
mnbvmar closed D35810: Add an empty shell of llvm-rc. by committing rL308940: Add an empty shell of llvm-rc..
Jul 24 2017, 5:26 PM
mnbvmar updated the diff for D35810: Add an empty shell of llvm-rc..

Removed unnecessary error handling methods.

Jul 24 2017, 3:47 PM
mnbvmar added inline comments to D35810: Add an empty shell of llvm-rc..
Jul 24 2017, 3:42 PM
mnbvmar updated the diff for D35810: Add an empty shell of llvm-rc..

Typos fixed.

Jul 24 2017, 3:31 PM
mnbvmar created D35810: Add an empty shell of llvm-rc..
Jul 24 2017, 11:50 AM

Jan 25 2017

mnbvmar created D29151: [clang-tidy] Add misc-invalidated-iterators check..
Jan 25 2017, 3:11 PM

Dec 24 2016

mnbvmar committed rL290489: [clang-tidy] refactor ExprSequence out of use-after-move check.
[clang-tidy] refactor ExprSequence out of use-after-move check
Dec 24 2016, 4:56 AM
mnbvmar closed D27700: [clang-tidy] refactor ExprSequence out of misc-use-after-move check by committing rL290489: [clang-tidy] refactor ExprSequence out of use-after-move check.
Dec 24 2016, 4:56 AM

Dec 16 2016

mnbvmar added inline comments to D27700: [clang-tidy] refactor ExprSequence out of misc-use-after-move check.
Dec 16 2016, 4:00 AM
mnbvmar updated the diff for D27700: [clang-tidy] refactor ExprSequence out of misc-use-after-move check.

Minor changes, according to the request.

Dec 16 2016, 3:59 AM

Dec 12 2016

mnbvmar added a reviewer for D27700: [clang-tidy] refactor ExprSequence out of misc-use-after-move check: alexfh.
Dec 12 2016, 11:24 PM
mnbvmar updated subscribers of D27700: [clang-tidy] refactor ExprSequence out of misc-use-after-move check.
Dec 12 2016, 11:23 PM
mnbvmar updated the diff for D27700: [clang-tidy] refactor ExprSequence out of misc-use-after-move check.

Fix "no-newline-at-the-end-of-file" message.

Dec 12 2016, 11:22 PM
mnbvmar updated the diff for D27700: [clang-tidy] refactor ExprSequence out of misc-use-after-move check.
Dec 12 2016, 11:21 PM
mnbvmar retitled D27700: [clang-tidy] refactor ExprSequence out of misc-use-after-move check from to [clang-tidy] refactor ExprSequence out of misc-use-after-move check.
Dec 12 2016, 11:20 PM

Jun 14 2016

mnbvmar added inline comments to D21303: [clang-tidy] Adds performance-returning-type check..
Jun 14 2016, 2:11 AM

Jun 2 2016

mnbvmar added inline comments to D20053: [clang-tidy] Add misc-unnecessary-mutable check..
Jun 2 2016, 12:53 PM
mnbvmar added a comment to D20053: [clang-tidy] Add misc-unnecessary-mutable check..
Jun 2 2016, 12:45 PM
mnbvmar updated the diff for D20053: [clang-tidy] Add misc-unnecessary-mutable check..

Fixes done.
Added macro test.
Docs should be working now.
Updated docs.

Jun 2 2016, 12:44 PM

May 30 2016

mnbvmar updated the diff for D19165: [clang-tidy] Add modernize-increment-bool check..

Clang-formatted code.
Added a simple macro test.
Resolved @Prazek's issues.

May 30 2016, 2:32 AM

May 8 2016

mnbvmar retitled D20053: [clang-tidy] Add misc-unnecessary-mutable check. from to [clang-tidy] Add misc-unnecessary-mutable check..
May 8 2016, 12:38 AM

Apr 15 2016

mnbvmar retitled D19165: [clang-tidy] Add modernize-increment-bool check. from to [clang-tidy] Add modernize-increment-bool check..
Apr 15 2016, 9:47 AM

Apr 6 2016

mnbvmar added a comment to D18745: [clang-tidy] Adds modernize-use-bool-literals check..

You could also think whether char literals should be converted to true/false, too. Apart from this (and other people's doubts), everything's fine.

Apr 6 2016, 1:01 PM
mnbvmar added a reviewer for D18745: [clang-tidy] Adds modernize-use-bool-literals check.: mnbvmar.
Apr 6 2016, 12:45 PM
mnbvmar added a comment to D18821: Add bugprone-bool-to-integer-conversion.

This check throws a warning also on the conversion to floats (probably very rare ones):

Apr 6 2016, 12:24 PM
mnbvmar added a reviewer for D18821: Add bugprone-bool-to-integer-conversion: mnbvmar.
Apr 6 2016, 12:10 PM