Page MenuHomePhabricator
Feed Advanced Search

Aug 19 2016

dvlahovski committed rL279234: Fixing a Darwing test thats failing on windows.
Fixing a Darwing test thats failing on windows
Aug 19 2016, 5:52 AM
dvlahovski added a comment to D23545: Minidump parsing.

I'm thinking of doing the following approach regarding the plugin implementation:
Start writing a new plugin "from scratch", which will be inspired strongly by ProcessWinMiniDump and also borrowing stuff from ProcessElfCore.
Also my plan is to make a single cross-platform Minidump plugin. At least for now I think that there aren't so many differences between Minidumps
generated on different platforms. (If the code gets messy probably a separate plugin for each platform is better.)
Also I think that I could reuse the Windows Minidump tests by pointing them to the new plugin and see if we
have at least the same (working) functionality.

Aug 19 2016, 4:46 AM
dvlahovski updated the diff for D23545: Minidump parsing.

Adding sanity checks whether the data buffer

Aug 19 2016, 4:39 AM

Aug 18 2016

dvlahovski added inline comments to D23545: Minidump parsing.
Aug 18 2016, 11:10 AM
dvlahovski added a comment to D23545: Minidump parsing.

Also FYI I copied the implementation of consumeObject to my header.

Aug 18 2016, 11:06 AM
dvlahovski added inline comments to D23545: Minidump parsing.
Aug 18 2016, 11:03 AM
dvlahovski added inline comments to D23545: Minidump parsing.
Aug 18 2016, 10:59 AM
dvlahovski added a comment to D23545: Minidump parsing.

Are we putting this code in the right place? I wouldn't expect minidump parsing to fall under Plugins/Process.

I assume the eventual intent is to turn the Windows-specific code into a user of your new code? I look forward to seeing that happen.

Aug 18 2016, 10:10 AM
dvlahovski added inline comments to D23545: Minidump parsing.
Aug 18 2016, 10:09 AM
dvlahovski updated the diff for D23545: Minidump parsing.

Update of the code, regarding the remarks

Aug 18 2016, 10:06 AM

Aug 16 2016

dvlahovski added inline comments to D23545: Minidump parsing.
Aug 16 2016, 9:44 AM
dvlahovski updated the diff for D23545: Minidump parsing.

Fixing a little bug - should get the byteorder

Aug 16 2016, 8:11 AM
dvlahovski updated the diff for D23545: Minidump parsing.

Resolving Pavel's remarks

Aug 16 2016, 7:56 AM
dvlahovski retitled D23545: Minidump parsing from to Minidump parsing.
Aug 16 2016, 3:15 AM

Jul 29 2016

dvlahovski committed rL277140: Add/fix support for i386 elf core files.
Add/fix support for i386 elf core files
Jul 29 2016, 6:26 AM
dvlahovski closed D22917: Add/fix support for i386 elf core files by committing rL277140: Add/fix support for i386 elf core files.
Jul 29 2016, 6:25 AM

Jul 28 2016

dvlahovski updated the diff for D22917: Add/fix support for i386 elf core files.

Checking for null pointer, in case of a corrupt core file

Jul 28 2016, 10:15 AM
dvlahovski retitled D22917: Add/fix support for i386 elf core files from to Add/fix support for i386 elf core files.
Jul 28 2016, 8:17 AM

Jul 22 2016

dvlahovski added a comment to D22628: Fixing layout of elf-core file related structures.

So, alignas doesn't work with typedef
We can use a #define but that's kind of ugly

Jul 22 2016, 4:46 AM

Jul 21 2016

dvlahovski updated the diff for D22628: Fixing layout of elf-core file related structures.

Forgot to add alignas to two members of prstatus

Jul 21 2016, 8:37 AM
dvlahovski retitled D22628: Fixing layout of elf-core file related structures from to Fixing layout of elf-core file related structures.
Jul 21 2016, 7:14 AM