Page MenuHomePhabricator
Feed Advanced Search

Today

sylvestre.ledru added a comment to D63810: Change the default arm-linux-gnueabihf target to armv7.

If accepted, I will of course update the release notes

Wed, Jun 26, 1:31 AM · Restricted Project
sylvestre.ledru updated the summary of D63810: Change the default arm-linux-gnueabihf target to armv7.
Wed, Jun 26, 1:31 AM · Restricted Project
sylvestre.ledru created D63810: Change the default arm-linux-gnueabihf target to armv7.
Wed, Jun 26, 1:28 AM · Restricted Project

Fri, Jun 21

sylvestre.ledru added a comment to D59253: [AIX][libcxx] AIX system headers need stdint.h and inttypes.h to be re-enterable when macro _STD_TYPES_T is defined.

FYI, I had similar patches for Linux/Debian packaging.
Thanks!

Fri, Jun 21, 6:31 AM · Restricted Project, Restricted Project, Restricted Project

Fri, Jun 14

sylvestre.ledru committed rG0f15ba98f57d: add a missing parenthese in the clang doc (authored by sylvestre.ledru).
add a missing parenthese in the clang doc
Fri, Jun 14, 4:31 AM

Tue, Jun 11

sylvestre.ledru added a comment to D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version.

I will wait for @dexonsmith 's opinion

Tue, Jun 11, 12:18 AM · Restricted Project

Sat, Jun 8

sylvestre.ledru added inline comments to D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version.
Sat, Jun 8, 11:47 AM · Restricted Project
sylvestre.ledru updated the diff for D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version.

fix rst syntax

Sat, Jun 8, 10:58 AM · Restricted Project
sylvestre.ledru updated the diff for D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version.

Fix the typo (thanks hubert)

Sat, Jun 8, 8:20 AM · Restricted Project
sylvestre.ledru committed rG375297f38fe8: fix a typo unavaliable=>unavailable (authored by sylvestre.ledru).
fix a typo unavaliable=>unavailable
Sat, Jun 8, 8:05 AM
sylvestre.ledru updated the diff for D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version.

update of the release notes

Sat, Jun 8, 8:05 AM · Restricted Project
sylvestre.ledru added a comment to D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version.

Btw, what about this code

// Currently claim to be compatible with GCC 4.2.1-5621, but only if we're
// not compiling for MSVC compatibility
Builder.defineMacro("__GNUC_MINOR__", "2");
Builder.defineMacro("__GNUC_PATCHLEVEL__", "1");
Builder.defineMacro("__GNUC__", "4");

?

Sat, Jun 8, 8:05 AM · Restricted Project
sylvestre.ledru added a reviewer for D60380: Also document -arch as -arch is mac specific: rnk.
Sat, Jun 8, 7:44 AM · Restricted Project
sylvestre.ledru abandoned D59702: Unbreak the build of compiler-rt on Linux/mips64el.

indeed, closing

Sat, Jun 8, 7:44 AM · Restricted Project, Restricted Project
sylvestre.ledru abandoned D60379: Make precompiled headers reproducible.

yeah
thanks

Sat, Jun 8, 7:44 AM · Restricted Project
sylvestre.ledru created D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version.
Sat, Jun 8, 7:41 AM · Restricted Project

May 21 2019

sylvestre.ledru added inline comments to D61909: Add Clang shared library with C++ exports.
May 21 2019, 11:56 PM · Restricted Project

May 18 2019

sylvestre.ledru added a comment to D61909: Add Clang shared library with C++ exports.

@beanz Great doc, thanks! I will see what I could use for Debian/Ubuntu packages (as we have a lot users and packages organized in a specific way, it isn't always easy to make huge changes)

May 18 2019, 1:33 AM · Restricted Project

May 17 2019

sylvestre.ledru added a comment to D61909: Add Clang shared library with C++ exports.

ok, it should probably be installed in that case (it is currently in usr/lib/llvm-9/lib/libclang_shared.so.9 )
by the way, the name of lib isn't super explicit :/

May 17 2019, 11:21 AM · Restricted Project
sylvestre.ledru added a comment to D61909: Add Clang shared library with C++ exports.

@beanz @tstellar
I am wondering what to do wrt apt.llvm.org
should it be part of libclang or create a libclang++ package
what do you think?

May 17 2019, 11:14 AM · Restricted Project

May 16 2019

sylvestre.ledru added a comment to rL360753: Replace assert with static_assert here applicable..

This change is breaking the build on i386 stage2 build.
https://llvm-jenkins.debian.net/job/llvm-toolchain-trusty-binaries/architecture=i386,distribution=trusty/1941/consoleFull

May 16 2019, 4:46 AM
sylvestre.ledru added a comment to rL360825: [mips] Always use _LARGEFILE_SOURCE / _FILE_OFFSET_BITS for building MIPS 32-bit.

Thanks, I reported:
https://bugs.llvm.org/show_bug.cgi?id=41894
to have it in 8.0.1

May 16 2019, 12:27 AM

May 1 2019

sylvestre.ledru added a comment to D59702: Unbreak the build of compiler-rt on Linux/mips64el.

@atanasyan, I tried with

May 1 2019, 5:07 AM · Restricted Project, Restricted Project

Apr 27 2019

sylvestre.ledru added a comment to D58573: [analyzer] Move UninitializedObjectChecker out of alpha.

I took the liberty to add that in the release notes of clang
https://reviews.llvm.org/rG5f163c7e2e62

Apr 27 2019, 2:10 AM · Restricted Project

Apr 26 2019

sylvestre.ledru committed rG5f163c7e2e62: Add to the release notes the fact that UninitializedObject checker is now… (authored by sylvestre.ledru).
Add to the release notes the fact that UninitializedObject checker is now…
Apr 26 2019, 2:45 PM

Apr 19 2019

sylvestre.ledru committed rG5505ad34dbdd: Debian: Add two missing version code in sid (authored by sylvestre.ledru).
Debian: Add two missing version code in sid
Apr 19 2019, 6:47 AM
sylvestre.ledru committed rG54a93a33ee64: Add support of the future Debian (Debian 11 - Bullseye) https://wiki.debian. (authored by sylvestre.ledru).
Add support of the future Debian (Debian 11 - Bullseye) https://wiki.debian.
Apr 19 2019, 6:47 AM
sylvestre.ledru committed rG454014199ddf: Add support of the next Ubuntu (Ubuntu 19.10 - Eoan EANIMAL) (authored by sylvestre.ledru).
Add support of the next Ubuntu (Ubuntu 19.10 - Eoan EANIMAL)
Apr 19 2019, 6:44 AM

Apr 16 2019

sylvestre.ledru abandoned D60360: Dump the minimal version of cmake 3.5.0.

As you wish.
People who might encounter the same issue will (hopefully) find this review

Apr 16 2019, 5:54 AM · Restricted Project
sylvestre.ledru added a comment to D60360: Dump the minimal version of cmake 3.5.0.

I didn't look at the details. It was failing with 3.4, upgrading to 3.5 address the issue.

Apr 16 2019, 5:02 AM · Restricted Project

Apr 8 2019

sylvestre.ledru added a comment to D60379: Make precompiled headers reproducible.

To be clear, this isn't about format stability and distributing but making sure that two same runs of clang produces the same output.

Apr 8 2019, 12:51 PM · Restricted Project
sylvestre.ledru added a reviewer for D60360: Dump the minimal version of cmake 3.5.0: stephenkelly.
Apr 8 2019, 7:58 AM · Restricted Project
sylvestre.ledru added a comment to D60379: Make precompiled headers reproducible.

I won't have time to write the test for that (and would not know where to start). I am just the messenger :)

Apr 8 2019, 1:36 AM · Restricted Project
sylvestre.ledru updated the summary of D60379: Make precompiled headers reproducible.
Apr 8 2019, 1:33 AM · Restricted Project

Apr 7 2019

sylvestre.ledru created D60380: Also document -arch as -arch is mac specific.
Apr 7 2019, 3:11 PM · Restricted Project
sylvestre.ledru created D60379: Make precompiled headers reproducible.
Apr 7 2019, 3:09 PM · Restricted Project

Apr 6 2019

sylvestre.ledru updated the summary of D60360: Dump the minimal version of cmake 3.5.0.
Apr 6 2019, 12:12 AM · Restricted Project

Apr 5 2019

sylvestre.ledru created D60360: Dump the minimal version of cmake 3.5.0.
Apr 5 2019, 11:51 PM · Restricted Project

Apr 3 2019

sylvestre.ledru added a comment to D60115: Adding 'CLion integration' to clang-format doc.

You are welcome, thanks for your contribution!

Apr 3 2019, 2:06 AM · Restricted Project
sylvestre.ledru committed rGacab05feeeb5: Adding 'CLion integration' to clang-format doc (authored by sylvestre.ledru).
Adding 'CLion integration' to clang-format doc
Apr 3 2019, 1:55 AM
sylvestre.ledru updated the summary of D60115: Adding 'CLion integration' to clang-format doc.
Apr 3 2019, 1:54 AM · Restricted Project
sylvestre.ledru added a comment to D60115: Adding 'CLion integration' to clang-format doc.

Sure, i will do it for you

Apr 3 2019, 1:54 AM · Restricted Project
sylvestre.ledru accepted D60115: Adding 'CLion integration' to clang-format doc.

works for me, thanks

Apr 3 2019, 12:53 AM · Restricted Project

Apr 2 2019

sylvestre.ledru added inline comments to D60115: Adding 'CLion integration' to clang-format doc.
Apr 2 2019, 1:28 AM · Restricted Project

Mar 31 2019

sylvestre.ledru committed rG7fb58e98f547: Spelling correction for docs for cppcoreguidelines-owning-memory (authored by sylvestre.ledru).
Spelling correction for docs for cppcoreguidelines-owning-memory
Mar 31 2019, 2:54 PM
sylvestre.ledru added a comment to D60050: Spelling correction for docs for cppcoreguidelines-owning-memory.

If you have permissions on the repo, no need for a review for such change!

Mar 31 2019, 2:33 PM · Restricted Project, Restricted Project, Restricted Project

Mar 26 2019

sylvestre.ledru committed rG90dbbdbc95ca: update the release notes after the change of 'clang -dumpversion' (authored by sylvestre.ledru).
update the release notes after the change of 'clang -dumpversion'
Mar 26 2019, 2:48 AM

Mar 25 2019

sylvestre.ledru committed rGa199a9ba40c7: clang -dumpversion returns 4.2.1 for legacy reason, update it (authored by sylvestre.ledru).
clang -dumpversion returns 4.2.1 for legacy reason, update it
Mar 25 2019, 11:07 AM
sylvestre.ledru updated the diff for D56803: clang -dumpversion returns 4.2.1 for legacy reason, update it.

Remove the empty directories

Mar 25 2019, 11:03 AM · Restricted Project, Restricted Project
sylvestre.ledru updated the diff for D56803: clang -dumpversion returns 4.2.1 for legacy reason, update it.

Improve the test (thanks rnk)

Mar 25 2019, 11:03 AM · Restricted Project, Restricted Project
sylvestre.ledru added a comment to D56803: clang -dumpversion returns 4.2.1 for legacy reason, update it.

@rnk btw, do you think it should be added to the clang release notes?

Mar 25 2019, 11:03 AM · Restricted Project, Restricted Project
sylvestre.ledru added a comment to D59702: Unbreak the build of compiler-rt on Linux/mips64el.

Debian testing
you can see the full log here:
https://buildd.debian.org/status/fetch.php?pkg=llvm-toolchain-8&arch=mips64el&ver=1%3A8~%2Brc5-1&stamp=1552412165&raw=0

Mar 25 2019, 7:54 AM · Restricted Project, Restricted Project
sylvestre.ledru added a comment to D59702: Unbreak the build of compiler-rt on Linux/mips64el.

I agree that 104 looks strange... but it worked.
As I said, I am no expert in mips64el. :/

Mar 25 2019, 7:47 AM · Restricted Project, Restricted Project
sylvestre.ledru added a comment to D59702: Unbreak the build of compiler-rt on Linux/mips64el.

@atanasyan ok with you?

Mar 25 2019, 6:47 AM · Restricted Project, Restricted Project

Mar 23 2019

sylvestre.ledru committed rGd53135767de5: Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format. (authored by sylvestre.ledru).
Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format.
Mar 23 2019, 10:59 AM
sylvestre.ledru added a reviewer for D56803: clang -dumpversion returns 4.2.1 for legacy reason, update it: rnk.
Mar 23 2019, 10:59 AM · Restricted Project, Restricted Project
sylvestre.ledru updated the summary of D56803: clang -dumpversion returns 4.2.1 for legacy reason, update it.
Mar 23 2019, 10:59 AM · Restricted Project, Restricted Project
sylvestre.ledru updated the diff for D58186: Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format.h`.

Try again

Mar 23 2019, 10:55 AM · Restricted Project
sylvestre.ledru updated the diff for D58186: Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format.h`.

Remove unrelated changes

Mar 23 2019, 10:52 AM · Restricted Project
sylvestre.ledru updated the diff for D58186: Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format.h`.

Svn version

Mar 23 2019, 10:48 AM · Restricted Project
sylvestre.ledru updated the summary of D58186: Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format.h`.
Mar 23 2019, 10:37 AM · Restricted Project

Mar 22 2019

sylvestre.ledru added a comment to D59702: Unbreak the build of compiler-rt on Linux/mips64el.

Not sure what I am doing but it fixes the issue

Mar 22 2019, 9:55 AM · Restricted Project, Restricted Project
sylvestre.ledru created D59702: Unbreak the build of compiler-rt on Linux/mips64el.
Mar 22 2019, 9:55 AM · Restricted Project, Restricted Project

Mar 20 2019

sylvestre.ledru committed rGba92e9bb1187: [perf][DebugInfo] follow up for "add SectionedAddress to DebugInfo interfaces" (authored by sylvestre.ledru).
[perf][DebugInfo] follow up for "add SectionedAddress to DebugInfo interfaces"
Mar 20 2019, 3:02 AM
sylvestre.ledru added a comment to D59189: [perf][DebugInfo] follow up for "add SectionedAddress to DebugInfo interfaces".

Sorry for the latency, I didn't receive the notification :/

Mar 20 2019, 3:01 AM · Restricted Project

Mar 13 2019

sylvestre.ledru updated the diff for D59189: [perf][DebugInfo] follow up for "add SectionedAddress to DebugInfo interfaces".

Remove an unrelated change

Mar 13 2019, 10:52 AM · Restricted Project
sylvestre.ledru updated the diff for D59189: [perf][DebugInfo] follow up for "add SectionedAddress to DebugInfo interfaces".

Also set SectionIndex

Mar 13 2019, 10:51 AM · Restricted Project
Herald added a project to D56803: clang -dumpversion returns 4.2.1 for legacy reason, update it: Restricted Project.

@ddunbar ping?

Mar 13 2019, 10:45 AM · Restricted Project, Restricted Project

Mar 10 2019

sylvestre.ledru added a comment to D59189: [perf][DebugInfo] follow up for "add SectionedAddress to DebugInfo interfaces".

The build is broken with:

{anonymous}::PerfJITEventListener::notifyObjectLoaded(llvm::JITEventListener::ObjectKey, const llvm::object::ObjectFile&, const llvm::RuntimeDyld::LoadedObjectInfo&)':
/build/llvm-toolchain-snapshot-9~svn355786/lib/ExecutionEngine/PerfJITEvents/PerfJITEventListener.cpp:274:55: error: no matching function for call to 'llvm::DIContext::getLineInfoForAddressRange(uint64_t&, uint64_t&, llvm::DILineInfoSpecifier::FileLineInfoKind)'
         Addr, Size, FileLineInfoKind::AbsoluteFilePath);
                                                       ^
In file included from /build/llvm-toolchain-snapshot-9~svn355786/include/llvm/DebugInfo/DWARF/DWARFContext.h:18:0,
                 from /build/llvm-toolchain-snapshot-9~svn355786/lib/ExecutionEngine/PerfJITEvents/PerfJITEventListener.cpp:20:
/build/llvm-toolchain-snapshot-9~svn355786/include/llvm/DebugInfo/DIContext.h:209:27: note: candidate: virtual llvm::DILineInfoTable llvm::DIContext::getLineInfoForAddressRange(llvm::object::SectionedAddress, uint64_t, llvm::DILineInfoSpecifier)
   virtual DILineInfoTable getLineInfoForAddressRange(
                           ^~~~~~~~~~~~~~~~~~~~~~~~~~
/build/llvm-toolchain-snapshot-9~svn355786/include/llvm/DebugInfo/DIContext.h:209:27: note:   no known conversion for argument 1 from 'uint64_t {aka long unsigned int}' to 'llvm::object::SectionedAddress'
Mar 10 2019, 8:59 AM · Restricted Project
sylvestre.ledru created D59189: [perf][DebugInfo] follow up for "add SectionedAddress to DebugInfo interfaces".
Mar 10 2019, 8:58 AM · Restricted Project

Feb 21 2019

sylvestre.ledru accepted D57859: llvm-config: Include -stdlib= in --cxxflags.
Feb 21 2019, 6:20 AM · Restricted Project
sylvestre.ledru accepted D58186: Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format.h`.

Do you have permissions on the repo?

Feb 21 2019, 6:19 AM · Restricted Project

Jan 28 2019

sylvestre.ledru added a comment to D33440: clang-format: better handle statement macros.

@Typz
I think this should be part of the release notes for v8.
This is changing the output on some code base and this is a new feature.

Jan 28 2019, 2:55 AM · Restricted Project
sylvestre.ledru added a comment to D56803: clang -dumpversion returns 4.2.1 for legacy reason, update it.

ping?

Jan 28 2019, 2:55 AM · Restricted Project, Restricted Project

Jan 26 2019

Herald updated subscribers of D53354: [WIP][NOT FOR COMMIT][PROTOTYPE] clang-scan-deps: dependency scanning tool rough prototype.
Jan 26 2019, 2:17 AM · Restricted Project

Jan 23 2019

sylvestre.ledru added a comment to D56803: clang -dumpversion returns 4.2.1 for legacy reason, update it.

@ddunbar is that ok with you? Thanks
See
https://bugs.llvm.org/show_bug.cgi?id=38836
https://bugs.launchpad.net/ubuntu/+source/llvm-defaults/+bug/1810860

Jan 23 2019, 2:03 PM · Restricted Project, Restricted Project

Jan 21 2019

sylvestre.ledru added a comment to D56946: [Documentation] Use HTTPS whenever possible in Clang.

Did you test all url?

Jan 21 2019, 5:49 AM · Restricted Project
sylvestre.ledru added a comment to D54472: Disable invalid isPodLike<> specialization.

@serge-sans-paille
This (probably) broke LLVM on Debian jessie. It fails with:

Jan 21 2019, 4:49 AM

Jan 17 2019

sylvestre.ledru resigned from D24863: Keep dependencies separated between static and dynamic libraries. Fix for bug #28127. .
Jan 17 2019, 5:42 AM · Restricted Project

Jan 16 2019

sylvestre.ledru abandoned D23976: Disable the common parts for the sanitizer tools on kfreebsd.

fixed I think

Jan 16 2019, 11:53 PM
sylvestre.ledru added a reviewer for D53014: Add CMAKE_BUILD_TYPE to the list of BOOTSTRAP_DEFAULT_PASSTHROUGH variables: beanz.
Jan 16 2019, 11:51 PM
sylvestre.ledru created D56803: clang -dumpversion returns 4.2.1 for legacy reason, update it.
Jan 16 2019, 1:05 PM · Restricted Project, Restricted Project

Jan 10 2019

sylvestre.ledru added a comment to D55434: ObjectFileBreakpad: Implement sections.

On i386

Jan 10 2019, 7:56 AM
sylvestre.ledru added a comment to D55434: ObjectFileBreakpad: Implement sections.

@labath This broke lldb on Debian stable:

Jan 10 2019, 7:36 AM

Dec 13 2018

sylvestre.ledru updated the summary of D55382: Make -Wstring-plus-int warns even if when the result is not out of bounds.
Dec 13 2018, 8:06 AM

Dec 10 2018

sylvestre.ledru added a comment to D54677: [hurd] Fix unconditional use of PATH_MAX.

@EricWF is it ok to land? Thanks

Dec 10 2018, 2:19 AM

Dec 7 2018

sylvestre.ledru accepted D55391: Don't add unnecessary compiler flags to llvm-config output.

Much better. thanks!

Dec 7 2018, 7:22 AM · Restricted Project
sylvestre.ledru abandoned D55174: Fix bug 8220 - llvm-config: Only keep flags starting by -I, -D & -std for --cflags, --cxxflags & --ldflags.
Dec 7 2018, 7:22 AM

Dec 6 2018

sylvestre.ledru added a comment to D55174: Fix bug 8220 - llvm-config: Only keep flags starting by -I, -D & -std for --cflags, --cxxflags & --ldflags.

@tstellar will you accept this patch if I remove -std?
thanks

Dec 6 2018, 1:45 PM
sylvestre.ledru added a comment to D55174: Fix bug 8220 - llvm-config: Only keep flags starting by -I, -D & -std for --cflags, --cxxflags & --ldflags.

And should I update the release notes?

Dec 6 2018, 1:45 PM

Dec 2 2018

sylvestre.ledru added a comment to D55174: Fix bug 8220 - llvm-config: Only keep flags starting by -I, -D & -std for --cflags, --cxxflags & --ldflags.

Other potential options:

Dec 2 2018, 6:45 AM
sylvestre.ledru created D55174: Fix bug 8220 - llvm-config: Only keep flags starting by -I, -D & -std for --cflags, --cxxflags & --ldflags.
Dec 2 2018, 6:41 AM

Nov 26 2018

sylvestre.ledru updated the summary of D53807: Create a diagnostic group for warn_call_to_pure_virtual_member_function_from_ctor_dtor, so it can be turned into an error using Werror.
Nov 26 2018, 6:21 AM

Nov 7 2018

sylvestre.ledru added a comment to D52034: [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to filter the files to instrument with gcov.

Can be done in a new commit but I think this should be mentioned in the clang release notes.

Nov 7 2018, 11:54 PM

Nov 1 2018

sylvestre.ledru resigned from D52173: Python bindings TypeError in reparse method .
Nov 1 2018, 4:51 AM · Restricted Project
sylvestre.ledru added a comment to D34329: [clang-diff] Initial implementation..

@johannes Someone asked for that in Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=907269

Nov 1 2018, 4:04 AM

Oct 29 2018

sylvestre.ledru added a comment to D53807: Create a diagnostic group for warn_call_to_pure_virtual_member_function_from_ctor_dtor, so it can be turned into an error using Werror.

Please add some tests

Oct 29 2018, 3:15 AM

Oct 23 2018

sylvestre.ledru updated the diff for D53520: Update the example of BS_Stroustrup to match what is done by clang-format.

Remove the desc update

Oct 23 2018, 12:10 PM

Oct 22 2018

sylvestre.ledru created D53520: Update the example of BS_Stroustrup to match what is done by clang-format.
Oct 22 2018, 12:22 PM

Oct 20 2018

sylvestre.ledru updated the diff for D53409: Add support for GNU Hurd in Path.inc and other places.

Remove the DwarfLinker.cpp declaration (useless)

Oct 20 2018, 2:31 PM