Page MenuHomePhabricator
Feed Advanced Search

Today

sylvestre.ledru committed rG5505ad34dbdd: Debian: Add two missing version code in sid (authored by sylvestre.ledru).
Debian: Add two missing version code in sid
Fri, Apr 19, 6:47 AM
sylvestre.ledru committed rG54a93a33ee64: Add support of the future Debian (Debian 11 - Bullseye) https://wiki.debian. (authored by sylvestre.ledru).
Add support of the future Debian (Debian 11 - Bullseye) https://wiki.debian.
Fri, Apr 19, 6:47 AM
sylvestre.ledru committed rG454014199ddf: Add support of the next Ubuntu (Ubuntu 19.10 - Eoan EANIMAL) (authored by sylvestre.ledru).
Add support of the next Ubuntu (Ubuntu 19.10 - Eoan EANIMAL)
Fri, Apr 19, 6:44 AM

Tue, Apr 16

sylvestre.ledru abandoned D60360: Dump the minimal version of cmake 3.5.0.

As you wish.
People who might encounter the same issue will (hopefully) find this review

Tue, Apr 16, 5:54 AM · Restricted Project
sylvestre.ledru added a comment to D60360: Dump the minimal version of cmake 3.5.0.

I didn't look at the details. It was failing with 3.4, upgrading to 3.5 address the issue.

Tue, Apr 16, 5:02 AM · Restricted Project

Mon, Apr 8

sylvestre.ledru added a comment to D60379: Make precompiled headers reproducible.

To be clear, this isn't about format stability and distributing but making sure that two same runs of clang produces the same output.

Mon, Apr 8, 12:51 PM · Restricted Project
sylvestre.ledru added a reviewer for D60360: Dump the minimal version of cmake 3.5.0: stephenkelly.
Mon, Apr 8, 7:58 AM · Restricted Project
sylvestre.ledru added a comment to D60379: Make precompiled headers reproducible.

I won't have time to write the test for that (and would not know where to start). I am just the messenger :)

Mon, Apr 8, 1:36 AM · Restricted Project
sylvestre.ledru updated the summary of D60379: Make precompiled headers reproducible.
Mon, Apr 8, 1:33 AM · Restricted Project

Sun, Apr 7

sylvestre.ledru created D60380: Also document -arch as -arch is mac specific.
Sun, Apr 7, 3:11 PM · Restricted Project
sylvestre.ledru created D60379: Make precompiled headers reproducible.
Sun, Apr 7, 3:09 PM · Restricted Project

Sat, Apr 6

sylvestre.ledru updated the summary of D60360: Dump the minimal version of cmake 3.5.0.
Sat, Apr 6, 12:12 AM · Restricted Project

Fri, Apr 5

sylvestre.ledru created D60360: Dump the minimal version of cmake 3.5.0.
Fri, Apr 5, 11:51 PM · Restricted Project

Wed, Apr 3

sylvestre.ledru added a comment to D60115: Adding 'CLion integration' to clang-format doc.

You are welcome, thanks for your contribution!

Wed, Apr 3, 2:06 AM · Restricted Project
sylvestre.ledru committed rGacab05feeeb5: Adding 'CLion integration' to clang-format doc (authored by sylvestre.ledru).
Adding 'CLion integration' to clang-format doc
Wed, Apr 3, 1:55 AM
sylvestre.ledru updated the summary of D60115: Adding 'CLion integration' to clang-format doc.
Wed, Apr 3, 1:54 AM · Restricted Project
sylvestre.ledru added a comment to D60115: Adding 'CLion integration' to clang-format doc.

Sure, i will do it for you

Wed, Apr 3, 1:54 AM · Restricted Project
sylvestre.ledru accepted D60115: Adding 'CLion integration' to clang-format doc.

works for me, thanks

Wed, Apr 3, 12:53 AM · Restricted Project

Tue, Apr 2

sylvestre.ledru added inline comments to D60115: Adding 'CLion integration' to clang-format doc.
Tue, Apr 2, 1:28 AM · Restricted Project

Sun, Mar 31

sylvestre.ledru committed rG7fb58e98f547: Spelling correction for docs for cppcoreguidelines-owning-memory (authored by sylvestre.ledru).
Spelling correction for docs for cppcoreguidelines-owning-memory
Sun, Mar 31, 2:54 PM
sylvestre.ledru added a comment to D60050: Spelling correction for docs for cppcoreguidelines-owning-memory.

If you have permissions on the repo, no need for a review for such change!

Sun, Mar 31, 2:33 PM · Restricted Project, Restricted Project, Restricted Project

Tue, Mar 26

sylvestre.ledru committed rG90dbbdbc95ca: update the release notes after the change of 'clang -dumpversion' (authored by sylvestre.ledru).
update the release notes after the change of 'clang -dumpversion'
Tue, Mar 26, 2:48 AM

Mon, Mar 25

sylvestre.ledru committed rGa199a9ba40c7: clang -dumpversion returns 4.2.1 for legacy reason, update it (authored by sylvestre.ledru).
clang -dumpversion returns 4.2.1 for legacy reason, update it
Mon, Mar 25, 11:07 AM
sylvestre.ledru updated the diff for D56803: clang -dumpversion returns 4.2.1 for legacy reason, update it.

Remove the empty directories

Mon, Mar 25, 11:03 AM · Restricted Project, Restricted Project
sylvestre.ledru updated the diff for D56803: clang -dumpversion returns 4.2.1 for legacy reason, update it.

Improve the test (thanks rnk)

Mon, Mar 25, 11:03 AM · Restricted Project, Restricted Project
sylvestre.ledru added a comment to D56803: clang -dumpversion returns 4.2.1 for legacy reason, update it.

@rnk btw, do you think it should be added to the clang release notes?

Mon, Mar 25, 11:03 AM · Restricted Project, Restricted Project
sylvestre.ledru added a comment to D59702: Unbreak the build of compiler-rt on Linux/mips64el.

Debian testing
you can see the full log here:
https://buildd.debian.org/status/fetch.php?pkg=llvm-toolchain-8&arch=mips64el&ver=1%3A8~%2Brc5-1&stamp=1552412165&raw=0

Mon, Mar 25, 7:54 AM · Restricted Project, Restricted Project
sylvestre.ledru added a comment to D59702: Unbreak the build of compiler-rt on Linux/mips64el.

I agree that 104 looks strange... but it worked.
As I said, I am no expert in mips64el. :/

Mon, Mar 25, 7:47 AM · Restricted Project, Restricted Project
sylvestre.ledru added a comment to D59702: Unbreak the build of compiler-rt on Linux/mips64el.

@atanasyan ok with you?

Mon, Mar 25, 6:47 AM · Restricted Project, Restricted Project

Sat, Mar 23

sylvestre.ledru committed rGd53135767de5: Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format. (authored by sylvestre.ledru).
Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format.
Sat, Mar 23, 10:59 AM
sylvestre.ledru added a reviewer for D56803: clang -dumpversion returns 4.2.1 for legacy reason, update it: rnk.
Sat, Mar 23, 10:59 AM · Restricted Project, Restricted Project
sylvestre.ledru updated the summary of D56803: clang -dumpversion returns 4.2.1 for legacy reason, update it.
Sat, Mar 23, 10:59 AM · Restricted Project, Restricted Project
sylvestre.ledru updated the diff for D58186: Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format.h`.

Try again

Sat, Mar 23, 10:55 AM · Restricted Project
sylvestre.ledru updated the diff for D58186: Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format.h`.

Remove unrelated changes

Sat, Mar 23, 10:52 AM · Restricted Project
sylvestre.ledru updated the diff for D58186: Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format.h`.

Svn version

Sat, Mar 23, 10:48 AM · Restricted Project
sylvestre.ledru updated the summary of D58186: Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format.h`.
Sat, Mar 23, 10:37 AM · Restricted Project

Fri, Mar 22

sylvestre.ledru added a comment to D59702: Unbreak the build of compiler-rt on Linux/mips64el.

Not sure what I am doing but it fixes the issue

Fri, Mar 22, 9:55 AM · Restricted Project, Restricted Project
sylvestre.ledru created D59702: Unbreak the build of compiler-rt on Linux/mips64el.
Fri, Mar 22, 9:55 AM · Restricted Project, Restricted Project

Mar 20 2019

sylvestre.ledru committed rGba92e9bb1187: [perf][DebugInfo] follow up for "add SectionedAddress to DebugInfo interfaces" (authored by sylvestre.ledru).
[perf][DebugInfo] follow up for "add SectionedAddress to DebugInfo interfaces"
Mar 20 2019, 3:02 AM
sylvestre.ledru added a comment to D59189: [perf][DebugInfo] follow up for "add SectionedAddress to DebugInfo interfaces".

Sorry for the latency, I didn't receive the notification :/

Mar 20 2019, 3:01 AM · Restricted Project

Mar 13 2019

sylvestre.ledru updated the diff for D59189: [perf][DebugInfo] follow up for "add SectionedAddress to DebugInfo interfaces".

Remove an unrelated change

Mar 13 2019, 10:52 AM · Restricted Project
sylvestre.ledru updated the diff for D59189: [perf][DebugInfo] follow up for "add SectionedAddress to DebugInfo interfaces".

Also set SectionIndex

Mar 13 2019, 10:51 AM · Restricted Project
Herald added a project to D56803: clang -dumpversion returns 4.2.1 for legacy reason, update it: Restricted Project.

@ddunbar ping?

Mar 13 2019, 10:45 AM · Restricted Project, Restricted Project

Mar 10 2019

sylvestre.ledru added a comment to D59189: [perf][DebugInfo] follow up for "add SectionedAddress to DebugInfo interfaces".

The build is broken with:

{anonymous}::PerfJITEventListener::notifyObjectLoaded(llvm::JITEventListener::ObjectKey, const llvm::object::ObjectFile&, const llvm::RuntimeDyld::LoadedObjectInfo&)':
/build/llvm-toolchain-snapshot-9~svn355786/lib/ExecutionEngine/PerfJITEvents/PerfJITEventListener.cpp:274:55: error: no matching function for call to 'llvm::DIContext::getLineInfoForAddressRange(uint64_t&, uint64_t&, llvm::DILineInfoSpecifier::FileLineInfoKind)'
         Addr, Size, FileLineInfoKind::AbsoluteFilePath);
                                                       ^
In file included from /build/llvm-toolchain-snapshot-9~svn355786/include/llvm/DebugInfo/DWARF/DWARFContext.h:18:0,
                 from /build/llvm-toolchain-snapshot-9~svn355786/lib/ExecutionEngine/PerfJITEvents/PerfJITEventListener.cpp:20:
/build/llvm-toolchain-snapshot-9~svn355786/include/llvm/DebugInfo/DIContext.h:209:27: note: candidate: virtual llvm::DILineInfoTable llvm::DIContext::getLineInfoForAddressRange(llvm::object::SectionedAddress, uint64_t, llvm::DILineInfoSpecifier)
   virtual DILineInfoTable getLineInfoForAddressRange(
                           ^~~~~~~~~~~~~~~~~~~~~~~~~~
/build/llvm-toolchain-snapshot-9~svn355786/include/llvm/DebugInfo/DIContext.h:209:27: note:   no known conversion for argument 1 from 'uint64_t {aka long unsigned int}' to 'llvm::object::SectionedAddress'
Mar 10 2019, 8:59 AM · Restricted Project
sylvestre.ledru created D59189: [perf][DebugInfo] follow up for "add SectionedAddress to DebugInfo interfaces".
Mar 10 2019, 8:58 AM · Restricted Project

Feb 21 2019

sylvestre.ledru accepted D57859: llvm-config: Include -stdlib= in --cxxflags.
Feb 21 2019, 6:20 AM · Restricted Project
sylvestre.ledru accepted D58186: Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format.h`.

Do you have permissions on the repo?

Feb 21 2019, 6:19 AM · Restricted Project

Jan 28 2019

sylvestre.ledru added a comment to D33440: clang-format: better handle statement macros.

@Typz
I think this should be part of the release notes for v8.
This is changing the output on some code base and this is a new feature.

Jan 28 2019, 2:55 AM
sylvestre.ledru added a comment to D56803: clang -dumpversion returns 4.2.1 for legacy reason, update it.

ping?

Jan 28 2019, 2:55 AM · Restricted Project, Restricted Project

Jan 26 2019

Herald updated subscribers of D53354: [WIP][NOT FOR COMMIT][PROTOTYPE] clang-scan-deps: dependency scanning tool rough prototype.
Jan 26 2019, 2:17 AM · Restricted Project

Jan 23 2019

sylvestre.ledru added a comment to D56803: clang -dumpversion returns 4.2.1 for legacy reason, update it.

@ddunbar is that ok with you? Thanks
See
https://bugs.llvm.org/show_bug.cgi?id=38836
https://bugs.launchpad.net/ubuntu/+source/llvm-defaults/+bug/1810860

Jan 23 2019, 2:03 PM · Restricted Project, Restricted Project

Jan 21 2019

sylvestre.ledru added a comment to D56946: [Documentation] Use HTTPS whenever possible in Clang.

Did you test all url?

Jan 21 2019, 5:49 AM · Restricted Project
sylvestre.ledru added a comment to D54472: Disable invalid isPodLike<> specialization.

@serge-sans-paille
This (probably) broke LLVM on Debian jessie. It fails with:

Jan 21 2019, 4:49 AM

Jan 17 2019

sylvestre.ledru resigned from D24863: Keep dependencies separated between static and dynamic libraries. Fix for bug #28127. .
Jan 17 2019, 5:42 AM · Restricted Project

Jan 16 2019

sylvestre.ledru abandoned D23976: Disable the common parts for the sanitizer tools on kfreebsd.

fixed I think

Jan 16 2019, 11:53 PM
sylvestre.ledru added a reviewer for D53014: Add CMAKE_BUILD_TYPE to the list of BOOTSTRAP_DEFAULT_PASSTHROUGH variables: beanz.
Jan 16 2019, 11:51 PM
sylvestre.ledru created D56803: clang -dumpversion returns 4.2.1 for legacy reason, update it.
Jan 16 2019, 1:05 PM · Restricted Project, Restricted Project

Jan 10 2019

sylvestre.ledru added a comment to D55434: ObjectFileBreakpad: Implement sections.

On i386

Jan 10 2019, 7:56 AM
sylvestre.ledru added a comment to D55434: ObjectFileBreakpad: Implement sections.

@labath This broke lldb on Debian stable:

Jan 10 2019, 7:36 AM

Dec 13 2018

sylvestre.ledru updated the summary of D55382: Make -Wstring-plus-int warns even if when the result is not out of bounds.
Dec 13 2018, 8:06 AM

Dec 10 2018

sylvestre.ledru added a comment to D54677: [hurd] Fix unconditional use of PATH_MAX.

@EricWF is it ok to land? Thanks

Dec 10 2018, 2:19 AM

Dec 7 2018

sylvestre.ledru accepted D55391: Don't add unnecessary compiler flags to llvm-config output.

Much better. thanks!

Dec 7 2018, 7:22 AM
sylvestre.ledru abandoned D55174: Fix bug 8220 - llvm-config: Only keep flags starting by -I, -D & -std for --cflags, --cxxflags & --ldflags.
Dec 7 2018, 7:22 AM

Dec 6 2018

sylvestre.ledru added a comment to D55174: Fix bug 8220 - llvm-config: Only keep flags starting by -I, -D & -std for --cflags, --cxxflags & --ldflags.

@tstellar will you accept this patch if I remove -std?
thanks

Dec 6 2018, 1:45 PM
sylvestre.ledru added a comment to D55174: Fix bug 8220 - llvm-config: Only keep flags starting by -I, -D & -std for --cflags, --cxxflags & --ldflags.

And should I update the release notes?

Dec 6 2018, 1:45 PM

Dec 2 2018

sylvestre.ledru added a comment to D55174: Fix bug 8220 - llvm-config: Only keep flags starting by -I, -D & -std for --cflags, --cxxflags & --ldflags.

Other potential options:

Dec 2 2018, 6:45 AM
sylvestre.ledru created D55174: Fix bug 8220 - llvm-config: Only keep flags starting by -I, -D & -std for --cflags, --cxxflags & --ldflags.
Dec 2 2018, 6:41 AM

Nov 26 2018

sylvestre.ledru updated the summary of D53807: Create a diagnostic group for warn_call_to_pure_virtual_member_function_from_ctor_dtor, so it can be turned into an error using Werror.
Nov 26 2018, 6:21 AM

Nov 7 2018

sylvestre.ledru added a comment to D52034: [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to filter the files to instrument with gcov.

Can be done in a new commit but I think this should be mentioned in the clang release notes.

Nov 7 2018, 11:54 PM

Nov 1 2018

sylvestre.ledru resigned from D52173: Python bindings TypeError in reparse method .
Nov 1 2018, 4:51 AM · Restricted Project
sylvestre.ledru added a comment to D34329: [clang-diff] Initial implementation..

@johannes Someone asked for that in Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=907269

Nov 1 2018, 4:04 AM

Oct 29 2018

sylvestre.ledru added a comment to D53807: Create a diagnostic group for warn_call_to_pure_virtual_member_function_from_ctor_dtor, so it can be turned into an error using Werror.

Please add some tests

Oct 29 2018, 3:15 AM

Oct 23 2018

sylvestre.ledru updated the diff for D53520: Update the example of BS_Stroustrup to match what is done by clang-format.

Remove the desc update

Oct 23 2018, 12:10 PM

Oct 22 2018

sylvestre.ledru created D53520: Update the example of BS_Stroustrup to match what is done by clang-format.
Oct 22 2018, 12:22 PM

Oct 20 2018

sylvestre.ledru updated the diff for D53409: Add support for GNU Hurd in Path.inc and other places.

Remove the DwarfLinker.cpp declaration (useless)

Oct 20 2018, 2:31 PM
sylvestre.ledru added a comment to D53409: Add support for GNU Hurd in Path.inc and other places.

Debian still proposes a GNU Hurd port of this distro. As LLVM is now key, the porters have been trying to get llvm ported.
This fixes a bunch of issues and make llvm work correctly on gnu hurd.

Oct 20 2018, 2:05 PM

Oct 18 2018

sylvestre.ledru created D53410: Add missing PATH_MAX for GNU Hurd support.
Oct 18 2018, 1:28 PM
sylvestre.ledru retitled D53409: Add support for GNU Hurd in Path.inc and other places from Add support for GNU Hurd in Path.inc to Add support for GNU Hurd in Path.inc and other places.
Oct 18 2018, 1:24 PM
sylvestre.ledru updated the diff for D53409: Add support for GNU Hurd in Path.inc and other places.

add path_max def

Oct 18 2018, 1:23 PM
sylvestre.ledru created D53409: Add support for GNU Hurd in Path.inc and other places.
Oct 18 2018, 1:18 PM

Oct 9 2018

sylvestre.ledru added a comment to D52173: Python bindings TypeError in reparse method .

I am sorry but I am not the right reviewer for that. Sorry!

Oct 9 2018, 11:50 PM · Restricted Project
sylvestre.ledru updated the diff for D53018: Document the behavior of option passing when using -DCLANG_ENABLE_BOOTSTRAP=On Also document -DCLANG_BOOTSTRAP_PASSTHROUGH.

Fix a typo

Oct 9 2018, 1:38 AM
sylvestre.ledru created D53018: Document the behavior of option passing when using -DCLANG_ENABLE_BOOTSTRAP=On Also document -DCLANG_BOOTSTRAP_PASSTHROUGH.
Oct 9 2018, 1:32 AM
sylvestre.ledru created D53014: Add CMAKE_BUILD_TYPE to the list of BOOTSTRAP_DEFAULT_PASSTHROUGH variables.
Oct 9 2018, 1:21 AM

Sep 29 2018

sylvestre.ledru added a comment to D49017: Replace "nullptr-terminated" C-arrays of OptionValueEnumeration with safer llvm::ArrayRef.

This broke the apt.llvm.org CI on Debian Jessie and Ubuntu trusty (at least).
I reported https://bugs.llvm.org/show_bug.cgi?id=39131

Sep 29 2018, 10:51 AM

Sep 17 2018

sylvestre.ledru abandoned D30111: [clang-format] Add a test to check at once all the Mozilla coding style.
Sep 17 2018, 12:06 AM

Sep 16 2018

sylvestre.ledru added a comment to D52151: Also manages clang-X as tool for scan-build.

@kristina sorry, I missed your comment. I just followed what we are doing with gcc. Do you want me to update it?

Sep 16 2018, 12:56 PM
sylvestre.ledru updated the diff for D52153: scan-build: Add support of the option --exclude like in scan-build-py.

Fix the indentation

Sep 16 2018, 12:51 PM
sylvestre.ledru created D52153: scan-build: Add support of the option --exclude like in scan-build-py.
Sep 16 2018, 12:50 PM
sylvestre.ledru updated the summary of D52153: scan-build: Add support of the option --exclude like in scan-build-py.
Sep 16 2018, 12:50 PM
sylvestre.ledru created D52151: Also manages clang-X as tool for scan-build.
Sep 16 2018, 11:47 AM

Sep 14 2018

sylvestre.ledru added a comment to D31338: Move ParsedAttrInfos into a registry and point to one in AttributeList.

@john.brawn Are you still working on that? We would need this change at Mozilla to improve the way we use attributes.
Thanks

Sep 14 2018, 11:49 PM

Sep 11 2018

sylvestre.ledru added a comment to D51108: [PowerPC] Fix wrong ABI for i1 stack arguments on PPC32.

You should ping the reviewer (if she/he is available on IRC).
Once you have the sign off, you ping the reviewer (or someone else like me) to land your patch in the vcs.

Sep 11 2018, 2:53 AM

Sep 8 2018

sylvestre.ledru added a comment to D43630: [Driver] Fix search paths on x32.

@jrtc27 are you going to take care of the tests? Thanks

Sep 8 2018, 7:33 AM

Sep 6 2018

sylvestre.ledru abandoned D51285: Fix a build issue on Debian Jessie.
Sep 6 2018, 1:26 AM

Aug 27 2018

sylvestre.ledru retitled D51285: Fix a build issue on Debian Jessie from Fix a build issue on Debian Jessie. Was failing with openmp/libomptarget/src/omptarget.cpp:37:21: error: 'va_start' was not declared in this scope to Fix a build issue on Debian Jessie.
Aug 27 2018, 12:39 AM
sylvestre.ledru created D51285: Fix a build issue on Debian Jessie.
Aug 27 2018, 12:32 AM

Aug 26 2018

sylvestre.ledru added a comment to D34329: [clang-diff] Initial implementation..

@arphaman @johannes Is that normal that clang-diff isn't installed by cmake? (like clang-format?)

Aug 26 2018, 7:09 AM

Aug 23 2018

sylvestre.ledru added a comment to D44910: [docs] Add Markdown support to Sphinx.

Unfortunately, recommonmark isn't available on some older ubuntu (no backport available) & debian (a backport is available).
This will make the life of some of us harder!

Aug 23 2018, 1:45 PM

Jun 27 2018

sylvestre.ledru added a comment to D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call.

If you are interested, I executed this checker on Firefox code. Results can be found here
http://sylvestre.ledru.info/reports/fx-scan-build/

Jun 27 2018, 12:04 PM