Page MenuHomePhabricator
Feed Advanced Search

Aug 21 2016

CrisCristescu added a reviewer for D21388: Module map redundant header file exclusions: v.g.vassilev.
Aug 21 2016, 11:18 PM · Restricted Project

Aug 10 2016

CrisCristescu updated the diff for D22804: Fix for Bug 28423 - error: too many arguments to function call, expected single argument '__pq', have 2 arguments void swap(priority_queue __pq) .

Updated the fix as suggested.

Aug 10 2016, 8:40 AM

Jul 26 2016

CrisCristescu updated the diff for D17820: Clang Code Completion Filtering .

Wrong indentation update.

Jul 26 2016, 8:38 AM
CrisCristescu updated the diff for D17820: Clang Code Completion Filtering .

Some more cosmetics.

Jul 26 2016, 6:52 AM
CrisCristescu retitled D22804: Fix for Bug 28423 - error: too many arguments to function call, expected single argument '__pq', have 2 arguments void swap(priority_queue __pq) from to Fix for Bug 28423 - error: too many arguments to function call, expected single argument '__pq', have 2 arguments void swap(priority_queue __pq) .
Jul 26 2016, 5:36 AM

Jul 25 2016

CrisCristescu updated the diff for D17820: Clang Code Completion Filtering .

PP CodeCompletionII initialisation.

Jul 25 2016, 12:36 PM
CrisCristescu updated the diff for D17820: Clang Code Completion Filtering .

Addressing some sugesstions.

Jul 25 2016, 12:22 PM

Jul 21 2016

CrisCristescu updated the diff for D21800: Fix for Bug 28332.

Last comments addressed.

Jul 21 2016, 2:25 AM

Jul 20 2016

CrisCristescu updated the diff for D21800: Fix for Bug 28332.

More cosmetics.

Jul 20 2016, 5:28 AM
CrisCristescu updated the diff for D21800: Fix for Bug 28332.

Some cosmetics changes.

Jul 20 2016, 4:55 AM
CrisCristescu updated the diff for D21800: Fix for Bug 28332.

This patch addresses the comments from the previous one:

Jul 20 2016, 3:42 AM

Jul 8 2016

CrisCristescu updated the diff for D21800: Fix for Bug 28332.

This is a new suggestion as a result from the irc discussion.

Jul 8 2016, 7:19 AM

Jul 7 2016

CrisCristescu added a comment to D21985: Missing includes.

Yes, sorry, I usually give the context in the Bugzilla entries, but since there is no bug attached I overlooked it.

Jul 7 2016, 8:41 AM · Restricted Project

Jul 5 2016

CrisCristescu retitled D21985: Missing includes from to Missing includes.
Jul 5 2016, 2:54 AM · Restricted Project

Jul 2 2016

CrisCristescu added a comment to D21800: Fix for Bug 28332.

Ok, I was trying to find the correct place to emit un update record, but I am not sure I have found it. I was looking at the Declare/Define ImplicitDestructor but there is an update record emitted there if the Function Decl comes from an ASTFile, but the Declare/Define does not seem to come from the AST file when it is created in our example.
On the other hand, if I replace the ~SmallVectorImpl() with the default constructor SmallVectorImpl() then the assertion is not reproducible. Thus, I tried to see what is different when Declare/DefineImplicitDefaultConstructor, but I could not see any difference in the code path in comparison to the Destructor.
So I believe SmallVectorImpl() is not implicitly defined and the update record should be emitted somewhere else. Any hint to where should I look?

Jul 2 2016, 11:44 AM

Jun 28 2016

CrisCristescu retitled D21800: Fix for Bug 28332 from to Fix for Bug 28332.
Jun 28 2016, 9:27 AM

Jun 27 2016

CrisCristescu updated the diff for D21754: Missing includes.

Correct diff.

Jun 27 2016, 2:20 PM · Restricted Project
CrisCristescu retitled D21754: Missing includes from to Missing includes.
Jun 27 2016, 9:45 AM · Restricted Project

Jun 15 2016

CrisCristescu updated subscribers of D21388: Module map redundant header file exclusions.
Jun 15 2016, 1:35 PM · Restricted Project
CrisCristescu updated subscribers of D21390: redefinition of '__true_type' struct __true_type {}; - Bug 27991.
Jun 15 2016, 1:34 PM · Restricted Project
CrisCristescu retitled D21390: redefinition of '__true_type' struct __true_type {}; - Bug 27991 from to redefinition of '__true_type' struct __true_type {}; - Bug 27991.
Jun 15 2016, 10:17 AM · Restricted Project
CrisCristescu retitled D21388: Module map redundant header file exclusions from to Module map redundant header file exclusions.
Jun 15 2016, 9:29 AM · Restricted Project

May 13 2016

CrisCristescu retitled D20244: Sema::MergeFunctionDecl improperly checking for an out-of-line def of defaulted function from to Sema::MergeFunctionDecl improperly checking for an out-of-line def of defaulted function.
May 13 2016, 9:19 AM · Restricted Project

May 4 2016

CrisCristescu updated the diff for D17820: Clang Code Completion Filtering .

Addresses the previous comments and adds testing for filtering.
All the tests already in CodeCompletion are testing both the backward compatibility and the new functionality itself.

May 4 2016, 2:57 AM

Apr 21 2016

CrisCristescu updated subscribers of D19315: Fix for Bug 27401. Always mark the canonical Decl as used..
Apr 21 2016, 7:46 AM · Restricted Project
CrisCristescu updated the diff for D19315: Fix for Bug 27401. Always mark the canonical Decl as used..
Apr 21 2016, 7:12 AM · Restricted Project

Apr 20 2016

CrisCristescu updated the diff for D19315: Fix for Bug 27401. Always mark the canonical Decl as used..

Refinements

Apr 20 2016, 5:23 AM · Restricted Project
CrisCristescu updated D19315: Fix for Bug 27401. Always mark the canonical Decl as used..
Apr 20 2016, 3:20 AM · Restricted Project
CrisCristescu updated D19315: Fix for Bug 27401. Always mark the canonical Decl as used..
Apr 20 2016, 3:20 AM · Restricted Project
CrisCristescu retitled D19315: Fix for Bug 27401. Always mark the canonical Decl as used. from to Fix for Bug 27401. Always mark the canonical Decl as used..
Apr 20 2016, 3:16 AM · Restricted Project

Mar 23 2016

CrisCristescu added a comment to D17820: Clang Code Completion Filtering .

For the filtering itself the motivation for not doing it on the client side is the following in our use case:

  • we do not re-filter on every key stroke, we only filter when the <TAB> key is pressed i.e there is one completion point;
  • we have a PCH which will help with the generation time;
  • performance is acceptable with the patch included: less than 1s even when the file contains several "heavier" includes such as <string> or <vector>;
  • without the patch if the <TAB> key is pressed in the middle of the identifier name (i.e setDouble) an error is thrown:
fiter-member-access.cpp:19:17: error: no member named 'set' in 'MyClass'
        objectMyClass->set
        ~~~~~~~~~~~~~  ^
  • and most importantly, we plan to propose another set of patches which would do lookup's only on subsets of the DeclContext of the identifier i.e incomplete lookup-s in order to reduce the amount of PCH deserializations.
Mar 23 2016, 6:06 AM
CrisCristescu updated the diff for D17820: Clang Code Completion Filtering .

This is a new way of filtering which is could be less intrusive and has less changes.

Mar 23 2016, 5:58 AM

Mar 3 2016

CrisCristescu changed the visibility for D17820: Clang Code Completion Filtering .
Mar 3 2016, 4:21 AM

Mar 2 2016

CrisCristescu retitled D17820: Clang Code Completion Filtering from to Clang Code Completion Filtering .
Mar 2 2016, 10:11 AM