Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Starting to come together nicely, but I think now would be a good time to write some tests. I am particularly interested in more complex situations like inheritance hierarchies.

Jun 28 2023, 8:39 AM · Restricted Project, Restricted Project

May 30 2023

dang committed rG06ff9770477d: [clang][ExtractAPI] Refactor serializer to the CRTP (authored by evelez7).

[clang][ExtractAPI] Refactor serializer to the CRTP

May 30 2023, 11:02 AM · Restricted Project, Restricted Project

dang closed D151477: [clang][ExtractAPI] Refactor serializer to the CRTP.

May 30 2023, 11:02 AM · Restricted Project, Restricted Project

dang accepted D151477: [clang][ExtractAPI] Refactor serializer to the CRTP.

May 30 2023, 7:29 AM · Restricted Project, Restricted Project

dang accepted D151048: [clang][ExtractAPI] Modify declaration fragment methods to add a new fragment at an arbitrary offset..

May 30 2023, 7:27 AM · Restricted Project, Restricted Project

May 26 2023

dang added a comment to D151477: [clang][ExtractAPI] Refactor serializer to the CRTP.

LGTM with minor changes

May 26 2023, 8:12 AM · Restricted Project, Restricted Project

May 24 2023

dang requested changes to D151293: [clang][ExtractAPI] Refactor serializer to the CRTP.

Great start but there are still some rough edges to polish!

May 24 2023, 2:28 AM · Restricted Project, Restricted Project

May 23 2023

dang requested changes to D151048: [clang][ExtractAPI] Modify declaration fragment methods to add a new fragment at an arbitrary offset..

May 23 2023, 7:50 AM · Restricted Project, Restricted Project

May 4 2023

dang accepted D149737: [clang][ExtractAPI] Add semicolon to function declaration fragments.

LGTM

May 4 2023, 6:44 AM · Restricted Project, Restricted Project

Apr 13 2023

dang committed rG3ac550984e83: [clang][ExtractAPI] Complete declaration fragments for TagDecl types defined in… (authored by Ruturaj4).

[clang][ExtractAPI] Complete declaration fragments for TagDecl types defined in…

Apr 13 2023, 9:56 AM · Restricted Project, Restricted Project

dang closed D146385: [clang][ExtractAPI] Complete declaration fragments for TagDecl types defined in a typedef.

Apr 13 2023, 9:56 AM · Restricted Project, Restricted Project

Apr 11 2023

dang added inline comments to D147901: [NFC][CLANG][API] Fix coverity remarks about large copies by values.

Apr 11 2023, 4:46 AM · Restricted Project, Restricted Project

Apr 4 2023

dang accepted D146759: [ExtractAPI] Remove extra attributes in property declaration fragments.

LGTM

Apr 4 2023, 9:51 AM · Restricted Project, Restricted Project

dang added a comment to D146759: [ExtractAPI] Remove extra attributes in property declaration fragments.

Do we still have a test that ensures that actually writing the property attributes manually results in them being added to the declaration fragments?

Apr 4 2023, 7:55 AM · Restricted Project, Restricted Project

Mar 30 2023

dang committed rG142c3d9d1414: [clang][ExtractAPI] Reland ExtractAPI for libclang improvements (authored by dang).

[clang][ExtractAPI] Reland ExtractAPI for libclang improvements

Mar 30 2023, 10:14 AM · Restricted Project, Restricted Project

dang closed D147234: [clang][ExtractAPI] Reland ExtractAPI for libclang improvements.

Mar 30 2023, 10:14 AM · Restricted Project, Restricted Project

dang accepted D146866: [clang][ExtractAPI] Remove extra pointer indirection from declaration fragments for Obj-C lightweight generics on id.

Mar 30 2023, 7:17 AM · Restricted Project, Restricted Project

dang added inline comments to D147234: [clang][ExtractAPI] Reland ExtractAPI for libclang improvements.

Mar 30 2023, 7:07 AM · Restricted Project, Restricted Project

dang requested review of D147234: [clang][ExtractAPI] Reland ExtractAPI for libclang improvements.

Mar 30 2023, 7:06 AM · Restricted Project, Restricted Project

dang accepted D146385: [clang][ExtractAPI] Complete declaration fragments for TagDecl types defined in a typedef.

Mar 30 2023, 5:59 AM · Restricted Project, Restricted Project

Mar 29 2023

dang committed rG1cfe1e732ad8: [clang][ExtractAPI] Add queried symbol to parent contexts in libclang (authored by dang).

[clang][ExtractAPI] Add queried symbol to parent contexts in libclang

Mar 29 2023, 8:33 AM · Restricted Project, Restricted Project

dang closed D147138: [clang][ExtractAPI] Add queried symbol to parent contexts in libclang.

Mar 29 2023, 8:32 AM · Restricted Project, Restricted Project

dang added inline comments to D146866: [clang][ExtractAPI] Remove extra pointer indirection from declaration fragments for Obj-C lightweight generics on id.

Mar 29 2023, 8:24 AM · Restricted Project, Restricted Project

dang added a reviewer for D147138: [clang][ExtractAPI] Add queried symbol to parent contexts in libclang: QuietMisdreavus.

Mar 29 2023, 8:16 AM · Restricted Project, Restricted Project

dang added a comment to D146385: [clang][ExtractAPI] Complete declaration fragments for TagDecl types defined in a typedef.

You will need to rebase this as I made some changes recently to how ExtractAPIVisitor is structured. We can either set up a time to talk about it and do it together or I can handle doing this work once we are happy with this.

Mar 29 2023, 8:15 AM · Restricted Project, Restricted Project

dang requested review of D147138: [clang][ExtractAPI] Add queried symbol to parent contexts in libclang.

Mar 29 2023, 4:06 AM · Restricted Project, Restricted Project

dang added a reverting change for rG158a431227a8: Revert ExtractAPI from https://reviews.llvm.org/D146656: rG791164751241: Revert "Revert ExtractAPI from https://reviews.llvm.org/D146656".

Mar 29 2023, 2:52 AM · Restricted Project, Restricted Project

dang committed rG791164751241: Revert "Revert ExtractAPI from https://reviews.llvm.org/D146656" (authored by dang).

Revert "Revert ExtractAPI from https://reviews.llvm.org/D146656"

Mar 29 2023, 2:52 AM · Restricted Project, Restricted Project

Mar 27 2023

dang committed rG158a431227a8: Revert ExtractAPI from https://reviews.llvm.org/D146656 (authored by dang).

Revert ExtractAPI from https://reviews.llvm.org/D146656

Mar 27 2023, 2:13 PM · Restricted Project, Restricted Project

dang committed rG21750a1ae8c8: [clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible (authored by dang).

[clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible

Mar 27 2023, 9:24 AM · Restricted Project, Restricted Project

dang committed rGd0dd151eed4b: Address code review feedback (authored by dang).

Address code review feedback

Mar 27 2023, 9:24 AM · Restricted Project, Restricted Project

dang committed rGea35740e7e18: [clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible (authored by dang).

[clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible

Mar 27 2023, 9:24 AM · Restricted Project, Restricted Project

dang closed D146656: [clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible.

Mar 27 2023, 9:24 AM · Restricted Project, Restricted Project

Mar 24 2023

dang added a comment to D146656: [clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible.

In D146656#4220022, @zixuw wrote:

LGTM for the ExtractAPIVisitor part.
Remaining:

update test with @LINE

the libclang side

Mar 24 2023, 10:30 AM · Restricted Project, Restricted Project

dang added inline comments to D146385: [clang][ExtractAPI] Complete declaration fragments for TagDecl types defined in a typedef.

Mar 24 2023, 3:38 AM · Restricted Project, Restricted Project

Mar 23 2023

dang accepted D146671: [clang][ExtractAPI]Fix Declaration fragments for instancetype in the type position degrade to id.

Yup looks fine to me!

Mar 23 2023, 8:13 AM · Restricted Project, Restricted Project

dang accepted D146671: [clang][ExtractAPI]Fix Declaration fragments for instancetype in the type position degrade to id.

LGTM, but you should also check in the test that id still renders as expected.

Mar 23 2023, 4:43 AM · Restricted Project, Restricted Project

dang added a reviewer for D146671: [clang][ExtractAPI]Fix Declaration fragments for instancetype in the type position degrade to id: zixuw.

Mar 23 2023, 4:24 AM · Restricted Project, Restricted Project

Mar 22 2023

dang updated the diff for D146656: [clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible.

Adding back missing diffs.

Mar 22 2023, 4:25 PM · Restricted Project, Restricted Project

dang updated the diff for D146656: [clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible.

Addressing code review feedback

Mar 22 2023, 4:24 PM · Restricted Project, Restricted Project

dang added inline comments to D146656: [clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible.

Mar 22 2023, 3:47 PM · Restricted Project, Restricted Project

dang added a reviewer for D146656: [clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible: arphaman.

Mar 22 2023, 12:18 PM · Restricted Project, Restricted Project

dang requested review of D146656: [clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible.

Mar 22 2023, 12:17 PM · Restricted Project, Restricted Project

Mar 20 2023

dang committed rGafce10c5b60f: [clang][ExtractAPI] Add semicolons for enum, typedef, struct declaration… (authored by chaitanyav).

[clang][ExtractAPI] Add semicolons for enum, typedef, struct declaration…

Mar 20 2023, 8:43 AM · Restricted Project, Restricted Project

dang closed D146354: [clang][ExtractAPI] Add semicolons for enum, typedef, struct declaration fragments.

Mar 20 2023, 8:43 AM · Restricted Project, Restricted Project

dang accepted D146354: [clang][ExtractAPI] Add semicolons for enum, typedef, struct declaration fragments.

LGTM! I think it's fine to go ahead and land this (premerge check are not a requirement). Have you contributed to LLVM before? If not I will need to commit it on your behalf. Once that is done you should follow the instructions at https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access to gain commit access if you wish to continue contributing to the project and LLVM in general.

Mar 20 2023, 7:09 AM · Restricted Project, Restricted Project

dang requested changes to D146385: [clang][ExtractAPI] Complete declaration fragments for TagDecl types defined in a typedef.

I think there might be some code missing here. Also can you add a test?

Mar 20 2023, 7:05 AM · Restricted Project, Restricted Project

Mar 13 2023

dang accepted D145869: [clang][ExtractAPI] Add multiple file support to --extract-api-ignores.

LGTM once you fix the test

Mar 13 2023, 4:36 AM · Restricted Project, Restricted Project

dang added inline comments to D145869: [clang][ExtractAPI] Add multiple file support to --extract-api-ignores.

Mar 13 2023, 4:35 AM · Restricted Project, Restricted Project

dang added inline comments to D145869: [clang][ExtractAPI] Add multiple file support to --extract-api-ignores.

Mar 13 2023, 3:26 AM · Restricted Project, Restricted Project

Mar 2 2023

dang committed rG65f7a84cf38b: [clang][ExtractAPI] Handle platform specific unavailability correctly (authored by Arsenic).

[clang][ExtractAPI] Handle platform specific unavailability correctly

Mar 2 2023, 7:51 AM · Restricted Project, Restricted Project

dang closed D144940: [clang][ExtractAPI] Handle platform specific unavailability correctly.

Mar 2 2023, 7:50 AM · Restricted Project, Restricted Project

Feb 28 2023

dang accepted D144940: [clang][ExtractAPI] Handle platform specific unavailability correctly.

LGTM, It's worth noting that if the user specifies that an API is unavailable in a later redeclaration, this will be ignored. For example if I add a line to the test void e(void) __attribute__((availability(macos, unavailable))); it will be ignored. Up to you whether you want to fix it now or at a later date.

Feb 28 2023, 8:34 AM · Restricted Project, Restricted Project

dang added a comment to D144940: [clang][ExtractAPI] Handle platform specific unavailability correctly.

In D144940#4158143, @Arsenic wrote:

In D144940#4158020, @dang wrote:

Nice! glad to see this getting fixed. You should add a lit test to ensure we don't regress this behavior in the future.

I see a test checking for availability attribute already exists ( clang/test/ExtractAPI/availability.c ) would it be better if I update it with another function having a platform specific unavailability attribute or should I create a new test file ?