Page MenuHomePhabricator
Feed Advanced Search

Yesterday

mib accepted D131605: [lldb][tests] Test queue-specific breakpoints.

LGTM with @teemperor feedback !

Fri, Aug 12, 2:01 PM · Restricted Project, Restricted Project
mib added inline comments to D131605: [lldb][tests] Test queue-specific breakpoints.
Fri, Aug 12, 12:10 PM · Restricted Project, Restricted Project

Thu, Aug 11

mib committed rG6c58f12d0761: [lldb/Symbol] Fix null-deref in TypeList::Dump (authored by mib).
[lldb/Symbol] Fix null-deref in TypeList::Dump
Thu, Aug 11, 10:29 PM · Restricted Project
mib committed rGedc77353daa7: [lldb/crashlog] Improve exception reporting for interactive mode (authored by mib).
[lldb/crashlog] Improve exception reporting for interactive mode
Thu, Aug 11, 10:29 PM · Restricted Project
mib committed rG603f44acc6ec: [lldb/test] Fix interactive crashlog test failure (NFC) (authored by mib).
[lldb/test] Fix interactive crashlog test failure (NFC)
Thu, Aug 11, 10:29 PM · Restricted Project
mib committed rG300e393092e3: [lldb/crashlog] Adapt raw text crashlog exception to json format (authored by mib).
[lldb/crashlog] Adapt raw text crashlog exception to json format
Thu, Aug 11, 10:29 PM · Restricted Project
mib closed D131086: [lldb/crashlog] Improve exception reporting for interactive mode.
Thu, Aug 11, 10:29 PM · Restricted Project, Restricted Project
mib closed D131719: [lldb/crashlog] Adapt raw text crashlog exception to json format.
Thu, Aug 11, 10:29 PM · Restricted Project, Restricted Project
mib updated the diff for D131086: [lldb/crashlog] Improve exception reporting for interactive mode.
Thu, Aug 11, 10:28 PM · Restricted Project, Restricted Project
mib updated the diff for D131719: [lldb/crashlog] Adapt raw text crashlog exception to json format.

Fixing typo

Thu, Aug 11, 5:25 PM · Restricted Project, Restricted Project
mib updated the diff for D131086: [lldb/crashlog] Improve exception reporting for interactive mode.

Reflect changes from D131719

Thu, Aug 11, 5:23 PM · Restricted Project, Restricted Project
mib resigned from D83180: Set generic error in SBError SetErrorToGenericError.
Thu, Aug 11, 4:47 PM · Restricted Project, Restricted Project
mib updated the diff for D131719: [lldb/crashlog] Adapt raw text crashlog exception to json format.
  • Make CrashLog.exception a dictionary at initialization
  • Update exception_type regex to use a non-capture group
Thu, Aug 11, 4:32 PM · Restricted Project, Restricted Project
mib updated the diff for D131719: [lldb/crashlog] Adapt raw text crashlog exception to json format.

Address @kastiglione comments

Thu, Aug 11, 3:50 PM · Restricted Project, Restricted Project
mib added inline comments to D131719: [lldb/crashlog] Adapt raw text crashlog exception to json format.
Thu, Aug 11, 3:30 PM · Restricted Project, Restricted Project
mib added inline comments to D131719: [lldb/crashlog] Adapt raw text crashlog exception to json format.
Thu, Aug 11, 3:22 PM · Restricted Project, Restricted Project
mib updated the diff for D131719: [lldb/crashlog] Adapt raw text crashlog exception to json format.

Change regex to support actual hex addresses

Thu, Aug 11, 3:06 PM · Restricted Project, Restricted Project
mib added inline comments to D131605: [lldb][tests] Test queue-specific breakpoints.
Thu, Aug 11, 2:47 PM · Restricted Project, Restricted Project
mib requested review of D131719: [lldb/crashlog] Adapt raw text crashlog exception to json format.
Thu, Aug 11, 1:47 PM · Restricted Project, Restricted Project
mib awarded D131305: [lldb] Tidy some regex in crashlog.py (NFC) a Yellow Medal token.
Thu, Aug 11, 11:15 AM · Restricted Project, Restricted Project

Wed, Aug 10

mib committed rG3f3db135251c: [lldb/crashlog] Add `-V|--version` option (authored by mib).
[lldb/crashlog] Add `-V|--version` option
Wed, Aug 10, 4:19 PM · Restricted Project
mib closed D131542: [lldb/crashlog] Add `-V|--version` option.
Wed, Aug 10, 4:19 PM · Restricted Project, Restricted Project

Tue, Aug 9

mib updated the summary of D131542: [lldb/crashlog] Add `-V|--version` option.
Tue, Aug 9, 11:14 PM · Restricted Project, Restricted Project
mib requested review of D131542: [lldb/crashlog] Add `-V|--version` option.
Tue, Aug 9, 11:14 PM · Restricted Project, Restricted Project
mib added a comment to D131147: [compiler-rt][BF16] Do not compile truncdfbf2.c and truncsfbf2.c if `__bf16` is not supported.

Thanks @mib for the information. It's odd. The reland patch should have solved the problem. I'll keep watching on the following build results. Thanks!

Tue, Aug 9, 9:52 PM · Restricted Project, Restricted Project
mib added a reverting change for rGab4e5ed441d4: Reland "[compiler-rt][BF16] Provide __truncsfbf2 only when __bf16 is available": rG5990cf380644: Revert "Reland "[compiler-rt][BF16] Provide __truncsfbf2 only when __bf16 is….
Tue, Aug 9, 9:46 PM · Restricted Project, Restricted Project
mib committed rG5990cf380644: Revert "Reland "[compiler-rt][BF16] Provide __truncsfbf2 only when __bf16 is… (authored by mib).
Revert "Reland "[compiler-rt][BF16] Provide __truncsfbf2 only when __bf16 is…
Tue, Aug 9, 9:46 PM · Restricted Project, Restricted Project
mib added a reverting change for D131147: [compiler-rt][BF16] Do not compile truncdfbf2.c and truncsfbf2.c if `__bf16` is not supported: rG5990cf380644: Revert "Reland "[compiler-rt][BF16] Provide __truncsfbf2 only when __bf16 is….
Tue, Aug 9, 9:45 PM · Restricted Project, Restricted Project
mib added a comment to D131147: [compiler-rt][BF16] Do not compile truncdfbf2.c and truncsfbf2.c if `__bf16` is not supported.

@pengfei This patch broke the macOS bot : https://green.lab.llvm.org/green/job/lldb-cmake/45984/

Tue, Aug 9, 9:14 PM · Restricted Project, Restricted Project
mib committed rG66f8819c5087: [lldb/crashlog] Refactor the CrashLogParser logic (authored by mib).
[lldb/crashlog] Refactor the CrashLogParser logic
Tue, Aug 9, 9:02 PM · Restricted Project
mib committed rG41c1a5f9bdc4: [lldb/crashlog] Add `-s|--skip-status` option to interactive mode (authored by mib).
[lldb/crashlog] Add `-s|--skip-status` option to interactive mode
Tue, Aug 9, 9:02 PM · Restricted Project
mib committed rG355be8cf8016: [lldb/crashlog] Skip null image dsym fetching on interactive mode (authored by mib).
[lldb/crashlog] Skip null image dsym fetching on interactive mode
Tue, Aug 9, 9:02 PM · Restricted Project
mib committed rG13aa780f37e1: [lldb/crashlog] Remove 'process_path' parsing logic (authored by mib).
[lldb/crashlog] Remove 'process_path' parsing logic
Tue, Aug 9, 9:02 PM · Restricted Project
mib committed rG81cbc294571f: [lldb/crashlog] Update frame regex matcher (authored by mib).
[lldb/crashlog] Update frame regex matcher
Tue, Aug 9, 9:02 PM · Restricted Project
mib closed D131085: [lldb/crashlog] Refactor the CrashLogParser logic.
Tue, Aug 9, 9:02 PM · Restricted Project, Restricted Project
mib committed rGa07a75180c01: [lldb/crashlog] Surface error using SBCommandReturnObject argument (authored by mib).
[lldb/crashlog] Surface error using SBCommandReturnObject argument
Tue, Aug 9, 9:02 PM · Restricted Project
mib closed D131038: [lldb/crashlog] Skip null image dsym fetching on interactive mode.
Tue, Aug 9, 9:02 PM · Restricted Project, Restricted Project
mib committed rGa633c5e11b44: [lldb/crashlog] Add '-t|--target' option to interactive mode (authored by mib).
[lldb/crashlog] Add '-t|--target' option to interactive mode
Tue, Aug 9, 9:02 PM · Restricted Project
mib closed D131036: [lldb/crashlog] Add `-s|--skip-status` option to interactive mode.
Tue, Aug 9, 9:02 PM · Restricted Project, Restricted Project
mib closed D131033: [lldb/crashlog] Remove 'process_path' parsing logic.
Tue, Aug 9, 9:02 PM · Restricted Project, Restricted Project
mib closed D131032: [lldb/crashlog] Update frame regex matcher.
Tue, Aug 9, 9:02 PM · Restricted Project, Restricted Project
mib closed D129614: [lldb/crashlog] Surface error using SBCommandReturnObject argument.
Tue, Aug 9, 9:02 PM · Restricted Project, Restricted Project
mib closed D129611: [lldb/crashlog] Add '-t|--target' option to interactive mode.
Tue, Aug 9, 9:02 PM · Restricted Project, Restricted Project
mib added a comment to D131085: [lldb/crashlog] Refactor the CrashLogParser logic.

thanks for having patience with us reviewers, lgtm with one comment about python versions

Tue, Aug 9, 4:38 PM · Restricted Project, Restricted Project
mib updated the diff for D131085: [lldb/crashlog] Refactor the CrashLogParser logic.

Remove walrus (:=) operator

Tue, Aug 9, 4:37 PM · Restricted Project, Restricted Project
mib committed rG4c2fb2e551e0: [lldb/crashlog] Fix interactive crashlog test (authored by mib).
[lldb/crashlog] Fix interactive crashlog test
Tue, Aug 9, 4:34 PM · Restricted Project
mib closed D129603: [lldb/crashlog] Fix interactive crashlog test.
Tue, Aug 9, 4:33 PM · Restricted Project, Restricted Project
mib updated the diff for D131085: [lldb/crashlog] Refactor the CrashLogParser logic.

Implement @kastiglione suggestion

Tue, Aug 9, 2:03 PM · Restricted Project, Restricted Project
mib added inline comments to D131085: [lldb/crashlog] Refactor the CrashLogParser logic.
Tue, Aug 9, 1:31 PM · Restricted Project, Restricted Project
mib added a comment to D131085: [lldb/crashlog] Refactor the CrashLogParser logic.

was the chmod intentional?

Tue, Aug 9, 1:28 PM · Restricted Project, Restricted Project
mib added inline comments to D131085: [lldb/crashlog] Refactor the CrashLogParser logic.
Tue, Aug 9, 10:06 AM · Restricted Project, Restricted Project

Mon, Aug 8

mib added inline comments to D131085: [lldb/crashlog] Refactor the CrashLogParser logic.
Mon, Aug 8, 6:00 PM · Restricted Project, Restricted Project
mib added inline comments to D131085: [lldb/crashlog] Refactor the CrashLogParser logic.
Mon, Aug 8, 4:47 PM · Restricted Project, Restricted Project

Sun, Aug 7

mib updated the diff for D131085: [lldb/crashlog] Refactor the CrashLogParser logic.

Address @kastiglione comment

Sun, Aug 7, 9:48 PM · Restricted Project, Restricted Project

Fri, Aug 5

mib added inline comments to D131304: [lldb] Remove uses of six module (NFC).
Fri, Aug 5, 4:04 PM · Restricted Project, Restricted Project
mib accepted D131304: [lldb] Remove uses of six module (NFC).

Very cool! Thanks for taking care of this! LGTM with the 2 comments and assuming the test suite runs fine :)

Fri, Aug 5, 4:02 PM · Restricted Project, Restricted Project
mib added a comment to D131138: [lldb] Dynamically generate enum names in lldbutil.

@JDevlieghere @mib what do you think of introducing type annotations as code is being touched?

Fri, Aug 5, 3:49 PM · Restricted Project, Restricted Project

Thu, Aug 4

mib added inline comments to D131038: [lldb/crashlog] Skip null image dsym fetching on interactive mode.
Thu, Aug 4, 10:53 AM · Restricted Project, Restricted Project
mib added inline comments to D131036: [lldb/crashlog] Add `-s|--skip-status` option to interactive mode.
Thu, Aug 4, 10:39 AM · Restricted Project, Restricted Project
mib updated the diff for D131032: [lldb/crashlog] Update frame regex matcher.

Add test

Thu, Aug 4, 10:35 AM · Restricted Project, Restricted Project

Wed, Aug 3

mib accepted D131138: [lldb] Dynamically generate enum names in lldbutil.
Wed, Aug 3, 9:08 PM · Restricted Project, Restricted Project
mib added a comment to D131138: [lldb] Dynamically generate enum names in lldbutil.

This is awesome 🤩 ! I was also thinking of changing the way enums are exposed to python: instead of having everything added to the lldb python module, we could create a class per enum and have static attributes for each enum value so we could do something like lldb.StopReason.Breakpoint. That static variable could be a pair with the value/string representation or maybe we could use the __str__ method to make it very pythonic. Just throwing some ideas here for later, but this LGTM 😊 !

Wed, Aug 3, 9:07 PM · Restricted Project, Restricted Project
mib updated the diff for D131086: [lldb/crashlog] Improve exception reporting for interactive mode.

Remove the comment from MachException::ExceptionCode since the function returns now an llvm::Optional

Wed, Aug 3, 6:39 PM · Restricted Project, Restricted Project
mib updated the diff for D131086: [lldb/crashlog] Improve exception reporting for interactive mode.

Use llvm::StringSwitch to get the exception code with the name

Wed, Aug 3, 6:35 PM · Restricted Project, Restricted Project
mib added inline comments to D131086: [lldb/crashlog] Improve exception reporting for interactive mode.
Wed, Aug 3, 6:32 PM · Restricted Project, Restricted Project
mib updated the diff for D131085: [lldb/crashlog] Refactor the CrashLogParser logic.

Address @JDevlieghere comments

Wed, Aug 3, 6:17 PM · Restricted Project, Restricted Project
mib added inline comments to D131085: [lldb/crashlog] Refactor the CrashLogParser logic.
Wed, Aug 3, 6:16 PM · Restricted Project, Restricted Project
mib updated the diff for D131033: [lldb/crashlog] Remove 'process_path' parsing logic.

Remove the process_path parsing logic

Wed, Aug 3, 4:44 PM · Restricted Project, Restricted Project
mib added a comment to D131032: [lldb/crashlog] Update frame regex matcher.

Can we test this by modifying an address in the existing test case?

Wed, Aug 3, 4:23 PM · Restricted Project, Restricted Project
mib added inline comments to D131033: [lldb/crashlog] Remove 'process_path' parsing logic.
Wed, Aug 3, 4:23 PM · Restricted Project, Restricted Project
mib updated the diff for D131033: [lldb/crashlog] Remove 'process_path' parsing logic.

Remove procPath key from crash report for testing

Wed, Aug 3, 3:41 PM · Restricted Project, Restricted Project
mib added inline comments to D131033: [lldb/crashlog] Remove 'process_path' parsing logic.
Wed, Aug 3, 2:58 PM · Restricted Project, Restricted Project
mib updated the diff for D131032: [lldb/crashlog] Update frame regex matcher.

Implement @kastiglione's suggestion

Wed, Aug 3, 2:26 PM · Restricted Project, Restricted Project
mib updated the diff for D129614: [lldb/crashlog] Surface error using SBCommandReturnObject argument.
  • Add custom InteractiveCrashLogException
  • Simplify the except block
Wed, Aug 3, 2:23 PM · Restricted Project, Restricted Project
mib updated the diff for D129611: [lldb/crashlog] Add '-t|--target' option to interactive mode.

Change f-string to string.format

Wed, Aug 3, 2:12 PM · Restricted Project, Restricted Project
mib added inline comments to D129611: [lldb/crashlog] Add '-t|--target' option to interactive mode.
Wed, Aug 3, 11:43 AM · Restricted Project, Restricted Project
mib added inline comments to D131085: [lldb/crashlog] Refactor the CrashLogParser logic.
Wed, Aug 3, 11:32 AM · Restricted Project, Restricted Project
mib accepted D131083: [lldb] Add assertStopReason helper function.

LGTM!

Wed, Aug 3, 11:29 AM · Restricted Project, Restricted Project
mib added inline comments to D131032: [lldb/crashlog] Update frame regex matcher.
Wed, Aug 3, 11:16 AM · Restricted Project, Restricted Project
mib updated the diff for D131085: [lldb/crashlog] Refactor the CrashLogParser logic.

Add missing import

Wed, Aug 3, 11:11 AM · Restricted Project, Restricted Project
mib requested review of D131086: [lldb/crashlog] Improve exception reporting for interactive mode.
Wed, Aug 3, 11:09 AM · Restricted Project, Restricted Project
mib requested review of D131085: [lldb/crashlog] Refactor the CrashLogParser logic.
Wed, Aug 3, 10:56 AM · Restricted Project, Restricted Project

Tue, Aug 2

mib requested review of D131038: [lldb/crashlog] Skip null image dsym fetching on interactive mode.
Tue, Aug 2, 5:43 PM · Restricted Project, Restricted Project
mib updated the diff for D129611: [lldb/crashlog] Add '-t|--target' option to interactive mode.

Make lit run command more readable

Tue, Aug 2, 5:30 PM · Restricted Project, Restricted Project
mib requested review of D131036: [lldb/crashlog] Add `-s|--skip-status` option to interactive mode.
Tue, Aug 2, 5:28 PM · Restricted Project, Restricted Project
mib updated the diff for D129603: [lldb/crashlog] Fix interactive crashlog test.
Tue, Aug 2, 4:58 PM · Restricted Project, Restricted Project
mib requested review of D131033: [lldb/crashlog] Remove 'process_path' parsing logic.
Tue, Aug 2, 4:45 PM · Restricted Project, Restricted Project
mib requested review of D131032: [lldb/crashlog] Update frame regex matcher.
Tue, Aug 2, 4:34 PM · Restricted Project, Restricted Project
mib updated the diff for D129614: [lldb/crashlog] Surface error using SBCommandReturnObject argument.

Address @JDevlieghere comments:

  • Use exception approach / Remove error helper function
  • Add test
Tue, Aug 2, 4:23 PM · Restricted Project, Restricted Project

Thu, Jul 28

mib updated the diff for D129614: [lldb/crashlog] Surface error using SBCommandReturnObject argument.
Thu, Jul 28, 3:54 PM · Restricted Project, Restricted Project
mib added inline comments to D129614: [lldb/crashlog] Surface error using SBCommandReturnObject argument.
Thu, Jul 28, 3:54 PM · Restricted Project, Restricted Project
mib updated the diff for D129611: [lldb/crashlog] Add '-t|--target' option to interactive mode.

Address @JDevlieghere feedbacks.

Thu, Jul 28, 2:02 PM · Restricted Project, Restricted Project
mib added inline comments to D129611: [lldb/crashlog] Add '-t|--target' option to interactive mode.
Thu, Jul 28, 2:02 PM · Restricted Project, Restricted Project
mib updated the diff for D129603: [lldb/crashlog] Fix interactive crashlog test.

Address @JDevlieghere feedback:

  • Rename test source file (cc -> cpp)
  • Reformat crash report
Thu, Jul 28, 12:05 PM · Restricted Project, Restricted Project

Tue, Jul 26

mib accepted D130540: [lldb] Read from the Rosetta shared cache with Xcode 14.

LGTM with a comment.

Tue, Jul 26, 10:07 AM · Restricted Project, Restricted Project

Fri, Jul 22

mib added a comment to D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator.

This broke building of Clang, when it's set up by symlinking llvm-project/clang into llvm-project/llvm/tools. In that case, cmake configure errors out like this:

-- Configuring done 
CMake Error in tools/clang/tools/clang-fuzzer/handle-cxx/CMakeLists.txt:
  Target "clangHandleCXX" INTERFACE_INCLUDE_DIRECTORIES property contains
  path:
 
    "/home/martin/code/llvm-project/llvm/tools/clang/tools/clang-fuzzer/handle-cxx/." 

  which is prefixed in the source directory.

See e.g. https://stackoverflow.com/questions/25676277/cmake-target-include-directories-prints-an-error-when-i-try-to-add-the-source for some discussion on the issue.

Can we revert this commit until this has been sorted out?

Fri, Jul 22, 3:26 PM · Restricted Project, Restricted Project, Restricted Project
mib added a reverting change for rGb797834748f1: [lldb/Fuzzer] Add fuzzer for expression evaluator: rGd959324e1efe: Revert "[lldb/Fuzzer] Add fuzzer for expression evaluator".
Fri, Jul 22, 3:25 PM · Restricted Project, Restricted Project
mib committed rGd959324e1efe: Revert "[lldb/Fuzzer] Add fuzzer for expression evaluator" (authored by mib).
Revert "[lldb/Fuzzer] Add fuzzer for expression evaluator"
Fri, Jul 22, 3:25 PM · Restricted Project, Restricted Project
mib added a reverting change for D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator: rGd959324e1efe: Revert "[lldb/Fuzzer] Add fuzzer for expression evaluator".
Fri, Jul 22, 3:25 PM · Restricted Project, Restricted Project, Restricted Project

Jul 12 2022

mib requested review of D129614: [lldb/crashlog] Surface error using SBCommandReturnObject argument.
Jul 12 2022, 6:29 PM · Restricted Project, Restricted Project