Changed short option to -E|--environment as @jingham suggested it.
Thu, Jan 21
Wed, Jan 20
Landed in 7169d3a315f4
Add header guards and split tablegen long description into multiple lines.
Tue, Jan 19
Thu, Jan 7
LGTM apart from few nits.
Mon, Jan 4
Dec 21 2020
Right! I thought it was depending on D52954 ... LGTM then !
Dec 14 2020
Address @JDevlieghere comments.
Dec 9 2020
Dec 7 2020
Hi @dstenb, any update on this ? I tried to look for DW_OP_LLVM_convert_generic in the codebase but couldn't find any occurence ... Thanks.
Oct 27 2020
Oct 23 2020
Add negative test for -debugger-tune=sce.
It seems that the HWASAN pre-check test is also failing in D89844 (https://buildkite.com/llvm-project/premerge-checks/builds/14519) ... I also tested on Linux and the test passes so I guess this is an issue with the bot.
Fix pre-check test failures
Oct 22 2020
Change shell test for unit test.
Oct 20 2020
Oct 19 2020
What if we tested each substring individually with self.assertIn to avoid checking the order of the substrings as it seems to change depending on the target ?
Oct 16 2020
LGTM provided that you address my last comments :)
Oct 15 2020
Could you please follow PEP8 style guide regarding variable names :
Oct 6 2020
LGTM! Have you considered also adding an option to the expression command object ? May be some people would like to change the error limit for a specific expression...
Sep 29 2020
Spotted some little things here and there ... This patch lacks a test and would need some reformatting (git clang-format HEAD~) but other than that, looks ok to me.
Sep 28 2020
Sep 11 2020
Add invalid breakpoint test case.
Sep 10 2020
Sep 8 2020
Some nitpicking but this looks fine to me.
Sep 3 2020
Sep 2 2020
@max-kudr Looking, thanks!
Sep 1 2020
Aug 28 2020
Replaced all the interpreter occurrences with shell in the code.
Removed bool run_in_shell argument from Platform classes.
- Changed CommandObject option from -i|--interpreter to -s|--shell.
- Updated test program build settings.
Aug 27 2020
Address most comments:
- Passed down the shell interpreter path down to Host::RunShellCommand to be "assembled" with the rest of the command.
- Wrote a custom test program to simplify testing on multiple platforms.
- Updated code by using llvm::StringRef instead of CString when possible.
Do people really call command-line shells interpreters? I would have thought --shell would be a better name. lldb already has its own command interpreter which is orthogonal to the shells, so it seems confusing to use the same term for both.
Aug 26 2020
Aug 19 2020
Updated man page to reflect current implementation.
Addressed @JDevlieghere comments.
Aug 4 2020
Jul 24 2020
Just a little nit, but as we already discussed offline, I have some doubts about adding a --dummy option.
It sounds unnecessary to me, so I'd like to hear @jingham take on this.
Jul 23 2020
Looks good to me.