Page MenuHomePhabricator
Feed Advanced Search

Yesterday

ashay-github accepted D131565: [cmake] Fix tablegen exports.

LGTM, thanks for the quick fix!

Wed, Aug 10, 9:23 AM · Restricted Project, Restricted Project, Restricted Project

Sun, Aug 7

ashay-github updated the summary of D131282: [mlir] fix `add_tablegen()` macro to allow installing mlir-pdll.
Sun, Aug 7, 12:23 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
ashay-github added inline comments to D131282: [mlir] fix `add_tablegen()` macro to allow installing mlir-pdll.
Sun, Aug 7, 11:58 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
ashay-github updated the diff for D131282: [mlir] fix `add_tablegen()` macro to allow installing mlir-pdll.

Simply invocation of cmake_parse_arguments().

Sun, Aug 7, 11:57 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
ashay-github added inline comments to D131282: [mlir] fix `add_tablegen()` macro to allow installing mlir-pdll.
Sun, Aug 7, 3:49 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
ashay-github updated the diff for D131282: [mlir] fix `add_tablegen()` macro to allow installing mlir-pdll.

Added optional DESTINATION argument to add_tablegen(). Also updated all
invocations of the macro.

Sun, Aug 7, 3:48 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Fri, Aug 5

ashay-github added a comment to D131282: [mlir] fix `add_tablegen()` macro to allow installing mlir-pdll.

I'm not sure if the test failures (timeouts) are related to the changes in this patch.

Fri, Aug 5, 10:10 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
ashay-github updated the diff for D131282: [mlir] fix `add_tablegen()` macro to allow installing mlir-pdll.

Removed the project check.

Fri, Aug 5, 5:57 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
ashay-github added a comment to D131282: [mlir] fix `add_tablegen()` macro to allow installing mlir-pdll.

Thanks, that makes sense. How about something like add_tablegen(mlir-pdll EXPORT) (i.e. drop the project but add a boolean argument), so that we can still control the installation but not worry about the project name?

Fri, Aug 5, 1:00 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
ashay-github requested review of D131282: [mlir] fix `add_tablegen()` macro to allow installing mlir-pdll.
Fri, Aug 5, 12:24 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Fri, Jul 15

ashay-github added a comment to D129718: [mlir] check whether region and block visitors are interrupted.

@rriddle My apologies! The fix is in this patch: https://reviews.llvm.org/D129913.

Fri, Jul 15, 5:57 PM · Restricted Project, Restricted Project
ashay-github requested review of D129913: [mlir] remove unnecessary statements in test.
Fri, Jul 15, 5:55 PM · Restricted Project, Restricted Project
ashay-github added a comment to D129718: [mlir] check whether region and block visitors are interrupted.

I think it's important that we test this. Would it possible to add a new visitor for regions and blocks?

Fri, Jul 15, 11:32 AM · Restricted Project, Restricted Project
ashay-github updated the diff for D129718: [mlir] check whether region and block visitors are interrupted.

Added tests for region and block visitors.

Fri, Jul 15, 11:29 AM · Restricted Project, Restricted Project
ashay-github added a comment to D129718: [mlir] check whether region and block visitors are interrupted.

It seems Phabricator didn't send out an email when I created the patch. Pinging folks to see if it helps.

Fri, Jul 15, 9:00 AM · Restricted Project, Restricted Project

Wed, Jul 13

ashay-github requested review of D129718: [mlir] check whether region and block visitors are interrupted.
Wed, Jul 13, 7:13 PM · Restricted Project, Restricted Project

Jun 2 2022

ashay-github updated the diff for D126604: [mlir] translate memref.reshape with static shapes but dynamic dims.

Place comment in the assert message

Jun 2 2022, 9:33 AM · Restricted Project, Restricted Project

May 31 2022

ashay-github added inline comments to D126604: [mlir] translate memref.reshape with static shapes but dynamic dims.
May 31 2022, 10:29 AM · Restricted Project, Restricted Project
ashay-github updated the diff for D126604: [mlir] translate memref.reshape with static shapes but dynamic dims.

Ensure that null stride value is never used

May 31 2022, 10:29 AM · Restricted Project, Restricted Project

May 30 2022

ashay-github added inline comments to D126604: [mlir] translate memref.reshape with static shapes but dynamic dims.
May 30 2022, 5:57 PM · Restricted Project, Restricted Project
ashay-github updated the diff for D126604: [mlir] translate memref.reshape with static shapes but dynamic dims.

Now using regular if instead of a ternary statement for better readability

May 30 2022, 5:56 PM · Restricted Project, Restricted Project

May 28 2022

ashay-github added inline comments to D126604: [mlir] translate memref.reshape with static shapes but dynamic dims.
May 28 2022, 5:46 PM · Restricted Project, Restricted Project
ashay-github requested review of D126604: [mlir] translate memref.reshape with static shapes but dynamic dims.
May 28 2022, 5:41 PM · Restricted Project, Restricted Project

May 12 2022

ashay-github updated the diff for D125039: [mlir] translate memref.reshape ops that have static shapes.

dropping element count in SmallVector usage

May 12 2022, 10:31 AM · Restricted Project, Restricted Project

May 10 2022

ashay-github added a comment to D125039: [mlir] translate memref.reshape ops that have static shapes.

Thanks @cathyzhyi! I added a check for !isStaticStrideOrOffset(offset) as well.

May 10 2022, 5:34 PM · Restricted Project, Restricted Project
ashay-github updated the diff for D125039: [mlir] translate memref.reshape ops that have static shapes.

check for dynamic offset

May 10 2022, 5:32 PM · Restricted Project, Restricted Project
ashay-github added a comment to D125039: [mlir] translate memref.reshape ops that have static shapes.

Thanks @cathyzhyi! I've updated the code accordingly, but please let me know if I still got it wrong. Thanks!

May 10 2022, 10:44 AM · Restricted Project, Restricted Project
ashay-github updated the diff for D125039: [mlir] translate memref.reshape ops that have static shapes.

check for static strides and offsets, otherwise return failure

May 10 2022, 10:40 AM · Restricted Project, Restricted Project

May 9 2022

ashay-github requested review of D125251: [mlir] Fail early if AnalysisState::getBuffer() returns failure.
May 9 2022, 11:27 AM · Restricted Project, Restricted Project
ashay-github added a comment to D125039: [mlir] translate memref.reshape ops that have static shapes.

Thanks for the suggestion. I've updated the code and test to set the offset, stride, and size. PTAL.

May 9 2022, 7:18 AM · Restricted Project, Restricted Project
ashay-github added a comment to D125031: [mlir] Add translation from tensor.reshape to memref.reshape.

Thanks @springerm! Could you commit the change please? I don't yet have write access to the repo.

May 9 2022, 7:16 AM · Restricted Project, Restricted Project

May 6 2022

ashay-github updated the diff for D125039: [mlir] translate memref.reshape ops that have static shapes.

set stride, offset, and size attributes of MemRefDescriptor

May 6 2022, 10:17 AM · Restricted Project, Restricted Project
ashay-github added a comment to D125031: [mlir] Add translation from tensor.reshape to memref.reshape.

Thanks! Fixed the code as per the suggestions. PTAL.

May 6 2022, 9:32 AM · Restricted Project, Restricted Project
ashay-github updated the diff for D125031: [mlir] Add translation from tensor.reshape to memref.reshape.

This patch changes the bufferizesToMemoryRead() method so that it returns true
for the shape operand. It also makes bufferize() return false if
BufferizationState::getBuffer() returns a failure.

May 6 2022, 9:30 AM · Restricted Project, Restricted Project

May 5 2022

ashay-github requested review of D125039: [mlir] translate memref.reshape ops that have static shapes.
May 5 2022, 1:49 PM · Restricted Project, Restricted Project
ashay-github requested review of D125031: [mlir] Add translation from tensor.reshape to memref.reshape.
May 5 2022, 11:50 AM · Restricted Project, Restricted Project

Apr 19 2022

ashay-github added a comment to D123981: [MLIR] Add function to create BFloat16 array attribute.

@stellaraccident Thanks for approving. I do not have commit access yet. Could you (or someone) commit this for now please? Thanks!

Apr 19 2022, 10:46 AM · Restricted Project, Restricted Project

Apr 18 2022

ashay-github requested review of D123981: [MLIR] Add function to create BFloat16 array attribute.
Apr 18 2022, 9:34 PM · Restricted Project, Restricted Project