LGTM, thanks for the quick fix!

Simply invocation of cmake_parse_arguments().

Added optional DESTINATION argument to add_tablegen(). Also updated all
invocations of the macro.

I'm not sure if the test failures (timeouts) are related to the changes in this patch.

Removed the project check.

Thanks, that makes sense. How about something like add_tablegen(mlir-pdll EXPORT) (i.e. drop the project but add a boolean argument), so that we can still control the installation but not worry about the project name?

@rriddle My apologies! The fix is in this patch: https://reviews.llvm.org/D129913.

I think it's important that we test this. Would it possible to add a new visitor for regions and blocks?

Added tests for region and block visitors.

It seems Phabricator didn't send out an email when I created the patch. Pinging folks to see if it helps.

Place comment in the assert message

Ensure that null stride value is never used

Now using regular if instead of a ternary statement for better readability

dropping element count in SmallVector usage

Thanks @cathyzhyi! I added a check for !isStaticStrideOrOffset(offset) as well.

check for dynamic offset

Thanks @cathyzhyi! I've updated the code accordingly, but please let me know if I still got it wrong. Thanks!

check for static strides and offsets, otherwise return failure

Thanks for the suggestion. I've updated the code and test to set the offset, stride, and size. PTAL.

Thanks @springerm! Could you commit the change please? I don't yet have write access to the repo.

set stride, offset, and size attributes of MemRefDescriptor

Thanks! Fixed the code as per the suggestions. PTAL.

This patch changes the bufferizesToMemoryRead() method so that it returns true
for the shape operand. It also makes bufferize() return false if
BufferizationState::getBuffer() returns a failure.

@stellaraccident Thanks for approving. I do not have commit access yet. Could you (or someone) commit this for now please? Thanks!