Page MenuHomePhabricator
Feed Advanced Search

Jan 22 2020

allevato accepted D73160: [llvm-cov] Add support for -skip-functions to lcov.
Jan 22 2020, 7:18 AM · Restricted Project

Apr 10 2019

allevato added a comment to D60161: Expose non-trivial struct helpers for Swift..

Oh, and in case I need to mention this (I don't contribute to llvm/clang frequently), I don't have commit access so I'll need someone else to merge it in. Thanks!

Apr 10 2019, 9:29 AM · Restricted Project
allevato added a comment to D60161: Expose non-trivial struct helpers for Swift..

Thanks for the review! This is ready to go on my end if there aren't any other comments.

Apr 10 2019, 9:10 AM · Restricted Project
allevato updated the diff for D60161: Expose non-trivial struct helpers for Swift..
  • Rename generate* to get* and cleanup param names.
Apr 10 2019, 9:06 AM · Restricted Project

Apr 9 2019

allevato updated the diff for D60161: Expose non-trivial struct helpers for Swift..
  • Apply review changes
Apr 9 2019, 12:29 PM · Restricted Project

Apr 3 2019

allevato added inline comments to D60161: Expose non-trivial struct helpers for Swift..
Apr 3 2019, 3:01 PM · Restricted Project

Apr 2 2019

allevato created D60161: Expose non-trivial struct helpers for Swift..
Apr 2 2019, 4:00 PM · Restricted Project

Nov 8 2018

allevato added a comment to D54266: [llvm-cov] Add lcov tracefile export format..

Thanks for the quick review!

Nov 8 2018, 4:06 PM
allevato added a comment to D54266: [llvm-cov] Add lcov tracefile export format..
In D54266#1291921, @vsk wrote:

I suggest adding a note in docs/ReleaseNotes.rst about this.

Nov 8 2018, 3:36 PM
allevato updated the diff for D54266: [llvm-cov] Add lcov tracefile export format..
  • Clean up error message, update release notes and command guide.
Nov 8 2018, 3:34 PM
allevato updated the diff for D54266: [llvm-cov] Add lcov tracefile export format..
  • Fix file comment.
Nov 8 2018, 8:59 AM
allevato created D54266: [llvm-cov] Add lcov tracefile export format..
Nov 8 2018, 8:57 AM