Oh, and in case I need to mention this (I don't contribute to llvm/clang frequently), I don't have commit access so I'll need someone else to merge it in. Thanks!
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Jan 22 2020
Jan 22 2020
Jan 22 2020, 7:18 AM · Restricted Project
Apr 10 2019
Apr 10 2019
Apr 10 2019, 9:29 AM · Restricted Project
Thanks for the review! This is ready to go on my end if there aren't any other comments.
Apr 10 2019, 9:10 AM · Restricted Project
- Rename generate* to get* and cleanup param names.
Apr 10 2019, 9:06 AM · Restricted Project
Apr 9 2019
Apr 9 2019
- Apply review changes
Apr 9 2019, 12:29 PM · Restricted Project
Apr 3 2019
Apr 3 2019
Apr 3 2019, 3:01 PM · Restricted Project
Apr 2 2019
Apr 2 2019
Apr 2 2019, 4:00 PM · Restricted Project
Nov 8 2018
Nov 8 2018
Thanks for the quick review!
In D54266#1291921, @vsk wrote:I suggest adding a note in docs/ReleaseNotes.rst about this.
- Clean up error message, update release notes and command guide.
- Fix file comment.