Page MenuHomePhabricator
Feed Advanced Search

Oct 20 2022

asi-sc updated the diff for D136170: [UpdateTestChecks] Sync flags in update_mir_test_checks.py with MIFlags.

Add tests

Oct 20 2022, 6:32 AM · Restricted Project, Restricted Project
asi-sc updated the summary of D136339: [MachineCombiner][RISCV] Relax optimization level requirement.
Oct 20 2022, 5:17 AM · Restricted Project, Restricted Project
asi-sc requested review of D136339: [MachineCombiner][RISCV] Relax optimization level requirement.
Oct 20 2022, 5:15 AM · Restricted Project, Restricted Project

Oct 18 2022

asi-sc updated the diff for D135264: [MachineCombiner][RISCV] Enable MachineCombiner for RISCV.

Re-generate machine-combiner-mir.ll test checks

Oct 18 2022, 8:42 AM · Restricted Project, Restricted Project
asi-sc reopened D135264: [MachineCombiner][RISCV] Enable MachineCombiner for RISCV.
Oct 18 2022, 8:39 AM · Restricted Project, Restricted Project
asi-sc added a comment to D135264: [MachineCombiner][RISCV] Enable MachineCombiner for RISCV.

We have to revert it because tests were not correctly updated by 'update_mir_test_checks.py' script. Fix in D136170. I'll regenerate tests and update the review soon.

Oct 18 2022, 6:57 AM · Restricted Project, Restricted Project
asi-sc added reviewers for D136170: [UpdateTestChecks] Sync flags in update_mir_test_checks.py with MIFlags: uweigand, zequanwu, bogner, rtereshin.
Oct 18 2022, 6:49 AM · Restricted Project, Restricted Project
asi-sc requested review of D136170: [UpdateTestChecks] Sync flags in update_mir_test_checks.py with MIFlags.
Oct 18 2022, 6:44 AM · Restricted Project, Restricted Project
asi-sc updated the diff for D135264: [MachineCombiner][RISCV] Enable MachineCombiner for RISCV.

Rebase to fetch precommitted tests

Oct 18 2022, 4:50 AM · Restricted Project, Restricted Project

Oct 14 2022

asi-sc updated the diff for D135264: [MachineCombiner][RISCV] Enable MachineCombiner for RISCV.

Rebase after D135776

Oct 14 2022, 9:28 AM · Restricted Project, Restricted Project

Oct 13 2022

asi-sc updated the diff for D135264: [MachineCombiner][RISCV] Enable MachineCombiner for RISCV.

Addressed review comments

Oct 13 2022, 1:32 AM · Restricted Project, Restricted Project
asi-sc added a comment to D135776: [NFC] Use forward decl of MachineCombinerPattern enum to reduce dependencies.

Thanks for the review.
@dmgreen, could you please submit the patch on my behalf? Author: Anton Sidorenko <anton.sidorenko@syntacore.com>

Oct 13 2022, 1:20 AM · Restricted Project, Restricted Project

Oct 12 2022

asi-sc added reviewers for D135776: [NFC] Use forward decl of MachineCombinerPattern enum to reduce dependencies: Gerolf, haicheng, Carrot, dmgreen.
Oct 12 2022, 8:47 AM · Restricted Project, Restricted Project
asi-sc requested review of D135776: [NFC] Use forward decl of MachineCombinerPattern enum to reduce dependencies.
Oct 12 2022, 6:51 AM · Restricted Project, Restricted Project
asi-sc added a comment to D130895: [RISCV] Make VL choosing for a splat-like VMV based on its users.

A gentle ping.

Oct 12 2022, 6:17 AM · Restricted Project, Restricted Project

Oct 11 2022

asi-sc updated the diff for D135264: [MachineCombiner][RISCV] Enable MachineCombiner for RISCV.

Move FRM operands creation from setSpecialOperandAttr to finalizeInsInstrs

Oct 11 2022, 8:13 AM · Restricted Project, Restricted Project
asi-sc added inline comments to D135264: [MachineCombiner][RISCV] Enable MachineCombiner for RISCV.
Oct 11 2022, 5:18 AM · Restricted Project, Restricted Project
asi-sc updated the diff for D135264: [MachineCombiner][RISCV] Enable MachineCombiner for RISCV.

Make flags intersection for new instructions, add Nsz flag check.

Oct 11 2022, 5:09 AM · Restricted Project, Restricted Project

Oct 10 2022

asi-sc added inline comments to D135264: [MachineCombiner][RISCV] Enable MachineCombiner for RISCV.
Oct 10 2022, 6:49 AM · Restricted Project, Restricted Project
asi-sc updated the diff for D135264: [MachineCombiner][RISCV] Enable MachineCombiner for RISCV.

Small code refactoring and tests update (change 'fast' flag to 'reassoc')

Oct 10 2022, 6:21 AM · Restricted Project, Restricted Project

Oct 7 2022

asi-sc added inline comments to D135264: [MachineCombiner][RISCV] Enable MachineCombiner for RISCV.
Oct 7 2022, 10:31 AM · Restricted Project, Restricted Project

Oct 6 2022

asi-sc added inline comments to D135264: [MachineCombiner][RISCV] Enable MachineCombiner for RISCV.
Oct 6 2022, 6:38 AM · Restricted Project, Restricted Project
asi-sc updated the diff for D135264: [MachineCombiner][RISCV] Enable MachineCombiner for RISCV.

Addressed review comments

Oct 6 2022, 6:34 AM · Restricted Project, Restricted Project

Oct 5 2022

asi-sc updated the diff for D130895: [RISCV] Make VL choosing for a splat-like VMV based on its users.

Rebase to fetch merged dependency

Oct 5 2022, 8:22 AM · Restricted Project, Restricted Project
asi-sc added reviewers for D135264: [MachineCombiner][RISCV] Enable MachineCombiner for RISCV: reames, craig.topper, frasercrmck.
Oct 5 2022, 5:59 AM · Restricted Project, Restricted Project
asi-sc added a comment to D135264: [MachineCombiner][RISCV] Enable MachineCombiner for RISCV.

This patch does not contain the full test to make changes more readable during the review.

Oct 5 2022, 5:57 AM · Restricted Project, Restricted Project
asi-sc requested review of D135264: [MachineCombiner][RISCV] Enable MachineCombiner for RISCV.
Oct 5 2022, 5:48 AM · Restricted Project, Restricted Project
asi-sc added a comment to D135086: [NFC][RISCV] Move getSEWLMULRatio function to header.

Thanks for the review.
@frasercrmck, could you please submit the patch on my behalf? Author: Anton Sidorenko <anton.sidorenko@syntacore.com>

Oct 5 2022, 1:23 AM · Restricted Project, Restricted Project

Oct 4 2022

asi-sc added inline comments to D135086: [NFC][RISCV] Move getSEWLMULRatio function to header.
Oct 4 2022, 9:22 AM · Restricted Project, Restricted Project
asi-sc updated the diff for D135086: [NFC][RISCV] Move getSEWLMULRatio function to header.

Addressed review comments

Oct 4 2022, 1:38 AM · Restricted Project, Restricted Project

Oct 3 2022

asi-sc added reviewers for D135086: [NFC][RISCV] Move getSEWLMULRatio function to header: craig.topper, reames.
Oct 3 2022, 10:35 AM · Restricted Project, Restricted Project
asi-sc updated the diff for D130895: [RISCV] Make VL choosing for a splat-like VMV based on its users.

Apply VL shrinking only when SEW/LMUL ratio is unmodified. This change depends on D135086

Oct 3 2022, 9:45 AM · Restricted Project, Restricted Project
asi-sc requested review of D135086: [NFC][RISCV] Move getSEWLMULRatio function to header.
Oct 3 2022, 9:40 AM · Restricted Project, Restricted Project

Sep 28 2022

asi-sc added inline comments to D130895: [RISCV] Make VL choosing for a splat-like VMV based on its users.
Sep 28 2022, 7:04 AM · Restricted Project, Restricted Project

Sep 26 2022

asi-sc added inline comments to D130895: [RISCV] Make VL choosing for a splat-like VMV based on its users.
Sep 26 2022, 7:04 AM · Restricted Project, Restricted Project
asi-sc updated the diff for D130895: [RISCV] Make VL choosing for a splat-like VMV based on its users.

Addressed review comments except for a few which have questions from my side.

Sep 26 2022, 6:53 AM · Restricted Project, Restricted Project

Sep 22 2022

asi-sc added inline comments to D130895: [RISCV] Make VL choosing for a splat-like VMV based on its users.
Sep 22 2022, 1:49 AM · Restricted Project, Restricted Project

Sep 21 2022

asi-sc updated the diff for D130895: [RISCV] Make VL choosing for a splat-like VMV based on its users.

Rebase

Sep 21 2022, 3:15 AM · Restricted Project, Restricted Project

Sep 20 2022

asi-sc added a comment to D134179: [NFC][RISCV] Move calculations of SDNode policy operand idx to a separate function.

@arcbbb, could you please submit the patch on my behalf? Author: Anton Sidorenko <anton.sidorenko@syntacore.com>
Thanks.

Sep 20 2022, 9:57 AM · Restricted Project, Restricted Project

Sep 19 2022

asi-sc added a comment to D130895: [RISCV] Make VL choosing for a splat-like VMV based on its users.

Depends on D134179

Sep 19 2022, 8:40 AM · Restricted Project, Restricted Project
asi-sc updated the diff for D130895: [RISCV] Make VL choosing for a splat-like VMV based on its users.

Addressed review comments

Sep 19 2022, 8:39 AM · Restricted Project, Restricted Project
asi-sc added inline comments to D130895: [RISCV] Make VL choosing for a splat-like VMV based on its users.
Sep 19 2022, 7:19 AM · Restricted Project, Restricted Project
asi-sc added reviewers for D134179: [NFC][RISCV] Move calculations of SDNode policy operand idx to a separate function: frasercrmck, arcbbb.
Sep 19 2022, 5:48 AM · Restricted Project, Restricted Project
asi-sc added reviewers for D134179: [NFC][RISCV] Move calculations of SDNode policy operand idx to a separate function: reames, craig.topper.
Sep 19 2022, 5:45 AM · Restricted Project, Restricted Project
asi-sc requested review of D134179: [NFC][RISCV] Move calculations of SDNode policy operand idx to a separate function.
Sep 19 2022, 5:43 AM · Restricted Project, Restricted Project

Sep 16 2022

asi-sc added inline comments to D130895: [RISCV] Make VL choosing for a splat-like VMV based on its users.
Sep 16 2022, 10:01 AM · Restricted Project, Restricted Project

Sep 15 2022

asi-sc added a comment to D130895: [RISCV] Make VL choosing for a splat-like VMV based on its users.

I've looked at a few ideas in this area, and there's an interaction I want to point out that I don't have a good answer for.

While reducing the VL of a splat to match the demanded lanes can remove vsetv toggles, it can also add them. Specifically, if the splat happens to be scheduled in a region which uses the original wider VL, then reducing the VL actually pessimizes the code. This actually shows up in mixed VL code, particularly when combined with LICM for splats which can't be folded (profitably) into their users.

We can patch part of this by extending InsertVSETVLI to allow increasing VL on splats if the splat is TA. However, there's still a scheduling interaction here which is a bit hard to account for.

I generally do believe that having VL reduction for all computation (not just splats) is generally a good idea; I'm just trying to figure out how to slice the pieces so that we can get there incrementally without nasty regressions along the way.

Sep 15 2022, 7:20 AM · Restricted Project, Restricted Project

Sep 13 2022

asi-sc added a comment to D130895: [RISCV] Make VL choosing for a splat-like VMV based on its users.

A gentle ping

Sep 13 2022, 1:03 AM · Restricted Project, Restricted Project

Sep 6 2022

asi-sc updated the summary of D130895: [RISCV] Make VL choosing for a splat-like VMV based on its users.
Sep 6 2022, 5:30 AM · Restricted Project, Restricted Project
asi-sc retitled D130895: [RISCV] Make VL choosing for a splat-like VMV based on its users from Make VL choosing for a splat constant based on its users to [RISCV] Make VL choosing for a splat-like VMV based on its users.
Sep 6 2022, 5:29 AM · Restricted Project, Restricted Project
asi-sc updated the diff for D130895: [RISCV] Make VL choosing for a splat-like VMV based on its users.

Make VL choosing for a splat-like VMV based on its users

Sep 6 2022, 5:27 AM · Restricted Project, Restricted Project

Aug 12 2022

asi-sc added a comment to D130895: [RISCV] Make VL choosing for a splat-like VMV based on its users.

A gentle ping on the question about adding a markup of merge operands for intrinsics.

Aug 12 2022, 6:13 AM · Restricted Project, Restricted Project

Aug 2 2022

asi-sc added a comment to D130895: [RISCV] Make VL choosing for a splat-like VMV based on its users.

What if the user is the merge operand of a tail undisturbed instruction. The VL of the using instruction would not apply to it then.

Aug 2 2022, 5:43 AM · Restricted Project, Restricted Project

Aug 1 2022

asi-sc added reviewers for D130895: [RISCV] Make VL choosing for a splat-like VMV based on its users: reames, craig.topper, frasercrmck.
Aug 1 2022, 5:42 AM · Restricted Project, Restricted Project
asi-sc requested review of D130895: [RISCV] Make VL choosing for a splat-like VMV based on its users.
Aug 1 2022, 5:35 AM · Restricted Project, Restricted Project