Page MenuHomePhabricator
Feed Advanced Search

Tue, Aug 13

igorb accepted D63934: [MIR] Improve PRE condition of MachineCSE optimization.

LGTM

Tue, Aug 13, 4:10 AM · Restricted Project
igorb accepted D66132: [CodeGen] Add `shouldDoPartialRedundancyElimination()` to `TargetInstrInfo` (PRR42405).

LGTM

Tue, Aug 13, 4:10 AM · Restricted Project

Jun 30 2019

igorb added reviewers for D63934: [MIR] Improve PRE condition of MachineCSE optimization: gilr, Ayal.
Jun 30 2019, 12:03 AM · Restricted Project

Feb 6 2019

igorb added a comment to D57803: [X86][GlobalISEL] Support lowering aligned unordered atomics.

The change looks ok.
Could you please add mir test for InstructionSelector pass, similar to select-memop-scalar.mir.
Thanks

Feb 6 2019, 11:54 PM · Restricted Project

Jan 8 2019

igorb added a comment to D55639: GlobalISel: Allow shift amount to be a different type.

The x86 changes looks ok. Few minor comments.
Thanks.

Jan 8 2019, 5:10 AM

Oct 7 2018

igorb accepted D49781: [GlobalIsel][X86] Support G_UDIV/G_UREM/G_SREM.

LGTM,
Thanks

Oct 7 2018, 12:10 AM

Aug 28 2018

igorb added a reviewer for D51197: [GISel]: Add missing opcodes for overflow intrinsics: aivchenk.
Aug 28 2018, 3:11 AM
igorb added a comment to D51197: [GISel]: Add missing opcodes for overflow intrinsics.

x86 is still using UADDE, and it's generated only by IRTranslator, so if you do this then x86 will lose support for compiling llvm.uadd.with.overflow intrinsics. @igorb what do you think?

Which is exposing a hole in our general GISel testing, where individual changes in passes can result in overall support for some input IR to be lost.

Aug 28 2018, 3:07 AM

Aug 26 2018

igorb resigned from D10799: [X86][AVX512BW] add intrinsics support.
Aug 26 2018, 10:37 PM
igorb resigned from D10730: [x86][AVX512] add vscalef support.
Aug 26 2018, 10:36 PM
igorb resigned from D10439: [AVX512] add intrinsics for integers min/max .
Aug 26 2018, 10:36 PM
igorb resigned from D10948: [X86][AVX512] Multiply Packed Unsigned Integers with Round and Scale.
Aug 26 2018, 10:35 PM

Aug 14 2018

igorb resigned from D10504: [AVX512] add Average packed unsigned integers.
Aug 14 2018, 1:58 AM
igorb resigned from D10896: [X86][AVX512] add Multiply High Op.
Aug 14 2018, 1:58 AM
igorb resigned from D40462: [LLVM][X86] Converting X86 intrinisics movmsk{ps|pd}{|256} and pmovmskb{128|256}.
Aug 14 2018, 1:57 AM
igorb resigned from D40465: [Clang][X86] Converting X86 intrinisics movmsk{ps|pd}{|256} and pmovmskb{128|256}.
Aug 14 2018, 1:57 AM
igorb accepted D49855: [GlobalISel][x86] Add the support for G_FPTRUNC.

LGTM

Aug 14 2018, 1:54 AM
igorb accepted D49183: [GlobalISel][X86_64] Support for G_FPTOSI.

LGTM

Aug 14 2018, 1:51 AM
igorb accepted D49180: [GlobalIsel][X86] Support for llvm.trap intrinsic.

LGTM

Aug 14 2018, 1:48 AM
igorb accepted D49172: [GlobalIsel][X86] Support for G_FCMP.

LGTM

Aug 14 2018, 1:44 AM

Jul 24 2018

igorb abandoned D38219: [GlobalISel][X86] Support G_LSHR/G_ASHR/G_SHL..
Jul 24 2018, 1:53 AM

Jun 5 2018

igorb accepted D47132: [GlobalISel][X86_64] Support for G_SITOFP.

Could you please consider to add ll tests also.

Jun 5 2018, 4:21 AM

Jun 4 2018

igorb abandoned D37678: [GISel][x86] X86 part for D37640.

merged.

Jun 4 2018, 11:54 PM

Mar 14 2018

igorb accepted D44430: [GlobalIsel][X86] Support for G_SDIV instruction.

LGTM

Mar 14 2018, 8:05 AM
igorb accepted D44395: [GlobalISel][X86] Support G_LSHR/G_ASHR/G_SHL.

LGTM

Mar 14 2018, 3:58 AM

Mar 13 2018

igorb accepted D44378: [GlobalIsel][X86] Support for G_ZEXT instruction.

LGTM

Mar 13 2018, 7:05 AM
igorb added a comment to D44395: [GlobalISel][X86] Support G_LSHR/G_ASHR/G_SHL.

Hi,
Could you please add more context in this patch also (svn diff --diff-cmd=diff -x -U999999)
Thanks

Mar 13 2018, 2:10 AM
igorb added a comment to D44378: [GlobalIsel][X86] Support for G_ZEXT instruction.

Hi,
Could you please add more context (svn diff --diff-cmd=diff -x -U999999)
Thanks

Mar 13 2018, 2:05 AM

Feb 27 2018

igorb accepted D43617: [GlobalIsel][X86] Support G_PTRTOINT instruction..

LGTM,
Thanks.

Feb 27 2018, 4:21 AM
igorb added inline comments to D43617: [GlobalIsel][X86] Support G_PTRTOINT instruction..
Feb 27 2018, 12:44 AM
igorb added a comment to D43617: [GlobalIsel][X86] Support G_PTRTOINT instruction..

Hi,
Could you please add test for Legalizar pass?
I also suggest to add ll test to test all the passes together.

Feb 27 2018, 12:39 AM

Feb 24 2018

igorb accepted D43622: [GlobalIsel][X86] Support G_INTTOPTR instruction..

LGTM,
Thanks.

Feb 24 2018, 11:24 PM

Feb 22 2018

igorb added a comment to D43622: [GlobalIsel][X86] Support G_INTTOPTR instruction..

Could you please add test for Legalizar pass?

Feb 22 2018, 12:42 PM

Jan 17 2018

igorb added a reviewer for D41599: [X86] Lowering X86 avx512 sqrt intrinsics to IR - LLVM: DavidKreitzer.
Jan 17 2018, 4:58 AM

Dec 21 2017

igorb added a comment to D37775: Add a verifier test to check the access on both sides of COPY are the same.

Hi Aditya ,
Unfortunately, I don't have time to work on this task

Dec 21 2017, 4:27 AM
igorb updated subscribers of D37775: Add a verifier test to check the access on both sides of COPY are the same.
Dec 21 2017, 4:23 AM

Dec 13 2017

igorb accepted D39547: [AVX512] Adding support for load truncate store of I1.

LGTM

Dec 13 2017, 4:36 AM

Nov 8 2017

igorb accepted D39569: [AVX512] Adding support for extract element(mask i8) from a vector .

LGTM

Nov 8 2017, 6:16 AM
igorb added inline comments to D39547: [AVX512] Adding support for load truncate store of I1.
Nov 8 2017, 5:53 AM

Oct 10 2017

igorb accepted D38780: [X86] Add CLWB intrinsic. llvm part.

LGTM

Oct 10 2017, 11:16 PM
igorb accepted D38782: [X86] Correct type for argument to clflushopt intrinsic..

LGTM

Oct 10 2017, 11:14 PM

Sep 25 2017

igorb accepted D38231: fixing a bug in mask[z]_set1.

LGTM

Sep 25 2017, 5:46 AM
igorb created D38219: [GlobalISel][X86] Support G_LSHR/G_ASHR/G_SHL..
Sep 25 2017, 5:02 AM

Sep 18 2017

igorb added a comment to D37678: [GISel][x86] X86 part for D37640.

Fixed CodeGen/X86/GlobalISel/phi.ll failing.

Sep 18 2017, 1:51 PM
igorb updated the diff for D37678: [GISel][x86] X86 part for D37640.
  • rebase
Sep 18 2017, 1:48 PM

Sep 15 2017

igorb added inline comments to D37734: [GlobalISel][X86] G_FCONSTANT support..
Sep 15 2017, 8:57 AM
igorb updated the diff for D37734: [GlobalISel][X86] G_FCONSTANT support..

fix according to comments.
32bit PIC mode not supported yet.

Sep 15 2017, 8:57 AM
igorb accepted D37653: [X86] Add isel pattern infrastructure to begin recognizing when we're inserting 0s into the upper portions of a vector register and the producing instruction as already produced the zeros..

LGTM

Sep 15 2017, 1:36 AM

Sep 13 2017

igorb added inline comments to D37775: Add a verifier test to check the access on both sides of COPY are the same.
Sep 13 2017, 1:17 AM
igorb added a comment to D37775: Add a verifier test to check the access on both sides of COPY are the same.

Failed to build as a shared library -DBUILD_SHARED_LIBS=1

Sep 13 2017, 12:07 AM

Sep 12 2017

igorb added a comment to D37678: [GISel][x86] X86 part for D37640.

Hi Aditya,
I implemented missing functionality in https://reviews.llvm.org/rL312903
Could you please rebase.

Sep 12 2017, 11:33 PM
igorb updated the diff for D37734: [GlobalISel][X86] G_FCONSTANT support..
  • fix according to comments
Sep 12 2017, 7:07 AM
igorb created D37734: [GlobalISel][X86] G_FCONSTANT support..
Sep 12 2017, 2:33 AM

Sep 11 2017

igorb added inline comments to D34816: [GlobalISel][X86] support G_FPEXT operation..
Sep 11 2017, 6:52 AM
igorb updated the diff for D34816: [GlobalISel][X86] support G_FPEXT operation..
  • fix according to comments and rebase
Sep 11 2017, 6:50 AM
igorb added a comment to D37640: [GISel]: Fix generation of illegal COPYs (of different sizes) during CallLowering .

X86 backend part - https://reviews.llvm.org/D37678
Could you please merge into you patch.
Regards.

Sep 11 2017, 3:15 AM
igorb created D37678: [GISel][x86] X86 part for D37640.
Sep 11 2017, 3:09 AM
igorb updated the diff for D37675: [GlobalISel][X86] G_ANYEXT support..
  • fix copy - paste
Sep 11 2017, 12:51 AM
igorb created D37675: [GlobalISel][X86] G_ANYEXT support..
Sep 11 2017, 12:46 AM

Sep 10 2017

igorb accepted D37670: AVX-512: Fixed a bug in Scatter scheduling.

LGTM

Sep 10 2017, 7:13 AM

Aug 30 2017

igorb accepted D36854: [AVX512] Don't use 32-bit elements version of AND/OR/XOR/ANDN during isel unless we're matching a masked op or broadcast.

LGTM

Aug 30 2017, 7:21 AM
igorb updated the diff for D37261: [GlobalISel][X86] Support variadic function call..
  • fix according to comments
Aug 30 2017, 6:35 AM
igorb accepted D37092: [AVX512] Use 256-bit extract instructions for extracting bits [255:128] from a 512-bit register.

LGTM

Aug 30 2017, 12:09 AM

Aug 29 2017

igorb accepted D37258: [X86][Skylake] Fixing duplicated prefixes in the run command of Code Gen regression tests.

LGTM

Aug 29 2017, 11:44 PM
igorb created D37261: [GlobalISel][X86] Support variadic function call..
Aug 29 2017, 4:52 AM

Aug 23 2017

igorb updated the diff for D36733: [GlobalISel][X86] Support G_IMPLICIT_DEF..
  • rebase
Aug 23 2017, 11:58 PM

Aug 21 2017

igorb updated the diff for D34754: [GlobalISel][X86] Support G_BRCOND operation..
  • rebase
Aug 21 2017, 2:34 AM

Aug 20 2017

igorb updated the diff for D34602: [GlobalISel][X86] Support call ABI..
  • rebase.
Aug 20 2017, 2:07 AM

Aug 17 2017

igorb accepted D36661: [AVX512] Don't switch unmasked subvector insert/extract instructions when AVX512DQI is enabled..

LGTM ,
Could you please make sure that tests cover the masked version of the instructions with DQI.

Aug 17 2017, 2:55 AM

Aug 15 2017

igorb created D36733: [GlobalISel][X86] Support G_IMPLICIT_DEF..
Aug 15 2017, 4:55 AM
igorb added a comment to D34978: [GlobalIsel] fix undefined behavior if Action not set..

ping

Aug 15 2017, 2:25 AM

Jul 16 2017

igorb added inline comments to D34602: [GlobalISel][X86] Support call ABI..
Jul 16 2017, 7:01 AM
igorb updated the diff for D34602: [GlobalISel][X86] Support call ABI..
  • Fix according to comments and rebase.
Jul 16 2017, 7:00 AM

Jul 11 2017

igorb added a comment to D34978: [GlobalIsel] fix undefined behavior if Action not set..

ping

Jul 11 2017, 8:37 AM

Jul 10 2017

igorb added a comment to D34602: [GlobalISel][X86] Support call ABI..

ping

Jul 10 2017, 3:53 AM
igorb added inline comments to D35178: [GlobalISel][X86] Support G_LOAD/G_STORE i1..
Jul 10 2017, 12:39 AM

Jul 9 2017

igorb created D35178: [GlobalISel][X86] Support G_LOAD/G_STORE i1..
Jul 9 2017, 6:14 AM
igorb accepted D35161: [X86] Improve the unknown stepping support for Intel CPUs in getHostCPUName.

LGTM

Jul 9 2017, 6:14 AM
igorb retitled D35177: [GlobalISel][X86] extend G_ZEXT support. from [GlobalISel][X86] extend G_ZEXT support Mark G_ZEXT/G_SEXT i1 to i8/i16, i8 to i16 as legal. Support G_ZEXT i1 to i8/i16 instruction selection ( C++ code) This patch requred to support G_LOAD/G_STORE i1. to [GlobalISel][X86] extend G_ZEXT support..
Jul 9 2017, 6:14 AM
igorb created D35177: [GlobalISel][X86] extend G_ZEXT support..
Jul 9 2017, 6:14 AM

Jul 6 2017

igorb added inline comments to D34602: [GlobalISel][X86] Support call ABI..
Jul 6 2017, 6:25 AM
igorb updated the diff for D34602: [GlobalISel][X86] Support call ABI..
  • Fix according to comments and rebase.
Jul 6 2017, 6:24 AM
igorb added a reviewer for D34438: [FastISel] fix a fallback diagnostic.: ab.
Jul 6 2017, 12:59 AM
igorb updated the diff for D34438: [FastISel] fix a fallback diagnostic..
  • add tests. Thanks.
Jul 6 2017, 12:58 AM

Jul 4 2017

igorb added a comment to D34978: [GlobalIsel] fix undefined behavior if Action not set..

Hi Igor,

Would it be possible to add a regression test for this?
I'm wondering when this fails today. I guess it must be when the target has specified an action for e.g. TypeIdx 0, but not TypeIdx 1?
I'm just trying to understand if this should be an assert (if a target hasn't specified something fully enough) or an if statement.

Thanks,

Kristof

Jul 4 2017, 5:24 AM
igorb created D34978: [GlobalIsel] fix undefined behavior if Action not set..
Jul 4 2017, 4:15 AM
igorb created D34975: [GlobalIsel] allow x86_fp80 values to be dumped..
Jul 4 2017, 12:52 AM

Jul 3 2017

igorb added inline comments to D34602: [GlobalISel][X86] Support call ABI..
Jul 3 2017, 11:55 AM

Jul 2 2017

igorb updated the diff for D34602: [GlobalISel][X86] Support call ABI..
  • Fix according to comments
  • rebase ToT
Jul 2 2017, 6:14 AM
igorb updated the diff for D33665: [GlobalISel][X86] Support vector type G_UNMERGE_VALUES selection..
  • reabse
  • Thanks for the review!
Jul 2 2017, 1:04 AM
igorb added a comment to D34602: [GlobalISel][X86] Support call ABI..

ping

Jul 2 2017, 12:16 AM

Jun 30 2017

igorb added a comment to D34438: [FastISel] fix a fallback diagnostic..

ping

Jun 30 2017, 10:34 AM

Jun 29 2017

igorb created D34816: [GlobalISel][X86] support G_FPEXT operation..
Jun 29 2017, 9:28 AM
igorb accepted D34807: [Clang][X86][Goldmont] Adding new target-cpu: Goldmont.

LGTM

Jun 29 2017, 6:19 AM
igorb updated the diff for D33958: [GlobalISel][X86] Support vector type G_MERGE_VALUES selection..
  • - rebase
Jun 29 2017, 2:41 AM
igorb added inline comments to D34807: [Clang][X86][Goldmont] Adding new target-cpu: Goldmont.
Jun 29 2017, 1:27 AM

Jun 28 2017

igorb created D34754: [GlobalISel][X86] Support G_BRCOND operation..
Jun 28 2017, 7:53 AM
igorb added a comment to D34504: [LLVM][X86][Goldmont] Adding new target-cpu: Goldmont.

LGTM, but maybe wait for another ok before committing.

Jun 28 2017, 4:49 AM
igorb added inline comments to D34605: [GlobalISel][X86] Support bitwise operations : G_AND, G_OR, G_XOR.
Jun 28 2017, 4:11 AM

Jun 27 2017

igorb created D34738: [GlobalISel][X86] Support G_GLOBAL_VALUE operation..
Jun 27 2017, 11:45 PM