Page MenuHomePhabricator
Feed Advanced Search

Nov 25 2021

jessesna added a comment to D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks.

Thanks a lot for your time and help @MyDeveloperDay

Nov 25 2021, 11:59 AM · Restricted Project, Restricted Project
jessesna added a comment to D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks.

Great. Thanks a lot. It's Jesses Gott and jesses.gott.na+llvm@gmail.com

Nov 25 2021, 10:06 AM · Restricted Project, Restricted Project
jessesna added a comment to D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks.

Thank you for the patch, Do you need help committing this? if so we need your name and email address to do so

https://llvm.org/docs/DeveloperPolicy.html#commit-messages

Nov 25 2021, 7:22 AM · Restricted Project, Restricted Project

Nov 24 2021

jessesna added a comment to D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks.

Ok now I'm a little puzzled, shouldn't this be covered by AllowShortIfStatementsOnASingleLine?

Nov 24 2021, 8:59 AM · Restricted Project, Restricted Project

Nov 22 2021

jessesna updated the diff for D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks.

use the more dense "verifyFormat(after,Style)" calls

Nov 22 2021, 10:08 AM · Restricted Project, Restricted Project
jessesna updated the diff for D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks.

use verifyFormat instead of EXPECT_EQ (as this does some extra stuff to ensure its stable)

Nov 22 2021, 8:18 AM · Restricted Project, Restricted Project

Nov 20 2021

jessesna requested review of D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks.
Nov 20 2021, 12:06 PM · Restricted Project, Restricted Project