Page MenuHomePhabricator
Feed Advanced Search

Feb 23 2022

iannisdezwart added a comment to D119077: clangd SemanticHighlighting: added support for highlighting overloaded operators.

Thank you for the comment, it's very helpful.

Feb 23 2022, 1:38 AM · Restricted Project, Restricted Project

Feb 17 2022

iannisdezwart requested review of D119077: clangd SemanticHighlighting: added support for highlighting overloaded operators.

Would be nice if this can further be reviewed and commited to the repo!

Feb 17 2022, 6:08 AM · Restricted Project, Restricted Project

Feb 7 2022

iannisdezwart updated the diff for D119077: clangd SemanticHighlighting: added support for highlighting overloaded operators.

Fixed formatting & reverted a deleted FIXME comment.

Feb 7 2022, 7:09 AM · Restricted Project, Restricted Project
iannisdezwart accepted D119077: clangd SemanticHighlighting: added support for highlighting overloaded operators.

I haven't looked at the patch in detail, but one high level question: have you considered the possibility of adding these highlightings during the findExplicitReferences phase, rather than in CollectExtraHighlightings? (I haven't thought through whether that would work, just wondering if you have. The reason this is worth asking is that if we can get findExplicitReferences to handle overloaded operator calls, other clangd features that use findExplicitReferences would benefit from knowing about such calls as well.)

Feb 7 2022, 6:25 AM · Restricted Project, Restricted Project
iannisdezwart updated the diff for D119077: clangd SemanticHighlighting: added support for highlighting overloaded operators.

Two changes:

  1. Added tests for overloaded operators into SemanticHighlightingTests.
  2. Fixed the way tokens are expanded. Previously operator<< would be split into two highlighting tokens: operator and <<. Now it's all one highlighting token. The same is true for all other compound operator keyword statements.
Feb 7 2022, 6:17 AM · Restricted Project, Restricted Project

Feb 6 2022

iannisdezwart updated the diff for D119077: clangd SemanticHighlighting: added support for highlighting overloaded operators.

Fixed a bug I introduced by removing a null-check. I added the null-check back in again.

Feb 6 2022, 6:10 AM · Restricted Project, Restricted Project
iannisdezwart requested review of D119077: clangd SemanticHighlighting: added support for highlighting overloaded operators.
Feb 6 2022, 5:54 AM · Restricted Project, Restricted Project