Page MenuHomePhabricator
Feed Advanced Search

Fri, Nov 15

Bigcheese updated the summary of D70351: [clang][WIP][clang-scan-deps] Add an experimental C API..
Fri, Nov 15, 5:53 PM · Restricted Project, Restricted Project
Bigcheese added a parent revision for D70351: [clang][WIP][clang-scan-deps] Add an experimental C API.: D70268: [clang][clang-scan-deps] Aggregate the full dependency information..
Fri, Nov 15, 5:44 PM · Restricted Project, Restricted Project
Bigcheese created D70351: [clang][WIP][clang-scan-deps] Add an experimental C API..
Fri, Nov 15, 5:44 PM · Restricted Project, Restricted Project
Bigcheese added a child revision for D70268: [clang][clang-scan-deps] Aggregate the full dependency information.: D70351: [clang][WIP][clang-scan-deps] Add an experimental C API..
Fri, Nov 15, 5:44 PM · Restricted Project

Thu, Nov 14

Bigcheese resigned from D2431: [lld] Registry model for Readers and Reference Kind strings.
Thu, Nov 14, 1:11 PM
Bigcheese resigned from D2225: [InputGraph][Gnu] Add Linkerscript support. .
Thu, Nov 14, 1:11 PM
Bigcheese abandoned D12545: [elf2] Add basic archive file support..
Thu, Nov 14, 1:11 PM
Bigcheese abandoned D664: [lld][Driver] Parallelize reading initial object files..
Thu, Nov 14, 1:11 PM
Bigcheese abandoned D13275: [lld][elf2] Sort output sections..
Thu, Nov 14, 1:11 PM
Bigcheese abandoned D3353: [Headers] Improve codegen for _mm_slli_epi32..
Thu, Nov 14, 1:11 PM
Bigcheese abandoned D13615: [lld][elf2] Local Dynamic TLS.
Thu, Nov 14, 1:11 PM
Bigcheese abandoned D697: [lld][ELF] Initialize readers and writers on creation..
Thu, Nov 14, 1:11 PM
Bigcheese abandoned D1332: [lld] Update to LLVM ELFFile changes..
Thu, Nov 14, 1:11 PM
Bigcheese abandoned D540: [clang][Driver] Nativize paths when emitting crash diagnostics..
Thu, Nov 14, 1:11 PM
Bigcheese added reviewers for D70268: [clang][clang-scan-deps] Aggregate the full dependency information.: arphaman, kousikk.
Thu, Nov 14, 1:02 PM · Restricted Project
Bigcheese created D70268: [clang][clang-scan-deps] Aggregate the full dependency information..
Thu, Nov 14, 1:02 PM · Restricted Project

Wed, Nov 13

Bigcheese accepted D69122: Add support to find out resource dir and add it as compilation args.

lgtm with the changes to FindResourceDir.

Wed, Nov 13, 4:04 PM · Restricted Project
Bigcheese accepted D69958: Improve VFS compatibility on Windows.

lgtm. Looking at the blame it would be best if @JDevlieghere @vsapsai or @benlangmuir could take a look also.

Wed, Nov 13, 1:52 PM · Restricted Project, Restricted Project

Thu, Oct 31

Bigcheese committed rGd816d9bdc585: [clang][ScanDeps] Fix issue with multiple commands with the same input. (authored by Bigcheese).
[clang][ScanDeps] Fix issue with multiple commands with the same input.
Thu, Oct 31, 2:25 PM
Bigcheese closed D69643: [clang][ScanDeps] Fix issue with multiple commands with the same input..
Thu, Oct 31, 2:24 PM · Restricted Project

Wed, Oct 30

Bigcheese committed rG17b64e36e90a: [clang][ScanDeps] Fix shadowing warning. (authored by Bigcheese).
[clang][ScanDeps] Fix shadowing warning.
Wed, Oct 30, 3:55 PM
Bigcheese committed rG33a745e6fe7e: [clang][clang-scan-deps] Add support for extracting full module dependencies. (authored by Bigcheese).
[clang][clang-scan-deps] Add support for extracting full module dependencies.
Wed, Oct 30, 3:29 PM
Bigcheese committed rG1c88d662230e: Revert "[clang][clang-scan-deps] Add support for extracting full module… (authored by Bigcheese).
Revert "[clang][clang-scan-deps] Add support for extracting full module…
Wed, Oct 30, 3:18 PM
Bigcheese added a reverting change for rGd8a4ef0e685c: [clang][clang-scan-deps] Add support for extracting full module dependencies.: rG1c88d662230e: Revert "[clang][clang-scan-deps] Add support for extracting full module….
Wed, Oct 30, 3:18 PM
Bigcheese committed rGd8a4ef0e685c: [clang][clang-scan-deps] Add support for extracting full module dependencies. (authored by Bigcheese).
[clang][clang-scan-deps] Add support for extracting full module dependencies.
Wed, Oct 30, 2:49 PM
Bigcheese closed D69420: [clang][clang-scan-deps] Add support for extracting full module dependencies..
Wed, Oct 30, 2:49 PM · Restricted Project
Bigcheese created D69643: [clang][ScanDeps] Fix issue with multiple commands with the same input..
Wed, Oct 30, 2:21 PM · Restricted Project
Bigcheese accepted D61608: YAML parser robustness improvements.

lgtm, sorry for the delay, I didn't see the updates for some reason.

Wed, Oct 30, 2:21 PM · Restricted Project

Tue, Oct 29

Bigcheese requested changes to D69122: Add support to find out resource dir and add it as compilation args.

So I agree solving this problem makes sense, but I have some issues with the current patch.

Tue, Oct 29, 3:25 PM · Restricted Project
Bigcheese updated the diff for D69420: [clang][clang-scan-deps] Add support for extracting full module dependencies..

I forgot to clang-format.

Tue, Oct 29, 2:43 PM · Restricted Project
Bigcheese updated the diff for D69420: [clang][clang-scan-deps] Add support for extracting full module dependencies..

This fixes some issues I received externally.

Tue, Oct 29, 2:34 PM · Restricted Project

Mon, Oct 28

Bigcheese committed rGdddec1f1840b: [clang][clang-scan-deps] Add -fcxx-modules to test for Darwin. (authored by Bigcheese).
[clang][clang-scan-deps] Add -fcxx-modules to test for Darwin.
Mon, Oct 28, 5:55 PM

Fri, Oct 25

Bigcheese committed rG8da20560ab0d: [clang][DependencyScanning] 80-col. (authored by Bigcheese).
[clang][DependencyScanning] 80-col.
Fri, Oct 25, 3:44 PM
Bigcheese added inline comments to D69420: [clang][clang-scan-deps] Add support for extracting full module dependencies..
Fri, Oct 25, 3:43 PM · Restricted Project
Bigcheese updated the diff for D69420: [clang][clang-scan-deps] Add support for extracting full module dependencies..

Address review comments.

Fri, Oct 25, 3:43 PM · Restricted Project

Thu, Oct 24

Bigcheese committed rG7af309a4ed1a: [clang][DependencyScanning] clang-format. (authored by Bigcheese).
[clang][DependencyScanning] clang-format.
Thu, Oct 24, 6:31 PM
Bigcheese created D69420: [clang][clang-scan-deps] Add support for extracting full module dependencies..
Thu, Oct 24, 5:57 PM · Restricted Project
Bigcheese committed rG9ab6d8236b17: [clang-scan-deps] Add basic support for modules. (authored by Bigcheese).
[clang-scan-deps] Add basic support for modules.
Thu, Oct 24, 4:24 PM
Bigcheese closed D68835: [clang-scan-deps] Add basic support for Clang modules..
Thu, Oct 24, 4:24 PM · Restricted Project
Bigcheese added a reviewer for D69122: Add support to find out resource dir and add it as compilation args: klimek.

I've added Manuel as a reviewer as this patch is also changing the tooling APIs.

Thu, Oct 24, 11:20 AM · Restricted Project

Wed, Oct 23

Bigcheese added a reviewer for D69331: [LegacyPM] Port CGProfile pass: chandlerc.

This was originally not added to the legacy pass manager because it leaks memory under it due to fundamental issues with the old pass manager. See https://reviews.llvm.org/D48105#1140299 .

Wed, Oct 23, 2:02 PM · Restricted Project

Mon, Oct 21

Bigcheese accepted D69186: Refactor DependencyScanningTool to its own file.

LGTM with style nit. I like that this decouples DependencyScanningTool from printing the results.

Mon, Oct 21, 5:38 PM · Restricted Project
Bigcheese added a comment to D69122: Add support to find out resource dir and add it as compilation args.

The current assumption is that the clang-scan-deps binary is the one that comes next to the clang binary you are using. There are lots of other differences between clang versions than just the resource-dir.

Mon, Oct 21, 5:38 PM · Restricted Project
Bigcheese committed rG8896d073b190: [Implicit Modules] Add -cc1 option -fmodules-strict-context-hash which includes… (authored by Bigcheese).
[Implicit Modules] Add -cc1 option -fmodules-strict-context-hash which includes…
Mon, Oct 21, 3:56 PM

Oct 19 2019

Bigcheese committed rG81a01e73faab: Revert "[Implicit Modules] Add -cc1 option -fmodules-strict-context-hash which… (authored by Bigcheese).
Revert "[Implicit Modules] Add -cc1 option -fmodules-strict-context-hash which…
Oct 19 2019, 2:46 AM

Oct 18 2019

Bigcheese committed rGd7cf99ae0370: [Docs] Fix header level. (authored by Bigcheese).
[Docs] Fix header level.
Oct 18 2019, 6:52 PM
Bigcheese committed rG14a3f77ba103: [Implicit Modules] Add -cc1 option -fmodules-strict-context-hash which includes… (authored by Bigcheese).
[Implicit Modules] Add -cc1 option -fmodules-strict-context-hash which includes…
Oct 18 2019, 6:43 PM
Bigcheese closed D68528: [Implicit Modules] Add -cc1 option -fmodules-strict-hash which includes search paths and diagnostics..
Oct 18 2019, 6:42 PM · Restricted Project

Oct 17 2019

Bigcheese added a comment to D68528: [Implicit Modules] Add -cc1 option -fmodules-strict-hash which includes search paths and diagnostics..

While adding the documentation I realized that a better name for this option would be -fmodules-strict-context-hash to make it clear which hash it's referring to.

Oct 17 2019, 3:52 PM · Restricted Project

Oct 16 2019

Bigcheese updated the diff for D68528: [Implicit Modules] Add -cc1 option -fmodules-strict-hash which includes search paths and diagnostics..

Fixed spelling and updated comment.

Oct 16 2019, 4:13 PM · Restricted Project
Bigcheese updated the diff for D68835: [clang-scan-deps] Add basic support for Clang modules..

Added .i, .ii, .mi, and .mmi as files to minimize.

Oct 16 2019, 2:57 PM · Restricted Project
Bigcheese accepted D69017: Include sanitize blacklist and other extra deps as part of scan-deps output.

lgtm. Jan may want to take a look as I believe he was looking at a related issue.

Oct 16 2019, 10:46 AM · Restricted Project

Oct 14 2019

Bigcheese committed rG9585d8c11a57: [Modules Build] Add missing dependency. (authored by Bigcheese).
[Modules Build] Add missing dependency.
Oct 14 2019, 3:00 PM
Bigcheese added inline comments to D68528: [Implicit Modules] Add -cc1 option -fmodules-strict-hash which includes search paths and diagnostics..
Oct 14 2019, 1:53 PM · Restricted Project

Oct 10 2019

Bigcheese updated the diff for D68835: [clang-scan-deps] Add basic support for Clang modules..

Addressed review comments.

Oct 10 2019, 5:31 PM · Restricted Project
Bigcheese created D68835: [clang-scan-deps] Add basic support for Clang modules..
Oct 10 2019, 2:43 PM · Restricted Project
Bigcheese committed rG2f56266234e5: [ScanDeps] clang-format, 80 cols. (authored by Bigcheese).
[ScanDeps] clang-format, 80 cols.
Oct 10 2019, 1:26 PM

Oct 9 2019

Bigcheese accepted D68193: In openFileForRead don't cache erroneous entries if the error relates to them being directories. Add tests..

lgtm, but wait for Alex or Duncan to also take a look.

Oct 9 2019, 6:41 PM · Restricted Project
Bigcheese added inline comments to D68193: In openFileForRead don't cache erroneous entries if the error relates to them being directories. Add tests..
Oct 9 2019, 6:32 PM · Restricted Project
Bigcheese added a comment to D68193: In openFileForRead don't cache erroneous entries if the error relates to them being directories. Add tests..

@arphaman I don't mind changing this if there are race conditions as you say, but isn't the assumption of the tool that the filesystem remains unchanged for a single run of the tool? If so, should we actually throw error conditions instead of crashing in those cases?

Oct 9 2019, 2:31 PM · Restricted Project

Oct 4 2019

Bigcheese updated the diff for D68528: [Implicit Modules] Add -cc1 option -fmodules-strict-hash which includes search paths and diagnostics..

Add diagnostics.

Oct 4 2019, 5:33 PM · Restricted Project
Bigcheese created D68528: [Implicit Modules] Add -cc1 option -fmodules-strict-hash which includes search paths and diagnostics..
Oct 4 2019, 4:58 PM · Restricted Project
Bigcheese added a comment to D67696: [tools] Mark output of tools as text if it is really text.

Do we really want to output \r\n on Windows? There is all of one program (notepad.exe) that doesn't support \n on Windows.

Oct 4 2019, 12:20 AM · Restricted Project

Sep 27 2019

Bigcheese accepted D46228: [ELF] Use union-find set and doubly linked list in Call-Chain Clustering (C³) heuristic.

lgtm

Sep 27 2019, 10:39 AM · Restricted Project

Sep 26 2019

Bigcheese added inline comments to D68073: Propeller code layout optimizations.
Sep 26 2019, 5:41 PM · Restricted Project

Sep 11 2019

Bigcheese accepted D67127: [clang-scan-deps] add skip excluded conditional preprocessor block preprocessing optimization .
Sep 11 2019, 1:05 PM · Restricted Project, Restricted Project

Sep 5 2019

Bigcheese added a comment to D61608: YAML parser robustness improvements.

Also, please use -U999999 for patches so there's full context.

Sep 5 2019, 2:31 PM · Restricted Project
Bigcheese added inline comments to D61608: YAML parser robustness improvements.
Sep 5 2019, 2:29 PM · Restricted Project

Sep 4 2019

Bigcheese added a comment to D67127: [clang-scan-deps] add skip excluded conditional preprocessor block preprocessing optimization .

Looking more into this I'm not sure you need the PPCallbacks. The Preprocessor should just own the PreprocessorSkippedMappings data structure and the dependency scanner can update it live.

Sep 4 2019, 1:56 PM · Restricted Project, Restricted Project

Sep 3 2019

Bigcheese added inline comments to D67127: [clang-scan-deps] add skip excluded conditional preprocessor block preprocessing optimization .
Sep 3 2019, 5:20 PM · Restricted Project, Restricted Project

Aug 30 2019

Bigcheese accepted D66989: FileManager: Remove ShouldCloseOpenFile argument from getBufferForFile, NFC.

lgtm

Aug 30 2019, 9:34 AM

Aug 21 2019

Bigcheese accepted D65907: Introduce FileEntryRef and use it when handling includes to report correct dependencies when the FileManager is reused across invocations.
Aug 21 2019, 2:02 PM · Restricted Project, Restricted Project

Aug 15 2019

Bigcheese requested changes to D65907: Introduce FileEntryRef and use it when handling includes to report correct dependencies when the FileManager is reused across invocations.
Aug 15 2019, 3:56 PM · Restricted Project, Restricted Project

Aug 14 2019

Bigcheese added inline comments to D65907: Introduce FileEntryRef and use it when handling includes to report correct dependencies when the FileManager is reused across invocations.
Aug 14 2019, 4:29 PM · Restricted Project, Restricted Project

Aug 13 2019

Bigcheese added inline comments to D66172: [clang][Modules] Serialize decl to comment mapping to speed up code completion..
Aug 13 2019, 3:04 PM

Aug 9 2019

Bigcheese added a comment to D65986: Allow setting the VFS to 'real' mode instead of default 'physical'.

This fix works, but we could also use openat to get around max path length issues. Windows also has an API that can be used similarly.

Aug 9 2019, 10:26 AM · Restricted Project

Aug 8 2019

Bigcheese committed rG1861f4ea2584: [clang-scan-deps] Add minimizer support for C++20 modules. (authored by Bigcheese).
[clang-scan-deps] Add minimizer support for C++20 modules.
Aug 8 2019, 7:03 PM
Bigcheese closed D65989: [clang-scan-deps] Add minimizer support for C++20 modules..

Fixed and committed as r368381.

Aug 8 2019, 7:03 PM · Restricted Project
Bigcheese created D65989: [clang-scan-deps] Add minimizer support for C++20 modules..
Aug 8 2019, 6:45 PM · Restricted Project

Aug 7 2019

Bigcheese added a comment to D65493: Modernize atomic detection and usage.

This looks like a good simplification, but I think call_once could be simplified more.

Aug 7 2019, 6:21 PM · Restricted Project, Restricted Project, Restricted Project

Jul 31 2019

Bigcheese committed rG33703fb9f908: [clang][ARM] Fix msvc arm{64} builtins to use int on LP64 systems. (authored by Bigcheese).
[clang][ARM] Fix msvc arm{64} builtins to use int on LP64 systems.
Jul 31 2019, 1:46 PM

Jul 11 2019

Bigcheese accepted D64191: [libcxxabi] Don't process exceptions in cxa_handlers when they're disabled.

looks good. @ldionne are you happy with the changes?

Jul 11 2019, 2:53 PM · Restricted Project

Jul 10 2019

Bigcheese added a comment to D64191: [libcxxabi] Don't process exceptions in cxa_handlers when they're disabled.

FYIe, you can also prevent this symbol to be linked in by putting a cxa_demangle function in an obj file that gets linked first, like so: https://cs.chromium.org/chromium/src/third_party/android_crazy_linker/src/src/crazy_linker_wrappers.cpp?type=cs&q=cxa_demangle+file:android&sq=package:chromium&g=0&l=54 – but I agree that since cxa_demangle is so large, it'd be nice if the upstream version was behind some kind of define. Then we could set that and remove that hack in chromium too. I don't have an opinion on if that should be a new define or if _LIBCXXABI_NO_EXCEPTIONS should be reused. Actually, I think we build libcxxabi with exceptions enabled because some of our test code can in theory throw exceptions, but we have an external dumper so we don't need the stack from terminate() – so it'd be somewhat more convenient for us if we could turn off the stack from terminate() (and the pulling in of __cxa_demangle) while still being able to build without setting _LIBCXXABI_NO_EXCEPTIONS.

Jul 10 2019, 6:48 PM · Restricted Project
Bigcheese accepted D64191: [libcxxabi] Don't process exceptions in cxa_handlers when they're disabled.

_LIBCXXABI_NO_EXCEPTIONS removes the exceptions abi from libc++abi, so I think this change as fine as __cxa_throw isn't even defined if _LIBCXXABI_NO_EXCEPTIONS is defined.

Jul 10 2019, 6:43 PM · Restricted Project
Bigcheese accepted D64525: [clang-scan-deps] Dependency directives source minimizer: single quotes are not digit separators after a valid character literal prefix.
Jul 10 2019, 1:02 PM · Restricted Project, Restricted Project
Bigcheese added inline comments to D64525: [clang-scan-deps] Dependency directives source minimizer: single quotes are not digit separators after a valid character literal prefix.
Jul 10 2019, 12:37 PM · Restricted Project, Restricted Project

Jul 3 2019

Bigcheese retitled D64164: [clang][ARM] Fix msvc arm{64} builtins to use int on LP64 systems. from [clang][ARM] Fix msvc arm{64} builtins to use int on LLP64 systems. to [clang][ARM] Fix msvc arm{64} builtins to use int on LP64 systems..
Jul 3 2019, 5:45 PM · Restricted Project, Restricted Project
Bigcheese added a comment to D64164: [clang][ARM] Fix msvc arm{64} builtins to use int on LP64 systems..
In D64164#1569679, @rnk wrote:

Please check the commit message:

[clang][ARM] Fix msvc arm{64} builtins to use int on LLP64 systems.

I think you mean "use int on LP64 systems", since long is 32-bits on LLP64, right?

Otherwise, sounds good.

Jul 3 2019, 5:45 PM · Restricted Project, Restricted Project
Bigcheese added a comment to D64164: [clang][ARM] Fix msvc arm{64} builtins to use int on LP64 systems..

Do the changes to BuiltinsARM.def have any practical effect? long should be 32 bits on all 32-bit ARM targets.

Jul 3 2019, 4:34 PM · Restricted Project, Restricted Project
Bigcheese updated the summary of D64164: [clang][ARM] Fix msvc arm{64} builtins to use int on LP64 systems..
Jul 3 2019, 4:03 PM · Restricted Project, Restricted Project
Bigcheese created D64164: [clang][ARM] Fix msvc arm{64} builtins to use int on LP64 systems..
Jul 3 2019, 3:55 PM · Restricted Project, Restricted Project
Bigcheese accepted D64149: [clang-scan-deps] use `-Wno-error` when scanning for dependencies.

LGTM

Jul 3 2019, 10:56 AM · Restricted Project, Restricted Project
Bigcheese added a reviewer for D64146: [Clang Interpreter] Initial patch for the constexpr interpreter: Bigcheese.
Jul 3 2019, 10:36 AM · Restricted Project, Restricted Project

Jun 25 2019

Bigcheese added inline comments to D63518: BitStream reader: propagate errors.
Jun 25 2019, 2:21 PM · Restricted Project, Restricted Project

Jun 17 2019

Bigcheese added a comment to D63453: [Support] Move llvm::MemoryBuffer to sys::fs::file_t.

Where do you want to keep these open? The default OS limit on open files for OSX is 256.

Jun 17 2019, 6:12 PM · Restricted Project
Bigcheese updated subscribers of D63388: WIP: experimenting with EH optimizations.

Also adding the llvm-commits list.

Jun 17 2019, 1:28 PM
Bigcheese added reviewers for D63388: WIP: experimenting with EH optimizations: rnk, chandlerc, zturner.

Thanks a lot for working on this. There's a lot of room to improve the performance of exceptions that nobody has done for C++ yet. I've added some reviewers that I'm aware are familiar with the area or that I've talked with about this before.

Jun 17 2019, 1:27 PM

Jun 10 2019

Bigcheese accepted D63101: [Frontend] SetUpDiagnosticLog should handle unowned diagnostic consumer in the compiler.

LGTM

Jun 10 2019, 3:33 PM · Restricted Project

May 31 2019

Bigcheese added a reviewer for D62711: [MACHO] Replaced calls to getStruct with getStructOrErr in functions returning Error or Expected or similar: lhames.

It would be nice to get tests for these cases, although I realize that can be difficult as it requires malformed inputs.

May 31 2019, 10:54 AM · Restricted Project

May 29 2019

Bigcheese requested changes to D61608: YAML parser robustness improvements.

Thanks for finding this!

May 29 2019, 3:39 PM · Restricted Project