Page MenuHomePhabricator
Feed Advanced Search

Aug 30 2020

ilya-nozhkin added a comment to D86652: [lldb] Fix ProcessEventData::DoOnRemoval to support multiple listeners.

I've realized that I just didn't know about stop hooks... So, sorry and thanks, it solves almost all my problems except for notifying about "resume" events which are important for me too. But I can use synchronous Process::Notifications to receive them (I couldn't use Notifications to receive stop events because they are sent before the public state is changed by DoOnRemoval). But then I thought why don't we just move SynchronouslyNotifyStateChanged invocation from ShouldBroadcastEvent to DoOnRemoval? It would provide the most convenient way of receiving process events without intersections with the primary listener. I can make these changes in another patch instead of this one.

Aug 30 2020, 1:05 PM · Restricted Project

Aug 27 2020

ilya-nozhkin added a comment to D86652: [lldb] Fix ProcessEventData::DoOnRemoval to support multiple listeners.

Yeah, I understand the problem of two listeners trying to change process state simultaneously and I agree that informing other listeners once the primary one finished its job would be a great solution. But the problem is that primary listener just provides an event to some user code (via GetEvent) and there is no way to find out when this code has finished without requiring it to invoke a handshake explicitly.

Aug 27 2020, 11:50 AM · Restricted Project

Aug 26 2020

ilya-nozhkin requested review of D86652: [lldb] Fix ProcessEventData::DoOnRemoval to support multiple listeners.
Aug 26 2020, 12:24 PM · Restricted Project