Page MenuHomePhabricator
Feed Advanced Search

May 25 2018

gramanas updated the summary of D47097: [DebugInfo] Preserve scope in auto generated StoreInst.
May 25 2018, 5:13 AM
gramanas updated the diff for D47097: [DebugInfo] Preserve scope in auto generated StoreInst.

I added a test that illustrates what @vsk is talking about.

May 25 2018, 5:04 AM

May 24 2018

gramanas added a comment to D47097: [DebugInfo] Preserve scope in auto generated StoreInst.

Can we step back a second and better explain what the problem is? With current Clang the debug info for this function looks okay to me.
The store that is "missing" a debug location is homing the formal parameter to its local stack location; this is part of prolog setup, not "real" code.

May 24 2018, 9:38 AM
gramanas updated the diff for D47097: [DebugInfo] Preserve scope in auto generated StoreInst.

Adress review comments.
Limit changes to the storeInst

May 24 2018, 7:48 AM

May 23 2018

gramanas updated the diff for D47097: [DebugInfo] Preserve scope in auto generated StoreInst.

Remove redundant this

May 23 2018, 6:29 AM
gramanas updated the diff for D47097: [DebugInfo] Preserve scope in auto generated StoreInst.

Set debug location to the entry block alloca

May 23 2018, 6:22 AM
gramanas added a comment to D47161: update.

It was a mistake on my part with the arcanist tool. The documentation is fine, the only problems I encountered were due to my ignorance of how these systems work.

May 23 2018, 6:05 AM

May 22 2018

gramanas updated the diff for D47097: [DebugInfo] Preserve scope in auto generated StoreInst.

Move ApplyDebugLocation before CreateMemTemp

May 22 2018, 9:56 AM
gramanas abandoned D47161: update.

Duplicate of https://reviews.llvm.org/D47097

May 22 2018, 8:58 AM

May 21 2018

gramanas updated the diff for D47097: [DebugInfo] Preserve scope in auto generated StoreInst.

Update diff

May 21 2018, 2:44 PM
gramanas created D47161: update.
May 21 2018, 1:59 PM
gramanas retitled D47097: [DebugInfo] Preserve scope in auto generated StoreInst from [WIP][DebugInfo] Preserve scope in auto generated StoreInst to [DebugInfo] Preserve scope in auto generated StoreInst.
May 21 2018, 1:58 PM
gramanas updated the diff for D47097: [DebugInfo] Preserve scope in auto generated StoreInst.

Update according to the comments

May 21 2018, 12:43 PM
gramanas updated the diff for D47097: [DebugInfo] Preserve scope in auto generated StoreInst.
  • Apply debug location
May 21 2018, 12:40 PM

May 18 2018

gramanas created D47097: [DebugInfo] Preserve scope in auto generated StoreInst.
May 18 2018, 5:31 PM

May 17 2018

gramanas closed D46941: [Debugify] Print errors and warnings to stderr.

commited r332642

May 17 2018, 11:27 AM
gramanas committed rL332642: [Debugify] Print the output to stderr.
[Debugify] Print the output to stderr
May 17 2018, 11:23 AM
gramanas updated the diff for D46941: [Debugify] Print errors and warnings to stderr.
  • ...
May 17 2018, 11:03 AM
gramanas updated the diff for D46941: [Debugify] Print errors and warnings to stderr.

fix mistake in tests

May 17 2018, 11:00 AM
gramanas updated the diff for D46941: [Debugify] Print errors and warnings to stderr.

The output of the tests should go to /dev/null

May 17 2018, 10:50 AM
gramanas updated the diff for D46941: [Debugify] Print errors and warnings to stderr.

The tests were missing the input file argument

May 17 2018, 9:58 AM
gramanas updated the summary of D46941: [Debugify] Print errors and warnings to stderr.
May 17 2018, 8:04 AM
gramanas updated the diff for D46941: [Debugify] Print errors and warnings to stderr.

Test that debugify can be safely used with piping

May 17 2018, 7:55 AM
gramanas updated the diff for D46941: [Debugify] Print errors and warnings to stderr.
  • [Debugify] All output now goes to stderr
May 17 2018, 4:16 AM

May 16 2018

gramanas added a comment to D46941: [Debugify] Print errors and warnings to stderr.

Just like llvm-lit I left the PASS or FAIL to stdout.

May 16 2018, 6:36 AM
gramanas created D46941: [Debugify] Print errors and warnings to stderr.
May 16 2018, 6:34 AM

May 15 2018

gramanas committed rL332418: [Debugify] Fix test failing after r332416.
[Debugify] Fix test failing after r332416
May 15 2018, 5:15 PM
gramanas committed rL332416: [Debugfiy] Print the pass name next to the result.
[Debugfiy] Print the pass name next to the result
May 15 2018, 4:42 PM
gramanas closed D46908: [Debugfiy][WIP] Print the pass name next to the result.
May 15 2018, 4:42 PM
gramanas added a comment to D46908: [Debugfiy][WIP] Print the pass name next to the result.

Will do, it's allready in my TODO list!

May 15 2018, 4:28 PM
gramanas updated the diff for D46908: [Debugfiy][WIP] Print the pass name next to the result.
  • Adress review comments
May 15 2018, 4:13 PM
gramanas updated the summary of D46908: [Debugfiy][WIP] Print the pass name next to the result.
May 15 2018, 3:36 PM
gramanas created D46908: [Debugfiy][WIP] Print the pass name next to the result.
May 15 2018, 3:27 PM

Mar 18 2018

gramanas added a watcher for debug-info: gramanas.
Mar 18 2018, 2:00 PM
gramanas committed rL327800: [LICM] Salvage DI from dying Instructions.
[LICM] Salvage DI from dying Instructions
Mar 18 2018, 9:02 AM

Mar 13 2018

gramanas updated the diff for D44356: [LICM] Salvage DebugInfo from dying Instructions.
  • Fix test label
Mar 13 2018, 10:02 AM · debug-info
gramanas updated the summary of D44356: [LICM] Salvage DebugInfo from dying Instructions.
Mar 13 2018, 9:02 AM · debug-info
gramanas updated the summary of D44356: [LICM] Salvage DebugInfo from dying Instructions.
Mar 13 2018, 8:18 AM · debug-info
gramanas updated the diff for D44356: [LICM] Salvage DebugInfo from dying Instructions.
  • fix redundant debugify test
Mar 13 2018, 8:11 AM · debug-info

Mar 10 2018

gramanas updated the summary of D44356: [LICM] Salvage DebugInfo from dying Instructions.
Mar 10 2018, 2:22 PM · debug-info
gramanas created D44356: [LICM] Salvage DebugInfo from dying Instructions.
Mar 10 2018, 2:13 PM · debug-info