Page MenuHomePhabricator
Feed Advanced Search

Thu, Jun 17

teemperor added a comment to D104444: [lldb] Fix complex integer type parsing for GCC.

FYI GDB does not support these complex types.
GCC discusses it as PR debug/93988.

Thu, Jun 17, 10:26 AM · Restricted Project
teemperor planned changes to D104444: [lldb] Fix complex integer type parsing for GCC.

Is this specific to GCC? To be on the safe side, would it make sense to check like type_name == "__unknown__" && compiler == GCC?

Thu, Jun 17, 6:35 AM · Restricted Project
teemperor accepted D104448: [lldb] Remove redundant calls to set eReturnStatusFailed.

LGTM now, just a small nit about the redundant "error: " string.

Thu, Jun 17, 6:28 AM · Restricted Project
teemperor requested changes to D104448: [lldb] Remove redundant calls to set eReturnStatusFailed.

There are two places where this isn't redundant (see inline comments) but otherwise this LGTM. Thanks!

Thu, Jun 17, 5:05 AM · Restricted Project
teemperor added a reviewer for D104448: [lldb] Remove redundant calls to set eReturnStatusFailed: teemperor.
Thu, Jun 17, 4:54 AM · Restricted Project
teemperor added inline comments to D103172: [lldb][NFC] Allow range-based for loops over DWARFDIE's children.
Thu, Jun 17, 3:36 AM · Restricted Project
teemperor updated the diff for D103172: [lldb][NFC] Allow range-based for loops over DWARFDIE's children.
  • Added a unit test (thanks Shafik!)
Thu, Jun 17, 3:34 AM · Restricted Project
teemperor added a reviewer for D104444: [lldb] Fix complex integer type parsing for GCC: werat.
Thu, Jun 17, 2:34 AM · Restricted Project
teemperor requested review of D104444: [lldb] Fix complex integer type parsing for GCC.
Thu, Jun 17, 2:33 AM · Restricted Project
teemperor requested changes to D104437: Add test for functions with extended characters..

Thanks for writing tests, it's really appreciated! FWIW, I think that you can just check in new tests without having to go through a full review (unless you do want feedback for it).

Thu, Jun 17, 1:52 AM · Restricted Project
teemperor committed rG25fa67868b36: [lldb] Skip variant/optional libc++ tests for Clang 5/6 (authored by teemperor).
[lldb] Skip variant/optional libc++ tests for Clang 5/6
Thu, Jun 17, 12:54 AM

Wed, Jun 16

teemperor accepted D104379: [lldb] Remove redundant calls to set eReturnStatusFailed.

LGTM and passes on macOS and Linux for me. Thanks!

Wed, Jun 16, 8:30 AM · Restricted Project
teemperor accepted D104380: [lldb] Set return object failed status even if error string is empty.

At least on the test suite on Linux that branch is anyway never taken, so LGTM. Thanks!

Wed, Jun 16, 8:24 AM · Restricted Project
teemperor added a comment to D104377: [lldb] Don't try to set -Wno-deprecated-declarations.

There is some cleanup that needs to be done before this can land. https://reviews.llvm.org/D104374 fixes some deprecation warnings from Python and there are some macOS APIs that got deprecated (which I still need to fix)

Wed, Jun 16, 6:32 AM · Restricted Project
teemperor requested review of D104377: [lldb] Don't try to set -Wno-deprecated-declarations.
Wed, Jun 16, 6:30 AM · Restricted Project
teemperor requested review of D104375: [lldb] Don't try to set -Wno-deprecated-register.
Wed, Jun 16, 6:26 AM · Restricted Project
teemperor requested review of D104374: [lldb] Rework the Python threading initialization.
Wed, Jun 16, 6:19 AM · Restricted Project
teemperor committed rG59d58863bc0e: [lldb] Require Clang 8 for gpubnames test (authored by teemperor).
[lldb] Require Clang 8 for gpubnames test
Wed, Jun 16, 5:07 AM
teemperor committed rG3b7795aeceb1: [lldb] vwprintw -> vw_printw in IOHandlerCursesGUI (authored by teemperor).
[lldb] vwprintw -> vw_printw in IOHandlerCursesGUI
Wed, Jun 16, 4:14 AM

Tue, Jun 15

teemperor committed rGb8567559cf38: [lldb] Make the ClassTemplateDecl merging logic in TypeSystemClang respect… (authored by teemperor).
[lldb] Make the ClassTemplateDecl merging logic in TypeSystemClang respect…
Tue, Jun 15, 10:25 AM
teemperor closed D100662: [lldb] Make the ClassTemplateDecl merging logic in TypeSystemClang respect template parameters.
Tue, Jun 15, 10:25 AM · Restricted Project
teemperor updated the diff for D100662: [lldb] Make the ClassTemplateDecl merging logic in TypeSystemClang respect template parameters.
  • assert -> lldbassert
Tue, Jun 15, 9:46 AM · Restricted Project
teemperor added a comment to D104281: [lldb][docs] Add reference docs for Lua scripting.

In fact, the same idea also occurred to me before. I think it's also achievable by a plugin sphinx-code-tabs.

Tue, Jun 15, 9:42 AM · Restricted Project
teemperor requested review of D104307: [lldb] Remove SBHostOS threading functionality.
Tue, Jun 15, 9:36 AM
teemperor accepted D104283: [lldb] Fix libstdc++ 11's std::unique_ptr affecting LLDB testsuite TestDataFormatterStdUniquePtr.py.

Personally I think if there is the pointer (and sizeof(std::unique_ptr<XXX, YYY> == 16) there should be the "deleter =" specified even if it is default deleter.

Tue, Jun 15, 2:13 AM · Restricted Project
teemperor requested changes to D104283: [lldb] Fix libstdc++ 11's std::unique_ptr affecting LLDB testsuite TestDataFormatterStdUniquePtr.py.

I think the way the provider is supposed to work is that there is always deleter child as long as it's not default_delete<T>, so I think we have to check for the name to avoid that we also hide an empty user-specified deleter.

Tue, Jun 15, 12:44 AM · Restricted Project

Mon, Jun 14

teemperor added a comment to D104281: [lldb][docs] Add reference docs for Lua scripting.

Instead of copying the text from the Python page, I was actually thinking whether we should make the 'scripting' page more generic and just add the language-specific examples for Python and Lua there. I am not sure what's the best way to do that visually though with RST. We could just go for raw HTML and use a tab switcher like this:

Mon, Jun 14, 11:46 PM · Restricted Project
teemperor added a reviewer for D104281: [lldb][docs] Add reference docs for Lua scripting: JDevlieghere.
Mon, Jun 14, 10:54 PM · Restricted Project
teemperor added a comment to D104231: [lldb] Deprecate the threading functionality in SBHostOS.

Not sure what else we should do to properly deprecate an API. LLVM's approach would be to put [[deprecated("bla")]] the C++ APIs (which would mean you need a C++14 compiler to use the SB API) and there is also the lldb-versioning.h header (which seems to be reserved for actual API breakages).

Mon, Jun 14, 8:22 AM · Restricted Project
teemperor updated the diff for D104231: [lldb] Deprecate the threading functionality in SBHostOS.
  • Remove the deprecation attribute that got inserted by accident.
Mon, Jun 14, 8:16 AM · Restricted Project
teemperor requested review of D104231: [lldb] Deprecate the threading functionality in SBHostOS.
Mon, Jun 14, 8:14 AM · Restricted Project
teemperor committed rGd94ce1a391cb: [lldb][docs] Add the missing rst anchors to the Python enum docs (authored by teemperor).
[lldb][docs] Add the missing rst anchors to the Python enum docs
Mon, Jun 14, 7:32 AM
teemperor committed rGe3d5e3193fd5: [lldb][docs] Fix section name for InputReaderGranularity (authored by teemperor).
[lldb][docs] Fix section name for InputReaderGranularity
Mon, Jun 14, 7:22 AM
teemperor requested review of D104221: [lldb][NFC] Remove redundant deleted constructors in HostInfoBase subclasses.
Mon, Jun 14, 5:59 AM · Restricted Project
teemperor committed rG11e2922bb7ad: [lldb][docs] Document SBType (authored by teemperor).
[lldb][docs] Document SBType
Mon, Jun 14, 4:20 AM
teemperor closed D103454: [lldb][docs] Document SBType.
Mon, Jun 14, 4:19 AM · Restricted Project
teemperor updated the diff for D103454: [lldb][docs] Document SBType.
  • Make language more uniform
  • Point out anonymous struct is a GNU extension.
Mon, Jun 14, 4:02 AM · Restricted Project
teemperor accepted D104041: [lldb] Replace default bodies of special member functions with = default;.

Not sure what happened to my accept, but I'll LGTM this again. Thanks!

Mon, Jun 14, 3:14 AM

Fri, Jun 11

teemperor committed rG60fde9542aac: [lldb] Remove GCC XFAIL for TestCPPAuto and TestClassTemplateParameterPack (authored by teemperor).
[lldb] Remove GCC XFAIL for TestCPPAuto and TestClassTemplateParameterPack
Fri, Jun 11, 2:22 PM
teemperor added a comment to D103675: [LLDB/API] Expose args and env from SBProcessInfo..

Not sure why this failed. Is it perhaps a difference where some processes have args including the executable and some do not?

Fri, Jun 11, 10:10 AM · Restricted Project
teemperor accepted D104054: [lldb] Enable Rust v0 symbol demangling.

LGTM, thanks! (And congrats on your first patch)

Fri, Jun 11, 9:53 AM · Restricted Project
teemperor committed rGab46490dfc5c: [lldb] Remove GCC XFAIL for TestTypedefArray (authored by teemperor).
[lldb] Remove GCC XFAIL for TestTypedefArray
Fri, Jun 11, 7:25 AM
teemperor committed rGb1603cb66fc6: [lldb] Fix compilation after removal of APInt::toString (authored by teemperor).
[lldb] Fix compilation after removal of APInt::toString
Fri, Jun 11, 7:21 AM
teemperor committed rGe2d0798bc3e4: [lldb] Unmark TestInlines as XFAIL for gcc (authored by teemperor).
[lldb] Unmark TestInlines as XFAIL for gcc
Fri, Jun 11, 7:07 AM
teemperor reopened D81550: [lldb] Add support for evaluating expressions in static member functions.

Reopen because of the revert.

Fri, Jun 11, 6:02 AM · Restricted Project
teemperor added a reverting change for rG00764c36edf8: [lldb] Add support for evaluating expressions in static member functions: rG4125b46232ca: Revert "[lldb] Add support for evaluating expressions in static member….
Fri, Jun 11, 6:01 AM
teemperor committed rG4125b46232ca: Revert "[lldb] Add support for evaluating expressions in static member… (authored by teemperor).
Revert "[lldb] Add support for evaluating expressions in static member…
Fri, Jun 11, 6:01 AM
teemperor added a reverting change for D81550: [lldb] Add support for evaluating expressions in static member functions: rG4125b46232ca: Revert "[lldb] Add support for evaluating expressions in static member….
Fri, Jun 11, 6:01 AM · Restricted Project
teemperor added inline comments to D103750: [analyzer] Handle std::make_unique for SmartPtrModeling.
Fri, Jun 11, 5:00 AM · Restricted Project
teemperor added a comment to D103750: [analyzer] Handle std::make_unique for SmartPtrModeling.

How do I set the C++ standard while running a test?

Fri, Jun 11, 1:23 AM · Restricted Project
teemperor requested changes to D104067: [lldb] Decouple ObjCLanguage from Symtab.

This looks pretty good to me.

It's a little awkward in InitNameIndexes that we look up the various NameToSymbolIndex maps by eFunctionNameType, use the function name type again to sort the names & index pairs into the bucket we looked up before. I wonder if that could be made cleaner by having an

AddToSymbolNameToIndexMap(symbol_name, index, func_name_type)

interface, which would just sort the symbol names into the right map. Not sure that's worth the bother, however.

Fri, Jun 11, 12:38 AM · Restricted Project
teemperor accepted D104091: [lldb] Fix leak in test.

LGTM, big thanks for the patch & quick turnaround!

Fri, Jun 11, 12:05 AM · Restricted Project

Thu, Jun 10

teemperor committed rG632cbcac7906: [lldb] Move once_flags in HostInfoLinux so the internal state struct (authored by teemperor).
[lldb] Move once_flags in HostInfoLinux so the internal state struct
Thu, Jun 10, 11:54 PM
teemperor closed D104093: [lldb] Move once_flags in HostInfoLinux so the internal state struct.
Thu, Jun 10, 11:54 PM · Restricted Project
teemperor added inline comments to D104091: [lldb] Fix leak in test.
Thu, Jun 10, 11:47 PM · Restricted Project
teemperor requested changes to D104091: [lldb] Fix leak in test.

I think we should instead implement the Terminate function that the plugin system provides to tear down our state. I made a patch in D104093 that
moves the once_flags to the internal state struct, so with a proper Terminate implementation + my patch this should all work properly.

Thu, Jun 10, 11:45 PM · Restricted Project
teemperor requested review of D104093: [lldb] Move once_flags in HostInfoLinux so the internal state struct.
Thu, Jun 10, 11:41 PM · Restricted Project
teemperor added inline comments to D104054: [lldb] Enable Rust v0 symbol demangling.
Thu, Jun 10, 2:48 PM · Restricted Project
teemperor added a comment to D104054: [lldb] Enable Rust v0 symbol demangling.

This seems reasonable to me, but I'll leave this open for a while in case someone that knows more about Rust mangling shows up. Otherwise I'll accept this next week.

Thu, Jun 10, 1:59 PM · Restricted Project
teemperor added a comment to D102993: [lldb] Disable minimal import mode for RecordDecls that back FieldDecls.

Sure I can take a look, but I don't see the immediate problem when looking at the backtrace.

Thu, Jun 10, 1:10 PM · Restricted Project
teemperor added a comment to D104041: [lldb] Replace default bodies of special member functions with = default;.

LGTM beside some minor formatting bugs that got exacerbated by the clang-tidy run. I got bored of writing 'format' everywhere so I translated every comment into a different language via Google translate. I'll already accept this as this is easy to fix.

Thu, Jun 10, 9:50 AM

Wed, Jun 9

teemperor accepted D103483: [lldb] Convert the default constructor’s member initializers into default member initializers.

This doesn't compile for me (on Linux):

Wed, Jun 9, 8:23 AM · Restricted Project

Tue, Jun 8

teemperor added a comment to D103701: [lldb] Set return status to failed when adding a command error.

I've gone ahead and landed it, will revert on failures.

Got patches to remove the reundant calls locally so I'll put those up for review once this has had time to go through.
(those changes will be fairly mechanical but it's worth someone scanning them for silly mistakes)

Tue, Jun 8, 1:47 AM · Restricted Project

Mon, Jun 7

teemperor accepted D103652: [lldb][NFC] Refactor name to index maps in Symtab.

Some small rename I forgot to point out, but LGTM modulo that rename. Thanks for cleaning this up!

Mon, Jun 7, 2:43 PM · Restricted Project
teemperor added a comment to rGf10b9ca9c672: [NFC] Add missing include to LaneBitmask.h to fix modules build.

http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/ is building LLVM + Clang + LLDB with modules. IIRC the bot isn't sending mails as Green Dragon's build nodes are not that reliable.

Mon, Jun 7, 12:13 PM
teemperor committed rG2c2feebcd127: [lldb] Fix TypeSystemClang compilation after D101777 (authored by teemperor).
[lldb] Fix TypeSystemClang compilation after D101777
Mon, Jun 7, 9:45 AM
teemperor committed rGf10b9ca9c672: [NFC] Add missing include to LaneBitmask.h to fix modules build (authored by teemperor).
[NFC] Add missing include to LaneBitmask.h to fix modules build
Mon, Jun 7, 9:43 AM

Fri, Jun 4

teemperor added a reviewer for D103701: [lldb] Set return status to failed when adding a command error: teemperor.
Fri, Jun 4, 9:05 AM · Restricted Project
teemperor added a comment to D103701: [lldb] Set return status to failed when adding a command error.

Oh I see, you're not just concerned about just having every command in the test suite covered before landing.

Fri, Jun 4, 9:05 AM · Restricted Project
teemperor added a comment to D103701: [lldb] Set return status to failed when adding a command error.

I can run this for you on macOS and Linux x86 which I think should cover every test.

Fri, Jun 4, 9:04 AM · Restricted Project
teemperor committed rG0a655c62eca8: [lldb][NFC] Remove a redundant call to weak_ptr::expired (authored by teemperor).
[lldb][NFC] Remove a redundant call to weak_ptr::expired
Fri, Jun 4, 3:07 AM
teemperor closed D103442: [lldb][NFC] Remove a redundant call to weak_ptr::expired.
Fri, Jun 4, 3:07 AM · Restricted Project
teemperor requested changes to D103652: [lldb][NFC] Refactor name to index maps in Symtab.

Only have some comments about the way FindFunctionSymbols is now implemented, but otherwise this LGTM.

Fri, Jun 4, 3:06 AM · Restricted Project
teemperor added inline comments to D103675: [LLDB/API] Expose args and env from SBProcessInfo..
Fri, Jun 4, 2:06 AM · Restricted Project
teemperor added a reviewer for D103675: [LLDB/API] Expose args and env from SBProcessInfo.: Restricted Project.
Fri, Jun 4, 2:01 AM · Restricted Project

Thu, Jun 3

teemperor abandoned D103596: [libc++] Put __memory headers in submodules.

You are right, I wasn't aware of D103551. Thanks!

Thu, Jun 3, 6:18 AM · Restricted Project
teemperor committed rGe149c8e8ccce: [lldb][NFC] Remove unused 'using ArrayRef' in RegisterValueTest (authored by teemperor).
[lldb][NFC] Remove unused 'using ArrayRef' in RegisterValueTest
Thu, Jun 3, 2:18 AM
teemperor updated subscribers of D103596: [libc++] Put __memory headers in submodules.

That should fix the build failures that caused the revert of D103369.

Thu, Jun 3, 1:36 AM · Restricted Project
teemperor requested review of D103596: [libc++] Put __memory headers in submodules.
Thu, Jun 3, 1:33 AM · Restricted Project
teemperor added a comment to D103210: [lldb] Introduce Language::MethodNameInfo.

Sorry for the delay!

Thu, Jun 3, 1:10 AM · Restricted Project
teemperor added a comment to D103454: [lldb][docs] Document SBType.

Is this code used for auto-generated docs? Could be have this documentation in C++ definitions (lldb/API/SBType.h) as well? I usually just read the C++ source code, but I can imagine having the same docs in two places might be not the best idea...

Thu, Jun 3, 12:49 AM · Restricted Project

Wed, Jun 2

teemperor committed rG0ec761c3fc2a: [lldb] Preserve type sugar when using SBValue::Dereference on C++ references (authored by teemperor).
[lldb] Preserve type sugar when using SBValue::Dereference on C++ references
Wed, Jun 2, 10:23 AM
teemperor closed D103532: [lldb] Preserve type sugar when using SBValue::Dereference on C++ references.
Wed, Jun 2, 10:23 AM · Restricted Project
teemperor requested review of D103532: [lldb] Preserve type sugar when using SBValue::Dereference on C++ references.
Wed, Jun 2, 9:10 AM · Restricted Project

Tue, Jun 1

teemperor added a comment to D103483: [lldb] Convert the default constructor’s member initializers into default member initializers.

+1. I'm anyway doing the same whenever I have to touching constructors, so we might as well pull out the big hammer.

Tue, Jun 1, 12:22 PM · Restricted Project
teemperor added a comment to D103439: [lldb] Print the backtrace for all threads if the test breakpoint can't be hit.

LGTM. Are there other places where we check this, either in lldbutil or maybe more generally a pattern in the tests that could be extracted into a helper?

Tue, Jun 1, 9:53 AM · Restricted Project
teemperor committed rGecfca427f960: [lldb][NFC] Use Language plugins in Mangled::GuessLanguage (authored by teemperor).
[lldb][NFC] Use Language plugins in Mangled::GuessLanguage
Tue, Jun 1, 9:02 AM
teemperor closed D103158: [lldb][NFC] Use Language plugins in Mangled::GuessLanguage.
Tue, Jun 1, 9:02 AM · Restricted Project
teemperor committed rG01fb14e17763: [lldb] Remove SBCommandReturnObject::ref (authored by teemperor).
[lldb] Remove SBCommandReturnObject::ref
Tue, Jun 1, 8:58 AM
teemperor closed D103390: [lldb] Remove SBCommandReturnObject::ref.
Tue, Jun 1, 8:57 AM · Restricted Project
teemperor added a comment to D103454: [lldb][docs] Document SBType.

The language here might shift between functions and needs to be synced up (that patch was written over a few weeks during some build/test idle time). But the patch seems good enough for a draft.

Tue, Jun 1, 5:19 AM · Restricted Project
teemperor requested review of D103454: [lldb][docs] Document SBType.
Tue, Jun 1, 5:17 AM · Restricted Project
teemperor requested review of D103442: [lldb][NFC] Remove a redundant call to weak_ptr::expired.
Tue, Jun 1, 1:58 AM · Restricted Project
teemperor requested review of D103439: [lldb] Print the backtrace for all threads if the test breakpoint can't be hit.
Tue, Jun 1, 12:27 AM · Restricted Project

Mon, May 31

teemperor committed rG24ee6d3d3c62: [lldb][NFC] Remove unused var in SBDebugger::GetInternalVariableValue (authored by teemperor).
[lldb][NFC] Remove unused var in SBDebugger::GetInternalVariableValue
Mon, May 31, 2:19 AM
teemperor requested review of D103391: [lldb] Add missing reproducer instrumentation to some SB classes.
Mon, May 31, 1:56 AM · Restricted Project
teemperor added a comment to D103390: [lldb] Remove SBCommandReturnObject::ref.

IIUC this was originally public but then we made the other users friends (but the public remained). But still putting this up for review in case I missed something

Mon, May 31, 1:51 AM · Restricted Project
teemperor requested review of D103390: [lldb] Remove SBCommandReturnObject::ref.
Mon, May 31, 1:49 AM · Restricted Project

Sun, May 30

teemperor added a comment to D103381: [lldb] Fix typos..

I assume you don't have requested commit access yet (?) so I'm going to land this for you. Thanks for the patch!

Sun, May 30, 5:11 PM · Restricted Project
teemperor accepted D103381: [lldb] Fix typos..

LGTM but could you split out the non-NFC change (and then you can also mark this whole commit as NFC). I'm just going to accept this module that change.

Sun, May 30, 12:33 PM · Restricted Project