Page MenuHomePhabricator
Feed Advanced Search

Aug 14 2019

aprantl added inline comments to D66227: [DebugLine] Improve path handling..
Aug 14 2019, 9:46 AM · Restricted Project, Restricted Project
aprantl accepted D66145: [DebugInfo] Allow bundled calls in the MIR's call site info.

I don't know enough about VLIW bundle handling to really decide, but mechanically, this seems good.

Aug 14 2019, 8:55 AM · Restricted Project, debug-info

Aug 13 2019

aprantl added inline comments to D66175: Improve anonymous class heuristic in ClangASTContext::CreateRecordType .
Aug 13 2019, 4:40 PM · Restricted Project
aprantl added inline comments to D66175: Improve anonymous class heuristic in ClangASTContext::CreateRecordType .
Aug 13 2019, 4:40 PM · Restricted Project
aprantl added inline comments to D66121: Debug Info: Nest Objective-C property function decls inside their container..
Aug 13 2019, 1:53 PM · debug-info
aprantl added inline comments to D66121: Debug Info: Nest Objective-C property function decls inside their container..
Aug 13 2019, 10:48 AM · debug-info
aprantl added a comment to D65914: [Dwarf] DW_TAG_unspecified_type is a type tag..

Neat. Thanks!

Aug 13 2019, 10:21 AM · Restricted Project
aprantl added a comment to D65368: [DebugInfo] Handle complex expressions of spilt locations in LiveDebugValues.

Once wrinkle: patch 1 or 2 would also need to create undef DEBUG_VALUEs at the spill location for the values we are skipping to terminate the ranges.

Aug 13 2019, 10:21 AM · Restricted Project
aprantl added a comment to D65368: [DebugInfo] Handle complex expressions of spilt locations in LiveDebugValues.

This could be fixed, possibly easily, by adding a DIExpression field to VarLoc and using that expression on restore. I've shied away from this as it could reduce performance, and the risk that adding new features/facilities won't be acceptable to merge into the LLVM-9 branch to fix the upcoming release. (I've no experience with what is or isn't seen as acceptable).

Aug 13 2019, 10:19 AM · Restricted Project
aprantl accepted D62570: Use LLVM's debug line parser in LLDB.

Two percent is a noticeable price tag, but since we are doing extra work with error handling and building a copy of the line table in memory first; understandable, I'm moderately optimistic that we could increase the performance a bit in the future by eliminating the extra copy step, though perhaps not with some larger changes to the LLVM interface. Since we need this for DWARF 5 support and the performance penalty isn't that bad, this patch gets a thumbs up from me. I ssume you profiled the code and there isn't any obvious silliness in the implementation?

Aug 13 2019, 10:00 AM · Restricted Project, Restricted Project

Aug 12 2019

aprantl added a comment to D65368: [DebugInfo] Handle complex expressions of spilt locations in LiveDebugValues.

This meaning, we're loosing those DBG_VALUEs, not that they are incorrect, right?

They would be incorrect, as extra operations used to calculate the location would be dropped -- but on the plus-side, the compiler wouldn't crash in the process. Here's an illustrative example to aid discussion, first how this is all supposed to work with a sample input using an empty DIExpression (in-pseudo-mir, destination regs on left hand side):

DBG_VALUE $rax, !1, !DIExpression()
MOV64rm $rsp(-8), $rax
call @somesymbol
MOV64mr $rax, $rsp(-8)

The existing spill-and-restore code will recognise the store/load to/from stack and produce:

DBG_VALUE $rax, !1, !DIExpression()
MOV64rm $rsp(-8), $rax
DBG_VALUE $rsp, !1, !DIExpression(DW_OP_constu, 8, DW_OP_minus)
call @somesymbol
MOV64mr $rax, $rsp(-8)
DBG_VALUE $rax, !1, !DIExpression()

inserting a DBG_VALUE after the spill and after the restore. The problem is that if the original DBG_VALUE has a fragment, then with no patch we get:

DBG_VALUE $rax, !1, !DIExpression(DW_OP_LLVM_fragment, 0, 32)
MOV64rm $rsp(-8), $rax
DBG_VALUE $rsp, !1, !DIExpression(DW_OP_constu, 8, DW_OP_minus, DW_OP_LLVM_fragment, 0, 32)
call @somesymbol
MOV64mr $rax, $rsp(-8)
DBG_VALUE $rax, !1, !DIExpression()

i.e., the fragment gets dropped on the last DBG_VALUE. This currently fires an assertion in LiveDebugValues, I'm pretty certain the location-list builder would fire a few assertions if it saw this too.

The patch as it stands right now would get the fragment correct on the previous example, but would refuse to spill the following:

DBG_VALUE $rax, !1, !DIExpression(DW_OP_plus_uconst, 1, DW_OP_LLVM_fragment, 0, 32)
MOV64rm $rsp(-8), $rax
call @somesymbol
MOV64mr $rax, $rsp(-8)

Because of the complex expression on the DBG_VALUE (i.e. the DW_OP_plus_ucons).

Aug 12 2019, 5:09 PM · Restricted Project
aprantl added a reviewer for D66121: Debug Info: Nest Objective-C property function decls inside their container.: davide.
Aug 12 2019, 4:44 PM · debug-info
aprantl created D66121: Debug Info: Nest Objective-C property function decls inside their container..
Aug 12 2019, 4:44 PM · debug-info
aprantl added inline comments to D65914: [Dwarf] DW_TAG_unspecified_type is a type tag..
Aug 12 2019, 4:16 PM · Restricted Project
aprantl accepted D65914: [Dwarf] DW_TAG_unspecified_type is a type tag..
Aug 12 2019, 4:15 PM · Restricted Project
aprantl added inline comments to D65914: [Dwarf] DW_TAG_unspecified_type is a type tag..
Aug 12 2019, 4:15 PM · Restricted Project
aprantl added a comment to D66093: [Symbol] GetTypeBitAlign() should return None in case of failure..

Check LLVM's MathExtras.h, perhaps we already got one.

Aug 12 2019, 12:15 PM · Restricted Project, Restricted Project
aprantl added a comment to D65368: [DebugInfo] Handle complex expressions of spilt locations in LiveDebugValues.

at the cost of potentially dropping portions of complex expressions.

Aug 12 2019, 12:14 PM · Restricted Project
aprantl accepted D66093: [Symbol] GetTypeBitAlign() should return None in case of failure..
Aug 12 2019, 11:18 AM · Restricted Project, Restricted Project
aprantl added inline comments to D65368: [DebugInfo] Handle complex expressions of spilt locations in LiveDebugValues.
Aug 12 2019, 9:11 AM · Restricted Project

Aug 9 2019

aprantl added inline comments to D62570: Use LLVM's debug line parser in LLDB.
Aug 9 2019, 5:18 PM · Restricted Project, Restricted Project

Aug 8 2019

aprantl committed rGfe9eaadd6830: SymbolFileDWARF: Unconditionally scan through clang modules. NFCish (authored by aprantl).
SymbolFileDWARF: Unconditionally scan through clang modules. NFCish
Aug 8 2019, 2:17 PM
aprantl committed rGd9cbd2acfa7d: Remove unused and undocumented data_offset parameter (NFC) (authored by aprantl).
Remove unused and undocumented data_offset parameter (NFC)
Aug 8 2019, 12:23 PM
aprantl added a comment to D65914: [Dwarf] DW_TAG_unspecified_type is a type tag..

Got it! I misunderstood the purpose of this function.

Aug 8 2019, 12:19 PM · Restricted Project
aprantl added a comment to D65914: [Dwarf] DW_TAG_unspecified_type is a type tag..

FYI. You can derive the complete list by scanning for DW_AT_type in DWARF 5 Appendix A, Table A.1.

? not really. Any tag that is a type qualifier will have DW_AT_type, but also anything else that simply has a type (DW_TAG_constant, etc).

I do think that the regex DW_TAG_*_type will find all of them.

Aug 8 2019, 10:54 AM · Restricted Project
aprantl added a comment to D65914: [Dwarf] DW_TAG_unspecified_type is a type tag..

FYI. You can derive the complete list by scanning for DW_AT_type in DWARF 5 Appendix A, Table A.1.

Aug 8 2019, 8:55 AM · Restricted Project

Aug 7 2019

aprantl updated the diff for D65910: Remove unused and undocumented data_offset parameter.
Aug 7 2019, 3:54 PM · Restricted Project, Restricted Project
aprantl created D65910: Remove unused and undocumented data_offset parameter.
Aug 7 2019, 3:54 PM · Restricted Project, Restricted Project
aprantl committed rGf81d6fe75ca1: Adjust a ValueObjectChild's offset when the child is a bitfield (authored by aprantl).
Adjust a ValueObjectChild's offset when the child is a bitfield
Aug 7 2019, 3:41 PM

Aug 6 2019

aprantl updated subscribers of D65821: [Attributor][modulemap] Revert r368064 but fix the build.
Aug 6 2019, 12:46 PM · Restricted Project
aprantl updated subscribers of D65712: [Attributor] Introduce the IRAttribute helper struct.
Aug 6 2019, 10:18 AM · Restricted Project
aprantl updated subscribers of D65712: [Attributor] Introduce the IRAttribute helper struct.
Aug 6 2019, 9:53 AM · Restricted Project
aprantl updated subscribers of D65712: [Attributor] Introduce the IRAttribute helper struct.
Aug 6 2019, 9:48 AM · Restricted Project
aprantl added a comment to D65712: [Attributor] Introduce the IRAttribute helper struct.

This series of commits broke the modular builds of LLVM.

Aug 6 2019, 9:48 AM · Restricted Project

Aug 5 2019

aprantl added a comment to D65035: [DebugInfo] Don't emit incorrect descriptions of thunk params (PR42627).
In D65035#1615906, @vsk wrote:

It's likely better for the tools to know where each function starts *and ends*.

attribute((nodebug)) breaks that invariant (& I think there's other functions we emit without debug info too - maybe some things to do with global ctors?)

Correct, and the tools need to fall back to heuristics in these cases. I don't know whether this causes any problems in practice.

More importantly though, if we don't generate debug info for the thunk, can we describe the function itself after it became inlined into the thunk?

Not really, no - and GCC doesn't describe the inlining either. A backtrace would demangle the name of the thunk & that's about all it could show there.

*That* sounds like a good reason to keep the debug info for the thunks around.

Not sure I follow why demangling the symbol would result in a worse user experience than the debug info? About the only thing in the debug info is the mangled name that's in the symbol table too.

Oh, wouldn't the debugger lose the ability to synthesize an [inlined] frame for whatever is inlined into the thunk?

True, true - you'd lose any variable descriptions etc. Fair point.

Aug 5 2019, 5:00 PM · Restricted Project
aprantl added a comment to D65035: [DebugInfo] Don't emit incorrect descriptions of thunk params (PR42627).

It's likely better for the tools to know where each function starts *and ends*.

attribute((nodebug)) breaks that invariant (& I think there's other functions we emit without debug info too - maybe some things to do with global ctors?)

Aug 5 2019, 3:11 PM · Restricted Project
aprantl added a comment to D65035: [DebugInfo] Don't emit incorrect descriptions of thunk params (PR42627).

It's likely better for the tools to know where each function starts *and ends*.
More importantly though, if we don't generate debug info for the thunk, can we describe the function itself after it became inlined into the thunk?

Aug 5 2019, 2:53 PM · Restricted Project
aprantl added inline comments to D65368: [DebugInfo] Handle complex expressions of spilt locations in LiveDebugValues.
Aug 5 2019, 2:44 PM · Restricted Project

Aug 2 2019

aprantl accepted D65666: Temporarily disable libc++ std::function formatter due to performance issue.
Aug 2 2019, 10:58 AM · Restricted Project
aprantl added a comment to D65646: [lldb] Print better diagnostics for user expressions and modules.

I have a question based on my half-knowledge about the expression evaluator: I thought that we already wrote out a temporary file for the expression in order to support expr -g? Is this orthogonal or do we now have to ways of pretending there is a source file backing up the expression?

Aug 2 2019, 8:50 AM · Restricted Project, Restricted Project

Aug 1 2019

aprantl added inline comments to D65414: Fix ClangASTContext::CreateParameterDeclaration to not call addDecl.
Aug 1 2019, 5:48 PM · Restricted Project
aprantl added a comment to D65492: Adjust a ValueObjectChild's offset when the child is a bitfield.

ping.

Aug 1 2019, 10:14 AM · Restricted Project, Restricted Project
aprantl accepted D65558: [LLVM][Alignment] Update documentation.

LGTM with one fix inline.

Aug 1 2019, 10:14 AM · Restricted Project
aprantl added a comment to D65585: WIP: [llvm-locstats] Add the llvm-locstats tool.

As David said, this does look like it could fit into dwarfdump --statistics (tools/llvm-dwarfdump/Statistics.cpp).

Aug 1 2019, 10:11 AM · Restricted Project, debug-info
aprantl added a comment to D65573: Add User docs for ASTImporter.

Thanks, the extra documentation is highly appreciated!

Aug 1 2019, 9:59 AM · Restricted Project, Restricted Project

Jul 31 2019

aprantl added inline comments to D64790: [LLVM][NFC] Adding an Alignment type to LLVM.
Jul 31 2019, 12:46 PM · Restricted Project

Jul 30 2019

aprantl added inline comments to rGa1c64dcdecb9: [DWARF] Add one more type unit test.
Jul 30 2019, 5:25 PM
aprantl created D65492: Adjust a ValueObjectChild's offset when the child is a bitfield.
Jul 30 2019, 5:19 PM · Restricted Project, Restricted Project

Jul 29 2019

aprantl accepted D65414: Fix ClangASTContext::CreateParameterDeclaration to not call addDecl.
Jul 29 2019, 3:56 PM · Restricted Project
aprantl accepted D65035: [DebugInfo] Don't emit incorrect descriptions of thunk params (PR42627).

I agree, there seems not to be much value of generating debug info for the arguments of a thunk.

Jul 29 2019, 1:41 PM · Restricted Project
aprantl added inline comments to D58238: [DebugInfo] MachineSink: Insert undef DBG_VALUEs when sinking instructions, try to forward copies.
Jul 29 2019, 1:32 PM · Restricted Project
aprantl added inline comments to D58386: [DebugInfo] Pre-RA MachineSink: sink DBG_VALUEs that don't immediately follow the sunk instruction too.
Jul 29 2019, 1:28 PM · Restricted Project
aprantl added a comment to D65414: Fix ClangASTContext::CreateParameterDeclaration to not call addDecl.

So basically this is reverting an untested and incomplete/incorrect fix for another bug, while fixing a regression. I'm fine with the change assuming that it won't break the Windows test suite. The Makefile can be simplified though.

Jul 29 2019, 1:18 PM · Restricted Project
aprantl accepted D58191: [DebugInfo] Make postra sinking of DBG_VALUEs safe in the presence of subregisters.
Jul 29 2019, 1:09 PM · Restricted Project
aprantl accepted D64437: [IR] Consolidate fixed metadata kind definitions (NFC).
Jul 29 2019, 1:09 PM · Restricted Project
aprantl added a comment to D64267: lldb_assert: abort when assertions are enabled..

Actually, it looks like this patch fixed an oversight in that commit. So all is good :-)

Jul 29 2019, 1:03 PM · Restricted Project, Restricted Project
aprantl added a comment to D64267: lldb_assert: abort when assertions are enabled..

Did you see this recent commit?

Jul 29 2019, 1:03 PM · Restricted Project, Restricted Project
aprantl added inline comments to D64209: [DWARF] Make DWARFDataExtractor possible to be used with both 32- and 64-bit offsets..
Jul 29 2019, 12:56 PM · Restricted Project

Jul 2 2019

aprantl added inline comments to D64036: [Bitcode] Update CHECK-DAG usage in tests.
Jul 2 2019, 9:46 AM · Restricted Project
aprantl added a comment to D64006: Support 64-bit offsets in utility classes (1/5).

Thank you for demonstrating this! I agree that the patch also introduces lots of opportunities for subtle bugs. It also increases the memory footprint in places where it likely won't be needed any time soon, such as 64-bit DWARF parsing support. This patch looks much more palatable to me now and I'd be okay with taking it if @dblaikie is okay with it. Is there danger in using the same function name or should we call the 64-bit variants something more explicit?

Jul 2 2019, 9:42 AM · Restricted Project
aprantl added a comment to D64059: [DO NOT SUBMIT] Switch DataExtractor to 64-bit offsets.

In a few cases it may be beneficial to reorder struct elements such that groups of 32-bit or smaller elements aren't interrupted by a 64-bit element for better packing.

Jul 2 2019, 9:34 AM

Jul 1 2019

aprantl added inline comments to D64006: Support 64-bit offsets in utility classes (1/5).
Jul 1 2019, 1:42 PM · Restricted Project
aprantl added inline comments to D58042: [LiveDebugValues] Emit parameter's entry value.
Jul 1 2019, 10:10 AM · Restricted Project, debug-info
aprantl added inline comments to D64006: Support 64-bit offsets in utility classes (1/5).
Jul 1 2019, 10:06 AM · Restricted Project

Jun 29 2019

aprantl committed rG6293cd05045c: Replace tabs with spaces. (authored by aprantl).
Replace tabs with spaces.
Jun 29 2019, 11:33 AM

Jun 28 2019

aprantl added a reviewer for D63828: Add FileWriter to GSYM and encode/decode functions to AddressRange and AddressRanges: vsk.
Jun 28 2019, 4:32 PM · Restricted Project
aprantl requested changes to D63828: Add FileWriter to GSYM and encode/decode functions to AddressRange and AddressRanges.

We need to come up with a better error handling strategy before this can be landed.

Jun 28 2019, 4:32 PM · Restricted Project

Jun 27 2019

aprantl committed rG559c6e17cd88: Make nrvo-string test more robust. (authored by aprantl).
Make nrvo-string test more robust.
Jun 27 2019, 1:39 PM
aprantl added a comment to D63828: Add FileWriter to GSYM and encode/decode functions to AddressRange and AddressRanges.

The important part is that the error must be checked (which isn't enforceable through bool returns). Whether it's after each function call or later, you probably have a better idea about.

Jun 27 2019, 1:20 PM · Restricted Project
aprantl added a comment to D63828: Add FileWriter to GSYM and encode/decode functions to AddressRange and AddressRanges.

JF is currently working on making BitStream error-safe over in https://reviews.llvm.org/D63518. Perhaps there are some patterns that are worth copying.

Jun 27 2019, 10:31 AM · Restricted Project
aprantl committed rG3b4a667854e0: Add a sanity check to the domain socket tests. (authored by aprantl).
Add a sanity check to the domain socket tests.
Jun 27 2019, 9:47 AM

Jun 26 2019

aprantl added inline comments to D63828: Add FileWriter to GSYM and encode/decode functions to AddressRange and AddressRanges.
Jun 26 2019, 4:58 PM · Restricted Project
aprantl added inline comments to D63828: Add FileWriter to GSYM and encode/decode functions to AddressRange and AddressRanges.
Jun 26 2019, 2:30 PM · Restricted Project
aprantl added inline comments to D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue.
Jun 26 2019, 2:23 PM · Restricted Project
aprantl committed rG8ac899c6003c: Make nrvo-string test more robust. (authored by aprantl).
Make nrvo-string test more robust.
Jun 26 2019, 1:06 PM
aprantl added inline comments to D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue.
Jun 26 2019, 11:40 AM · Restricted Project
aprantl added inline comments to D63828: Add FileWriter to GSYM and encode/decode functions to AddressRange and AddressRanges.
Jun 26 2019, 11:36 AM · Restricted Project
aprantl accepted D56151: [DebugInfo] PR40010: Avoid register coalesing altering DBG_VALUE valuations.
Jun 26 2019, 11:31 AM · Restricted Project

Jun 25 2019

aprantl added a comment to D56151: [DebugInfo] PR40010: Avoid register coalesing altering DBG_VALUE valuations.

Ping: we should hammer out this review, seeing how the branch date for llvm-9 has been announced. Could I suggest that everyone is happy with the *implementation* of this patch, but that it's not yet agreed that it needs merging?

The patch effectively makes the codegen backend stricter about what DBG_VALUE insts it will accept, i.e. they have to refer to vregs that are alive. If it helps, this is already something that's enforced a few optimisation passes later in LiveDebugVariables [0], this patch just brings that check further forwards, due to the errors that can be introduced (described above). What's unfortunate is that this also prevents occasions where register coalescing re-enlivens DBG_VALUEs with a vreg that has the right value in it, occasions which can be generated due to limitations in SelectionDAG.

This then becomes a trade-off (see immediately preceeding comment) of whether the problem is so bad that we should trade some lost locations for getting rid of placeDbgValues. IMHO: yes, because we're trading definitely-incorrect locations for some more being optimized-out, a net reduction in error, to me. Other opinions most welcome.

[0] https://github.com/llvm/llvm-project/blob/b9f1e7b16ed2341e54b4e2033d111e7a2ca19b9a/llvm/lib/CodeGen/LiveDebugVariables.cpp#L624

Jun 25 2019, 2:21 PM · Restricted Project
aprantl added inline comments to D63104: Add GSYM utility files along with unit tests..
Jun 25 2019, 1:59 PM · Restricted Project
aprantl committed rG510f4098ae04: Add a defensive check for nullptr as in the block above. (authored by aprantl).
Add a defensive check for nullptr as in the block above.
Jun 25 2019, 12:54 PM
aprantl added a comment to D63110: Fix a crash in option parsing..

Thanks!

Jun 25 2019, 10:50 AM · Restricted Project, Restricted Project
aprantl added inline comments to D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue.
Jun 25 2019, 10:35 AM · Restricted Project

Jun 24 2019

aprantl committed rGc8e8b274f1c0: Reapply "Fix a crash in option parsing." (authored by aprantl).
Reapply "Fix a crash in option parsing."
Jun 24 2019, 5:56 PM
aprantl added inline comments to D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue.
Jun 24 2019, 4:19 PM · Restricted Project
aprantl added a comment to D61062: Keep call site info valid through the backend.

looks good!

Jun 24 2019, 4:07 PM · Restricted Project, debug-info
aprantl added a comment to D58042: [LiveDebugValues] Emit parameter's entry value.

A rebase shouldn't affect the spirit of the change :-)

Jun 24 2019, 4:06 PM · Restricted Project, debug-info

Jun 19 2019

aprantl added a comment to D60831: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion.

Thanks for your help!

Jun 19 2019, 6:26 AM · debug-info, Restricted Project

Jun 18 2019

aprantl committed rGfc5107cde644: Add debug location verification for !llvm.loop attachments. (authored by aprantl).
Add debug location verification for !llvm.loop attachments.
Jun 18 2019, 1:06 PM
aprantl committed rG1db8d4a8660f: Fix broken debug info in in an !llvm.loop attachment in this testcase. (authored by aprantl).
Fix broken debug info in in an !llvm.loop attachment in this testcase.
Jun 18 2019, 1:05 PM
aprantl committed rGacc93d62e048: Revert Add debug location verification for !llvm.loop attachments. (authored by aprantl).
Revert Add debug location verification for !llvm.loop attachments.
Jun 18 2019, 12:52 PM
aprantl committed rG8ff822d61dac: Add debug location verification for !llvm.loop attachments. (authored by aprantl).
Add debug location verification for !llvm.loop attachments.
Jun 18 2019, 12:41 PM
aprantl added a comment to D63361: Pretend NRVO variables are references so they can be found by debug info.

Thanks, this addresses my concern!

Jun 18 2019, 11:03 AM · debug-info, Restricted Project, Restricted Project
aprantl added a comment to D60831: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion.

I put up a Verifier patch at https://reviews.llvm.org/D63499. Once that patch has landed, this patch should be safe to re-apply.

Jun 18 2019, 9:52 AM · debug-info, Restricted Project
aprantl created D63499: Add debug location verification for !llvm.loop attachments.
Jun 18 2019, 9:52 AM · Restricted Project, debug-info

Jun 17 2019

aprantl committed rG2d26cf37d777: llgdb.py: Make sure to clean up the debugger on exit. (authored by aprantl).
llgdb.py: Make sure to clean up the debugger on exit.
Jun 17 2019, 1:04 PM
aprantl added inline comments to D63429: [DebugInfo] Avoid adding too much indirection to pointer-valued variables.
Jun 17 2019, 10:11 AM · Restricted Project
aprantl added a project to D63387: clang: Promote -fdebug-compilation-dir from cc1 flag to driver-level flag: debug-info.
Jun 17 2019, 10:07 AM · debug-info, Restricted Project
aprantl added a comment to D60831: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion.

This seems to be a case of having old, incorrect, metadata baked into the test.
The 'startLoc' (!680) and 'endLoc' (!681) in loop metadta for loop !679 are both
missing an 'inlinedAt' node.

Jun 17 2019, 10:02 AM · debug-info, Restricted Project
aprantl added a comment to D63083: [DebugInfo][Docs] Document that prologue/epilogue variable location changes are ignored.

I think this is good to go.

Jun 17 2019, 9:49 AM · Restricted Project