Page MenuHomePhabricator
Feed Advanced Search

Fri, Jan 17

aprantl committed rG63c4261720a7: Pass length of string in Go binding of CreateCompileUnit (authored by aprantl).
Pass length of string in Go binding of CreateCompileUnit
Fri, Jan 17, 1:36 PM
aprantl added a comment to D72953: Fix the handling of unnamed bit-fields when parsing DWARF.

Very cool. I think we can improve the code quite a bit while we're here.

Fri, Jan 17, 1:26 PM
aprantl added inline comments to D72953: Fix the handling of unnamed bit-fields when parsing DWARF.
Fri, Jan 17, 1:26 PM
aprantl committed rG7b30370e5bcf: Move the sysroot attribute from DIModule to DICompileUnit (authored by aprantl).
Move the sysroot attribute from DIModule to DICompileUnit
Fri, Jan 17, 12:57 PM
aprantl committed rGc17aee67f100: Revert "Rename DW_AT_LLVM_isysroot to DW_AT_LLVM_sysroot" (authored by aprantl).
Revert "Rename DW_AT_LLVM_isysroot to DW_AT_LLVM_sysroot"
Fri, Jan 17, 12:57 PM
aprantl closed D71732: Move the sysroot attribute from DIModule to DICompileUnit.
Fri, Jan 17, 12:57 PM · Restricted Project, Restricted Project, Restricted Project, debug-info
aprantl added a reverting change for rG12e479475a89: Rename DW_AT_LLVM_isysroot to DW_AT_LLVM_sysroot: rGc17aee67f100: Revert "Rename DW_AT_LLVM_isysroot to DW_AT_LLVM_sysroot".
Fri, Jan 17, 12:57 PM
aprantl committed rG94dd096f35a2: Revert "Attempt to fix Go syntax error" (authored by aprantl).
Revert "Attempt to fix Go syntax error"
Fri, Jan 17, 12:57 PM
aprantl added a reverting change for rGc0176916a482: Attempt to fix Go syntax error: rG94dd096f35a2: Revert "Attempt to fix Go syntax error".
Fri, Jan 17, 12:57 PM
aprantl committed rGc0176916a482: Attempt to fix Go syntax error (authored by aprantl).
Attempt to fix Go syntax error
Fri, Jan 17, 12:38 PM
aprantl added inline comments to D72917: [lldb/DWARF] Change how we construct a llvm::DWARFContext.
Fri, Jan 17, 11:21 AM · Restricted Project
aprantl added inline comments to D72880: Fix a buffer-size bug when the first DW_OP_piece is undefined.
Fri, Jan 17, 11:21 AM · Restricted Project
aprantl added inline comments to D68063: Propeller: LLVM support for basic block sections.
Fri, Jan 17, 11:21 AM · Restricted Project
aprantl committed rGec9a3cccd401: Update testcase for LLVM IR change (sysroot) (authored by aprantl).
Update testcase for LLVM IR change (sysroot)
Fri, Jan 17, 11:11 AM
aprantl created D72938: Fix an assertion failure in DwarfExpression's subregister composition.
Fri, Jan 17, 10:51 AM · Restricted Project, debug-info
aprantl committed rG12e479475a89: Rename DW_AT_LLVM_isysroot to DW_AT_LLVM_sysroot (authored by aprantl).
Rename DW_AT_LLVM_isysroot to DW_AT_LLVM_sysroot
Fri, Jan 17, 9:44 AM

Thu, Jan 16

aprantl committed rGf55ab6f90b73: Fix a buffer-size bug when the first DW_OP_piece is undefined (authored by aprantl).
Fix a buffer-size bug when the first DW_OP_piece is undefined
Thu, Jan 16, 4:51 PM
aprantl committed rG7b0d58e339b2: Add testing for DW_OP_piece and fix a bug with small Scalar values. (authored by aprantl).
Add testing for DW_OP_piece and fix a bug with small Scalar values.
Thu, Jan 16, 4:51 PM
aprantl closed D72880: Fix a buffer-size bug when the first DW_OP_piece is undefined.
Thu, Jan 16, 4:50 PM · Restricted Project
aprantl closed D72879: Add testing for DW_OP_piece and fix a bug with small Scalar values..
Thu, Jan 16, 4:50 PM · Restricted Project
aprantl added a reviewer for D72879: Add testing for DW_OP_piece and fix a bug with small Scalar values.: vsk.
Thu, Jan 16, 3:43 PM · Restricted Project
aprantl added a comment to D71732: Move the sysroot attribute from DIModule to DICompileUnit.

Any other comments?

Thu, Jan 16, 3:34 PM · Restricted Project, Restricted Project, Restricted Project, debug-info
aprantl accepted D72823: [Reproducers] Add a tool to transparently capture and replay lldb sessions.
Thu, Jan 16, 3:34 PM · Restricted Project
aprantl added a child revision for D72879: Add testing for DW_OP_piece and fix a bug with small Scalar values.: D72880: Fix a buffer-size bug when the first DW_OP_piece is undefined.
Thu, Jan 16, 3:34 PM · Restricted Project
aprantl added a parent revision for D72880: Fix a buffer-size bug when the first DW_OP_piece is undefined: D72879: Add testing for DW_OP_piece and fix a bug with small Scalar values..
Thu, Jan 16, 3:34 PM · Restricted Project
aprantl added a comment to D72879: Add testing for DW_OP_piece and fix a bug with small Scalar values..

My understanding is that DW_OP_piece is still incomplete, right?

Thu, Jan 16, 3:34 PM · Restricted Project
aprantl accepted D72877: [FastISel] Lower `llvm.dbg.value(undef, ...` correctly..

LGTM with Vedant's testcase!

Thu, Jan 16, 3:34 PM · debug-info, Restricted Project
aprantl added a project to D72877: [FastISel] Lower `llvm.dbg.value(undef, ...` correctly.: debug-info.
Thu, Jan 16, 2:53 PM · debug-info, Restricted Project
aprantl added a comment to D72877: [FastISel] Lower `llvm.dbg.value(undef, ...` correctly..

Thanks!

Thu, Jan 16, 2:53 PM · debug-info, Restricted Project
aprantl added inline comments to D72823: [Reproducers] Add a tool to transparently capture and replay lldb sessions.
Thu, Jan 16, 2:43 PM · Restricted Project
aprantl created D72879: Add testing for DW_OP_piece and fix a bug with small Scalar values..
Thu, Jan 16, 2:34 PM · Restricted Project
aprantl created D72880: Fix a buffer-size bug when the first DW_OP_piece is undefined.
Thu, Jan 16, 2:34 PM · Restricted Project
aprantl added inline comments to D72823: [Reproducers] Add a tool to transparently capture and replay lldb sessions.
Thu, Jan 16, 12:56 PM · Restricted Project
aprantl committed rGc0d909a1b12f: Delete control character from comment. (NFC) (authored by aprantl).
Delete control character from comment. (NFC)
Thu, Jan 16, 10:51 AM
aprantl added inline comments to D72823: [Reproducers] Add a tool to transparently capture and replay lldb sessions.
Thu, Jan 16, 9:53 AM · Restricted Project
aprantl added inline comments to D72823: [Reproducers] Add a tool to transparently capture and replay lldb sessions.
Thu, Jan 16, 9:34 AM · Restricted Project
aprantl added inline comments to D72828: [DWARF5] Added support for emission of debug_macro section..
Thu, Jan 16, 8:57 AM · Restricted Project, debug-info

Wed, Jan 15

aprantl accepted D72801: [CodeExtractor] Transfer debug info to extracted function.

Looks plausible.

Wed, Jan 15, 3:34 PM · Restricted Project
aprantl committed rZORG0c746ef9b47d: lldb-sanitized: Move MAX_PARALLEL_TESTS initialization to a place where it can… (authored by aprantl).
lldb-sanitized: Move MAX_PARALLEL_TESTS initialization to a place where it can…
Wed, Jan 15, 2:52 PM
aprantl added inline comments to D72801: [CodeExtractor] Transfer debug info to extracted function.
Wed, Jan 15, 1:19 PM · Restricted Project
aprantl accepted D72795: DebugInfo: Factor out logic to update locations in MD_loop metadata, NFC.
Wed, Jan 15, 12:15 PM · Restricted Project
aprantl added a comment to D72797: [llvm-dwarfdump][Statistics] Distinguish functions/variables with same name across different CUs.

This five patches reduces 'total availability' metric of clang binary (debug build) from 126% to 87%.

Wed, Jan 15, 12:14 PM · debug-info, Restricted Project
aprantl accepted D72757: [DebugInfo] Simplify the constructor of DWARFDebugAranges::Range. NFC..

Thanks!

Wed, Jan 15, 9:53 AM · Restricted Project, debug-info

Tue, Jan 14

aprantl updated the diff for D71732: Move the sysroot attribute from DIModule to DICompileUnit.
  • removed copyied&pasted sysroot member from DwarfDebug
  • address feedback in MetadataLoader
Tue, Jan 14, 2:55 PM · Restricted Project, Restricted Project, Restricted Project, debug-info
aprantl updated the diff for D71732: Move the sysroot attribute from DIModule to DICompileUnit.

Addressed feedback from @dblaikie :

  • sysroot is now an LLDB tuning setting
  • attribute moved from skeleton to .dwo unit
Tue, Jan 14, 1:50 PM · Restricted Project, Restricted Project, Restricted Project, debug-info
aprantl committed rGb53d44b17a16: dotest.py: Add option to pass extra lldb settings to dotest (authored by aprantl).
dotest.py: Add option to pass extra lldb settings to dotest
Tue, Jan 14, 12:40 PM
aprantl closed D72662: dotest.py: Add option to pass extra lldb settings to dotest.
Tue, Jan 14, 12:40 PM · Restricted Project
aprantl accepted D71870: [llvm-locstats] Add the --compare option.

@aprantl Thanks for the comment, sorry for the late response, I was on the vacation.

How ubiquitous is matplotlib? I wonder if it might be better to textually print out a gnuplot file or something similar. OTOH the surface area in the code seems to be really small, so this may be fine.

I see the matplotlib is used within some of the LLVM Python tools, but I can investigate this further in order to see if the gnuplot is better option for this.

@aprantl For this option I would keep using the matplotlib (there is a help message saying we need the library, please see e.g. clang/utils/analyzer/CmpRuns.py).
Although, I think the gnuplot could be useful as well, but I don't see any obstacle that both ways of plotting coexist here, so we can add another feature to the llvm-locstats tool generating a gnuplot text file. WDYT?

Tue, Jan 14, 12:30 PM · Restricted Project, debug-info
aprantl added a comment to D71732: Move the sysroot attribute from DIModule to DICompileUnit.

Some mysterious CFI failures I haven't looked into yet, but were pretty clearly blamed on this change & went away with a revert.

Because the flag was previously not (de)serialized and now shows up in LTO builds where it was dropped before?

Maybe, but don't see how that'd turn up anything interesting in CFI behavior - again, no one's turning this flag on...

Well I guess I can serialize false for now without preventing this from getting fixed.

Any opinions on this patch otherwise?

Seems alright - but I'd like to understand it a bit better. Looks like this'll add the attribute to every (.o - so skeleton with Split DWARF, or the normal/unit with non-split) CU, where previously it was only in DIModules which were only emitted with -gmodules? What's it used for? Could it be put in the full unit, rather than the skeleton unit? Could it be only emitted when tuning for lldb?

Tue, Jan 14, 12:30 PM · Restricted Project, Restricted Project, Restricted Project, debug-info
aprantl added inline comments to D72662: dotest.py: Add option to pass extra lldb settings to dotest.
Tue, Jan 14, 12:21 PM · Restricted Project
aprantl added a comment to D72684: [lldb][NFC] Rename ClangASTContext to TypeSystemClang.

This is very good, go for it. Should we do the same for Swift? cc: @aprantl

Tue, Jan 14, 12:12 PM · Restricted Project
aprantl accepted D71834: [DWARF] Fix DWARFDebugAranges to support 64-bit CU offsets..

But removing the default values is also seems to be out of the scope of the patch.

Tue, Jan 14, 12:02 PM · Restricted Project, debug-info

Mon, Jan 13

aprantl created D72662: dotest.py: Add option to pass extra lldb settings to dotest.
Mon, Jan 13, 3:44 PM · Restricted Project
aprantl added inline comments to D72597: [lldb][DWARF] Added support for new forms in DWARFv5 macro..
Mon, Jan 13, 1:15 PM · Restricted Project
aprantl added inline comments to D71834: [DWARF] Fix DWARFDebugAranges to support 64-bit CU offsets..
Mon, Jan 13, 9:38 AM · Restricted Project, debug-info
aprantl added inline comments to D71931: [DWARF] Allow empty address range tables..
Mon, Jan 13, 9:38 AM · Restricted Project, debug-info
aprantl accepted D72593: [lldb][NFC] Rewrite python_api/rdar-12481949 test.

Awesome.

Mon, Jan 13, 9:38 AM · Restricted Project
aprantl added inline comments to D72515: Add Targeted LiveDebugValues Tests That Exercise Specific Expected Behaviours .
Mon, Jan 13, 9:38 AM · Restricted Project, debug-info
aprantl added a comment to D72515: Add Targeted LiveDebugValues Tests That Exercise Specific Expected Behaviours .

Very nice!

Mon, Jan 13, 9:38 AM · Restricted Project, debug-info
aprantl accepted D72515: Add Targeted LiveDebugValues Tests That Exercise Specific Expected Behaviours .

Very nice!

Mon, Jan 13, 9:30 AM · Restricted Project, debug-info
aprantl added a comment to D71451: Support to emit extern variables debuginfo with "-fstandalone-debug".

ping

Mon, Jan 13, 8:59 AM · Restricted Project, Restricted Project, debug-info

Fri, Jan 10

aprantl added inline comments to D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes..
Fri, Jan 10, 10:22 AM · debug-info, Restricted Project
aprantl accepted D72321: Add test for GDB pretty printers..
Fri, Jan 10, 9:03 AM · Restricted Project
aprantl accepted D72489: [DWARF] Emit DW_AT_call_return_pc as an address.
Fri, Jan 10, 8:58 AM · Restricted Project, Restricted Project
aprantl added inline comments to D72489: [DWARF] Emit DW_AT_call_return_pc as an address.
Fri, Jan 10, 8:57 AM · Restricted Project, Restricted Project
aprantl committed rGe9331a56fead: Add missing nullptr checks. (authored by aprantl).
Add missing nullptr checks.
Fri, Jan 10, 8:53 AM
aprantl closed D72413: Add missing nullptr checks..
Fri, Jan 10, 8:53 AM · Restricted Project

Thu, Jan 9

aprantl committed rGb2ab5139c9f8: Merge commit 'refs/am/changes/d27a16eb392f39f9ee04ff5194b1eff3e189e6f8_apple/ma… (authored by aprantl).
Merge commit 'refs/am/changes/d27a16eb392f39f9ee04ff5194b1eff3e189e6f8_apple/ma…
Thu, Jan 9, 3:59 PM
aprantl added a comment to D71732: Move the sysroot attribute from DIModule to DICompileUnit.

Some mysterious CFI failures I haven't looked into yet, but were pretty clearly blamed on this change & went away with a revert.

Thu, Jan 9, 2:56 PM · Restricted Project, Restricted Project, Restricted Project, debug-info
aprantl added a comment to D71732: Move the sysroot attribute from DIModule to DICompileUnit.

@dblaikie: I just saw you reverted https://reviews.llvm.org/rGc51b45e32ef7f35c11891f60871aa9c2c04cd991 ? What happened?

Thu, Jan 9, 1:13 PM · Restricted Project, Restricted Project, Restricted Project, debug-info
aprantl added a reviewer for D72413: Add missing nullptr checks.: davide.
Thu, Jan 9, 1:13 PM · Restricted Project
aprantl updated the diff for D71732: Move the sysroot attribute from DIModule to DICompileUnit.

Removed workaround for the bug @dbalikie fixed in https://reviews.llvm.org/rGc51b45e32ef7f35c11891f60871aa9c2c04cd991

Thu, Jan 9, 1:04 PM · Restricted Project, Restricted Project, Restricted Project, debug-info
aprantl added a comment to D71732: Move the sysroot attribute from DIModule to DICompileUnit.

Ping @debug-info / @dblaikie for a review.

Thu, Jan 9, 1:04 PM · Restricted Project, Restricted Project, Restricted Project, debug-info
aprantl added a comment to D72413: Add missing nullptr checks..

Should we merge this like that, or is there a better way of doing this?

Thu, Jan 9, 9:45 AM · Restricted Project
aprantl accepted D72447: [lldb] Mark several tests as not dependent on debug info.

I believe that all of these make sense.

Thu, Jan 9, 9:18 AM · Restricted Project
aprantl updated subscribers of D72321: Add test for GDB pretty printers..

What about debuginfo-tests/llvm-prettyprinters/gdb/ and then we'll create an lldb subdirectory next to later?

Thu, Jan 9, 9:17 AM · Restricted Project
aprantl added inline comments to D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes..
Thu, Jan 9, 9:08 AM · debug-info, Restricted Project
aprantl added reviewers for D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes.: probinson, aprantl.
Thu, Jan 9, 9:08 AM · debug-info, Restricted Project
aprantl accepted D70676: [DebugInfo] Don't repeatedly created undef DBG_VALUEs during machine-sinking.
Thu, Jan 9, 9:08 AM · Restricted Project

Wed, Jan 8

aprantl added a comment to D72413: Add missing nullptr checks..

Do we currently have a way to end up in this state?

Wed, Jan 8, 4:42 PM · Restricted Project
aprantl added a comment to D72413: Add missing nullptr checks..

If we can't make a persistent expression state, are we going to be able to do anything useful with expressions? I don't see anything wrong here, but it seems like we should really be putting up a crunchy frog warning and erroring out of "expr"directly if we really can't make a type system.

Wed, Jan 8, 3:56 PM · Restricted Project
aprantl added reviewers for D72321: Add test for GDB pretty printers.: davide, JDevlieghere.
Wed, Jan 8, 3:37 PM · Restricted Project
aprantl added a comment to D72321: Add test for GDB pretty printers..

This is cute. We should do something similar with the LLDB pretty printers.

Wed, Jan 8, 3:29 PM · Restricted Project
aprantl updated the diff for D71732: Move the sysroot attribute from DIModule to DICompileUnit.

Address feedback from Raphael.

Wed, Jan 8, 2:41 PM · Restricted Project, Restricted Project, Restricted Project, debug-info
aprantl committed rG28b9cdd26073: Delete dead code. (authored by aprantl).
Delete dead code.
Wed, Jan 8, 2:32 PM
aprantl added a comment to D71870: [llvm-locstats] Add the --compare option.

How ubiquitous is matplotlib? I wonder if it might be better to textually print out a gnuplot file or something similar. OTOH the surface area in the code seems to be really small, so this may be fine.

Wed, Jan 8, 2:04 PM · Restricted Project, debug-info
aprantl created D72413: Add missing nullptr checks..
Wed, Jan 8, 1:46 PM · Restricted Project

Dec 20 2019

aprantl committed rG44b4b833ad76: Rename DW_AT_LLVM_isysroot to DW_AT_LLVM_sysroot (authored by aprantl).
Rename DW_AT_LLVM_isysroot to DW_AT_LLVM_sysroot
Dec 20 2019, 1:26 PM
aprantl closed D71722: Rename DW_AT_LLVM_isysroot to DW_AT_LLVM_sysroot.
Dec 20 2019, 1:26 PM · Restricted Project, Restricted Project, Restricted Project, debug-info
aprantl added inline comments to D71575: [LLDB] Add ObjectFileWasm plugin for WebAssembly debugging.
Dec 20 2019, 1:04 PM · Restricted Project
aprantl added a comment to D71770: [lldb] Don't process symlinks deep inside DWARFUnit.

Does the mean these mappings will show up in the settings command?

Dec 20 2019, 1:04 PM · Restricted Project
aprantl accepted D71751: [lldb/DWARF] Fix mixed v4+v5 location lists.
Dec 20 2019, 1:04 PM · Restricted Project
aprantl accepted D71694: [objc_direct] Tigthen checks for direct methods.
Dec 20 2019, 8:19 AM · Restricted Project

Dec 19 2019

aprantl updated the diff for D71732: Move the sysroot attribute from DIModule to DICompileUnit.

Forgot to include the LLDB patch.

Dec 19 2019, 4:15 PM · Restricted Project, Restricted Project, Restricted Project, debug-info
aprantl added inline comments to D71732: Move the sysroot attribute from DIModule to DICompileUnit.
Dec 19 2019, 4:04 PM · Restricted Project, Restricted Project, Restricted Project, debug-info
aprantl added a parent revision for D71732: Move the sysroot attribute from DIModule to DICompileUnit: D71722: Rename DW_AT_LLVM_isysroot to DW_AT_LLVM_sysroot.
Dec 19 2019, 4:00 PM · Restricted Project, Restricted Project, Restricted Project, debug-info
aprantl added a child revision for D71722: Rename DW_AT_LLVM_isysroot to DW_AT_LLVM_sysroot: D71732: Move the sysroot attribute from DIModule to DICompileUnit.
Dec 19 2019, 4:00 PM · Restricted Project, Restricted Project, Restricted Project, debug-info
aprantl created D71732: Move the sysroot attribute from DIModule to DICompileUnit.
Dec 19 2019, 4:00 PM · Restricted Project, Restricted Project, Restricted Project, debug-info
Herald added a project to D54242: DebugInfo: Add a CU metadata attribute for use of DWARF ranges base address specifiers: Restricted Project.
Dec 19 2019, 3:30 PM · Restricted Project
aprantl updated subscribers of D71694: [objc_direct] Tigthen checks for direct methods.
Dec 19 2019, 2:01 PM · Restricted Project