Page MenuHomePhabricator
Feed Advanced Search

Today

erik.pilkington added a comment to D82611: [SemaObjC] Add a warning for @selector expressions that potentially refer to objc_direct methods.

So the risk with that one is that if someone had say the -didSomething direct selector and that some UIKit/Apple SDK API now adds this as a thing that you use with CFNotification center for example, where you _need_ dynamism, then the uses of the API would warn all the time when the internal to the client project -didSomething is in scope.

So we ideally need a way to silence this warning, so at the very least this needs to be a new -W flag (on by default (?)) so that callers that have an issue can use a _Pragma at the call site to ignore the error for when it's legal.

Mon, Jul 6, 10:25 AM
erik.pilkington updated the diff for D82611: [SemaObjC] Add a warning for @selector expressions that potentially refer to objc_direct methods.

Add an off-by-default variant of this warning.

Mon, Jul 6, 10:25 AM

Tue, Jun 30

erik.pilkington accepted D82823: canonicalize macOS 10.16 availability to macOS 11 while preserving uses of if @available macOS 10.16.

LGTM, after mine and Aaron's comments.

Tue, Jun 30, 9:15 AM

Thu, Jun 25

erik.pilkington added a comment to D76323: [AST] Fix handling of long double and bool in __builtin_bit_cast.

Ping, @rsmith did you want to take another look at this?

Thu, Jun 25, 4:56 PM
erik.pilkington created D82611: [SemaObjC] Add a warning for @selector expressions that potentially refer to objc_direct methods.
Thu, Jun 25, 4:56 PM
erik.pilkington accepted D77924: ld128 demangle: allow space for 'L' suffix..

LGTM, thanks for figuring this out!

Thu, Jun 25, 1:39 PM · Restricted Project, Restricted Project

Wed, Jun 24

erik.pilkington committed rG69d2fa9ed1c1: [SemaObjC] Fix a crash on invalid when 'auto' is used in a @property (authored by erik.pilkington).
[SemaObjC] Fix a crash on invalid when 'auto' is used in a @property
Wed, Jun 24, 9:43 AM

Sat, Jun 20

erik.pilkington added a comment to D81905: Enhance Itanium demangler interface..

I don't have a problem with adding an API like this in theory, but what exactly are you planning on using these for in an IR pass? If its to infer some semantic property of the symbol then there probably are better ways of expressing that, like getting the frontend to add metadata or a function attribute or something.

Sat, Jun 20, 4:57 PM · Restricted Project

Mon, Jun 15

erik.pilkington added inline comments to D77592: [clang] Frontend components for the relative vtables ABI.
Mon, Jun 15, 9:46 AM · Restricted Project

Fri, Jun 12

erik.pilkington created D81751: [SemaObjC] Fix a -Wobjc-signed-char-bool false-positive with binary conditional operator.
Fri, Jun 12, 11:26 AM

Thu, Jun 11

erik.pilkington committed rG95d7ccb70b9c: [PCH] Support writing BuiltinBitCastExprs to PCHs (authored by hyd-dev).
[PCH] Support writing BuiltinBitCastExprs to PCHs
Thu, Jun 11, 11:03 AM
erik.pilkington closed D80360: [PCH] Support writing BuiltinBitCastExprs to PCHs.
Thu, Jun 11, 11:02 AM · Restricted Project

Tue, Jun 9

erik.pilkington accepted D80360: [PCH] Support writing BuiltinBitCastExprs to PCHs.

LGTM (after a minor comment), thank you for fixing this!

Tue, Jun 9, 1:14 PM · Restricted Project

Mon, Jun 8

erik.pilkington committed rG8b529e311a90: [ObjC] Fix AST serialization for pseudo-strong parameters (authored by dgoldman).
[ObjC] Fix AST serialization for pseudo-strong parameters
Mon, Jun 8, 9:24 AM
erik.pilkington closed D74417: [clang][ARC] Remove invalid assertion that can crash clangd.
Mon, Jun 8, 9:23 AM · Restricted Project

May 14 2020

erik.pilkington added a comment to D74813: Function block naming - add hash of parameter type to end of block name.

Could I please get a review on this ? Thanks :) !

May 14 2020, 7:32 AM · Restricted Project, Restricted Project

May 13 2020

erik.pilkington committed rG1c1fb350c59a: [demangler] Support for 'this' expressions (authored by erik.pilkington).
[demangler] Support for 'this' expressions
May 13 2020, 7:39 PM
erik.pilkington committed rG15426b2161a4: [demangler] Fix demangling of enumerators with negative values (authored by erik.pilkington).
[demangler] Fix demangling of enumerators with negative values
May 13 2020, 11:58 AM

May 6 2020

erik.pilkington added a comment to D76323: [AST] Fix handling of long double and bool in __builtin_bit_cast.

Ping!

May 6 2020, 9:07 AM

May 5 2020

erik.pilkington committed rG873e27909539: [SemaObjC] Add a warning for dictionary literals with duplicate keys (authored by erik.pilkington).
[SemaObjC] Add a warning for dictionary literals with duplicate keys
May 5 2020, 12:58 PM
erik.pilkington committed rG86e50af72d0a: [AST] Print fixed enum type regardless of language mode (authored by erik.pilkington).
[AST] Print fixed enum type regardless of language mode
May 5 2020, 12:58 PM
erik.pilkington closed D78660: [SemaObjC] Add a warning for dictionary literals with duplicate keys.
May 5 2020, 12:58 PM · Restricted Project
erik.pilkington added inline comments to D78660: [SemaObjC] Add a warning for dictionary literals with duplicate keys.
May 5 2020, 6:25 AM · Restricted Project

May 1 2020

erik.pilkington added a comment to D78660: [SemaObjC] Add a warning for dictionary literals with duplicate keys.

Ping!

May 1 2020, 5:10 PM · Restricted Project

Apr 30 2020

erik.pilkington accepted D79166: [docs][llvm-cxxfilt] Document the --no-strip-underscore option.

LGTM, thanks!

Apr 30 2020, 6:46 AM · Restricted Project

Apr 29 2020

erik.pilkington edited reviewers for D74813: Function block naming - add hash of parameter type to end of block name, added: rjmccall; removed: Restricted Project.

@erik.pilkington would the hash-based numbering be OK for now ?

Apr 29 2020, 12:54 PM · Restricted Project, Restricted Project
erik.pilkington added a reviewer for D79094: [SemaObjC] Warn on visibility attributes on an @implementation: ahatanak.
Apr 29 2020, 10:43 AM
erik.pilkington created D79094: [SemaObjC] Warn on visibility attributes on an @implementation.
Apr 29 2020, 8:33 AM

Apr 28 2020

erik.pilkington committed rG2bb686b4b629: [AST] Fix a crash on a dependent vector_size attribute (authored by erik.pilkington).
[AST] Fix a crash on a dependent vector_size attribute
Apr 28 2020, 10:12 AM
erik.pilkington closed D79012: [AST] Fix a crash on a dependent vector_size attribute.
Apr 28 2020, 10:12 AM · Restricted Project
erik.pilkington created D79012: [AST] Fix a crash on a dependent vector_size attribute.
Apr 28 2020, 8:34 AM · Restricted Project

Apr 23 2020

erik.pilkington added inline comments to D74813: Function block naming - add hash of parameter type to end of block name.
Apr 23 2020, 9:43 AM · Restricted Project, Restricted Project

Apr 22 2020

erik.pilkington created D78660: [SemaObjC] Add a warning for dictionary literals with duplicate keys.
Apr 22 2020, 11:58 AM · Restricted Project
erik.pilkington accepted D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec..

LGTM, again :) Thanks for cleaning this up.

Apr 22 2020, 10:19 AM · Restricted Project, Restricted Project
erik.pilkington added a comment to D74813: Function block naming - add hash of parameter type to end of block name.

The demangler changes should also be made in libcxxabi/src/demangle, as there is a copy of the demangler there. This change also needs tests, there should be demangler tests (in libcxxabi/test/test_demangle.cpp), and IRGen tests (in clang/test/CodeGen) that check the mangled name. Finally, can you please add full contexts to your diffs? (by running e.g. git show -U99999).

Apr 22 2020, 9:12 AM · Restricted Project, Restricted Project

Apr 20 2020

erik.pilkington committed rG85cca945b4c9: [SemaObjC] Forbid storing an unboxed integer literal in an NSNumber (authored by erik.pilkington).
[SemaObjC] Forbid storing an unboxed integer literal in an NSNumber
Apr 20 2020, 12:28 PM
erik.pilkington closed D78066: [SemaObjC] Forbid storing an unboxed integer literal in an NSNumber.
Apr 20 2020, 12:28 PM · Restricted Project

Apr 15 2020

erik.pilkington added a comment to D76323: [AST] Fix handling of long double and bool in __builtin_bit_cast.

Ping!

Apr 15 2020, 9:50 AM

Apr 14 2020

erik.pilkington accepted D74163: [demangler] PPC and S390: Fix parsing of e-prefixed long double literals.

Please also commit this to llvm's copy of the demangler. You can copy the change over by running the cp-to-llvm.sh script.

Apr 14 2020, 3:12 PM · Restricted Project, Restricted Project, Restricted Project
erik.pilkington added inline comments to D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec..
Apr 14 2020, 6:22 AM · Restricted Project, Restricted Project

Apr 13 2020

erik.pilkington created D78066: [SemaObjC] Forbid storing an unboxed integer literal in an NSNumber.
Apr 13 2020, 5:24 PM · Restricted Project
erik.pilkington requested changes to D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec..
Apr 13 2020, 8:34 AM · Restricted Project, Restricted Project
erik.pilkington accepted D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec..

LGTM (after fixing those tests). Thanks for cleaning this up!

Apr 13 2020, 6:25 AM · Restricted Project, Restricted Project

Apr 12 2020

erik.pilkington added inline comments to D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec..
Apr 12 2020, 7:14 PM · Restricted Project, Restricted Project

Apr 11 2020

erik.pilkington added a comment to D77924: ld128 demangle: allow space for 'L' suffix..

Can you add your test to libcxxabi/test/test_demangle.pass.cpp? You can put it in invalid_cases if you expect it to fail to demangle.

Apr 11 2020, 11:43 AM · Restricted Project, Restricted Project

Apr 8 2020

erik.pilkington added a comment to D74813: Function block naming - add hash of parameter type to end of block name.

What do you think about using the block type instead of a hash? That should be stable across compiler versions, changes to the block body, and changes to referenced declarations. You'd still have to number blocks of the same type within the same function, but that should be a much smaller problem. It'd also allow demanglers to provide more information about the symbol, e.g. a demangler could print:

Apr 8 2020, 1:35 PM · Restricted Project, Restricted Project

Apr 7 2020

erik.pilkington added a comment to D76323: [AST] Fix handling of long double and bool in __builtin_bit_cast.

Ping!

Apr 7 2020, 11:23 AM
erik.pilkington accepted D77586: Allow parameter names to be elided in a function definition in C.

This also adds the same feature to ObjC blocks under the assumption that ObjC wishes to follow the C standard in this regard.

Apr 7 2020, 8:39 AM

Apr 6 2020

erik.pilkington committed rGd33c7de8e11f: [CodeGenObjC] Fix a crash when attempting to copy a zero-sized bit-field in a… (authored by erik.pilkington).
[CodeGenObjC] Fix a crash when attempting to copy a zero-sized bit-field in a…
Apr 6 2020, 1:05 PM
erik.pilkington closed D76782: [CodeGenObjC] Fix a crash when attempting to copy a zero-sized bit-field in a non-trivial C struct.
Apr 6 2020, 1:05 PM · Restricted Project
erik.pilkington updated the diff for D76782: [CodeGenObjC] Fix a crash when attempting to copy a zero-sized bit-field in a non-trivial C struct.

Don't bother including zero length bit-fields in the mangling of the copy/destroy helpers.

Apr 6 2020, 10:18 AM · Restricted Project

Apr 2 2020

erik.pilkington accepted D72872: [ObjC generics] Fix not inheriting type bounds in categories/extensions..

LGTM, sorry for the delay in reviewing this.

Apr 2 2020, 11:55 AM · Restricted Project

Mar 31 2020

erik.pilkington added inline comments to D76323: [AST] Fix handling of long double and bool in __builtin_bit_cast.
Mar 31 2020, 1:48 PM
erik.pilkington updated the diff for D76323: [AST] Fix handling of long double and bool in __builtin_bit_cast.

Address review comments.

Mar 31 2020, 1:48 PM

Mar 30 2020

erik.pilkington created D77070: [SemaObjC] Add a warning for declarations of BOOL:1 when BOOL is a signed char.
Mar 30 2020, 9:43 AM

Mar 25 2020

erik.pilkington created D76782: [CodeGenObjC] Fix a crash when attempting to copy a zero-sized bit-field in a non-trivial C struct.
Mar 25 2020, 10:16 AM · Restricted Project

Mar 24 2020

erik.pilkington committed rGde98cf92e301: [CodeGen] Add an alignment attribute to all sret parameters (authored by erik.pilkington).
[CodeGen] Add an alignment attribute to all sret parameters
Mar 24 2020, 12:55 PM
erik.pilkington closed D74183: [IRGen] Add an alignment attribute to underaligned sret parameters.
Mar 24 2020, 12:55 PM · Restricted Project

Mar 23 2020

erik.pilkington accepted D76643: [objc_direct] also go through implementations when looking for clashes.

LGTM

Mar 23 2020, 5:59 PM · Restricted Project
erik.pilkington added inline comments to D76323: [AST] Fix handling of long double and bool in __builtin_bit_cast.
Mar 23 2020, 7:36 AM
erik.pilkington updated the diff for D76323: [AST] Fix handling of long double and bool in __builtin_bit_cast.

Add tests for bit_cast<bool>((char)1);

Mar 23 2020, 7:36 AM

Mar 20 2020

erik.pilkington updated the diff for D74183: [IRGen] Add an alignment attribute to underaligned sret parameters.

Add alignment attribute to all sret parameters.

Mar 20 2020, 5:22 PM · Restricted Project

Mar 17 2020

erik.pilkington added inline comments to D75960: [libc++] Implement C++20's P0476r2: std::bit_cast.
Mar 17 2020, 2:35 PM · Restricted Project
erik.pilkington created D76323: [AST] Fix handling of long double and bool in __builtin_bit_cast.
Mar 17 2020, 2:35 PM

Mar 13 2020

erik.pilkington added inline comments to D75960: [libc++] Implement C++20's P0476r2: std::bit_cast.
Mar 13 2020, 10:44 AM · Restricted Project

Mar 10 2020

erik.pilkington committed rG75af694a6da5: [CodeGenObjC] Place property names in __objc_methname (authored by erik.pilkington).
[CodeGenObjC] Place property names in __objc_methname
Mar 10 2020, 2:48 PM
erik.pilkington added a comment to rGfafc6e4fdf36: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas.

This also fixes https://bugs.llvm.org/show_bug.cgi?id=44253. Is there any update on the ppc reproducer?

Mar 10 2020, 12:33 PM

Mar 9 2020

erik.pilkington committed rG7fbf15a8f2df: [CodeGenObjC] Privatize some ObjC metadata symbols (authored by erik.pilkington).
[CodeGenObjC] Privatize some ObjC metadata symbols
Mar 9 2020, 4:13 PM
erik.pilkington closed D75491: [CodeGenObjC] Privatize some ObjC metadata symbols.
Mar 9 2020, 4:13 PM · Restricted Project

Mar 2 2020

erik.pilkington committed rG29a4239d31c6: [Sema] Fix a crash when attaching comments to an implicit decl (authored by erik.pilkington).
[Sema] Fix a crash when attaching comments to an implicit decl
Mar 2 2020, 4:55 PM
erik.pilkington closed D75483: [Sema] Fix a crash when attaching comments to an implicit decl.
Mar 2 2020, 4:55 PM · Restricted Project
erik.pilkington added a comment to D75490: [clang] Skip implicit declarations when attaching doc comments.

It looks like this check is done already in getDeclLocForCommentSearch. Any reason to duplicate it?

Mar 2 2020, 4:55 PM
erik.pilkington created D75491: [CodeGenObjC] Privatize some ObjC metadata symbols.
Mar 2 2020, 4:38 PM · Restricted Project
erik.pilkington created D75483: [Sema] Fix a crash when attaching comments to an implicit decl.
Mar 2 2020, 2:56 PM · Restricted Project
erik.pilkington committed rGe392dcd5708b: [Sema] Look through OpaqueValueExpr when checking implicit conversions (authored by erik.pilkington).
[Sema] Look through OpaqueValueExpr when checking implicit conversions
Mar 2 2020, 11:38 AM
erik.pilkington closed D75387: [Sema] Look through OpaqueValueExpr when checking implicit conversions.
Mar 2 2020, 11:38 AM · Restricted Project

Feb 28 2020

erik.pilkington accepted D74417: [clang][ARC] Remove invalid assertion that can crash clangd.

Okay, I've added this, it seems to fix the test but I'm not sure if it's fully correct since the place where it was modified is under the VarDecl comment instead of ParmVarDecl.

Feb 28 2020, 4:16 PM · Restricted Project
erik.pilkington committed rG2e4f5e629de8: [Sema] Fix an assert when objc_externally_retained was applied to an… (authored by erik.pilkington).
[Sema] Fix an assert when objc_externally_retained was applied to an…
Feb 28 2020, 3:49 PM
erik.pilkington created D75387: [Sema] Look through OpaqueValueExpr when checking implicit conversions.
Feb 28 2020, 3:21 PM · Restricted Project

Feb 26 2020

erik.pilkington committed rG30f4362040fe: Disable memory leak checking in a test to work around a bot failure (authored by erik.pilkington).
Disable memory leak checking in a test to work around a bot failure
Feb 26 2020, 2:57 PM

Feb 14 2020

erik.pilkington accepted D73755: [objc_direct] Small updates to help with adoption..

LGTM, thanks.

Feb 14 2020, 3:52 PM · Restricted Project

Feb 13 2020

erik.pilkington added a comment to D74417: [clang][ARC] Remove invalid assertion that can crash clangd.

Added but it's still failing due to a different assertion failure, do you think this could be because the abbreviation is different for the ParamVars? I'm not sure how to handle this...

Feb 13 2020, 10:43 AM · Restricted Project

Feb 12 2020

erik.pilkington added inline comments to D73755: [objc_direct] Small updates to help with adoption..
Feb 12 2020, 4:58 PM · Restricted Project
erik.pilkington added a comment to D74417: [clang][ARC] Remove invalid assertion that can crash clangd.

This looks good, but please add a testcase.

Feb 12 2020, 3:27 PM · Restricted Project
erik.pilkington committed rGe26c24b84921: Revert "[IRGen] Emit lifetime intrinsics around temporary aggregate argument… (authored by erik.pilkington).
Revert "[IRGen] Emit lifetime intrinsics around temporary aggregate argument…
Feb 12 2020, 12:34 PM
erik.pilkington added a reverting change for rGfafc6e4fdf36: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas: rGe26c24b84921: Revert "[IRGen] Emit lifetime intrinsics around temporary aggregate argument….
Feb 12 2020, 12:34 PM
erik.pilkington added a comment to rGfafc6e4fdf36: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas.

This patch broke our multistage bot during stage 2 build: http://lab.llvm.org:8011/builders/clang-ppc64be-linux-multistage/builds/23546
We are investigating, please pull until we can provide a reproducer.

Feb 12 2020, 12:33 PM

Feb 10 2020

erik.pilkington accepted D74355: [ubsan] Null-check and adjust TypeLoc before using it.

LGTM!

Feb 10 2020, 2:06 PM · Restricted Project

Feb 7 2020

erik.pilkington committed rGfafc6e4fdf36: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas (authored by erik.pilkington).
[IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas
Feb 7 2020, 2:44 PM
erik.pilkington closed D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas.
Feb 7 2020, 2:43 PM · Restricted Project
erik.pilkington added inline comments to D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas.
Feb 7 2020, 11:39 AM · Restricted Project
erik.pilkington updated the diff for D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas.

Disable the optimization for non-trivially destructible types.

Feb 7 2020, 11:21 AM · Restricted Project

Feb 6 2020

erik.pilkington created D74183: [IRGen] Add an alignment attribute to underaligned sret parameters.
Feb 6 2020, 4:53 PM · Restricted Project
erik.pilkington planned changes to D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas.
Feb 6 2020, 12:05 PM · Restricted Project

Feb 5 2020

erik.pilkington created D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas.
Feb 5 2020, 3:11 PM · Restricted Project

Jan 16 2020

erik.pilkington added reviewers for D71566: New checks for fortified sprintf: aaron.ballman, rsmith.
Jan 16 2020, 9:48 PM · Restricted Project

Jan 9 2020

erik.pilkington committed rGeb9d2faaa3dc: Add support for constant discriminators in PointerAuthSchema (authored by erik.pilkington).
Add support for constant discriminators in PointerAuthSchema
Jan 9 2020, 4:55 PM
erik.pilkington committed rG771fed1834c9: NFC: get rid of the unnecessary union in PointerAuthSchema (authored by erik.pilkington).
NFC: get rid of the unnecessary union in PointerAuthSchema
Jan 9 2020, 4:55 PM
erik.pilkington committed rG183b5d38d7cf: [demangle] Copy back some NFC commits from LLVM (authored by erik.pilkington).
[demangle] Copy back some NFC commits from LLVM
Jan 9 2020, 10:43 AM

Dec 16 2019

erik.pilkington added a comment to D71566: New checks for fortified sprintf.

Thanks for working on this! I think this would be a really useful diagnostic to have.

Dec 16 2019, 5:03 PM · Restricted Project