Page MenuHomePhabricator
Feed Advanced Search

Today

kadircet accepted D114864: [clangd] IncludeClenaer: Don't mark forward declarations of a class if it's declared in the main file.

thanks, lgtm!

Thu, Dec 2, 1:03 AM · Restricted Project

Yesterday

kadircet added a comment to D114864: [clangd] IncludeClenaer: Don't mark forward declarations of a class if it's declared in the main file.

I can't fully remember the discussion but what about the case in which we don't have a declaration in the main file, but see a definition and multiple forward declarations. Is there a good reason to still include re-decls in this case?

Wed, Dec 1, 4:48 AM · Restricted Project
kadircet added a comment to D114724: [clangd][StdSymbolMap] Prefer std::remove from algorithm.

for whatever reason I remembered the std::remove to have been referenced ~17k. looks like these two are much closer. I don't think it makes sense to prefer one or the other here.

Wed, Dec 1, 1:00 AM · Restricted Project

Tue, Nov 30

kadircet added inline comments to D114724: [clangd][StdSymbolMap] Prefer std::remove from algorithm.
Tue, Nov 30, 2:38 AM · Restricted Project
kadircet committed rG3356d8837e46: [clangd] Make std symbol generation script python3 friendly (authored by kadircet).
[clangd] Make std symbol generation script python3 friendly
Tue, Nov 30, 1:16 AM
kadircet closed D114723: [clangd] Make std symbol generation script python3 friendly.
Tue, Nov 30, 1:16 AM · Restricted Project

Mon, Nov 29

kadircet requested review of D114724: [clangd][StdSymbolMap] Prefer std::remove from algorithm.
Mon, Nov 29, 10:22 AM · Restricted Project
kadircet requested review of D114723: [clangd] Make std symbol generation script python3 friendly.
Mon, Nov 29, 10:15 AM · Restricted Project

Fri, Nov 26

kadircet added a comment to D114522: [clangd] Add desugared type to hover.

My main remaining concern is just that this will trigger too often when there's no confusion over types, and clutter the display.
Some common cases I'm worried about:

  • std::string -> basic_string<char>. Maybe we should special-case this to hide the aka?
  • int64_t vs long long et al. I have no idea what to do about this.
Fri, Nov 26, 9:17 AM · Restricted Project, Restricted Project
kadircet added inline comments to D114621: [clangd] Show parameters for construct..
Fri, Nov 26, 8:21 AM · Restricted Project
kadircet added a comment to D114072: [clangd] Record IWYU pragma keep in the IncludeStructure.

Sorry for forgetting about this one. Hopefully I can still help now by disagreeing with Kadir and creating an awkward stalemate instead.

Fri, Nov 26, 5:34 AM · Restricted Project
kadircet added a comment to D114072: [clangd] Record IWYU pragma keep in the IncludeStructure.

It's annoying that we see comments and inclusion directives out-of-order, we can try fixing it on the parser side (I think it is incidental that these are issued in that order currently, they are eagerly trying to generate a fix/diagnostic for tokens after a pp-directive. hence we can first issue the PP callback, and then diagnose for rest of the line instead).
But I don't think it matters in the long run especially when we want to handle different types of pragmas in the future (which is the plan IIRC), they might not even necessarily be in the main file, let alone being seen with right sequencing.

Fri, Nov 26, 4:00 AM · Restricted Project
kadircet committed rGd026f2f7c688: [clang] Fix crash on broken parameter declarators (authored by kadircet).
[clang] Fix crash on broken parameter declarators
Fri, Nov 26, 2:04 AM
kadircet closed D114609: [clang] Fix crash on broken parameter declarators.
Fri, Nov 26, 2:04 AM · Restricted Project

Thu, Nov 25

kadircet requested review of D114609: [clang] Fix crash on broken parameter declarators.
Thu, Nov 25, 11:12 AM · Restricted Project
kadircet committed rGe2cad4df22a6: [clangd] Add ObjC method support to prepareCallHierarchy (authored by sheldonneuberger-sc).
[clangd] Add ObjC method support to prepareCallHierarchy
Thu, Nov 25, 2:25 AM
kadircet closed D114058: [clangd] Add ObjC method support to prepareCallHierarchy.
Thu, Nov 25, 2:25 AM · Restricted Project, Restricted Project
kadircet committed rGcdd37e2e47f7: [clangd] Disable hicpp-invalid-access-moved inside clangd (authored by kadircet).
[clangd] Disable hicpp-invalid-access-moved inside clangd
Thu, Nov 25, 1:33 AM

Wed, Nov 24

kadircet added a comment to D114525: [clang] Change ordering of PreableCallbacks to make sure PP can be referenced in them.

As discussed offline this definitely LGTM, let me summarize the reasoning here.

Wed, Nov 24, 5:07 AM · Restricted Project

Tue, Nov 23

kadircet accepted D114058: [clangd] Add ObjC method support to prepareCallHierarchy.

thanks, lgtm! let me know of your email address (for commit attribution) if you want me to land this for you.

Tue, Nov 23, 11:08 PM · Restricted Project, Restricted Project
kadircet added inline comments to D114058: [clangd] Add ObjC method support to prepareCallHierarchy.
Tue, Nov 23, 9:21 AM · Restricted Project, Restricted Project
kadircet added inline comments to D114370: [clangd] Record information about non self-contained headers in IncludeStructure.
Tue, Nov 23, 6:34 AM · Restricted Project, Restricted Project
kadircet added a comment to D114370: [clangd] Record information about non self-contained headers in IncludeStructure.

thanks, LG in general, just a couple polishing touches

Tue, Nov 23, 12:44 AM · Restricted Project, Restricted Project

Mon, Nov 22

kadircet added inline comments to D114326: Update the list of CUDA versions up to 11.5.
Mon, Nov 22, 2:36 AM · Restricted Project

Wed, Nov 17

kadircet committed rGe76e5729896c: [clangd] Dont include file version in task name (authored by kadircet).
[clangd] Dont include file version in task name
Wed, Nov 17, 10:17 AM
kadircet closed D113390: [clangd] Dont include file version in task name.
Wed, Nov 17, 10:17 AM · Restricted Project
kadircet accepted D113899: [NFC][clangd] fix clang-tidy finding on isa_and_nonnull.

thanks!

Wed, Nov 17, 10:12 AM · Restricted Project
kadircet accepted D113999: [clangd] Fix assertion crashes on unmatched NOLINTBEGIN comments..

thanks, lgtm!

Wed, Nov 17, 2:51 AM · Restricted Project
kadircet added a comment to D114058: [clangd] Add ObjC method support to prepareCallHierarchy.

I agree with Nathan on this one. It's unclear why there are two functions that does the same thing in different ways and some usages in sema looks suspicious enough to require caution (there are subtle checks for shadowing and whatnot and I don't know how these rules come into play in objc contexts).

Wed, Nov 17, 2:17 AM · Restricted Project, Restricted Project

Tue, Nov 16

kadircet accepted D113895: [NFC][clangd] fix llvm-namespace-comment finding.
Tue, Nov 16, 6:33 AM · Restricted Project

Mon, Nov 15

kadircet accepted D113891: [NFC][clangd] cleaning up unused "using".

thanks!

Mon, Nov 15, 7:28 AM · Restricted Project

Sat, Nov 13

kadircet accepted D113765: [clangd] Fix function-arg-placeholder suppression with macros..
Sat, Nov 13, 10:31 AM · Restricted Project

Fri, Nov 12

kadircet added inline comments to D113765: [clangd] Fix function-arg-placeholder suppression with macros..
Fri, Nov 12, 6:30 AM · Restricted Project
kadircet committed rGebda5e1e521f: [clangd] Fix use-after-free in test (authored by kadircet).
[clangd] Fix use-after-free in test
Fri, Nov 12, 5:51 AM
kadircet committed rG7d668ae38d2d: [clangd] Mark macros from preamble for code completion (authored by kadircet).
[clangd] Mark macros from preamble for code completion
Fri, Nov 12, 5:07 AM
kadircet closed D113555: [clangd] Mark macros from preamble for code completion.
Fri, Nov 12, 5:07 AM · Restricted Project
kadircet updated subscribers of D113645: [clangd] Allow Unix config paths on Darwin.

I got a couple of concerns about the general ideas in the change. Even though the convenience of using ~/.config/clangd/config.yaml seems nice, I think it'll just end up creating confusion in the long run.

Fri, Nov 12, 1:26 AM · Restricted Project, Restricted Project

Wed, Nov 10

kadircet requested review of D113555: [clangd] Mark macros from preamble for code completion.
Wed, Nov 10, 3:12 AM · Restricted Project

Mon, Nov 8

kadircet requested review of D113390: [clangd] Dont include file version in task name.
Mon, Nov 8, 2:20 AM · Restricted Project
kadircet accepted D113120: [clang] Add early exit when checking for const init of arrays..

thanks, lgtm!

Mon, Nov 8, 2:10 AM · Restricted Project

Thu, Nov 4

kadircet added a comment to D113120: [clang] Add early exit when checking for const init of arrays..

thanks this looks amazing! i am also not an expert in these parts of the code but AFAICT the proposed behavior is in line with the contract. i am a little worried about the cost of extra copy (especially when there are only a handful of elements), but it should be probably fine.

Thu, Nov 4, 6:05 AM · Restricted Project
kadircet accepted D113029: [clangd] Find definition of ClassTemplate without going through index..

thanks, lgtm!

Thu, Nov 4, 3:46 AM · Restricted Project

Oct 29 2021

kadircet requested review of D112835: [clangd] Record time spent in tidy checks.
Oct 29 2021, 10:20 AM · Restricted Project
kadircet accepted D112783: [clangd] Track performance of IncludeCleaner.

oops forgot to LGTM, thanks!

Oct 29 2021, 3:49 AM · Restricted Project
kadircet added inline comments to D112783: [clangd] Track performance of IncludeCleaner.
Oct 29 2021, 2:26 AM · Restricted Project

Oct 28 2021

kadircet committed rG3d735480bd2a: [clangd] SelectionTree should prefer lexical declcontext (authored by kadircet).
[clangd] SelectionTree should prefer lexical declcontext
Oct 28 2021, 8:40 AM
kadircet closed D112712: [clangd] SelectionTree should prefer lexical declcontext.
Oct 28 2021, 8:40 AM · Restricted Project
kadircet added inline comments to D112712: [clangd] SelectionTree should prefer lexical declcontext.
Oct 28 2021, 8:40 AM · Restricted Project
kadircet added inline comments to D112707: [clangd] IncludeCleaner: Be more conservative in marking RecordDecl usage.
Oct 28 2021, 6:37 AM · Restricted Project
kadircet updated the diff for D112712: [clangd] SelectionTree should prefer lexical declcontext.
Oct 28 2021, 5:59 AM · Restricted Project
kadircet requested review of D112712: [clangd] SelectionTree should prefer lexical declcontext.
Oct 28 2021, 5:58 AM · Restricted Project
kadircet committed rGfbf1745722a0: [clangd] Escape error message in AddUsing (authored by kadircet).
[clangd] Escape error message in AddUsing
Oct 28 2021, 5:53 AM

Oct 27 2021

kadircet accepted D112608: [clangd] IncludeCleaner: Do not process locations in built-in files.

thanks, lgtm!

Oct 27 2021, 10:24 AM · Restricted Project
kadircet accepted D112565: [clangd] Add integration test for crash handling.

thanks, lgtm!

Oct 27 2021, 1:51 AM · Restricted Project
kadircet committed rGe42f5d4b488e: [clangd] Fix filename ranges while replaying preamble (authored by kadircet).
[clangd] Fix filename ranges while replaying preamble
Oct 27 2021, 12:39 AM
kadircet closed D112559: [clangd] Fix filename ranges while replaying preamble.
Oct 27 2021, 12:39 AM · Restricted Project

Oct 26 2021

kadircet added a comment to D112530: [clangd] AddUsing: Fix support for template specializations..

(oops, i didn't notice i wasn't the reviewer :D)

Oct 26 2021, 11:03 AM · Restricted Project
kadircet requested review of D112559: [clangd] Fix filename ranges while replaying preamble.
Oct 26 2021, 10:12 AM · Restricted Project
kadircet accepted D112530: [clangd] AddUsing: Fix support for template specializations..

thanks!

Oct 26 2021, 7:31 AM · Restricted Project
kadircet accepted D112527: [clangd] Fix a hover crash on templated spaceship operator..
Oct 26 2021, 7:18 AM · Restricted Project
kadircet accepted D111711: [clangd] IncludeCleaner: Don't consider the definition as usage for function forward declarations.

thanks, lgtm!

Oct 26 2021, 1:17 AM · Restricted Project

Oct 25 2021

kadircet resigned from D111120: [clangd] Find explicit references in the base-specifier of an enum decl.

I suppose this is obseleted by https://reviews.llvm.org/D111260

Oct 25 2021, 8:14 AM · Restricted Project
kadircet closed D111224: [clang] Traverse enum integer-base specifiers in RAV.

Landed as https://github.com/llvm/llvm-project/commit/4e4511df8d33a6fc02d5e46c681855db495187cd

Oct 25 2021, 8:13 AM · Restricted Project, Restricted Project
kadircet accepted D112403: [clangd] Respect diagnostic suppression during preamble build.

Thanks for fixing this, LGTM! (This also reminds me that we should probably invalidate preambles on config changes one day)

Oct 25 2021, 8:11 AM · Restricted Project
kadircet committed rG333c36bec09a: [clang][unittests] Fix shared lib builds (authored by kadircet).
[clang][unittests] Fix shared lib builds
Oct 25 2021, 6:10 AM
kadircet committed rG9ab9caf214f4: [clang] Visit enum base specifiers in libIndex (authored by kadircet).
[clang] Visit enum base specifiers in libIndex
Oct 25 2021, 4:17 AM
kadircet committed rG4e4511df8d33: [clang] Traverse enum base specifier in RAV (authored by kadircet).
[clang] Traverse enum base specifier in RAV
Oct 25 2021, 4:17 AM
kadircet committed rGffa96f022c3f: [clang] Fix range for forward-declared enums (authored by kadircet).
[clang] Fix range for forward-declared enums
Oct 25 2021, 4:17 AM
kadircet closed D111260: [clang] Visit enum base specifiers in libIndex.
Oct 25 2021, 4:17 AM · Restricted Project, Restricted Project
kadircet closed D111259: [clang] Fix range for forward-declared enums.
Oct 25 2021, 4:16 AM · Restricted Project

Oct 20 2021

kadircet committed rG60e19f6752b7: [clangd] Fix use-after-free in HeaderIncluderCache (authored by kadircet).
[clangd] Fix use-after-free in HeaderIncluderCache
Oct 20 2021, 7:36 AM
kadircet closed D112130: [clangd] Fix use-after-free in HeaderIncluderCache.
Oct 20 2021, 7:36 AM · Restricted Project
kadircet added inline comments to D112130: [clangd] Fix use-after-free in HeaderIncluderCache.
Oct 20 2021, 7:36 AM · Restricted Project
kadircet committed rGc959da9ef344: [clangd] Only publish preamble after rebuilds (authored by kadircet).
[clangd] Only publish preamble after rebuilds
Oct 20 2021, 7:34 AM
kadircet closed D112137: [clangd] Only publish preamble after rebuilds.
Oct 20 2021, 7:34 AM · Restricted Project
kadircet requested review of D112137: [clangd] Only publish preamble after rebuilds.
Oct 20 2021, 6:13 AM · Restricted Project
kadircet updated the diff for D112130: [clangd] Fix use-after-free in HeaderIncluderCache.
  • Rather than dropping the entry, perform an extra check during invalidate. As

the entry actually backs the data for main file strings in associations.

Oct 20 2021, 4:31 AM · Restricted Project
kadircet requested review of D112130: [clangd] Fix use-after-free in HeaderIncluderCache.
Oct 20 2021, 3:54 AM · Restricted Project

Oct 19 2021

kadircet accepted D110823: [clangd] Add code completion of param name on /* inside function calls..

thanks, LGTM!

Oct 19 2021, 1:42 AM · Restricted Project

Oct 8 2021

kadircet added a comment to D110823: [clangd] Add code completion of param name on /* inside function calls..

thanks, mostly LG, a couple of nits :)

Oct 8 2021, 9:41 AM · Restricted Project

Oct 6 2021

kadircet updated the diff for D111260: [clang] Visit enum base specifiers in libIndex.
  • Improve tests
Oct 6 2021, 1:08 PM · Restricted Project, Restricted Project
kadircet requested review of D111260: [clang] Visit enum base specifiers in libIndex.
Oct 6 2021, 1:05 PM · Restricted Project, Restricted Project
kadircet added a reviewer for D111224: [clang] Traverse enum integer-base specifiers in RAV: sammccall.
Oct 6 2021, 1:04 PM · Restricted Project, Restricted Project
kadircet updated the diff for D111224: [clang] Traverse enum integer-base specifiers in RAV.
  • split changes in libindex
  • fix the issue with non-traversal of forward-decls
  • add unittests into RAV
Oct 6 2021, 1:04 PM · Restricted Project, Restricted Project
kadircet requested review of D111259: [clang] Fix range for forward-declared enums.
Oct 6 2021, 1:01 PM · Restricted Project
kadircet updated the diff for D111224: [clang] Traverse enum integer-base specifiers in RAV.
  • Fix tests
Oct 6 2021, 6:48 AM · Restricted Project, Restricted Project
kadircet requested review of D111224: [clang] Traverse enum integer-base specifiers in RAV.
Oct 6 2021, 5:58 AM · Restricted Project, Restricted Project

Oct 5 2021

kadircet added inline comments to D110823: [clangd] Add code completion of param name on /* inside function calls..
Oct 5 2021, 2:11 AM · Restricted Project
kadircet accepted D111039: [clangd] Include refs of base method in refs for derived method..

thanks, lgtm!

Oct 5 2021, 1:25 AM · Restricted Project

Oct 4 2021

kadircet added inline comments to D111039: [clangd] Include refs of base method in refs for derived method..
Oct 4 2021, 1:46 AM · Restricted Project

Oct 1 2021

kadircet committed rG512aa8485010: [clangd] Handle members of anon structs in SelectionTree (authored by kadircet).
[clangd] Handle members of anon structs in SelectionTree
Oct 1 2021, 3:45 AM
kadircet closed D110825: [clangd] Handle members of anon structs in SelectionTree.
Oct 1 2021, 3:45 AM · Restricted Project
kadircet updated the diff for D110825: [clangd] Handle members of anon structs in SelectionTree.
  • update comments
Oct 1 2021, 1:18 AM · Restricted Project

Sep 30 2021

kadircet added inline comments to D110825: [clangd] Handle members of anon structs in SelectionTree.
Sep 30 2021, 8:47 AM · Restricted Project
kadircet updated the diff for D110825: [clangd] Handle members of anon structs in SelectionTree.
  • Use isImplicit rather than earlyClaim
Sep 30 2021, 8:47 AM · Restricted Project
kadircet added inline comments to D110825: [clangd] Handle members of anon structs in SelectionTree.
Sep 30 2021, 7:14 AM · Restricted Project
kadircet updated the summary of D110825: [clangd] Handle members of anon structs in SelectionTree.
Sep 30 2021, 6:29 AM · Restricted Project
kadircet added inline comments to D110825: [clangd] Handle members of anon structs in SelectionTree.
Sep 30 2021, 6:28 AM · Restricted Project
kadircet requested review of D110825: [clangd] Handle members of anon structs in SelectionTree.
Sep 30 2021, 6:27 AM · Restricted Project

Sep 29 2021

kadircet accepted D110711: [VFS] InMemoryFilesystem's UniqueIDs are a function of path and content..

thanks, lgtm!

Sep 29 2021, 7:39 AM · Restricted Project