Page MenuHomePhabricator
Feed Advanced Search

Jul 29 2021

mleair requested review of D107120: [flang] Fix warnings as errors in ARM build of reduction unit tests..
Jul 29 2021, 5:23 PM · Restricted Project, Restricted Project
mleair updated the summary of D107107: [flang] Fix all/any scalar unit tests.
Jul 29 2021, 2:49 PM · Restricted Project, Restricted Project
mleair updated subscribers of D106820: [flang] Fix runtime ICE with maxloc and scalar result.

Yes. I saw the failure and I think I have a fix for this. It's out for review now.

Jul 29 2021, 2:45 PM · Restricted Project, Restricted Project
mleair added reviewers for D107107: [flang] Fix all/any scalar unit tests: klausler, PeteSteinfeld, schweitz.
Jul 29 2021, 2:36 PM · Restricted Project, Restricted Project
mleair requested review of D107107: [flang] Fix all/any scalar unit tests.
Jul 29 2021, 2:34 PM · Restricted Project, Restricted Project

Jul 28 2021

mleair updated the diff for D106820: [flang] Fix runtime ICE with maxloc and scalar result.

Simplify the bug fix by changing the assert condition in the applicable INTERNAL_CHECK usages.

Jul 28 2021, 11:55 AM · Restricted Project, Restricted Project
mleair added inline comments to D106820: [flang] Fix runtime ICE with maxloc and scalar result.
Jul 28 2021, 10:12 AM · Restricted Project, Restricted Project

Jul 26 2021

mleair added inline comments to D106820: [flang] Fix runtime ICE with maxloc and scalar result.
Jul 26 2021, 4:24 PM · Restricted Project, Restricted Project
mleair added inline comments to D106820: [flang] Fix runtime ICE with maxloc and scalar result.
Jul 26 2021, 4:16 PM · Restricted Project, Restricted Project
mleair updated the summary of D106820: [flang] Fix runtime ICE with maxloc and scalar result.
Jul 26 2021, 12:36 PM · Restricted Project, Restricted Project
mleair updated the summary of D106820: [flang] Fix runtime ICE with maxloc and scalar result.
Jul 26 2021, 12:33 PM · Restricted Project, Restricted Project
mleair requested review of D106820: [flang] Fix runtime ICE with maxloc and scalar result.
Jul 26 2021, 12:31 PM · Restricted Project, Restricted Project

Jul 21 2021

mleair accepted D106292: [flang] Implement the runtime portion of the CSHIFT intrinsic.

LGTM

Jul 21 2021, 1:10 PM · Restricted Project, Restricted Project

Jul 19 2021

mleair added inline comments to D106294: [flang] Implement the runtime portion of the UNPACK intrinsic.
Jul 19 2021, 12:14 PM · Restricted Project, Restricted Project
mleair added inline comments to D106294: [flang] Implement the runtime portion of the UNPACK intrinsic.
Jul 19 2021, 12:12 PM · Restricted Project, Restricted Project
mleair added inline comments to D106292: [flang] Implement the runtime portion of the CSHIFT intrinsic.
Jul 19 2021, 11:40 AM · Restricted Project, Restricted Project

Jul 16 2021

mleair closed D105837: [flang] Add scalar argument case for the Fortran Spread intrinsic unit test.

Close by commit: https://github.com/llvm/llvm-project/commit/d0f1ae6eb6eab82d2f67c61260087353a46d48ec

Jul 16 2021, 12:55 PM · Restricted Project

Jul 12 2021

mleair requested review of D105837: [flang] Add scalar argument case for the Fortran Spread intrinsic unit test.
Jul 12 2021, 12:48 PM · Restricted Project

Jun 24 2021

mleair added a comment to D104586: [flang] Update Reshape runtime library routine and its corresponding unit test.

@klausler @jeanPerier @PeteSteinfeld Do you have any more comments?

Jun 24 2021, 9:11 AM · Restricted Project, Restricted Project

Jun 22 2021

mleair updated the diff for D104586: [flang] Update Reshape runtime library routine and its corresponding unit test.

Incorporate comments from previous diff.

Jun 22 2021, 7:05 PM · Restricted Project, Restricted Project
mleair added a comment to D104586: [flang] Update Reshape runtime library routine and its corresponding unit test.

Looks good to me.

Jun 22 2021, 6:51 PM · Restricted Project, Restricted Project

Jun 19 2021

mleair updated the diff for D104586: [flang] Update Reshape runtime library routine and its corresponding unit test.

fix address calculation for order argument.

Jun 19 2021, 12:53 AM · Restricted Project, Restricted Project

Jun 18 2021

mleair updated the diff for D104586: [flang] Update Reshape runtime library routine and its corresponding unit test.

Remove unneeded check on pad.

Jun 18 2021, 11:43 PM · Restricted Project, Restricted Project
mleair added a reviewer for D104586: [flang] Update Reshape runtime library routine and its corresponding unit test: PeteSteinfeld.
Jun 18 2021, 7:32 PM · Restricted Project, Restricted Project
mleair updated the diff for D104586: [flang] Update Reshape runtime library routine and its corresponding unit test.

incorporate lint comments.

Jun 18 2021, 7:23 PM · Restricted Project, Restricted Project
mleair updated subscribers of D104586: [flang] Update Reshape runtime library routine and its corresponding unit test.
Jun 18 2021, 7:10 PM · Restricted Project, Restricted Project
mleair requested review of D104586: [flang] Update Reshape runtime library routine and its corresponding unit test.
Jun 18 2021, 7:03 PM · Restricted Project, Restricted Project