Made changes to review suggested in the patch for Vector Function ABI Name Demangling patch.
[https://reviews.llvm.org/D66024].
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Aug 23 2019
Aug 23 2019
aranisumedh updated the diff for D66025: SVFS implementation according to RFC: Interface user provided vector functions with the vectorizer..
Aug 23 2019, 2:23 PM · Restricted Project
Minor Update. Cosmetic changes.
Aug 23 2019, 2:15 PM · Restricted Project
Had a minor bug in the previous patch. Updated it.
Aug 23 2019, 11:47 AM · Restricted Project
Aug 22 2019
Aug 22 2019
Thank you all for valuable comments. I have made the changes as requested so far.
Aug 22 2019, 11:31 PM · Restricted Project
Aug 13 2019
Aug 13 2019
Aug 13 2019, 9:00 AM · Restricted Project
Aug 12 2019
Aug 12 2019
Aug 12 2019, 9:54 AM · Restricted Project
Aug 9 2019
Aug 9 2019
All the parsing code is always extremely prone to subtle bugs.
At least it should not crash on them.
That would be easy to ensure via a fuzz target.
Aug 9 2019, 2:15 PM · Restricted Project
- Could you elaborate about the fuzzer target? The VFABI::getVectorName() extracts the custom redirection to a user-specified function that can be described using #pragma declare variant
- If I understood you correctly, yes, this name mangling format is as specified in the ABI. It is also supported by other implementations such as GCC. The following link is a demonstration of the same which uses GCC compiler. [https://godbolt.org/z/PrGLn0]
Aug 9 2019, 1:37 PM · Restricted Project
aranisumedh created D66025: SVFS implementation according to RFC: Interface user provided vector functions with the vectorizer..
Aug 9 2019, 12:48 PM · Restricted Project
Aug 9 2019, 12:42 PM · Restricted Project
aranisumedh added inline comments to D64095: SVFS implementation according to RFC: Interface user provided vector functions with the vectorizer..
Aug 9 2019, 12:20 PM · Restricted Project
Aug 6 2019
Aug 6 2019
aranisumedh added inline comments to D64095: SVFS implementation according to RFC: Interface user provided vector functions with the vectorizer..
Aug 6 2019, 11:07 AM · Restricted Project
aranisumedh planned changes to D64095: SVFS implementation according to RFC: Interface user provided vector functions with the vectorizer..
As suggested earlier by Sander, I'll be splitting this patch into two patches for easier review.
Aug 6 2019, 8:43 AM · Restricted Project
Aug 1 2019
Aug 1 2019
aranisumedh added inline comments to D64095: SVFS implementation according to RFC: Interface user provided vector functions with the vectorizer..
Aug 1 2019, 12:37 PM · Restricted Project
Jul 31 2019
Jul 31 2019
aranisumedh awarded D64095: SVFS implementation according to RFC: Interface user provided vector functions with the vectorizer. a Yellow Medal token.
Jul 31 2019, 2:52 PM · Restricted Project
aranisumedh updated the diff for D64095: SVFS implementation according to RFC: Interface user provided vector functions with the vectorizer..
Minor changes as suggested in the recent review.
Jul 31 2019, 2:46 PM · Restricted Project
aranisumedh added inline comments to D64095: SVFS implementation according to RFC: Interface user provided vector functions with the vectorizer..
Jul 31 2019, 2:41 PM · Restricted Project
aranisumedh updated the diff for D64095: SVFS implementation according to RFC: Interface user provided vector functions with the vectorizer..
Thank you for valuable inputs. Sorry for the delay in getting back to you.
Jul 31 2019, 1:41 PM · Restricted Project
aranisumedh added inline comments to D64095: SVFS implementation according to RFC: Interface user provided vector functions with the vectorizer..
Jul 31 2019, 1:20 PM · Restricted Project
Jul 15 2019
Jul 15 2019
aranisumedh added inline comments to D64095: SVFS implementation according to RFC: Interface user provided vector functions with the vectorizer..
Jul 15 2019, 9:50 AM · Restricted Project
Jul 12 2019
Jul 12 2019
aranisumedh added inline comments to D64095: SVFS implementation according to RFC: Interface user provided vector functions with the vectorizer..
Jul 12 2019, 12:15 PM · Restricted Project
aranisumedh updated the diff for D64095: SVFS implementation according to RFC: Interface user provided vector functions with the vectorizer..
Added code to expose the functionality as an Analysis Pass. Integrated changes as suggested in prior code review.
Jul 12 2019, 12:09 PM · Restricted Project
Jul 2 2019
Jul 2 2019