Page MenuHomePhabricator
Feed Advanced Search

Mon, Jun 29

AndreyChurbanov committed rG7f3d9cc1c059: [openmp][NFC] Cleanup: guard __kmp_mic_type by KMP_MIC_SUPPORTED macro. (authored by AndreyChurbanov).
[openmp][NFC] Cleanup: guard __kmp_mic_type by KMP_MIC_SUPPORTED macro.
Mon, Jun 29, 4:18 AM
AndreyChurbanov closed D82301: [OpenMP][NFC] Cleanup: put two more usages of __kmp_mic_type under KMP_MIC_SUPPORTED macro..
Mon, Jun 29, 4:17 AM · Restricted Project

Mon, Jun 22

AndreyChurbanov created D82301: [OpenMP][NFC] Cleanup: put two more usages of __kmp_mic_type under KMP_MIC_SUPPORTED macro..
Mon, Jun 22, 7:30 AM · Restricted Project

Sun, Jun 14

AndreyChurbanov accepted D81804: [OpenMP][Tests] fix data race in a OpenMP runtime test.

LGTM

Sun, Jun 14, 1:52 PM · Restricted Project

Fri, Jun 12

AndreyChurbanov accepted D81497: [OpenMP] support alloc of serialized tasks.

LGTM

Fri, Jun 12, 6:26 AM · Restricted Project

Wed, Jun 10

AndreyChurbanov added inline comments to D81497: [OpenMP] support alloc of serialized tasks.
Wed, Jun 10, 12:46 PM · Restricted Project

Jun 4 2020

AndreyChurbanov committed rGabe64360ae13: [openmp] Fixed nonmonotonic schedule implementation. (authored by AndreyChurbanov).
[openmp] Fixed nonmonotonic schedule implementation.
Jun 4 2020, 5:58 AM
AndreyChurbanov closed D80942: [openmp] Fixed nonmonotonic schedule implementation..
Jun 4 2020, 5:58 AM · Restricted Project

Jun 1 2020

AndreyChurbanov created D80942: [openmp] Fixed nonmonotonic schedule implementation..
Jun 1 2020, 11:52 AM · Restricted Project
AndreyChurbanov committed rG5e111c5df8ef: [openmp] Fixed taskloop recursive splitting so that taskloop tasks have same… (authored by AndreyChurbanov).
[openmp] Fixed taskloop recursive splitting so that taskloop tasks have same…
Jun 1 2020, 8:01 AM
AndreyChurbanov closed D80577: [OpenMP] Fixed taskloop recursive splitting so that taskloop tasks have same parent tasks..
Jun 1 2020, 8:01 AM · Restricted Project
AndreyChurbanov updated the summary of D80577: [OpenMP] Fixed taskloop recursive splitting so that taskloop tasks have same parent tasks..
Jun 1 2020, 8:00 AM · Restricted Project

May 27 2020

AndreyChurbanov added inline comments to D80222: Replace Clang's createRuntimeFunction with the definitions in OMPKinds.def.
May 27 2020, 11:56 AM · Restricted Project, Restricted Project, Restricted Project

May 26 2020

AndreyChurbanov created D80577: [OpenMP] Fixed taskloop recursive splitting so that taskloop tasks have same parent tasks..
May 26 2020, 10:49 AM · Restricted Project

May 25 2020

AndreyChurbanov accepted D80480: [OpenMP] Fix a race in task queue reallocation.

LGTM

May 25 2020, 1:01 AM · Restricted Project

May 24 2020

AndreyChurbanov added a comment to D80480: [OpenMP] Fix a race in task queue reallocation.

Also may worth adding the test just in case.

May 24 2020, 1:20 PM · Restricted Project
AndreyChurbanov added inline comments to D80480: [OpenMP] Fix a race in task queue reallocation.
May 24 2020, 1:20 PM · Restricted Project

May 18 2020

AndreyChurbanov committed rG57d8b8d6f0b9: [openmp] Fixed hang if detached task was serialized. (authored by AndreyChurbanov).
[openmp] Fixed hang if detached task was serialized.
May 18 2020, 5:53 AM
AndreyChurbanov closed D79944: [OpenMP] Fix for https://bugs.llvm.org/show_bug.cgi?id=45904..
May 18 2020, 5:53 AM · Restricted Project
AndreyChurbanov added a comment to D79944: [OpenMP] Fix for https://bugs.llvm.org/show_bug.cgi?id=45904..

Does -fopenmp-version work with the Intel Compiler? How will this work if the GCC eventually gets support for OpenMP 5.0?

May 18 2020, 5:52 AM · Restricted Project
AndreyChurbanov updated the diff for D79944: [OpenMP] Fix for https://bugs.llvm.org/show_bug.cgi?id=45904..

Comments addressed.

May 18 2020, 5:20 AM · Restricted Project

May 14 2020

AndreyChurbanov retitled D79944: [OpenMP] Fix for https://bugs.llvm.org/show_bug.cgi?id=45904. from Fix for https://bugs.llvm.org/show_bug.cgi?id=45904. to [OpenMP] Fix for https://bugs.llvm.org/show_bug.cgi?id=45904..
May 14 2020, 8:38 AM · Restricted Project
AndreyChurbanov created D79944: [OpenMP] Fix for https://bugs.llvm.org/show_bug.cgi?id=45904..
May 14 2020, 8:38 AM · Restricted Project

May 12 2020

AndreyChurbanov added inline comments to D79702: [OpenMP] Fix race condition in the completion/freeing of detached tasks.
May 12 2020, 10:11 AM · Restricted Project
AndreyChurbanov accepted D79702: [OpenMP] Fix race condition in the completion/freeing of detached tasks.

Joachim, thanks for taking care of this bug.

May 12 2020, 7:29 AM · Restricted Project

Apr 15 2020

AndreyChurbanov accepted D76755: Fix build on macOS sdk 10.12 and newer.

LGTM

Apr 15 2020, 10:56 AM · Restricted Project

Apr 13 2020

AndreyChurbanov added a comment to D77603: [OpenMP] Sync writes to child thread's data before reduction.

Should I also add memory barriers to __kmp_linear_barrier_gather_template, __kmp_tree_barrier_gather, and __kmp_hierarchical_barrier_gather? They seem to suffer from the same problem on systems with weak memory order (but I don't have a handy test case to prove it).

Apr 13 2020, 1:40 PM · Restricted Project
AndreyChurbanov accepted D77603: [OpenMP] Sync writes to child thread's data before reduction.

LGTM

Apr 13 2020, 10:47 AM · Restricted Project
AndreyChurbanov requested changes to D77603: [OpenMP] Sync writes to child thread's data before reduction.

Sorry, found one more issue.

Apr 13 2020, 5:52 AM · Restricted Project
AndreyChurbanov accepted D77603: [OpenMP] Sync writes to child thread's data before reduction.

May worth waiting for a day or two for others' comments, up to you.

Apr 13 2020, 5:20 AM · Restricted Project

Apr 8 2020

AndreyChurbanov added a comment to D77603: [OpenMP] Sync writes to child thread's data before reduction.

I don't see paired memory barrier in a child thread between assigning th.th_local.reduce_data in __kmp_barrier_template() and releasing b_arrived barrier flag that frees parent to go to reduce data. So it might be that the problem could just become lesser probable. Should paired KMP_MB be added after the reduce_data assignment? Or does atomic releasing of a flag serves as a memory barrier? Then my assumption is wrong and second MB is not needed.

Apr 8 2020, 2:42 PM · Restricted Project
AndreyChurbanov added a comment to D77609: [OpenMP] Added the support for unshackled task in RTL.

Could you please tell which part is monitor thread?

Code under "#if KMP_USE_MONITOR" implements monitor thread which used earlier to control behavior of worker threads. Now it is not used by default, and worker threads follow requested wait policy themselves.

Apr 8 2020, 7:02 AM · Restricted Project

Apr 7 2020

AndreyChurbanov added a comment to D77609: [OpenMP] Added the support for unshackled task in RTL.

The idea looks feasible to me in general.

Apr 7 2020, 1:03 PM · Restricted Project

Apr 2 2020

AndreyChurbanov added a comment to D77333: OpenMP: Support FreeBSD on AArch64..

Could you please run clang-format on the changes (new lines are too long). Thanks.

Apr 2 2020, 1:33 PM · Restricted Project

Mar 25 2020

AndreyChurbanov added inline comments to D76755: Fix build on macOS sdk 10.12 and newer.
Mar 25 2020, 6:59 AM · Restricted Project

Mar 23 2020

AndreyChurbanov committed rGae044467ede1: [openmp][runtime] Fixed hang for explicit task inside a taskloop. (authored by AndreyChurbanov).
[openmp][runtime] Fixed hang for explicit task inside a taskloop.
Mar 23 2020, 10:23 AM
AndreyChurbanov closed D75673: [runtime] Fixed hang when explicit task created inside a taskloop..
Mar 23 2020, 10:22 AM · Restricted Project

Mar 18 2020

AndreyChurbanov updated the diff for D75673: [runtime] Fixed hang when explicit task created inside a taskloop..

Adde check of task tiedness, and comment on why this is needed.

Mar 18 2020, 8:42 AM · Restricted Project
AndreyChurbanov added a comment to D62485: New implementation of OpenMP 5.0 detached tasks..

Shall the compiler generate the call of omp_fulfill_event after __kmpc_omp_task call? Or is it a user code?

Mar 18 2020, 2:08 AM · Restricted Project, Restricted Project

Mar 5 2020

AndreyChurbanov created D75673: [runtime] Fixed hang when explicit task created inside a taskloop..
Mar 5 2020, 4:24 AM · Restricted Project

Mar 4 2020

AndreyChurbanov committed rG95df6747cf19: [openmp] OpenMP 5.1 omp_display_env function implementation. (authored by AndreyChurbanov).
[openmp] OpenMP 5.1 omp_display_env function implementation.
Mar 4 2020, 7:21 AM
AndreyChurbanov closed D74956: OpenMP 5.1 omp_display_env function implementation..
Mar 4 2020, 7:20 AM · Restricted Project

Mar 3 2020

AndreyChurbanov updated the diff for D74956: OpenMP 5.1 omp_display_env function implementation..

Addressed comments: removed "#if 0" code block; added basic checks for the test.

Mar 3 2020, 11:57 AM · Restricted Project

Mar 2 2020

AndreyChurbanov added a comment to D74956: OpenMP 5.1 omp_display_env function implementation..

We can have filechek tests, right? We should verify a bit more than the existence of a function that will return.

Mar 2 2020, 11:36 AM · Restricted Project

Feb 21 2020

AndreyChurbanov updated the diff for D74956: OpenMP 5.1 omp_display_env function implementation..

Addressed Kelvin's comment.

Feb 21 2020, 7:27 AM · Restricted Project
AndreyChurbanov updated the diff for D74956: OpenMP 5.1 omp_display_env function implementation..

Added full context.
Also added (missed) "value" attribute to Fortran interfaces.

Feb 21 2020, 5:29 AM · Restricted Project
AndreyChurbanov created D74956: OpenMP 5.1 omp_display_env function implementation..
Feb 21 2020, 4:53 AM · Restricted Project
AndreyChurbanov accepted D73922: [OpenMP][runtime] Add GOMP 5.0 loop entry points.

LGTM

Feb 21 2020, 4:26 AM · Restricted Project
AndreyChurbanov accepted D74921: Detect and disable openmp tests that require multiple hardware processor to run when only one core is available..

We may need to also loose the internal tough limit of number of threads in the teams construct, which is currently not convenient to overcome. But this needs time to work on..

Feb 21 2020, 3:50 AM · Restricted Project

Jan 23 2020

AndreyChurbanov accepted D73248: [OpenMP] change OMP_ATK_* and OMP_ATV_* enum to lowercase [NFC].

LGTM

Jan 23 2020, 1:16 AM · Restricted Project

Jan 20 2020

AndreyChurbanov added inline comments to D72058: [OpenMP] Enabling CPU affinity on Darwin platform proposal.
Jan 20 2020, 11:31 AM · Restricted Project
AndreyChurbanov added a comment to D72132: [OpenMP] affinity little fix for FreeBSD.

If possible, please also fix typo in FreeBSD-related code on line 289 of z_Linux_util.cpp (< is used instead of comma).

Jan 20 2020, 8:42 AM · Restricted Project

Jan 15 2020

AndreyChurbanov added a comment to D71989: [OpenMP][IRBuilder][WIP] Prototype `omp task` support.

Having a copy function per type allows us to reuse it, otherwise we have one copy function per static task location (at worst). Either works for me I think.

I also would be OK with either option.
But note that using per-type functions will require more additions to the interface, like:

(..., num_objects, array_of_copy_wrappers, array_of_desctuctor_wrappers, array_of_obj_offsets).

Then the library can iterate over objects to copy-construct them, then iterate to destroy them after the task is complete. Without any possibility of inlining of any wrappers.

Jan 15 2020, 10:22 AM · Restricted Project, Restricted Project

Jan 14 2020

AndreyChurbanov added a comment to D71989: [OpenMP][IRBuilder][WIP] Prototype `omp task` support.

the task create and task issue step are
conceptually not separated anymore as it is

I don't think this can work reliably. Because not all C++ objects can be mem-copied.
E.g. an object can keep its own address or reference, and mem-copy will make it broken.
This could be fixed by generating (optional) thunk routine which would create all needed objects
in the library-allocated space, and similar routine which would destroy all the created objects.

Jan 14 2020, 4:00 AM · Restricted Project, Restricted Project

Nov 27 2019

AndreyChurbanov committed rGbd2fb41c2dd5: [openmp] Fixed nonmonotonic schedule when #threads > #chunks in a loop. (authored by AndreyChurbanov).
[openmp] Fixed nonmonotonic schedule when #threads > #chunks in a loop.
Nov 27 2019, 4:29 AM
AndreyChurbanov closed D70713: Fixed nonmonotonic dynamic schedule for case when #threads > #chunks in a loop..
Nov 27 2019, 4:29 AM · Restricted Project

Nov 26 2019

AndreyChurbanov updated the summary of D70713: Fixed nonmonotonic dynamic schedule for case when #threads > #chunks in a loop..
Nov 26 2019, 5:19 AM · Restricted Project
AndreyChurbanov created D70713: Fixed nonmonotonic dynamic schedule for case when #threads > #chunks in a loop..
Nov 26 2019, 5:19 AM · Restricted Project
AndreyChurbanov committed rG5f8b8d282048: [openmp] Recognise ARMv7ve machine arch. (authored by AndreyChurbanov).
[openmp] Recognise ARMv7ve machine arch.
Nov 26 2019, 3:39 AM
AndreyChurbanov closed D68543: openmp: Recognise ARMv7ve machine arch.
Nov 26 2019, 3:39 AM · Restricted Project

Nov 25 2019

AndreyChurbanov accepted D68543: openmp: Recognise ARMv7ve machine arch.

I am not an ARM expert, but don't see any problems with checking extra define here.

Nov 25 2019, 9:58 AM · Restricted Project

Nov 19 2019

AndreyChurbanov committed rG3a76b8a538c0: Fix openmp on PowerPC64-BE-ELFv2 ABI on FreeBSD. (authored by AndreyChurbanov).
Fix openmp on PowerPC64-BE-ELFv2 ABI on FreeBSD.
Nov 19 2019, 8:52 AM
AndreyChurbanov closed D67190: Fix openmp on PowerPC64-BE-ELFv2 ABI on FreeBSD.
Nov 19 2019, 8:52 AM · Restricted Project

Nov 18 2019

AndreyChurbanov accepted D69927: [OpenMP] Remove -Wl,-fini=__kmp_internal_end_fini.

LGTM

Nov 18 2019, 8:27 AM · Restricted Project

Nov 13 2019

AndreyChurbanov added a comment to D69927: [OpenMP] Remove -Wl,-fini=__kmp_internal_end_fini.

I will try removing __kmp_internal_end_fini with a test that __kmp_internal_end_atexit is still called.

Nov 13 2019, 11:00 AM · Restricted Project
AndreyChurbanov added a comment to D65285: [OpenMP] Rename last file to cpp and remove LIBOMP_CFLAGS.

I will contact ittnotify owners just in case. So that we might have lesser burden with possible future updates of this third-party code.

Thanks. Is that open-source or internal to Intel?

It is open-sourced many years ago, now under BSD license; IINM, it can be found at https://github.com/intel/IntelSEAPI/tree/master/ittnotify (though we don't update it regularly without real need);
and it is also part of Intel Tools products (e.g. Amplifier, etc.).

They already agreed to upstream the last change (removal of const). Not sure it will be possible to upstream .c --> .cpp, because they depend on many other customers. But I think this is minor issue for us.

One mode detail - the link I provided is not an "official" location of ittnotify, but just one more usage of it by SEAPI project. The updates of the ittnotify itself were published sporadically. And it will get its own stable location on githab soon (the publishing is in process).

Nov 13 2019, 7:12 AM · Restricted Project, Restricted Project

Nov 7 2019

AndreyChurbanov added a comment to D69927: [OpenMP] Remove -Wl,-fini=__kmp_internal_end_fini.

Looks acceptable to me. As well as removing the kmp_internal_end_fini symbol at all, as it duplicates the functionality of kmp_internal_end_dtor which has attribute "destructor". I am OK with either solution, would be good to hear others opinion.

Nov 7 2019, 7:04 AM · Restricted Project

Oct 30 2019

AndreyChurbanov committed rG27f6eedc57f9: Enable OpenBSD support. (authored by AndreyChurbanov).
Enable OpenBSD support.
Oct 30 2019, 2:40 AM

Oct 25 2019

AndreyChurbanov committed rGbe29d9285487: OpenMP Tasks dependencies hash re-sizing fixed. (authored by AndreyChurbanov).
OpenMP Tasks dependencies hash re-sizing fixed.
Oct 25 2019, 6:08 AM
AndreyChurbanov closed D68036: Tasks dependencies hash re-sizing fixed.
Oct 25 2019, 6:08 AM · Restricted Project

Oct 8 2019

AndreyChurbanov added a comment to D68051: [OpenMP] Don't link libm with -Wl,--as-needed on FreeBSD.

Jan,
you may want to ask for D68045 landing there directly, as compiler-rt is a different project which I don't work on.

Oct 8 2019, 5:56 AM · Restricted Project
AndreyChurbanov committed rGca2973bb2024: Don't assume Type from `readelf -d` has parentheses (authored by AndreyChurbanov).
Don't assume Type from `readelf -d` has parentheses
Oct 8 2019, 5:47 AM
AndreyChurbanov closed D68053: [OpenMP] Don't assume Type from `readelf -d` has parentheses.
Oct 8 2019, 5:46 AM · Restricted Project
AndreyChurbanov committed rGf34271d88690: Don't link libm with -Wl,--as-needed on FreeBSD (authored by AndreyChurbanov).
Don't link libm with -Wl,--as-needed on FreeBSD
Oct 8 2019, 5:29 AM
AndreyChurbanov closed D68051: [OpenMP] Don't link libm with -Wl,--as-needed on FreeBSD.
Oct 8 2019, 5:28 AM · Restricted Project

Sep 27 2019

AndreyChurbanov accepted D67190: Fix openmp on PowerPC64-BE-ELFv2 ABI on FreeBSD.

LGTM

Sep 27 2019, 7:13 AM · Restricted Project
AndreyChurbanov accepted D68053: [OpenMP] Don't assume Type from `readelf -d` has parentheses.

LGTM

Sep 27 2019, 6:59 AM · Restricted Project
AndreyChurbanov accepted D68051: [OpenMP] Don't link libm with -Wl,--as-needed on FreeBSD.

LGTM

Sep 27 2019, 6:07 AM · Restricted Project

Sep 25 2019

AndreyChurbanov created D68036: Tasks dependencies hash re-sizing fixed.
Sep 25 2019, 10:10 AM · Restricted Project
AndreyChurbanov committed rGde44f434e828: fixed test: eliminated race condition which might cause deadlock (authored by AndreyChurbanov).
fixed test: eliminated race condition which might cause deadlock
Sep 25 2019, 8:28 AM
AndreyChurbanov committed rGa1639b9bba7c: Enable tasks dependencies hashmaps resizing. (authored by AndreyChurbanov).
Enable tasks dependencies hashmaps resizing.
Sep 25 2019, 7:40 AM

Sep 16 2019

AndreyChurbanov accepted D67447: Enable tasks dependencies hashmaps resizing.
Sep 16 2019, 9:11 AM · Restricted Project, Restricted Project

Sep 4 2019

AndreyChurbanov accepted D66292: [OpenMP] Change initialization of __kmp_global.

LGTM

Sep 4 2019, 6:42 AM · Restricted Project, Restricted Project

Sep 3 2019

AndreyChurbanov added a comment to D66351: Force runtime to honor nthreads-var and thread-limit-var inside the teams construct on host..

BTW, there is also workaround without runtime patching, - set KMP_TEAMS_THREAD_LIMIT to the same value as OMP_THREAD_LIMIT. This avoids runtime segfault with old library.

Sep 3 2019, 4:26 AM · Restricted Project, Restricted Project

Sep 2 2019

AndreyChurbanov added a comment to D66351: Force runtime to honor nthreads-var and thread-limit-var inside the teams construct on host..

Will this fix make it to the 9.0 release? Thank you!

Sep 2 2019, 8:24 AM · Restricted Project, Restricted Project

Aug 16 2019

AndreyChurbanov created D66351: Force runtime to honor nthreads-var and thread-limit-var inside the teams construct on host..
Aug 16 2019, 7:44 AM · Restricted Project, Restricted Project

Aug 12 2019

AndreyChurbanov committed rG5eec1a9d324f: Cleanup unused variable. (authored by AndreyChurbanov).
Cleanup unused variable.
Aug 12 2019, 5:39 AM

Aug 7 2019

AndreyChurbanov created D65885: Cleanup unused variable..
Aug 7 2019, 8:25 AM · Restricted Project, Restricted Project
AndreyChurbanov added inline comments to D65870: [OpenMP] Remove 'unnecessary parentheses'.
Aug 7 2019, 7:48 AM · Restricted Project, Restricted Project

Aug 6 2019

AndreyChurbanov added a comment to D65285: [OpenMP] Rename last file to cpp and remove LIBOMP_CFLAGS.

For the correct solution, could you point me to code that uses the dll_path_ptr member? Given that there were no problem with static const char dll_path[PATH_MAX] I guess it never assigns to *dll_path_ptr, but then I don't fully understand why it needs a pointer to a pointer...

Aug 6 2019, 5:46 AM · Restricted Project, Restricted Project

Jul 29 2019

AndreyChurbanov added a comment to D65285: [OpenMP] Rename last file to cpp and remove LIBOMP_CFLAGS.

I will contact ittnotify owners just in case. So that we might have lesser burden with possible future updates of this third-party code.

Thanks. Is that open-source or internal to Intel?

Jul 29 2019, 7:54 AM · Restricted Project, Restricted Project

Jul 26 2019

AndreyChurbanov accepted D65285: [OpenMP] Rename last file to cpp and remove LIBOMP_CFLAGS.

I will contact ittnotify owners just in case. So that we might have lesser burden with possible future updates of this third-party code.

Jul 26 2019, 5:03 AM · Restricted Project, Restricted Project

Jul 25 2019

AndreyChurbanov accepted D65284: [OpenMP] Fix build of stubs library.

LGTM (I'd treat this as NFC :).

Jul 25 2019, 9:06 AM · Restricted Project, Restricted Project

Jul 16 2019

AndreyChurbanov accepted D64625: [OpenMP] Move header inclusion out of 'extern "C"'.

LGTM

Jul 16 2019, 9:11 AM · Restricted Project

Jul 12 2019

AndreyChurbanov added inline comments to D64534: Remove OMP spec versioning.
Jul 12 2019, 6:56 AM · Restricted Project, Restricted Project

Jul 10 2019

AndreyChurbanov committed rG28f44040cc43: NFC: fixed typo #ifdef --> #if to allow macro set to 0 work correctly (authored by AndreyChurbanov).
NFC: fixed typo #ifdef --> #if to allow macro set to 0 work correctly
Jul 10 2019, 8:12 AM

Jul 2 2019

AndreyChurbanov committed rGa23806e67a2d: Create a runtime option to disable task throttling. (authored by AndreyChurbanov).
Create a runtime option to disable task throttling.
Jul 2 2019, 8:12 AM
AndreyChurbanov accepted D63196: Create a runtime option to disable task throttling.

LGTM

Jul 2 2019, 8:05 AM · Restricted Project, Restricted Project
AndreyChurbanov committed rGe7b2c64a6e4c: Cleanup of unused code (authored by AndreyChurbanov).
Cleanup of unused code
Jul 2 2019, 6:46 AM

Jun 27 2019

AndreyChurbanov requested changes to D63196: Create a runtime option to disable task throttling.

Of cause you are free to choose your own test, or simply extend existing test(s).

Jun 27 2019, 6:01 AM · Restricted Project, Restricted Project