Page MenuHomePhabricator
Feed Advanced Search

Thu, Jun 25

aleksandr.urakov committed rG895529cfd875: [lldb][PDB] Constexpr static member values as AST literals (authored by aleksandr.urakov).
[lldb][PDB] Constexpr static member values as AST literals
Thu, Jun 25, 1:36 AM
aleksandr.urakov closed D82160: [lldb][PDB] Constexpr static member values as AST literals.
Thu, Jun 25, 1:35 AM · Restricted Project, Restricted Project

Tue, Jun 23

aleksandr.urakov accepted D82160: [lldb][PDB] Constexpr static member values as AST literals.

LGTM, thanks!

Tue, Jun 23, 7:26 AM · Restricted Project, Restricted Project

Mon, Jun 22

aleksandr.urakov added inline comments to D82160: [lldb][PDB] Constexpr static member values as AST literals.
Mon, Jun 22, 4:48 AM · Restricted Project, Restricted Project
aleksandr.urakov added a comment to D82160: [lldb][PDB] Constexpr static member values as AST literals.

Hello! Thanks for the patch, generally it looks good to me, the only thing I worry about is scoped enums (please, see the comment below).

Mon, Jun 22, 3:43 AM · Restricted Project, Restricted Project

Apr 27 2020

aleksandr.urakov committed rG84c398d375d9: [lldb][TypeSystemClang] Desugar an elaborated type before checking if it's a… (authored by aleksandr.urakov).
[lldb][TypeSystemClang] Desugar an elaborated type before checking if it's a…
Apr 27 2020, 1:34 AM
aleksandr.urakov closed D78697: [lldb][TypeSystemClang] Desugar an elaborated type before checking if it's a typedef or getting a typedefed type.
Apr 27 2020, 1:33 AM · Restricted Project
aleksandr.urakov updated the diff for D78697: [lldb][TypeSystemClang] Desugar an elaborated type before checking if it's a typedef or getting a typedefed type.

Exactly! Removed unneeded wrapper.

Apr 27 2020, 1:33 AM · Restricted Project

Apr 24 2020

aleksandr.urakov added a comment to D78697: [lldb][TypeSystemClang] Desugar an elaborated type before checking if it's a typedef or getting a typedefed type.

The problem here is that in the case of success GetCString() returns nullptr, and we fail on concatenation with None even if the expression was evaluated successfully.

Apr 24 2020, 5:54 AM · Restricted Project
aleksandr.urakov updated the diff for D78697: [lldb][TypeSystemClang] Desugar an elaborated type before checking if it's a typedef or getting a typedefed type.

Thanks! Fixed. The only thing is that GetCString() can return nullptr, which leads to None in Python, so I made a simple wrapper for that.

Apr 24 2020, 5:22 AM · Restricted Project

Apr 23 2020

aleksandr.urakov updated the diff for D78697: [lldb][TypeSystemClang] Desugar an elaborated type before checking if it's a typedef or getting a typedefed type.

Hello, Pavel! Thanks for the review. Yes, this method looks like a better fit, I just didn't notice it before.

Apr 23 2020, 3:45 AM · Restricted Project
aleksandr.urakov created D78697: [lldb][TypeSystemClang] Desugar an elaborated type before checking if it's a typedef or getting a typedefed type.
Apr 23 2020, 12:29 AM · Restricted Project

Mar 31 2020

aleksandr.urakov accepted D77000: [LLDB] [PECOFF] Only use PECallFrameInfo on the one supported architecture.

Sorry for the long delay, LGTM now, thanks!

Mar 31 2020, 4:56 AM · Restricted Project

Mar 30 2020

aleksandr.urakov added a comment to D77000: [LLDB] [PECOFF] Only use PECallFrameInfo on the one supported architecture.

Hello! But does the format of an exception directory for aarch64 differ completely from x86-64 one? Can we somehow adopt the existing parser to support it? If we can, I think that this check looks good (we encapsulate the difference inside PECallFrameInfo). Or may be it is worth to make a different parser for aarch64? Then I think the check would look better in ObjectFilePECOFF::CreateEHCallFrameInfo (and then we will choose a right exception directory parser depending on an architecture). What do you think on this?

Mar 30 2020, 12:29 AM · Restricted Project

Oct 28 2019

aleksandr.urakov added a comment to D69503: [LLDB] [Windows] Don't crash if the debugged process is unable to start up.

Sorry, I'm OOO today, so I can't take a precise look on this now. But I'm not sure, isn't race condition possible here on the m_session_data reset?

Oct 28 2019, 7:45 AM · Restricted Project
aleksandr.urakov accepted D69502: [LLDB] [PECOFF] Don't crash in ReadImageDataByRVA for addresses out of range.

LGTM, thank you! Can you send me an example of binary on which unwinding fails with a crash, please? It is a very interesting case...

Oct 28 2019, 7:27 AM · Restricted Project

Oct 15 2019

aleksandr.urakov added a comment to D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans.

@stella.stamenova I've fixed it with r374888, thanks again for pointing to that. The fix of unwind can fix some stepping issues, because stepping logic uses call stack information actively.

Oct 15 2019, 7:30 AM · Restricted Project, Restricted Project
aleksandr.urakov added a comment to D68980: [LLDB] [test] Allow specifying the full arch for msvc/clang-cl in build.py.

@aleksandr.urakov, since you probably know more about windows and these tests than I do, I'd be interested in hearing your thoughts too...

Oct 15 2019, 7:30 AM · Restricted Project
aleksandr.urakov committed rG86d0f8b148bd: [Windows][NFC] Fix tests after r374528. (authored by aleksandr.urakov).
[Windows][NFC] Fix tests after r374528.
Oct 15 2019, 6:58 AM
aleksandr.urakov committed rL374888: [Windows][NFC] Fix tests after r374528..
[Windows][NFC] Fix tests after r374528.
Oct 15 2019, 6:50 AM
aleksandr.urakov added a comment to D68980: [LLDB] [test] Allow specifying the full arch for msvc/clang-cl in build.py.

Sorry, I didn't see Pavel's message. In this case I have no objections to the patch if other people also won't have.

Oct 15 2019, 4:46 AM · Restricted Project
aleksandr.urakov accepted D68980: [LLDB] [test] Allow specifying the full arch for msvc/clang-cl in build.py.

LGTM!

Oct 15 2019, 4:44 AM · Restricted Project

Oct 11 2019

aleksandr.urakov accepted D68864: [LLDB] [lldb-server] Use llvm::InitLLVM for doing unicode conversion of arguments for windows.
Oct 11 2019, 4:20 AM · Restricted Project
aleksandr.urakov added a comment to D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans.

Quick question here; will unwinding using DWARF debug info still work like before after this, for binaries that don't use SEH for exception unwinding?

Oct 11 2019, 2:23 AM · Restricted Project, Restricted Project
aleksandr.urakov committed rG30c2441a3262: [Windows] Use information from the PE32 exceptions directory to construct… (authored by aleksandr.urakov).
[Windows] Use information from the PE32 exceptions directory to construct…
Oct 11 2019, 2:05 AM
aleksandr.urakov committed rL374528: [Windows] Use information from the PE32 exceptions directory to construct….
[Windows] Use information from the PE32 exceptions directory to construct…
Oct 11 2019, 2:05 AM
aleksandr.urakov closed D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans.
Oct 11 2019, 2:05 AM · Restricted Project, Restricted Project

Oct 10 2019

aleksandr.urakov added a comment to D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans.

Thanks a lot for the review!

Oct 10 2019, 10:33 PM · Restricted Project, Restricted Project
aleksandr.urakov committed rG0891366571b2: [Windows] Introduce a switch for the `lldb-server` mode on Windows (authored by aleksandr.urakov).
[Windows] Introduce a switch for the `lldb-server` mode on Windows
Oct 10 2019, 5:23 AM
aleksandr.urakov closed D68258: [Windows] Introduce a switch for the `lldb-server` mode on Windows.
Oct 10 2019, 5:23 AM · Restricted Project
aleksandr.urakov committed rL374325: [Windows] Introduce a switch for the `lldb-server` mode on Windows.
[Windows] Introduce a switch for the `lldb-server` mode on Windows
Oct 10 2019, 5:22 AM

Oct 9 2019

aleksandr.urakov added a comment to D68680: [dsymutil] Fix handling of common symbols in multiple object files..

Hi! Could you choose some other names for com1.o and com2.o, please? :) They are reserved names on Windows, so there are problems with checking out this change.

Oct 9 2019, 1:42 AM · Restricted Project
aleksandr.urakov added a comment to D68258: [Windows] Introduce a switch for the `lldb-server` mode on Windows.

Hello! I am sorry for a delay with reply, I was OOO. Thanks all for the review!

Oct 9 2019, 1:24 AM · Restricted Project

Oct 1 2019

aleksandr.urakov added a comment to D68258: [Windows] Introduce a switch for the `lldb-server` mode on Windows.

I've made it in the way similar to Zachary have made for the SymbolFileNativePDB plugin. An environment variable could be more convenient e.g. to run a bunch of tests using the lldb-test option.

Oct 1 2019, 9:50 PM · Restricted Project
aleksandr.urakov added a comment to D68258: [Windows] Introduce a switch for the `lldb-server` mode on Windows.

I've made it in the way similar to Zachary have made for the SymbolFileNativePDB plugin. An environment variable could be more convenient e.g. to run a bunch of tests using the lldb-test option.

Oct 1 2019, 9:45 PM · Restricted Project

Sep 30 2019

aleksandr.urakov committed rG5b5274eaf8c2: [Windows] Added support of watchpoints to `NativeProcessWindows` (authored by aleksandr.urakov).
[Windows] Added support of watchpoints to `NativeProcessWindows`
Sep 30 2019, 10:54 PM
aleksandr.urakov committed rL373300: [Windows] Added support of watchpoints to `NativeProcessWindows`.
[Windows] Added support of watchpoints to `NativeProcessWindows`
Sep 30 2019, 10:53 PM
aleksandr.urakov closed D67222: [Windows] Added support of watchpoints to `NativeProcessWindows`.
Sep 30 2019, 10:53 PM · Restricted Project, Restricted Project
aleksandr.urakov added a comment to D67222: [Windows] Added support of watchpoints to `NativeProcessWindows`.

Thank you! I've added a switch in a manner similar to one that Zachary has chosen for SymbolFilePDB/NativePDB plugins here: D68258

Sep 30 2019, 10:53 PM · Restricted Project, Restricted Project
aleksandr.urakov created D68258: [Windows] Introduce a switch for the `lldb-server` mode on Windows.
Sep 30 2019, 10:44 PM · Restricted Project

Sep 24 2019

aleksandr.urakov added a comment to D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans.

Gentle ping! What do you think of this?

Sep 24 2019, 10:29 PM · Restricted Project, Restricted Project
aleksandr.urakov updated subscribers of D67954: [LLDB] [Windows] Initial support for ARM64 register contexts.

Have you considered going the "native" route directly? My understanding is that this route is already functional on x86 (modulo watchpoints, which I need to get around to reviewing). It would be great to be able to delete the in-process route soon, as it's not good to have both for a long time, and for that we need to ensure that the lldb-server route does not lag behind in features. I'm not really sure what's needed to enable the lldb-server mechanism, but @aleksandr.urakov should.

Sep 24 2019, 10:25 PM · Restricted Project, Restricted Project
aleksandr.urakov added a reviewer for D67222: [Windows] Added support of watchpoints to `NativeProcessWindows`: labath.

Btw, in the context of D67954, I realized that I don't know how to actually enable the usage of lldb-server in lldb on windows. Can you share how you did that ?

Sep 24 2019, 10:18 PM · Restricted Project, Restricted Project
aleksandr.urakov updated the diff for D67222: [Windows] Added support of watchpoints to `NativeProcessWindows`.

Update the patch due to Pavel's request.

Sep 24 2019, 10:18 PM · Restricted Project, Restricted Project

Sep 13 2019

aleksandr.urakov added a comment to D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans.

Hi Jason, thanks for the review!

Sep 13 2019, 12:17 PM · Restricted Project, Restricted Project
aleksandr.urakov updated the diff for D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans.

Update due to the requests.

Sep 13 2019, 11:00 AM · Restricted Project, Restricted Project

Sep 12 2019

aleksandr.urakov added a comment to D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans.

Thanks all for taking a look!

Sep 12 2019, 1:11 AM · Restricted Project, Restricted Project
aleksandr.urakov updated the diff for D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans.

Update diff due to Pavel's requests.

Sep 12 2019, 1:02 AM · Restricted Project, Restricted Project

Sep 10 2019

aleksandr.urakov added a comment to D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans.

It's a good point, thank you! I had the same thoughts when I done it, but I'm not completely sure. The problem is that an object file can't be completely responsible for choosing an unwind plan, because some plans are produced by symbol files (and an object file knows nothing about that, if I understand right). So we can move only a part of the plan-choosing-functionality from FuncUnwinders to ObjectFiles, but will it be better? In that case both FuncUnwinders and ObjectFiles will be responsible for managing plans, won't it add an additional complexity to the solution?

Sep 10 2019, 6:41 AM · Restricted Project, Restricted Project

Sep 9 2019

aleksandr.urakov updated subscribers of D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans.
Sep 9 2019, 4:46 AM · Restricted Project, Restricted Project
aleksandr.urakov retitled D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans from [Windows] Use EH info from the PE32 exceptions directory to construct unwind plans to [Windows] Use information from the PE32 exceptions directory to construct unwind plans.
Sep 9 2019, 4:46 AM · Restricted Project, Restricted Project
aleksandr.urakov created D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans.
Sep 9 2019, 4:11 AM · Restricted Project, Restricted Project

Sep 5 2019

aleksandr.urakov committed rG6179c0eb0d15: [Windows] Add support of watchpoints to `ProcessWindows` (authored by aleksandr.urakov).
[Windows] Add support of watchpoints to `ProcessWindows`
Sep 5 2019, 10:38 PM
aleksandr.urakov committed rL371166: [Windows] Add support of watchpoints to `ProcessWindows`.
[Windows] Add support of watchpoints to `ProcessWindows`
Sep 5 2019, 10:38 PM
aleksandr.urakov closed D67168: [Windows] Add support of watchpoints to `ProcessWindows`.
Sep 5 2019, 10:37 PM · Restricted Project, Restricted Project
aleksandr.urakov added a comment to D67168: [Windows] Add support of watchpoints to `ProcessWindows`.

Thanks all!

Sep 5 2019, 10:37 PM · Restricted Project, Restricted Project
aleksandr.urakov added inline comments to D67168: [Windows] Add support of watchpoints to `ProcessWindows`.
Sep 5 2019, 5:50 AM · Restricted Project, Restricted Project
aleksandr.urakov updated the diff for D67168: [Windows] Add support of watchpoints to `ProcessWindows`.

Determine whether 8-byte watchpoints are supported or not statically.

Sep 5 2019, 5:28 AM · Restricted Project, Restricted Project
aleksandr.urakov created D67222: [Windows] Added support of watchpoints to `NativeProcessWindows`.
Sep 5 2019, 5:08 AM · Restricted Project, Restricted Project

Sep 4 2019

aleksandr.urakov added inline comments to D67168: [Windows] Add support of watchpoints to `ProcessWindows`.
Sep 4 2019, 10:59 PM · Restricted Project, Restricted Project
aleksandr.urakov updated the diff for D67168: [Windows] Add support of watchpoints to `ProcessWindows`.

Check bitness of the target when checking the watchpoint size.

Sep 4 2019, 10:39 PM · Restricted Project, Restricted Project
aleksandr.urakov updated the diff for D67168: [Windows] Add support of watchpoints to `ProcessWindows`.

Address the requested changes.

Sep 4 2019, 10:18 PM · Restricted Project, Restricted Project
aleksandr.urakov updated the diff for D67168: [Windows] Add support of watchpoints to `ProcessWindows`.

Address the requested changes.

Sep 4 2019, 10:15 PM · Restricted Project, Restricted Project
aleksandr.urakov updated subscribers of D67168: [Windows] Add support of watchpoints to `ProcessWindows`.
Sep 4 2019, 6:42 AM · Restricted Project, Restricted Project
aleksandr.urakov created D67168: [Windows] Add support of watchpoints to `ProcessWindows`.
Sep 4 2019, 6:42 AM · Restricted Project, Restricted Project

Aug 25 2019

aleksandr.urakov accepted D66634: Postfix: move more code out of the PDB plugin.

LGTM, thanks!

Aug 25 2019, 11:39 PM · Restricted Project

Jul 17 2019

aleksandr.urakov accepted D64851: [NativePDB] Add a FromCompilerDecl for going from lldb -> clang.

LGTM!

Jul 17 2019, 12:30 AM · Restricted Project

Jul 16 2019

aleksandr.urakov added a comment to D64660: add a workaround in GetLine to account for ReadFile not reporintg error.

That makes sense, thank you!

Jul 16 2019, 10:26 PM · Restricted Project

Jul 15 2019

aleksandr.urakov added a reviewer for D64689: [NativePDB] Make GetOrCreateDeclForUid return an lldb CompilerDecl: amccarth.
Jul 15 2019, 11:57 PM
aleksandr.urakov accepted D64688: [NativePDB] Make GetTranslationUnitDecl return an lldb CompilerDeclCtx.

LGTM, thanks! Sorry for the long delay with the reply, I had days off.

Jul 15 2019, 11:56 PM
aleksandr.urakov accepted D64689: [NativePDB] Make GetOrCreateDeclForUid return an lldb CompilerDecl.

LGTM! So the other functions (e.g. GetOrCreateDeclContextForUid, GetParentDeclContext etc.) will be also replaced in the future in a corresponding manner?

Jul 15 2019, 11:49 PM
aleksandr.urakov added a comment to D64660: add a workaround in GetLine to account for ReadFile not reporintg error.

I do not fully understand how this works... Does the second fgets sets error to EINTR?

Jul 15 2019, 11:46 PM · Restricted Project

Jul 11 2019

aleksandr.urakov accepted D64615: check for interrupt from fgets on Windows.

LGTM!

Jul 11 2019, 11:41 PM

Jun 18 2019

aleksandr.urakov added inline comments to D63526: [NativePDB] Read inc-link thunks from /* LINKER */ module and create symbols.
Jun 18 2019, 11:25 PM

May 16 2019

aleksandr.urakov accepted D62021: Fix LLDB warnings when compiling with Clang 8.0.

LGTM, thanks!

May 16 2019, 12:37 PM · Restricted Project, Restricted Project
aleksandr.urakov added a comment to D53753: [Windows] Define generic arguments registers for Windows x64.

Ah, yes, sure, it will just be moved on the lldb-server side. Thanks again for the clarification!

May 16 2019, 5:57 AM · Restricted Project, Restricted Project
aleksandr.urakov added a comment to D53753: [Windows] Define generic arguments registers for Windows x64.

When we evaluate an expression, we jit a bunch of opcodes into the inferior memory and then have it execute them. For that to work, we need to allocate some memory in order to store the opcodes. We cannot use the general expression engine to jit that expression, as we would be back to square one, so we manually set the PC to the entry point of the mmap function, and set the argument values as if it was being called. Then we just let the inferior loose and have it allocate the memory for us and return it. For this to work, we need abi knowledge both to correctly set the arguments of mmap, and to retrieve its result.

May 16 2019, 5:44 AM · Restricted Project, Restricted Project
aleksandr.urakov added a comment to D53753: [Windows] Define generic arguments registers for Windows x64.

I'm not sure what exactly are the consequences of not using the correct ABI definition here. I think the case where the difference may start to become obvious is if you try to get argument values of a function for which you don't have debug info for.

It sounds strange to me... If we don't have symbols for a function, then we can't even know amount of its arguments, so how can we retrieve them? Also e.g. on Windows x86 both stdcall, ccall, thiscall and fastcall are commonly used, so it would be strange to use some "default" ABI...

May 16 2019, 4:53 AM · Restricted Project, Restricted Project
aleksandr.urakov added a comment to D53753: [Windows] Define generic arguments registers for Windows x64.

@lanza Hello! AFAIU, these values have nothing to do with the Microsoft x64 calling convention. They are used by ABISysV_x86_64, which specifies ABI for working with code injectable into a process being debugged. It requires six arguments to be passed through registers (see GetArgumentValues).

May 16 2019, 1:15 AM · Restricted Project, Restricted Project

May 13 2019

aleksandr.urakov committed rG7f5318c89258: [NativePDB] Fix tests after r360569 (authored by aleksandr.urakov).
[NativePDB] Fix tests after r360569
May 13 2019, 8:06 AM
aleksandr.urakov committed rL360587: [NativePDB] Fix tests after r360569.
[NativePDB] Fix tests after r360569
May 13 2019, 8:04 AM
aleksandr.urakov committed rLLDB360587: [NativePDB] Fix tests after r360569.
[NativePDB] Fix tests after r360569
May 13 2019, 8:03 AM
aleksandr.urakov committed rG869f934d19f7: [NativePDB] Support member function types in PdbAstBuilder (authored by aleksandr.urakov).
[NativePDB] Support member function types in PdbAstBuilder
May 13 2019, 2:40 AM
aleksandr.urakov committed rLLDB360569: [NativePDB] Support member function types in PdbAstBuilder.
[NativePDB] Support member function types in PdbAstBuilder
May 13 2019, 2:39 AM
aleksandr.urakov committed rL360569: [NativePDB] Support member function types in PdbAstBuilder.
[NativePDB] Support member function types in PdbAstBuilder
May 13 2019, 2:39 AM

Apr 29 2019

aleksandr.urakov committed rLLDB359420: [Windows] Dump more information about access violation exception.
[Windows] Dump more information about access violation exception
Apr 29 2019, 12:32 AM
aleksandr.urakov committed rG26366c3e2cc0: [Windows] Dump more information about access violation exception (authored by aleksandr.urakov).
[Windows] Dump more information about access violation exception
Apr 29 2019, 12:28 AM
aleksandr.urakov committed rL359420: [Windows] Dump more information about access violation exception.
[Windows] Dump more information about access violation exception
Apr 29 2019, 12:27 AM
aleksandr.urakov closed D60519: [Windows] Dump more information about access violation exception.
Apr 29 2019, 12:27 AM · Restricted Project, Restricted Project

Apr 23 2019

aleksandr.urakov accepted D61003: PostfixExpression: move parser out of NativePDB internals.

LGTM, thanks!

Apr 23 2019, 9:41 AM · Restricted Project

Apr 22 2019

aleksandr.urakov committed rGee12a75e388a: [NativePDB] Add anonymous namespaces support (authored by aleksandr.urakov).
[NativePDB] Add anonymous namespaces support
Apr 22 2019, 12:13 AM
aleksandr.urakov committed rLLDB358873: [NativePDB] Add anonymous namespaces support.
[NativePDB] Add anonymous namespaces support
Apr 22 2019, 12:13 AM
aleksandr.urakov committed rL358873: [NativePDB] Add anonymous namespaces support.
[NativePDB] Add anonymous namespaces support
Apr 22 2019, 12:13 AM
aleksandr.urakov closed D60817: [NativePDB] Add anonymous namespaces support.
Apr 22 2019, 12:12 AM · Restricted Project, Restricted Project

Apr 21 2019

aleksandr.urakov added a comment to D60817: [NativePDB] Add anonymous namespaces support.

Thanks for the review! Sorry, I've forgot to include context in the updated patch. Yes, it's exactly the case that is broken, I've left FIXME there until it will be fixed.

Apr 21 2019, 10:35 PM · Restricted Project, Restricted Project

Apr 19 2019

aleksandr.urakov updated subscribers of D60817: [NativePDB] Add anonymous namespaces support.
Apr 19 2019, 12:51 AM · Restricted Project, Restricted Project

Apr 18 2019

aleksandr.urakov updated the diff for D60817: [NativePDB] Add anonymous namespaces support.

Thank you for the comments, I agree with you. I've fixed the patch.

Apr 18 2019, 11:56 PM · Restricted Project, Restricted Project
aleksandr.urakov added inline comments to D60817: [NativePDB] Add anonymous namespaces support.
Apr 18 2019, 11:56 PM · Restricted Project, Restricted Project

Apr 17 2019

aleksandr.urakov created D60817: [NativePDB] Add anonymous namespaces support.
Apr 17 2019, 5:19 AM · Restricted Project, Restricted Project

Apr 14 2019

aleksandr.urakov accepted D60599: Move postfix expression code out of the NativePDB plugin.

Sorry for the long delay with the response, I had days off. LGTM, thanks!

Apr 14 2019, 11:09 PM · Restricted Project